18554889800

Committed 16 Oct 2025 08:17AM UTC coverage: 81.92% (+0.003%) from 81.917%

Build # 18554889800

Build Type

Pull #3582

github

Committed by

web-flow

Commit Message

Merge e35cc7d0d into b94b49611

Pull Request Pull Request #3582: Enable specifying reference direction for azimuthal angle in PolarAzimuthal distribution

Run Details

16596 of 23106 branches covered (71.83%)

Branch coverage included in aggregate %.

28 of 29 new or added lines in 2 files covered. (96.55%)

10 existing lines in 1 file now uncovered.

53739 of 62752 relevant lines covered (85.64%)

43265077.02 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.05

/src/distribution_multi.cpp

#include "openmc/distribution_multi.h"

#include <algorithm> // for move
#include <cmath>     // for sqrt, sin, cos, max

#include "openmc/constants.h"
#include "openmc/error.h"
#include "openmc/math_functions.h"
#include "openmc/random_dist.h"
#include "openmc/random_lcg.h"
#include "openmc/xml_interface.h"

namespace openmc {

unique_ptr<UnitSphereDistribution> UnitSphereDistribution::create(
  pugi::xml_node node)
{
  // Check for type of angular distribution
  std::string type;
  if (check_for_node(node, "type"))
    type = get_node_value(node, "type", true, true);
  if (type == "isotropic") {
    return UPtrAngle {new Isotropic()};
  } else if (type == "monodirectional") {
    return UPtrAngle {new Monodirectional(node)};
  } else if (type == "mu-phi") {
    return UPtrAngle {new PolarAzimuthal(node)};
  } else {
    fatal_error(fmt::format(
      "Invalid angular distribution for external source: {}", type));
  }
}

//==============================================================================
// UnitSphereDistribution implementation
//==============================================================================

UnitSphereDistribution::UnitSphereDistribution(pugi::xml_node node)
{
  // Read reference directional unit vector
  if (check_for_node(node, "reference_uvw")) {
    auto u_ref = get_node_array<double>(node, "reference_uvw");
    if (u_ref.size() != 3)
      fatal_error("Angular distribution reference direction must have "
                  "three parameters specified.");
    u_ref_ = Direction(u_ref.data());
  }
}

//==============================================================================
// PolarAzimuthal implementation
//==============================================================================

PolarAzimuthal::PolarAzimuthal(Direction u, UPtrDist mu, UPtrDist phi)
  : UnitSphereDistribution {u}, mu_ {std::move(mu)}, phi_ {std::move(phi)}
{}

PolarAzimuthal::PolarAzimuthal(pugi::xml_node node)
  : UnitSphereDistribution {node}
{
  // Read reference directional unit vector
  if (check_for_node(node, "reference_vwu")) {
    auto v_ref = get_node_array<double>(node, "reference_vwu");
    if (v_ref.size() != 3)
      fatal_error("Angular distribution reference v direction must have "
                  "three parameters specified.");
    v_ref_ = Direction(v_ref.data());
  }
  w_ref_ = u_ref_.cross(v_ref_);
  if (check_for_node(node, "mu")) {
    pugi::xml_node node_dist = node.child("mu");
    mu_ = distribution_from_xml(node_dist);
  } else {
    mu_ = UPtrDist {new Uniform(-1., 1.)};
  }

  if (check_for_node(node, "phi")) {
    pugi::xml_node node_dist = node.child("phi");
    phi_ = distribution_from_xml(node_dist);
  } else {
    phi_ = UPtrDist {new Uniform(0.0, 2.0 * PI)};
  }
}

Direction PolarAzimuthal::sample(uint64_t* seed) const
{
  // Sample cosine of polar angle
  double mu = mu_->sample(seed);
  if (mu == 1.0)
    return u_ref_;
  if (mu == -1.0)
    return -u_ref_;

  // Sample azimuthal angle
  double phi = phi_->sample(seed);

  double f = std::sqrt(1 - mu * mu);

  return mu * u_ref_ + f * std::cos(phi) * v_ref_ + f * std::sin(phi) * w_ref_;
}

//==============================================================================
// Isotropic implementation
//==============================================================================

Direction isotropic_direction(uint64_t* seed)
{
  double phi = uniform_distribution(0., 2.0 * PI, seed);
  double mu = uniform_distribution(-1., 1., seed);
  return {mu, std::sqrt(1.0 - mu * mu) * std::cos(phi),
    std::sqrt(1.0 - mu * mu) * std::sin(phi)};
}

Direction Isotropic::sample(uint64_t* seed) const
{
  return isotropic_direction(seed);
}

//==============================================================================
// Monodirectional implementation
//==============================================================================

Direction Monodirectional::sample(uint64_t* seed) const
{
  return u_ref_;
}

} // namespace openmc

1	#include "openmc/distribution_multi.h"
2
3	#include <algorithm> // for move
4	#include <cmath> // for sqrt, sin, cos, max
5
6	#include "openmc/constants.h"
7	#include "openmc/error.h"
8	#include "openmc/math_functions.h"
9	#include "openmc/random_dist.h"
10	#include "openmc/random_lcg.h"
11	#include "openmc/xml_interface.h"
12
13	namespace openmc {
14
15	unique_ptr<UnitSphereDistribution> UnitSphereDistribution::create(	3,167✔
16	pugi::xml_node node)
17	{
18	// Check for type of angular distribution
19	std::string type;	3,167✔
20	if (check_for_node(node, "type"))	3,167!
21	type = get_node_value(node, "type", true, true);	3,167✔
22	if (type == "isotropic") {	3,167✔
23	return UPtrAngle {new Isotropic()};	255✔
24	} else if (type == "monodirectional") {	2,912✔
25	return UPtrAngle {new Monodirectional(node)};	2,874✔
26	} else if (type == "mu-phi") {	38!
27	return UPtrAngle {new PolarAzimuthal(node)};	38✔
28	} else {
29	fatal_error(fmt::format(	×
30	"Invalid angular distribution for external source: {}", type));
31	}
32	}	3,167✔
33
34	//==============================================================================
35	// UnitSphereDistribution implementation
36	//==============================================================================
37
38	UnitSphereDistribution::UnitSphereDistribution(pugi::xml_node node)	2,912✔
39	{
40	// Read reference directional unit vector
41	if (check_for_node(node, "reference_uvw")) {	2,912!
42	auto u_ref = get_node_array<double>(node, "reference_uvw");	2,912✔
43	if (u_ref.size() != 3)	2,912!
44	fatal_error("Angular distribution reference direction must have "	×
45	"three parameters specified.");
46	u_ref_ = Direction(u_ref.data());	2,912✔
47	}	2,912✔
48	}	2,912✔
49
50	//==============================================================================
51	// PolarAzimuthal implementation
52	//==============================================================================
53
54	PolarAzimuthal::PolarAzimuthal(Direction u, UPtrDist mu, UPtrDist phi)	×
55	: UnitSphereDistribution {u}, mu_ {std::move(mu)}, phi_ {std::move(phi)}	×
56	{}	×
57
58	PolarAzimuthal::PolarAzimuthal(pugi::xml_node node)	38✔
59	: UnitSphereDistribution {node}	38✔
60	{
61	// Read reference directional unit vector
62	if (check_for_node(node, "reference_vwu")) {	38!
63	auto v_ref = get_node_array<double>(node, "reference_vwu");	38✔
64	if (v_ref.size() != 3)	38!
NEW 65	fatal_error("Angular distribution reference v direction must have "	×
66	"three parameters specified.");
67	v_ref_ = Direction(v_ref.data());	38✔
68	}	38✔
69	w_ref_ = u_ref_.cross(v_ref_);	38✔
70	if (check_for_node(node, "mu")) {	38!
71	pugi::xml_node node_dist = node.child("mu");	38✔
72	mu_ = distribution_from_xml(node_dist);	38✔
73	} else {
74	mu_ = UPtrDist {new Uniform(-1., 1.)};	×
75	}
76
77	if (check_for_node(node, "phi")) {	38!
78	pugi::xml_node node_dist = node.child("phi");	38✔
79	phi_ = distribution_from_xml(node_dist);	38✔
80	} else {
81	phi_ = UPtrDist {new Uniform(0.0, 2.0 * PI)};	×
82	}
83	}	38✔
84
85	Direction PolarAzimuthal::sample(uint64_t* seed) const	25,300✔
86	{
87	// Sample cosine of polar angle
88	double mu = mu_->sample(seed);	25,300✔
89	if (mu == 1.0)	25,300✔
90	return u_ref_;	759✔
91	if (mu == -1.0)	24,541✔
92	return -u_ref_;	1,628✔
93
94	// Sample azimuthal angle
95	double phi = phi_->sample(seed);	22,913✔
96
97	double f = std::sqrt(1 - mu * mu);	22,913✔
98
99	return mu * u_ref_ + f * std::cos(phi) * v_ref_ + f * std::sin(phi) * w_ref_;	22,913✔
100	}
101
102	//==============================================================================
103	// Isotropic implementation
104	//==============================================================================
105
106	Direction isotropic_direction(uint64_t* seed)	111,337,715✔
107	{
108	double phi = uniform_distribution(0., 2.0 * PI, seed);	111,337,715✔
109	double mu = uniform_distribution(-1., 1., seed);	111,337,715✔
110	return {mu, std::sqrt(1.0 - mu * mu) * std::cos(phi),	111,337,715✔
111	std::sqrt(1.0 - mu * mu) * std::sin(phi)};	111,337,715✔
112	}
113
114	Direction Isotropic::sample(uint64_t* seed) const	19,217,561✔
115	{
116	return isotropic_direction(seed);	19,217,561✔
117	}
118
119	//==============================================================================
120	// Monodirectional implementation
121	//==============================================================================
122
123	Direction Monodirectional::sample(uint64_t* seed) const	12,466,094✔
124	{
125	return u_ref_;	12,466,094✔
126	}
127
128	} // namespace openmc

openmc-dev / openmc / 18554889800

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous