#4659

Committed 16 Oct 2025 06:25AM UTC coverage: 36.302% (-0.02%) from 36.323%

Build # #4659

Build Type

push

github

Committed by

topframe

Commit Message

refactor(shell): Improve isInteractive logic with caching and clear separation

Refactor the interactive mode detection logic in the shell console to improve performance and maintainability.

Previously, the `isInteractive()` method performed checks every time it was called. This change introduces a caching mechanism in `AbstractShellConsole` to store the result after the first invocation, avoiding redundant computations.

The logic has been restructured for better separation of concerns:
- `AbstractShellConsole` now handles caching and provides a base `determineInteractive()` method for common checks (e.g., system properties or environment variables for IDEs).
- Subclasses (`DefaultShellConsole` and `JLineShellConsole`) override `determineInteractive()` to add their implementation-specific checks after calling the super method.

 Additionally, Javadoc comments for these methods have been improved to clearly document the new structure and the role of each class.

Coverage Stats

0 of 29 new or added lines in 5 files covered. (0.0%)

2 existing lines in 2 files now uncovered.

15032 of 41408 relevant lines covered (36.3%)

0.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

5.38

/shell/src/main/java/com/aspectran/shell/console/AbstractShellConsole.java

Build SHA Not Found

The commit SHA "1f11fab9edf9c241965032cc3338fc98907950f0" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

aspectran / aspectran / #4659

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous