ProjectOpenSea / opensea-js / 18507247130

push

github

fix: add consideration parameters for criteria offers in generateFulfillmentData (#1769)

* fix: add consideration parameters for criteria offers in generateFulfillmentData

Fixes #1750

This change adds support for passing asset_contract_address and token_id
when generating fulfillment data for criteria offers (e.g., collection offers).

Previously, there was no way to pass these required fields, which caused
the API to return "Consideration is required for criteria offers" error.

Changes:
- Updated generateFulfillmentData to accept optional assetContractAddress and tokenId parameters
- Updated getFulfillOfferPayload and getFulfillListingPayload to include consideration fields
- Updated SDK fulfillOrder method to accept and pass these parameters

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add test for collection offer fulfillment with consideration parameters

- Add test verifying generateFulfillmentData works with consideration parameters for collection offers
- Make test resilient to expired/fulfilled orders from live API

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

120 of 404 branches covered (29.7%)

Branch coverage included in aggregate %.

16 of 22 new or added lines in 2 files covered. (72.73%)

639 of 1127 relevant lines covered (56.7%)

2.08 hits per line