18436453786

Committed 10 Oct 2025 10:13PM UTC coverage: 72.292% (-0.04%) from 72.329%

Build # 18436453786

Build Type

push

github

Committed by

YHNdnzj

Commit Message

pidfd-util: add missing trailing argument for ioctl(PIDFD_GET_*_NAMESPACE)

Otherwise, it always fails with EINVAL.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

330 existing lines in 38 files now uncovered.

303595 of 419954 relevant lines covered (72.29%)

1064618.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.99

/src/basic/pidfd-util.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <linux/fs.h>
#include <linux/magic.h>
#include <sys/ioctl.h>
#include <threads.h>
#include <unistd.h>

#include "errno-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "mountpoint-util.h"
#include "parse-util.h"
#include "pidfd-util.h"
#include "process-util.h"
#include "stat-util.h"
#include "stdio-util.h"
#include "string-util.h"
#include "unaligned.h"

static thread_local int have_pidfs = -1;

int pidfd_check_pidfs(int pid_fd) {

        /* NB: the passed fd *must* be acquired via pidfd_open(), i.e. must be a true pidfd! */

        if (have_pidfs >= 0)
                return have_pidfs;

        _cleanup_close_ int our_fd = -EBADF;
        if (pid_fd < 0) {
                our_fd = pidfd_open(getpid_cached(), /* flags = */ 0);
                if (our_fd < 0)
                        return -errno;

                pid_fd = our_fd;
        }

        return (have_pidfs = fd_is_fs_type(pid_fd, PID_FS_MAGIC));
}

int pidfd_get_namespace(int fd, unsigned long ns_type_cmd) {
        static bool cached_supported = true;

        /* Obtain the namespace fd from pidfd directly through ioctl(PIDFD_GET_*_NAMESPACE).
         *
         * Returns -EOPNOTSUPP if ioctl on pidfds are not supported, -ENOPKG if the requested namespace
         * is disabled in kernel. (The errno used are different from what kernel returns via ioctl(),
         * see below) */

        assert(fd >= 0);

        /* If we know ahead of time that pidfs is unavailable, shortcut things. But otherwise we don't
         * call pidfd_check_pidfs() here, which is kinda extraneous and our own cache is required
         * anyways (pidfs is introduced in kernel 6.9 while ioctl support there is added in 6.11). */
        if (have_pidfs == 0 || !cached_supported)
                return -EOPNOTSUPP;

        int nsfd = ioctl(fd, ns_type_cmd, 0);
        if (nsfd < 0) {
                /* Kernel returns EOPNOTSUPP if the ns type in question is disabled. Hence we need to look
                 * at precise errno instead of generic ERRNO_IS_(IOCTL_)NOT_SUPPORTED. */
                if (IN_SET(errno, ENOTTY, EINVAL)) {
                        cached_supported = false;
                        return -EOPNOTSUPP;
                }
                if (errno == EOPNOTSUPP) /* Translate to something more recognizable */
                        return -ENOPKG;

                return -errno;
        }

        return nsfd;
}

static int pidfd_get_info(int fd, struct pidfd_info *info) {
        static bool cached_supported = true;

        assert(fd >= 0);
        assert(info);

        if (have_pidfs == 0 || !cached_supported)
                return -EOPNOTSUPP;

        if (ioctl(fd, PIDFD_GET_INFO, info) < 0) {
                if (ERRNO_IS_IOCTL_NOT_SUPPORTED(errno)) {
                        cached_supported = false;
                        return -EOPNOTSUPP;
                }

                return -errno;
        }

        return 0;
}

static int pidfd_get_pid_fdinfo(int fd, pid_t *ret) {
        char path[STRLEN("/proc/self/fdinfo/") + DECIMAL_STR_MAX(int)];
        _cleanup_free_ char *p = NULL;
        int r;

        assert(fd >= 0);

        xsprintf(path, "/proc/self/fdinfo/%i", fd);

        r = get_proc_field(path, "Pid", &p);
        if (r == -ENOENT)
                return -EBADF;
        if (r == -ENODATA) /* not a pidfd? */
                return -ENOTTY;
        if (r < 0)
                return r;

        if (streq(p, "0"))
                return -EREMOTE; /* PID is in foreign PID namespace? */
        if (streq(p, "-1"))
                return -ESRCH;   /* refers to reaped process? */

        return parse_pid(p, ret);
}

static int pidfd_get_pid_ioctl(int fd, pid_t *ret) {
        struct pidfd_info info = { .mask = PIDFD_INFO_PID };
        int r;

        assert(fd >= 0);

        r = pidfd_get_info(fd, &info);
        if (r < 0)
                return r;

        assert(FLAGS_SET(info.mask, PIDFD_INFO_PID));

        if (ret)
                *ret = info.pid;
        return 0;
}

int pidfd_get_pid(int fd, pid_t *ret) {
        int r;

        /* Converts a pidfd into a pid. We try ioctl(PIDFD_GET_INFO) (kernel 6.13+) first,
         * /proc/self/fdinfo/ as fallback. Well known errors:
         *
         *    -EBADF   → fd invalid
         *    -ESRCH   → fd valid, but process is already reaped
         *
         * pidfd_get_pid_fdinfo() might additionally fail for other reasons:
         *
         *    -ENOSYS  → /proc/ not mounted
         *    -ENOTTY  → fd valid, but not a pidfd
         *    -EREMOTE → fd valid, but pid is in another namespace we cannot translate to the local one
         *               (when using PIDFD_GET_INFO this is indistinguishable from -ESRCH)
         */

        assert(fd >= 0);

        r = pidfd_get_pid_ioctl(fd, ret);
        if (r != -EOPNOTSUPP)
                return r;

        return pidfd_get_pid_fdinfo(fd, ret);
}

int pidfd_verify_pid(int pidfd, pid_t pid) {
        pid_t current_pid;
        int r;

        assert(pidfd >= 0);
        assert(pid > 0);

        r = pidfd_get_pid(pidfd, &current_pid);
        if (r < 0)
                return r;

        return current_pid != pid ? -ESRCH : 0;
}

int pidfd_get_ppid(int fd, pid_t *ret) {
        struct pidfd_info info = { .mask = PIDFD_INFO_PID };
        int r;

        assert(fd >= 0);

        r = pidfd_get_info(fd, &info);
        if (r < 0)
                return r;

        assert(FLAGS_SET(info.mask, PIDFD_INFO_PID));

        if (info.ppid == 0) /* See comments in pid_get_ppid() */
                return -EADDRNOTAVAIL;

        if (ret)
                *ret = info.ppid;
        return 0;
}

int pidfd_get_uid(int fd, uid_t *ret) {
        struct pidfd_info info = { .mask = PIDFD_INFO_CREDS };
        int r;

        assert(fd >= 0);

        r = pidfd_get_info(fd, &info);
        if (r < 0)
                return r;

        assert(FLAGS_SET(info.mask, PIDFD_INFO_CREDS));

        if (ret)
                *ret = info.ruid;
        return 0;
}

int pidfd_get_cgroupid(int fd, uint64_t *ret) {
        struct pidfd_info info = { .mask = PIDFD_INFO_CGROUPID };
        int r;

        assert(fd >= 0);

        r = pidfd_get_info(fd, &info);
        if (r < 0)
                return r;

        assert(FLAGS_SET(info.mask, PIDFD_INFO_CGROUPID));

        if (ret)
                *ret = info.cgroupid;
        return 0;
}

int pidfd_get_inode_id_impl(int fd, uint64_t *ret) {
        static thread_local bool file_handle_supported = true;
        int r;

        assert(fd >= 0);

        if (file_handle_supported) {
                union {
                        struct file_handle file_handle;
                        uint8_t space[offsetof(struct file_handle, f_handle) + sizeof(uint64_t)];
                } fh = {
                        .file_handle.handle_bytes = sizeof(uint64_t),
                        .file_handle.handle_type = FILEID_KERNFS,
                };
                int mnt_id;

                r = RET_NERRNO(name_to_handle_at(fd, "", &fh.file_handle, &mnt_id, AT_EMPTY_PATH));
                if (r >= 0) {
                        if (ret)
                                /* Note, "struct file_handle" is 32bit aligned usually, but we need to read a 64bit value from it */
                                *ret = unaligned_read_ne64(fh.file_handle.f_handle);
                        return 0;
                }
                assert(r != -EOVERFLOW);
                if (is_name_to_handle_at_fatal_error(r))
                        return r;

                file_handle_supported = false;
        }

#if SIZEOF_INO_T == 8
        struct stat st;
        if (fstat(fd, &st) < 0)
                return -errno;

        if (ret)
                *ret = (uint64_t) st.st_ino;
        return 0;

#elif SIZEOF_INO_T == 4
        /* On 32-bit systems (where sizeof(ino_t) == 4), the inode id returned by fstat() cannot be used to
         * reliably identify the process, nor can we communicate the origin of the id with the clients.
         * Hence let's just refuse to acquire pidfdid through fstat() here. All clients shall also insist on
         * the 64-bit id from name_to_handle_at(). */
        return -EOPNOTSUPP;
#else
#  error Unsupported ino_t size
#endif
}

int pidfd_get_inode_id(int fd, uint64_t *ret) {
        int r;

        assert(fd >= 0);

        r = pidfd_check_pidfs(fd);
        if (r < 0)
                return r;
        if (r == 0)
                return -EOPNOTSUPP;

        return pidfd_get_inode_id_impl(fd, ret);
}

int pidfd_get_inode_id_self_cached(uint64_t *ret) {
        static thread_local uint64_t cached = 0;
        static thread_local pid_t initialized = 0; /* < 0: cached error; == 0: invalid; > 0: valid and pid that was current */
        int r;

        assert(ret);

        if (initialized == getpid_cached()) {
                *ret = cached;
                return 0;
        }
        if (initialized < 0)
                return initialized;

        _cleanup_close_ int fd = pidfd_open(getpid_cached(), 0);
        if (fd < 0)
                return -errno;

        r = pidfd_get_inode_id(fd, &cached);
        if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
                return (initialized = -EOPNOTSUPP);
        if (r < 0)
                return r;

        *ret = cached;
        initialized = getpid_cached();
        return 0;
}

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <linux/fs.h>
4	#include <linux/magic.h>
5	#include <sys/ioctl.h>
6	#include <threads.h>
7	#include <unistd.h>
8
9	#include "errno-util.h"
10	#include "fd-util.h"
11	#include "fileio.h"
12	#include "mountpoint-util.h"
13	#include "parse-util.h"
14	#include "pidfd-util.h"
15	#include "process-util.h"
16	#include "stat-util.h"
17	#include "stdio-util.h"
18	#include "string-util.h"
19	#include "unaligned.h"
20
21	static thread_local int have_pidfs = -1;
22
23	int pidfd_check_pidfs(int pid_fd) {	27,364✔
24
25	/* NB: the passed fd must be acquired via pidfd_open(), i.e. must be a true pidfd! */
26
27	if (have_pidfs >= 0)	27,364✔
28	return have_pidfs;	27,364✔
29
30	_cleanup_close_ int our_fd = -EBADF;	27,364✔
31	if (pid_fd < 0) {	6,931✔
32	our_fd = pidfd_open(getpid_cached(), /* flags = */ 0);	1✔
33	if (our_fd < 0)	1✔
34	return -errno;	×
35
36	pid_fd = our_fd;
37	}
38
39	return (have_pidfs = fd_is_fs_type(pid_fd, PID_FS_MAGIC));	6,931✔
40	}
41
42	int pidfd_get_namespace(int fd, unsigned long ns_type_cmd) {	8,930✔
43	static bool cached_supported = true;	8,930✔
44
45	/* Obtain the namespace fd from pidfd directly through ioctl(PIDFD_GET_*_NAMESPACE).
46	*
47	* Returns -EOPNOTSUPP if ioctl on pidfds are not supported, -ENOPKG if the requested namespace
48	* is disabled in kernel. (The errno used are different from what kernel returns via ioctl(),
49	* see below) */
50
51	assert(fd >= 0);	8,930✔
52
53	/* If we know ahead of time that pidfs is unavailable, shortcut things. But otherwise we don't
54	* call pidfd_check_pidfs() here, which is kinda extraneous and our own cache is required
55	* anyways (pidfs is introduced in kernel 6.9 while ioctl support there is added in 6.11). */
56	if (have_pidfs == 0 \|\| !cached_supported)	8,930✔
57	return -EOPNOTSUPP;
58
59	int nsfd = ioctl(fd, ns_type_cmd, 0);	8,930✔
60	if (nsfd < 0) {	8,930✔
61	/* Kernel returns EOPNOTSUPP if the ns type in question is disabled. Hence we need to look
62	* at precise errno instead of generic ERRNO_IS_(IOCTL_)NOT_SUPPORTED. */
UNCOV 63	if (IN_SET(errno, ENOTTY, EINVAL)) {	×
UNCOV 64	cached_supported = false;	×
UNCOV 65	return -EOPNOTSUPP;	×
66	}
67	if (errno == EOPNOTSUPP) /* Translate to something more recognizable */	×
68	return -ENOPKG;
69
70	return -errno;	×
71	}
72
73	return nsfd;
74	}
75
76	static int pidfd_get_info(int fd, struct pidfd_info *info) {	39,836✔
77	static bool cached_supported = true;	39,836✔
78
79	assert(fd >= 0);	39,836✔
80	assert(info);	39,836✔
81
82	if (have_pidfs == 0 \|\| !cached_supported)	39,836✔
83	return -EOPNOTSUPP;
84
85	if (ioctl(fd, PIDFD_GET_INFO, info) < 0) {	25,385✔
86	if (ERRNO_IS_IOCTL_NOT_SUPPORTED(errno)) {	1,079✔
87	cached_supported = false;	262✔
88	return -EOPNOTSUPP;	262✔
89	}
90
91	return -errno;	817✔
92	}
93
94	return 0;
95	}
96
97	static int pidfd_get_pid_fdinfo(int fd, pid_t *ret) {	13,539✔
98	char path[STRLEN("/proc/self/fdinfo/") + DECIMAL_STR_MAX(int)];	13,539✔
99	_cleanup_free_ char *p = NULL;	13,539✔
100	int r;	13,539✔
101
102	assert(fd >= 0);	13,539✔
103
104	xsprintf(path, "/proc/self/fdinfo/%i", fd);	13,539✔
105
106	r = get_proc_field(path, "Pid", &p);	13,539✔
107	if (r == -ENOENT)	13,539✔
108	return -EBADF;
109	if (r == -ENODATA) /* not a pidfd? */	13,539✔
110	return -ENOTTY;
111	if (r < 0)	13,539✔
112	return r;
113
114	if (streq(p, "0"))	13,539✔
115	return -EREMOTE; /* PID is in foreign PID namespace? */
116	if (streq(p, "-1"))	13,539✔
117	return -ESRCH; /* refers to reaped process? */
118
119	return parse_pid(p, ret);	11,960✔
120	}
121
122	static int pidfd_get_pid_ioctl(int fd, pid_t *ret) {	37,662✔
123	struct pidfd_info info = { .mask = PIDFD_INFO_PID };	37,662✔
124	int r;	37,662✔
125
126	assert(fd >= 0);	37,662✔
127
128	r = pidfd_get_info(fd, &info);	37,662✔
129	if (r < 0)	37,662✔
130	return r;	37,662✔
131
132	assert(FLAGS_SET(info.mask, PIDFD_INFO_PID));	23,306✔
133
134	if (ret)	23,306✔
135	*ret = info.pid;	23,306✔
136	return 0;
137	}
138
139	int pidfd_get_pid(int fd, pid_t *ret) {	37,662✔
140	int r;	37,662✔
141
142	/* Converts a pidfd into a pid. We try ioctl(PIDFD_GET_INFO) (kernel 6.13+) first,
143	* /proc/self/fdinfo/ as fallback. Well known errors:
144	*
145	* -EBADF → fd invalid
146	* -ESRCH → fd valid, but process is already reaped
147	*
148	* pidfd_get_pid_fdinfo() might additionally fail for other reasons:
149	*
150	* -ENOSYS → /proc/ not mounted
151	* -ENOTTY → fd valid, but not a pidfd
152	* -EREMOTE → fd valid, but pid is in another namespace we cannot translate to the local one
153	* (when using PIDFD_GET_INFO this is indistinguishable from -ESRCH)
154	*/
155
156	assert(fd >= 0);	37,662✔
157
158	r = pidfd_get_pid_ioctl(fd, ret);	37,662✔
159	if (r != -EOPNOTSUPP)	37,662✔
160	return r;
161
162	return pidfd_get_pid_fdinfo(fd, ret);	13,539✔
163	}
164
165	int pidfd_verify_pid(int pidfd, pid_t pid) {	20,119✔
166	pid_t current_pid;	20,119✔
167	int r;	20,119✔
168
169	assert(pidfd >= 0);	20,119✔
170	assert(pid > 0);	20,119✔
171
172	r = pidfd_get_pid(pidfd, &current_pid);	20,119✔
173	if (r < 0)	20,119✔
174	return r;	20,119✔
175
176	return current_pid != pid ? -ESRCH : 0;	17,723✔
177	}
178
179	int pidfd_get_ppid(int fd, pid_t *ret) {	2,111✔
180	struct pidfd_info info = { .mask = PIDFD_INFO_PID };	2,111✔
181	int r;	2,111✔
182
183	assert(fd >= 0);	2,111✔
184
185	r = pidfd_get_info(fd, &info);	2,111✔
186	if (r < 0)	2,111✔
187	return r;	2,111✔
188
189	assert(FLAGS_SET(info.mask, PIDFD_INFO_PID));	940✔
190
191	if (info.ppid == 0) /* See comments in pid_get_ppid() */	940✔
192	return -EADDRNOTAVAIL;
193
194	if (ret)	940✔
195	*ret = info.ppid;	940✔
196	return 0;
197	}
198
199	int pidfd_get_uid(int fd, uid_t *ret) {	63✔
200	struct pidfd_info info = { .mask = PIDFD_INFO_CREDS };	63✔
201	int r;	63✔
202
203	assert(fd >= 0);	63✔
204
205	r = pidfd_get_info(fd, &info);	63✔
206	if (r < 0)	63✔
207	return r;	63✔
208
209	assert(FLAGS_SET(info.mask, PIDFD_INFO_CREDS));	60✔
210
211	if (ret)	60✔
212	*ret = info.ruid;	60✔
213	return 0;
214	}
215
216	int pidfd_get_cgroupid(int fd, uint64_t *ret) {	×
217	struct pidfd_info info = { .mask = PIDFD_INFO_CGROUPID };	×
218	int r;	×
219
220	assert(fd >= 0);	×
221
222	r = pidfd_get_info(fd, &info);	×
223	if (r < 0)	×
224	return r;	×
225
226	assert(FLAGS_SET(info.mask, PIDFD_INFO_CGROUPID));	×
227
228	if (ret)	×
229	*ret = info.cgroupid;	×
230	return 0;
231	}
232
233	int pidfd_get_inode_id_impl(int fd, uint64_t *ret) {	27,363✔
234	static thread_local bool file_handle_supported = true;	27,363✔
235	int r;	27,363✔
236
237	assert(fd >= 0);	27,363✔
238
239	if (file_handle_supported) {	27,363✔
240	union {	25,137✔
241	struct file_handle file_handle;
242	uint8_t space[offsetof(struct file_handle, f_handle) + sizeof(uint64_t)];
243	} fh = {	25,137✔
244	.file_handle.handle_bytes = sizeof(uint64_t),
245	.file_handle.handle_type = FILEID_KERNFS,
246	};
247	int mnt_id;	25,137✔
248
249	r = RET_NERRNO(name_to_handle_at(fd, "", &fh.file_handle, &mnt_id, AT_EMPTY_PATH));	25,137✔
250	if (r >= 0) {	1,411✔
251	if (ret)	23,726✔
252	/* Note, "struct file_handle" is 32bit aligned usually, but we need to read a 64bit value from it */
253	*ret = unaligned_read_ne64(fh.file_handle.f_handle);	23,726✔
254	return 0;	23,726✔
255	}
256	assert(r != -EOVERFLOW);	1,411✔
257	if (is_name_to_handle_at_fatal_error(r))	1,411✔
258	return r;
259
260	file_handle_supported = false;	1,411✔
261	}
262
263	#if SIZEOF_INO_T == 8
264	struct stat st;	3,637✔
265	if (fstat(fd, &st) < 0)	3,637✔
266	return -errno;	×
267
268	if (ret)	3,637✔
269	*ret = (uint64_t) st.st_ino;	3,636✔
270	return 0;
271
272	#elif SIZEOF_INO_T == 4
273	/* On 32-bit systems (where sizeof(ino_t) == 4), the inode id returned by fstat() cannot be used to
274	* reliably identify the process, nor can we communicate the origin of the id with the clients.
275	* Hence let's just refuse to acquire pidfdid through fstat() here. All clients shall also insist on
276	* the 64-bit id from name_to_handle_at(). */
277	return -EOPNOTSUPP;
278	#else
279	# error Unsupported ino_t size
280	#endif
281	}
282
283	int pidfd_get_inode_id(int fd, uint64_t *ret) {	27,362✔
284	int r;	27,362✔
285
286	assert(fd >= 0);	27,362✔
287
288	r = pidfd_check_pidfs(fd);	27,362✔
289	if (r < 0)	27,362✔
290	return r;
291	if (r == 0)	27,362✔
292	return -EOPNOTSUPP;
293
294	return pidfd_get_inode_id_impl(fd, ret);	27,362✔
295	}
296
297	int pidfd_get_inode_id_self_cached(uint64_t *ret) {	26,878✔
298	static thread_local uint64_t cached = 0;	26,878✔
299	static thread_local pid_t initialized = 0; /* < 0: cached error; == 0: invalid; > 0: valid and pid that was current */	26,878✔
300	int r;	26,878✔
301
302	assert(ret);	26,878✔
303
304	if (initialized == getpid_cached()) {	26,878✔
305	*ret = cached;	4,802✔
306	return 0;	4,802✔
307	}
308	if (initialized < 0)	22,076✔
309	return initialized;
310
311	_cleanup_close_ int fd = pidfd_open(getpid_cached(), 0);	48,954✔
312	if (fd < 0)	22,076✔
313	return -errno;	×
314
315	r = pidfd_get_inode_id(fd, &cached);	22,076✔
316	if (ERRNO_IS_NEG_NOT_SUPPORTED(r))	22,076✔
317	return (initialized = -EOPNOTSUPP);	×
318	if (r < 0)	22,076✔
319	return r;
320
321	*ret = cached;	22,076✔
322	initialized = getpid_cached();	22,076✔
323	return 0;	22,076✔
324	}

systemd / systemd / 18436453786

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous