18343625207

Committed 08 Oct 2025 11:48AM UTC coverage: 24.542% (-0.02%) from 24.561%

Build # 18343625207

Build Type

push

github

Committed by

web-flow

Commit Message

fix(state): object mapper on delete operation (#7447)

fixes #7434

Run Details

1 of 49 new or added lines in 2 files covered. (2.04%)

7084 existing lines in 207 files now uncovered.

14004 of 57061 relevant lines covered (24.54%)

26.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.67

/src/JsonSchema/ResourceMetadataTrait.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\JsonSchema;

use ApiPlatform\Metadata\CollectionOperationInterface;
use ApiPlatform\Metadata\Exception\OperationNotFoundException;
use ApiPlatform\Metadata\HttpOperation;
use ApiPlatform\Metadata\Operation;
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
use ApiPlatform\Metadata\Util\ResourceClassInfoTrait;

/**
 * @internal
 */
trait ResourceMetadataTrait
{
    use ResourceClassInfoTrait;

    private function findOutputClass(string $className, string $type, Operation $operation, ?array $serializerContext): ?string
    {
        $inputOrOutput = ['class' => $className];
        $inputOrOutput = Schema::TYPE_OUTPUT === $type ? ($operation->getOutput() ?? $inputOrOutput) : ($operation->getInput() ?? $inputOrOutput);
        $forceSubschema = $serializerContext[SchemaFactory::FORCE_SUBSCHEMA] ?? false;

        return $forceSubschema ? ($inputOrOutput['class'] ?? $inputOrOutput->class ?? $operation->getClass()) : ($inputOrOutput['class'] ?? $inputOrOutput->class ?? null);
    }

    private function findOperation(string $className, string $type, ?Operation $operation, ?array $serializerContext, ?string $format = null): Operation
    {
        if (null === $operation) {
            if (null === $this->resourceMetadataFactory) {
                return new HttpOperation();
            }
            $resourceMetadataCollection = $this->resourceMetadataFactory->create($className);

            try {
                $operation = $resourceMetadataCollection->getOperation();
            } catch (OperationNotFoundException $e) {
                $operation = new HttpOperation();
            }
            $forceSubschema = $serializerContext[SchemaFactory::FORCE_SUBSCHEMA] ?? false;
            if ($operation->getShortName() === $this->getShortClassName($className) && $forceSubschema) {
                $operation = new HttpOperation();
            }

            return $this->findOperationForType($resourceMetadataCollection, $type, $operation, $forceSubschema ? null : $format);
        }

        // The best here is to use an Operation when calling `buildSchema`, we try to do a smart guess otherwise
        if ($this->resourceMetadataFactory && !$operation->getClass()) {
            $resourceMetadataCollection = $this->resourceMetadataFactory->create($className);

            if ($operation->getName()) {
                return $resourceMetadataCollection->getOperation($operation->getName());
            }

            return $this->findOperationForType($resourceMetadataCollection, $type, $operation, $format);
        }

        return $operation;
    }

    private function findOperationForType(ResourceMetadataCollection $resourceMetadataCollection, string $type, Operation $operation, ?string $format = null): Operation
    {
        $lookForCollection = $operation instanceof CollectionOperationInterface;
        // Find the operation and use the first one that matches criterias
        foreach ($resourceMetadataCollection as $resourceMetadata) {
            foreach ($resourceMetadata->getOperations() ?? [] as $op) {
                if (!$lookForCollection && $op instanceof CollectionOperationInterface) {
                    continue;
                }

                if (Schema::TYPE_INPUT === $type && \in_array($op->getMethod(), ['POST', 'PATCH', 'PUT'], true)) {
                    $operation = $op;
                    break 2;
                }

                if ($format && Schema::TYPE_OUTPUT === $type && \array_key_exists($format, $op->getOutputFormats() ?? [])) {
                    $operation = $op;
                    break 2;
                }
            }
        }

        return $operation;
    }

    private function getSerializerContext(Operation $operation, string $type = Schema::TYPE_OUTPUT): array
    {
        return Schema::TYPE_OUTPUT === $type ? ($operation->getNormalizationContext() ?? []) : ($operation->getDenormalizationContext() ?? []);
    }

    private function getShortClassName(string $fullyQualifiedName): string
    {
        $parts = explode('\\', $fullyQualifiedName);

        return end($parts);
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\JsonSchema;
15
16	use ApiPlatform\Metadata\CollectionOperationInterface;
17	use ApiPlatform\Metadata\Exception\OperationNotFoundException;
18	use ApiPlatform\Metadata\HttpOperation;
19	use ApiPlatform\Metadata\Operation;
20	use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
21	use ApiPlatform\Metadata\Util\ResourceClassInfoTrait;
22
23	/**
24	* @internal
25	*/
26	trait ResourceMetadataTrait
27	{
28	use ResourceClassInfoTrait;
29
30	private function findOutputClass(string $className, string $type, Operation $operation, ?array $serializerContext): ?string
31	{
UNCOV 32	$inputOrOutput = ['class' => $className];	152✔
UNCOV 33	$inputOrOutput = Schema::TYPE_OUTPUT === $type ? ($operation->getOutput() ?? $inputOrOutput) : ($operation->getInput() ?? $inputOrOutput);	152✔
UNCOV 34	$forceSubschema = $serializerContext[SchemaFactory::FORCE_SUBSCHEMA] ?? false;	152✔
35
UNCOV 36	return $forceSubschema ? ($inputOrOutput['class'] ?? $inputOrOutput->class ?? $operation->getClass()) : ($inputOrOutput['class'] ?? $inputOrOutput->class ?? null);	152✔
37	}
38
39	private function findOperation(string $className, string $type, ?Operation $operation, ?array $serializerContext, ?string $format = null): Operation
40	{
UNCOV 41	if (null === $operation) {	152✔
UNCOV 42	if (null === $this->resourceMetadataFactory) {	106✔
43	return new HttpOperation();	×
44	}
UNCOV 45	$resourceMetadataCollection = $this->resourceMetadataFactory->create($className);	106✔
46
47	try {
UNCOV 48	$operation = $resourceMetadataCollection->getOperation();	106✔
49	} catch (OperationNotFoundException $e) {	×
50	$operation = new HttpOperation();	×
51	}
UNCOV 52	$forceSubschema = $serializerContext[SchemaFactory::FORCE_SUBSCHEMA] ?? false;	106✔
UNCOV 53	if ($operation->getShortName() === $this->getShortClassName($className) && $forceSubschema) {	106✔
UNCOV 54	$operation = new HttpOperation();	66✔
55	}
56
UNCOV 57	return $this->findOperationForType($resourceMetadataCollection, $type, $operation, $forceSubschema ? null : $format);	106✔
58	}
59
60	// The best here is to use an Operation when calling `buildSchema`, we try to do a smart guess otherwise
UNCOV 61	if ($this->resourceMetadataFactory && !$operation->getClass()) {	136✔
UNCOV 62	$resourceMetadataCollection = $this->resourceMetadataFactory->create($className);	62✔
63
UNCOV 64	if ($operation->getName()) {	62✔
UNCOV 65	return $resourceMetadataCollection->getOperation($operation->getName());	16✔
66	}
67
UNCOV 68	return $this->findOperationForType($resourceMetadataCollection, $type, $operation, $format);	46✔
69	}
70
UNCOV 71	return $operation;	126✔
72	}
73
74	private function findOperationForType(ResourceMetadataCollection $resourceMetadataCollection, string $type, Operation $operation, ?string $format = null): Operation
75	{
UNCOV 76	$lookForCollection = $operation instanceof CollectionOperationInterface;	106✔
77	// Find the operation and use the first one that matches criterias
UNCOV 78	foreach ($resourceMetadataCollection as $resourceMetadata) {	106✔
UNCOV 79	foreach ($resourceMetadata->getOperations() ?? [] as $op) {	106✔
UNCOV 80	if (!$lookForCollection && $op instanceof CollectionOperationInterface) {	106✔
UNCOV 81	continue;	78✔
82	}
83
UNCOV 84	if (Schema::TYPE_INPUT === $type && \in_array($op->getMethod(), ['POST', 'PATCH', 'PUT'], true)) {	106✔
UNCOV 85	$operation = $op;	36✔
UNCOV 86	break 2;	36✔
87	}
88
UNCOV 89	if ($format && Schema::TYPE_OUTPUT === $type && \array_key_exists($format, $op->getOutputFormats() ?? [])) {	106✔
UNCOV 90	$operation = $op;	86✔
UNCOV 91	break 2;	86✔
92	}
93	}
94	}
95
UNCOV 96	return $operation;	106✔
97	}
98
99	private function getSerializerContext(Operation $operation, string $type = Schema::TYPE_OUTPUT): array
100	{
UNCOV 101	return Schema::TYPE_OUTPUT === $type ? ($operation->getNormalizationContext() ?? []) : ($operation->getDenormalizationContext() ?? []);	108✔
102	}
103
104	private function getShortClassName(string $fullyQualifiedName): string
105	{
UNCOV 106	$parts = explode('\\', $fullyQualifiedName);	106✔
107
UNCOV 108	return end($parts);	106✔
109	}
110	}

api-platform / core / 18343625207

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous