18250393962

Committed 04 Oct 2025 10:31PM UTC coverage: 73.966% (-0.7%) from 74.699%

Build # 18250393962

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #273 from OneBusAway/refactor/map-state-simplification

Refactor/map-state-simplification

Run Details

839 of 957 branches covered (87.67%)

Branch coverage included in aggregate %.

10 of 159 new or added lines in 9 files covered. (6.29%)

9 existing lines in 4 files now uncovered.

6687 of 9218 relevant lines covered (72.54%)

1.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/components/MapContainer.svelte

<script>
        import '$lib/i18n.js';
        import MapView from './map/MapView.svelte';
        import GoogleMapProvider from '$lib/Provider/GoogleMapProvider.svelte';
        import OpenStreetMapProvider from '$lib/Provider/OpenStreetMapProvider.svelte';
        import FullPageLoadingSpinner from '$components/FullPageLoadingSpinner.svelte';
        import { env } from '$env/dynamic/public';
        import { PUBLIC_OBA_MAP_PROVIDER } from '$env/static/public';
        import { onMount } from 'svelte';
        import { MapSource } from './../config/mapSource.js';

        let apiKey = env.PUBLIC_OBA_GOOGLE_MAPS_API_KEY;
        let { handleStopMarkerSelect, mapProvider = $bindable(), stop, ...restProps } = $props();

        onMount(() => {
                if (PUBLIC_OBA_MAP_PROVIDER === MapSource.Google) {
                        mapProvider = new GoogleMapProvider(apiKey, handleStopMarkerSelect);
                } else if (PUBLIC_OBA_MAP_PROVIDER === MapSource.OpenStreetMap) {
                        mapProvider = new OpenStreetMapProvider(handleStopMarkerSelect);
                } else {
                        console.error('Unknown map provider:');
                }
        });
</script>

{#if mapProvider}
        <MapView {handleStopMarkerSelect} {mapProvider} {stop} {...restProps} />
{:else}
        <FullPageLoadingSpinner />
{/if}

1	<script>	×
2	import '$lib/i18n.js';
3	import MapView from './map/MapView.svelte';
4	import GoogleMapProvider from '$lib/Provider/GoogleMapProvider.svelte';
5	import OpenStreetMapProvider from '$lib/Provider/OpenStreetMapProvider.svelte';
6	import FullPageLoadingSpinner from '$components/FullPageLoadingSpinner.svelte';
7	import { env } from '$env/dynamic/public';
8	import { PUBLIC_OBA_MAP_PROVIDER } from '$env/static/public';
9	import { onMount } from 'svelte';
10	import { MapSource } from './../config/mapSource.js';
11
12	let apiKey = env.PUBLIC_OBA_GOOGLE_MAPS_API_KEY;	×
NEW 13	let { handleStopMarkerSelect, mapProvider = $bindable(), stop, ...restProps } = $props();	×
14
15	onMount(() => {	×
16	if (PUBLIC_OBA_MAP_PROVIDER === MapSource.Google) {	×
17	mapProvider = new GoogleMapProvider(apiKey, handleStopMarkerSelect);	×
18	} else if (PUBLIC_OBA_MAP_PROVIDER === MapSource.OpenStreetMap) {	×
19	mapProvider = new OpenStreetMapProvider(handleStopMarkerSelect);	×
20	} else {
21	console.error('Unknown map provider:');	×
22	}
23	});
24	</script>
25
26	{#if mapProvider}	×
NEW 27	<MapView {handleStopMarkerSelect} {mapProvider} {stop} {...restProps} />	×
28	{:else}
29	<FullPageLoadingSpinner />
30	{/if}

OneBusAway / wayfinder / 18250393962

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous