KeRNeLith / ImmediateReflection / 301

Committed 01 Oct 2025 07:29PM UTC coverage: 99.099% (-0.6%) from 99.738%

Build # 301

Build Type

push

appveyor

Committed by

KeRNeLith

Commit Message

Add a custom hashcode implementation on PropertyInfo usage as key for .NET targets as there is a regression on them.

See https://github.com/dotnet/runtime/issues/114280.

Run Details

770 of 777 relevant lines covered (99.1%)

250.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.86

/src/ImmediateReflection/Cache/MemoryCache.cs

﻿using System;
using System.Collections;
using System.Diagnostics;
using JetBrains.Annotations;

namespace ImmediateReflection
{
    /// <summary>
    /// Represents a type that implements a memory cache.
    /// </summary>
    /// <typeparam name="TKey">Cache key type.</typeparam>
    /// <typeparam name="TValue">Cache value type.</typeparam>
    internal sealed class MemoryCache<TKey, TValue>
        where TValue : class
    {
        [NotNull]
        private readonly Hashtable _cache;

        public MemoryCache(IEqualityComparer comparer = null)
        {
            _cache = new Hashtable(comparer);
        }

        /// <summary>
        /// Gets the cached value corresponding to the given <paramref name="key"/> if already cached, or creates
        /// a new entry if not available.
        /// </summary>
        /// <param name="key">Cache key.</param>
        /// <param name="valueFactory">Factory method to create the value if it does not exist.</param>
        /// <returns>The value.</returns>
        [NotNull]
        [ContractAnnotation("key:null => halt;valueFactory:null => halt")]
        public TValue GetOrCreate([NotNull] TKey key, [NotNull, InstantHandle] Func<TValue> valueFactory)
        {
            Debug.Assert(key != null);
            Debug.Assert(valueFactory != null);

            // ReSharper disable once InconsistentlySynchronizedField, Justification: HashTable is thread safe for reading
            var cachedValue = (TValue)_cache[key];
            if (cachedValue != null)
                return cachedValue;

            lock (_cache)
            {
                // Double check (init during lock wait)
                cachedValue = (TValue)_cache[key];
                if (cachedValue != null)
                    return cachedValue;

                cachedValue = valueFactory();
                _cache[key] = cachedValue;
                return cachedValue;
            }
        }
    }
}

1	using System;
2	using System.Collections;
3	using System.Diagnostics;
4	using JetBrains.Annotations;
5
6	namespace ImmediateReflection
7	{
8	/// <summary>
9	/// Represents a type that implements a memory cache.
10	/// </summary>
11	/// <typeparam name="TKey">Cache key type.</typeparam>
12	/// <typeparam name="TValue">Cache value type.</typeparam>
13	internal sealed class MemoryCache<TKey, TValue>
14	where TValue : class
15	{
16	[NotNull]
17	private readonly Hashtable _cache;
18
19	public MemoryCache(IEqualityComparer comparer = null)	6✔
20	{
21	_cache = new Hashtable(comparer);	6✔
22	}	6✔
23
24	/// <summary>
25	/// Gets the cached value corresponding to the given <paramref name="key"/> if already cached, or creates
26	/// a new entry if not available.
27	/// </summary>
28	/// <param name="key">Cache key.</param>
29	/// <param name="valueFactory">Factory method to create the value if it does not exist.</param>
30	/// <returns>The value.</returns>
31	[NotNull]
32	[ContractAnnotation("key:null => halt;valueFactory:null => halt")]
33	public TValue GetOrCreate([NotNull] TKey key, [NotNull, InstantHandle] Func<TValue> valueFactory)
34	{
35	Debug.Assert(key != null);
36	Debug.Assert(valueFactory != null);
37
38	// ReSharper disable once InconsistentlySynchronizedField, Justification: HashTable is thread safe for reading
39	var cachedValue = (TValue)_cache[key];	6,097✔
40	if (cachedValue != null)	6,097✔
41	return cachedValue;	5,171✔
42
43	lock (_cache)	926✔
44	{
45	// Double check (init during lock wait)
46	cachedValue = (TValue)_cache[key];	926✔
47	if (cachedValue != null)	926✔
48	return cachedValue;	×
49
50	cachedValue = valueFactory();	926✔
51	_cache[key] = cachedValue;	926✔
52	return cachedValue;	926✔
53	}
54	}	926✔
55	}
56	}

KeRNeLith / ImmediateReflection / 301

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous