18089958695

Committed 29 Sep 2025 07:57AM UTC coverage: 21.569% (-0.2%) from 21.797%

Build # 18089958695

Build Type

push

github

Committed by

web-flow

Commit Message

fix(openapi): define items type for HydraCollectionBaseSchema hydra:member (#7419)

Co-authored-by: Thibaut Cholley <thibaut.cholley@elsie-sante.fr>

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

12063 existing lines in 401 files now uncovered.

11765 of 54545 relevant lines covered (21.57%)

12.57 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.74

/src/Metadata/Resource/Factory/FormatsResourceMetadataCollectionFactory.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Metadata\Resource\Factory;

use ApiPlatform\Metadata\CollectionOperationInterface;
use ApiPlatform\Metadata\ErrorResource;
use ApiPlatform\Metadata\Exception\InvalidArgumentException;
use ApiPlatform\Metadata\Exception\ResourceClassNotFoundException;
use ApiPlatform\Metadata\HttpOperation;
use ApiPlatform\Metadata\Operations;
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;

/**
 * Normalizes enabled formats.
 *
 * Formats hierarchy:
 * * resource formats
 *   * resource input/output formats
 *     * operation formats
 *       * operation input/output formats
 *
 * @author Kévin Dunglas <dunglas@gmail.com>
 */
final class FormatsResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
{
    public function __construct(
        private readonly ResourceMetadataCollectionFactoryInterface $decorated,
        private readonly array $formats,
        private readonly array $patchFormats,
        private readonly ?array $errorFormats = null,
    ) {
    }

    /**
     * Adds the formats attributes.
     *
     * @see UriTemplateResourceMetadataCollectionFactory
     *
     * @throws ResourceClassNotFoundException
     */
    public function create(string $resourceClass): ResourceMetadataCollection
    {
        $resourceMetadataCollection = $this->decorated->create($resourceClass);

        foreach ($resourceMetadataCollection as $index => $resourceMetadata) {
            $rawResourceFormats = $resourceMetadata->getFormats();
            $resourceFormats = null === $rawResourceFormats ? $this->formats : $this->normalizeFormats($rawResourceFormats);
            $resourceInputFormats = $resourceMetadata->getInputFormats() ? $this->normalizeFormats($resourceMetadata->getInputFormats()) : $resourceFormats;
            $resourceOutputFormats = $resourceMetadata->getOutputFormats() ? $this->normalizeFormats($resourceMetadata->getOutputFormats()) : $resourceFormats;
            if ($resourceMetadata instanceof ErrorResource) {
                $resourceOutputFormats = $resourceMetadata->getOutputFormats() ? $this->normalizeFormats($resourceMetadata->getOutputFormats()) : ($this->errorFormats ?? []);
            }

            $resourceMetadataCollection[$index] = $resourceMetadataCollection[$index]->withOperations($this->normalize($resourceInputFormats, $resourceOutputFormats, $resourceMetadata->getOperations()));
        }

        return $resourceMetadataCollection;
    }

    /**
     * @param Operations<HttpOperation> $operations
     */
    private function normalize(array $resourceInputFormats, array $resourceOutputFormats, Operations $operations): Operations
    {
        $newOperations = [];
        $patchFormats = null;
        foreach ($operations as $operationName => $operation) {
            if ($operation->getFormats()) {
                $operation = $operation->withFormats($this->normalizeFormats($operation->getFormats()));
            }

            if (($isPatch = 'PATCH' === $operation->getMethod()) && !$operation->getFormats() && !$operation->getInputFormats()) {
                $operation = $operation->withInputFormats($this->patchFormats);
            }

            $operation = $operation->withInputFormats($operation->getInputFormats() ? $this->normalizeFormats($operation->getInputFormats()) : $operation->getFormats() ?? $resourceInputFormats);
            $operation = $operation->withOutputFormats($operation->getOutputFormats() ? $this->normalizeFormats($operation->getOutputFormats()) : $operation->getFormats() ?? $resourceOutputFormats);

            if ($isPatch) {
                $patchFormats = $operation->getInputFormats();
            }

            $newOperations[$operationName] = $operation;
        }

        if (!$patchFormats) {
            return new Operations($newOperations);
        }

        // Prepare an Accept-Patch header
        foreach ($newOperations as $operationName => $operation) {
            if ($operation instanceof CollectionOperationInterface) {
                continue;
            }

            $patchMimeTypes = [];

            foreach ($patchFormats as $mimeTypes) {
                foreach ($mimeTypes as $mimeType) {
                    $patchMimeTypes[] = $mimeType;
                }
            }

            $newOperations[$operationName] = $operation->withAcceptPatch(implode(', ', $patchMimeTypes));
        }

        return new Operations($newOperations);
    }

    /**
     * @throws InvalidArgumentException
     */
    private function normalizeFormats(array|string $currentFormats): array
    {
        $currentFormats = (array) $currentFormats;

        $normalizedFormats = [];
        foreach ($currentFormats as $format => $value) {
            if (!is_numeric($format)) {
                $normalizedFormats[$format] = (array) $value;
                continue;
            }
            if (!\is_string($value)) {
                throw new InvalidArgumentException(\sprintf("The 'formats' attributes value must be a string when trying to include an already configured format, %s given.", \gettype($value)));
            }
            if (\array_key_exists($value, $this->formats)) {
                $normalizedFormats[$value] = $this->formats[$value];
                continue;
            }

            throw new InvalidArgumentException(\sprintf("You either need to add the format '%s' to your project configuration or declare a mime type for it in your annotation.", $value));
        }

        return $normalizedFormats;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Metadata\Resource\Factory;
15
16	use ApiPlatform\Metadata\CollectionOperationInterface;
17	use ApiPlatform\Metadata\ErrorResource;
18	use ApiPlatform\Metadata\Exception\InvalidArgumentException;
19	use ApiPlatform\Metadata\Exception\ResourceClassNotFoundException;
20	use ApiPlatform\Metadata\HttpOperation;
21	use ApiPlatform\Metadata\Operations;
22	use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
23
24	/**
25	* Normalizes enabled formats.
26	*
27	* Formats hierarchy:
28	* * resource formats
29	* * resource input/output formats
30	* * operation formats
31	* * operation input/output formats
32	*
33	* @author Kévin Dunglas <dunglas@gmail.com>
34	*/
35	final class FormatsResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
36	{
37	public function __construct(
38	private readonly ResourceMetadataCollectionFactoryInterface $decorated,
39	private readonly array $formats,
40	private readonly array $patchFormats,
41	private readonly ?array $errorFormats = null,
42	) {
UNCOV 43	}	362✔
44
45	/**
46	* Adds the formats attributes.
47	*
48	* @see UriTemplateResourceMetadataCollectionFactory
49	*
50	* @throws ResourceClassNotFoundException
51	*/
52	public function create(string $resourceClass): ResourceMetadataCollection
53	{
UNCOV 54	$resourceMetadataCollection = $this->decorated->create($resourceClass);	56✔
55
UNCOV 56	foreach ($resourceMetadataCollection as $index => $resourceMetadata) {	56✔
UNCOV 57	$rawResourceFormats = $resourceMetadata->getFormats();	55✔
UNCOV 58	$resourceFormats = null === $rawResourceFormats ? $this->formats : $this->normalizeFormats($rawResourceFormats);	55✔
UNCOV 59	$resourceInputFormats = $resourceMetadata->getInputFormats() ? $this->normalizeFormats($resourceMetadata->getInputFormats()) : $resourceFormats;	55✔
UNCOV 60	$resourceOutputFormats = $resourceMetadata->getOutputFormats() ? $this->normalizeFormats($resourceMetadata->getOutputFormats()) : $resourceFormats;	55✔
UNCOV 61	if ($resourceMetadata instanceof ErrorResource) {	55✔
UNCOV 62	$resourceOutputFormats = $resourceMetadata->getOutputFormats() ? $this->normalizeFormats($resourceMetadata->getOutputFormats()) : ($this->errorFormats ?? []);	3✔
63	}
64
UNCOV 65	$resourceMetadataCollection[$index] = $resourceMetadataCollection[$index]->withOperations($this->normalize($resourceInputFormats, $resourceOutputFormats, $resourceMetadata->getOperations()));	55✔
66	}
67
UNCOV 68	return $resourceMetadataCollection;	56✔
69	}
70
71	/**
72	* @param Operations<HttpOperation> $operations
73	*/
74	private function normalize(array $resourceInputFormats, array $resourceOutputFormats, Operations $operations): Operations
75	{
UNCOV 76	$newOperations = [];	55✔
UNCOV 77	$patchFormats = null;	55✔
UNCOV 78	foreach ($operations as $operationName => $operation) {	55✔
UNCOV 79	if ($operation->getFormats()) {	55✔
UNCOV 80	$operation = $operation->withFormats($this->normalizeFormats($operation->getFormats()));	1✔
81	}
82
UNCOV 83	if (($isPatch = 'PATCH' === $operation->getMethod()) && !$operation->getFormats() && !$operation->getInputFormats()) {	55✔
UNCOV 84	$operation = $operation->withInputFormats($this->patchFormats);	16✔
85	}
86
UNCOV 87	$operation = $operation->withInputFormats($operation->getInputFormats() ? $this->normalizeFormats($operation->getInputFormats()) : $operation->getFormats() ?? $resourceInputFormats);	55✔
UNCOV 88	$operation = $operation->withOutputFormats($operation->getOutputFormats() ? $this->normalizeFormats($operation->getOutputFormats()) : $operation->getFormats() ?? $resourceOutputFormats);	55✔
89
UNCOV 90	if ($isPatch) {	55✔
UNCOV 91	$patchFormats = $operation->getInputFormats();	16✔
92	}
93
UNCOV 94	$newOperations[$operationName] = $operation;	55✔
95	}
96
UNCOV 97	if (!$patchFormats) {	55✔
UNCOV 98	return new Operations($newOperations);	49✔
99	}
100
101	// Prepare an Accept-Patch header
UNCOV 102	foreach ($newOperations as $operationName => $operation) {	16✔
UNCOV 103	if ($operation instanceof CollectionOperationInterface) {	16✔
UNCOV 104	continue;	16✔
105	}
106
UNCOV 107	$patchMimeTypes = [];	16✔
108
UNCOV 109	foreach ($patchFormats as $mimeTypes) {	16✔
UNCOV 110	foreach ($mimeTypes as $mimeType) {	16✔
UNCOV 111	$patchMimeTypes[] = $mimeType;	16✔
112	}
113	}
114
UNCOV 115	$newOperations[$operationName] = $operation->withAcceptPatch(implode(', ', $patchMimeTypes));	16✔
116	}
117
UNCOV 118	return new Operations($newOperations);	16✔
119	}
120
121	/**
122	* @throws InvalidArgumentException
123	*/
124	private function normalizeFormats(array\|string $currentFormats): array
125	{
UNCOV 126	$currentFormats = (array) $currentFormats;	21✔
127
UNCOV 128	$normalizedFormats = [];	21✔
UNCOV 129	foreach ($currentFormats as $format => $value) {	21✔
UNCOV 130	if (!is_numeric($format)) {	21✔
UNCOV 131	$normalizedFormats[$format] = (array) $value;	20✔
UNCOV 132	continue;	20✔
133	}
UNCOV 134	if (!\is_string($value)) {	2✔
135	throw new InvalidArgumentException(\sprintf("The 'formats' attributes value must be a string when trying to include an already configured format, %s given.", \gettype($value)));	×
136	}
UNCOV 137	if (\array_key_exists($value, $this->formats)) {	2✔
UNCOV 138	$normalizedFormats[$value] = $this->formats[$value];	2✔
UNCOV 139	continue;	2✔
140	}
141
142	throw new InvalidArgumentException(\sprintf("You either need to add the format '%s' to your project configuration or declare a mime type for it in your annotation.", $value));	×
143	}
144
UNCOV 145	return $normalizedFormats;	21✔
146	}
147	}

api-platform / core / 18089958695

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous