18052125394

Committed 26 Sep 2025 11:00PM UTC coverage: 72.224% (+0.02%) from 72.205%

Build # 18052125394

Build Type

push

github

Committed by

YHNdnzj

Commit Message

pam_systemd: correct alignment

Follow-up for cf2630aca

Run Details

303350 of 420010 relevant lines covered (72.22%)

1058085.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

62.26

/src/network/networkd.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <sys/stat.h>
#include <unistd.h>

#include "sd-event.h"

#include "bus-log-control-api.h"
#include "bus-object.h"
#include "capability-util.h"
#include "daemon-util.h"
#include "main-func.h"
#include "mkdir-label.h"
#include "networkd-conf.h"
#include "networkd-manager.h"
#include "networkd-manager-bus.h"
#include "networkd-serialize.h"
#include "service-util.h"
#include "strv.h"
#include "user-util.h"

static int run(int argc, char *argv[]) {
        _cleanup_(manager_freep) Manager *m = NULL;
        _unused_ _cleanup_(notify_on_cleanup) const char *notify_message = NULL;
        int r;

        log_setup();

        r = service_parse_argv("systemd-networkd.service",
                               "Manage and configure network devices, create virtual network devices",
                               BUS_IMPLEMENTATIONS(&manager_object, &log_control_object),
                               /* runtime_scope= */ NULL,
                               argc, argv);
        if (r <= 0)
                return r;

        umask(0022);

        if (argc != 1)
                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "This program takes no arguments.");

        /* Drop privileges, but only if we have been started as root. If we are not running as root we assume all
         * privileges are already dropped and we can't create our runtime directory. */
        if (geteuid() == 0) {
                const char *user = "systemd-network";
                uid_t uid;
                gid_t gid;

                r = get_user_creds(&user, &uid, &gid, NULL, NULL, 0);
                if (r < 0)
                        return log_error_errno(r, "Cannot resolve user name %s: %m", user);

                /* Create runtime directory. This is not necessary when networkd is
                 * started with "RuntimeDirectory=systemd/netif", or after
                 * systemd-tmpfiles-setup.service. */
                r = mkdir_safe_label("/run/systemd/netif", 0755, uid, gid, MKDIR_WARN_MODE);
                if (r < 0)
                        log_warning_errno(r, "Could not create runtime directory: %m");

                r = drop_privileges(uid, gid,
                                    (1ULL << CAP_NET_ADMIN) |
                                    (1ULL << CAP_NET_BIND_SERVICE) |
                                    (1ULL << CAP_NET_BROADCAST) |
                                    (1ULL << CAP_NET_RAW) |
                                    (1ULL << CAP_SYS_ADMIN) |
                                    (1ULL << CAP_BPF));
                if (r < 0)
                        return log_error_errno(r, "Failed to drop privileges: %m");
        }

        /* Always create the directories people can create inotify watches in. It is necessary to create the
         * following subdirectories after drop_privileges() to make them owned by systemd-network. */
        FOREACH_STRING(p,
                       "/run/systemd/netif/dhcp-server-lease/",
                       "/run/systemd/netif/leases/",
                       "/run/systemd/netif/links/") {
                r = mkdir_safe_label(p, 0755, UID_INVALID, GID_INVALID, MKDIR_WARN_MODE);
                if (r < 0)
                        log_warning_errno(r, "Could not create directory '%s': %m", p);
        }

        r = manager_new(&m, /* test_mode = */ false);
        if (r < 0)
                return log_error_errno(r, "Could not create manager: %m");

        r = manager_setup(m);
        if (r < 0)
                return log_error_errno(r, "Could not set up manager: %m");

        r = manager_parse_config_file(m);
        if (r < 0)
                log_warning_errno(r, "Failed to parse configuration file: %m");

        r = manager_load_config(m);
        if (r < 0)
                return log_error_errno(r, "Could not load configuration files: %m");

        r = manager_enumerate(m);
        if (r < 0)
                return r;

        r = manager_deserialize(m);
        if (r < 0)
                log_warning_errno(r, "Failed to deserialize the previous invocation, ignoring: %m");

        r = manager_start(m);
        if (r < 0)
                return log_error_errno(r, "Could not start manager: %m");

        notify_message = notify_start(NOTIFY_READY_MESSAGE, NOTIFY_STOPPING_MESSAGE);

        r = sd_event_loop(m->event);
        if (r < 0)
                return log_error_errno(r, "Event loop failed: %m");

        return 0;
}

DEFINE_MAIN_FUNCTION(run);

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <sys/stat.h>
4	#include <unistd.h>
5
6	#include "sd-event.h"
7
8	#include "bus-log-control-api.h"
9	#include "bus-object.h"
10	#include "capability-util.h"
11	#include "daemon-util.h"
12	#include "main-func.h"
13	#include "mkdir-label.h"
14	#include "networkd-conf.h"
15	#include "networkd-manager.h"
16	#include "networkd-manager-bus.h"
17	#include "networkd-serialize.h"
18	#include "service-util.h"
19	#include "strv.h"
20	#include "user-util.h"
21
22	static int run(int argc, char *argv[]) {	439✔
23	_cleanup_(manager_freep) Manager *m = NULL;	439✔
24	_unused_ _cleanup_(notify_on_cleanup) const char *notify_message = NULL;	439✔
25	int r;	439✔
26
27	log_setup();	439✔
28
29	r = service_parse_argv("systemd-networkd.service",	878✔
30	"Manage and configure network devices, create virtual network devices",
31	BUS_IMPLEMENTATIONS(&manager_object, &log_control_object),	439✔
32	/* runtime_scope= */ NULL,
33	argc, argv);
34	if (r <= 0)	439✔
35	return r;
36
37	umask(0022);	439✔
38
39	if (argc != 1)	439✔
40	return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "This program takes no arguments.");	×
41
42	/* Drop privileges, but only if we have been started as root. If we are not running as root we assume all
43	* privileges are already dropped and we can't create our runtime directory. */
44	if (geteuid() == 0) {	439✔
45	const char *user = "systemd-network";	×
46	uid_t uid;	×
47	gid_t gid;	×
48
49	r = get_user_creds(&user, &uid, &gid, NULL, NULL, 0);	×
50	if (r < 0)	×
51	return log_error_errno(r, "Cannot resolve user name %s: %m", user);	×
52
53	/* Create runtime directory. This is not necessary when networkd is
54	* started with "RuntimeDirectory=systemd/netif", or after
55	* systemd-tmpfiles-setup.service. */
56	r = mkdir_safe_label("/run/systemd/netif", 0755, uid, gid, MKDIR_WARN_MODE);	×
57	if (r < 0)	×
58	log_warning_errno(r, "Could not create runtime directory: %m");	×
59
60	r = drop_privileges(uid, gid,	×
61	(1ULL << CAP_NET_ADMIN) \|
62	(1ULL << CAP_NET_BIND_SERVICE) \|
63	(1ULL << CAP_NET_BROADCAST) \|
64	(1ULL << CAP_NET_RAW) \|
65	(1ULL << CAP_SYS_ADMIN) \|
66	(1ULL << CAP_BPF));
67	if (r < 0)	×
68	return log_error_errno(r, "Failed to drop privileges: %m");	×
69	}
70
71	/* Always create the directories people can create inotify watches in. It is necessary to create the
72	* following subdirectories after drop_privileges() to make them owned by systemd-network. */
73	FOREACH_STRING(p,	1,756✔
74	"/run/systemd/netif/dhcp-server-lease/",
75	"/run/systemd/netif/leases/",
76	"/run/systemd/netif/links/") {
77	r = mkdir_safe_label(p, 0755, UID_INVALID, GID_INVALID, MKDIR_WARN_MODE);	1,317✔
78	if (r < 0)	1,317✔
79	log_warning_errno(r, "Could not create directory '%s': %m", p);	1,317✔
80	}
81
82	r = manager_new(&m, /* test_mode = */ false);	439✔
83	if (r < 0)	439✔
84	return log_error_errno(r, "Could not create manager: %m");	×
85
86	r = manager_setup(m);	439✔
87	if (r < 0)	439✔
88	return log_error_errno(r, "Could not set up manager: %m");	×
89
90	r = manager_parse_config_file(m);	439✔
91	if (r < 0)	439✔
92	log_warning_errno(r, "Failed to parse configuration file: %m");	×
93
94	r = manager_load_config(m);	439✔
95	if (r < 0)	439✔
96	return log_error_errno(r, "Could not load configuration files: %m");	×
97
98	r = manager_enumerate(m);	439✔
99	if (r < 0)	439✔
100	return r;
101
102	r = manager_deserialize(m);	439✔
103	if (r < 0)	439✔
104	log_warning_errno(r, "Failed to deserialize the previous invocation, ignoring: %m");	×
105
106	r = manager_start(m);	439✔
107	if (r < 0)	439✔
108	return log_error_errno(r, "Could not start manager: %m");	×
109
110	notify_message = notify_start(NOTIFY_READY_MESSAGE, NOTIFY_STOPPING_MESSAGE);	439✔
111
112	r = sd_event_loop(m->event);	439✔
113	if (r < 0)	439✔
114	return log_error_errno(r, "Event loop failed: %m");	×
115
116	return 0;
117	}
118
119	DEFINE_MAIN_FUNCTION(run);	439✔

systemd / systemd / 18052125394

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous