17920603410

Committed 22 Sep 2025 03:39PM UTC coverage: 71.97% (-0.05%) from 72.02%

Build # 17920603410

Build Type

push

github

Committed by

paulmthompson

Commit Message

all tests pass

Run Details

277 of 288 new or added lines in 8 files covered. (96.18%)

520 existing lines in 35 files now uncovered.

40275 of 55961 relevant lines covered (71.97%)

1225.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.4

/src/DataManager/utils/TableView/computers/IntervalPropertyComputer.test.cpp

#include <catch2/catch_approx.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/matchers/catch_matchers_floating_point.hpp>

#include "DataManager.hpp"
#include "DigitalTimeSeries/Digital_Interval_Series.hpp"
#include "Entity/EntityGroupManager.hpp"
#include "IntervalPropertyComputer.h"
#include "TimeFrame/TimeFrame.hpp"
#include "TimeFrame/interval_data.hpp"
#include "utils/TableView/ComputerRegistry.hpp"
#include "utils/TableView/TableRegistry.hpp"
#include "utils/TableView/adapters/DataManagerExtension.h"
#include "utils/TableView/core/ExecutionPlan.h"
#include "utils/TableView/core/TableView.h"
#include "utils/TableView/core/TableViewBuilder.h"
#include "utils/TableView/interfaces/IIntervalSource.h"
#include "utils/TableView/interfaces/IRowSelector.h"
#include "utils/TableView/pipeline/TablePipeline.hpp"

#include <cstdint>
#include <memory>
#include <nlohmann/json.hpp>
#include <numeric>
#include <vector>

/**
 * @brief Base test fixture for IntervalPropertyComputer with realistic interval data
 * 
 * This fixture provides a DataManager populated with:
 * - TimeFrames with different granularities
 * - Intervals representing different event periods with realistic durations
 * - Cross-timeframe scenarios for comprehensive testing
 */
class IntervalPropertyTestFixture {
protected:
    IntervalPropertyTestFixture() {
        // Initialize the DataManager
        m_data_manager = std::make_unique<DataManager>();

        // Populate with test data
        populateWithIntervalTestData();
    }

    ~IntervalPropertyTestFixture() = default;

    /**
     * @brief Get the DataManager instance
     */
    DataManager & getDataManager() { return *m_data_manager; }
    DataManager const & getDataManager() const { return *m_data_manager; }
    DataManager * getDataManagerPtr() { return m_data_manager.get(); }

private:
    std::unique_ptr<DataManager> m_data_manager;

    /**
     * @brief Populate the DataManager with interval test data
     */
    void populateWithIntervalTestData() {
        createTimeFrames();
        createBehaviorIntervals();
        createStimulusIntervals();
        createNeuralEvents();
    }

    /**
     * @brief Create TimeFrame objects for different data streams
     */
    void createTimeFrames() {
        // Create "behavior_time" timeframe: 0 to 200 (201 points) - behavior tracking at 10Hz
        std::vector<int> behavior_time_values(201);
        std::iota(behavior_time_values.begin(), behavior_time_values.end(), 0);
        auto behavior_time_frame = std::make_shared<TimeFrame>(behavior_time_values);
        m_data_manager->setTime(TimeKey("behavior_time"), behavior_time_frame, true);

        // Create "neural_time" timeframe: 0, 2, 4, 6, ..., 200 (101 points) - neural recording at 5Hz
        std::vector<int> neural_time_values;
        neural_time_values.reserve(101);
        for (int i = 0; i <= 100; ++i) {
            neural_time_values.push_back(i * 2);
        }
        auto neural_time_frame = std::make_shared<TimeFrame>(neural_time_values);
        m_data_manager->setTime(TimeKey("neural_time"), neural_time_frame, true);

        // Create "high_res_time" timeframe: millisecond resolution for precise timing
        std::vector<int> high_res_values;
        high_res_values.reserve(201);
        for (int i = 0; i <= 200; ++i) {
            high_res_values.push_back(i);
        }
        auto high_res_frame = std::make_shared<TimeFrame>(high_res_values);
        m_data_manager->setTime(TimeKey("high_res_time"), high_res_frame, true);
    }

    /**
     * @brief Create behavior intervals for testing property extraction
     */
    void createBehaviorIntervals() {
        // Create behavior periods with varying durations
        auto behavior_intervals = std::make_shared<DigitalIntervalSeries>();
        behavior_intervals->setIdentityContext("BehaviorPeriods", m_data_manager->getEntityRegistry());

        // Short grooming bout: time 10-15 (duration = 5)
        behavior_intervals->addEvent(TimeFrameIndex(10), TimeFrameIndex(15));

        // Medium exploration period: time 30-50 (duration = 20)
        behavior_intervals->addEvent(TimeFrameIndex(30), TimeFrameIndex(50));

        // Long rest period: time 70-120 (duration = 50)
        behavior_intervals->addEvent(TimeFrameIndex(70), TimeFrameIndex(120));

        // Brief social interaction: time 150-155 (duration = 5)
        behavior_intervals->addEvent(TimeFrameIndex(150), TimeFrameIndex(155));

        // Very long sleep period: time 160-190 (duration = 30)
        behavior_intervals->addEvent(TimeFrameIndex(160), TimeFrameIndex(190));

        // Rebuild entity IDs to ensure they're generated
        behavior_intervals->rebuildAllEntityIds();

        m_data_manager->setData<DigitalIntervalSeries>("BehaviorPeriods", behavior_intervals, TimeKey("behavior_time"));
    }

    /**
     * @brief Create stimulus intervals with different patterns
     */
    void createStimulusIntervals() {
        // Create stimulus presentation periods with precise timing
        auto stimulus_intervals = std::make_shared<DigitalIntervalSeries>();
        stimulus_intervals->setIdentityContext("StimulusIntervals", m_data_manager->getEntityRegistry());

        // Brief stimulus 1: time 5-8 (duration = 3)
        stimulus_intervals->addEvent(TimeFrameIndex(5), TimeFrameIndex(8));

        // Medium stimulus 2: time 25-35 (duration = 10)
        stimulus_intervals->addEvent(TimeFrameIndex(25), TimeFrameIndex(35));

        // Long stimulus 3: time 80-100 (duration = 20)
        stimulus_intervals->addEvent(TimeFrameIndex(80), TimeFrameIndex(100));

        // Short stimulus 4: time 140-142 (duration = 2)
        stimulus_intervals->addEvent(TimeFrameIndex(140), TimeFrameIndex(142));

        // Rebuild entity IDs to ensure they're generated
        stimulus_intervals->rebuildAllEntityIds();

        m_data_manager->setData<DigitalIntervalSeries>("StimulusIntervals", stimulus_intervals, TimeKey("neural_time"));
    }

    /**
     * @brief Create neural event intervals for high-resolution testing
     */
    void createNeuralEvents() {
        // Create neural activity bursts with precise timing
        auto neural_intervals = std::make_shared<DigitalIntervalSeries>();
        neural_intervals->setIdentityContext("NeuralEvents", m_data_manager->getEntityRegistry());

        // Microsecond-level precision events
        // Event 1: time 12-13 (duration = 1)
        neural_intervals->addEvent(TimeFrameIndex(12), TimeFrameIndex(13));

        // Event 2: time 45-47 (duration = 2)
        neural_intervals->addEvent(TimeFrameIndex(45), TimeFrameIndex(47));

        // Event 3: time 89-92 (duration = 3)
        neural_intervals->addEvent(TimeFrameIndex(89), TimeFrameIndex(92));

        // Event 4: time 156-161 (duration = 5)
        neural_intervals->addEvent(TimeFrameIndex(156), TimeFrameIndex(161));

        // Rebuild entity IDs to ensure they're generated
        neural_intervals->rebuildAllEntityIds();

        m_data_manager->setData<DigitalIntervalSeries>("NeuralEvents", neural_intervals, TimeKey("high_res_time"));
    }
};

/**
 * @brief Test fixture combining IntervalPropertyTestFixture with TableRegistry and TablePipeline
 * 
 * This fixture provides everything needed to test JSON-based table pipeline execution:
 * - DataManager with interval test data (from IntervalPropertyTestFixture)
 * - TableRegistry for managing table configurations
 * - TablePipeline for executing JSON configurations
 */
class IntervalPropertyTableRegistryTestFixture : public IntervalPropertyTestFixture {
protected:
    IntervalPropertyTableRegistryTestFixture()
        : IntervalPropertyTestFixture() {
        // Use the DataManager's existing TableRegistry instead of creating a new one
        m_table_registry_ptr = getDataManager().getTableRegistry();

        // Initialize TablePipeline with the existing TableRegistry
        m_table_pipeline = std::make_unique<TablePipeline>(m_table_registry_ptr, &getDataManager());
    }

    ~IntervalPropertyTableRegistryTestFixture() = default;

    /**
     * @brief Get the TableRegistry instance
     * @return Reference to the TableRegistry
     */
    TableRegistry & getTableRegistry() { return *m_table_registry_ptr; }

    /**
     * @brief Get the TableRegistry instance (const version)
     * @return Const reference to the TableRegistry
     */
    TableRegistry const & getTableRegistry() const { return *m_table_registry_ptr; }

    /**
     * @brief Get a pointer to the TableRegistry
     * @return Raw pointer to the TableRegistry
     */
    TableRegistry * getTableRegistryPtr() { return m_table_registry_ptr; }

    /**
     * @brief Get the TablePipeline instance
     * @return Reference to the TablePipeline
     */
    TablePipeline & getTablePipeline() { return *m_table_pipeline; }

    /**
     * @brief Get the TablePipeline instance (const version)
     * @return Const reference to the TablePipeline
     */
    TablePipeline const & getTablePipeline() const { return *m_table_pipeline; }

    /**
     * @brief Get a pointer to the TablePipeline
     * @return Raw pointer to the TablePipeline
     */
    TablePipeline * getTablePipelinePtr() { return m_table_pipeline.get(); }

    /**
     * @brief Get the DataManagerExtension instance
     */
    std::shared_ptr<DataManagerExtension> getDataManagerExtension() {
        if (!m_data_manager_extension) {
            m_data_manager_extension = std::make_shared<DataManagerExtension>(getDataManager());
        }
        return m_data_manager_extension;
    }

private:
    TableRegistry * m_table_registry_ptr;// Points to DataManager's TableRegistry
    std::unique_ptr<TablePipeline> m_table_pipeline;
    std::shared_ptr<DataManagerExtension> m_data_manager_extension;// Lazy-initialized
};

// Mock implementation of IIntervalSource for testing
class MockIntervalSource : public IIntervalSource {
public:
    MockIntervalSource(std::string name,
                       std::shared_ptr<TimeFrame> timeFrame,
                       std::vector<Interval> intervals)
        : m_name(std::move(name)),
          m_timeFrame(std::move(timeFrame)),
          m_intervals(std::move(intervals)) {}

    [[nodiscard]] auto getName() const -> std::string const & override {
        return m_name;
    }

    [[nodiscard]] auto getTimeFrame() const -> std::shared_ptr<TimeFrame> override {
        return m_timeFrame;
    }

    [[nodiscard]] auto size() const -> size_t override {
        return m_intervals.size();
    }

    auto getIntervals() -> std::vector<Interval> override {
        return m_intervals;
    }

    auto getIntervalsInRange(TimeFrameIndex start, TimeFrameIndex end,
                             TimeFrame const * target_timeFrame) -> std::vector<Interval> override {
        std::vector<Interval> result;

        // Convert TimeFrameIndex to time values for comparison
        auto startTime = target_timeFrame->getTimeAtIndex(start);
        auto endTime = target_timeFrame->getTimeAtIndex(end);

        for (auto const & interval: m_intervals) {
            // Convert interval indices to time values using our timeframe
            auto intervalStartTime = m_timeFrame->getTimeAtIndex(TimeFrameIndex(interval.start));
            auto intervalEndTime = m_timeFrame->getTimeAtIndex(TimeFrameIndex(interval.end));

            // Check if intervals overlap in time
            if (intervalStartTime <= endTime && startTime <= intervalEndTime) {
                result.push_back(interval);
            }
        }

        return result;
    }

    auto getIntervalsWithIdsInRange(TimeFrameIndex start, TimeFrameIndex end,
                                    TimeFrame const * target_timeFrame) -> std::vector<IntervalWithId> override {
        std::vector<IntervalWithId> result;

        // Convert TimeFrameIndex to time values for comparison
        auto startTime = target_timeFrame->getTimeAtIndex(start);
        auto endTime = target_timeFrame->getTimeAtIndex(end);

        for (auto const & interval: m_intervals) {
            // Convert interval indices to time values using our timeframe
            auto intervalStartTime = m_timeFrame->getTimeAtIndex(TimeFrameIndex(interval.start));
            auto intervalEndTime = m_timeFrame->getTimeAtIndex(TimeFrameIndex(interval.end));

            // Check if intervals overlap in time
            if (intervalStartTime <= endTime && startTime <= intervalEndTime) {
                result.push_back(IntervalWithId(interval, 0));
            }
        }

        return result;
    }

private:
    std::string m_name;
    std::shared_ptr<TimeFrame> m_timeFrame;
    std::vector<Interval> m_intervals;
};

TEST_CASE("DM - TV - IntervalPropertyComputer Basic Functionality", "[IntervalPropertyComputer]") {

    SECTION("Start property extraction with matching intervals") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals (non-overlapping, properly ordered)
        std::vector<Interval> sourceIntervals = {
            {0, 2},   // Start = 0
            {4, 6},   // Start = 4  
            {8, 10},  // Start = 8
            {12, 14}  // Start = 12
        };

        auto intervalSource = std::make_shared<MockIntervalSource>(
            "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that match the source intervals exactly
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(0), TimeFrameIndex(2)), // Start = 0
                TimeFrameInterval(TimeFrameIndex(4), TimeFrameIndex(6)), // Start = 4
                TimeFrameInterval(TimeFrameIndex(8), TimeFrameIndex(10)), // Start = 8
                TimeFrameInterval(TimeFrameIndex(12), TimeFrameIndex(14)) // Start = 12
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Create the computer for Start property
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Start,
                                                   "TestIntervals");

        // Compute the results
        auto [results, entity_ids] = computer.compute(plan);

        // Verify results
        REQUIRE(results.size() == 4);
        REQUIRE(results[0] == 0);// First interval start
        REQUIRE(results[1] == 4);// Second interval start
        REQUIRE(results[2] == 8);// Third interval start
        REQUIRE(results[3] == 12);// Fourth interval start
    }

    SECTION("End property extraction with matching intervals") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals (non-overlapping, properly ordered)
        std::vector<Interval> sourceIntervals = {
            {0, 2},   // End = 2
            {4, 6},   // End = 6
            {8, 10},  // End = 10
            {12, 14}  // End = 14
        };
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that match the source intervals exactly
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(0), TimeFrameIndex(2)), // End = 2
                TimeFrameInterval(TimeFrameIndex(4), TimeFrameIndex(6)), // End = 6
                TimeFrameInterval(TimeFrameIndex(8), TimeFrameIndex(10)), // End = 10
                TimeFrameInterval(TimeFrameIndex(12), TimeFrameIndex(14)) // End = 14
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Create the computer for End property
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::End,
                                                   "TestIntervals");

        // Compute the results
        auto [results, entity_ids] = computer.compute(plan);

        // Verify results
        REQUIRE(results.size() == 4);
        REQUIRE(results[0] == 2);// First interval end
        REQUIRE(results[1] == 6);// Second interval end
        REQUIRE(results[2] == 10);// Third interval end
        REQUIRE(results[3] == 14);// Fourth interval end
    }

    SECTION("Duration property extraction with matching intervals") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals (non-overlapping, properly ordered)
        std::vector<Interval> sourceIntervals = {
            {0, 2},   // Duration = 2-0 = 2
            {4, 7},   // Duration = 7-4 = 3
            {8, 10},  // Duration = 10-8 = 2
            {12, 15}  // Duration = 15-12 = 3
        };
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that match the source intervals exactly
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(0), TimeFrameIndex(2)), // Duration = 2-0 = 2
                TimeFrameInterval(TimeFrameIndex(4), TimeFrameIndex(7)), // Duration = 7-4 = 3
                TimeFrameInterval(TimeFrameIndex(8), TimeFrameIndex(10)), // Duration = 10-8 = 2
                TimeFrameInterval(TimeFrameIndex(12), TimeFrameIndex(15)) // Duration = 15-12 = 3
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Create the computer for Duration property
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Duration,
                                                   "TestIntervals");

        // Compute the results
        auto [results, entity_ids] = computer.compute(plan);

        // Verify results
        REQUIRE(results.size() == 4);
        REQUIRE(results[0] == 2);// Duration = 2-0
        REQUIRE(results[1] == 3);// Duration = 7-4
        REQUIRE(results[2] == 2);// Duration = 10-8
        REQUIRE(results[3] == 3);// Duration = 15-12
    }

    SECTION("Single interval scenarios") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals that match the row intervals
        std::vector<Interval> sourceIntervals = {{2, 4}}; // Start=2, End=4, Duration=2
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "SingleInterval", timeFrame, sourceIntervals);

        // Create single row interval that matches the source interval
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(2), TimeFrameIndex(4))// Start=2, End=4, Duration=2
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Test Start property
        IntervalPropertyComputer<int64_t> startComputer(intervalSource,
                                                        IntervalProperty::Start,
                                                        "SingleInterval");
        auto [startResults, entity_ids] = startComputer.compute(plan);
        REQUIRE(startResults.size() == 1);
        REQUIRE(startResults[0] == 2);

        // Test End property
        IntervalPropertyComputer<int64_t> endComputer(intervalSource,
                                                      IntervalProperty::End,
                                                      "SingleInterval");
        auto [endResults, endEntity_ids] = endComputer.compute(plan);
        REQUIRE(endResults.size() == 1);
        REQUIRE(endResults[0] == 4);

        // Test Duration property
        IntervalPropertyComputer<int64_t> durationComputer(intervalSource,
                                                           IntervalProperty::Duration,
                                                           "SingleInterval");
        auto [durationResults, durationEntity_ids] = durationComputer.compute(plan);
        REQUIRE(durationResults.size() == 1);
        REQUIRE(durationResults[0] == 2);
    }

    SECTION("Zero-duration intervals with matching source") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals with zero-duration intervals
        std::vector<Interval> sourceIntervals = {
            {1, 1},  // Duration = 0
            {3, 3}   // Duration = 0
        };
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "ZeroDuration", timeFrame, sourceIntervals);

        // Create row intervals that match the source intervals exactly
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(1), TimeFrameIndex(1)),// Duration = 0
                TimeFrameInterval(TimeFrameIndex(3), TimeFrameIndex(3)) // Duration = 0
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Test Duration property
        IntervalPropertyComputer<int64_t> durationComputer(intervalSource,
                                                           IntervalProperty::Duration,
                                                           "ZeroDuration");
        auto [durationResults, entity_ids] = durationComputer.compute(plan);

        REQUIRE(durationResults.size() == 2);
        REQUIRE(durationResults[0] == 0);// Zero duration
        REQUIRE(durationResults[1] == 0);// Zero duration
    }
}

TEST_CASE("DM - TV - IntervalPropertyComputer Error Handling", "[IntervalPropertyComputer][Error]") {

    SECTION("ExecutionPlan without intervals throws exception") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals
        std::vector<Interval> sourceIntervals = {{1, 3}};
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create execution plan with indices instead of intervals
        std::vector<TimeFrameIndex> indices = {TimeFrameIndex(0), TimeFrameIndex(1)};
        ExecutionPlan plan(indices, timeFrame);

        // Create the computer
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Start,
                                                   "TestIntervals");

        // Should throw an exception
        REQUIRE_THROWS_AS(computer.compute(plan), std::runtime_error);
    }

    SECTION("Row intervals not matching source intervals throws exception") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals
        std::vector<Interval> sourceIntervals = {
            {1, 3},
            {5, 7}
        };
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that don't match source intervals
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(2), TimeFrameIndex(4)), // Not in source
                TimeFrameInterval(TimeFrameIndex(6), TimeFrameIndex(8))  // Not in source
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Create the computer
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Start,
                                                   "TestIntervals");

        // Should throw an exception
        REQUIRE_THROWS_AS(computer.compute(plan), std::runtime_error);
    }

    SECTION("Partial subset of source intervals is valid") {
        // Create time frame
        std::vector<int> timeValues = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals (5 intervals)
        std::vector<Interval> sourceIntervals = {
            {1, 2},  // Interval 1
            {3, 4},  // Interval 2
            {5, 6},  // Interval 3
            {7, 8},  // Interval 4
            {9, 10}  // Interval 5
        };
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that are a subset of source intervals (intervals 2 and 4)
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(3), TimeFrameIndex(4)), // Matches source interval 2
                TimeFrameInterval(TimeFrameIndex(7), TimeFrameIndex(8))  // Matches source interval 4
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Create the computer
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Start,
                                                   "TestIntervals");

        // Should work without throwing
        auto [results, entity_ids] = computer.compute(plan);

        // Verify results
        REQUIRE(results.size() == 2);
        REQUIRE(results[0] == 3); // Start of interval 2
        REQUIRE(results[1] == 7); // Start of interval 4
    }
}

TEST_CASE("DM - TV - IntervalPropertyComputer Template Types", "[IntervalPropertyComputer][Templates]") {

    SECTION("Test with different numeric types") {
        // Create time frame
        std::vector<int> timeValues = {0, 5, 10, 15, 20, 25};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        // Create source intervals
        std::vector<Interval> sourceIntervals = {{1, 4}}; // Duration = 3
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestIntervals", timeFrame, sourceIntervals);

        // Create row intervals that match the source intervals exactly
        std::vector<TimeFrameInterval> rowIntervals = {
                TimeFrameInterval(TimeFrameIndex(1), TimeFrameIndex(4))// Start=1, End=4, Duration=3
        };

        ExecutionPlan plan(rowIntervals, timeFrame);

        // Test with int64_t
        IntervalPropertyComputer<int64_t> intComputer(intervalSource,
                                                      IntervalProperty::Duration,
                                                      "TestIntervals");
        auto [intResults, entity_ids] = intComputer.compute(plan);
        REQUIRE(intResults.size() == 1);
        REQUIRE(intResults[0] == 3);

        // Test with float
        IntervalPropertyComputer<float> floatComputer(intervalSource,
                                                      IntervalProperty::Duration,
                                                      "TestIntervals");
        auto [floatResults, floatEntity_ids] = floatComputer.compute(plan);
        REQUIRE(floatResults.size() == 1);
        REQUIRE(floatResults[0] == Catch::Approx(3.0f));

        // Test with double
        IntervalPropertyComputer<double> doubleComputer(intervalSource,
                                                        IntervalProperty::Duration,
                                                        "TestIntervals");
        auto [doubleResults, doubleEntity_ids] = doubleComputer.compute(plan);
        REQUIRE(doubleResults.size() == 1);
        REQUIRE(doubleResults[0] == Catch::Approx(3.0));
    }
}

TEST_CASE("DM - TV - IntervalPropertyComputer Dependency Tracking", "[IntervalPropertyComputer][Dependencies]") {

    SECTION("getSourceDependency returns correct source name") {
        // Create minimal setup
        std::vector<int> timeValues = {0, 1, 2};
        auto timeFrame = std::make_shared<TimeFrame>(timeValues);

        std::vector<Interval> sourceIntervals = {{0, 1}};
        auto intervalSource = std::make_shared<MockIntervalSource>(
                "TestSource", timeFrame, sourceIntervals);

        // Create computer
        IntervalPropertyComputer<int64_t> computer(intervalSource,
                                                   IntervalProperty::Start,
                                                   "TestSourceName");

        // Test source dependency
        REQUIRE(computer.getSourceDependency() == "TestSourceName");
    }
}

TEST_CASE_METHOD(IntervalPropertyTestFixture, "DM - TV - IntervalPropertyComputer with DataManager fixture", "[IntervalPropertyComputer][DataManager][Fixture]") {

    SECTION("Test with behavior intervals from fixture") {
        auto & dm = getDataManager();
        auto dme = std::make_shared<DataManagerExtension>(dm);

        // Get the interval source from the DataManager
        auto behavior_source = dme->getIntervalSource("BehaviorPeriods");

        REQUIRE(behavior_source != nullptr);

        // Create row selector from behavior intervals
        auto behavior_time_frame = dm.getTime(TimeKey("behavior_time"));
        auto behavior_intervals = behavior_source->getIntervalsInRange(
                TimeFrameIndex(0), TimeFrameIndex(200), behavior_time_frame.get());

        REQUIRE(behavior_intervals.size() == 5);// 5 behavior periods from fixture

        // Convert to TimeFrameIntervals for row selector
        std::vector<TimeFrameInterval> row_intervals;
        for (auto const & interval: behavior_intervals) {
            row_intervals.emplace_back(TimeFrameIndex(interval.start), TimeFrameIndex(interval.end));
        }

        auto row_selector = std::make_unique<IntervalSelector>(row_intervals, behavior_time_frame);

        // Create TableView builder
        TableViewBuilder builder(dme);
        builder.setRowSelector(std::move(row_selector));

        // Test Start property
        builder.addColumn<double>("IntervalStart",
                                  std::make_unique<IntervalPropertyComputer<double>>(behavior_source,
                                                                                     IntervalProperty::Start, "BehaviorPeriods"));

        // Test End property
        builder.addColumn<double>("IntervalEnd",
                                  std::make_unique<IntervalPropertyComputer<double>>(behavior_source,
                                                                                     IntervalProperty::End, "BehaviorPeriods"));

        // Test Duration property
        builder.addColumn<double>("IntervalDuration",
                                  std::make_unique<IntervalPropertyComputer<double>>(behavior_source,
                                                                                     IntervalProperty::Duration, "BehaviorPeriods"));

        // Build the table
        TableView table = builder.build();

        // Verify table structure
        REQUIRE(table.getRowCount() == 5);
        REQUIRE(table.getColumnCount() == 3);
        REQUIRE(table.hasColumn("IntervalStart"));
        REQUIRE(table.hasColumn("IntervalEnd"));
        REQUIRE(table.hasColumn("IntervalDuration"));

        // Get the column data
        auto starts = table.getColumnValues<double>("IntervalStart");
        auto ends = table.getColumnValues<double>("IntervalEnd");
        auto durations = table.getColumnValues<double>("IntervalDuration");

        REQUIRE(starts.size() == 5);
        REQUIRE(ends.size() == 5);
        REQUIRE(durations.size() == 5);

        // Verify the property values match our test data expectations
        // Expected behavior periods from fixture:
        // Period 1: 10-15 (duration = 5)
        // Period 2: 30-50 (duration = 20)
        // Period 3: 70-120 (duration = 50)
        // Period 4: 150-155 (duration = 5)
        // Period 5: 160-190 (duration = 30)

        for (size_t i = 0; i < 5; ++i) {
            REQUIRE(starts[i] >= 0);                       // Valid start times
            REQUIRE(ends[i] > starts[i]);                  // End > Start
            REQUIRE(durations[i] > 0);                     // Positive durations
            REQUIRE(durations[i] == (ends[i] - starts[i]));// Duration = End - Start

            std::cout << "Behavior period " << i << ": Start=" << starts[i]
                      << ", End=" << ends[i] << ", Duration=" << durations[i] << std::endl;
        }

        // Verify specific expected values (first few intervals)
        REQUIRE(starts[0] == Catch::Approx(10.0));  // First period starts at 10
        REQUIRE(ends[0] == Catch::Approx(15.0));    // First period ends at 15
        REQUIRE(durations[0] == Catch::Approx(5.0));// First period duration = 5

        REQUIRE(starts[1] == Catch::Approx(30.0));   // Second period starts at 30
        REQUIRE(durations[1] == Catch::Approx(20.0));// Second period duration = 20
    }

    SECTION("Test with neural events from fixture") {
        auto & dm = getDataManager();
        auto dme = std::make_shared<DataManagerExtension>(dm);

        // Get neural events from high-resolution timeframe
        auto neural_source = dme->getIntervalSource("NeuralEvents");
        REQUIRE(neural_source != nullptr);

        auto neural_time_frame = dm.getTime(TimeKey("high_res_time"));
        auto neural_intervals = neural_source->getIntervalsInRange(
                TimeFrameIndex(0), TimeFrameIndex(200), neural_time_frame.get());

        REQUIRE(neural_intervals.size() == 4);// 4 neural events from fixture

        // Convert to TimeFrameIntervals for row selector
        std::vector<TimeFrameInterval> row_intervals;
        for (auto const & interval: neural_intervals) {
            row_intervals.emplace_back(TimeFrameIndex(interval.start), TimeFrameIndex(interval.end));
        }

        auto row_selector = std::make_unique<IntervalSelector>(row_intervals, neural_time_frame);

        TableViewBuilder builder(dme);
        builder.setRowSelector(std::move(row_selector));

        // Add property computers
        builder.addColumn<int64_t>("EventStart",
                                   std::make_unique<IntervalPropertyComputer<int64_t>>(neural_source,
                                                                                       IntervalProperty::Start, "NeuralEvents"));

        builder.addColumn<int64_t>("EventDuration",
                                   std::make_unique<IntervalPropertyComputer<int64_t>>(neural_source,
                                                                                       IntervalProperty::Duration, "NeuralEvents"));

        // Build and verify the table
        TableView table = builder.build();

        REQUIRE(table.getRowCount() == 4);
        REQUIRE(table.getColumnCount() == 2);

        auto starts = table.getColumnValues<int64_t>("EventStart");
        auto durations = table.getColumnValues<int64_t>("EventDuration");

        REQUIRE(starts.size() == 4);
        REQUIRE(durations.size() == 4);

        // Verify neural events match our test data:
        // Event 1: 12-13 (duration = 1)
        // Event 2: 45-47 (duration = 2)
        // Event 3: 89-92 (duration = 3)
        // Event 4: 156-161 (duration = 5)

        std::vector<int64_t> expected_starts = {12, 45, 89, 156};
        std::vector<int64_t> expected_durations = {1, 2, 3, 5};

        for (size_t i = 0; i < 4; ++i) {
            REQUIRE(starts[i] == expected_starts[i]);
            REQUIRE(durations[i] == expected_durations[i]);

            std::cout << "Neural event " << i << ": Start=" << starts[i]
                      << ", Duration=" << durations[i] << std::endl;
        }
    }
}

TEST_CASE_METHOD(IntervalPropertyTestFixture, "DM - TV - IntervalPropertyComputer EntityID Round-trip Integration", "[IntervalPropertyComputer][EntityID][integration]") {

    SECTION("TableView creation and EntityID extraction with IntervalPropertyComputer") {
        auto & dm = getDataManager();

        // Create DataManagerExtension for TableView integration
        auto dme = std::make_shared<DataManagerExtension>(dm);

        // Get behavior intervals from our test fixture
        auto behavior_source = dme->getIntervalSource("BehaviorPeriods");
        REQUIRE(behavior_source != nullptr);

        // Create row selector for behavior intervals
        auto behavior_time_frame = dm.getTime(TimeKey("behavior_time"));
        auto behavior_intervals = behavior_source->getIntervalsInRange(
                TimeFrameIndex(0), TimeFrameIndex(200), behavior_time_frame.get());

        REQUIRE(behavior_intervals.size() == 5);// 5 behavior periods from fixture

        // Convert to TimeFrameIntervals for row selector
        std::vector<TimeFrameInterval> row_intervals;
        for (auto const & interval: behavior_intervals) {
            row_intervals.emplace_back(TimeFrameIndex(interval.start), TimeFrameIndex(interval.end));
        }

        auto row_selector = std::make_unique<IntervalSelector>(row_intervals, behavior_time_frame);

        // Build TableView using TableViewBuilder
        TableViewBuilder builder(dme);
        builder.setRowSelector(std::move(row_selector));

        // Add IntervalPropertyComputer columns
        builder.addColumn<double>("IntervalStart",
                                  std::make_unique<IntervalPropertyComputer<double>>(behavior_source,
                                                                                     IntervalProperty::Start, "BehaviorPeriods"));
        builder.addColumn<double>("IntervalDuration",
                                  std::make_unique<IntervalPropertyComputer<double>>(behavior_source,
                                                                                     IntervalProperty::Duration, "BehaviorPeriods"));

        auto table = builder.build();

        auto start_data_from_table = table.getColumnValues<double>("IntervalStart");
        auto duration_data_from_table = table.getColumnValues<double>("IntervalDuration");

        // Verify table structure
        REQUIRE(table.getRowCount() == 5);// 5 behavior periods
        REQUIRE(table.getColumnCount() == 2);
        REQUIRE(table.hasColumn("IntervalStart"));
        REQUIRE(table.hasColumn("IntervalDuration"));

        // Verify EntityID information is available for IntervalPropertyComputer columns
        REQUIRE(table.hasColumnEntityIds("IntervalStart"));
        REQUIRE(table.hasColumnEntityIds("IntervalDuration"));

        // Get EntityIDs from the columns (all IntervalPropertyComputer columns should share the same EntityIDs)
        auto start_entity_ids_variant = table.getColumnEntityIds("IntervalStart");
        auto duration_entity_ids_variant = table.getColumnEntityIds("IntervalDuration");

        // IntervalPropertyComputer uses Simple EntityID structure, so extract std::vector<EntityId>
        REQUIRE(std::holds_alternative<std::vector<EntityId>>(start_entity_ids_variant));
        REQUIRE(std::holds_alternative<std::vector<EntityId>>(duration_entity_ids_variant));

        auto start_entity_ids = std::get<std::vector<EntityId>>(start_entity_ids_variant);
        auto duration_entity_ids = std::get<std::vector<EntityId>>(duration_entity_ids_variant);

        REQUIRE(start_entity_ids.size() == 5);// Should match row count
        REQUIRE(duration_entity_ids.size() == 5);

        // Verify all EntityIDs are valid (non-zero)
        for (EntityId id: start_entity_ids) {
            REQUIRE(id != 0);
            INFO("Start Column EntityID: " << id);
        }

        // Verify that both columns have the same EntityIDs (they come from the same intervals)
        REQUIRE(duration_entity_ids == start_entity_ids);

        // Get sample data from table columns
        auto start_values = table.getColumnValues<double>("IntervalStart");
        auto duration_values = table.getColumnValues<double>("IntervalDuration");

        REQUIRE(start_values.size() == 5);
        REQUIRE(duration_values.size() == 5);

        // Verify data consistency and entity relationships
        for (size_t i = 0; i < 5; ++i) {
            // Verify basic properties
            REQUIRE(start_values[i] >= 0);
            REQUIRE(duration_values[i] > 0);

            INFO("Row " << i << ": Start=" << start_values[i]
                        << ", Duration=" << duration_values[i]
                        << ", EntityID=" << start_entity_ids[i]);
        }

        // Test EntityID round-trip: Compare TableView EntityIDs with original source EntityIDs
        INFO("Testing EntityID round-trip from source data to TableView");

        // Get the original DigitalIntervalSeries data that was used to create the intervals
        auto behavior_data = dm.getData<DigitalIntervalSeries>("BehaviorPeriods");
        REQUIRE(behavior_data != nullptr);

        // Get the EntityIDs directly from the source data
        auto source_entity_ids = behavior_data->getEntityIds();
        REQUIRE(source_entity_ids.size() == 5);// Should match the number of intervals

        // Debug: Print source EntityIDs to see if they're valid
        INFO("Source EntityIDs from DigitalIntervalSeries:");
        for (size_t i = 0; i < source_entity_ids.size(); ++i) {
            INFO("  Source EntityID[" << i << "] = " << source_entity_ids[i]);
            REQUIRE(source_entity_ids[i] != 0);// Verify source EntityIDs are valid
        }

        // Verify that TableView EntityIDs match the source EntityIDs
        REQUIRE(start_entity_ids.size() == source_entity_ids.size());
        for (size_t i = 0; i < source_entity_ids.size(); ++i) {
            REQUIRE(start_entity_ids[i] == source_entity_ids[i]);
            INFO("EntityID " << i << ": Source=" << source_entity_ids[i]
                             << ", TableView=" << start_entity_ids[i] << " ✓");
        }

        INFO("✓ EntityID round-trip successful: " << start_entity_ids.size() << " EntityIDs match source data");

        // Test individual row EntityID extraction
        for (size_t row_idx = 0; row_idx < 5; ++row_idx) {
            // Get EntityIDs for a specific row
            auto row_start_ids = table.getCellEntityIds("IntervalStart", row_idx);
            auto row_duration_ids = table.getCellEntityIds("IntervalDuration", row_idx);

            REQUIRE(row_start_ids.size() == 1);// Should have exactly one EntityID per interval
            REQUIRE(row_duration_ids.size() == 1);

            // Verify they match the overall EntityID list
            REQUIRE(row_start_ids[0] == start_entity_ids[row_idx]);
            REQUIRE(row_duration_ids[0] == start_entity_ids[row_idx]);

            INFO("Row " << row_idx << " individual EntityID check: " << row_start_ids[0]);
        }

        INFO("✓ All IntervalPropertyComputer EntityID extraction tests passed");
    }
}

TEST_CASE_METHOD(IntervalPropertyTableRegistryTestFixture, "DM - TV - IntervalPropertyComputer via ComputerRegistry", "[IntervalPropertyComputer][Registry]") {

    SECTION("Verify IntervalPropertyComputer is registered in ComputerRegistry") {
        auto & registry = getTableRegistry().getComputerRegistry();

        // Check that all interval property computers are registered
        auto start_info = registry.findComputerInfo("Interval Start");
        auto end_info = registry.findComputerInfo("Interval End");
        auto duration_info = registry.findComputerInfo("Interval Duration");

        REQUIRE(start_info != nullptr);
        REQUIRE(end_info != nullptr);
        REQUIRE(duration_info != nullptr);

        // Verify computer info details for Start
        REQUIRE(start_info->name == "Interval Start");
        REQUIRE(start_info->outputType == typeid(double));
        REQUIRE(start_info->outputTypeName == "double");
        REQUIRE(start_info->requiredRowSelector == RowSelectorType::IntervalBased);
        REQUIRE(start_info->requiredSourceType == typeid(std::shared_ptr<IIntervalSource>));

        // Verify computer info details for End
        REQUIRE(end_info->name == "Interval End");
        REQUIRE(end_info->outputType == typeid(double));
        REQUIRE(end_info->outputTypeName == "double");
        REQUIRE(end_info->requiredRowSelector == RowSelectorType::IntervalBased);
        REQUIRE(end_info->requiredSourceType == typeid(std::shared_ptr<IIntervalSource>));

        // Verify computer info details for Duration
        REQUIRE(duration_info->name == "Interval Duration");
        REQUIRE(duration_info->outputType == typeid(double));
        REQUIRE(duration_info->outputTypeName == "double");
        REQUIRE(duration_info->requiredRowSelector == RowSelectorType::IntervalBased);
        REQUIRE(duration_info->requiredSourceType == typeid(std::shared_ptr<IIntervalSource>));
    }

    SECTION("Create IntervalPropertyComputer via ComputerRegistry") {
        auto & dm = getDataManager();
        auto dme = std::make_shared<DataManagerExtension>(dm);
        auto & registry = getTableRegistry().getComputerRegistry();

        // Get behavior source for testing
        auto behavior_source = dme->getIntervalSource("BehaviorPeriods");
        REQUIRE(behavior_source != nullptr);

        // Create computers via registry
        std::map<std::string, std::string> empty_params;

        auto start_computer = registry.createTypedComputer<double>(
                "Interval Start", behavior_source, empty_params);
        auto end_computer = registry.createTypedComputer<double>(
                "Interval End", behavior_source, empty_params);
        auto duration_computer = registry.createTypedComputer<double>(
                "Interval Duration", behavior_source, empty_params);

        REQUIRE(start_computer != nullptr);
        REQUIRE(end_computer != nullptr);
        REQUIRE(duration_computer != nullptr);

        // Test that the created computers work correctly
        auto behavior_time_frame = dm.getTime(TimeKey("behavior_time"));

        // Create a simple test interval
        std::vector<TimeFrameInterval> test_intervals = {
                TimeFrameInterval(TimeFrameIndex(30), TimeFrameIndex(50))// Behavior period 2
        };

        auto row_selector = std::make_unique<IntervalSelector>(test_intervals, behavior_time_frame);

        TableViewBuilder builder(dme);
        builder.setRowSelector(std::move(row_selector));

        // Use the registry-created computers
        builder.addColumn("RegistryStart", std::move(start_computer));
        builder.addColumn("RegistryEnd", std::move(end_computer));
        builder.addColumn("RegistryDuration", std::move(duration_computer));

        // Build and verify the table
        TableView table = builder.build();

        REQUIRE(table.getRowCount() == 1);
        REQUIRE(table.getColumnCount() == 3);
        REQUIRE(table.hasColumn("RegistryStart"));
        REQUIRE(table.hasColumn("RegistryEnd"));
        REQUIRE(table.hasColumn("RegistryDuration"));

        auto starts = table.getColumnValues<double>("RegistryStart");
        auto ends = table.getColumnValues<double>("RegistryEnd");
        auto durations = table.getColumnValues<double>("RegistryDuration");

        REQUIRE(starts.size() == 1);
        REQUIRE(ends.size() == 1);
        REQUIRE(durations.size() == 1);

        // Verify reasonable results (should match the test interval: 30-50)
        REQUIRE(starts[0] == Catch::Approx(30.0));
        REQUIRE(ends[0] == Catch::Approx(50.0));
        REQUIRE(durations[0] == Catch::Approx(20.0));

        std::cout << "Registry test - Start: " << starts[0]
                  << ", End: " << ends[0] << ", Duration: " << durations[0] << std::endl;
    }

    SECTION("Compare registry-created vs direct-created computers") {
        auto & dm = getDataManager();
        auto dme = std::make_shared<DataManagerExtension>(dm);
        auto & registry = getTableRegistry().getComputerRegistry();

        auto behavior_source = dme->getIntervalSource("BehaviorPeriods");
        REQUIRE(behavior_source != nullptr);

        // Create computer via registry
        std::map<std::string, std::string> empty_params;
        auto registry_computer = registry.createTypedComputer<double>(
                "Interval Duration", behavior_source, empty_params);

        // Create computer directly
        auto direct_computer = std::make_unique<IntervalPropertyComputer<double>>(
                behavior_source, IntervalProperty::Duration, "BehaviorPeriods");

        REQUIRE(registry_computer != nullptr);
        REQUIRE(direct_computer != nullptr);

        // Test both computers with the same data
        auto behavior_time_frame = dm.getTime(TimeKey("behavior_time"));
        std::vector<TimeFrameInterval> test_intervals = {
                TimeFrameInterval(TimeFrameIndex(70), TimeFrameIndex(120))// Period 3: duration = 50
        };

        ExecutionPlan plan(test_intervals, behavior_time_frame);

        auto [registry_result, registry_entity_ids] = registry_computer->compute(plan);
        auto [direct_result, direct_entity_ids] = direct_computer->compute(plan);

        REQUIRE(registry_result.size() == 1);
        REQUIRE(direct_result.size() == 1);

        // Results should be identical
        REQUIRE(registry_result[0] == Catch::Approx(direct_result[0]));
        REQUIRE(registry_result[0] == Catch::Approx(50.0));// Expected duration

        std::cout << "Comparison test - Registry result: " << registry_result[0]
                  << ", Direct result: " << direct_result[0] << std::endl;
    }
}

TEST_CASE_METHOD(IntervalPropertyTableRegistryTestFixture, "DM - TV - IntervalPropertyComputer via JSON TablePipeline", "[IntervalPropertyComputer][JSON][Pipeline]") {

    SECTION("Test all property operations via JSON pipeline") {
        // JSON configuration for testing IntervalPropertyComputer through TablePipeline
        char const * json_config = R"({
            "metadata": {
                "name": "Interval Property Test",
                "description": "Test JSON execution of IntervalPropertyComputer",
                "version": "1.0"
            },
            "tables": [
                {
                    "table_id": "interval_property_test",
                    "name": "Interval Property Test Table",
                    "description": "Test table using IntervalPropertyComputer",
                    "row_selector": {
                        "type": "interval",
                        "source": "BehaviorPeriods"
                    },
                    "columns": [
                        {
                            "name": "IntervalStartTime",
                            "description": "Start time of each behavior period",
                            "data_source": "BehaviorPeriods",
                            "computer": "Interval Start"
                        },
                        {
                            "name": "IntervalEndTime",
                            "description": "End time of each behavior period",
                            "data_source": "BehaviorPeriods",
                            "computer": "Interval End"
                        },
                        {
                            "name": "IntervalDuration",
                            "description": "Duration of each behavior period",
                            "data_source": "BehaviorPeriods",
                            "computer": "Interval Duration"
                        }
                    ]
                }
            ]
        })";

        auto & pipeline = getTablePipeline();

        // Parse the JSON configuration
        nlohmann::json json_obj = nlohmann::json::parse(json_config);

        // Load configuration into pipeline
        bool load_success = pipeline.loadFromJson(json_obj);
        REQUIRE(load_success);

        // Verify configuration was loaded correctly
        auto table_configs = pipeline.getTableConfigurations();
        REQUIRE(table_configs.size() == 1);

        auto const & config = table_configs[0];
        REQUIRE(config.table_id == "interval_property_test");
        REQUIRE(config.name == "Interval Property Test Table");
        REQUIRE(config.columns.size() == 3);

        // Verify column configurations
        auto const & column1 = config.columns[0];
        REQUIRE(column1["name"] == "IntervalStartTime");
        REQUIRE(column1["computer"] == "Interval Start");
        REQUIRE(column1["data_source"] == "BehaviorPeriods");

        auto const & column2 = config.columns[1];
        REQUIRE(column2["name"] == "IntervalEndTime");
        REQUIRE(column2["computer"] == "Interval End");
        REQUIRE(column2["data_source"] == "BehaviorPeriods");

        auto const & column3 = config.columns[2];
        REQUIRE(column3["name"] == "IntervalDuration");
        REQUIRE(column3["computer"] == "Interval Duration");
        REQUIRE(column3["data_source"] == "BehaviorPeriods");

        // Verify row selector configuration
        REQUIRE(config.row_selector["type"] == "interval");
        REQUIRE(config.row_selector["source"] == "BehaviorPeriods");

        std::cout << "JSON pipeline configuration loaded and parsed successfully" << std::endl;

        // Execute the pipeline
        auto pipeline_result = pipeline.execute([](int table_index, std::string const & table_name, int table_progress, int overall_progress) {
            std::cout << "Building table " << table_index << " (" << table_name << "): "
                      << table_progress << "% (Overall: " << overall_progress << "%)" << std::endl;
        });

        if (pipeline_result.success) {
            std::cout << "Pipeline executed successfully!" << std::endl;
            std::cout << "Tables completed: " << pipeline_result.tables_completed << "/" << pipeline_result.total_tables << std::endl;
            std::cout << "Execution time: " << pipeline_result.total_execution_time_ms << " ms" << std::endl;

            // Verify the built table exists
            auto & registry = getTableRegistry();
            REQUIRE(registry.hasTable("interval_property_test"));

            // Get the built table and verify its structure
            auto built_table = registry.getBuiltTable("interval_property_test");
            REQUIRE(built_table != nullptr);

            // Check that the table has the expected columns
            auto column_names = built_table->getColumnNames();
            std::cout << "Built table has " << column_names.size() << " columns" << std::endl;
            for (auto const & name: column_names) {
                std::cout << "  Column: " << name << std::endl;
            }

            REQUIRE(column_names.size() == 3);
            REQUIRE(built_table->hasColumn("IntervalStartTime"));
            REQUIRE(built_table->hasColumn("IntervalEndTime"));
            REQUIRE(built_table->hasColumn("IntervalDuration"));

            // Verify table has 5 rows (one for each behavior period)
            REQUIRE(built_table->getRowCount() == 5);

            // Get and verify the computed values
            auto start_times = built_table->getColumnValues<double>("IntervalStartTime");
            auto end_times = built_table->getColumnValues<double>("IntervalEndTime");
            auto durations = built_table->getColumnValues<double>("IntervalDuration");

            REQUIRE(start_times.size() == 5);
            REQUIRE(end_times.size() == 5);
            REQUIRE(durations.size() == 5);

            for (size_t i = 0; i < 5; ++i) {
                REQUIRE(start_times[i] >= 0);                                         // Valid start times
                REQUIRE(end_times[i] > start_times[i]);                               // End > Start
                REQUIRE(durations[i] > 0);                                            // Positive durations
                REQUIRE(durations[i] == Catch::Approx(end_times[i] - start_times[i]));// Duration = End - Start

                std::cout << "Row " << i << ": Start=" << start_times[i]
                          << ", End=" << end_times[i] << ", Duration=" << durations[i] << std::endl;
            }

            // Verify specific expected values from our fixture
            REQUIRE(start_times[0] == Catch::Approx(10.0));// First period: 10-15
            REQUIRE(end_times[0] == Catch::Approx(15.0));
            REQUIRE(durations[0] == Catch::Approx(5.0));

            REQUIRE(start_times[1] == Catch::Approx(30.0));// Second period: 30-50
            REQUIRE(durations[1] == Catch::Approx(20.0));

        } else {
            std::cout << "Pipeline execution failed: " << pipeline_result.error_message << std::endl;
            FAIL("Pipeline execution failed: " + pipeline_result.error_message);
        }
    }

    SECTION("Test mixed interval properties with neural data") {
        char const * json_config = R"({
            "metadata": {
                "name": "Neural Event Property Test",
                "description": "Test IntervalPropertyComputer with neural events"
            },
            "tables": [
                {
                    "table_id": "neural_property_test",
                    "name": "Neural Event Property Table",
                    "description": "Test table using neural event intervals",
                    "row_selector": {
                        "type": "interval",
                        "source": "NeuralEvents"
                    },
                    "columns": [
                        {
                            "name": "EventStart",
                            "description": "Start time of neural events",
                            "data_source": "NeuralEvents",
                            "computer": "Interval Start"
                        },
                        {
                            "name": "EventDuration",
                            "description": "Duration of neural events",
                            "data_source": "NeuralEvents",
                            "computer": "Interval Duration"
                        }
                    ]
                }
            ]
        })";

        auto & pipeline = getTablePipeline();
        nlohmann::json json_obj = nlohmann::json::parse(json_config);

        bool load_success = pipeline.loadFromJson(json_obj);
        REQUIRE(load_success);

        auto table_configs = pipeline.getTableConfigurations();
        REQUIRE(table_configs.size() == 1);

        auto const & config = table_configs[0];
        REQUIRE(config.columns.size() == 2);
        REQUIRE(config.columns[0]["computer"] == "Interval Start");
        REQUIRE(config.columns[1]["computer"] == "Interval Duration");

        std::cout << "Neural event properties JSON configuration parsed successfully" << std::endl;

        // Execute the pipeline
        auto pipeline_result = pipeline.execute();

        if (pipeline_result.success) {
            std::cout << "✓ Neural event property pipeline executed successfully!" << std::endl;

            // Verify the built table exists and has correct structure
            auto & registry = getTableRegistry();
            REQUIRE(registry.hasTable("neural_property_test"));

            auto built_table = registry.getBuiltTable("neural_property_test");
            REQUIRE(built_table != nullptr);

            // Should have 4 rows (one for each neural event from our fixture)
            REQUIRE(built_table->getRowCount() == 4);
            REQUIRE(built_table->getColumnCount() == 2);
            REQUIRE(built_table->hasColumn("EventStart"));
            REQUIRE(built_table->hasColumn("EventDuration"));

            auto starts = built_table->getColumnValues<double>("EventStart");
            auto durations = built_table->getColumnValues<double>("EventDuration");

            REQUIRE(starts.size() == 4);
            REQUIRE(durations.size() == 4);

            // Expected neural events from fixture:
            // Event 1: 12-13 (duration = 1)
            // Event 2: 45-47 (duration = 2)
            // Event 3: 89-92 (duration = 3)
            // Event 4: 156-161 (duration = 5)
            std::vector<double> expected_starts = {12.0, 45.0, 89.0, 156.0};
            std::vector<double> expected_durations = {1.0, 2.0, 3.0, 5.0};

            for (size_t i = 0; i < 4; ++i) {
                REQUIRE(starts[i] == Catch::Approx(expected_starts[i]));
                REQUIRE(durations[i] == Catch::Approx(expected_durations[i]));
                std::cout << "Neural event " << i << ": Start=" << starts[i]
                          << ", Duration=" << durations[i] << std::endl;
            }

        } else {
            FAIL("Neural event pipeline execution failed: " + pipeline_result.error_message);
        }
    }
}

paulmthompson / WhiskerToolbox / 17920603410

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous