#2589

Committed 19 Sep 2025 08:50AM UTC coverage: 35.01% (-0.1%) from 35.146%

Build # #2589

Build Type

push

coveralls-python

Committed by

web-flow

Commit Message

Merge 38792c162 into f6f4be1e7

Run Details

62 of 260 new or added lines in 40 files covered. (23.85%)

6 existing lines in 5 files now uncovered.

4859 of 13879 relevant lines covered (35.01%)

0.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

30.14

/tool_graph/graph.py

from qgis.PyQt.QtCore import Qt
from threedi_results_analysis.tool_graph.graph_view import GraphDockWidget
from threedi_results_analysis.threedi_plugin_model import ThreeDiResultItem, ThreeDiGridItem
from threedi_results_analysis.threedi_plugin_tool import ThreeDiPluginTool
from qgis.PyQt.QtCore import pyqtSlot
import qgis
import os


class ThreeDiGraph(ThreeDiPluginTool):

    def __init__(self, iface, model):
        super().__init__()

        self.iface = iface
        self.model = model

        self.icon_path = os.path.join(os.path.dirname(os.path.dirname(__file__)), "icons", "icon_graph.png")
        self.menu_text = "Time series plotter"

        self.dock_widgets = []
        self.widget_nr = 0

    def on_unload(self):
        """
        on close of graph plugin
        """
        for widget in self.dock_widgets:
            widget.close()  # TODO: delete as well?

    def on_close_child_widget(self, widget_nr):
        """Cleanup necessary items here when plugin dockwidget is closed"""
        nr = None

        # find widget based on nr
        for i in range(0, len(self.dock_widgets)):
            widget = self.dock_widgets[i]
            if widget.nr == widget_nr:
                nr = i

        # close widget
        if nr is not None:
            widget = self.dock_widgets[nr]
            widget.closingWidget.disconnect(self.on_close_child_widget)

            del self.dock_widgets[nr]

    @pyqtSlot(ThreeDiResultItem)
    def result_added(self, result_item: ThreeDiResultItem):
        # Assign a line pattern to this result (TODO: consider keeping track of the patterns
        # in this plugin instead of storing in model?)
        if not result_item._pattern:
            result_item._pattern = ThreeDiGraph.get_line_pattern(result_item=result_item)

        self.action_icon.setEnabled(self.model.number_of_results() > 0)
        for dock_widget in self.dock_widgets:
            dock_widget.result_added(result_item)

    @pyqtSlot(ThreeDiResultItem)
    def result_removed(self, result_item: ThreeDiResultItem):
        self.action_icon.setEnabled(self.model.number_of_results() > 0)
        for dock_widget in self.dock_widgets:
            dock_widget.result_removed(result_item)

    @pyqtSlot(ThreeDiResultItem)
    def result_changed(self, result_item: ThreeDiResultItem):
        for dock_widget in self.dock_widgets:
            dock_widget.result_changed(result_item)

    @pyqtSlot(ThreeDiGridItem)
    def grid_changed(self, grid_item: ThreeDiGridItem):
        for dock_widget in self.dock_widgets:
            dock_widget.grid_changed(grid_item)

    def run(self):
        """
        Run method that loads and starts the plugin (docked graph widget)
        """
        # create the dockwidget
        self.widget_nr += 1
        new_widget = GraphDockWidget(
            iface=self.iface,
            nr=self.widget_nr,
            model=self.model,
        )
        self.dock_widgets.append(new_widget)

        # connect cleanup on closing of dockwidget
        new_widget.closingWidget.connect(self.on_close_child_widget)

        # show the dockwidget
        self.iface.addDockWidget(Qt.DockWidgetArea.BottomDockWidgetArea, new_widget)

        # make stack of graph widgets (instead of next to each other)
        if len(self.dock_widgets) > 1:
            window = qgis.core.QgsApplication.activeWindow()
            window.tabifyDockWidget(self.dock_widgets[0], new_widget)

        new_widget.show()

    @staticmethod
    def get_line_pattern(result_item: ThreeDiResultItem) -> Qt.PenStyle:
        """Determine (default) line pattern for this result plot

        Look at the already-used styles os sibblings and try to pick an unused one.

        :param item_field:
        """
        available_styles = [
            Qt.PenStyle.SolidLine,
            Qt.PenStyle.DashLine,
            Qt.PenStyle.DotLine,
            Qt.PenStyle.DashDotLine,
            Qt.PenStyle.DashDotDotLine,
        ]

        already_used_patterns = []
        grid_item = result_item.parent()
        for i in range(grid_item.rowCount()):
            if grid_item.child(i) is not result_item:
                sibling_pattern = grid_item.child(i)._pattern
                assert sibling_pattern
                already_used_patterns.append(sibling_pattern)

        for style in available_styles:
            if style not in already_used_patterns:
                # Hurray, an unused style.
                return style

        # No unused styles. Use the solid line style as a default.
        return Qt.PenStyle.SolidLine

1	from qgis.PyQt.QtCore import Qt	1✔
2	from threedi_results_analysis.tool_graph.graph_view import GraphDockWidget	1✔
3	from threedi_results_analysis.threedi_plugin_model import ThreeDiResultItem, ThreeDiGridItem	1✔
4	from threedi_results_analysis.threedi_plugin_tool import ThreeDiPluginTool	1✔
5	from qgis.PyQt.QtCore import pyqtSlot	1✔
6	import qgis	1✔
7	import os	1✔
8
9
10	class ThreeDiGraph(ThreeDiPluginTool):	1✔
11
12	def __init__(self, iface, model):	1✔
13	super().__init__()	×
14
15	self.iface = iface	×
16	self.model = model	×
17
18	self.icon_path = os.path.join(os.path.dirname(os.path.dirname(__file__)), "icons", "icon_graph.png")	×
19	self.menu_text = "Time series plotter"	×
20
21	self.dock_widgets = []	×
22	self.widget_nr = 0	×
23
24	def on_unload(self):	1✔
25	"""
26	on close of graph plugin
27	"""
28	for widget in self.dock_widgets:	×
29	widget.close() # TODO: delete as well?	×
30
31	def on_close_child_widget(self, widget_nr):	1✔
32	"""Cleanup necessary items here when plugin dockwidget is closed"""
33	nr = None	×
34
35	# find widget based on nr
36	for i in range(0, len(self.dock_widgets)):	×
37	widget = self.dock_widgets[i]	×
38	if widget.nr == widget_nr:	×
39	nr = i	×
40
41	# close widget
42	if nr is not None:	×
43	widget = self.dock_widgets[nr]	×
44	widget.closingWidget.disconnect(self.on_close_child_widget)	×
45
46	del self.dock_widgets[nr]	×
47
48	@pyqtSlot(ThreeDiResultItem)	1✔
49	def result_added(self, result_item: ThreeDiResultItem):	1✔
50	# Assign a line pattern to this result (TODO: consider keeping track of the patterns
51	# in this plugin instead of storing in model?)
52	if not result_item._pattern:	×
53	result_item._pattern = ThreeDiGraph.get_line_pattern(result_item=result_item)	×
54
55	self.action_icon.setEnabled(self.model.number_of_results() > 0)	×
56	for dock_widget in self.dock_widgets:	×
57	dock_widget.result_added(result_item)	×
58
59	@pyqtSlot(ThreeDiResultItem)	1✔
60	def result_removed(self, result_item: ThreeDiResultItem):	1✔
61	self.action_icon.setEnabled(self.model.number_of_results() > 0)	×
62	for dock_widget in self.dock_widgets:	×
63	dock_widget.result_removed(result_item)	×
64
65	@pyqtSlot(ThreeDiResultItem)	1✔
66	def result_changed(self, result_item: ThreeDiResultItem):	1✔
67	for dock_widget in self.dock_widgets:	×
68	dock_widget.result_changed(result_item)	×
69
70	@pyqtSlot(ThreeDiGridItem)	1✔
71	def grid_changed(self, grid_item: ThreeDiGridItem):	1✔
72	for dock_widget in self.dock_widgets:	×
73	dock_widget.grid_changed(grid_item)	×
74
75	def run(self):	1✔
76	"""
77	Run method that loads and starts the plugin (docked graph widget)
78	"""
79	# create the dockwidget
80	self.widget_nr += 1	×
81	new_widget = GraphDockWidget(	×
82	iface=self.iface,
83	nr=self.widget_nr,
84	model=self.model,
85	)
86	self.dock_widgets.append(new_widget)	×
87
88	# connect cleanup on closing of dockwidget
89	new_widget.closingWidget.connect(self.on_close_child_widget)	×
90
91	# show the dockwidget
NEW 92	self.iface.addDockWidget(Qt.DockWidgetArea.BottomDockWidgetArea, new_widget)	×
93
94	# make stack of graph widgets (instead of next to each other)
95	if len(self.dock_widgets) > 1:	×
96	window = qgis.core.QgsApplication.activeWindow()	×
97	window.tabifyDockWidget(self.dock_widgets[0], new_widget)	×
98
99	new_widget.show()	×
100
101	@staticmethod	1✔
102	def get_line_pattern(result_item: ThreeDiResultItem) -> Qt.PenStyle:	1✔
103	"""Determine (default) line pattern for this result plot
104
105	Look at the already-used styles os sibblings and try to pick an unused one.
106
107	:param item_field:
108	"""
109	available_styles = [	×
110	Qt.PenStyle.SolidLine,
111	Qt.PenStyle.DashLine,
112	Qt.PenStyle.DotLine,
113	Qt.PenStyle.DashDotLine,
114	Qt.PenStyle.DashDotDotLine,
115	]
116
117	already_used_patterns = []	×
118	grid_item = result_item.parent()	×
119	for i in range(grid_item.rowCount()):	×
120	if grid_item.child(i) is not result_item:	×
121	sibling_pattern = grid_item.child(i)._pattern	×
122	assert sibling_pattern	×
123	already_used_patterns.append(sibling_pattern)	×
124
125	for style in available_styles:	×
126	if style not in already_used_patterns:	×
127	# Hurray, an unused style.
128	return style	×
129
130	# No unused styles. Use the solid line style as a default.
NEW 131	return Qt.PenStyle.SolidLine	×

nens / ThreeDiToolbox / #2589

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous