• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4729

12 Sep 2025 02:34AM UTC coverage: 58.085% (-1.0%) from 59.125%
#4729

push

travis-ci

web-flow
docs: optimize taosd config parameters doc better (#32964)

133518 of 292959 branches covered (45.58%)

Branch coverage included in aggregate %.

201933 of 284559 relevant lines covered (70.96%)

5466318.3 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

69.04
/source/dnode/mnode/impl/src/mndSnode.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndDnode.h"
18
#include "mndPrivilege.h"
19
#include "mndShow.h"
20
#include "mndSnode.h"
21
#include "mndTrans.h"
22
#include "mndUser.h"
23
#include "mndStream.h"
24

25
#define SNODE_VER_NUMBER   2
26
#define SNODE_RESERVE_SIZE 64
27

28
static SSdbRaw *mndSnodeActionEncode(SSnodeObj *pObj);
29
static SSdbRow *mndSnodeActionDecode(SSdbRaw *pRaw);
30
static int32_t  mndSnodeActionInsert(SSdb *pSdb, SSnodeObj *pObj);
31
static int32_t  mndSnodeActionUpdate(SSdb *pSdb, SSnodeObj *pOld, SSnodeObj *pNew);
32
static int32_t  mndSnodeActionDelete(SSdb *pSdb, SSnodeObj *pObj);
33
static int32_t  mndProcessCreateSnodeReq(SRpcMsg *pReq);
34
static int32_t  mndProcessDropSnodeReq(SRpcMsg *pReq);
35
static int32_t  mndRetrieveSnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
36
static void     mndCancelGetNextSnode(SMnode *pMnode, void *pIter);
37

38
int32_t mndInitSnode(SMnode *pMnode) {
1,922✔
39
  SSdbTable table = {
1,922✔
40
      .sdbType = SDB_SNODE,
41
      .keyType = SDB_KEY_INT32,
42
      .encodeFp = (SdbEncodeFp)mndSnodeActionEncode,
43
      .decodeFp = (SdbDecodeFp)mndSnodeActionDecode,
44
      .insertFp = (SdbInsertFp)mndSnodeActionInsert,
45
      .updateFp = (SdbUpdateFp)mndSnodeActionUpdate,
46
      .deleteFp = (SdbDeleteFp)mndSnodeActionDelete,
47
  };
48

49
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_SNODE, mndProcessCreateSnodeReq);
1,922✔
50
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_SNODE, mndProcessDropSnodeReq);
1,922✔
51
  mndSetMsgHandle(pMnode, TDMT_DND_CREATE_SNODE_RSP, mndTransProcessRsp);
1,922✔
52
  mndSetMsgHandle(pMnode, TDMT_DND_ALTER_SNODE_RSP, mndTransProcessRsp);
1,922✔
53
  mndSetMsgHandle(pMnode, TDMT_DND_DROP_SNODE_RSP, mndTransProcessRsp);
1,922✔
54

55
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_SNODE, mndRetrieveSnodes);
1,922✔
56
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_SNODE, mndCancelGetNextSnode);
1,922✔
57

58
  return sdbSetTable(pMnode->pSdb, table);
1,922✔
59
}
60

61
void mndCleanupSnode(SMnode *pMnode) {}
1,922✔
62

63
SEpSet mndAcquireEpFromSnode(SMnode *pMnode, const SSnodeObj *pSnode) {
×
64
  SEpSet epSet = {.numOfEps = 1, .inUse = 0};
×
65
  memcpy(epSet.eps[0].fqdn, pSnode->pDnode->fqdn, TSDB_FQDN_LEN);
×
66
  epSet.eps[0].port = pSnode->pDnode->port;
×
67
  return epSet;
×
68
}
69

70
SSnodeObj *mndAcquireSnode(SMnode *pMnode, int32_t snodeId) {
2,209✔
71
  SSnodeObj *pObj = sdbAcquire(pMnode->pSdb, SDB_SNODE, &snodeId);
2,209✔
72
  if (pObj == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
2,209!
73
    terrno = TSDB_CODE_MND_SNODE_NOT_EXIST;
287✔
74
  }
75
  return pObj;
2,209✔
76
}
77

78
void mndReleaseSnode(SMnode *pMnode, SSnodeObj *pObj) {
2,006✔
79
  SSdb *pSdb = pMnode->pSdb;
2,006✔
80
  sdbRelease(pSdb, pObj);
2,006✔
81
}
2,006✔
82

83
static SSdbRaw *mndSnodeActionEncode(SSnodeObj *pObj) {
1,920✔
84
  int32_t code = 0;
1,920✔
85
  int32_t lino = 0;
1,920✔
86
  terrno = TSDB_CODE_OUT_OF_MEMORY;
1,920✔
87

88
  SSdbRaw *pRaw = sdbAllocRaw(SDB_SNODE, SNODE_VER_NUMBER, sizeof(SSnodeObj) + SNODE_RESERVE_SIZE);
1,920✔
89
  if (pRaw == NULL) goto _OVER;
1,920!
90

91
  int32_t dataPos = 0;
1,920✔
92
  SDB_SET_INT32(pRaw, dataPos, pObj->id, _OVER)
1,920!
93
  SDB_SET_INT32(pRaw, dataPos, pObj->leadersId[0], _OVER)
1,920!
94
  SDB_SET_INT32(pRaw, dataPos, pObj->leadersId[1], _OVER)
1,920!
95
  SDB_SET_INT32(pRaw, dataPos, pObj->replicaId, _OVER)
1,920!
96
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
1,920!
97
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
1,920!
98
  SDB_SET_RESERVE(pRaw, dataPos, SNODE_RESERVE_SIZE, _OVER)
1,920!
99

100
  terrno = 0;
1,920✔
101

102
_OVER:
1,920✔
103
  if (terrno != 0) {
1,920!
104
    mError("snode:%d, failed to encode to raw:%p since %s", pObj->id, pRaw, terrstr());
×
105
    sdbFreeRaw(pRaw);
×
106
    return NULL;
×
107
  }
108

109
  mTrace("snode:%d, encode to raw:%p, row:%p", pObj->id, pRaw, pObj);
1,920✔
110
  return pRaw;
1,920✔
111
}
112

113
static SSdbRow *mndSnodeActionDecode(SSdbRaw *pRaw) {
1,612✔
114
  int32_t code = 0;
1,612✔
115
  int32_t lino = 0;
1,612✔
116
  terrno = TSDB_CODE_OUT_OF_MEMORY;
1,612✔
117
  SSdbRow   *pRow = NULL;
1,612✔
118
  SSnodeObj *pObj = NULL;
1,612✔
119

120
  int8_t sver = 0;
1,612✔
121
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
1,612!
122

123
  if (sver != SNODE_VER_NUMBER) {
1,612!
124
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
125
    goto _OVER;
×
126
  }
127

128
  pRow = sdbAllocRow(sizeof(SSnodeObj));
1,612✔
129
  if (pRow == NULL) goto _OVER;
1,612!
130

131
  pObj = sdbGetRowObj(pRow);
1,612✔
132
  if (pObj == NULL) goto _OVER;
1,612!
133

134
  int32_t dataPos = 0;
1,612✔
135
  SDB_GET_INT32(pRaw, dataPos, &pObj->id, _OVER)
1,612!
136
  SDB_GET_INT32(pRaw, dataPos, &pObj->leadersId[0], _OVER)
1,612!
137
  SDB_GET_INT32(pRaw, dataPos, &pObj->leadersId[1], _OVER)
1,612!
138
  SDB_GET_INT32(pRaw, dataPos, &pObj->replicaId, _OVER)
1,612!
139
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
1,612!
140
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
1,612!
141
  SDB_GET_RESERVE(pRaw, dataPos, SNODE_RESERVE_SIZE, _OVER)
1,612!
142

143
  terrno = 0;
1,612✔
144

145
_OVER:
1,612✔
146
  if (terrno != 0) {
1,612!
147
    mError("snode:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->id, pRaw, terrstr());
×
148
    taosMemoryFreeClear(pRow);
×
149
    return NULL;
×
150
  }
151

152
  mDebug("snode:%d, decode from raw:%p, row:%p, leaderId[0]:%d, leaderId[1]:%d, replicaId:%d", pObj->id, pRaw, pObj, pObj->leadersId[0], pObj->leadersId[1], pObj->replicaId);
1,612!
153
  return pRow;
1,612✔
154
}
155

156
static int32_t mndSnodeActionInsert(SSdb *pSdb, SSnodeObj *pObj) {
225✔
157
  mTrace("snode:%d, perform insert action, row:%p", pObj->id, pObj);
225✔
158
  pObj->pDnode = sdbAcquire(pSdb, SDB_DNODE, &pObj->id);
225✔
159
  if (pObj->pDnode == NULL) {
225!
160
    terrno = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
161
    mError("snode:%d, failed to perform insert action since %s", pObj->id, terrstr());
×
162
    return -1;
×
163
  }
164

165
  return 0;
225✔
166
}
167

168
static int32_t mndSnodeActionDelete(SSdb *pSdb, SSnodeObj *pObj) {
1,612✔
169
  mTrace("snode:%d, perform delete action, row:%p", pObj->id, pObj);
1,612✔
170
  if (pObj->pDnode != NULL) {
1,612✔
171
    sdbRelease(pSdb, pObj->pDnode);
225✔
172
    pObj->pDnode = NULL;
225✔
173
  }
174

175
  return 0;
1,612✔
176
}
177

178
static int32_t mndSnodeActionUpdate(SSdb *pSdb, SSnodeObj *pOld, SSnodeObj *pNew) {
1,232✔
179
  mDebug("snode:%d, perform update action, old row:%p new row:%p", pOld->id, pOld, pNew);
1,232!
180
  pOld->leadersId[0] = pNew->leadersId[0];
1,232✔
181
  pOld->leadersId[1] = pNew->leadersId[1];
1,232✔
182
  pOld->replicaId = pNew->replicaId;
1,232✔
183
  pOld->updateTime = pNew->updateTime;
1,232✔
184
  return 0;
1,232✔
185
}
186

187
static int32_t mndSetCreateSnodeRedoLogs(STrans *pTrans, SSnodeObj *pObj) {
215✔
188
  int32_t  code = 0;
215✔
189
  SSdbRaw *pRedoRaw = mndSnodeActionEncode(pObj);
215✔
190
  if (pRedoRaw == NULL) {
215!
191
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
192
    if (terrno != 0) code = terrno;
×
193
    TAOS_RETURN(code);
×
194
  }
195
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
215!
196
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
215!
197
  TAOS_RETURN(code);
215✔
198
}
199

200
static int32_t mndSetUpdateSnodeRedoLogs(STrans *pTrans, SSnodeObj *pObj) {
431✔
201
  int32_t  code = 0;
431✔
202
  SSdbRaw *pRedoRaw = mndSnodeActionEncode(pObj);
431✔
203
  if (pRedoRaw == NULL) {
431!
204
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
205
    if (terrno != 0) code = terrno;
×
206
    TAOS_RETURN(code);
×
207
  }
208
  TAOS_CHECK_RETURN(mndTransAppendGroupRedolog(pTrans, pRedoRaw, -1));
431!
209
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
431!
210
  TAOS_RETURN(code);
431✔
211
}
212

213

214
static int32_t mndSetCreateSnodeUndoLogs(STrans *pTrans, SSnodeObj *pObj) {
215✔
215
  int32_t  code = 0;
215✔
216
  SSdbRaw *pUndoRaw = mndSnodeActionEncode(pObj);
215✔
217
  if (pUndoRaw == NULL) {
215!
218
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
219
    if (terrno != 0) code = terrno;
×
220
    TAOS_RETURN(code);
×
221
  }
222
  TAOS_CHECK_RETURN(mndTransAppendUndolog(pTrans, pUndoRaw));
215!
223
  TAOS_CHECK_RETURN(sdbSetRawStatus(pUndoRaw, SDB_STATUS_DROPPED));
215!
224
  TAOS_RETURN(code);
215✔
225
}
226

227
static int32_t mndSetCreateSnodeCommitLogs(STrans *pTrans, SSnodeObj *pObj) {
646✔
228
  int32_t  code = 0;
646✔
229
  SSdbRaw *pCommitRaw = mndSnodeActionEncode(pObj);
646✔
230
  if (pCommitRaw == NULL) {
646!
231
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
232
    if (terrno != 0) code = terrno;
×
233
    TAOS_RETURN(code);
×
234
  }
235
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
646!
236
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
646!
237
  TAOS_RETURN(code);
646✔
238
}
239

240
static int32_t mndSetCreateSnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SSnodeObj *pObj, SMnode *pMnode) {
215✔
241
  int32_t          code = 0;
215✔
242
  SDCreateSnodeReq createReq = {0};
215✔
243
  createReq.snodeId = pDnode->id;
215✔
244
  createReq.leaders[0].nodeId = pObj->leadersId[0];
215✔
245
  if (createReq.leaders[0].nodeId > 0) {
215✔
246
    createReq.leaders[0].epSet = mndGetDnodeEpsetById(pMnode, createReq.leaders[0].nodeId);
14✔
247
  }
248
  createReq.leaders[1].nodeId = pObj->leadersId[1];
215✔
249
  if (createReq.leaders[1].nodeId > 0) {
215!
250
    createReq.leaders[1].epSet = mndGetDnodeEpsetById(pMnode, createReq.leaders[1].nodeId);
×
251
  }
252
  createReq.replica.nodeId = pObj->replicaId;
215✔
253
  if (createReq.replica.nodeId > 0) {
215✔
254
    createReq.replica.epSet = mndGetDnodeEpsetById(pMnode, createReq.replica.nodeId);
156✔
255
  }
256

257
  int32_t contLen = tSerializeSDCreateSNodeReq(NULL, 0, &createReq);
215✔
258
  void   *pReq = taosMemoryMalloc(contLen);
215!
259
  if (pReq == NULL) {
215!
260
    code = terrno;
×
261
    TAOS_RETURN(code);
×
262
  }
263
  code = tSerializeSDCreateSNodeReq(pReq, contLen, &createReq);
215✔
264
  if (code < 0) {
215!
265
    mError("snode:%d, failed to serialize create drop snode request since %s", createReq.snodeId, terrstr());
×
266
  }
267

268
  STransAction action = {0};
215✔
269
  action.epSet = mndGetDnodeEpset(pDnode);
215✔
270
  action.pCont = pReq;
215✔
271
  action.contLen = contLen;
215✔
272
  action.msgType = TDMT_DND_CREATE_SNODE;
215✔
273
  action.acceptableCode = TSDB_CODE_SNODE_ALREADY_DEPLOYED;
215✔
274

275
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
215!
276
    taosMemoryFree(pReq);
×
277
    TAOS_RETURN(code);
×
278
  }
279

280
  TAOS_RETURN(code);
215✔
281
}
282

283
static int32_t mndSetUpdateSnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SSnodeObj *pObj, SMnode *pMnode) {
431✔
284
  int32_t          code = 0;
431✔
285
  SDCreateSnodeReq createReq = {0};
431✔
286
  createReq.snodeId = pDnode->id;
431✔
287
  createReq.leaders[0].nodeId = pObj->leadersId[0];
431✔
288
  if (createReq.leaders[0].nodeId > 0) {
431✔
289
    createReq.leaders[0].epSet = mndGetDnodeEpsetById(pMnode, createReq.leaders[0].nodeId);
381✔
290
  }
291
  createReq.leaders[1].nodeId = pObj->leadersId[1];
431✔
292
  if (createReq.leaders[1].nodeId > 0) {
431✔
293
    createReq.leaders[1].epSet = mndGetDnodeEpsetById(pMnode, createReq.leaders[1].nodeId);
69✔
294
  }
295
  createReq.replica.nodeId = pObj->replicaId;
431✔
296
  if (createReq.replica.nodeId > 0) {
431✔
297
    createReq.replica.epSet = mndGetDnodeEpsetById(pMnode, createReq.replica.nodeId);
421✔
298
  }
299

300
  int32_t contLen = tSerializeSDCreateSNodeReq(NULL, 0, &createReq);
431✔
301
  void   *pReq = taosMemoryMalloc(contLen);
431!
302
  if (pReq == NULL) {
431!
303
    code = terrno;
×
304
    TAOS_RETURN(code);
×
305
  }
306
  code = tSerializeSDCreateSNodeReq(pReq, contLen, &createReq);
431✔
307
  if (code < 0) {
431!
308
    mError("snode:%d, failed to serialize create drop snode request since %s", createReq.snodeId, terrstr());
×
309
  }
310

311
  STransAction action = {0};
431✔
312
  action.epSet = mndGetDnodeEpset(pDnode);
431✔
313
  action.pCont = pReq;
431✔
314
  action.contLen = contLen;
431✔
315
  action.msgType = TDMT_DND_ALTER_SNODE;
431✔
316
  action.acceptableCode = 0;
431✔
317
  action.groupId = -1;
431✔
318

319
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
431!
320
    taosMemoryFree(pReq);
×
321
    TAOS_RETURN(code);
×
322
  }
323

324
  TAOS_RETURN(code);
431✔
325
}
326

327

328
static int32_t mndSetCreateSnodeUndoActions(STrans *pTrans, SDnodeObj *pDnode, SSnodeObj *pObj) {
215✔
329
  int32_t        code = 0;
215✔
330
  SDDropSnodeReq dropReq = {0};
215✔
331
  dropReq.dnodeId = pDnode->id;
215✔
332

333
  int32_t contLen = tSerializeSCreateDropMQSNodeReq(NULL, 0, &dropReq);
215✔
334
  void   *pReq = taosMemoryMalloc(contLen);
215!
335
  if (pReq == NULL) {
215!
336
    code = terrno;
×
337
    TAOS_RETURN(code);
×
338
  }
339
  code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, &dropReq);
215✔
340
  if (code < 0) {
215!
341
    mError("snode:%d, failed to serialize create drop snode request since %s", dropReq.dnodeId, terrstr());
×
342
  }
343

344
  STransAction action = {0};
215✔
345
  action.epSet = mndGetDnodeEpset(pDnode);
215✔
346
  action.pCont = pReq;
215✔
347
  action.contLen = contLen;
215✔
348
  action.msgType = TDMT_DND_DROP_SNODE;
215✔
349
  action.acceptableCode = TSDB_CODE_SNODE_NOT_DEPLOYED;
215✔
350

351
  if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
215!
352
    taosMemoryFree(pReq);
×
353
    TAOS_RETURN(code);
×
354
  }
355

356
  TAOS_RETURN(code);
215✔
357
}
358

359
static int32_t mndCreateSnode(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateSnodeReq *pCreate, int64_t currTs) {
59✔
360
  int32_t code = -1;
59✔
361

362
  SSnodeObj snodeObj = {0};
59✔
363
  snodeObj.id = pDnode->id;
59✔
364
  snodeObj.createdTime = currTs;
59✔
365
  snodeObj.updateTime = snodeObj.createdTime;
59✔
366

367
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_NOTHING, pReq, "create-snode");
59✔
368
  if (pTrans == NULL) {
59!
369
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
370
    if (terrno != 0) code = terrno;
×
371
    goto _OVER;
×
372
  }
373
  mndTransSetSerial(pTrans);
59✔
374

375
  mInfo("trans:%d, used to create snode:%d", pTrans->id, pCreate->dnodeId);
59!
376

377
  TAOS_CHECK_GOTO(mndSetCreateSnodeRedoLogs(pTrans, &snodeObj), NULL, _OVER);
59!
378
  TAOS_CHECK_GOTO(mndSetCreateSnodeUndoLogs(pTrans, &snodeObj), NULL, _OVER);
59!
379
  TAOS_CHECK_GOTO(mndSetCreateSnodeCommitLogs(pTrans, &snodeObj), NULL, _OVER);
59!
380
  TAOS_CHECK_GOTO(mndSetCreateSnodeRedoActions(pTrans, pDnode, &snodeObj, pMnode), NULL, _OVER);
59!
381
  TAOS_CHECK_GOTO(mndSetCreateSnodeUndoActions(pTrans, pDnode, &snodeObj), NULL, _OVER);
59!
382
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
59!
383

384
  code = 0;
59✔
385

386
_OVER:
59✔
387
  mndTransDrop(pTrans);
59✔
388
  TAOS_RETURN(code);
59✔
389
}
390

391
static bool mndSnodeTraverseForCreate(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
642✔
392
  SSnodeObj* pSnode = pObj;
642✔
393
  SSnodeObj* pReplica = (SSnodeObj*)p1;
642✔
394
  SSnodeObj* pLeader = (SSnodeObj*)p2;
642✔
395
  bool* noLeaderGot = (bool*)p3;
642✔
396

397
  if (0 == pSnode->leadersId[0]) {
642✔
398
    *pReplica = *pSnode;
128✔
399
    if (pLeader->id > 0) {
128!
400
      return false;
×
401
    }
402

403
    *noLeaderGot = true;
128✔
404
  } else if (0 == pReplica->id && 0 == pSnode->leadersId[1]) {
514✔
405
    *pReplica = *pSnode;
105✔
406
  }
407

408
  if (0 == pSnode->replicaId && 0 == pLeader->id) {
642!
409
    *pLeader = *pSnode;
14✔
410
    if (*noLeaderGot) {
14!
411
      return false;
14✔
412
    }
413
  }
414

415
  return true;
628✔
416
}
417

418

419
void mndSnodeGetReplicaSnode(SMnode *pMnode, SMCreateSnodeReq *pCreate, SSnodeObj *pReplica, SSnodeObj* pLeader) {
156✔
420
  bool noLeaderGot = false;
156✔
421
  sdbTraverse(pMnode->pSdb, SDB_SNODE, mndSnodeTraverseForCreate, pReplica, pLeader, &noLeaderGot);
156✔
422
}
156✔
423

424
static int32_t mndSnodeAppendUpdateToTrans(SMnode *pMnode, SSnodeObj* pObj, STrans *pTrans) {
431✔
425
  int32_t code = TSDB_CODE_SUCCESS;
431✔
426
  int32_t lino = 0;
431✔
427
  SDnodeObj *pDnode2 = mndAcquireDnode(pMnode, pObj->id);
431✔
428
  if (pDnode2 == NULL) {
431!
429
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
430
    goto _exit;
×
431
  }
432
  
433
  SSnodeObj snodeObj2 = {0};
431✔
434
  snodeObj2.id = pObj->id;
431✔
435
  snodeObj2.leadersId[0] = pObj->leadersId[0];
431✔
436
  snodeObj2.leadersId[1] = pObj->leadersId[1];
431✔
437
  snodeObj2.replicaId = pObj->replicaId;
431✔
438
  snodeObj2.createdTime = pObj->createdTime;
431✔
439
  snodeObj2.updateTime = taosGetTimestampMs();
431✔
440
  
441
  mInfo("trans:%d, used to update snode:%d", pTrans->id, snodeObj2.id);
431!
442
  
443
  TAOS_CHECK_EXIT(mndSetUpdateSnodeRedoLogs(pTrans, &snodeObj2));
431!
444
  //TAOS_CHECK_EXIT(mndSetCreateSnodeUndoLogs(pTrans, &snodeObj2));
445
  TAOS_CHECK_EXIT(mndSetCreateSnodeCommitLogs(pTrans, &snodeObj2));
431!
446
  TAOS_CHECK_EXIT(mndSetUpdateSnodeRedoActions(pTrans, pDnode2, &snodeObj2, pMnode));
431!
447
  //TAOS_CHECK_EXIT(mndSetCreateSnodeUndoActions(pTrans, pDnode2, &snodeObj2));
448

449
_exit:
431✔
450

451
  mndReleaseDnode(pMnode, pDnode2);
431✔
452

453
  if (code) {
431!
454
    mError("%s failed at line %d, error:%s", __FUNCTION__, lino, tstrerror(code));
×
455
  }
456

457
  return code;  
431✔
458
}
459

460
static int32_t mndCreateSnodeWithReplicaId(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateSnodeReq *pCreate, int64_t currTs) {
156✔
461
  SSnodeObj replicaSnode = {0};
156✔
462
  SSnodeObj leaderSnode = {0};
156✔
463
  int32_t code = TSDB_CODE_SUCCESS;
156✔
464
  int32_t lino = 0;
156✔
465

466
  mndSnodeGetReplicaSnode(pMnode, pCreate, &replicaSnode, &leaderSnode);
156✔
467

468
  SSnodeObj snodeObj = {0};
156✔
469
  snodeObj.id = pDnode->id;
156✔
470
  if (leaderSnode.id > 0) {
156✔
471
    snodeObj.leadersId[0] = leaderSnode.id;
14✔
472
  }
473
  snodeObj.replicaId = replicaSnode.id;
156✔
474
  snodeObj.createdTime = currTs;
156✔
475
  snodeObj.updateTime = snodeObj.createdTime;
156✔
476

477
  if (leaderSnode.id > 0) {
156✔
478
    leaderSnode.replicaId = snodeObj.id;
14✔
479
  }
480

481
  if (replicaSnode.id > 0) {
156!
482
    SSnodeObj* pTarget = &replicaSnode;
156✔
483
    if (replicaSnode.id == leaderSnode.id) {
156✔
484
      pTarget = &leaderSnode;
14✔
485
    }
486
    if (pTarget->leadersId[0] > 0) {
156✔
487
      pTarget->leadersId[1] = snodeObj.id;
28✔
488
    } else {
489
      pTarget->leadersId[0] = snodeObj.id;
128✔
490
    }
491
  }
492

493
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_NOTHING, pReq, "create-snode");
156✔
494
  if (pTrans == NULL) {
156!
495
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
496
    if (terrno != 0) code = terrno;
×
497
    goto _exit;
×
498
  }
499
  
500
  mndTransSetSerial(pTrans);
156✔
501

502
  mInfo("trans:%d, used to create snode:%d", pTrans->id, pCreate->dnodeId);
156!
503

504
  TAOS_CHECK_EXIT(mndSetCreateSnodeRedoLogs(pTrans, &snodeObj));
156!
505
  TAOS_CHECK_EXIT(mndSetCreateSnodeUndoLogs(pTrans, &snodeObj));
156!
506
  TAOS_CHECK_EXIT(mndSetCreateSnodeCommitLogs(pTrans, &snodeObj));
156!
507
  TAOS_CHECK_EXIT(mndSetCreateSnodeRedoActions(pTrans, pDnode, &snodeObj, pMnode));
156!
508
  TAOS_CHECK_EXIT(mndSetCreateSnodeUndoActions(pTrans, pDnode, &snodeObj));
156!
509

510
  if (leaderSnode.id > 0) {
156✔
511
    TAOS_CHECK_EXIT(mndSnodeAppendUpdateToTrans(pMnode, &leaderSnode, pTrans));
14!
512
  }
513

514
  if (replicaSnode.id > 0 && replicaSnode.id != leaderSnode.id) {
156!
515
    TAOS_CHECK_EXIT(mndSnodeAppendUpdateToTrans(pMnode, &replicaSnode, pTrans));
142!
516
  }
517

518
  TAOS_CHECK_EXIT(mndTransPrepare(pMnode, pTrans));
156!
519

520
_exit:
156✔
521

522
  mndTransDrop(pTrans);
156✔
523

524
  if (code) {
156!
525
    mError("%s failed at line %d, error:%s", __FUNCTION__, lino, tstrerror(code));
×
526
  }
527
  
528
  TAOS_RETURN(code);
156✔
529
}
530

531

532
static int32_t mndProcessCreateSnodeReq(SRpcMsg *pReq) {
283✔
533
  SMnode          *pMnode = pReq->info.node;
283✔
534
  int32_t          code = -1;
283✔
535
  SSnodeObj       *pObj = NULL;
283✔
536
  SDnodeObj       *pDnode = NULL;
283✔
537
  SMCreateSnodeReq createReq = {0};
283✔
538

539
  TAOS_CHECK_GOTO(tDeserializeSCreateDropMQSNodeReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
283!
540

541
  mInfo("snode:%d, start to create", createReq.dnodeId);
283!
542
  
543
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CREATE_SNODE), NULL, _OVER);
283✔
544

545
  pObj = mndAcquireSnode(pMnode, createReq.dnodeId);
272✔
546
  if (pObj != NULL) {
272✔
547
    code = TSDB_CODE_MND_SNODE_ALREADY_EXIST;
57✔
548
    mndReleaseSnode(pMnode, pObj);
57✔
549
    goto _OVER;
57✔
550
  } else if (terrno != TSDB_CODE_MND_SNODE_NOT_EXIST) {
215!
551
    goto _OVER;
×
552
  }
553

554
  pDnode = mndAcquireDnode(pMnode, createReq.dnodeId);
215✔
555
  if (pDnode == NULL) {
215!
556
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
557
    goto _OVER;
×
558
  }
559

560
  int64_t currTs = taosGetTimestampMs();
215✔
561
  int32_t snodeNum = sdbGetSize(pMnode->pSdb, SDB_SNODE);
215✔
562
  if (snodeNum > 0) {
215✔
563
    code = mndCreateSnodeWithReplicaId(pMnode, pReq, pDnode, &createReq, currTs);
156✔
564
  } else {
565
    code = mndCreateSnode(pMnode, pReq, pDnode, &createReq, currTs);
59✔
566
  }
567
  
568
  if (code == 0) {
215!
569
    code = TSDB_CODE_ACTION_IN_PROGRESS;
215✔
570
    
571
    MND_STREAM_SET_LAST_TS(STM_EVENT_CREATE_SNODE, currTs);
215!
572
  }
573

574
_OVER:
×
575

576
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
283!
577
    mError("snode:%d, failed to create since %s", createReq.dnodeId, tstrerror(code));
68!
578
  }
579

580
  mndReleaseDnode(pMnode, pDnode);
283✔
581
  tFreeSMCreateQnodeReq(&createReq);
283✔
582
  TAOS_RETURN(code);
283✔
583
}
584

585
static int32_t mndSetDropSnodeRedoLogs(STrans *pTrans, SSnodeObj *pObj) {
155✔
586
  int32_t  code = 0;
155✔
587
  SSdbRaw *pRedoRaw = mndSnodeActionEncode(pObj);
155✔
588
  if (pRedoRaw == NULL) {
155!
589
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
590
    if (terrno != 0) code = terrno;
×
591
    TAOS_RETURN(code);
×
592
  }
593
  TAOS_CHECK_RETURN(mndTransAppendGroupRedolog(pTrans, pRedoRaw, -1));
155!
594
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
155!
595
  TAOS_RETURN(code);
155✔
596
}
597

598
static int32_t mndSetDropSnodeCommitLogs(STrans *pTrans, SSnodeObj *pObj) {
155✔
599
  int32_t  code = 0;
155✔
600
  SSdbRaw *pCommitRaw = mndSnodeActionEncode(pObj);
155✔
601
  if (pCommitRaw == NULL) {
155!
602
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
603
    if (terrno != 0) code = terrno;
×
604
    TAOS_RETURN(code);
×
605
  }
606
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
155!
607
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
155!
608
  TAOS_RETURN(code);
155✔
609
}
610

611
static int32_t mndSetDropSnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SSnodeObj *pObj) {
155✔
612
  int32_t        code = 0;
155✔
613
  SDDropSnodeReq dropReq = {0};
155✔
614
  dropReq.dnodeId = pDnode->id;
155✔
615

616
  int32_t contLen = tSerializeSCreateDropMQSNodeReq(NULL, 0, &dropReq);
155✔
617
  void   *pReq = taosMemoryMalloc(contLen);
155!
618
  if (pReq == NULL) {
155!
619
    code = terrno;
×
620
    TAOS_RETURN(code);
×
621
  }
622
  code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, &dropReq);
155✔
623
  if (code < 0) {
155!
624
    mError("snode:%d, failed to serialize create drop snode request since %s", dropReq.dnodeId, terrstr());
×
625
  }
626

627
  STransAction action = {0};
155✔
628
  action.epSet = mndGetDnodeEpset(pDnode);
155✔
629
  action.pCont = pReq;
155✔
630
  action.contLen = contLen;
155✔
631
  action.msgType = TDMT_DND_DROP_SNODE;
155✔
632
  action.acceptableCode = TSDB_CODE_SNODE_NOT_DEPLOYED;
155✔
633
  action.groupId = -1;
155✔
634

635
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
155!
636
    taosMemoryFree(pReq);
×
637
    TAOS_RETURN(code);
×
638
  }
639

640
  TAOS_RETURN(code);
155✔
641
}
642

643
int32_t mndSetDropSnodeInfoToTrans(SMnode *pMnode, STrans *pTrans, SSnodeObj *pObj, bool force) {
155✔
644
  if (pObj == NULL) return 0;
155!
645
  TAOS_CHECK_RETURN(mndSetDropSnodeRedoLogs(pTrans, pObj));
155!
646
  TAOS_CHECK_RETURN(mndSetDropSnodeCommitLogs(pTrans, pObj));
155!
647
  if (!force) {
155!
648
    TAOS_CHECK_RETURN(mndSetDropSnodeRedoActions(pTrans, pObj->pDnode, pObj));
155!
649
  }
650
  return 0;
155✔
651
}
652

653
static bool mndSnodeTraverseForDropAff(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
×
654
  SSnodeObj* pSnode = pObj;
×
655
  SSnodeDropTraversaCtx* ctx = (SSnodeDropTraversaCtx*)p1;
×
656

657
  if (pSnode->replicaId == ctx->target->id) {
×
658
    if (ctx->affNum <= 1) {
×
659
      ctx->affSnode[ctx->affNum++] = *pSnode;
×
660
    } else {
661
      mError("%d snodes with same replicaId:%d, %d, %d, %d", ctx->affNum + 1, ctx->target->id, 
×
662
          ctx->affSnode[0].id, ctx->affSnode[1].id, pSnode->id);
663
    }
664
  }
665

666
  return true;
×
667
}
668

669
static bool mndSnodeTraverseForNewReplica(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
86✔
670
  SSnodeObj* pSnode = pObj;
86✔
671
  SSnodeObj* pSnode1 = (SSnodeObj*)p1;
86✔
672
  SSnodeObj* pSnode2 = (SSnodeObj*)p2;
86✔
673

674
  if (pSnode->id == pSnode1->id || pSnode->id == pSnode2->id) {
86✔
675
    return true;
42✔
676
  }
677

678
  int32_t n = pSnode->leadersId[0] ? (pSnode->leadersId[1] ? 2 : 1) : 0;
44!
679
  if (0 == n) {
44✔
680
    *(SSnodeObj*)p3 = *pSnode;
20✔
681
    return false;
20✔
682
  } else if (1 == n && 0 == ((SSnodeObj*)p3)->id) {
24!
683
    *(SSnodeObj*)p3 = *pSnode;
14✔
684
  }
685

686
  return true;
24✔
687
}
688

689

690
static int32_t mndSnodeCheckDropReplica(SMnode *pMnode, SSnodeObj* pObj, SSnodeDropTraversaCtx* pCtx) {
×
691
  int32_t snodeNum = sdbGetSize(pMnode->pSdb, SDB_SNODE);
×
692
  if (snodeNum <= 1) {
×
693
    mWarn("no need to get drop snode replica, replicaId:%d, remainSnode:%d", pObj->replicaId, snodeNum);
×
694
    return TSDB_CODE_SUCCESS;
×
695
  }
696

697
  sdbTraverse(pMnode->pSdb, SDB_SNODE, mndSnodeTraverseForDropAff, pCtx, NULL, NULL);
×
698

699
  if (0 == pCtx->affNum) {
×
700
    mDebug("no affected snode for dropping snode %d", pObj->id);
×
701
    return TSDB_CODE_SUCCESS;
×
702
  }
703

704
  if (2 == pCtx->affNum) {
×
705
    sdbTraverse(pMnode->pSdb, SDB_SNODE, mndSnodeTraverseForNewReplica, pCtx->target, &pCtx->affSnode[0], &pCtx->affNewReplica[0]);
×
706
    sdbTraverse(pMnode->pSdb, SDB_SNODE, mndSnodeTraverseForNewReplica, pCtx->target, &pCtx->affSnode[1], &pCtx->affNewReplica[1]);
×
707

708
    mDebug("two affected snodes for dropping snode %d, first:%d newRId:%d, sencod:%d newRId:%d", 
×
709
        pObj->id, pCtx->affSnode[0].id, pCtx->affNewReplica[0].id, pCtx->affSnode[1].id, pCtx->affNewReplica[1].id);
710

711
    return TSDB_CODE_SUCCESS;
×
712
  }
713

714
  SSnodeObj* replicaSnode = mndAcquireSnode(pMnode, pObj->replicaId);
×
715
  pCtx->affNewReplica[0] = *replicaSnode;
×
716
  mndReleaseSnode(pMnode, replicaSnode);
×
717
  
718
  mDebug("one affected snodes for dropping snode %d, first:%d newRId:%d", pObj->id, pCtx->affSnode[0].id, pCtx->affNewReplica[0].id);
×
719

720
  return TSDB_CODE_SUCCESS;
×
721
}
722

723
static void mndSnodeRemoveLeaderId(SSnodeObj *pObj, int32_t leaderId) {
465✔
724
  if (NULL == pObj || 0 == pObj->id) {
465!
725
    return;
210✔
726
  }
727
  
728
  if (pObj->leadersId[1] == leaderId) {
255✔
729
    pObj->leadersId[1] = 0;
18✔
730
    return;
18✔
731
  }
732

733
  if (pObj->leadersId[0] == leaderId) {
237✔
734
    if (pObj->leadersId[1] > 0) {
132✔
735
      pObj->leadersId[0] = pObj->leadersId[1];
22✔
736
      pObj->leadersId[1] = 0;
22✔
737
      return;
22✔
738
    }
739

740
    pObj->leadersId[0] = 0;
110✔
741
  }
742
}
743

744
static void mndSnodeAddLeaderId(SSnodeObj *pObj, int32_t leaderId) {
153✔
745
  if (NULL == pObj || 0 == pObj->id || 0 == leaderId) {
153!
746
    return;
10✔
747
  }
748
  
749
  if (0 == pObj->leadersId[0]) {
143✔
750
    pObj->leadersId[0] = leaderId;
109✔
751
    return;
109✔
752
  }
753

754
  if (0 == pObj->leadersId[1]) {
34!
755
    pObj->leadersId[1] = leaderId;
34✔
756
    return;
34✔
757
  }
758

759
  mError("snode %d can't add new leaderId %d since already has two leaders:%d, %d", pObj->id, leaderId, pObj->leadersId[0], pObj->leadersId[1]);
×
760
}
761

762
int32_t mndDropSnodeImpl(SMnode *pMnode, SRpcMsg *pReq, SSnodeObj *pObj, STrans *pTrans, bool force) {
155✔
763
  int32_t code = TSDB_CODE_SUCCESS;
155✔
764
  int32_t lino = 0;
155✔
765
  SArray* streamList = NULL;
155✔
766
  SSnodeObj asReplicaOf[2] = {0};
155✔
767
  SSnodeObj replicaSnode = {0};
155✔
768
  SSnodeObj* pTmp = NULL;
155✔
769

770
  if (pObj->leadersId[0] > 0) {
155✔
771
    pTmp = mndAcquireSnode(pMnode, pObj->leadersId[0]);
132✔
772
    TSDB_CHECK_NULL(pTmp, code, lino, _exit, terrno);
132!
773
    asReplicaOf[0] = *pTmp;
132✔
774
    mndReleaseSnode(pMnode, pTmp);
132✔
775
  }  
776

777
  if (pObj->leadersId[1] > 0) {
155✔
778
    pTmp = mndAcquireSnode(pMnode, pObj->leadersId[1]);
21✔
779
    TSDB_CHECK_NULL(pTmp, code, lino, _exit, terrno);
21!
780
    asReplicaOf[1] = *pTmp;
21✔
781
    mndReleaseSnode(pMnode, pTmp);
21✔
782
  }
783

784
  if (pObj->replicaId > 0 && pObj->replicaId != pObj->leadersId[0] && pObj->replicaId != pObj->leadersId[1]) {
155✔
785
    pTmp = mndAcquireSnode(pMnode, pObj->replicaId);
102✔
786
    TSDB_CHECK_NULL(pTmp, code, lino, _exit, terrno);
102!
787
    replicaSnode = *pTmp;
102✔
788
    mndReleaseSnode(pMnode, pTmp);
102✔
789
  }
790
  
791
  TAOS_CHECK_EXIT(msmCheckSnodeReassign(pMnode, pObj, &streamList));
155!
792

793
  int32_t streamNum = taosArrayGetSize(streamList);
155✔
794
  if (streamNum > 0) {
155✔
795
    for (int32_t i = 0; i < streamNum; ++i) {
10✔
796
      SStreamObj* pStream = taosArrayGetP(streamList, i);
6✔
797
      atomic_store_32(&pStream->mainSnodeId, pObj->replicaId);
6✔
798
      TAOS_CHECK_EXIT(mndStreamTransAppend(pStream, pTrans, SDB_STATUS_READY));
6!
799
    }
800
  }
801

802
  mndSnodeRemoveLeaderId(&asReplicaOf[0], pObj->id);
155✔
803
  mndSnodeRemoveLeaderId(&asReplicaOf[1], pObj->id);
155✔
804
  mndSnodeRemoveLeaderId(&replicaSnode, pObj->id);
155✔
805

806
  if (asReplicaOf[0].id > 0) {
155✔
807
    if (asReplicaOf[1].id > 0) {
132✔
808
      asReplicaOf[0].replicaId = asReplicaOf[1].id;
21✔
809
      asReplicaOf[1].replicaId = asReplicaOf[0].id;
21✔
810
      mndSnodeAddLeaderId(&asReplicaOf[0], asReplicaOf[1].id);
21✔
811
      mndSnodeAddLeaderId(&asReplicaOf[1], asReplicaOf[0].id);
21✔
812
    } else {
813
      if (0 == replicaSnode.id) {
111✔
814
        sdbTraverse(pMnode->pSdb, SDB_SNODE, mndSnodeTraverseForNewReplica, pObj, &asReplicaOf[0], &replicaSnode);
30✔
815
      }
816
      
817
      asReplicaOf[0].replicaId = replicaSnode.id;
111✔
818
      mndSnodeAddLeaderId(&replicaSnode, asReplicaOf[0].id);
111✔
819
    }
820
  }
821

822
  if (asReplicaOf[0].id > 0) {
155✔
823
    mInfo("trans:%d, used to update snode:%d", pTrans->id, asReplicaOf[0].id);
132!
824
    TAOS_CHECK_EXIT(mndSnodeAppendUpdateToTrans(pMnode, &asReplicaOf[0], pTrans));
132!
825
  }
826
  if (asReplicaOf[1].id > 0) {
155✔
827
    mInfo("trans:%d, used to update snode:%d", pTrans->id, asReplicaOf[1].id);
21!
828
    TAOS_CHECK_EXIT(mndSnodeAppendUpdateToTrans(pMnode, &asReplicaOf[1], pTrans));
21!
829
  }
830
  if (replicaSnode.id > 0) {
155✔
831
    mInfo("trans:%d, used to update snode:%d", pTrans->id, replicaSnode.id);
122!
832
    TAOS_CHECK_EXIT(mndSnodeAppendUpdateToTrans(pMnode, &replicaSnode, pTrans));
122!
833
  }
834

835
  mInfo("trans:%d, used to drop snode:%d", pTrans->id, pObj->id);
155!
836
  TAOS_CHECK_GOTO(mndSetDropSnodeInfoToTrans(pMnode, pTrans, pObj, force), NULL, _exit);
155!
837
  
838
_exit:
155✔
839

840
  taosArrayDestroy(streamList);
155✔
841

842
  if (code) {
155!
843
    mError("%s failed at line %d, error:%s", __FUNCTION__, lino, tstrerror(code));
×
844
  }
845
  
846
  TAOS_RETURN(code);
155✔
847
}
848

849

850
static int32_t mndDropSnode(SMnode *pMnode, SRpcMsg *pReq, SSnodeObj *pObj) {
152✔
851
  int32_t code = TSDB_CODE_SUCCESS;
152✔
852
  int32_t lino = 0;
152✔
853
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_NOTHING, pReq, "drop-snode");
152✔
854
  if (pTrans == NULL) {
152!
855
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
856
    if (terrno != 0) code = terrno;
×
857
    goto _exit;
×
858
  }
859
  mndTransSetSerial(pTrans);
152✔
860

861
  TAOS_CHECK_GOTO(mndDropSnodeImpl(pMnode, pReq, pObj, pTrans, false), &lino, _exit);
152!
862
  
863
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), &lino, _exit);
152!
864

865
_exit:
152✔
866

867
  mndTransDrop(pTrans);
152✔
868

869
  if (code) {
152!
870
    mError("%s failed at line %d, error:%s", __FUNCTION__, lino, tstrerror(code));
×
871
  }
872
  
873
  TAOS_RETURN(code);
152✔
874
}
875

876
static int32_t mndProcessDropSnodeReq(SRpcMsg *pReq) {
207✔
877
  SMnode        *pMnode = pReq->info.node;
207✔
878
  int32_t        code = -1;
207✔
879
  SSnodeObj     *pObj = NULL;
207✔
880
  SMDropSnodeReq dropReq = {0};
207✔
881

882
  TAOS_CHECK_GOTO(tDeserializeSCreateDropMQSNodeReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
207!
883

884
  mInfo("snode:%d, start to drop", dropReq.dnodeId);
207!
885
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_DROP_SNODE), NULL, _OVER);
207✔
886

887
  if (dropReq.dnodeId <= 0) {
196!
888
    code = TSDB_CODE_INVALID_MSG;
×
889
    goto _OVER;
×
890
  }
891

892
  pObj = mndAcquireSnode(pMnode, dropReq.dnodeId);
196✔
893
  if (pObj == NULL) {
196✔
894
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
44✔
895
    if (terrno != 0) code = terrno;
44!
896
    goto _OVER;
44✔
897
  }
898

899
  // check deletable
900
  code = mndDropSnode(pMnode, pReq, pObj);
152✔
901
  if (code == 0) {
152!
902
    code = TSDB_CODE_ACTION_IN_PROGRESS;
152✔
903

904
    MND_STREAM_SET_LAST_TS(STM_EVENT_DROP_SNODE, taosGetTimestampMs());
304!
905
  }
906

907
_OVER:
×
908
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
207!
909
    mError("snode:%d, failed to drop since %s", dropReq.dnodeId, tstrerror(code));
55!
910
  }
911

912
  mndReleaseSnode(pMnode, pObj);
207✔
913
  tFreeSMCreateQnodeReq(&dropReq);
207✔
914
  TAOS_RETURN(code);
207✔
915
}
916

917
static int32_t mndRetrieveSnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
378✔
918
  SMnode    *pMnode = pReq->info.node;
378✔
919
  SSdb      *pSdb = pMnode->pSdb;
378✔
920
  int32_t    numOfRows = 0;
378✔
921
  int32_t    cols = 0;
378✔
922
  SSnodeObj *pObj = NULL;
378✔
923

924
  while (numOfRows < rows) {
1,902!
925
    pShow->pIter = sdbFetch(pSdb, SDB_SNODE, pShow->pIter, (void **)&pObj);
1,902✔
926
    if (pShow->pIter == NULL) break;
1,902✔
927

928
    cols = 0;
1,524✔
929
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,524✔
930
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->id, false), pSdb, pObj);
1,524!
931

932
    char ep[TSDB_EP_LEN + VARSTR_HEADER_SIZE] = {0};
1,524✔
933
    STR_WITH_MAXSIZE_TO_VARSTR(ep, pObj->pDnode->ep, pShow->pMeta->pSchemas[cols].bytes);
1,524✔
934

935
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,524✔
936
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)ep, false), pSdb, pObj);
1,524!
937

938
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,524✔
939
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->createdTime, false), pSdb,
1,524!
940
                                   pObj);
941

942
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,524✔
943
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->replicaId, false), pSdb,
1,524!
944
                                   pObj);
945

946
    char asReplicaOf[64 + VARSTR_HEADER_SIZE] = {0};
1,524✔
947
    if (pObj->leadersId[0] && pObj->leadersId[1]) {
1,524✔
948
      snprintf(varDataVal(asReplicaOf), sizeof(asReplicaOf) - VARSTR_HEADER_SIZE, "%d, %d", pObj->leadersId[0], pObj->leadersId[1]);
251✔
949
    } else if (pObj->leadersId[0] || pObj->leadersId[1]) {
1,273!
950
      snprintf(varDataVal(asReplicaOf), sizeof(asReplicaOf) - VARSTR_HEADER_SIZE, "%d", pObj->leadersId[0] ? pObj->leadersId[0] : pObj->leadersId[1]);
942!
951
    } else {
952
      strcpy(varDataVal(asReplicaOf), "None");
331✔
953
    }
954
    varDataSetLen(asReplicaOf, strlen(varDataVal(asReplicaOf)));
1,524✔
955
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,524✔
956
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)asReplicaOf, false), pSdb,
1,524!
957
                                  pObj);
958

959
    numOfRows++;
1,524✔
960
    sdbRelease(pSdb, pObj);
1,524✔
961
  }
962

963
  pShow->numOfRows += numOfRows;
378✔
964

965
  return numOfRows;
378✔
966
}
967

968
static void mndCancelGetNextSnode(SMnode *pMnode, void *pIter) {
×
969
  SSdb *pSdb = pMnode->pSdb;
×
970
  sdbCancelFetchByType(pSdb, pIter, SDB_SNODE);
×
971
}
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc