17669567316

Committed 12 Sep 2025 08:50AM UTC coverage: 64.971% (-1.0%) from 66.018%

Build # 17669567316

Build Type

Pull #16073

github

Committed by

web-flow

Commit Message

Merge 557c9a967 into 1f79f8639

Pull Request Pull Request #16073: auth: simple protobuf logging support

Run Details

34815 of 81290 branches covered (42.83%)

Branch coverage included in aggregate %.

107406 of 137608 relevant lines covered (78.05%)

3556626.24 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/ext/yahttp/yahttp/router.cpp

/* @file
 * @brief Concrete implementation of Router 
 */
#include "yahttp.hpp"
#include "router.hpp"

namespace YaHTTP {
  // router is defined here.
  YaHTTP::Router Router::router;

  void Router::map(const std::string& method, const std::string& url, THandlerFunction handler, const std::string& name) {
    std::string method2 = method;
    bool isopen=false;
    // add into vector
    for(std::string::const_iterator i = url.begin(); i != url.end(); i++) {
       if (*i == '<' && isopen) throw Error("Invalid URL mask, cannot have < after <");
       if (*i == '<') isopen = true;
       if (*i == '>' && !isopen) throw Error("Invalid URL mask, cannot have > without < first");
       if (*i == '>') isopen = false;
    }
    std::transform(method2.begin(), method2.end(), method2.begin(), ::toupper); 
    routes.push_back(funcptr::make_tuple(method2, url, handler, name));
  };

  bool Router::match(const std::string& route, const URL& requrl, std::map<std::string, TDelim> &params) {
     size_t rpos = 0;
     size_t upos = 0;
     size_t npos = 0;
     size_t nstart = 0;
     size_t nend = 0;
     std::string pname;
     for(; rpos < route.size() && upos < requrl.path.size(); ) {
        if (route[rpos] == '<') {
          nstart = upos;
          npos = rpos+1;
          // start of parameter
          while(rpos < route.size() && route[rpos] != '>') {
            rpos++;
          }
          pname = std::string(route.begin()+static_cast<long>(npos), route.begin()+static_cast<long>(rpos));
          // then we also look it on the url
          if (pname[0] == '*') {
            pname = pname.substr(1);
            // this matches whatever comes after it, basically end of string
            nend = requrl.path.size();
            if (!pname.empty()) {
              params[pname] = funcptr::tie(nstart,nend);
            }
            rpos = route.size();
            upos = requrl.path.size();
            break;
          }
          // match until url[upos] or next / if pattern is at end
          while (upos < requrl.path.size()) {
            if (route[rpos+1] == '\0' && requrl.path[upos] == '/') {
              break;
            }
            if (requrl.path[upos] == route[rpos+1]) {
              break;
            }
            upos++;
          }
          nend = upos;
          params[pname] = funcptr::tie(nstart, nend);
          if (upos > 0) {
            upos--;
          }
          else {
            // If upos is zero, do not decrement it and then increment at bottom of loop, this disturbs Coverity.
            // Only increment rpos and continue loop
            rpos++;
            continue;
          }
        }
        else if (route[rpos] != requrl.path[upos]) {
          break;
        }

        rpos++; upos++;
      }
      return route[rpos] == requrl.path[upos];
  }

  RoutingResult Router::route(Request *req, THandlerFunction& handler) {
    std::map<std::string, TDelim> params;
    bool matched = false;
    bool seen = false;
    std::string rname;

    // iterate routes
    for (auto& route: routes) {
      std::string method;
      std::string url;
      funcptr::tie(method, url, handler, rname) = route;

      // see if we can't match the url
      params.clear();
      // simple matcher func
      matched = match(url, req->url, params);

      if (matched && !method.empty() && req->method != method) {
         // method did not match, record it though so we can return correct result
         matched = false;
         // The OPTIONS handler registered in pdns/webserver.cc matches every
         // url, and would cause "not found" errors to always be superseded
         // with "found, but wrong method" errors, so don't pretend there has
         // been a match in this case.
         if (method != "OPTIONS") {
           seen = true;
         }
         continue;
      }
      if (matched) {
        break;
      }
    }

    if (!matched) {
      if (seen) {
        return RouteNoMethod;
      }
      // no route
      return RouteNotFound;
    }

    req->parameters.clear();

    for (const auto& param: params) {
      int nstart = 0;
      int nend = 0;
      funcptr::tie(nstart, nend) = param.second;
      std::string value(req->url.path.begin() + nstart, req->url.path.begin() + nend);
      value = Utility::decodeURL(value);
      req->parameters[param.first] = std::move(value);
    }

    req->routeName = std::move(rname);

    return RouteFound;
  };

  void Router::printRoutes(std::ostream &os) {
    for(TRouteList::iterator i = routes.begin(); i != routes.end(); i++) {
#if __cplusplus >= 201103L
      std::streamsize ss = os.width();
      std::ios::fmtflags ff = os.setf(std::ios::left);
      os.width(10);
      os << std::get<0>(*i);
      os.width(50);
      os << std::get<1>(*i);
      os.width(ss);
      os.setf(ff);
      os << "    " << std::get<3>(*i);
      os << std::endl;
#else
      os << i->get<0>() << "    " << i->get<1>() << "    " << i->get<3>() << std::endl;
#endif
    } 
  };

  std::pair<std::string,std::string> Router::urlFor(const std::string &name, const strstr_map_t& arguments) {
    std::ostringstream path;
    std::string mask,method,result;
    int k1,k2,k3;

    bool found = false;
    for(TRouteList::iterator i = routes.begin(); !found && i != routes.end(); i++) {
#if __cplusplus >= 201103L
      if (std::get<3>(*i) == name) { mask = std::get<1>(*i); method = std::get<0>(*i); found = true; }
#else
      if (i->get<3>() == name) { mask = i->get<1>(); method = i->get<0>(); found = true; }
#endif
    }

    if (!found)
      throw Error("Route not found");

    for(k1=0,k3=0;k1<static_cast<int>(mask.size());k1++) {
      if (mask[k1] == '<') {
        std::string pname;
        strstr_map_t::const_iterator pptr;
        k2=k1;
        while(k1<static_cast<int>(mask.size()) && mask[k1]!='>') k1++;
        path << mask.substr(k3,k2-k3);
        if (mask[k2+1] == '*')
          pname = std::string(mask.begin() + k2 + 2, mask.begin() + k1);
        else 
          pname = std::string(mask.begin() + k2 + 1, mask.begin() + k1);
        if ((pptr = arguments.find(pname)) != arguments.end()) 
          path << Utility::encodeURL(pptr->second);
        k3 = k1+1;
      }
      else if (mask[k1] == '*') {
        // ready 
        k3++;
        continue;
      }
    }
    path << mask.substr(k3);
    result = path.str();
    return std::make_pair(method, result);
  }
};

1	/* @file
2	* @brief Concrete implementation of Router
3	*/
4	#include "yahttp.hpp"
5	#include "router.hpp"
6
7	namespace YaHTTP {
8	// router is defined here.
9	YaHTTP::Router Router::router;
10
11	void Router::map(const std::string& method, const std::string& url, THandlerFunction handler, const std::string& name) {	×
12	std::string method2 = method;	×
13	bool isopen=false;	×
14	// add into vector
15	for(std::string::const_iterator i = url.begin(); i != url.end(); i++) {	×
16	if (*i == '<' && isopen) throw Error("Invalid URL mask, cannot have < after <");	×
17	if (*i == '<') isopen = true;	×
18	if (*i == '>' && !isopen) throw Error("Invalid URL mask, cannot have > without < first");	×
19	if (*i == '>') isopen = false;	×
20	}	×
21	std::transform(method2.begin(), method2.end(), method2.begin(), ::toupper);	×
22	routes.push_back(funcptr::make_tuple(method2, url, handler, name));	×
23	};	×
24
25	bool Router::match(const std::string& route, const URL& requrl, std::map<std::string, TDelim> &params) {	×
26	size_t rpos = 0;	×
27	size_t upos = 0;	×
28	size_t npos = 0;	×
29	size_t nstart = 0;	×
30	size_t nend = 0;	×
31	std::string pname;	×
32	for(; rpos < route.size() && upos < requrl.path.size(); ) {	×
33	if (route[rpos] == '<') {	×
34	nstart = upos;	×
35	npos = rpos+1;	×
36	// start of parameter
37	while(rpos < route.size() && route[rpos] != '>') {	×
38	rpos++;	×
39	}	×
40	pname = std::string(route.begin()+static_cast<long>(npos), route.begin()+static_cast<long>(rpos));	×
41	// then we also look it on the url
42	if (pname[0] == '*') {	×
43	pname = pname.substr(1);	×
44	// this matches whatever comes after it, basically end of string
45	nend = requrl.path.size();	×
46	if (!pname.empty()) {	×
47	params[pname] = funcptr::tie(nstart,nend);	×
48	}	×
49	rpos = route.size();	×
50	upos = requrl.path.size();	×
51	break;	×
52	}	×
53	// match until url[upos] or next / if pattern is at end
54	while (upos < requrl.path.size()) {	×
55	if (route[rpos+1] == '\0' && requrl.path[upos] == '/') {	×
56	break;	×
57	}	×
58	if (requrl.path[upos] == route[rpos+1]) {	×
59	break;	×
60	}	×
61	upos++;	×
62	}	×
63	nend = upos;	×
64	params[pname] = funcptr::tie(nstart, nend);	×
65	if (upos > 0) {	×
66	upos--;	×
67	}	×
68	else {	×
69	// If upos is zero, do not decrement it and then increment at bottom of loop, this disturbs Coverity.
70	// Only increment rpos and continue loop
71	rpos++;	×
72	continue;	×
73	}	×
74	}	×
75	else if (route[rpos] != requrl.path[upos]) {	×
76	break;	×
77	}	×
78
79	rpos++; upos++;	×
80	}	×
81	return route[rpos] == requrl.path[upos];	×
82	}	×
83
84	RoutingResult Router::route(Request *req, THandlerFunction& handler) {	×
85	std::map<std::string, TDelim> params;	×
86	bool matched = false;	×
87	bool seen = false;	×
88	std::string rname;	×
89
90	// iterate routes
91	for (auto& route: routes) {	×
92	std::string method;	×
93	std::string url;	×
94	funcptr::tie(method, url, handler, rname) = route;	×
95
96	// see if we can't match the url
97	params.clear();	×
98	// simple matcher func
99	matched = match(url, req->url, params);	×
100
101	if (matched && !method.empty() && req->method != method) {	×
102	// method did not match, record it though so we can return correct result
103	matched = false;	×
104	// The OPTIONS handler registered in pdns/webserver.cc matches every
105	// url, and would cause "not found" errors to always be superseded
106	// with "found, but wrong method" errors, so don't pretend there has
107	// been a match in this case.
108	if (method != "OPTIONS") {	×
109	seen = true;	×
110	}	×
111	continue;	×
112	}	×
113	if (matched) {	×
114	break;	×
115	}	×
116	}	×
117
118	if (!matched) {	×
119	if (seen) {	×
120	return RouteNoMethod;	×
121	}	×
122	// no route
123	return RouteNotFound;	×
124	}	×
125
126	req->parameters.clear();	×
127
128	for (const auto& param: params) {	×
129	int nstart = 0;	×
130	int nend = 0;	×
131	funcptr::tie(nstart, nend) = param.second;	×
132	std::string value(req->url.path.begin() + nstart, req->url.path.begin() + nend);	×
133	value = Utility::decodeURL(value);	×
134	req->parameters[param.first] = std::move(value);	×
135	}	×
136
137	req->routeName = std::move(rname);	×
138
139	return RouteFound;	×
140	};	×
141
142	void Router::printRoutes(std::ostream &os) {	×
143	for(TRouteList::iterator i = routes.begin(); i != routes.end(); i++) {	×
144	#if __cplusplus >= 201103L	×
145	std::streamsize ss = os.width();	×
146	std::ios::fmtflags ff = os.setf(std::ios::left);	×
147	os.width(10);	×
148	os << std::get<0>(*i);	×
149	os.width(50);	×
150	os << std::get<1>(*i);	×
151	os.width(ss);	×
152	os.setf(ff);	×
153	os << " " << std::get<3>(*i);	×
154	os << std::endl;	×
155	#else
156	os << i->get<0>() << " " << i->get<1>() << " " << i->get<3>() << std::endl;
157	#endif
158	}	×
159	};	×
160
161	std::pair<std::string,std::string> Router::urlFor(const std::string &name, const strstr_map_t& arguments) {	×
162	std::ostringstream path;	×
163	std::string mask,method,result;	×
164	int k1,k2,k3;	×
165
166	bool found = false;	×
167	for(TRouteList::iterator i = routes.begin(); !found && i != routes.end(); i++) {	×
168	#if __cplusplus >= 201103L	×
169	if (std::get<3>(i) == name) { mask = std::get<1>(i); method = std::get<0>(*i); found = true; }	×
170	#else
171	if (i->get<3>() == name) { mask = i->get<1>(); method = i->get<0>(); found = true; }
172	#endif
173	}	×
174
175	if (!found)	×
176	throw Error("Route not found");	×
177
178	for(k1=0,k3=0;k1<static_cast<int>(mask.size());k1++) {	×
179	if (mask[k1] == '<') {	×
180	std::string pname;	×
181	strstr_map_t::const_iterator pptr;	×
182	k2=k1;	×
183	while(k1<static_cast<int>(mask.size()) && mask[k1]!='>') k1++;	×
184	path << mask.substr(k3,k2-k3);	×
185	if (mask[k2+1] == '*')	×
186	pname = std::string(mask.begin() + k2 + 2, mask.begin() + k1);	×
187	else	×
188	pname = std::string(mask.begin() + k2 + 1, mask.begin() + k1);	×
189	if ((pptr = arguments.find(pname)) != arguments.end())	×
190	path << Utility::encodeURL(pptr->second);	×
191	k3 = k1+1;	×
192	}	×
193	else if (mask[k1] == '*') {	×
194	// ready
195	k3++;	×
196	continue;	×
197	}	×
198	}	×
199	path << mask.substr(k3);	×
200	result = path.str();	×
201	return std::make_pair(method, result);	×
202	}	×
203	};

PowerDNS / pdns / 17669567316

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous