• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4720

08 Sep 2025 08:43AM UTC coverage: 58.139% (-0.6%) from 58.762%
#4720

push

travis-ci

web-flow
Merge pull request #32881 from taosdata/enh/add-new-windows-ci

fix(ci): update workflow reference to use new Windows CI YAML

133181 of 292179 branches covered (45.58%)

Branch coverage included in aggregate %.

201691 of 283811 relevant lines covered (71.07%)

5442780.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

49.71
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "taoserror.h"
21
#include "tmsg.h"
22
#include "ttypes.h"
23

24
#include "executorInt.h"
25
#include "tcommon.h"
26
#include "thash.h"
27
#include "ttime.h"
28

29
#include "function.h"
30
#include "operator.h"
31
#include "querynodes.h"
32
#include "querytask.h"
33
#include "tdatablock.h"
34
#include "tfill.h"
35

36
typedef struct STimeRange {
37
  TSKEY    skey;
38
  TSKEY    ekey;
39
  uint64_t groupId;
40
} STimeRange;
41

42
typedef struct SFillOperatorInfo {
43
  struct SFillInfo* pFillInfo;
44
  SSDataBlock*      pRes;
45
  SSDataBlock*      pFinalRes;
46
  int64_t           totalInputRows;
47
  void**            p;
48
  SSDataBlock*      existNewGroupBlock;
49
  STimeWindow       win;
50
  SColMatchInfo     matchInfo;
51
  int32_t           primaryTsCol;
52
  int32_t           primarySrcSlotId;
53
  uint64_t          curGroupId;  // current handled group id
54
  SExprInfo*        pExprInfo;
55
  int32_t           numOfExpr;
56
  SExprSupp         noFillExprSupp;
57
  SExprSupp         fillNullExprSupp;
58
  SList*            pFillSavedBlockList;
59
  SNode*            pTimeRange;  // STimeRangeNode for stream fill
60
} SFillOperatorInfo;
61

62
static void destroyFillOperatorInfo(void* param);
63
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
64
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
65
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
66

67
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
3,258✔
68
                                               SResultInfo* pResultInfo, int32_t order) {
69
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
3,258✔
70
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
3,258✔
71
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
3,258✔
72

73
  //  int32_t order = TSDB_ORDER_ASC;
74
  int32_t scanFlag = MAIN_SCAN;
3,258✔
75
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
76
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
3,258✔
77

78
  blockDataCleanup(pInfo->pRes);
3,258✔
79
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
3,258✔
80

81
  reviseFillStartAndEndKey(pOperator->info, order);
3,257✔
82

83
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
6,514✔
84
                                         : pInfo->existNewGroupBlock->info.window.skey;
3,257!
85
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
3,257✔
86

87
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
3,257✔
88
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
3,257✔
89
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
886✔
90
    if (code != TSDB_CODE_SUCCESS) {
887!
91
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
92
      T_LONG_JMP(pTaskInfo->env, code);
×
93
    }
94
  }
95

96
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
3,258✔
97
  int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, NULL);
3,258✔
98
  if (code != TSDB_CODE_SUCCESS) {
3,258!
99
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
100
    T_LONG_JMP(pTaskInfo->env, code);
×
101
  }
102

103
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
3,258✔
104
  pInfo->existNewGroupBlock = NULL;
3,258✔
105
}
3,258✔
106

107
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
13,282✔
108
                                            SResultInfo* pResultInfo, int32_t order) {
109
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
13,282✔
110
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
13,282✔
111
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
4,975✔
112
    int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows, NULL);
4,975✔
113
    if (code != TSDB_CODE_SUCCESS) {
4,975!
114
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
115
      T_LONG_JMP(pTaskInfo->env, code);
×
116
    }
117
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
4,975✔
118
    return;
4,975✔
119
  }
120

121
  // handle the cached new group data block
122
  if (pInfo->existNewGroupBlock) {
8,307✔
123
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
3,258✔
124
  }
125
}
126

127
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
10,783✔
128
  int32_t            code = TSDB_CODE_SUCCESS;
10,783✔
129
  int32_t            lino = 0;
10,783✔
130
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
10,783✔
131
  SFillOperatorInfo* pInfo = pOperator->info;
10,783✔
132
  SExprSupp*         pSup = &pOperator->exprSupp;
10,783✔
133
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
10,783✔
134
  QUERY_CHECK_CODE(code, lino, _end);
10,783!
135
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
10,783!
136
  QUERY_CHECK_CODE(code, lino, _end);
10,783!
137

138
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
139
  pInfo->pRes->info.rows = 0;
10,783✔
140
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
10,783✔
141
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
10,783✔
142
  QUERY_CHECK_CODE(code, lino, _end);
10,783!
143

144
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
10,783✔
145
                               NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
10,783!
146
  QUERY_CHECK_CODE(code, lino, _end);
10,782!
147

148
  if (pInfo->fillNullExprSupp.pExprInfo) {
10,782✔
149
    pInfo->pRes->info.rows = 0;
1✔
150
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
1✔
151
    QUERY_CHECK_CODE(code, lino, _end);
1!
152
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
1✔
153
        pInfo->fillNullExprSupp.numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
1!
154
  }
155

156
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
10,782✔
157

158
_end:
10,782✔
159
  if (code != TSDB_CODE_SUCCESS) {
10,782!
160
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
161
    T_LONG_JMP(pTaskInfo->env, code);
×
162
  }
163
}
10,782✔
164

165
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
886✔
166
  int32_t code = TSDB_CODE_SUCCESS;
886✔
167
  int32_t lino = 0;
886✔
168
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
7,195✔
169
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
6,309✔
170
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
4,604✔
171
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
4,604!
172
      key->isNull = true;
4,604✔
173
    }
174
  }
175

176
_end:
886✔
177
  if (code != TSDB_CODE_SUCCESS) {
886!
178
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
179
  }
180
  return code;
887✔
181
}
182

183
static SSDataBlock* doFillImpl2(SOperatorInfo* pOperator) {
13,282✔
184
  int32_t            code = TSDB_CODE_SUCCESS;
13,282✔
185
  int32_t            lino = 0;
13,282✔
186
  SFillOperatorInfo* pInfo = pOperator->info;
13,282✔
187
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
13,282✔
188
  if (pInfo == NULL || pTaskInfo == NULL) {
13,282!
189
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
190
    return NULL;
×
191
  }
192

193
  SResultInfo* pResultInfo = &pOperator->resultInfo;
13,282✔
194
  SSDataBlock* pResBlock = pInfo->pFinalRes;
13,282✔
195
  if (pResBlock == NULL) {
13,282!
196
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
197
    return NULL;
×
198
  }
199
  blockDataCleanup(pResBlock);
13,282✔
200
  int32_t        order = pInfo->pFillInfo->order;
13,282✔
201
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
13,282✔
202

203
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
13,282✔
204
  if (pResBlock->info.rows > 0) {
13,282✔
205
    pResBlock->info.id.groupId = pInfo->curGroupId;
4,322✔
206
    return pResBlock;
4,322✔
207
  }
208

209
  while (1) {
3,591✔
210
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
12,551✔
211
    if (pBlock == NULL) {
12,551✔
212
      if (pInfo->totalInputRows == 0 &&
5,026✔
213
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
1,592✔
214
        setOperatorCompleted(pOperator);
1,136✔
215
        return NULL;
8,960✔
216
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
3,890✔
217
        reviseFillStartAndEndKey(pInfo, order);
228✔
218
      }
219

220
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
3,890✔
221
    } else {
222
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
7,525✔
223
      pBlock->info.dataLoad = 1;
7,525✔
224
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
7,525✔
225
      QUERY_CHECK_CODE(code, lino, _end);
7,525!
226

227
      blockDataCleanup(pInfo->pRes);
7,525✔
228
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
7,525✔
229
      QUERY_CHECK_CODE(code, lino, _end);
7,525!
230
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
7,525✔
231
      QUERY_CHECK_CODE(code, lino, _end);
7,525!
232
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
7,525✔
233

234
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
11,792✔
235
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
4,267✔
236
          reviseFillStartAndEndKey(pInfo, order);
1,745✔
237
        }
238

239
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
4,267✔
240
        pInfo->totalInputRows += pInfo->pRes->info.rows;
4,267✔
241

242
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
4,267✔
243
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
4,267✔
244
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
4,267✔
245
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
3,258!
246
        pInfo->existNewGroupBlock = pBlock;
3,258✔
247

248
        // Fill the previous group data block, before handle the data block of new group.
249
        // Close the fill operation for previous group data block
250
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
3,258✔
251
        pInfo->pFillInfo->prev.key = 0;
3,258✔
252
      }
253
    }
254

255
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
11,415✔
256
    bool wantMoreBlock = false;
11,415✔
257
    code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, &wantMoreBlock);
11,415✔
258
    QUERY_CHECK_CODE(code, lino, _end);
11,415!
259

260
    // current group has no more result to return
261
    if (pResBlock->info.rows > 0) {
11,415✔
262
      // 1. The result in current group not reach the threshold of output result, continue
263
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
264
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
5,884!
265
        pResBlock->info.id.groupId = pInfo->curGroupId;
5,884✔
266
        return pResBlock;
5,884✔
267
      }
268

269
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
270
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
271
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
272
        return pResBlock;
×
273
      }
274
    } else if (pInfo->existNewGroupBlock) {  // try next group
5,531!
275
      blockDataCleanup(pResBlock);
×
276

277
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
278
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
279
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
280
        return pResBlock;
×
281
      }
282
    } else {
283
      if (wantMoreBlock) continue;
5,531✔
284
      return NULL;
1,940✔
285
    }
286
  }
287

288
_end:
×
289
  if (code != TSDB_CODE_SUCCESS) {
×
290
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
291
    T_LONG_JMP(pTaskInfo->env, code);
×
292
  }
293
  return NULL;
×
294
}
295

296
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
×
297
  int32_t            code = TSDB_CODE_SUCCESS;
×
298
  int32_t            lino = 0;
×
299
  SFillOperatorInfo* pInfo = pOperator->info;
×
300
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
×
301
  if (pInfo == NULL || pTaskInfo == NULL) {
×
302
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
303
    return NULL;
×
304
  }
305

306
  SResultInfo* pResultInfo = &pOperator->resultInfo;
×
307
  SSDataBlock* pResBlock = pInfo->pFinalRes;
×
308
  if (pResBlock == NULL) {
×
309
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
310
    return NULL;
×
311
  }
312

313
  blockDataCleanup(pResBlock);
×
314

315
  int32_t order = pInfo->pFillInfo->order;
×
316

317
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
×
318
#if 0
319
  // the scan order may be different from the output result order for agg interval operator.
320
  if (pDownstream->operatorType == QUERY_NODE_PHYSICAL_PLAN_HASH_INTERVAL) {
321
    order = ((SIntervalAggOperatorInfo*) pDownstream->info)->resultTsOrder;
322
  } else {
323
    order = pInfo->pFillInfo->order;
324
  }
325
#endif
326

327
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
328
  if (pResBlock->info.rows > 0) {
×
329
    pResBlock->info.id.groupId = pInfo->curGroupId;
×
330
    return pResBlock;
×
331
  }
332

333
  while (1) {
×
334
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
×
335
    if (pBlock == NULL) {
×
336
      if (pInfo->totalInputRows == 0 &&
×
337
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
×
338
        setOperatorCompleted(pOperator);
×
339
        return NULL;
×
340
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
341
        reviseFillStartAndEndKey(pInfo, order);
×
342
      }
343

344
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
345
    } else {
346
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
×
347
      pBlock->info.dataLoad = 1;
×
348
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
×
349
      QUERY_CHECK_CODE(code, lino, _end);
×
350

351
      blockDataCleanup(pInfo->pRes);
×
352
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
×
353
      QUERY_CHECK_CODE(code, lino, _end);
×
354
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
×
355
      QUERY_CHECK_CODE(code, lino, _end);
×
356
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
×
357

358
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
×
359
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
360
          reviseFillStartAndEndKey(pInfo, order);
×
361
        }
362

363
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
×
364
        pInfo->totalInputRows += pInfo->pRes->info.rows;
×
365

366
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
×
367
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
×
368
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
×
369
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
×
370
        pInfo->existNewGroupBlock = pBlock;
×
371

372
        // Fill the previous group data block, before handle the data block of new group.
373
        // Close the fill operation for previous group data block
374
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
375
        pInfo->pFillInfo->prev.key = 0;
×
376
      }
377
    }
378

379
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
×
380
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
×
381
    QUERY_CHECK_CODE(code, lino, _end);
×
382

383
    // current group has no more result to return
384
    if (pResBlock->info.rows > 0) {
×
385
      // 1. The result in current group not reach the threshold of output result, continue
386
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
387
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
×
388
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
389
        return pResBlock;
×
390
      }
391

392
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
393
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
394
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
395
        return pResBlock;
×
396
      }
397
    } else if (pInfo->existNewGroupBlock) {  // try next group
×
398
      blockDataCleanup(pResBlock);
×
399

400
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
401
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
402
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
403
        return pResBlock;
×
404
      }
405
    } else {
406
      return NULL;
×
407
    }
408
  }
409

410
_end:
×
411
  if (code != TSDB_CODE_SUCCESS) {
×
412
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
413
    T_LONG_JMP(pTaskInfo->env, code);
×
414
  }
415
  return NULL;
×
416
}
417

418
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
13,282✔
419
  int32_t            code = TSDB_CODE_SUCCESS;
13,282✔
420
  SFillOperatorInfo* pInfo = pOperator->info;
13,282✔
421
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
13,282✔
422

423
  if (pInfo->pTimeRange != NULL) {
13,282!
424
    STimeWindow pWinRange = {0};
×
425
    bool        isWinRangeValid = false;
×
426
    calcTimeRange((STimeRangeNode*)pInfo->pTimeRange, &pTaskInfo->pStreamRuntimeInfo->funcInfo, &pWinRange,
×
427
                  &isWinRangeValid);
428

429
    if (isWinRangeValid) {
×
430
      pInfo->win.skey = pWinRange.skey;
×
431
      pInfo->win.ekey = pWinRange.ekey;
×
432
    }
433
  }
434

435
  if (pOperator->status == OP_EXEC_DONE) {
13,282!
436
    (*ppRes) = NULL;
×
437
    return code;
×
438
  }
439

440
  SSDataBlock* fillResult = NULL;
13,282✔
441
  while (true) {
442
    fillResult = doFillImpl2(pOperator);
13,282✔
443
    if (fillResult == NULL) {
13,282✔
444
      setOperatorCompleted(pOperator);
3,076✔
445
      break;
3,076✔
446
    }
447

448
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo);
10,206✔
449
    if (code != TSDB_CODE_SUCCESS) {
10,206!
450
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
451
      pTaskInfo->code = code;
×
452
      T_LONG_JMP(pTaskInfo->env, code);
×
453
    }
454
    if (fillResult->info.rows > 0) {
10,206!
455
      break;
10,206✔
456
    }
457
  }
458

459
  if (fillResult != NULL) {
13,282✔
460
    pOperator->resultInfo.totalRows += fillResult->info.rows;
10,206✔
461
  }
462

463
  (*ppRes) = fillResult;
13,282✔
464
  return code;
13,282✔
465
}
466

467
void destroyFillOperatorInfo(void* param) {
3,109✔
468
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
3,109✔
469
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
3,109✔
470
  blockDataDestroy(pInfo->pRes);
3,109✔
471
  pInfo->pRes = NULL;
3,109✔
472
  blockDataDestroy(pInfo->pFinalRes);
3,109✔
473
  pInfo->pFinalRes = NULL;
3,109✔
474

475
  cleanupExprSupp(&pInfo->noFillExprSupp);
3,109✔
476
  cleanupExprSupp(&pInfo->fillNullExprSupp);
3,109✔
477

478
  taosMemoryFreeClear(pInfo->p);
3,109!
479
  taosArrayDestroy(pInfo->matchInfo.pList);
3,109✔
480
  taosMemoryFreeClear(param);
3,109!
481
}
3,109✔
482

483
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr, int32_t numOfCols, SExprInfo* pNotFillExpr,
3,109✔
484
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr, int32_t numOfFillNullExprs,
485
                            SNodeListNode* pValNode, STimeWindow win, int32_t capacity, const char* id,
486
                            SInterval* pInterval, int32_t fillType, int32_t order, SExecTaskInfo* pTaskInfo) {
487
  SFillColInfo* pColInfo =
488
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols, pFillNullExpr, numOfFillNullExprs, pValNode);
3,109✔
489
  if (!pColInfo) {
3,109✔
490
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
1!
491
    return terrno;
1✔
492
  }
493

494
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
3,108✔
495

496
  //  STimeWindow w = {0};
497
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
498
  pInfo->pFillInfo = NULL;
3,108✔
499
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols, numOfFillNullExprs, capacity, pInterval,
3,108✔
500
                                    fillType, pColInfo, pInfo->primaryTsCol, order, id, pTaskInfo, &pInfo->pFillInfo);
3,108✔
501
  if (code != TSDB_CODE_SUCCESS) {
3,108!
502
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
503
    return code;
×
504
  }
505

506
  if (order == TSDB_ORDER_ASC) {
3,108✔
507
    pInfo->win.skey = win.skey;
2,454✔
508
    pInfo->win.ekey = win.ekey;
2,454✔
509
  } else {
510
    pInfo->win.skey = win.ekey;
654✔
511
    pInfo->win.ekey = win.skey;
654✔
512
  }
513
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
3,108!
514
  if (!pInfo->p) {
3,109!
515
    return terrno;
×
516
  }
517

518
  if (pInfo->pFillInfo == NULL) {
3,109!
519
    taosMemoryFree(pInfo->pFillInfo);
×
520
    taosMemoryFree(pInfo->p);
×
521
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
522
  } else {
523
    return TSDB_CODE_SUCCESS;
3,109✔
524
  }
525
}
526

527
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
3,107✔
528
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
3,107✔
529
    return false;
258✔
530
  }
531

532
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
4,277✔
533
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
4,216✔
534
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
4,216!
535
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
4,216✔
536
      return true;
2,788✔
537
    }
538
  }
539
  return false;
61✔
540
}
541

542
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
3,108✔
543
                                           const char* idStr) {
544
  bool wstartExist = isWstartColumnExist(pInfo);
3,108✔
545

546
  if (wstartExist == false) {
3,109✔
547
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
321!
548
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
549
      return TSDB_CODE_QRY_SYS_ERROR;
×
550
    }
551

552
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
321!
553
    if (pExpr == NULL) {
321!
554
      return terrno;
×
555
    }
556

557
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
321✔
558
    if (code != TSDB_CODE_SUCCESS) {
321!
559
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
560
      pExprSupp->numOfExprs += 1;
×
561
      pExprSupp->pExprInfo = pExpr;
×
562
      return code;
×
563
    }
564

565
    pExprSupp->numOfExprs += 1;
321✔
566
    pExprSupp->pExprInfo = pExpr;
321✔
567
  }
568

569
  return TSDB_CODE_SUCCESS;
3,109✔
570
}
571

572
static int32_t resetFillOperState(SOperatorInfo* pOper) {
×
573
  SFillOperatorInfo* pFill = pOper->info;
×
574
  SExecTaskInfo*           pTaskInfo = pOper->pTaskInfo;
×
575
  pOper->status = OP_NOT_OPENED;
×
576
  SFillPhysiNode* pPhyNode = (SFillPhysiNode*)pOper->pPhyNode;
×
577

578
  pFill->curGroupId = 0;
×
579
  pFill->totalInputRows = 0;
×
580
  blockDataCleanup(pFill->pRes);
×
581
  blockDataCleanup(pFill->pFinalRes);
×
582

583
  int64_t startKey = (pFill->pFillInfo->order == TSDB_ORDER_ASC) ? pPhyNode->timeRange.skey : pPhyNode->timeRange.ekey;
×
584
  pFill->pFillInfo->start = startKey;
×
585
  pFill->pFillInfo->currentKey = startKey;
×
586
  pFill->pFillInfo->end = startKey;
×
587

588
  pFill->pFillInfo->numOfRows = 0;
×
589
  pFill->pFillInfo->index = -1;
×
590
  pFill->pFillInfo->numOfTotal = 0;
×
591
  pFill->pFillInfo->numOfCurrent = 0;
×
592
  pFill->pFillInfo->isFilled = false;
×
593
  pFill->pFillInfo->prev.key = 0;
×
594
  pFill->pFillInfo->next.key = 0;
×
595
  int32_t size = taosArrayGetSize(pFill->pFillInfo->prev.pRowVal);
×
596
  for (int32_t i = 0; i < size; ++i) {
×
597
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->prev.pRowVal, i);
×
598
    pKey->isNull = true;
×
599
  }
600
  size = taosArrayGetSize(pFill->pFillInfo->next.pRowVal);
×
601
  for (int32_t i = 0; i < size; ++i) {
×
602
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->next.pRowVal, i);
×
603
    pKey->isNull = true;
×
604
  }
605

606
  taosMemoryFreeClear(pFill->pFillInfo->pTags);
×
607
  taosArrayDestroy(pFill->pFillInfo->pColFillProgress);
×
608
  pFill->pFillInfo->pColFillProgress = NULL;
×
609

610
  tdListFreeP(pFill->pFillInfo->pFillSavedBlockList, destroyFillBlock);
×
611
  pFill->pFillInfo->pFillSavedBlockList = NULL;
×
612

613
  int32_t order = (pPhyNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
×
614
  if (order == TSDB_ORDER_ASC) {
×
615
    pFill->win.skey = pPhyNode->timeRange.skey;
×
616
    pFill->win.ekey = pPhyNode->timeRange.ekey;
×
617
  } else {
618
    pFill->win.skey = pPhyNode->timeRange.ekey;
×
619
    pFill->win.ekey = pPhyNode->timeRange.skey;
×
620
  }
621

622
  return TSDB_CODE_SUCCESS;
×
623
}
624

625
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
3,105✔
626
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
627
  QRY_PARAM_CHECK(pOptrInfo);
3,105!
628
  int32_t code = 0;
3,105✔
629
  int32_t lino = 0;
3,105✔
630

631
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
3,105!
632
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
3,106!
633
  if (pInfo == NULL || pOperator == NULL) {
3,108!
634
    code = terrno;
×
635
    goto _error;
×
636
  }
637

638
  pOperator->pPhyNode = pPhyFillNode;
3,108✔
639
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
3,108✔
640
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
3,109!
641
  SExprInfo* pExprInfo = NULL;
3,109✔
642

643
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
3,109✔
644
  QUERY_CHECK_CODE(code, lino, _error);
3,108!
645

646
  pOperator->exprSupp.pExprInfo = pExprInfo;
3,108✔
647
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
3,108✔
648

649
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
3,108✔
650
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
3,108✔
651
  QUERY_CHECK_CODE(code, lino, _error);
3,109!
652

653
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
3,109✔
654
  QUERY_CHECK_CODE(code, lino, _error);
3,108!
655

656
  code =
657
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
3,108✔
658
  QUERY_CHECK_CODE(code, lino, _error);
3,109!
659

660
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
3,109✔
661
                        &pInfo->fillNullExprSupp.numOfExprs);
662
  QUERY_CHECK_CODE(code, lino, _error);
3,109!
663
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
3,109✔
664
                      &pTaskInfo->storageAPI.functionStore);
665
  QUERY_CHECK_CODE(code, lino, _error);
3,109!
666

667
  SInterval* pInterval =
3,109✔
668
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
3,109✔
669
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
799✔
670
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
3,109✔
671

672
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
3,109✔
673
  int32_t type = convertFillType(pPhyFillNode->mode);
3,109✔
674

675
  SResultInfo* pResultInfo = &pOperator->resultInfo;
3,107✔
676

677
  initResultSizeInfo(&pOperator->resultInfo, 4096);
3,107✔
678
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
3,109✔
679
  if (code != TSDB_CODE_SUCCESS) {
3,109!
680
    goto _error;
×
681
  }
682
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
3,109✔
683
  if (code != TSDB_CODE_SUCCESS) {
3,109!
684
    goto _error;
×
685
  }
686

687
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
3,109✔
688
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
3,109✔
689

690
  int32_t numOfOutputCols = 0;
3,109✔
691
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
3,109✔
692
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
693

694
  QUERY_CHECK_CODE(code, lino, _error);
3,109!
695
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
3,109✔
696
                      pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
697
                      (SNodeListNode*)pPhyFillNode->pValues, pPhyFillNode->timeRange, pResultInfo->capacity,
3,109✔
698
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo);
3,109✔
699
  if (code != TSDB_CODE_SUCCESS) {
3,109!
700
    goto _error;
×
701
  }
702
  TSWAP(pInfo->pTimeRange, pPhyFillNode->pTimeRange);
3,109✔
703
  pInfo->pFinalRes = NULL;
3,109✔
704

705
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
3,109✔
706
  if (code) {
3,107!
707
    goto _error;
×
708
  }
709

710
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
3,107✔
711
  if (code != TSDB_CODE_SUCCESS) {
3,109!
712
    goto _error;
×
713
  }
714

715
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0,
3,109✔
716
                            pTaskInfo->pStreamRuntimeInfo);
3,109✔
717
  if (code != TSDB_CODE_SUCCESS) {
3,109!
718
    goto _error;
×
719
  }
720

721
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
3,109✔
722
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
3,109✔
723
                                         optrDefaultGetNextExtFn, NULL);
724
  setOperatorResetStateFn(pOperator, resetFillOperState);
3,109✔
725

726
  code = appendDownstream(pOperator, &downstream, 1);
3,109✔
727
  if (code != TSDB_CODE_SUCCESS) {
3,109!
728
    goto _error;
×
729
  }
730

731
  *pOptrInfo = pOperator;
3,109✔
732
  return TSDB_CODE_SUCCESS;
3,109✔
733

734
_error:
×
735
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
736

737
  if (pInfo != NULL) {
×
738
    destroyFillOperatorInfo(pInfo);
×
739
  }
740
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
741
  pTaskInfo->code = code;
×
742
  return code;
×
743
}
744

745
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
5,230✔
746
  int64_t skey, ekey, next;
747
  if (order == TSDB_ORDER_ASC) {
5,230✔
748
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
4,805✔
749
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
4,805✔
750

751
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
4,805✔
752
    next = ekey;
4,805✔
753
    while (next < pInfo->win.ekey) {
6,072✔
754
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
1,267✔
755
                         pInfo->pFillInfo->interval.precision, NULL);
1,267✔
756
      if (next == ekey) break;
1,267!
757
      ekey = next > pInfo->win.ekey ? ekey : next;
1,267✔
758
    }
759
    pInfo->win.ekey = ekey;
4,805✔
760
  } else {
761
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
425✔
762
    next = skey;
425✔
763
    while (next < pInfo->win.skey) {
857✔
764
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
432✔
765
                         pInfo->pFillInfo->interval.precision, NULL);
432✔
766
      if (next == skey) break;
432!
767
      skey = next > pInfo->win.skey ? skey : next;
432✔
768
    }
769
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
425✔
770
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
425✔
771
  }
772
}
5,230✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc