• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PowerDNS / pdns / 17551617099

08 Sep 2025 12:59PM UTC coverage: 66.015% (+0.01%) from 66.004%
17551617099

Pull #16077

github

web-flow
Merge 9e72f6ac2 into 5e4ad748a
Pull Request #16077: Move to C++20

42208 of 92550 branches covered (45.61%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 5 files covered. (100.0%)

99 existing lines in 11 files now uncovered.

128368 of 165838 relevant lines covered (77.41%)

5592083.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.18
/modules/gpgsqlbackend/spgsql.cc
1
/*
2
 * This file is part of PowerDNS or dnsdist.
3
 * Copyright -- PowerDNS.COM B.V. and its contributors
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of version 2 of the GNU General Public License as
7
 * published by the Free Software Foundation.
8
 *
9
 * In addition, for the avoidance of any doubt, permission is granted to
10
 * link this program with OpenSSL and to (re)distribute the binaries
11
 * produced as the result of such linking.
12
 *
13
 * This program is distributed in the hope that it will be useful,
14
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
16
 * GNU General Public License for more details.
17
 *
18
 * You should have received a copy of the GNU General Public License
19
 * along with this program; if not, write to the Free Software
20
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21
 */
22

23
#ifdef HAVE_CONFIG_H
24
#include "config.h"
25
#endif
26
#include <string>
27
#include "spgsql.hh"
28
#include <sys/time.h>
29
#include <iostream>
30
#include "pdns/logger.hh"
31
#include "pdns/dns.hh"
32
#include "pdns/namespaces.hh"
33
#include <algorithm>
34

35
class SPgSQLStatement : public SSqlStatement
36
{
37
public:
38
  SPgSQLStatement(const string& query, bool dolog, int nparams, SPgSQL* db, unsigned int nstatement)
39
  {
128,069✔
40
    d_query = query;
128,069✔
41
    d_dolog = dolog;
128,069✔
42
    d_parent = db;
128,069✔
43
    d_nparams = nparams;
128,069✔
44
    d_nstatement = nstatement;
128,069✔
45
  }
128,069✔
46

47
  SSqlStatement* bind(const string& name, bool value) override { return bind(name, string(value ? "t" : "f")); }
529,368✔
48
  SSqlStatement* bind(const string& name, int value) override { return bind(name, std::to_string(value)); }
547,581✔
49
  SSqlStatement* bind(const string& name, uint32_t value) override { return bind(name, std::to_string(value)); }
223,788✔
50
  SSqlStatement* bind(const string& name, long value) override { return bind(name, std::to_string(value)); }
81✔
51
  SSqlStatement* bind(const string& name, unsigned long value) override { return bind(name, std::to_string(value)); }
11✔
52
  SSqlStatement* bind(const string& name, long long value) override { return bind(name, std::to_string(value)); }
×
53
  SSqlStatement* bind(const string& name, unsigned long long value) override { return bind(name, std::to_string(value)); }
×
54
  SSqlStatement* bind(const string& /* name */, const std::string& value) override
55
  {
2,226,343✔
56
    prepareStatement();
2,226,343✔
57
    allocate();
2,226,343✔
58
    if (d_paridx >= d_nparams) {
2,226,343!
59
      releaseStatement();
×
60
      throw SSqlException("Attempt to bind more parameters than query has: " + d_query);
×
61
    }
×
62
    paramValues[d_paridx] = new char[value.size() + 1];
2,226,343✔
63
    memset(paramValues[d_paridx], 0, sizeof(char) * (value.size() + 1));
2,226,343✔
64
    value.copy(paramValues[d_paridx], value.size());
2,226,343✔
65
    paramLengths[d_paridx] = value.size();
2,226,343✔
66
    d_paridx++;
2,226,343✔
67
    return this;
2,226,343✔
68
  }
2,226,343✔
69
  SSqlStatement* bindNull(const string& /* name */) override
70
  {
162,880✔
71
    prepareStatement();
162,880✔
72
    d_paridx++;
162,880✔
73
    return this;
162,880✔
74
  } // these are set null in allocate()
162,880✔
75
  SSqlStatement* execute() override
76
  {
331,225✔
77
    prepareStatement();
331,225✔
78
    if (d_dolog) {
331,225!
79
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": Statement: " << d_query << endl;
×
80
      if (d_paridx) {
×
81
        // Log message is similar, but not exactly the same as the postgres server log.
82
        std::stringstream log_message;
×
83
        log_message << "Query " << ((long)(void*)this) << ": Parameters: ";
×
84
        for (int i = 0; i < d_paridx; i++) {
×
85
          if (i != 0) {
×
86
            log_message << ", ";
×
87
          }
×
88
          log_message << "$" << (i + 1) << " = ";
×
89
          if (paramValues[i] == nullptr) {
×
90
            log_message << "NULL";
×
91
          }
×
92
          else {
×
93
            log_message << "'" << paramValues[i] << "'";
×
94
          }
×
95
        }
×
96
        g_log << Logger::Warning << log_message.str() << endl;
×
97
      }
×
98
      d_dtime.set();
×
99
    }
×
100
    if (!d_stmt.empty()) {
331,225!
101
      d_res_set = PQexecPrepared(d_db(), d_stmt.c_str(), d_nparams, paramValues, paramLengths, nullptr, 0);
331,225✔
102
    }
331,225✔
UNCOV
103
    else {
×
UNCOV
104
      d_res_set = PQexecParams(d_db(), d_query.c_str(), d_nparams, nullptr, paramValues, paramLengths, nullptr, 0);
×
UNCOV
105
    }
×
106
    ExecStatusType status = PQresultStatus(d_res_set);
331,225✔
107
    if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
331,225!
108
      string errmsg(PQresultErrorMessage(d_res_set));
×
109
      releaseStatement();
×
110
      throw SSqlException("Fatal error during query: " + d_query + string(": ") + errmsg);
×
111
    }
×
112
    d_cur_set = 0;
331,225✔
113
    if (d_dolog) {
331,225!
114
      auto diff = d_dtime.udiffNoReset();
×
115
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << diff << " us to execute" << endl;
×
116
    }
×
117

118
    nextResult();
331,225✔
119
    return this;
331,225✔
120
  }
331,225✔
121

122
  void nextResult()
123
  {
349,390✔
124
    if (d_res_set == nullptr)
349,390✔
125
      return;
18,165✔
126
    if (d_cur_set >= PQntuples(d_res_set)) {
331,225✔
127
      PQclear(d_res_set);
313,056✔
128
      d_res_set = nullptr;
313,056✔
129
      return;
313,056✔
130
    }
313,056✔
131
    if (PQftype(d_res_set, 0) == 1790) { // REFCURSOR
18,169!
132
      g_log << Logger::Error << "Postgres query returned a REFCURSOR and we do not support those - see https://github.com/PowerDNS/pdns/pull/10259" << endl;
×
133
      PQclear(d_res_set);
×
134
      d_res_set = nullptr;
×
135
    }
×
136
    else {
18,169✔
137
      d_res = d_res_set;
18,169✔
138
      d_res_set = nullptr;
18,169✔
139
      d_resnum = PQntuples(d_res);
18,169✔
140
    }
18,169✔
141
  }
18,169✔
142

143
  bool hasNextRow() override
144
  {
295,223✔
145
    if (d_dolog && d_residx == d_resnum) {
295,223!
146
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << d_dtime.udiff() << " us total to last row" << endl;
×
147
    }
×
148

149
    return d_residx < d_resnum;
295,223✔
150
  }
295,223✔
151

152
  SSqlStatement* nextRow(row_t& row) override
153
  {
271,620✔
154
    int i;
271,620✔
155
    row.clear();
271,620✔
156
    if (d_residx >= d_resnum || !d_res)
271,620!
157
      return this;
×
158
    row.reserve(PQnfields(d_res));
271,620✔
159
    for (i = 0; i < PQnfields(d_res); i++) {
2,610,429✔
160
      if (PQgetisnull(d_res, d_residx, i)) {
2,338,809✔
161
        row.emplace_back("");
198,203✔
162
      }
198,203✔
163
      else if (PQftype(d_res, i) == 16) { // BOOLEAN
2,140,606✔
164
        char* val = PQgetvalue(d_res, d_residx, i);
166✔
165
        row.emplace_back(val[0] == 't' ? "1" : "0");
166✔
166
      }
166✔
167
      else {
2,140,440✔
168
        row.emplace_back(PQgetvalue(d_res, d_residx, i));
2,140,440✔
169
      }
2,140,440✔
170
    }
2,338,809✔
171
    d_residx++;
271,620✔
172
    if (d_residx >= d_resnum) {
271,620✔
173
      PQclear(d_res);
18,165✔
174
      d_res = nullptr;
18,165✔
175
      nextResult();
18,165✔
176
    }
18,165✔
177
    return this;
271,620✔
178
  }
271,620✔
179

180
  SSqlStatement* getResult(result_t& result) override
181
  {
1,193✔
182
    result.clear();
1,193✔
183
    if (d_res == nullptr)
1,193✔
184
      return this;
163✔
185
    result.reserve(d_resnum);
1,030✔
186
    row_t row;
1,030✔
187
    while (hasNextRow()) {
2,125✔
188
      nextRow(row);
1,095✔
189
      result.push_back(std::move(row));
1,095✔
190
    }
1,095✔
191
    return this;
1,030✔
192
  }
1,193✔
193

194
  SSqlStatement* reset() override
195
  {
451,892✔
196
    int i;
451,892✔
197
    if (d_res) {
451,892!
198
      PQclear(d_res);
×
199
    }
×
200
    if (d_res_set) {
451,892!
201
      PQclear(d_res_set);
×
202
    }
×
203
    d_res_set = nullptr;
451,892✔
204
    d_res = nullptr;
451,892✔
205
    d_paridx = d_residx = d_resnum = 0;
451,892✔
206
    if (paramValues) {
451,892✔
207
      for (i = 0; i < d_nparams; i++) {
2,720,425✔
208
        if (paramValues[i]) {
2,389,225✔
209
          delete[] paramValues[i];
2,226,342✔
210
        }
2,226,342✔
211
      }
2,389,225✔
212
    }
331,200✔
213
    delete[] paramValues;
451,892✔
214
    paramValues = nullptr;
451,892✔
215
    delete[] paramLengths;
451,892✔
216
    paramLengths = nullptr;
451,892✔
217
    return this;
451,892✔
218
  }
451,892✔
219

220
  const std::string& getQuery() override { return d_query; }
×
221

222
  ~SPgSQLStatement() override
223
  {
120,255✔
224
    releaseStatement();
120,255✔
225
  }
120,255✔
226

227
private:
228
  PGconn* d_db()
229
  {
344,791✔
230
    return d_parent->db();
344,791✔
231
  }
344,791✔
232

233
  void releaseStatement()
234
  {
120,475✔
235
    d_prepared = false;
120,475✔
236
    reset();
120,475✔
237
    if (!d_stmt.empty()) {
120,475✔
238
      string cmd = string("DEALLOCATE " + d_stmt);
6,581✔
239
      PGresult* res = PQexec(d_db(), cmd.c_str());
6,581✔
240
      PQclear(res);
6,581✔
241
      d_stmt.clear();
6,581✔
242
    }
6,581✔
243
  }
120,475✔
244

245
  void prepareStatement()
246
  {
2,720,446✔
247
    if (d_prepared)
2,720,446✔
248
      return;
2,713,458✔
249
    if (d_parent->usePrepared()) {
6,988✔
250
      // prepare a statement; name must be unique per session (using d_nstatement to ensure this).
251
      this->d_stmt = string("stmt") + std::to_string(d_nstatement);
6,986✔
252
      PGresult* res = PQprepare(d_db(), d_stmt.c_str(), d_query.c_str(), d_nparams, nullptr);
6,986✔
253
      ExecStatusType status = PQresultStatus(res);
6,986✔
254
      string errmsg(PQresultErrorMessage(res));
6,986✔
255
      PQclear(res);
6,986✔
256
      if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
6,986!
257
        releaseStatement();
×
258
        throw SSqlException("Fatal error during prePQpreparepare: " + d_query + string(": ") + errmsg);
×
259
      }
×
260
    }
6,986✔
261
    paramValues = nullptr;
6,988✔
262
    paramLengths = nullptr;
6,988✔
263
    d_cur_set = d_paridx = d_residx = d_resnum = 0;
6,988✔
264
    d_res = nullptr;
6,988✔
265
    d_res_set = nullptr;
6,988✔
266
    d_prepared = true;
6,988✔
267
  }
6,988✔
268

269
  void allocate()
270
  {
2,226,341✔
271
    if (paramValues != nullptr)
2,226,341✔
272
      return;
1,895,143✔
273
    paramValues = new char*[d_nparams];
331,198✔
274
    paramLengths = new int[d_nparams];
331,198✔
275
    memset(paramValues, 0, sizeof(char*) * d_nparams);
331,198✔
276
    memset(paramLengths, 0, sizeof(int) * d_nparams);
331,198✔
277
  }
331,198✔
278

279
  string d_query;
280
  string d_stmt;
281
  SPgSQL* d_parent;
282
  PGresult* d_res_set{nullptr};
283
  PGresult* d_res{nullptr};
284
  bool d_dolog;
285
  DTime d_dtime; // only used if d_dolog is set
286
  bool d_prepared{false};
287
  int d_nparams;
288
  int d_paridx{0};
289
  char** paramValues{nullptr};
290
  int* paramLengths{nullptr};
291
  int d_residx{0};
292
  int d_resnum{0};
293
  int d_cur_set{0};
294
  unsigned int d_nstatement;
295
};
296

297
bool SPgSQL::s_dolog;
298

299
static string escapeForPQparam(const string& v)
300
{
3,296✔
301
  string ret = v;
3,296✔
302
  boost::replace_all(ret, "\\", "\\\\");
3,296✔
303
  boost::replace_all(ret, "'", "\\'");
3,296✔
304

305
  return string("'") + ret + string("'");
3,296✔
306
}
3,296✔
307

308
SPgSQL::SPgSQL(const string& database, const string& host, const string& port, const string& user,
309
               const string& password, const string& extra_connection_parameters, const bool use_prepared)
310
{
1,884✔
311
  d_db = nullptr;
1,884✔
312
  d_in_trx = false;
1,884✔
313
  d_connectstr = "";
1,884✔
314
  d_nstatements = 0;
1,884✔
315

316
  if (!database.empty())
1,884✔
317
    d_connectstr += "dbname=" + escapeForPQparam(database);
1,883✔
318

319
  if (!user.empty())
1,884✔
320
    d_connectstr += " user=" + escapeForPQparam(user);
1,413✔
321

322
  if (!host.empty())
1,884!
323
    d_connectstr += " host=" + escapeForPQparam(host);
×
324

325
  if (!port.empty())
1,884!
326
    d_connectstr += " port=" + escapeForPQparam(port);
×
327

328
  if (!extra_connection_parameters.empty())
1,884!
329
    d_connectstr += " " + extra_connection_parameters;
×
330

331
  d_connectlogstr = d_connectstr;
1,884✔
332

333
  if (!password.empty()) {
1,884!
334
    d_connectlogstr += " password=<HIDDEN>";
×
335
    d_connectstr += " password=" + escapeForPQparam(password);
×
336
  }
×
337

338
  d_use_prepared = use_prepared;
1,884✔
339

340
  d_db = PQconnectdb(d_connectstr.c_str());
1,884✔
341

342
  if (!d_db || PQstatus(d_db) == CONNECTION_BAD) {
1,884!
343
    try {
×
344
      throw sPerrorException("Unable to connect to database, connect string: " + d_connectlogstr);
×
345
    }
×
346
    catch (...) {
×
347
      if (d_db)
×
348
        PQfinish(d_db);
×
349
      d_db = 0;
×
350
      throw;
×
351
    }
×
352
  }
×
353
}
1,884✔
354

355
void SPgSQL::setLog(bool state)
356
{
1,884✔
357
  s_dolog = state;
1,884✔
358
}
1,884✔
359

360
SPgSQL::~SPgSQL()
361
{
1,778✔
362
  PQfinish(d_db);
1,778✔
363
}
1,778✔
364

365
SSqlException SPgSQL::sPerrorException(const string& reason)
366
{
×
367
  return SSqlException(reason + string(": ") + (d_db ? PQerrorMessage(d_db) : "no connection"));
×
368
}
×
369

370
void SPgSQL::execute(const string& query)
371
{
1,083✔
372
  PGresult* res = PQexec(d_db, query.c_str());
1,083✔
373
  ExecStatusType status = PQresultStatus(res);
1,083✔
374
  string errmsg(PQresultErrorMessage(res));
1,083✔
375
  PQclear(res);
1,083✔
376
  if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
1,083!
377
    throw sPerrorException("Fatal error during query: " + errmsg);
×
378
  }
×
379
}
1,083✔
380

381
std::unique_ptr<SSqlStatement> SPgSQL::prepare(const string& query, int nparams)
382
{
128,100✔
383
  d_nstatements++;
128,100✔
384
  return std::make_unique<SPgSQLStatement>(query, s_dolog, nparams, this, d_nstatements);
128,100✔
385
}
128,100✔
386

387
void SPgSQL::startTransaction()
388
{
549✔
389
  execute("begin");
549✔
390
  d_in_trx = true;
549✔
391
}
549✔
392

393
void SPgSQL::commit()
394
{
516✔
395
  execute("commit");
516✔
396
  d_in_trx = false;
516✔
397
}
516✔
398

399
void SPgSQL::rollback()
400
{
18✔
401
  execute("rollback");
18✔
402
  d_in_trx = false;
18✔
403
}
18✔
404

405
bool SPgSQL::isConnectionUsable()
406
{
22,899✔
407
  if (PQstatus(d_db) != CONNECTION_OK) {
22,899!
408
    return false;
×
409
  }
×
410

411
  bool usable = false;
22,899✔
412
  int sd = PQsocket(d_db);
22,899✔
413
  bool wasNonBlocking = isNonBlocking(sd);
22,899✔
414

415
  if (!wasNonBlocking) {
22,899!
416
    if (!setNonBlocking(sd)) {
×
417
      return usable;
×
418
    }
×
419
  }
×
420

421
  usable = isTCPSocketUsable(sd);
22,899✔
422

423
  if (!wasNonBlocking) {
22,899!
424
    if (!setBlocking(sd)) {
×
425
      usable = false;
×
426
    }
×
427
  }
×
428

429
  return usable;
22,899✔
430
}
22,899✔
431

432
void SPgSQL::reconnect()
433
{
×
434
  PQreset(d_db);
×
435
}
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc