• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4712

06 Sep 2025 04:27PM UTC coverage: 58.144% (-1.0%) from 59.134%
#4712

push

travis-ci

GitHub
test: update case description (#32878)

133123 of 291691 branches covered (45.64%)

Branch coverage included in aggregate %.

201244 of 283375 relevant lines covered (71.02%)

5637899.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

58.9
/source/dnode/vnode/src/vnd/vnodeCommit.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17
#include "sync.h"
18
#include "vnd.h"
19
#include "vnodeInt.h"
20

21
extern int32_t tsdbPreCommit(STsdb *pTsdb);
22
extern int32_t tsdbCommitBegin(STsdb *pTsdb, SCommitInfo *pInfo);
23
extern int32_t tsdbCommitCommit(STsdb *pTsdb);
24
extern int32_t tsdbCommitAbort(STsdb *pTsdb);
25

26
#define VND_INFO_FNAME_TMP "vnode_tmp.json"
27

28
static int vnodeEncodeInfo(const SVnodeInfo *pInfo, char **ppData);
29
static int vnodeCommitImpl(SCommitInfo *pInfo);
30

31
#define WAIT_TIME_MILI_SEC 10  // miliseconds
32

33
static int32_t vnodeTryRecycleBufPool(SVnode *pVnode) {
×
34
  int32_t code = 0;
×
35

36
  if (pVnode->onRecycle == NULL) {
×
37
    if (pVnode->recycleHead == NULL) {
×
38
      vDebug("vgId:%d, no recyclable buffer pool", TD_VID(pVnode));
×
39
      goto _exit;
×
40
    } else {
41
      vDebug("vgId:%d, buffer pool %p of id %d on recycle queue, try to recycle", TD_VID(pVnode), pVnode->recycleHead,
×
42
             pVnode->recycleHead->id);
43

44
      pVnode->onRecycle = pVnode->recycleHead;
×
45
      if (pVnode->recycleHead == pVnode->recycleTail) {
×
46
        pVnode->recycleHead = pVnode->recycleTail = NULL;
×
47
      } else {
48
        pVnode->recycleHead = pVnode->recycleHead->recycleNext;
×
49
        pVnode->recycleHead->recyclePrev = NULL;
×
50
      }
51
      pVnode->onRecycle->recycleNext = pVnode->onRecycle->recyclePrev = NULL;
×
52
    }
53
  }
54

55
  code = vnodeBufPoolRecycle(pVnode->onRecycle);
×
56
  if (code) goto _exit;
×
57

58
_exit:
×
59
  if (code) {
×
60
    vError("vgId:%d, %s failed since %s", TD_VID(pVnode), __func__, tstrerror(code));
×
61
  }
62
  return code;
×
63
}
64
static int32_t vnodeGetBufPoolToUse(SVnode *pVnode) {
35,139✔
65
  int32_t code = 0;
35,139✔
66
  int32_t lino = 0;
35,139✔
67

68
  (void)taosThreadMutexLock(&pVnode->mutex);
35,139✔
69

70
  int32_t nTry = 0;
35,139✔
71
  for (;;) {
72
    ++nTry;
35,139✔
73

74
    if (pVnode->freeList) {
35,139!
75
      vDebug("vgId:%d, allocate free buffer pool on %d try, pPool:%p id:%d", TD_VID(pVnode), nTry, pVnode->freeList,
35,139✔
76
             pVnode->freeList->id);
77

78
      pVnode->inUse = pVnode->freeList;
35,138✔
79
      pVnode->inUse->nRef = 1;
35,138✔
80
      pVnode->freeList = pVnode->inUse->freeNext;
35,138✔
81
      pVnode->inUse->freeNext = NULL;
35,138✔
82
      break;
35,138✔
83
    } else {
84
      vDebug("vgId:%d, no free buffer pool on %d try, try to recycle...", TD_VID(pVnode), nTry);
×
85

86
      code = vnodeTryRecycleBufPool(pVnode);
×
87
      TSDB_CHECK_CODE(code, lino, _exit);
×
88

89
      if (pVnode->freeList == NULL) {
×
90
        vDebug("vgId:%d, no free buffer pool on %d try, wait %d ms...", TD_VID(pVnode), nTry, WAIT_TIME_MILI_SEC);
×
91

92
        struct timeval  tv;
93
        struct timespec ts;
94
        if (taosGetTimeOfDay(&tv) != 0) {
×
95
          continue;
×
96
        }
97
        ts.tv_nsec = tv.tv_usec * 1000 + WAIT_TIME_MILI_SEC * 1000000;
×
98
        if (ts.tv_nsec > 999999999l) {
×
99
          ts.tv_sec = tv.tv_sec + 1;
×
100
          ts.tv_nsec -= 1000000000l;
×
101
        } else {
102
          ts.tv_sec = tv.tv_sec;
×
103
        }
104

105
        code = taosThreadCondTimedWait(&pVnode->poolNotEmpty, &pVnode->mutex, &ts);
×
106
        // ignore timeout error and retry
107
        if (code == TSDB_CODE_TIMEOUT_ERROR) {
×
108
          code = TSDB_CODE_SUCCESS;
×
109
        }
110
        TSDB_CHECK_CODE(code, lino, _exit);
×
111
      }
112
    }
113
  }
114

115
_exit:
35,138✔
116
  (void)taosThreadMutexUnlock(&pVnode->mutex);
35,138✔
117
  if (code) {
35,138!
118
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
×
119
  }
120
  return code;
35,138✔
121
}
122
int vnodeBegin(SVnode *pVnode) {
35,139✔
123
  int32_t code = 0;
35,139✔
124
  int32_t lino = 0;
35,139✔
125

126
  // alloc buffer pool
127
  code = vnodeGetBufPoolToUse(pVnode);
35,139✔
128
  TSDB_CHECK_CODE(code, lino, _exit);
35,138!
129

130
  // begin meta
131
  code = metaBegin(pVnode->pMeta, META_BEGIN_HEAP_BUFFERPOOL);
35,138✔
132
  TSDB_CHECK_CODE(code, lino, _exit);
35,138!
133

134
  // begin tsdb
135
  code = tsdbBegin(pVnode->pTsdb);
35,138✔
136
  TSDB_CHECK_CODE(code, lino, _exit);
35,138!
137

138
  // begin sma
139
  if (VND_IS_RSMA(pVnode)) {
35,138!
140
    code = smaBegin(pVnode->pSma);
×
141
    TSDB_CHECK_CODE(code, lino, _exit);
×
142
  }
143

144
_exit:
35,138✔
145
  if (code) {
35,138!
146
    terrno = code;
×
147
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
×
148
  }
149
  return code;
35,137✔
150
}
151

152
int vnodeShouldCommit(SVnode *pVnode, bool atExit) {
1,907,653✔
153
  bool diskAvail = osDataSpaceAvailable();
1,907,653✔
154
  bool needCommit = false;
1,907,654✔
155

156
  (void)taosThreadMutexLock(&pVnode->mutex);
1,907,654✔
157
  if (pVnode->inUse && diskAvail) {
1,907,674!
158
    needCommit = (pVnode->inUse->size > pVnode->inUse->node.size) ||
1,917,942✔
159
                 (atExit && (pVnode->inUse->size > 0 || pVnode->pMeta->changed ||
10,266✔
160
                             pVnode->state.applied - pVnode->state.committed > 4096));
3,534!
161
  }
162
  vTrace("vgId:%d, should commit:%d, disk available:%d, buffer size:%" PRId64 ", node size:%" PRId64
1,907,674!
163
         ", meta changed:%d"
164
         ", state:[%" PRId64 ",%" PRId64 "]",
165
         TD_VID(pVnode), needCommit, diskAvail, pVnode->inUse ? pVnode->inUse->size : 0,
166
         pVnode->inUse ? pVnode->inUse->node.size : 0, pVnode->pMeta->changed, pVnode->state.applied,
167
         pVnode->state.committed);
168
  (void)taosThreadMutexUnlock(&pVnode->mutex);
1,907,674✔
169
  return needCommit;
1,907,671✔
170
}
171

172
int vnodeSaveInfo(const char *dir, const SVnodeInfo *pInfo) {
34,036✔
173
  int32_t   code = 0;
34,036✔
174
  int32_t   lino;
175
  char      fname[TSDB_FILENAME_LEN];
176
  TdFilePtr pFile = NULL;
34,036✔
177
  char     *data = NULL;
34,036✔
178

179
  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);
34,036✔
180

181
  code = vnodeEncodeInfo(pInfo, &data);
34,036✔
182
  TSDB_CHECK_CODE(code, lino, _exit);
34,027!
183

184
  // save info to a vnode_tmp.json
185
  pFile = taosOpenFile(fname, TD_FILE_CREATE | TD_FILE_WRITE | TD_FILE_TRUNC | TD_FILE_WRITE_THROUGH);
34,027✔
186
  if (pFile == NULL) {
33,976!
187
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
188
  }
189

190
  if (taosWriteFile(pFile, data, strlen(data)) < 0) {
33,976!
191
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
192
  }
193

194
  if (taosFsyncFile(pFile) < 0) {
34,012!
195
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
196
  }
197

198
_exit:
34,035✔
199
  if (code) {
34,035!
200
    vError("vgId:%d %s failed at %s:%d since %s", pInfo->config.vgId, __func__, __FILE__, lino, tstrerror(code));
×
201
  } else {
202
    vInfo("vgId:%d, vnode info is saved, fname:%s replica:%d selfIndex:%d changeVersion:%d", pInfo->config.vgId, fname,
34,035✔
203
          pInfo->config.syncCfg.replicaNum, pInfo->config.syncCfg.myIndex, pInfo->config.syncCfg.changeVersion);
204
  }
205
  if (taosCloseFile(&pFile) != 0) {
34,036!
206
    vError("vgId:%d, failed to close file", pInfo->config.vgId);
×
207
  }
208
  taosMemoryFree(data);
34,037!
209
  TAOS_RETURN(code);
34,037✔
210
}
211

212
int vnodeCommitInfo(const char *dir) {
34,037✔
213
  char fname[TSDB_FILENAME_LEN];
214
  char tfname[TSDB_FILENAME_LEN];
215

216
  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);
34,037✔
217
  snprintf(tfname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME_TMP);
34,037✔
218

219
  int32_t code = taosRenameFile(tfname, fname);
34,037✔
220
  if (code < 0) {
34,033!
221
    return code;
×
222
  }
223

224
  vInfo("vnode info is committed, dir:%s", dir);
34,033✔
225
  return 0;
34,037✔
226
}
227

228
int vnodeLoadInfo(const char *dir, SVnodeInfo *pInfo) {
23,748✔
229
  int32_t   code = 0;
23,748✔
230
  int32_t   lino;
231
  char      fname[TSDB_FILENAME_LEN];
232
  TdFilePtr pFile = NULL;
23,748✔
233
  char     *pData = NULL;
23,748✔
234
  int64_t   size;
235

236
  snprintf(fname, TSDB_FILENAME_LEN, "%s%s%s", dir, TD_DIRSEP, VND_INFO_FNAME);
23,748✔
237

238
  // read info
239
  pFile = taosOpenFile(fname, TD_FILE_READ);
23,748✔
240
  if (pFile == NULL) {
23,742✔
241
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
9,831!
242
  }
243

244
  code = taosFStatFile(pFile, &size, NULL);
13,911✔
245
  TSDB_CHECK_CODE(code, lino, _exit);
13,914!
246

247
  pData = taosMemoryMalloc(size + 1);
13,914!
248
  if (pData == NULL) {
13,915!
249
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
250
  }
251

252
  if (taosReadFile(pFile, pData, size) < 0) {
13,915!
253
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
254
  }
255

256
  pData[size] = '\0';
13,913✔
257

258
  // decode info
259
  code = vnodeDecodeInfo(pData, pInfo);
13,913✔
260
  TSDB_CHECK_CODE(code, lino, _exit);
13,915!
261

262
  pInfo->config.walCfg.committed = pInfo->state.committed;
13,915✔
263
_exit:
23,746✔
264
  if (code) {
23,746✔
265
    vError("vgId:%d %s failed at %s:%d since %s, file:%s", pInfo->config.vgId, __func__, __FILE__, lino,
9,831✔
266
           tstrerror(code), fname);
267
  }
268
  taosMemoryFree(pData);
23,747!
269
  if (taosCloseFile(&pFile) != 0) {
23,748!
270
    vError("vgId:%d, failed to close file", pInfo->config.vgId);
×
271
  }
272
  return code;
23,748✔
273
}
274

275
static int32_t vnodePrepareCommit(SVnode *pVnode, SCommitInfo *pInfo) {
22,672✔
276
  int32_t code = 0;
22,672✔
277
  int32_t lino = 0;
22,672✔
278
  char    dir[TSDB_FILENAME_LEN] = {0};
22,672✔
279
  int64_t lastCommitted = pInfo->info.state.committed;
22,672✔
280

281
  // wait last commit task
282
  vnodeAWait(&pVnode->commitTask);
22,672✔
283

284
  code = syncNodeGetConfig(pVnode->sync, &pVnode->config.syncCfg);
22,670✔
285
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
286

287
  pVnode->state.commitTerm = pVnode->state.applyTerm;
22,672✔
288

289
  pInfo->info.config = pVnode->config;
22,672✔
290
  pInfo->info.state.committed = pVnode->state.applied;
22,672✔
291
  pInfo->info.state.commitTerm = pVnode->state.applyTerm;
22,672✔
292
  pInfo->info.state.commitID = ++pVnode->state.commitID;
22,672✔
293
  pInfo->pVnode = pVnode;
22,672✔
294
  pInfo->txn = metaGetTxn(pVnode->pMeta);
22,672✔
295

296
  // save info
297
  vnodeGetPrimaryPath(pVnode, false, dir, TSDB_FILENAME_LEN);
22,670✔
298

299
  vDebug("vgId:%d, save config while prepare commit", TD_VID(pVnode));
22,667✔
300
  code = vnodeSaveInfo(dir, &pInfo->info);
22,669✔
301
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
302

303
  code = tsdbPreCommit(pVnode->pTsdb);
22,672✔
304
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
305

306
  code = metaPrepareAsyncCommit(pVnode->pMeta);
22,672✔
307
  TSDB_CHECK_CODE(code, lino, _exit);
22,671!
308

309
  code = smaPrepareAsyncCommit(pVnode->pSma);
22,671✔
310
  TSDB_CHECK_CODE(code, lino, _exit);
22,668!
311

312
  (void)taosThreadMutexLock(&pVnode->mutex);
22,668✔
313
  pVnode->onCommit = pVnode->inUse;
22,672✔
314
  pVnode->inUse = NULL;
22,672✔
315
  (void)taosThreadMutexUnlock(&pVnode->mutex);
22,672✔
316

317
_exit:
22,671✔
318
  if (code) {
22,671!
319
    vError("vgId:%d, %s failed at line %d since %s, commit id:%" PRId64, TD_VID(pVnode), __func__, lino,
×
320
           tstrerror(code), pVnode->state.commitID);
321
  } else {
322
    vDebug("vgId:%d, %s done, commit id:%" PRId64, TD_VID(pVnode), __func__, pInfo->info.state.commitID);
22,671✔
323
  }
324

325
  return code;
22,672✔
326
}
327
static void vnodeReturnBufPool(SVnode *pVnode) {
22,672✔
328
  (void)taosThreadMutexLock(&pVnode->mutex);
22,672✔
329

330
  SVBufPool *pPool = pVnode->onCommit;
22,672✔
331
  int32_t    nRef = atomic_sub_fetch_32(&pPool->nRef, 1);
22,672✔
332

333
  pVnode->onCommit = NULL;
22,672✔
334
  if (nRef == 0) {
22,672✔
335
    vnodeBufPoolAddToFreeList(pPool);
22,567✔
336
  } else if (nRef > 0) {
105!
337
    vDebug("vgId:%d, buffer pool %p of id %d is added to recycle queue", TD_VID(pVnode), pPool, pPool->id);
105!
338

339
    if (pVnode->recycleTail == NULL) {
105✔
340
      pPool->recyclePrev = pPool->recycleNext = NULL;
104✔
341
      pVnode->recycleHead = pVnode->recycleTail = pPool;
104✔
342
    } else {
343
      pPool->recyclePrev = pVnode->recycleTail;
1✔
344
      pPool->recycleNext = NULL;
1✔
345
      pVnode->recycleTail->recycleNext = pPool;
1✔
346
      pVnode->recycleTail = pPool;
1✔
347
    }
348
  } else {
349
    vError("vgId:%d, buffer pool %p of id %d nRef:%d", TD_VID(pVnode), pPool, pPool->id, nRef);
×
350
  }
351

352
  (void)taosThreadMutexUnlock(&pVnode->mutex);
22,672✔
353
}
22,672✔
354
static int32_t vnodeCommit(void *arg) {
22,671✔
355
  int32_t code = 0;
22,671✔
356

357
  SCommitInfo *pInfo = (SCommitInfo *)arg;
22,671✔
358
  SVnode      *pVnode = pInfo->pVnode;
22,671✔
359

360
  // commit
361
  METRICS_TIMING_BLOCK(pVnode->writeMetrics.commit_time, METRIC_LEVEL_HIGH, {
22,671!
362
    if ((code = vnodeCommitImpl(pInfo))) {
363
      vFatal("vgId:%d, failed to commit vnode since %s", TD_VID(pVnode), terrstr());
364
      taosMsleep(100);
365
      exit(EXIT_FAILURE);
366
      goto _exit;
367
    }
368
  });
369

370
  METRICS_UPDATE(pVnode->writeMetrics.commit_count, METRIC_LEVEL_HIGH, 1);
22,672!
371

372
  vnodeReturnBufPool(pVnode);
22,672✔
373

374
_exit:
22,672✔
375
  taosMemoryFree(arg);
22,672!
376
  return code;
22,672✔
377
}
378

379
static void vnodeCommitCancel(void *arg) { taosMemoryFree(arg); }
×
380

381
int vnodeAsyncCommit(SVnode *pVnode) {
22,667✔
382
  int32_t code = 0;
22,667✔
383
  int32_t lino = 0;
22,667✔
384

385
  SCommitInfo *pInfo = (SCommitInfo *)taosMemoryCalloc(1, sizeof(*pInfo));
22,667!
386
  if (NULL == pInfo) {
22,671!
387
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
388
  }
389
  code = vnodePrepareCommit(pVnode, pInfo);
22,671✔
390
  TSDB_CHECK_CODE(code, lino, _exit);
22,671!
391

392
  // schedule the task
393
  code = vnodeAsync(COMMIT_TASK_ASYNC, EVA_PRIORITY_HIGH, vnodeCommit, vnodeCommitCancel, pInfo, &pVnode->commitTask);
22,671✔
394
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
395

396
_exit:
22,672✔
397
  if (code) {
22,672!
398
    taosMemoryFree(pInfo);
×
399
    vError("vgId:%d %s failed at line %d since %s" PRId64, TD_VID(pVnode), __func__, lino, tstrerror(code));
×
400
  } else {
401
    vInfo("vgId:%d, vnode async commit done, commitId:%" PRId64 " term:%" PRId64 " applied:%" PRId64, TD_VID(pVnode),
22,672✔
402
          pVnode->state.commitID, pVnode->state.applyTerm, pVnode->state.applied);
403
  }
404
  return code;
22,672✔
405
}
406

407
int32_t vnodeSyncCommit(SVnode *pVnode) {
162✔
408
  int32_t lino;
409
  int32_t code = vnodeAsyncCommit(pVnode);
162✔
410
  TSDB_CHECK_CODE(code, lino, _exit);
162!
411
  vnodeAWait(&pVnode->commitTask);
162✔
412

413
_exit:
162✔
414
  if (code) {
162!
415
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
×
416
  } else {
417
    vInfo("vgId:%d, sync commit end", TD_VID(pVnode));
162!
418
  }
419

420
  return code;
162✔
421
}
422

423
static int vnodeCommitImpl(SCommitInfo *pInfo) {
22,670✔
424
  int32_t code = 0;
22,670✔
425
  int32_t lino = 0;
22,670✔
426

427
  char    dir[TSDB_FILENAME_LEN] = {0};
22,670✔
428
  SVnode *pVnode = pInfo->pVnode;
22,670✔
429

430
  vInfo("vgId:%d, start to commit, commitId:%" PRId64 " version:%" PRId64 " term: %" PRId64, TD_VID(pVnode),
22,670✔
431
        pInfo->info.state.commitID, pInfo->info.state.committed, pInfo->info.state.commitTerm);
432

433
  // persist wal before starting
434
  if ((code = walPersist(pVnode->pWal)) < 0) {
22,674!
435
    vError("vgId:%d, failed to persist wal since %s", TD_VID(pVnode), tstrerror(code));
×
436
    return code;
×
437
  }
438

439
  vnodeGetPrimaryPath(pVnode, false, dir, TSDB_FILENAME_LEN);
22,672✔
440

441
  code = syncBeginSnapshot(pVnode->sync, pInfo->info.state.committed);
22,671✔
442
  TSDB_CHECK_CODE(code, lino, _exit);
22,671!
443

444
  code = tsdbCommitBegin(pVnode->pTsdb, pInfo);
22,671✔
445
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
446

447
  if (!TSDB_CACHE_NO(pVnode->config)) {
22,672✔
448
    METRICS_TIMING_BLOCK(pVnode->writeMetrics.last_cache_commit_time, METRIC_LEVEL_HIGH,
233!
449
                         { code = tsdbCacheCommit(pVnode->pTsdb); });
450
    METRICS_UPDATE(pVnode->writeMetrics.last_cache_commit_count, METRIC_LEVEL_HIGH, 1);
233!
451
    TSDB_CHECK_CODE(code, lino, _exit);
233!
452
  }
453

454
  if (VND_IS_RSMA(pVnode)) {
22,672!
455
    code = smaCommit(pVnode->pSma, pInfo);
×
456
    TSDB_CHECK_CODE(code, lino, _exit);
×
457
  }
458
  // blob storage engine commit
459
  code = bseCommit(pVnode->pBse);
22,672✔
460
  // commit info
461
  code = vnodeCommitInfo(dir);
22,672✔
462
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
463

464
  code = tsdbCommitCommit(pVnode->pTsdb);
22,672✔
465
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
466

467
  if (VND_IS_RSMA(pVnode)) {
22,672!
468
    code = smaFinishCommit(pVnode->pSma);
×
469
    TSDB_CHECK_CODE(code, lino, _exit);
×
470
  }
471

472
  code = metaFinishCommit(pVnode->pMeta, pInfo->txn);
22,672✔
473
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
474

475
  pVnode->state.committed = pInfo->info.state.committed;
22,672✔
476

477
  if (smaPostCommit(pVnode->pSma) < 0) {
22,672!
478
    vError("vgId:%d, failed to post-commit sma since %s", TD_VID(pVnode), tstrerror(terrno));
×
479
    return -1;
×
480
  }
481

482
  code = syncEndSnapshot(pVnode->sync);
22,669✔
483
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
484

485
  code = tqCommitOffset(pVnode->pTq);
22,672✔
486
  TSDB_CHECK_CODE(code, lino, _exit);
22,672!
487
  
488
_exit:
22,672✔
489
  if (code) {
22,672!
490
    vError("vgId:%d, %s failed at line %d since %s", TD_VID(pVnode), __func__, lino, tstrerror(code));
×
491
  } else {
492
    vInfo("vgId:%d, commit end", TD_VID(pVnode));
22,672✔
493
  }
494
  return code;
22,672✔
495
}
496

497
bool vnodeShouldRollback(SVnode *pVnode) {
12,471✔
498
  char    tFName[TSDB_FILENAME_LEN] = {0};
12,471✔
499
  int32_t offset = 0;
12,471✔
500

501
  vnodeGetPrimaryPath(pVnode, false, tFName, TSDB_FILENAME_LEN);
12,471✔
502
  offset = strlen(tFName);
12,471✔
503
  snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);
12,471✔
504

505
  return taosCheckExistFile(tFName);
12,471✔
506
}
507

508
void vnodeRollback(SVnode *pVnode) {
×
509
  char    tFName[TSDB_FILENAME_LEN] = {0};
×
510
  int32_t offset = 0;
×
511

512
  vnodeGetPrimaryPath(pVnode, false, tFName, TSDB_FILENAME_LEN);
×
513
  offset = strlen(tFName);
×
514
  snprintf(tFName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME_TMP);
×
515

516
  if (taosRemoveFile(tFName) != 0) {
×
517
    vError("vgId:%d, failed to remove file %s since %s", TD_VID(pVnode), tFName, tstrerror(terrno));
×
518
  }
519
}
×
520

521
static int vnodeEncodeState(const void *pObj, SJson *pJson) {
34,037✔
522
  const SVState *pState = (SVState *)pObj;
34,037✔
523

524
  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit version", pState->committed));
34,037!
525
  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit ID", pState->commitID));
34,037!
526
  TAOS_CHECK_RETURN(tjsonAddIntegerToObject(pJson, "commit term", pState->commitTerm));
34,037✔
527

528
  return 0;
34,035✔
529
}
530

531
static int vnodeDecodeState(const SJson *pJson, void *pObj) {
14,012✔
532
  SVState *pState = (SVState *)pObj;
14,012✔
533

534
  int32_t code;
535
  tjsonGetNumberValue(pJson, "commit version", pState->committed, code);
14,012✔
536
  if (code) return code;
14,009!
537
  tjsonGetNumberValue(pJson, "commit ID", pState->commitID, code);
14,009✔
538
  if (code) return code;
14,011!
539
  tjsonGetNumberValue(pJson, "commit term", pState->commitTerm, code);
14,011✔
540
  if (code) return code;
14,011!
541

542
  return 0;
14,011✔
543
}
544

545
static int vnodeEncodeInfo(const SVnodeInfo *pInfo, char **ppData) {
34,036✔
546
  int32_t code = 0;
34,036✔
547
  int32_t lino;
548
  SJson  *pJson = NULL;
34,036✔
549
  char   *pData = NULL;
34,036✔
550

551
  pJson = tjsonCreateObject();
34,036✔
552
  if (pJson == NULL) {
34,037!
553
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
554
  }
555

556
  code = tjsonAddObject(pJson, "config", vnodeEncodeConfig, (void *)&pInfo->config);
34,037✔
557
  TSDB_CHECK_CODE(code, lino, _exit);
34,037!
558

559
  code = tjsonAddObject(pJson, "state", vnodeEncodeState, (void *)&pInfo->state);
34,037✔
560
  TSDB_CHECK_CODE(code, lino, _exit);
34,036!
561

562
  pData = tjsonToString(pJson);
34,036✔
563
  if (pData == NULL) {
34,034!
564
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
565
  }
566

567
  tjsonDelete(pJson);
34,034✔
568

569
_exit:
34,034✔
570
  if (code) {
34,034!
571
    tjsonDelete(pJson);
×
572
    *ppData = NULL;
×
573
  } else {
574
    *ppData = pData;
34,034✔
575
  }
576
  return code;
34,034✔
577
}
578

579
int vnodeDecodeInfo(uint8_t *pData, SVnodeInfo *pInfo) {
14,006✔
580
  int32_t code = 0;
14,006✔
581
  int32_t lino;
582
  SJson  *pJson = NULL;
14,006✔
583

584
  pJson = tjsonParse(pData);
14,006✔
585
  if (pJson == NULL) {
14,008!
586
    TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_DATA_FMT, lino, _exit);
×
587
  }
588

589
  code = tjsonToObject(pJson, "config", vnodeDecodeConfig, (void *)&pInfo->config);
14,008✔
590
  TSDB_CHECK_CODE(code, lino, _exit);
14,010!
591

592
  code = tjsonToObject(pJson, "state", vnodeDecodeState, (void *)&pInfo->state);
14,010✔
593
  TSDB_CHECK_CODE(code, lino, _exit);
14,011!
594

595
_exit:
14,011✔
596
  tjsonDelete(pJson);
14,011✔
597
  return code;
14,011✔
598
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc