#4696

Committed 29 Aug 2025 06:36AM UTC coverage: 58.25% (+0.2%) from 58.041%

Build # #4696

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix(gpt): fix race-condition in preparing tmp files (#32800)

Run Details

133424 of 291873 branches covered (45.71%)

Branch coverage included in aggregate %.

5 of 34 new or added lines in 6 files covered. (14.71%)

444 existing lines in 69 files now uncovered.

201767 of 283561 relevant lines covered (71.15%)

17907122.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.73

/source/util/src/tref.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "tref.h"
#include "taoserror.h"
#include "tlog.h"
#include "tutil.h"

#define TSDB_REF_OBJECTS        100
#define TSDB_REF_STATE_EMPTY    0
#define TSDB_REF_STATE_ACTIVE   1
#define TSDB_REF_STATE_DELETED  2
#define TSDB_REF_ITER_THRESHOLD 100

typedef struct SRefNode {
  struct SRefNode *prev;     // previous node
  struct SRefNode *next;     // next node
  void            *p;        // pointer to resource protected,
  int64_t          rid;      // reference ID
  int32_t          count;    // number of references
  int32_t          removed;  // 1: removed
} SRefNode;

typedef struct {
  SRefNode **nodeList;  // array of SRefNode linked list
  int32_t    state;     // 0: empty, 1: active;  2: deleted
  int32_t    rsetId;    // refSet ID, global unique
  int64_t    rid;       // increase by one for each new reference
  int32_t    max;       // mod
  int32_t    count;     // total number of SRefNodes in this set
  int64_t   *lockedBy;
  void (*fp)(void *);
} SRefSet;

static SRefSet       tsRefSetList[TSDB_REF_OBJECTS];
static TdThreadOnce  tsRefModuleInit = PTHREAD_ONCE_INIT;
static TdThreadMutex tsRefMutex;
static int32_t       tsRefSetNum = 0;
static int32_t       tsNextId = 0;

static void    taosInitRefModule(void);
static void    taosLockList(int64_t *lockedBy);
static void    taosUnlockList(int64_t *lockedBy);
static void    taosIncRsetCount(SRefSet *pSet);
static void    taosDecRsetCount(SRefSet *pSet);
static int32_t taosDecRefCount(int32_t rsetId, int64_t rid, int32_t remove, int32_t *isReleased);

int32_t taosOpenRef(int32_t max, RefFp fp) {
  SRefNode **nodeList;
  SRefSet   *pSet;
  int64_t   *lockedBy;
  int32_t    i, rsetId;

  (void)taosThreadOnce(&tsRefModuleInit, taosInitRefModule);

  nodeList = taosMemoryCalloc(sizeof(SRefNode *), (size_t)max);
  if (nodeList == NULL) {
    return terrno;
  }

  lockedBy = taosMemoryCalloc(sizeof(int64_t), (size_t)max);
  if (lockedBy == NULL) {
    taosMemoryFree(nodeList);
    return terrno;
  }

  (void)taosThreadMutexLock(&tsRefMutex);

  for (i = 0; i < TSDB_REF_OBJECTS; ++i) {
    tsNextId = (tsNextId + 1) % TSDB_REF_OBJECTS;
    if (tsNextId == 0) tsNextId = 1;  // dont use 0 as rsetId
    if (tsRefSetList[tsNextId].state == TSDB_REF_STATE_EMPTY) break;
  }

  if (i < TSDB_REF_OBJECTS) {
    rsetId = tsNextId;
    pSet = tsRefSetList + rsetId;
    pSet->max = max;
    pSet->nodeList = nodeList;
    pSet->lockedBy = lockedBy;
    pSet->fp = fp;
    pSet->rid = 1;
    pSet->rsetId = rsetId;
    pSet->state = TSDB_REF_STATE_ACTIVE;
    taosIncRsetCount(pSet);

    tsRefSetNum++;
    uTrace("rsetId:%d, is opened, max:%d, fp:%p refSetNum:%d", rsetId, max, fp, tsRefSetNum);
  } else {
    rsetId = TSDB_CODE_REF_FULL;
    taosMemoryFree(nodeList);
    taosMemoryFree(lockedBy);
    uTrace("run out of Ref ID, maximum:%d refSetNum:%d", TSDB_REF_OBJECTS, tsRefSetNum);
  }

  (void)taosThreadMutexUnlock(&tsRefMutex);

  return rsetId;
}

void taosCloseRef(int32_t rsetId) {
  SRefSet *pSet;
  int32_t  deleted = 0;

  if (rsetId < 0 || rsetId >= TSDB_REF_OBJECTS) {
    uTrace("rsetId:%d, is invalid, out of range", rsetId);
    return;
  }

  pSet = tsRefSetList + rsetId;

  (void)taosThreadMutexLock(&tsRefMutex);

  if (pSet->state == TSDB_REF_STATE_ACTIVE) {
    pSet->state = TSDB_REF_STATE_DELETED;
    deleted = 1;
    uTrace("rsetId:%d, is closed, count:%d", rsetId, pSet->count);
  } else {
    uTrace("rsetId:%d, is already closed, count:%d", rsetId, pSet->count);
  }

  (void)taosThreadMutexUnlock(&tsRefMutex);

  if (deleted) taosDecRsetCount(pSet);
}

int64_t taosAddRef(int32_t rsetId, void *p) {
  int32_t   hash;
  SRefNode *pNode;
  SRefSet  *pSet;
  int64_t   rid = 0;

  if (rsetId < 0 || rsetId >= TSDB_REF_OBJECTS) {
    uTrace("p:%p, failed to add, rsetId not valid, rsetId:%d", p, rsetId);
    return terrno = TSDB_CODE_REF_INVALID_ID;
  }

  pSet = tsRefSetList + rsetId;
  taosIncRsetCount(pSet);
  if (pSet->state != TSDB_REF_STATE_ACTIVE) {
    taosDecRsetCount(pSet);
    uTrace("p:%p, failed to add, not active, rsetId:%d", p, rsetId);
    return terrno = TSDB_CODE_REF_ID_REMOVED;
  }

  pNode = taosMemoryCalloc(sizeof(SRefNode), 1);
  if (pNode == NULL) {
    taosDecRsetCount(pSet);
    uError("p:%p, failed to add, out of memory, rsetId:%d", p, rsetId);
    return terrno;
  }

  rid = atomic_add_fetch_64(&pSet->rid, 1);
  hash = rid % pSet->max;
  taosLockList(pSet->lockedBy + hash);

  pNode->p = p;
  pNode->rid = rid;
  pNode->count = 1;

  pNode->prev = NULL;
  pNode->next = pSet->nodeList[hash];
  if (pSet->nodeList[hash]) pSet->nodeList[hash]->prev = pNode;
  pSet->nodeList[hash] = pNode;

  uTrace("p:%p, rid:0x%" PRIx64 " is added, count:%d, remain count:%d rsetId:%d", p, rid, pSet->count, pNode->count,
         rsetId);

  taosUnlockList(pSet->lockedBy + hash);

  return rid;
}

int32_t taosRemoveRef(int32_t rsetId, int64_t rid) { return taosDecRefCount(rsetId, rid, 1, NULL); }

// if rid is 0, return the first p in hash list, otherwise, return the next after current rid
void *taosAcquireRef(int32_t rsetId, int64_t rid) {
  int32_t   hash;
  SRefNode *pNode;
  SRefSet  *pSet;
  int32_t   iter = 0;
  void     *p = NULL;

  if (rsetId < 0 || rsetId >= TSDB_REF_OBJECTS) {
    // uTrace("rsetId:%d, rid:0x%" PRIx64 " failed to acquire, rsetId not valid", rsetId, rid);
    terrno = TSDB_CODE_REF_INVALID_ID;
    return NULL;
  }

  if (rid <= 0) {
    uTrace("rid:0x%" PRIx64 ", failed to acquire, rid not valid, rsetId:%d", rid, rsetId);
    terrno = TSDB_CODE_REF_NOT_EXIST;
    return NULL;
  }

  pSet = tsRefSetList + rsetId;
  taosIncRsetCount(pSet);
  if (pSet->state != TSDB_REF_STATE_ACTIVE) {
    uTrace("rid:0x%" PRIx64 ", failed to acquire, not active, rsetId:%d", rid, rsetId);
    taosDecRsetCount(pSet);
    terrno = TSDB_CODE_REF_ID_REMOVED;
    return NULL;
  }

  hash = rid % pSet->max;
  taosLockList(pSet->lockedBy + hash);

  pNode = pSet->nodeList[hash];

  while (pNode) {
    if (pNode->rid == rid) {
      break;
    }
    iter++;
    pNode = pNode->next;
  }

  if (iter >= TSDB_REF_ITER_THRESHOLD) {
    uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);
  }

  if (pNode) {
    if (pNode->removed == 0) {
      pNode->count++;
      p = pNode->p;
      uTrace("p:%p, rid:0x%" PRIx64 " is acquired, remain count:%d, rsetId:%d", pNode->p, rid, pNode->count, rsetId);
    } else {
      terrno = TSDB_CODE_REF_NOT_EXIST;
      uTrace("p:%p, rid:0x%" PRIx64 " is already removed, failed to acquire, rsetId:%d", pNode->p, rid, rsetId);
    }
  } else {
    terrno = TSDB_CODE_REF_NOT_EXIST;
    uTrace("rid:0x%" PRIx64 ", is not there, failed to acquire, rsetId:%d", rid, rsetId);
  }

  taosUnlockList(pSet->lockedBy + hash);

  taosDecRsetCount(pSet);

  return p;
}

int32_t taosReleaseRef(int32_t rsetId, int64_t rid) { return taosDecRefCount(rsetId, rid, 0, NULL); }
int32_t taosReleaseRefEx(int32_t rsetId, int64_t rid, int32_t *isReleased) {
  return taosDecRefCount(rsetId, rid, 0, isReleased);
}

// if rid is 0, return the first p in hash list, otherwise, return the next after current rid
void *taosIterateRef(int32_t rsetId, int64_t rid) {
  SRefNode *pNode = NULL;
  SRefSet  *pSet;

  if (rsetId < 0 || rsetId >= TSDB_REF_OBJECTS) {
    uTrace("rid:0x%" PRIx64 ", failed to iterate, rsetId not valid, rsetId:%d", rid, rsetId);
    terrno = TSDB_CODE_REF_INVALID_ID;
    return NULL;
  }

  if (rid < 0) {
    uTrace("rid:0x%" PRIx64 ", failed to iterate, rid not valid, rsetId:%d", rid, rsetId);
    terrno = TSDB_CODE_REF_NOT_EXIST;
    return NULL;
  }

  void *newP = NULL;
  pSet = tsRefSetList + rsetId;
  taosIncRsetCount(pSet);
  if (pSet->state != TSDB_REF_STATE_ACTIVE) {
    uTrace("rid:0x%" PRIx64 ", failed to iterate, rset not active, rsetId:%d", rid, rsetId);
    terrno = TSDB_CODE_REF_ID_REMOVED;
    taosDecRsetCount(pSet);
    return NULL;
  }

  do {
    newP = NULL;
    int32_t hash = 0;
    int32_t iter = 0;
    if (rid > 0) {
      hash = rid % pSet->max;
      taosLockList(pSet->lockedBy + hash);

      pNode = pSet->nodeList[hash];
      while (pNode) {
        if (pNode->rid == rid) break;
        pNode = pNode->next;
        iter++;
      }

      if (iter >= TSDB_REF_ITER_THRESHOLD) {
        uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);
      }

      if (pNode == NULL) {
        uError("rid:0x%" PRIx64 ", not there and quit, rsetId:%d", rid, rsetId);
        terrno = TSDB_CODE_REF_NOT_EXIST;
        taosUnlockList(pSet->lockedBy + hash);
        taosDecRsetCount(pSet);
        return NULL;
      }

      // rid is there
      pNode = pNode->next;
      // check first place
      while (pNode) {
        if (!pNode->removed) break;
        pNode = pNode->next;
      }
      if (pNode == NULL) {
        taosUnlockList(pSet->lockedBy + hash);
        hash++;
      }
    }

    if (pNode == NULL) {
      for (; hash < pSet->max; ++hash) {
        taosLockList(pSet->lockedBy + hash);
        pNode = pSet->nodeList[hash];
        if (pNode) {
          // check first place
          while (pNode) {
            if (!pNode->removed) break;
            pNode = pNode->next;
          }
          if (pNode) break;
        }
        taosUnlockList(pSet->lockedBy + hash);
      }
    }

    if (pNode) {
      pNode->count++;  // acquire it
      newP = pNode->p;
      taosUnlockList(pSet->lockedBy + hash);
      uTrace("p:%p, rid:0x%" PRIx64 " is returned, rsetId:%d", newP, rid, rsetId);
    } else {
      uTrace("rsetId:%d, the list is over", rsetId);
    }

    if (rid > 0) taosReleaseRef(rsetId, rid);  // release the current one
    if (pNode) rid = pNode->rid;
  } while (newP && pNode->removed);

  taosDecRsetCount(pSet);

  return newP;
}

int32_t taosListRef() {
  SRefSet  *pSet;
  SRefNode *pNode;
  int32_t   num = 0;

  (void)taosThreadMutexLock(&tsRefMutex);

  for (int32_t i = 0; i < TSDB_REF_OBJECTS; ++i) {
    pSet = tsRefSetList + i;

    if (pSet->state == TSDB_REF_STATE_EMPTY) continue;

    uInfo("rsetId:%d, state:%d count:%d", i, pSet->state, pSet->count);

    for (int32_t j = 0; j < pSet->max; ++j) {
      pNode = pSet->nodeList[j];

      while (pNode) {
        uInfo("p:%p, rid:0x%" PRIx64 " count:%d, rsetId:%d", pNode->p, pNode->rid, pNode->count, i);
        pNode = pNode->next;
        num++;
      }
    }
  }

  (void)taosThreadMutexUnlock(&tsRefMutex);

  return num;
}

static int32_t taosDecRefCount(int32_t rsetId, int64_t rid, int32_t remove, int32_t *isReleased) {
  int32_t   hash;
  SRefSet  *pSet;
  SRefNode *pNode;
  int32_t   iter = 0;
  int32_t   released = 0;
  int32_t   code = 0;

  if (rsetId < 0 || rsetId >= TSDB_REF_OBJECTS) {
    uTrace("rid:0x%" PRIx64 ", failed to remove, rsetId not valid, rsetId:%d", rid, rsetId);
    return terrno = TSDB_CODE_REF_INVALID_ID;
  }

  if (rid <= 0) {
    uTrace("rid:0x%" PRIx64 ", failed to remove, rid not valid, rsetId:%d", rid, rsetId);
    return terrno = TSDB_CODE_REF_NOT_EXIST;
  }

  pSet = tsRefSetList + rsetId;
  if (pSet->state == TSDB_REF_STATE_EMPTY) {
    uTrace("rid:0x%" PRIx64 ", failed to remove, cleaned, rsetId:%d", rid, rsetId);
    return terrno = TSDB_CODE_REF_ID_REMOVED;
  }

  hash = rid % pSet->max;
  taosLockList(pSet->lockedBy + hash);

  pNode = pSet->nodeList[hash];
  while (pNode) {
    if (pNode->rid == rid) break;

    pNode = pNode->next;
    iter++;
  }

  if (iter >= TSDB_REF_ITER_THRESHOLD) {
    uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);
  }

  if (pNode) {
    pNode->count--;
    if (remove) pNode->removed = 1;

    if (pNode->count <= 0) {
      if (pNode->prev) {
        pNode->prev->next = pNode->next;
      } else {
        pSet->nodeList[hash] = pNode->next;
      }

      if (pNode->next) {
        pNode->next->prev = pNode->prev;
      }
      released = 1;
    } else {
      uTrace("p:%p, rid:0x%" PRIx64 " is released, remain count:%d, rsetId:%d", pNode->p, rid, pNode->count, rsetId);
    }
  } else {
    uTrace("rid:0x%" PRIx64 ", is not there, failed to release/remove, rsetId:%d", rid, rsetId);
    terrno = TSDB_CODE_REF_NOT_EXIST;
    code = terrno;
  }

  taosUnlockList(pSet->lockedBy + hash);

  if (released) {
    uTrace("p:%p, rid:0x%" PRIx64 " is removed, count:%d, free mem:%p, rsetId:%d", pNode->p, rid, pSet->count, pNode,
           rsetId);
    (*pSet->fp)(pNode->p);
    taosMemoryFree(pNode);

    taosDecRsetCount(pSet);
  }

  if (isReleased) {
    *isReleased = released;
  }

  return code;
}

static void taosLockList(int64_t *lockedBy) {
  int64_t tid = taosGetSelfPthreadId();
  int32_t i = 0;
  while (atomic_val_compare_exchange_64(lockedBy, 0, tid) != 0) {
    if (++i % 100 == 0) {
      (void)sched_yield();
    }
  }
}

static void taosUnlockList(int64_t *lockedBy) {
  int64_t tid = taosGetSelfPthreadId();
  (void)atomic_val_compare_exchange_64(lockedBy, tid, 0);
}

static void taosInitRefModule(void) { (void)taosThreadMutexInit(&tsRefMutex, NULL); }

static void taosIncRsetCount(SRefSet *pSet) {
  (void)atomic_add_fetch_32(&pSet->count, 1);
  // uTrace("rsetId:%d, inc count:%d", pSet->rsetId, count);
}

static void taosDecRsetCount(SRefSet *pSet) {
  int32_t count = atomic_sub_fetch_32(&pSet->count, 1);
  // uTrace("rsetId:%d, dec count:%d", pSet->rsetId, count);

  if (count > 0) return;

  (void)taosThreadMutexLock(&tsRefMutex);

  if (pSet->state != TSDB_REF_STATE_EMPTY) {
    pSet->state = TSDB_REF_STATE_EMPTY;
    pSet->max = 0;
    pSet->fp = NULL;

    taosMemoryFreeClear(pSet->nodeList);
    taosMemoryFreeClear(pSet->lockedBy);

    tsRefSetNum--;
    uTrace("rsetId:%d, is cleaned, refSetNum:%d count:%d", pSet->rsetId, tsRefSetNum, pSet->count);
  }

  (void)taosThreadMutexUnlock(&tsRefMutex);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "tref.h"
18	#include "taoserror.h"
19	#include "tlog.h"
20	#include "tutil.h"
21
22	#define TSDB_REF_OBJECTS 100
23	#define TSDB_REF_STATE_EMPTY 0
24	#define TSDB_REF_STATE_ACTIVE 1
25	#define TSDB_REF_STATE_DELETED 2
26	#define TSDB_REF_ITER_THRESHOLD 100
27
28	typedef struct SRefNode {
29	struct SRefNode *prev; // previous node
30	struct SRefNode *next; // next node
31	void *p; // pointer to resource protected,
32	int64_t rid; // reference ID
33	int32_t count; // number of references
34	int32_t removed; // 1: removed
35	} SRefNode;
36
37	typedef struct {
38	SRefNode **nodeList; // array of SRefNode linked list
39	int32_t state; // 0: empty, 1: active; 2: deleted
40	int32_t rsetId; // refSet ID, global unique
41	int64_t rid; // increase by one for each new reference
42	int32_t max; // mod
43	int32_t count; // total number of SRefNodes in this set
44	int64_t *lockedBy;
45	void (fp)(void );
46	} SRefSet;
47
48	static SRefSet tsRefSetList[TSDB_REF_OBJECTS];
49	static TdThreadOnce tsRefModuleInit = PTHREAD_ONCE_INIT;
50	static TdThreadMutex tsRefMutex;
51	static int32_t tsRefSetNum = 0;
52	static int32_t tsNextId = 0;
53
54	static void taosInitRefModule(void);
55	static void taosLockList(int64_t *lockedBy);
56	static void taosUnlockList(int64_t *lockedBy);
57	static void taosIncRsetCount(SRefSet *pSet);
58	static void taosDecRsetCount(SRefSet *pSet);
59	static int32_t taosDecRefCount(int32_t rsetId, int64_t rid, int32_t remove, int32_t *isReleased);
60
61	int32_t taosOpenRef(int32_t max, RefFp fp) {	107,542✔
62	SRefNode **nodeList;
63	SRefSet *pSet;
64	int64_t *lockedBy;
65	int32_t i, rsetId;
66
67	(void)taosThreadOnce(&tsRefModuleInit, taosInitRefModule);	107,542✔
68
69	nodeList = taosMemoryCalloc(sizeof(SRefNode *), (size_t)max);	107,542!
70	if (nodeList == NULL) {	107,542!
71	return terrno;	×
72	}
73
74	lockedBy = taosMemoryCalloc(sizeof(int64_t), (size_t)max);	107,542!
75	if (lockedBy == NULL) {	107,542!
76	taosMemoryFree(nodeList);	×
77	return terrno;	×
78	}
79
80	(void)taosThreadMutexLock(&tsRefMutex);	107,542✔
81
82	for (i = 0; i < TSDB_REF_OBJECTS; ++i) {	107,542!
83	tsNextId = (tsNextId + 1) % TSDB_REF_OBJECTS;	107,542✔
84	if (tsNextId == 0) tsNextId = 1; // dont use 0 as rsetId	107,542!
85	if (tsRefSetList[tsNextId].state == TSDB_REF_STATE_EMPTY) break;	107,542!
86	}
87
88	if (i < TSDB_REF_OBJECTS) {	107,542!
89	rsetId = tsNextId;	107,542✔
90	pSet = tsRefSetList + rsetId;	107,542✔
91	pSet->max = max;	107,542✔
92	pSet->nodeList = nodeList;	107,542✔
93	pSet->lockedBy = lockedBy;	107,542✔
94	pSet->fp = fp;	107,542✔
95	pSet->rid = 1;	107,542✔
96	pSet->rsetId = rsetId;	107,542✔
97	pSet->state = TSDB_REF_STATE_ACTIVE;	107,542✔
98	taosIncRsetCount(pSet);	107,542✔
99
100	tsRefSetNum++;	107,542✔
101	uTrace("rsetId:%d, is opened, max:%d, fp:%p refSetNum:%d", rsetId, max, fp, tsRefSetNum);	107,542✔
102	} else {
103	rsetId = TSDB_CODE_REF_FULL;	×
104	taosMemoryFree(nodeList);	×
105	taosMemoryFree(lockedBy);	×
106	uTrace("run out of Ref ID, maximum:%d refSetNum:%d", TSDB_REF_OBJECTS, tsRefSetNum);	×
107	}
108
109	(void)taosThreadMutexUnlock(&tsRefMutex);	107,542✔
110
111	return rsetId;	107,542✔
112	}
113
114	void taosCloseRef(int32_t rsetId) {	97,600✔
115	SRefSet *pSet;
116	int32_t deleted = 0;	97,600✔
117
118	if (rsetId < 0 \|\| rsetId >= TSDB_REF_OBJECTS) {	97,600!
119	uTrace("rsetId:%d, is invalid, out of range", rsetId);	2!
120	return;	2✔
121	}
122
123	pSet = tsRefSetList + rsetId;	97,598✔
124
125	(void)taosThreadMutexLock(&tsRefMutex);	97,598✔
126
127	if (pSet->state == TSDB_REF_STATE_ACTIVE) {	97,598✔
128	pSet->state = TSDB_REF_STATE_DELETED;	92,070✔
129	deleted = 1;	92,070✔
130	uTrace("rsetId:%d, is closed, count:%d", rsetId, pSet->count);	92,070✔
131	} else {
132	uTrace("rsetId:%d, is already closed, count:%d", rsetId, pSet->count);	5,528✔
133	}
134
135	(void)taosThreadMutexUnlock(&tsRefMutex);	97,598✔
136
137	if (deleted) taosDecRsetCount(pSet);	97,598✔
138	}
139
140	int64_t taosAddRef(int32_t rsetId, void *p) {	26,108,893✔
141	int32_t hash;
142	SRefNode *pNode;
143	SRefSet *pSet;
144	int64_t rid = 0;	26,108,893✔
145
146	if (rsetId < 0 \|\| rsetId >= TSDB_REF_OBJECTS) {	26,108,893!
147	uTrace("p:%p, failed to add, rsetId not valid, rsetId:%d", p, rsetId);	×
148	return terrno = TSDB_CODE_REF_INVALID_ID;	×
149	}
150
151	pSet = tsRefSetList + rsetId;	26,162,069✔
152	taosIncRsetCount(pSet);	26,162,069✔
153	if (pSet->state != TSDB_REF_STATE_ACTIVE) {	26,253,631!
154	taosDecRsetCount(pSet);	×
155	uTrace("p:%p, failed to add, not active, rsetId:%d", p, rsetId);	×
156	return terrno = TSDB_CODE_REF_ID_REMOVED;	×
157	}
158
159	pNode = taosMemoryCalloc(sizeof(SRefNode), 1);	26,253,631✔
160	if (pNode == NULL) {	26,233,536!
161	taosDecRsetCount(pSet);	×
162	uError("p:%p, failed to add, out of memory, rsetId:%d", p, rsetId);	×
163	return terrno;	×
164	}
165
166	rid = atomic_add_fetch_64(&pSet->rid, 1);	26,233,536✔
167	hash = rid % pSet->max;	26,262,050✔
168	taosLockList(pSet->lockedBy + hash);	26,262,050✔
169
170	pNode->p = p;	26,234,421✔
171	pNode->rid = rid;	26,234,421✔
172	pNode->count = 1;	26,234,421✔
173
174	pNode->prev = NULL;	26,234,421✔
175	pNode->next = pSet->nodeList[hash];	26,234,421✔
176	if (pSet->nodeList[hash]) pSet->nodeList[hash]->prev = pNode;	26,234,421✔
177	pSet->nodeList[hash] = pNode;	26,234,421✔
178
179	uTrace("p:%p, rid:0x%" PRIx64 " is added, count:%d, remain count:%d rsetId:%d", p, rid, pSet->count, pNode->count,	26,234,421✔
180	rsetId);
181
182	taosUnlockList(pSet->lockedBy + hash);	26,234,421✔
183
184	return rid;	26,237,067✔
185	}
186
187	int32_t taosRemoveRef(int32_t rsetId, int64_t rid) { return taosDecRefCount(rsetId, rid, 1, NULL); }	26,154,199✔
188
189	// if rid is 0, return the first p in hash list, otherwise, return the next after current rid
190	void *taosAcquireRef(int32_t rsetId, int64_t rid) {	369,818,454✔
191	int32_t hash;
192	SRefNode *pNode;
193	SRefSet *pSet;
194	int32_t iter = 0;	369,818,454✔
195	void *p = NULL;	369,818,454✔
196
197	if (rsetId < 0 \|\| rsetId >= TSDB_REF_OBJECTS) {	369,818,454!
198	// uTrace("rsetId:%d, rid:0x%" PRIx64 " failed to acquire, rsetId not valid", rsetId, rid);
199	terrno = TSDB_CODE_REF_INVALID_ID;	×
200	return NULL;	150✔
201	}
202
203	if (rid <= 0) {	370,484,073✔
204	uTrace("rid:0x%" PRIx64 ", failed to acquire, rid not valid, rsetId:%d", rid, rsetId);	127,473✔
205	terrno = TSDB_CODE_REF_NOT_EXIST;	127,473✔
206	return NULL;	127,473✔
207	}
208
209	pSet = tsRefSetList + rsetId;	370,356,600✔
210	taosIncRsetCount(pSet);	370,356,600✔
211	if (pSet->state != TSDB_REF_STATE_ACTIVE) {	372,332,353!
212	uTrace("rid:0x%" PRIx64 ", failed to acquire, not active, rsetId:%d", rid, rsetId);	×
213	taosDecRsetCount(pSet);	×
214	terrno = TSDB_CODE_REF_ID_REMOVED;	×
215	return NULL;	×
216	}
217
218	hash = rid % pSet->max;	372,332,353✔
219	taosLockList(pSet->lockedBy + hash);	372,332,353✔
220
221	pNode = pSet->nodeList[hash];	371,957,339✔
222
223	while (pNode) {	372,505,785✔
224	if (pNode->rid == rid) {	357,359,774✔
225	break;	356,811,328✔
226	}
227	iter++;	548,446✔
228	pNode = pNode->next;	548,446✔
229	}
230
231	if (iter >= TSDB_REF_ITER_THRESHOLD) {	371,957,339!
232	uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);	×
233	}
234
235	if (pNode) {	372,382,689✔
236	if (pNode->removed == 0) {	356,611,062✔
237	pNode->count++;	356,365,223✔
238	p = pNode->p;	356,365,223✔
239	uTrace("p:%p, rid:0x%" PRIx64 " is acquired, remain count:%d, rsetId:%d", pNode->p, rid, pNode->count, rsetId);	356,365,223✔
240	} else {
241	terrno = TSDB_CODE_REF_NOT_EXIST;	245,839✔
242	uTrace("p:%p, rid:0x%" PRIx64 " is already removed, failed to acquire, rsetId:%d", pNode->p, rid, rsetId);	305,893!
243	}
244	} else {
245	terrno = TSDB_CODE_REF_NOT_EXIST;	15,771,627✔
246	uTrace("rid:0x%" PRIx64 ", is not there, failed to acquire, rsetId:%d", rid, rsetId);	15,751,128!
247	}
248
249	taosUnlockList(pSet->lockedBy + hash);	372,422,244✔
250
251	taosDecRsetCount(pSet);	371,937,463✔
252
253	return p;	371,924,473✔
254	}
255
256	int32_t taosReleaseRef(int32_t rsetId, int64_t rid) { return taosDecRefCount(rsetId, rid, 0, NULL); }	355,804,216✔
257	int32_t taosReleaseRefEx(int32_t rsetId, int64_t rid, int32_t *isReleased) {	8,165,354✔
258	return taosDecRefCount(rsetId, rid, 0, isReleased);	8,165,354✔
259	}
260
261	// if rid is 0, return the first p in hash list, otherwise, return the next after current rid
262	void *taosIterateRef(int32_t rsetId, int64_t rid) {	1,190,209✔
263	SRefNode *pNode = NULL;	1,190,209✔
264	SRefSet *pSet;
265
266	if (rsetId < 0 \|\| rsetId >= TSDB_REF_OBJECTS) {	1,190,209!
267	uTrace("rid:0x%" PRIx64 ", failed to iterate, rsetId not valid, rsetId:%d", rid, rsetId);	×
268	terrno = TSDB_CODE_REF_INVALID_ID;	×
269	return NULL;	×
270	}
271
272	if (rid < 0) {	1,190,209!
273	uTrace("rid:0x%" PRIx64 ", failed to iterate, rid not valid, rsetId:%d", rid, rsetId);	×
274	terrno = TSDB_CODE_REF_NOT_EXIST;	×
275	return NULL;	×
276	}
277
278	void *newP = NULL;	1,190,209✔
279	pSet = tsRefSetList + rsetId;	1,190,209✔
280	taosIncRsetCount(pSet);	1,190,209✔
281	if (pSet->state != TSDB_REF_STATE_ACTIVE) {	1,190,209!
282	uTrace("rid:0x%" PRIx64 ", failed to iterate, rset not active, rsetId:%d", rid, rsetId);	×
283	terrno = TSDB_CODE_REF_ID_REMOVED;	×
284	taosDecRsetCount(pSet);	×
285	return NULL;	×
286	}
287
288	do {
289	newP = NULL;	1,190,209✔
290	int32_t hash = 0;	1,190,209✔
291	int32_t iter = 0;	1,190,209✔
292	if (rid > 0) {	1,190,209✔
293	hash = rid % pSet->max;	1,016,886✔
294	taosLockList(pSet->lockedBy + hash);	1,016,886✔
295
296	pNode = pSet->nodeList[hash];	1,016,886✔
297	while (pNode) {	1,620,831!
298	if (pNode->rid == rid) break;	1,620,831✔
299	pNode = pNode->next;	603,945✔
300	iter++;	603,945✔
301	}
302
303	if (iter >= TSDB_REF_ITER_THRESHOLD) {	1,016,886!
304	uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);	×
305	}
306
307	if (pNode == NULL) {	1,016,886!
308	uError("rid:0x%" PRIx64 ", not there and quit, rsetId:%d", rid, rsetId);	×
309	terrno = TSDB_CODE_REF_NOT_EXIST;	×
310	taosUnlockList(pSet->lockedBy + hash);	×
311	taosDecRsetCount(pSet);	×
312	return NULL;	×
313	}
314
315	// rid is there
316	pNode = pNode->next;	1,016,886✔
317	// check first place
318	while (pNode) {	1,016,886✔
319	if (!pNode->removed) break;	305,098!
320	pNode = pNode->next;	×
321	}
322	if (pNode == NULL) {	1,016,886✔
323	taosUnlockList(pSet->lockedBy + hash);	711,788✔
324	hash++;	711,788✔
325	}
326	}
327
328	if (pNode == NULL) {	1,190,209✔
329	for (; hash < pSet->max; ++hash) {	8,864,915✔
330	taosLockList(pSet->lockedBy + hash);	8,691,592✔
331	pNode = pSet->nodeList[hash];	8,691,592✔
332	if (pNode) {	8,691,592✔
333	// check first place
334	while (pNode) {	711,788!
335	if (!pNode->removed) break;	711,788!
336	pNode = pNode->next;	×
337	}
338	if (pNode) break;	711,788!
339	}
340	taosUnlockList(pSet->lockedBy + hash);	7,979,804✔
341	}
342	}
343
344	if (pNode) {	1,190,209✔
345	pNode->count++; // acquire it	1,016,886✔
346	newP = pNode->p;	1,016,886✔
347	taosUnlockList(pSet->lockedBy + hash);	1,016,886✔
348	uTrace("p:%p, rid:0x%" PRIx64 " is returned, rsetId:%d", newP, rid, rsetId);	1,016,886✔
349	} else {
350	uTrace("rsetId:%d, the list is over", rsetId);	173,323✔
351	}
352
353	if (rid > 0) taosReleaseRef(rsetId, rid); // release the current one	1,190,209✔
354	if (pNode) rid = pNode->rid;	1,190,209✔
355	} while (newP && pNode->removed);	1,190,209!
356
357	taosDecRsetCount(pSet);	1,190,209✔
358
359	return newP;	1,190,209✔
360	}
361
362	int32_t taosListRef() {	×
363	SRefSet *pSet;
364	SRefNode *pNode;
365	int32_t num = 0;	×
366
367	(void)taosThreadMutexLock(&tsRefMutex);	×
368
369	for (int32_t i = 0; i < TSDB_REF_OBJECTS; ++i) {	×
370	pSet = tsRefSetList + i;	×
371
372	if (pSet->state == TSDB_REF_STATE_EMPTY) continue;	×
373
374	uInfo("rsetId:%d, state:%d count:%d", i, pSet->state, pSet->count);	×
375
376	for (int32_t j = 0; j < pSet->max; ++j) {	×
377	pNode = pSet->nodeList[j];	×
378
379	while (pNode) {	×
380	uInfo("p:%p, rid:0x%" PRIx64 " count:%d, rsetId:%d", pNode->p, pNode->rid, pNode->count, i);	×
381	pNode = pNode->next;	×
382	num++;	×
383	}
384	}
385	}
386
387	(void)taosThreadMutexUnlock(&tsRefMutex);	×
388
389	return num;	×
390	}
391
392	static int32_t taosDecRefCount(int32_t rsetId, int64_t rid, int32_t remove, int32_t *isReleased) {	388,431,409✔
393	int32_t hash;
394	SRefSet *pSet;
395	SRefNode *pNode;
396	int32_t iter = 0;	388,431,409✔
397	int32_t released = 0;	388,431,409✔
398	int32_t code = 0;	388,431,409✔
399
400	if (rsetId < 0 \|\| rsetId >= TSDB_REF_OBJECTS) {	388,431,409!
401	uTrace("rid:0x%" PRIx64 ", failed to remove, rsetId not valid, rsetId:%d", rid, rsetId);	×
402	return terrno = TSDB_CODE_REF_INVALID_ID;	×
403	}
404
405	if (rid <= 0) {	388,969,733✔
406	uTrace("rid:0x%" PRIx64 ", failed to remove, rid not valid, rsetId:%d", rid, rsetId);	7,978,150!
407	return terrno = TSDB_CODE_REF_NOT_EXIST;	7,978,150✔
408	}
409
410	pSet = tsRefSetList + rsetId;	380,991,583✔
411	if (pSet->state == TSDB_REF_STATE_EMPTY) {	380,991,583!
412	uTrace("rid:0x%" PRIx64 ", failed to remove, cleaned, rsetId:%d", rid, rsetId);	×
413	return terrno = TSDB_CODE_REF_ID_REMOVED;	×
414	}
415
416	hash = rid % pSet->max;	380,991,583✔
417	taosLockList(pSet->lockedBy + hash);	380,991,583✔
418
419	pNode = pSet->nodeList[hash];	383,086,645✔
420	while (pNode) {	384,239,386!
421	if (pNode->rid == rid) break;	384,554,335✔
422
423	pNode = pNode->next;	1,152,741✔
424	iter++;	1,152,741✔
425	}
426
427	if (iter >= TSDB_REF_ITER_THRESHOLD) {	383,086,645!
428	uWarn("rid:0x%" PRIx64 ", iter:%d, rsetId:%d", rid, iter, rsetId);	×
429	}
430
431	if (pNode) {	383,156,543✔
432	pNode->count--;	383,154,059✔
433	if (remove) pNode->removed = 1;	383,154,059✔
434
435	if (pNode->count <= 0) {	383,154,059✔
436	if (pNode->prev) {	26,253,403✔
437	pNode->prev->next = pNode->next;	678✔
438	} else {
439	pSet->nodeList[hash] = pNode->next;	26,252,725✔
440	}
441
442	if (pNode->next) {	26,253,403✔
443	pNode->next->prev = pNode->prev;	11,343✔
444	}
445	released = 1;	26,253,403✔
446	} else {
447	uTrace("p:%p, rid:0x%" PRIx64 " is released, remain count:%d, rsetId:%d", pNode->p, rid, pNode->count, rsetId);	356,900,656✔
448	}
449	} else {
450	uTrace("rid:0x%" PRIx64 ", is not there, failed to release/remove, rsetId:%d", rid, rsetId);	2,484!
451	terrno = TSDB_CODE_REF_NOT_EXIST;	2,484✔
452	code = terrno;	2,484✔
453	}
454
455	taosUnlockList(pSet->lockedBy + hash);	383,156,542✔
456
457	if (released) {	383,152,977✔
458	uTrace("p:%p, rid:0x%" PRIx64 " is removed, count:%d, free mem:%p, rsetId:%d", pNode->p, rid, pSet->count, pNode,	26,249,378✔
459	rsetId);
460	(*pSet->fp)(pNode->p);	26,249,378✔
461	taosMemoryFree(pNode);	26,261,751!
462
463	taosDecRsetCount(pSet);	26,273,258✔
464	}
465
466	if (isReleased) {	383,110,610✔
467	*isReleased = released;	8,187,195✔
468	}
469
470	return code;	383,110,610✔
471	}
472
473	static void taosLockList(int64_t *lockedBy) {	781,700,077✔
474	int64_t tid = taosGetSelfPthreadId();	781,700,077✔
475	int32_t i = 0;	778,600,197✔
476	while (atomic_val_compare_exchange_64(lockedBy, 0, tid) != 0) {	798,095,269✔
477	if (++i % 100 == 0) {	19,495,197✔
478	(void)sched_yield();	155,667✔
479	}
480	}
481	}	786,390,095✔
482
483	static void taosUnlockList(int64_t *lockedBy) {	780,392,212✔
484	int64_t tid = taosGetSelfPthreadId();	780,392,212✔
485	(void)atomic_val_compare_exchange_64(lockedBy, tid, 0);	776,522,788✔
486	}	787,549,989✔
487
488	static void taosInitRefModule(void) { (void)taosThreadMutexInit(&tsRefMutex, NULL); }	7,659✔
489
490	static void taosIncRsetCount(SRefSet *pSet) {	396,475,049✔
491	(void)atomic_add_fetch_32(&pSet->count, 1);	396,475,049✔
492	// uTrace("rsetId:%d, inc count:%d", pSet->rsetId, count);
493	}	399,818,775✔
494
495	static void taosDecRsetCount(SRefSet *pSet) {	398,349,289✔
496	int32_t count = atomic_sub_fetch_32(&pSet->count, 1);	398,349,289✔
497	// uTrace("rsetId:%d, dec count:%d", pSet->rsetId, count);
498
499	if (count > 0) return;	399,633,213!
500
UNCOV 501	(void)taosThreadMutexLock(&tsRefMutex);	×
502
503	if (pSet->state != TSDB_REF_STATE_EMPTY) {	91,652!
504	pSet->state = TSDB_REF_STATE_EMPTY;	91,652✔
505	pSet->max = 0;	91,652✔
506	pSet->fp = NULL;	91,652✔
507
508	taosMemoryFreeClear(pSet->nodeList);	91,652!
509	taosMemoryFreeClear(pSet->lockedBy);	91,652!
510
511	tsRefSetNum--;	91,652✔
512	uTrace("rsetId:%d, is cleaned, refSetNum:%d count:%d", pSet->rsetId, tsRefSetNum, pSet->count);	91,652✔
513	}
514
515	(void)taosThreadMutexUnlock(&tsRefMutex);	91,652✔
516	}

taosdata / TDengine / #4696

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous