#4693

Committed 29 Aug 2025 06:36AM UTC coverage: 58.007% (-1.1%) from 59.151%

Build # #4693

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix(gpt): fix race-condition in preparing tmp files (#32800)

Run Details

132676 of 291873 branches covered (45.46%)

Branch coverage included in aggregate %.

5 of 34 new or added lines in 6 files covered. (14.71%)

4288 existing lines in 199 files now uncovered.

201114 of 283561 relevant lines covered (70.92%)

5433357.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.65

/source/dnode/vnode/src/tsdb/tsdbMerge.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "tsdbMerge.h"

#define TSDB_MAX_LEVEL 2  // means max level is 3

typedef struct {
  STsdb     *tsdb;
  int32_t    fid;
  STFileSet *fset;

  int32_t sttTrigger;
  int32_t maxRow;
  int32_t minRow;
  int32_t szPage;
  int8_t  cmprAlg;
  int64_t compactVersion;
  int64_t cid;

  // context
  struct {
    bool       opened;
    int64_t    now;
    STFileSet *fset;
    bool       toData;
    int32_t    level;
    TABLEID    tbid[1];
  } ctx[1];

  TFileOpArray fopArr[1];

  // reader
  TSttFileReaderArray sttReaderArr[1];
  // iter
  TTsdbIterArray dataIterArr[1];
  SIterMerger   *dataIterMerger;
  TTsdbIterArray tombIterArr[1];
  SIterMerger   *tombIterMerger;
  // writer
  SFSetWriter *writer;
} SMerger;

static int32_t tsdbMergerOpen(SMerger *merger) {
  merger->ctx->now = taosGetTimestampSec();
  merger->maxRow = merger->tsdb->pVnode->config.tsdbCfg.maxRows;
  merger->minRow = merger->tsdb->pVnode->config.tsdbCfg.minRows;
  merger->szPage = merger->tsdb->pVnode->config.tsdbPageSize;
  merger->cmprAlg = merger->tsdb->pVnode->config.tsdbCfg.compression;
  merger->compactVersion = INT64_MAX;
  merger->cid = tsdbFSAllocEid(merger->tsdb->pFS);
  merger->ctx->opened = true;
  return 0;
}

static int32_t tsdbMergerClose(SMerger *merger) {
  int32_t lino = 0;
  SVnode *pVnode = merger->tsdb->pVnode;

  // clear the merge
  TARRAY2_DESTROY(merger->tombIterArr, NULL);
  TARRAY2_DESTROY(merger->dataIterArr, NULL);
  TARRAY2_DESTROY(merger->sttReaderArr, NULL);
  TARRAY2_DESTROY(merger->fopArr, NULL);
  return 0;
}

static void tsdbMergeFileSetEndCloseReader(SMerger *merger) {
  TARRAY2_CLEAR(merger->sttReaderArr, tsdbSttFileReaderClose);
}

static int32_t tsdbMergeFileSetBeginOpenReader(SMerger *merger) {
  int32_t  code = 0;
  int32_t  lino = 0;
  SSttLvl *lvl;

  bool hasLevelLargerThanMax = false;
  TARRAY2_FOREACH_REVERSE(merger->ctx->fset->lvlArr, lvl) {
    if (lvl->level <= TSDB_MAX_LEVEL) {
      break;
    } else if (TARRAY2_SIZE(lvl->fobjArr) > 0) {
      hasLevelLargerThanMax = true;
      break;
    }
  }

  if (hasLevelLargerThanMax) {
    // merge all stt files
    merger->ctx->toData = true;
    merger->ctx->level = TSDB_MAX_LEVEL;

    TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {
      int32_t numMergeFile = TARRAY2_SIZE(lvl->fobjArr);

      for (int32_t i = 0; i < numMergeFile; ++i) {
        STFileObj *fobj = TARRAY2_GET(lvl->fobjArr, i);

        STFileOp op = {
            .optype = TSDB_FOP_REMOVE,
            .fid = merger->ctx->fset->fid,
            .of = fobj->f[0],
        };
        TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->fopArr, op), &lino, _exit);

        SSttFileReader      *reader;
        SSttFileReaderConfig config = {
            .tsdb = merger->tsdb,
            .szPage = merger->szPage,
            .file[0] = fobj->f[0],
        };

        TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &reader), &lino, _exit);

        TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->sttReaderArr, reader), &lino, _exit);
      }
    }
  } else {
    // do regular merge
    merger->ctx->toData = true;
    merger->ctx->level = 0;

    // find the highest level that can be merged to
    for (int32_t i = 0, numCarry = 0;;) {
      int32_t numFile = numCarry;
      if (i < TARRAY2_SIZE(merger->ctx->fset->lvlArr) &&
          merger->ctx->level == TARRAY2_GET(merger->ctx->fset->lvlArr, i)->level) {
        numFile += TARRAY2_SIZE(TARRAY2_GET(merger->ctx->fset->lvlArr, i)->fobjArr);
        i++;
      }

      numCarry = numFile / merger->sttTrigger;
      if (numCarry == 0) {
        break;
      } else {
        merger->ctx->level++;
      }
    }

    if (merger->ctx->level <= TSDB_MAX_LEVEL) {
      TARRAY2_FOREACH_REVERSE(merger->ctx->fset->lvlArr, lvl) {
        if (TARRAY2_SIZE(lvl->fobjArr) == 0) {
          continue;
        }

        if (lvl->level >= merger->ctx->level) {
          merger->ctx->toData = false;
        }
        break;
      }
    }

    // get number of level-0 files to merge
    int32_t numFile = pow(merger->sttTrigger, merger->ctx->level);
    TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {
      if (lvl->level == 0) continue;
      if (lvl->level >= merger->ctx->level) break;

      numFile = numFile - TARRAY2_SIZE(lvl->fobjArr) * pow(merger->sttTrigger, lvl->level);
    }

    // get file system operations
    TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {
      if (lvl->level >= merger->ctx->level) {
        break;
      }

      int32_t numMergeFile;
      if (lvl->level == 0) {
        numMergeFile = numFile;
      } else {
        numMergeFile = TARRAY2_SIZE(lvl->fobjArr);
      }

      for (int32_t i = 0; i < numMergeFile; ++i) {
        STFileObj *fobj = TARRAY2_GET(lvl->fobjArr, i);

        STFileOp op = {
            .optype = TSDB_FOP_REMOVE,
            .fid = merger->ctx->fset->fid,
            .of = fobj->f[0],
        };
        TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->fopArr, op), &lino, _exit);

        SSttFileReader      *reader;
        SSttFileReaderConfig config = {
            .tsdb = merger->tsdb,
            .szPage = merger->szPage,
            .file[0] = fobj->f[0],
        };

        TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &reader), &lino, _exit);

        if ((code = TARRAY2_APPEND(merger->sttReaderArr, reader))) {
          tsdbSttFileReaderClose(&reader);
          TSDB_CHECK_CODE(code, lino, _exit);
        }
      }
    }

    if (merger->ctx->level > TSDB_MAX_LEVEL) {
      merger->ctx->level = TSDB_MAX_LEVEL;
    }
  }

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,
              tstrerror(code));
    tsdbMergeFileSetEndCloseReader(merger);
  }
  return code;
}

static int32_t tsdbMergeFileSetBeginOpenIter(SMerger *merger) {
  int32_t code = 0;
  int32_t lino = 0;
  int32_t vid = TD_VID(merger->tsdb->pVnode);

  SSttFileReader *sttReader;
  TARRAY2_FOREACH(merger->sttReaderArr, sttReader) {
    STsdbIter      *iter;
    STsdbIterConfig config = {0};

    // data iter
    config.type = TSDB_ITER_TYPE_STT;
    config.sttReader = sttReader;

    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
    TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->dataIterArr, iter), &lino, _exit);

    // tomb iter
    config.type = TSDB_ITER_TYPE_STT_TOMB;
    config.sttReader = sttReader;

    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);

    TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->tombIterArr, iter), &lino, _exit);
  }

  TAOS_CHECK_GOTO(tsdbIterMergerOpen(merger->dataIterArr, &merger->dataIterMerger, false), &lino, _exit);

  TAOS_CHECK_GOTO(tsdbIterMergerOpen(merger->tombIterArr, &merger->tombIterMerger, true), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", vid, __func__, __FILE__, lino, tstrerror(code));
  }
  return code;
}

static int32_t tsdbMergeFileSetBeginOpenWriter(SMerger *merger) {
  int32_t code = 0;
  int32_t lino = 0;
  int32_t vid = TD_VID(merger->tsdb->pVnode);

  SFSetWriterConfig config = {
      .tsdb = merger->tsdb,
      .toSttOnly = true,
      .compactVersion = merger->compactVersion,
      .minRow = merger->minRow,
      .maxRow = merger->maxRow,
      .szPage = merger->szPage,
      .cmprAlg = merger->cmprAlg,
      .fid = merger->ctx->fset->fid,
      .cid = merger->cid,
      .expLevel = tsdbFidLevel(merger->ctx->fset->fid, &merger->tsdb->keepCfg, merger->ctx->now),
      .level = merger->ctx->level,
  };

  if (merger->ctx->toData) {
    config.toSttOnly = false;

    for (int32_t ftype = 0; ftype < TSDB_FTYPE_MAX; ++ftype) {
      if (merger->ctx->fset->farr[ftype]) {
        config.files[ftype].exist = true;
        config.files[ftype].file = merger->ctx->fset->farr[ftype]->f[0];
      } else {
        config.files[ftype].exist = false;
      }
    }
  }

  TAOS_CHECK_GOTO(tsdbFSetWriterOpen(&config, &merger->writer), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", vid, __func__, __FILE__, lino, tstrerror(code));
  }
  return code;
}

static int32_t tsdbMergeFileSetBegin(SMerger *merger) {
  int32_t code = 0;
  int32_t lino = 0;

  TARRAY2_CLEAR(merger->fopArr, NULL);

  merger->ctx->tbid->suid = 0;
  merger->ctx->tbid->uid = 0;

  // open reader
  TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenReader(merger), &lino, _exit);

  // open iterator
  TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenIter(merger), &lino, _exit);

  // open writer
  TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenWriter(merger), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,
              tstrerror(code));
  }
  return code;
}

static int32_t tsdbMergeFileSetEndCloseWriter(SMerger *merger) {
  return tsdbFSetWriterClose(&merger->writer, 0, merger->fopArr);
}

static int32_t tsdbMergeFileSetEndCloseIter(SMerger *merger) {
  tsdbIterMergerClose(&merger->tombIterMerger);
  TARRAY2_CLEAR(merger->tombIterArr, tsdbIterClose);
  tsdbIterMergerClose(&merger->dataIterMerger);
  TARRAY2_CLEAR(merger->dataIterArr, tsdbIterClose);
  return 0;
}

static int32_t tsdbMergeFileSetEnd(SMerger *merger) {
  int32_t code = 0;
  int32_t lino = 0;

  TAOS_CHECK_GOTO(tsdbMergeFileSetEndCloseWriter(merger), &lino, _exit);

  TAOS_CHECK_GOTO(tsdbMergeFileSetEndCloseIter(merger), &lino, _exit);

  tsdbMergeFileSetEndCloseReader(merger);

  // edit file system
  TAOS_CHECK_GOTO(tsdbFSEditBegin(merger->tsdb->pFS, merger->fopArr, TSDB_FEDIT_MERGE), &lino, _exit);

  (void)taosThreadMutexLock(&merger->tsdb->mutex);
  code = tsdbFSEditCommit(merger->tsdb->pFS);
  if (code) {
    (void)taosThreadMutexUnlock(&merger->tsdb->mutex);
    TSDB_CHECK_CODE(code, lino, _exit);
  }
  (void)taosThreadMutexUnlock(&merger->tsdb->mutex);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,
              tstrerror(code));
    TSDB_ERROR_LOG(TD_VID(merger->tsdb->pVnode), lino, code);
  }
  return code;
}

static int32_t tsdbMergeFileSet(SMerger *merger, STFileSet *fset) {
  int32_t code = 0;
  int32_t lino = 0;

  merger->ctx->fset = fset;
  TAOS_CHECK_GOTO(tsdbMergeFileSetBegin(merger), &lino, _exit);

  // data
  SMetaInfo info;
  SRowInfo *row;
  merger->ctx->tbid->suid = 0;
  merger->ctx->tbid->uid = 0;
  while ((row = tsdbIterMergerGetData(merger->dataIterMerger)) != NULL) {
    if (row->uid != merger->ctx->tbid->uid) {
      merger->ctx->tbid->uid = row->uid;
      merger->ctx->tbid->suid = row->suid;

      if (metaGetInfo(merger->tsdb->pVnode->pMeta, row->uid, &info, NULL) != 0) {
        TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(merger->dataIterMerger, merger->ctx->tbid), &lino, _exit);
        continue;
      }
    }

    TAOS_CHECK_GOTO(tsdbFSetWriteRow(merger->writer, row), &lino, _exit);

    TAOS_CHECK_GOTO(tsdbIterMergerNext(merger->dataIterMerger), &lino, _exit);
  }

  // tomb
  merger->ctx->tbid->suid = 0;
  merger->ctx->tbid->uid = 0;
  for (STombRecord *record; (record = tsdbIterMergerGetTombRecord(merger->tombIterMerger)) != NULL;) {
    if (record->uid != merger->ctx->tbid->uid) {
      merger->ctx->tbid->uid = record->uid;
      merger->ctx->tbid->suid = record->suid;

      if (metaGetInfo(merger->tsdb->pVnode->pMeta, record->uid, &info, NULL) != 0) {
        TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(merger->tombIterMerger, merger->ctx->tbid), &lino, _exit);
        continue;
      }
    }
    TAOS_CHECK_GOTO(tsdbFSetWriteTombRecord(merger->writer, record), &lino, _exit);

    TAOS_CHECK_GOTO(tsdbIterMergerNext(merger->tombIterMerger), &lino, _exit);
  }

  TAOS_CHECK_GOTO(tsdbMergeFileSetEnd(merger), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,
              tstrerror(code));
  } else {
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(merger->tsdb->pVnode), __func__, fset->fid);
  }
  return code;
}

static int32_t tsdbDoMerge(SMerger *merger) {
  int32_t code = 0;
  int32_t lino = 0;

  if (TARRAY2_SIZE(merger->fset->lvlArr) == 0) return 0;

  SSttLvl *lvl = TARRAY2_FIRST(merger->fset->lvlArr);
  if (lvl->level != 0 || TARRAY2_SIZE(lvl->fobjArr) < merger->sttTrigger) {
    return 0;
  }

  TAOS_CHECK_GOTO(tsdbMergerOpen(merger), &lino, _exit);
  TAOS_CHECK_GOTO(tsdbMergeFileSet(merger, merger->fset), &lino, _exit);
  TAOS_CHECK_GOTO(tsdbMergerClose(merger), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,
              tstrerror(code));
  } else {
    tsdbDebug("vgId:%d %s done", TD_VID(merger->tsdb->pVnode), __func__);
  }
  return code;
}

static int32_t tsdbMergeGetFSet(SMerger *merger) {
  STFileSet *fset;
  int32_t    code;
  STsdb     *tsdb = merger->tsdb;

  (void)taosThreadMutexLock(&merger->tsdb->mutex);

  if (tsdb->bgTaskDisabled) {
    (void)taosThreadMutexUnlock(&merger->tsdb->mutex);
    return 0;
  }

  tsdbBeginTaskOnFileSet(tsdb, merger->fid, EVA_TASK_MERGE, &fset);
  if (NULL == fset) {
    (void)taosThreadMutexUnlock(&merger->tsdb->mutex);
    return 0;
  }

  code = tsdbTFileSetInitCopy(merger->tsdb, fset, &merger->fset);
  if (code) {
    (void)taosThreadMutexUnlock(&merger->tsdb->mutex);
    return code;
  }

  (void)taosThreadMutexUnlock(&merger->tsdb->mutex);
  return 0;
}

int32_t tsdbMerge(void *arg) {
  int32_t    code = 0;
  int32_t    lino = 0;
  SMergeArg *mergeArg = (SMergeArg *)arg;
  STsdb     *tsdb = mergeArg->tsdb;

  SMerger merger[1] = {{
      .tsdb = tsdb,
      .fid = mergeArg->fid,
      .sttTrigger = tsdb->pVnode->config.sttTrigger,
  }};

  if (merger->sttTrigger <= 1) {
    return 0;
  }

  // copy snapshot
  code = tsdbMergeGetFSet(merger);
  TSDB_CHECK_CODE(code, lino, _exit);

  if (merger->fset == NULL) {
    return 0;
  }

  // do merge
  tsdbInfo("vgId:%d merge begin, fid:%d", TD_VID(tsdb->pVnode), merger->fid);
  METRICS_TIMING_BLOCK(tsdb->pVnode->writeMetrics.merge_time, METRIC_LEVEL_HIGH, { code = tsdbDoMerge(merger); });
  METRICS_UPDATE(tsdb->pVnode->writeMetrics.merge_count, METRIC_LEVEL_HIGH, 1);
  tsdbInfo("vgId:%d merge done, fid:%d", TD_VID(tsdb->pVnode), mergeArg->fid);
  TSDB_CHECK_CODE(code, lino, _exit);

_exit:
  if (merger->fset) {
    (void)taosThreadMutexLock(&tsdb->mutex);
    tsdbFinishTaskOnFileSet(tsdb, mergeArg->fid, EVA_TASK_MERGE);
    (void)taosThreadMutexUnlock(&tsdb->mutex);
  }

  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
    tsdbFatal("vgId:%d, failed to merge stt files since %s. code:%d", TD_VID(tsdb->pVnode), terrstr(), code);
    taosMsleep(100);
    exit(EXIT_FAILURE);
  }

  tsdbTFileSetClear(&merger->fset);
  taosMemoryFree(arg);
  return code;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "tsdbMerge.h"
17
18	#define TSDB_MAX_LEVEL 2 // means max level is 3
19
20	typedef struct {
21	STsdb *tsdb;
22	int32_t fid;
23	STFileSet *fset;
24
25	int32_t sttTrigger;
26	int32_t maxRow;
27	int32_t minRow;
28	int32_t szPage;
29	int8_t cmprAlg;
30	int64_t compactVersion;
31	int64_t cid;
32
33	// context
34	struct {
35	bool opened;
36	int64_t now;
37	STFileSet *fset;
38	bool toData;
39	int32_t level;
40	TABLEID tbid[1];
41	} ctx[1];
42
43	TFileOpArray fopArr[1];
44
45	// reader
46	TSttFileReaderArray sttReaderArr[1];
47	// iter
48	TTsdbIterArray dataIterArr[1];
49	SIterMerger *dataIterMerger;
50	TTsdbIterArray tombIterArr[1];
51	SIterMerger *tombIterMerger;
52	// writer
53	SFSetWriter *writer;
54	} SMerger;
55
56	static int32_t tsdbMergerOpen(SMerger *merger) {	3,095✔
57	merger->ctx->now = taosGetTimestampSec();	3,095✔
58	merger->maxRow = merger->tsdb->pVnode->config.tsdbCfg.maxRows;	3,095✔
59	merger->minRow = merger->tsdb->pVnode->config.tsdbCfg.minRows;	3,095✔
60	merger->szPage = merger->tsdb->pVnode->config.tsdbPageSize;	3,095✔
61	merger->cmprAlg = merger->tsdb->pVnode->config.tsdbCfg.compression;	3,095✔
62	merger->compactVersion = INT64_MAX;	3,095✔
63	merger->cid = tsdbFSAllocEid(merger->tsdb->pFS);	3,095✔
64	merger->ctx->opened = true;	3,095✔
65	return 0;	3,095✔
66	}
67
68	static int32_t tsdbMergerClose(SMerger *merger) {	3,095✔
69	int32_t lino = 0;	3,095✔
70	SVnode *pVnode = merger->tsdb->pVnode;	3,095✔
71
72	// clear the merge
73	TARRAY2_DESTROY(merger->tombIterArr, NULL);	3,095!
74	TARRAY2_DESTROY(merger->dataIterArr, NULL);	3,095!
75	TARRAY2_DESTROY(merger->sttReaderArr, NULL);	3,095!
76	TARRAY2_DESTROY(merger->fopArr, NULL);	3,095!
77	return 0;	3,095✔
78	}
79
80	static void tsdbMergeFileSetEndCloseReader(SMerger *merger) {	3,095✔
81	TARRAY2_CLEAR(merger->sttReaderArr, tsdbSttFileReaderClose);	11,733!
82	}	3,095✔
83
84	static int32_t tsdbMergeFileSetBeginOpenReader(SMerger *merger) {	3,095✔
85	int32_t code = 0;	3,095✔
86	int32_t lino = 0;	3,095✔
87	SSttLvl *lvl;
88
89	bool hasLevelLargerThanMax = false;	3,095✔
90	TARRAY2_FOREACH_REVERSE(merger->ctx->fset->lvlArr, lvl) {	3,095!
91	if (lvl->level <= TSDB_MAX_LEVEL) {	3,095!
92	break;	3,095✔
93	} else if (TARRAY2_SIZE(lvl->fobjArr) > 0) {	×
94	hasLevelLargerThanMax = true;	×
95	break;	×
96	}
97	}
98
99	if (hasLevelLargerThanMax) {	3,095!
100	// merge all stt files
101	merger->ctx->toData = true;	×
102	merger->ctx->level = TSDB_MAX_LEVEL;	×
103
104	TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {	×
105	int32_t numMergeFile = TARRAY2_SIZE(lvl->fobjArr);	×
106
107	for (int32_t i = 0; i < numMergeFile; ++i) {	×
108	STFileObj *fobj = TARRAY2_GET(lvl->fobjArr, i);	×
109
110	STFileOp op = {	×
111	.optype = TSDB_FOP_REMOVE,
112	.fid = merger->ctx->fset->fid,	×
113	.of = fobj->f[0],
114	};
115	TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->fopArr, op), &lino, _exit);	×
116
117	SSttFileReader *reader;
118	SSttFileReaderConfig config = {	×
119	.tsdb = merger->tsdb,	×
120	.szPage = merger->szPage,	×
121	.file[0] = fobj->f[0],
122	};
123
124	TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &reader), &lino, _exit);	×
125
126	TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->sttReaderArr, reader), &lino, _exit);	×
127	}
128	}
129	} else {
130	// do regular merge
131	merger->ctx->toData = true;	3,095✔
132	merger->ctx->level = 0;	3,095✔
133
134	// find the highest level that can be merged to
135	for (int32_t i = 0, numCarry = 0;;) {	3,095✔
136	int32_t numFile = numCarry;	8,559✔
137	if (i < TARRAY2_SIZE(merger->ctx->fset->lvlArr) &&	8,559✔
138	merger->ctx->level == TARRAY2_GET(merger->ctx->fset->lvlArr, i)->level) {	6,536✔
139	numFile += TARRAY2_SIZE(TARRAY2_GET(merger->ctx->fset->lvlArr, i)->fobjArr);	5,385✔
140	i++;	5,385✔
141	}
142
143	numCarry = numFile / merger->sttTrigger;	8,559✔
144	if (numCarry == 0) {	8,559✔
145	break;	3,095✔
146	} else {
147	merger->ctx->level++;	5,464✔
148	}
149	}
150
151	if (merger->ctx->level <= TSDB_MAX_LEVEL) {	3,095✔
152	TARRAY2_FOREACH_REVERSE(merger->ctx->fset->lvlArr, lvl) {	1,986!
153	if (TARRAY2_SIZE(lvl->fobjArr) == 0) {	1,986!
154	continue;	×
155	}
156
157	if (lvl->level >= merger->ctx->level) {	1,986✔
158	merger->ctx->toData = false;	1,150✔
159	}
160	break;	1,986✔
161	}
162	}
163
164	// get number of level-0 files to merge
165	int32_t numFile = pow(merger->sttTrigger, merger->ctx->level);	3,095✔
166	TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {	8,479✔
167	if (lvl->level == 0) continue;	6,534✔
168	if (lvl->level >= merger->ctx->level) break;	3,440✔
169
170	numFile = numFile - TARRAY2_SIZE(lvl->fobjArr) * pow(merger->sttTrigger, lvl->level);	2,290✔
171	}
172
173	// get file system operations
174	TARRAY2_FOREACH(merger->ctx->fset->lvlArr, lvl) {	8,477✔
175	if (lvl->level >= merger->ctx->level) {	6,533✔
176	break;	1,150✔
177	}
178
179	int32_t numMergeFile;
180	if (lvl->level == 0) {	5,383✔
181	numMergeFile = numFile;	3,094✔
182	} else {
183	numMergeFile = TARRAY2_SIZE(lvl->fobjArr);	2,289✔
184	}
185
186	for (int32_t i = 0; i < numMergeFile; ++i) {	14,019✔
187	STFileObj *fobj = TARRAY2_GET(lvl->fobjArr, i);	8,637✔
188
189	STFileOp op = {	8,637✔
190	.optype = TSDB_FOP_REMOVE,
191	.fid = merger->ctx->fset->fid,	8,637✔
192	.of = fobj->f[0],
193	};
194	TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->fopArr, op), &lino, _exit);	17,275!
195
196	SSttFileReader *reader;
197	SSttFileReaderConfig config = {	8,638✔
198	.tsdb = merger->tsdb,	8,638✔
199	.szPage = merger->szPage,	8,638✔
200	.file[0] = fobj->f[0],
201	};
202
203	TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &reader), &lino, _exit);	8,638!
204
205	if ((code = TARRAY2_APPEND(merger->sttReaderArr, reader))) {	17,272!
206	tsdbSttFileReaderClose(&reader);	×
207	TSDB_CHECK_CODE(code, lino, _exit);	×
208	}
209	}
210	}
211
212	if (merger->ctx->level > TSDB_MAX_LEVEL) {	3,094✔
213	merger->ctx->level = TSDB_MAX_LEVEL;	1,109✔
214	}
215	}
216
217	_exit:	1,985✔
218	if (code) {	3,094!
219	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,	×
220	tstrerror(code));
221	tsdbMergeFileSetEndCloseReader(merger);	×
222	}
223	return code;	3,095✔
224	}
225
226	static int32_t tsdbMergeFileSetBeginOpenIter(SMerger *merger) {	3,094✔
227	int32_t code = 0;	3,094✔
228	int32_t lino = 0;	3,094✔
229	int32_t vid = TD_VID(merger->tsdb->pVnode);	3,094✔
230
231	SSttFileReader *sttReader;
232	TARRAY2_FOREACH(merger->sttReaderArr, sttReader) {	11,732✔
233	STsdbIter *iter;
234	STsdbIterConfig config = {0};	8,638✔
235
236	// data iter
237	config.type = TSDB_ITER_TYPE_STT;	8,638✔
238	config.sttReader = sttReader;	8,638✔
239
240	TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);	8,638!
241	TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->dataIterArr, iter), &lino, _exit);	17,276!
242
243	// tomb iter
244	config.type = TSDB_ITER_TYPE_STT_TOMB;	8,638✔
245	config.sttReader = sttReader;	8,638✔
246
247	TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);	8,638!
248
249	TAOS_CHECK_GOTO(TARRAY2_APPEND(merger->tombIterArr, iter), &lino, _exit);	17,276!
250	}
251
252	TAOS_CHECK_GOTO(tsdbIterMergerOpen(merger->dataIterArr, &merger->dataIterMerger, false), &lino, _exit);	3,094!
253
254	TAOS_CHECK_GOTO(tsdbIterMergerOpen(merger->tombIterArr, &merger->tombIterMerger, true), &lino, _exit);	3,095!
255
256	_exit:	3,095✔
257	if (code) {	3,095!
258	tsdbError("vgId:%d %s failed at %s:%d since %s", vid, __func__, __FILE__, lino, tstrerror(code));	×
259	}
260	return code;	3,095✔
261	}
262
263	static int32_t tsdbMergeFileSetBeginOpenWriter(SMerger *merger) {	3,095✔
264	int32_t code = 0;	3,095✔
265	int32_t lino = 0;	3,095✔
266	int32_t vid = TD_VID(merger->tsdb->pVnode);	3,095✔
267
268	SFSetWriterConfig config = {	6,190✔
269	.tsdb = merger->tsdb,	3,095✔
270	.toSttOnly = true,
271	.compactVersion = merger->compactVersion,	3,095✔
272	.minRow = merger->minRow,	3,095✔
273	.maxRow = merger->maxRow,	3,095✔
274	.szPage = merger->szPage,	3,095✔
275	.cmprAlg = merger->cmprAlg,	3,095✔
276	.fid = merger->ctx->fset->fid,	3,095✔
277	.cid = merger->cid,	3,095✔
278	.expLevel = tsdbFidLevel(merger->ctx->fset->fid, &merger->tsdb->keepCfg, merger->ctx->now),	3,095✔
279	.level = merger->ctx->level,	3,095✔
280	};
281
282	if (merger->ctx->toData) {	3,095✔
283	config.toSttOnly = false;	1,945✔
284
285	for (int32_t ftype = 0; ftype < TSDB_FTYPE_MAX; ++ftype) {	9,725✔
286	if (merger->ctx->fset->farr[ftype]) {	7,780✔
287	config.files[ftype].exist = true;	2,587✔
288	config.files[ftype].file = merger->ctx->fset->farr[ftype]->f[0];	2,587✔
289	} else {
290	config.files[ftype].exist = false;	5,193✔
291	}
292	}
293	}
294
295	TAOS_CHECK_GOTO(tsdbFSetWriterOpen(&config, &merger->writer), &lino, _exit);	3,095!
296
297	_exit:	3,095✔
298	if (code) {	3,095!
299	tsdbError("vgId:%d %s failed at %s:%d since %s", vid, __func__, __FILE__, lino, tstrerror(code));	×
300	}
301	return code;	3,095✔
302	}
303
304	static int32_t tsdbMergeFileSetBegin(SMerger *merger) {	3,095✔
305	int32_t code = 0;	3,095✔
306	int32_t lino = 0;	3,095✔
307
308	TARRAY2_CLEAR(merger->fopArr, NULL);	3,095✔
309
310	merger->ctx->tbid->suid = 0;	3,095✔
311	merger->ctx->tbid->uid = 0;	3,095✔
312
313	// open reader
314	TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenReader(merger), &lino, _exit);	3,095!
315
316	// open iterator
317	TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenIter(merger), &lino, _exit);	3,095!
318
319	// open writer
320	TAOS_CHECK_GOTO(tsdbMergeFileSetBeginOpenWriter(merger), &lino, _exit);	3,095!
321
322	_exit:	3,095✔
323	if (code) {	3,095!
324	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,	×
325	tstrerror(code));
326	}
327	return code;	3,095✔
328	}
329
330	static int32_t tsdbMergeFileSetEndCloseWriter(SMerger *merger) {	3,095✔
331	return tsdbFSetWriterClose(&merger->writer, 0, merger->fopArr);	3,095✔
332	}
333
334	static int32_t tsdbMergeFileSetEndCloseIter(SMerger *merger) {	3,095✔
335	tsdbIterMergerClose(&merger->tombIterMerger);	3,095✔
336	TARRAY2_CLEAR(merger->tombIterArr, tsdbIterClose);	11,733!
337	tsdbIterMergerClose(&merger->dataIterMerger);	3,095✔
338	TARRAY2_CLEAR(merger->dataIterArr, tsdbIterClose);	11,733!
339	return 0;	3,095✔
340	}
341
342	static int32_t tsdbMergeFileSetEnd(SMerger *merger) {	3,095✔
343	int32_t code = 0;	3,095✔
344	int32_t lino = 0;	3,095✔
345
346	TAOS_CHECK_GOTO(tsdbMergeFileSetEndCloseWriter(merger), &lino, _exit);	3,095!
347
348	TAOS_CHECK_GOTO(tsdbMergeFileSetEndCloseIter(merger), &lino, _exit);	3,095!
349
350	tsdbMergeFileSetEndCloseReader(merger);	3,095✔
351
352	// edit file system
353	TAOS_CHECK_GOTO(tsdbFSEditBegin(merger->tsdb->pFS, merger->fopArr, TSDB_FEDIT_MERGE), &lino, _exit);	3,095!
354
355	(void)taosThreadMutexLock(&merger->tsdb->mutex);	3,095✔
356	code = tsdbFSEditCommit(merger->tsdb->pFS);	3,095✔
357	if (code) {	3,095!
358	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	×
359	TSDB_CHECK_CODE(code, lino, _exit);	×
360	}
361	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	3,095✔
362
363	_exit:	3,095✔
364	if (code) {	3,095!
365	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,	×
366	tstrerror(code));
367	TSDB_ERROR_LOG(TD_VID(merger->tsdb->pVnode), lino, code);	×
368	}
369	return code;	3,095✔
370	}
371
372	static int32_t tsdbMergeFileSet(SMerger merger, STFileSet fset) {	3,095✔
373	int32_t code = 0;	3,095✔
374	int32_t lino = 0;	3,095✔
375
376	merger->ctx->fset = fset;	3,095✔
377	TAOS_CHECK_GOTO(tsdbMergeFileSetBegin(merger), &lino, _exit);	3,095!
378
379	// data
380	SMetaInfo info;
381	SRowInfo *row;
382	merger->ctx->tbid->suid = 0;	3,095✔
383	merger->ctx->tbid->uid = 0;	3,095✔
384	while ((row = tsdbIterMergerGetData(merger->dataIterMerger)) != NULL) {	21,186,702✔
385	if (row->uid != merger->ctx->tbid->uid) {	21,171,438✔
386	merger->ctx->tbid->uid = row->uid;	21,555✔
387	merger->ctx->tbid->suid = row->suid;	21,555✔
388
389	if (metaGetInfo(merger->tsdb->pVnode->pMeta, row->uid, &info, NULL) != 0) {	21,555✔
390	TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(merger->dataIterMerger, merger->ctx->tbid), &lino, _exit);	633!
391	continue;	633✔
392	}
393	}
394
395	TAOS_CHECK_GOTO(tsdbFSetWriteRow(merger->writer, row), &lino, _exit);	21,170,805!
396
397	TAOS_CHECK_GOTO(tsdbIterMergerNext(merger->dataIterMerger), &lino, _exit);	21,234,959!
398	}
399
400	// tomb
401	merger->ctx->tbid->suid = 0;	3,095✔
402	merger->ctx->tbid->uid = 0;	3,095✔
403	for (STombRecord *record; (record = tsdbIterMergerGetTombRecord(merger->tombIterMerger)) != NULL;) {	14,898✔
404	if (record->uid != merger->ctx->tbid->uid) {	11,803✔
405	merger->ctx->tbid->uid = record->uid;	3,790✔
406	merger->ctx->tbid->suid = record->suid;	3,790✔
407
408	if (metaGetInfo(merger->tsdb->pVnode->pMeta, record->uid, &info, NULL) != 0) {	3,790✔
409	TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(merger->tombIterMerger, merger->ctx->tbid), &lino, _exit);	181!
410	continue;	181✔
411	}
412	}
413	TAOS_CHECK_GOTO(tsdbFSetWriteTombRecord(merger->writer, record), &lino, _exit);	11,622!
414
415	TAOS_CHECK_GOTO(tsdbIterMergerNext(merger->tombIterMerger), &lino, _exit);	11,622!
416	}
417
418	TAOS_CHECK_GOTO(tsdbMergeFileSetEnd(merger), &lino, _exit);	3,095!
419
420	_exit:	3,095✔
421	if (code) {	3,095!
422	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,	×
423	tstrerror(code));
424	} else {
425	tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(merger->tsdb->pVnode), __func__, fset->fid);	3,095✔
426	}
427	return code;	3,095✔
428	}
429
430	static int32_t tsdbDoMerge(SMerger *merger) {	3,095✔
431	int32_t code = 0;	3,095✔
432	int32_t lino = 0;	3,095✔
433
434	if (TARRAY2_SIZE(merger->fset->lvlArr) == 0) return 0;	3,095!
435
436	SSttLvl *lvl = TARRAY2_FIRST(merger->fset->lvlArr);	3,095✔
437	if (lvl->level != 0 \|\| TARRAY2_SIZE(lvl->fobjArr) < merger->sttTrigger) {	3,095!
438	return 0;	×
439	}
440
441	TAOS_CHECK_GOTO(tsdbMergerOpen(merger), &lino, _exit);	3,095!
442	TAOS_CHECK_GOTO(tsdbMergeFileSet(merger, merger->fset), &lino, _exit);	3,095!
443	TAOS_CHECK_GOTO(tsdbMergerClose(merger), &lino, _exit);	3,095!
444
445	_exit:	3,095✔
446	if (code) {	3,095!
447	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(merger->tsdb->pVnode), __func__, __FILE__, lino,	×
448	tstrerror(code));
449	} else {
450	tsdbDebug("vgId:%d %s done", TD_VID(merger->tsdb->pVnode), __func__);	3,095✔
451	}
452	return code;	3,095✔
453	}
454
455	static int32_t tsdbMergeGetFSet(SMerger *merger) {	3,095✔
456	STFileSet *fset;
457	int32_t code;
458	STsdb *tsdb = merger->tsdb;	3,095✔
459
460	(void)taosThreadMutexLock(&merger->tsdb->mutex);	3,095✔
461
462	if (tsdb->bgTaskDisabled) {	3,095!
UNCOV 463	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	×
UNCOV 464	return 0;	×
465	}
466
467	tsdbBeginTaskOnFileSet(tsdb, merger->fid, EVA_TASK_MERGE, &fset);	3,095✔
468	if (NULL == fset) {	3,095!
469	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	×
470	return 0;	×
471	}
472
473	code = tsdbTFileSetInitCopy(merger->tsdb, fset, &merger->fset);	3,095✔
474	if (code) {	3,095!
475	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	×
476	return code;	×
477	}
478
479	(void)taosThreadMutexUnlock(&merger->tsdb->mutex);	3,095✔
480	return 0;	3,095✔
481	}
482
483	int32_t tsdbMerge(void *arg) {	3,095✔
484	int32_t code = 0;	3,095✔
485	int32_t lino = 0;	3,095✔
486	SMergeArg mergeArg = (SMergeArg )arg;	3,095✔
487	STsdb *tsdb = mergeArg->tsdb;	3,095✔
488
489	SMerger merger[1] = {{	3,095✔
490	.tsdb = tsdb,
491	.fid = mergeArg->fid,	3,095✔
492	.sttTrigger = tsdb->pVnode->config.sttTrigger,	3,095✔
493	}};
494
495	if (merger->sttTrigger <= 1) {	3,095!
496	return 0;	×
497	}
498
499	// copy snapshot
500	code = tsdbMergeGetFSet(merger);	3,095✔
501	TSDB_CHECK_CODE(code, lino, _exit);	3,095!
502
503	if (merger->fset == NULL) {	3,095!
UNCOV 504	return 0;	×
505	}
506
507	// do merge
508	tsdbInfo("vgId:%d merge begin, fid:%d", TD_VID(tsdb->pVnode), merger->fid);	3,095!
509	METRICS_TIMING_BLOCK(tsdb->pVnode->writeMetrics.merge_time, METRIC_LEVEL_HIGH, { code = tsdbDoMerge(merger); });	3,095!
510	METRICS_UPDATE(tsdb->pVnode->writeMetrics.merge_count, METRIC_LEVEL_HIGH, 1);	3,095!
511	tsdbInfo("vgId:%d merge done, fid:%d", TD_VID(tsdb->pVnode), mergeArg->fid);	3,095!
512	TSDB_CHECK_CODE(code, lino, _exit);	3,095!
513
514	_exit:	3,095✔
515	if (merger->fset) {	3,095!
516	(void)taosThreadMutexLock(&tsdb->mutex);	3,095✔
517	tsdbFinishTaskOnFileSet(tsdb, mergeArg->fid, EVA_TASK_MERGE);	3,095✔
518	(void)taosThreadMutexUnlock(&tsdb->mutex);	3,095✔
519	}
520
521	if (code) {	3,095!
522	tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));	×
523	tsdbFatal("vgId:%d, failed to merge stt files since %s. code:%d", TD_VID(tsdb->pVnode), terrstr(), code);	×
524	taosMsleep(100);	×
525	exit(EXIT_FAILURE);	×
526	}
527
528	tsdbTFileSetClear(&merger->fset);	3,095✔
529	taosMemoryFree(arg);	3,095!
530	return code;	3,095✔
531	}

taosdata / TDengine / #4693

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous