#4693

Committed 29 Aug 2025 06:36AM UTC coverage: 58.007% (-1.1%) from 59.151%

Build # #4693

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix(gpt): fix race-condition in preparing tmp files (#32800)

Run Details

132676 of 291873 branches covered (45.46%)

Branch coverage included in aggregate %.

5 of 34 new or added lines in 6 files covered. (14.71%)

4288 existing lines in 199 files now uncovered.

201114 of 283561 relevant lines covered (70.92%)

5433357.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.11

/source/dnode/mnode/sdb/src/sdbHash.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "sdb.h"

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);

const char *sdbTableName(ESdbType type) {
  switch (type) {
    case SDB_TRANS:
      return "trans";
    case SDB_CLUSTER:
      return "cluster";
    case SDB_MNODE:
      return "mnode";
    case SDB_QNODE:
      return "qnode";
    case SDB_SNODE:
      return "snode";
    case SDB_DNODE:
      return "dnode";
    case SDB_USER:
      return "user";
    case SDB_AUTH:
      return "auth";
    case SDB_ACCT:
      return "acct";
    case SDB_STREAM_CK:
      return "stream_ck";
    case SDB_STREAM:
      return "stream";
    case SDB_OFFSET:
      return "offset";
    case SDB_SUBSCRIBE:
      return "subscribe";
    case SDB_CONSUMER:
      return "consumer";
    case SDB_TOPIC:
      return "topic";
    case SDB_VGROUP:
      return "vgroup";
    case SDB_SMA:
      return "sma";
    case SDB_STB:
      return "stb";
    case SDB_DB:
      return "db";
    case SDB_FUNC:
      return "func";
    case SDB_IDX:
      return "idx";
    case SDB_VIEW:
      return "view";
    case SDB_STREAM_SEQ:
      return "stream_seq";
    case SDB_COMPACT:
      return "compact";
    case SDB_COMPACT_DETAIL:
      return "compact_detail";
    case SDB_GRANT:
      return "grant";
    case SDB_ARBGROUP:
      return "arb_group";
    case SDB_ANODE:
      return "anode";
    case SDB_BNODE:
      return "bnode";
    case SDB_CFG:
      return "config";
    case SDB_MOUNT:
      return "mount";
    default:
      return "undefine";
  }
}

const char *sdbStatusName(ESdbStatus status) {
  switch (status) {
    case SDB_STATUS_CREATING:
      return "creating";
    case SDB_STATUS_DROPPING:
      return "dropping";
    case SDB_STATUS_READY:
      return "ready";
    case SDB_STATUS_DROPPED:
      return "dropped";
    case SDB_STATUS_INIT:
      return "init";
    case SDB_STATUS_UPDATE:
      return "update";
    default:
      return "undefine";
  }
}

void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
#if 1
  EKeyType keyType = pSdb->keyTypes[pRow->type];

  if (keyType == SDB_KEY_BINARY) {
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT32) {
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT64) {
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else {
  }
#endif
}

static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return NULL;
  }

  SHashObj *hash = pSdb->hashObjs[type];
  if (hash == NULL) {
    terrno = TSDB_CODE_APP_ERROR;
    return NULL;
  }

  return hash;
}

static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
  int32_t  keySize = 0;
  EKeyType keyType = pSdb->keyTypes[type];

  if (keyType == SDB_KEY_INT32) {
    keySize = sizeof(int32_t);
  } else if (keyType == SDB_KEY_BINARY) {
    keySize = strlen(pKey) + 1;
  } else {
    keySize = sizeof(int64_t);
  }

  return keySize;
}

static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (pOldRow != NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
    return terrno;
  }

  pRow->refCount = 0;
  pRow->status = pRaw->status;
  sdbPrintOper(pSdb, pRow, "insert");

  int32_t code = 0;
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    return code;
  }

  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
  if (insertFp != NULL) {
    code = (*insertFp)(pSdb, pRow->pObj);
    if (code != 0) {
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
        mError("failed to remove row from hash");
      }
      sdbFreeRow(pSdb, pRow, false);
      sdbUnLock(pSdb, type);
      terrno = code;
      return terrno;
    }
  }

  sdbUnLock(pSdb, type);

  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
  }
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
  }
  pSdb->tableVer[pRow->type]++;

  return 0;
}

static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
  int32_t type = pNewRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
  }

  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;
  sdbPrintOper(pSdb, pOldRow, "update");

  int32_t     code = 0;
  SdbUpdateFp updateFp = pSdb->updateFps[type];
  if (updateFp != NULL) {
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
  }
  sdbUnLock(pSdb, type);

  // sdbUnLock(pSdb, type);
  sdbFreeRow(pSdb, pNewRow, false);

  pSdb->tableVer[pOldRow->type]++;
  return code;
}

static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;

  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
  sdbPrintOper(pSdb, pOldRow, "delete");

  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  pSdb->tableVer[pOldRow->type]++;
  sdbUnLock(pSdb, type);

  sdbFreeRow(pSdb, pRow, false);

  sdbCheckRow(pSdb, pOldRow);
  return 0;
}

int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
  if (pRaw->type == SDB_CFG) {
    mTrace("sdb write cfg");
  }
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
  if (hash == NULL) return terrno;

  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
  SSdbRow    *pRow = (*decodeFp)(pRaw);
  if (pRow == NULL) return terrno;

  pRow->type = pRaw->type;

  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;

  switch (pRaw->status) {
    case SDB_STATUS_CREATING:
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_READY:
    case SDB_STATUS_UPDATE:
    case SDB_STATUS_DROPPING:
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_DROPPED:
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
      break;
  }

  return code;
}

int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
  sdbFreeRaw(pRaw);
  return code;
}

void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
  terrno = 0;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  void   *pRet = NULL;
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
  if (ppRow == NULL || *ppRow == NULL) {
    sdbUnLock(pSdb, type);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return NULL;
  }

  SSdbRow *pRow = *ppRow;
  switch (pRow->status) {
    case SDB_STATUS_READY:
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
      break;
    case SDB_STATUS_CREATING:
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
      break;
    case SDB_STATUS_DROPPING:
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
      break;
    default:
      terrno = TSDB_CODE_APP_ERROR;
      break;
  }

  if (pRet == NULL) {
    if (!onlyReady) {
      terrno = 0;
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
    }
  }

  sdbUnLock(pSdb, type);
  return pRet;
}

void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
  return sdbAcquireAll(pSdb, type, pKey, false);
}

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "check");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  sdbUnLock(pSdb, type);
}

void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
  if (pObj == NULL) return;

  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
  if (pRow->type >= SDB_MAX) return;

  int32_t type = pRow->type;
  if (lock) {
    sdbWriteLock(pSdb, type);
  }

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "release");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }
  if (ref < 0) {
    mError("row:%p, ref:%d, type:%s", pRow, ref, sdbTableName(type));
  }

  if (lock) {
    sdbUnLock(pSdb, type);
  }
}

void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }

void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void) atomic_add_fetch_32(&pRow->refCount, 1);

    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    break;
  }
  sdbUnLock(pSdb, type);

  return ppRow;
}

void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  if (lock) {
    sdbReadLock(pSdb, type);
  }

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    *status = pRow->status;
    break;
  }
  if (lock) {
    sdbUnLock(pSdb, type);
  }

  return ppRow;
}

void sdbCancelFetch(SSdb *pSdb, void *pIter) {
  if (pIter == NULL) return;
  SSdbRow *pRow = *(SSdbRow **)pIter;
  mTrace("cancel fetch row:%p", pRow);
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
  if (hash == NULL) return;

  int32_t type = pRow->type;
  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
  if (pIter == NULL) return;
  if (type >= SDB_MAX || type < 0) return;
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow->status == SDB_STATUS_READY) {
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
      if (!isContinue) {
        taosHashCancelIterate(hash, ppRow);
        break;
      }
    }

    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
}

int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return 0;

  sdbReadLock(pSdb, type);
  int32_t size = taosHashGetSize(hash);
  sdbUnLock(pSdb, type);

  return size;
}

int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return -1;

  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;

  int32_t maxId = 0;
  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    int32_t  id = *(int32_t *)pRow->pObj;
    maxId = TMAX(id, maxId);
    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
  maxId = TMAX(maxId, pSdb->maxId[type]);
  return maxId + 1;
}

int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return -1;
  }

  return pSdb->tableVer[type];
}

bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
  int32_t *pInt = p1;
  (*pInt) += 1;
  return true;
}

int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {
  int32_t num = 0;
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
  return num;
}


bool sdbCheckExists(SSdb *pSdb, ESdbType type, const void *pKey) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return false;
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);

  sdbReadLock(pSdb, type);
  void* p = taosHashGet(hash, pKey, keySize);
  sdbUnLock(pSdb, type);

  return (NULL != p);
}



1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "sdb.h"
18
19	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow);
20
21	const char *sdbTableName(ESdbType type) {	1,217,590✔
22	switch (type) {	1,217,590!
23	case SDB_TRANS:	193,100✔
24	return "trans";	193,100✔
25	case SDB_CLUSTER:	15,039✔
26	return "cluster";	15,039✔
27	case SDB_MNODE:	16,658✔
28	return "mnode";	16,658✔
29	case SDB_QNODE:	11,288✔
30	return "qnode";	11,288✔
31	case SDB_SNODE:	12,081✔
32	return "snode";	12,081✔
33	case SDB_DNODE:	34,582✔
34	return "dnode";	34,582✔
35	case SDB_USER:	23,195✔
36	return "user";	23,195✔
UNCOV 37	case SDB_AUTH:	×
UNCOV 38	return "auth";	×
39	case SDB_ACCT:	14,488✔
40	return "acct";	14,488✔
UNCOV 41	case SDB_STREAM_CK:	×
UNCOV 42	return "stream_ck";	×
43	case SDB_STREAM:	8,718✔
44	return "stream";	8,718✔
UNCOV 45	case SDB_OFFSET:	×
UNCOV 46	return "offset";	×
47	case SDB_SUBSCRIBE:	10,886✔
48	return "subscribe";	10,886✔
49	case SDB_CONSUMER:	13,494✔
50	return "consumer";	13,494✔
51	case SDB_TOPIC:	10,010✔
52	return "topic";	10,010✔
53	case SDB_VGROUP:	96,969✔
54	return "vgroup";	96,969✔
55	case SDB_SMA:	7,911✔
56	return "sma";	7,911✔
57	case SDB_STB:	125,754✔
58	return "stb";	125,754✔
59	case SDB_DB:	54,247✔
60	return "db";	54,247✔
61	case SDB_FUNC:	8,351✔
62	return "func";	8,351✔
63	case SDB_IDX:	43,705✔
64	return "idx";	43,705✔
65	case SDB_VIEW:	10,587✔
66	return "view";	10,587✔
UNCOV 67	case SDB_STREAM_SEQ:	×
UNCOV 68	return "stream_seq";	×
69	case SDB_COMPACT:	8,241✔
70	return "compact";	8,241✔
71	case SDB_COMPACT_DETAIL:	8,982✔
72	return "compact_detail";	8,982✔
73	case SDB_GRANT:	17,123✔
74	return "grant";	17,123✔
75	case SDB_ARBGROUP:	8,056✔
76	return "arb_group";	8,056✔
77	case SDB_ANODE:	7,911✔
78	return "anode";	7,911✔
79	case SDB_BNODE:	8,987✔
80	return "bnode";	8,987✔
81	case SDB_CFG:	423,448✔
82	return "config";	423,448✔
83	case SDB_MOUNT:	7,937✔
84	return "mount";	7,937✔
85	default:	15,842✔
86	return "undefine";	15,842✔
87	}
88	}
89
90	const char *sdbStatusName(ESdbStatus status) {	507,317✔
91	switch (status) {	507,317!
92	case SDB_STATUS_CREATING:	28,250✔
93	return "creating";	28,250✔
94	case SDB_STATUS_DROPPING:	6,455✔
95	return "dropping";	6,455✔
96	case SDB_STATUS_READY:	428,961✔
97	return "ready";	428,961✔
98	case SDB_STATUS_DROPPED:	42,453✔
99	return "dropped";	42,453✔
100	case SDB_STATUS_INIT:	1,196✔
101	return "init";	1,196✔
102	case SDB_STATUS_UPDATE:	×
103	return "update";	×
104	default:	2✔
105	return "undefine";	2✔
106	}
107	}
108
109	void sdbPrintOper(SSdb pSdb, SSdbRow pRow, const char *oper) {	9,316,024✔
110	#if 1
111	EKeyType keyType = pSdb->keyTypes[pRow->type];	9,316,024✔
112
113	if (keyType == SDB_KEY_BINARY) {	9,316,024✔
114	mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,	3,197,895✔
115	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
116	} else if (keyType == SDB_KEY_INT32) {	6,118,129✔
117	mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (int32_t )pRow->pObj,	5,845,240✔
118	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
119	} else if (keyType == SDB_KEY_INT64) {	272,889!
120	mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),	273,291✔
121	(int64_t )pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
122	} else {
123	}
124	#endif
125	}	9,316,024✔
126
127	static SHashObj sdbGetHash(SSdb pSdb, int32_t type) {	6,403,496✔
128	if (type >= SDB_MAX \|\| type < 0) {	6,403,496!
129	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	×
130	return NULL;	3✔
131	}
132
133	SHashObj *hash = pSdb->hashObjs[type];	6,403,522✔
134	if (hash == NULL) {	6,403,522✔
135	terrno = TSDB_CODE_APP_ERROR;	3✔
136	return NULL;	3✔
137	}
138
139	return hash;	6,403,519✔
140	}
141
142	static int32_t sdbGetkeySize(SSdb pSdb, ESdbType type, const void pKey) {	2,703,857✔
143	int32_t keySize = 0;	2,703,857✔
144	EKeyType keyType = pSdb->keyTypes[type];	2,703,857✔
145
146	if (keyType == SDB_KEY_INT32) {	2,703,857✔
147	keySize = sizeof(int32_t);	1,657,793✔
148	} else if (keyType == SDB_KEY_BINARY) {	1,046,064✔
149	keySize = strlen(pKey) + 1;	1,026,540✔
150	} else {
151	keySize = sizeof(int64_t);	19,524✔
152	}
153
154	return keySize;	2,703,857✔
155	}
156
157	static int32_t sdbInsertRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	273,304✔
158	int32_t type = pRow->type;	273,304✔
159	sdbWriteLock(pSdb, type);	273,304✔
160
161	SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);	273,304✔
162	if (pOldRow != NULL) {	273,304!
163	sdbUnLock(pSdb, type);	×
164	sdbFreeRow(pSdb, pRow, false);	×
165	terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;	×
166	return terrno;	×
167	}
168
169	pRow->refCount = 0;	273,304✔
170	pRow->status = pRaw->status;	273,304✔
171	sdbPrintOper(pSdb, pRow, "insert");	273,304✔
172
173	int32_t code = 0;	273,304✔
174	if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {	273,304!
175	sdbUnLock(pSdb, type);	×
176	sdbFreeRow(pSdb, pRow, false);	×
177	return code;	×
178	}
179
180	SdbInsertFp insertFp = pSdb->insertFps[pRow->type];	273,304✔
181	if (insertFp != NULL) {	273,304!
182	code = (*insertFp)(pSdb, pRow->pObj);	273,304✔
183	if (code != 0) {	273,304!
184	if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {	×
185	mError("failed to remove row from hash");	×
186	}
187	sdbFreeRow(pSdb, pRow, false);	×
188	sdbUnLock(pSdb, type);	×
189	terrno = code;	×
190	return terrno;	×
191	}
192	}
193
194	sdbUnLock(pSdb, type);	273,304✔
195
196	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {	273,304✔
197	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int32_t )pRow->pObj));	74,410✔
198	}
199	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {	273,304✔
200	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int64_t )pRow->pObj));	2,533✔
201	}
202	pSdb->tableVer[pRow->type]++;	273,304✔
203
204	return 0;	273,304✔
205	}
206
207	static int32_t sdbUpdateRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pNewRow, int32_t keySize) {	383,077✔
208	int32_t type = pNewRow->type;	383,077✔
209	sdbWriteLock(pSdb, type);	383,077✔
210
211	SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);	383,077✔
212	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	383,077!
213	sdbUnLock(pSdb, type);	258,809✔
214	return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);	258,809✔
215	}
216
217	SSdbRow pOldRow = ppOldRow;	124,268✔
218	pOldRow->status = pRaw->status;	124,268✔
219	sdbPrintOper(pSdb, pOldRow, "update");	124,268✔
220
221	int32_t code = 0;	124,268✔
222	SdbUpdateFp updateFp = pSdb->updateFps[type];	124,268✔
223	if (updateFp != NULL) {	124,268!
224	code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);	124,268✔
225	}
226	sdbUnLock(pSdb, type);	124,268✔
227
228	// sdbUnLock(pSdb, type);
229	sdbFreeRow(pSdb, pNewRow, false);	124,268✔
230
231	pSdb->tableVer[pOldRow->type]++;	124,268✔
232	return code;	124,268✔
233	}
234
235	static int32_t sdbDeleteRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	69,903✔
236	int32_t type = pRow->type;	69,903✔
237	sdbWriteLock(pSdb, type);	69,903✔
238
239	SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);	69,903✔
240	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	69,903!
241	sdbUnLock(pSdb, type);	31✔
242	sdbFreeRow(pSdb, pRow, false);	31✔
243	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	31✔
244	return terrno;	31✔
245	}
246	SSdbRow pOldRow = ppOldRow;	69,872✔
247	pOldRow->status = pRaw->status;	69,872✔
248
249	(void)atomic_add_fetch_32(&pOldRow->refCount, 1);	69,872✔
250	sdbPrintOper(pSdb, pOldRow, "delete");	69,872✔
251
252	if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {	69,872!
253	sdbUnLock(pSdb, type);	×
254	sdbFreeRow(pSdb, pRow, false);	×
255	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	×
256	return terrno;	×
257	}
258	pSdb->tableVer[pOldRow->type]++;	69,872✔
259	sdbUnLock(pSdb, type);	69,872✔
260
261	sdbFreeRow(pSdb, pRow, false);	69,872✔
262
263	sdbCheckRow(pSdb, pOldRow);	69,872✔
264	return 0;	69,872✔
265	}
266
267	int32_t sdbWriteWithoutFree(SSdb pSdb, SSdbRaw pRaw) {	467,481✔
268	if (pRaw->type == SDB_CFG) {	467,481✔
269	mTrace("sdb write cfg");	162,019✔
270	}
271	SHashObj *hash = sdbGetHash(pSdb, pRaw->type);	467,481✔
272	if (hash == NULL) return terrno;	467,481✔
273
274	SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];	467,475✔
275	SSdbRow pRow = (decodeFp)(pRaw);	467,475✔
276	if (pRow == NULL) return terrno;	467,475!
277
278	pRow->type = pRaw->type;	467,475✔
279
280	int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);	467,475✔
281	int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;	467,475✔
282
283	switch (pRaw->status) {	467,475!
284	case SDB_STATUS_CREATING:	14,495✔
285	code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);	14,495✔
286	break;	14,495✔
287	case SDB_STATUS_READY:	383,077✔
288	case SDB_STATUS_UPDATE:
289	case SDB_STATUS_DROPPING:
290	code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);	383,077✔
291	break;	383,077✔
292	case SDB_STATUS_DROPPED:	69,903✔
293	code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);	69,903✔
294	break;	69,903✔
295	}
296
297	return code;	467,475✔
298	}
299
300	int32_t sdbWrite(SSdb pSdb, SSdbRaw pRaw) {	56,717✔
301	int32_t code = sdbWriteWithoutFree(pSdb, pRaw);	56,717✔
302	sdbFreeRaw(pRaw);	56,717✔
303	return code;	56,717✔
304	}
305
306	void sdbAcquireAll(SSdb pSdb, ESdbType type, const void *pKey, bool onlyReady) {	2,235,899✔
307	terrno = 0;	2,235,899✔
308
309	SHashObj *hash = sdbGetHash(pSdb, type);	2,235,894✔
310	if (hash == NULL) return NULL;	2,235,893!
311
312	void *pRet = NULL;	2,235,893✔
313	int32_t keySize = sdbGetkeySize(pSdb, type, pKey);	2,235,893✔
314
315	sdbReadLock(pSdb, type);	2,235,891✔
316
317	SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);	2,235,909✔
318	if (ppRow == NULL \|\| *ppRow == NULL) {	2,235,911✔
319	sdbUnLock(pSdb, type);	391,661✔
320	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	391,659✔
321	return NULL;	391,659✔
322	}
323
324	SSdbRow pRow = ppRow;	1,844,250✔
325	switch (pRow->status) {	1,844,250!
326	case SDB_STATUS_READY:	1,838,004✔
327	(void)atomic_add_fetch_32(&pRow->refCount, 1);	1,838,004✔
328	pRet = pRow->pObj;	1,838,017✔
329	sdbPrintOper(pSdb, pRow, "acquire");	1,838,017✔
330	break;	1,838,015✔
331	case SDB_STATUS_CREATING:	5,736✔
332	terrno = TSDB_CODE_SDB_OBJ_CREATING;	5,736✔
333	break;	5,736✔
334	case SDB_STATUS_DROPPING:	512✔
335	terrno = TSDB_CODE_SDB_OBJ_DROPPING;	512✔
336	break;	512✔
UNCOV 337	default:	×
UNCOV 338	terrno = TSDB_CODE_APP_ERROR;	×
339	break;	×
340	}
341
342	if (pRet == NULL) {	1,844,263✔
343	if (!onlyReady) {	6,248!
344	terrno = 0;	×
345	(void)atomic_add_fetch_32(&pRow->refCount, 1);	×
346	pRet = pRow->pObj;	×
347	sdbPrintOper(pSdb, pRow, "acquire");	×
348	}
349	}
350
351	sdbUnLock(pSdb, type);	1,844,263✔
352	return pRet;	1,844,261✔
353	}
354
355	void sdbAcquire(SSdb pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }	2,233,376✔
356	void sdbAcquireNotReadyObj(SSdb pSdb, ESdbType type, const void *pKey) {	2,523✔
357	return sdbAcquireAll(pSdb, type, pKey, false);	2,523✔
358	}
359
360	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow) {	69,872✔
361	int32_t type = pRow->type;	69,872✔
362	sdbWriteLock(pSdb, type);	69,872✔
363
364	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	69,872✔
365	sdbPrintOper(pSdb, pRow, "check");	69,872✔
366	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	69,872!
367	sdbFreeRow(pSdb, pRow, true);	12,305✔
368	}
369
370	sdbUnLock(pSdb, type);	69,872✔
371	}	69,872✔
372
373	void sdbReleaseLock(SSdb pSdb, void pObj, bool lock) {	4,021,550✔
374	if (pObj == NULL) return;	4,021,550✔
375
376	SSdbRow pRow = (SSdbRow )((char *)pObj - sizeof(SSdbRow));	3,973,463✔
377	if (pRow->type >= SDB_MAX) return;	3,973,463!
378
379	int32_t type = pRow->type;	3,973,463✔
380	if (lock) {	3,973,463✔
381	sdbWriteLock(pSdb, type);	3,969,575✔
382	}
383
384	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	3,973,622✔
385	sdbPrintOper(pSdb, pRow, "release");	3,973,734✔
386	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	3,973,716✔
387	sdbFreeRow(pSdb, pRow, true);	57,567✔
388	}
389	if (ref < 0) {	3,973,716✔
390	mError("row:%p, ref:%d, type:%s", pRow, ref, sdbTableName(type));	2,363!
391	}
392
393	if (lock) {	3,973,707✔
394	sdbUnLock(pSdb, type);	3,969,758✔
395	}
396	}
397
398	void sdbRelease(SSdb pSdb, void pObj) { sdbReleaseLock(pSdb, pObj, true); }	4,017,582✔
399
400	void sdbFetch(SSdb pSdb, ESdbType type, void pIter, void *ppObj) {	2,417,925✔
401	*ppObj = NULL;	2,417,925✔
402
403	SHashObj *hash = sdbGetHash(pSdb, type);	2,417,925✔
404	if (hash == NULL) return NULL;	2,417,840!
405
406	sdbReadLock(pSdb, type);	2,417,840✔
407
408	SSdbRow **ppRow = taosHashIterate(hash, pIter);	2,418,072✔
409	while (ppRow != NULL) {	2,432,060✔
410	SSdbRow pRow = ppRow;	1,850,835✔
411	if (pRow == NULL \|\| pRow->status != SDB_STATUS_READY) {	1,850,835!
412	ppRow = taosHashIterate(hash, ppRow);	13,973✔
413	continue;	13,971✔
414	}
415
416	(void) atomic_add_fetch_32(&pRow->refCount, 1);	1,836,862✔
417
418	sdbPrintOper(pSdb, pRow, "fetch");	1,836,862✔
419	*ppObj = pRow->pObj;	1,836,834✔
420	break;	1,836,834✔
421	}
422	sdbUnLock(pSdb, type);	2,418,059✔
423
424	return ppRow;	2,418,176✔
425	}
426
427	void sdbFetchAll(SSdb pSdb, ESdbType type, void pIter, void ppObj, ESdbStatus status, bool lock) {	375,840✔
428	*ppObj = NULL;	375,840✔
429
430	SHashObj *hash = sdbGetHash(pSdb, type);	375,840✔
431	if (hash == NULL) return NULL;	375,840!
432
433	if (lock) {	375,840✔
434	sdbReadLock(pSdb, type);	369,150✔
435	}
436
437	SSdbRow **ppRow = taosHashIterate(hash, pIter);	375,840✔
438	while (ppRow != NULL) {	375,840✔
439	SSdbRow pRow = ppRow;	298,871✔
440	if (pRow == NULL) {	298,871!
441	ppRow = taosHashIterate(hash, ppRow);	×
442	continue;	×
443	}
444
445	(void)atomic_add_fetch_32(&pRow->refCount, 1);	298,871✔
446	sdbPrintOper(pSdb, pRow, "fetch");	298,871✔
447	*ppObj = pRow->pObj;	298,871✔
448	*status = pRow->status;	298,871✔
449	break;	298,871✔
450	}
451	if (lock) {	375,840✔
452	sdbUnLock(pSdb, type);	369,150✔
453	}
454
455	return ppRow;	375,840✔
456	}
457
458	void sdbCancelFetch(SSdb pSdb, void pIter) {	275,327✔
459	if (pIter == NULL) return;	275,327✔
460	SSdbRow pRow = (SSdbRow **)pIter;	274,467✔
461	mTrace("cancel fetch row:%p", pRow);	274,467✔
462	SHashObj *hash = sdbGetHash(pSdb, pRow->type);	274,467✔
463	if (hash == NULL) return;	274,467!
464
465	int32_t type = pRow->type;	274,467✔
466	sdbReadLock(pSdb, type);	274,467✔
467	taosHashCancelIterate(hash, pIter);	274,467✔
468	sdbUnLock(pSdb, type);	274,467✔
469	}
470
471	void sdbCancelFetchByType(SSdb pSdb, void pIter, ESdbType type) {	1✔
472	if (pIter == NULL) return;	1!
473	if (type >= SDB_MAX \|\| type < 0) return;	1!
474	SHashObj *hash = sdbGetHash(pSdb, type);	1✔
475	if (hash == NULL) return;	1!
476
477	sdbReadLock(pSdb, type);	1✔
478	taosHashCancelIterate(hash, pIter);	1✔
479	sdbUnLock(pSdb, type);	1✔
480	}
481
482	void sdbTraverse(SSdb pSdb, ESdbType type, sdbTraverseFp fp, void p1, void p2, void p3) {	28,848✔
483	SHashObj *hash = sdbGetHash(pSdb, type);	28,848✔
484	if (hash == NULL) return;	28,848!
485
486	sdbReadLock(pSdb, type);	28,848✔
487
488	SSdbRow **ppRow = taosHashIterate(hash, NULL);	28,848✔
489	while (ppRow != NULL) {	92,106✔
490	SSdbRow pRow = ppRow;	63,285✔
491	if (pRow->status == SDB_STATUS_READY) {	63,285✔
492	bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);	56,457✔
493	if (!isContinue) {	56,457✔
494	taosHashCancelIterate(hash, ppRow);	27✔
495	break;	27✔
496	}
497	}
498
499	ppRow = taosHashIterate(hash, ppRow);	63,258✔
500	}
501
502	sdbUnLock(pSdb, type);	28,848✔
503	}
504
505	int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {	543,127✔
506	SHashObj *hash = sdbGetHash(pSdb, type);	543,127✔
507	if (hash == NULL) return 0;	543,128!
508
509	sdbReadLock(pSdb, type);	543,128✔
510	int32_t size = taosHashGetSize(hash);	543,128✔
511	sdbUnLock(pSdb, type);	543,128✔
512
513	return size;	543,129✔
514	}
515
516	int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {	60,461✔
517	SHashObj *hash = sdbGetHash(pSdb, type);	60,461✔
518	if (hash == NULL) return -1;	60,461!
519
520	if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;	60,461✔
521
522	int32_t maxId = 0;	60,443✔
523	sdbReadLock(pSdb, type);	60,443✔
524
525	SSdbRow **ppRow = taosHashIterate(hash, NULL);	60,443✔
526	while (ppRow != NULL) {	101,332✔
527	SSdbRow pRow = ppRow;	40,889✔
528	int32_t id = (int32_t )pRow->pObj;	40,889✔
529	maxId = TMAX(id, maxId);	40,889✔
530	ppRow = taosHashIterate(hash, ppRow);	40,889✔
531	}
532
533	sdbUnLock(pSdb, type);	60,443✔
534	maxId = TMAX(maxId, pSdb->maxId[type]);	60,443✔
535	return maxId + 1;	60,443✔
536	}
537
538	int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {	308,740✔
539	if (type >= SDB_MAX \|\| type < 0) {	308,740✔
540	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	3✔
541	return -1;	3✔
542	}
543
544	return pSdb->tableVer[type];	308,737✔
545	}
546
547	bool countValid(SMnode pMnode, void pObj, void p1, void p2, void *p3) {	×
548	int32_t *pInt = p1;	×
549	(*pInt) += 1;	×
550	return true;	×
551	}
552
553	int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {	×
554	int32_t num = 0;	×
555	sdbTraverse(pSdb, type, countValid, &num, 0, 0);	×
556	return num;	×
557	}
558
559
560	bool sdbCheckExists(SSdb pSdb, ESdbType type, const void pKey) {	490✔
561	SHashObj *hash = sdbGetHash(pSdb, type);	490✔
562	if (hash == NULL) return false;	490!
563	int32_t keySize = sdbGetkeySize(pSdb, type, pKey);	490✔
564
565	sdbReadLock(pSdb, type);	490✔
566	void* p = taosHashGet(hash, pKey, keySize);	490✔
567	sdbUnLock(pSdb, type);	490✔
568
569	return (NULL != p);	490✔
570	}
571
572

taosdata / TDengine / #4693

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous