pulibrary / tigerdata-app / 6a411f67-4d90-4835-b588-71c43f14ed4a

coverage: 73.704% (-14.4%) from 88.118%
6a411f67-4d90-4835-b588-71c43f14ed4a

Pull #1801

circleci

JaymeeH 
test parallelism with 3 executors
Pull Request #1801: 1586 request mailer

10 of 10 new or added lines in 2 files covered. (100.0%)

423 existing lines in 40 files now uncovered.

2133 of 2894 relevant lines covered (73.7%)

104.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

42.86
/app/controllers/users_controller.rb
1 
# frozen_string_literal: true
2 
class UsersController < ApplicationController
1✔
3 
  before_action :set_breadcrumbs
1✔
4 
  before_action :check_user_access
1✔
5 









6



  def index




1✔






UNCOV

7



    @users = User.order("uid ASC NULLS LAST").page params[:page]




×







8



  end










9












10



  def show




1✔






UNCOV

11



    add_breadcrumb("User")




×








UNCOV

12



    @user = User.find(params[:id])




×







13



  end










14












15



  def edit




1✔






UNCOV

16



    add_breadcrumb("Edit User")




×








UNCOV

17



    @user = User.find(params[:id])




×







18



  end










19












20



  def update




1✔






UNCOV

21



    update_user_with_params




×








UNCOV

22



    redirect_to user_path(@user)




×







23



  rescue => ex










24



    short_message = "Error saving user #{params[:id]}"




×







25



    Rails.logger.error "#{short_message}: #{ex.message}"




×







26



    Honeybadger.notify "#{short_message}: #{ex.message}"




×







27



    flash[:alert] = short_message




×







28



    redirect_to user_path(id: params[:id])




×







29



  end










30












31



  def lookup




1✔





32



    query = (params["query"] || "").strip.downcase




5✔





33



    matches = PrincetonUsers.user_list_query(query)




5✔





34



    result = {










35



      suggestions: matches.take(20).map { |match| { "value": match[:name] || "", "data": match[:uid] } }




10✔





36



    }










37



    render json: result




5✔





38



  end










39












40



  private




1✔





41












42



    def set_breadcrumbs




1✔





43



      add_breadcrumb("Users", users_path)




5✔





44



    end










45












46



    def check_user_access




1✔





47



      return if current_user.superuser || current_user.sysadmin || current_user.trainer




5✔






UNCOV

48



      flash[:notice] = "You do not have access to this page (#{current_user.uid})"




×








UNCOV

49



      redirect_to dashboard_path




×







50



    end










51












52



    # rubocop:disable Metrics/AbcSize










53



    def update_user_with_params




1✔






UNCOV

54



      @user = User.find(params[:id])




×








UNCOV

55



      @user.given_name = params["user"]["given_name"]




×








UNCOV

56



      @user.family_name = params["user"]["family_name"]




×








UNCOV

57



      @user.display_name = params["user"]["display_name"]




×








UNCOV

58



      @user.eligible_sponsor = params["user"]["eligible_sponsor"] == "1"




×








UNCOV

59



      @user.eligible_manager = params["user"]["eligible_manager"] == "1"




×








UNCOV

60



      @user.superuser = params["user"]["superuser"] == "1"




×








UNCOV

61



      @user.sysadmin = params["user"]["sysadmin"] == "1"




×








UNCOV

62



      @user.trainer = params["user"]["trainer"] == "1"




×








UNCOV

63



      @user.save!




×







64



    end










65



  # rubocop:enable Metrics/AbcSize










66



end
























    

  • 

    •