WolferyScripting / WolferyJS / #16

Committed 29 Aug 2025 04:49PM UTC coverage: 59.799% (-0.03%) from 59.833%

Build # #16

Build Type

push

Committed by

Commit Message

Fix forcefully keeping BaseCollectionModel instances due to internal `change` listeners
WolferyScripting/resclient-ts@1786b91c7

Run Details

93 of 247 branches covered (37.65%)

Branch coverage included in aggregate %.

32 of 58 new or added lines in 15 files covered. (55.17%)

7 existing lines in 1 file now uncovered.

5027 of 8315 relevant lines covered (60.46%)

1.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.41

/lib/models/Notes.ts

import type Note from "./Note.js";
import BaseCollectionModel from "./BaseCollectionModel.js";
import type WolferyJS from "../WolferyJS.js";
import { type ResClient, ResRef } from "resclient-ts";

// do not edit the first line of the class comment
/**
 * All notes.
 * @resourceID {@link ResourceIDs.NOTES | NOTES}
 */
class Notes extends BaseCollectionModel<ResRef<Note>> {
    constructor(client: WolferyJS, api: ResClient, rid: string) {
        super(client, api, rid, item => item instanceof ResRef);
    }

    protected override async _listen(on: boolean): Promise<void> {
        await super._listen(on, this.client.anyTracked("notes"));
    }

    async fetchAll(): Promise<Array<Note>> {
        return Promise.all(this.list.map(ref => ref.get()));
    }

    async getAll(): Promise<Array<Note>> {
        return this.client.getAllPaginated<Note>(this.rid);
    }
}

export default Notes;

1	import type Note from "./Note.js";	1✔
2	import BaseCollectionModel from "./BaseCollectionModel.js";	1✔
3	import type WolferyJS from "../WolferyJS.js";	1✔
4	import { type ResClient, ResRef } from "resclient-ts";	1✔
5		1✔
6	// do not edit the first line of the class comment	1✔
7	/**	1✔
8	* All notes.	1✔
9	* @resourceID {@link ResourceIDs.NOTES \| NOTES}	1✔
10	*/	1✔
11	class Notes extends BaseCollectionModel<ResRef<Note>> {	1✔
12	constructor(client: WolferyJS, api: ResClient, rid: string) {	1✔
13	super(client, api, rid, item => item instanceof ResRef);	×
14	}	×
15		1✔
16	protected override async _listen(on: boolean): Promise<void> {	1✔
NEW 17	await super._listen(on, this.client.anyTracked("notes"));	×
NEW 18	}	×
19		1✔
20	async fetchAll(): Promise<Array<Note>> {	1✔
21	return Promise.all(this.list.map(ref => ref.get()));	×
22	}	×
23		1✔
24	async getAll(): Promise<Array<Note>> {	1✔
25	return this.client.getAllPaginated<Note>(this.rid);	×
26	}	×
27	}	1✔
28		1✔
29	export default Notes;	1✔

WolferyScripting / WolferyJS / #16

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous