Qiskit / qiskit / 17306652456

push

github

Add fast-path parameter binding (#14782)

* Add fast-path parameter binding

The new `ParameterExpresion.bind_all` is a fast path for producing a
numeric result.  This has a couple of advantages over
`ParameterExpression.bind`:

- we can allocate fewer objects, since we do not need to allocate output
  name names, or other deeper metadata involved in the
  `ParameterExpression` struct

- we have no historical API reasons to scan through the incoming mapping
  looking for invalid keys or values.  This is a huge performance
  improvement for the case of using the same mapping to bind many
  different expressions (though there are always ways that
  `ParameterExpression.bind` could be improved in-place without breaking
  its API).

There is still a sizeable amount of performance gain to be had, because
the interfaces in the Rust-space `ParameterExpression` and `SymbolExpr`
require rather more heap allocations per binding call than are entirely
necessary.  That said, this already provides a large performance
improvement, and a complexity improvement for the case of a large values
dictionary being used many times.

* Remove unnecessary lifetime

* Add comment on non-finite values

14 of 17 new or added lines in 1 file covered. (82.35%)

91011 of 102905 relevant lines covered (88.44%)

482630.27 hits per line