• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4688

26 Aug 2025 02:05PM UTC coverage: 56.997% (-0.9%) from 57.894%
#4688

push

travis-ci

web-flow
fix: modify the prompt language of the taos-shell (#32758)

* fix: modify prompt language

* fix: add shell test case

* fix: modify comments

* fix: modify test case for TDengine TSDB

130660 of 292423 branches covered (44.68%)

Branch coverage included in aggregate %.

16 of 17 new or added lines in 2 files covered. (94.12%)

9459 existing lines in 157 files now uncovered.

198294 of 284715 relevant lines covered (69.65%)

4532552.29 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.72
/source/dnode/mnode/impl/src/mndBnode.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndBnode.h"
18
#include "mndDnode.h"
19
#include "mndPrivilege.h"
20
#include "mndShow.h"
21
#include "mndTrans.h"
22
#include "mndUser.h"
23

24
#define BNODE_VER_NUMBER   1
25
#define BNODE_RESERVE_SIZE 64
26

27
static SSdbRaw *mndBnodeActionEncode(SBnodeObj *pObj) {
424✔
28
  int32_t code = 0;
424✔
29
  int32_t lino = 0;
424✔
30

31
  terrno = TSDB_CODE_OUT_OF_MEMORY;
424✔
32

33
  SSdbRaw *pRaw = sdbAllocRaw(SDB_BNODE, BNODE_VER_NUMBER, sizeof(SBnodeObj) + BNODE_RESERVE_SIZE);
424✔
34
  if (pRaw == NULL) goto _OVER;
424!
35

36
  int32_t dataPos = 0;
424✔
37
  SDB_SET_INT32(pRaw, dataPos, pObj->id, _OVER)
424!
38
  SDB_SET_INT32(pRaw, dataPos, pObj->proto, _OVER)
424!
39
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
424!
40
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
424!
41
  SDB_SET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
424!
42

43
  terrno = 0;
424✔
44

45
_OVER:
424✔
46
  if (terrno != 0) {
424!
47
    mError("bnode:%d, failed to encode to raw:%p since %s", pObj->id, pRaw, terrstr());
×
48
    sdbFreeRaw(pRaw);
×
49
    return NULL;
×
50
  }
51

52
  mTrace("bnode:%d, encode to raw:%p, row:%p", pObj->id, pRaw, pObj);
424!
53
  return pRaw;
424✔
54
}
55

56
static SSdbRow *mndBnodeActionDecode(SSdbRaw *pRaw) {
333✔
57
  int32_t    code = 0;
333✔
58
  int32_t    lino = 0;
333✔
59
  SSdbRow   *pRow = NULL;
333✔
60
  SBnodeObj *pObj = NULL;
333✔
61
  int8_t     sver = 0;
333✔
62

63
  terrno = TSDB_CODE_OUT_OF_MEMORY;
333✔
64

65
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
333!
66

67
  if (sver != BNODE_VER_NUMBER) {
333!
68
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
69
    goto _OVER;
×
70
  }
71

72
  pRow = sdbAllocRow(sizeof(SBnodeObj));
333✔
73
  if (pRow == NULL) goto _OVER;
333!
74

75
  pObj = sdbGetRowObj(pRow);
333✔
76
  if (pObj == NULL) goto _OVER;
333!
77

78
  int32_t dataPos = 0;
333✔
79
  SDB_GET_INT32(pRaw, dataPos, &pObj->id, _OVER)
333!
80
  SDB_GET_INT32(pRaw, dataPos, &pObj->proto, _OVER)
333!
81
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
333!
82
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
333!
83
  SDB_GET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
333!
84

85
  terrno = 0;
333✔
86

87
_OVER:
333✔
88
  if (terrno != 0) {
333!
89
    mError("bnode:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->id, pRaw, terrstr());
×
90
    taosMemoryFreeClear(pRow);
×
91
    return NULL;
×
92
  }
93

94
  mTrace("bnode:%d, decode from raw:%p, row:%p", pObj->id, pRaw, pObj);
333!
95
  return pRow;
333✔
96
}
97

98
static int32_t mndBnodeActionInsert(SSdb *pSdb, SBnodeObj *pObj) {
86✔
99
  mTrace("bnode:%d, perform insert action, row:%p", pObj->id, pObj);
86!
100
  pObj->pDnode = sdbAcquire(pSdb, SDB_DNODE, &pObj->id);
86✔
101
  if (pObj->pDnode == NULL) {
86!
102
    terrno = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
103
    mError("bnode:%d, failed to perform insert action since %s", pObj->id, terrstr());
×
104
    return -1;
×
105
  }
106

107
  return 0;
86✔
108
}
109

110
static int32_t mndBnodeActionDelete(SSdb *pSdb, SBnodeObj *pObj) {
333✔
111
  mTrace("bnode:%d, perform delete action, row:%p", pObj->id, pObj);
333!
112
  if (pObj->pDnode != NULL) {
333✔
113
    sdbRelease(pSdb, pObj->pDnode);
86✔
114
    pObj->pDnode = NULL;
86✔
115
  }
116

117
  return 0;
333✔
118
}
119

120
static int32_t mndBnodeActionUpdate(SSdb *pSdb, SBnodeObj *pOld, SBnodeObj *pNew) {
165✔
121
  mTrace("bnode:%d, perform update action, old row:%p new row:%p", pOld->id, pOld, pNew);
165!
122
  pOld->updateTime = pNew->updateTime;
165✔
123
  return 0;
165✔
124
}
125

126
static int32_t mndSetCreateBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
83✔
127
  int32_t  code = 0;
83✔
128
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
83✔
129
  if (pRedoRaw == NULL) {
83!
130
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
131
    if (terrno != 0) code = terrno;
×
132
    TAOS_RETURN(code);
×
133
  }
134
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
83!
135
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
83!
136
  TAOS_RETURN(code);
83✔
137
}
138

139
static int32_t mndSetCreateBnodeUndoLogs(STrans *pTrans, SBnodeObj *pObj) {
83✔
140
  int32_t  code = 0;
83✔
141
  SSdbRaw *pUndoRaw = mndBnodeActionEncode(pObj);
83✔
142
  if (pUndoRaw == NULL) {
83!
143
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
144
    if (terrno != 0) code = terrno;
×
145
    TAOS_RETURN(code);
×
146
  }
147
  TAOS_CHECK_RETURN(mndTransAppendUndolog(pTrans, pUndoRaw));
83!
148
  TAOS_CHECK_RETURN(sdbSetRawStatus(pUndoRaw, SDB_STATUS_DROPPED));
83!
149
  TAOS_RETURN(code);
83✔
150
}
151

152
static int32_t mndSetCreateBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
83✔
153
  int32_t  code = 0;
83✔
154
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
83✔
155
  if (pCommitRaw == NULL) {
83!
156
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
157
    if (terrno != 0) code = terrno;
×
158
    TAOS_RETURN(code);
×
159
  }
160
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
83!
161
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
83!
162
  TAOS_RETURN(code);
83✔
163
}
164

165
static int32_t mndSetCreateBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
83✔
166
  int32_t          code = 0;
83✔
167
  SDCreateBnodeReq createReq = {0};
83✔
168
  createReq.dnodeId = pDnode->id;
83✔
169
  createReq.bnodeProto = pObj->proto;
83✔
170

171
  int32_t contLen = tSerializeSMCreateBnodeReq(NULL, 0, &createReq);
83✔
172
  void   *pReq = taosMemoryMalloc(contLen);
83!
173
  if (pReq == NULL) {
83!
174
    code = terrno;
×
175
    TAOS_RETURN(code);
×
176
  }
177
  code = tSerializeSMCreateBnodeReq(pReq, contLen, &createReq);
83✔
178
  if (code < 0) {
83!
179
    mError("bnode:%d, failed to serialize create drop bnode request since %s", createReq.dnodeId, terrstr());
×
180

181
    taosMemoryFree(pReq);
×
182
    TAOS_RETURN(code);
×
183
  }
184

185
  STransAction action = {0};
83✔
186
  action.epSet = mndGetDnodeEpset(pDnode);
83✔
187
  action.pCont = pReq;
83✔
188
  action.contLen = contLen;
83✔
189
  action.msgType = TDMT_DND_CREATE_BNODE;
83✔
190
  action.acceptableCode = TSDB_CODE_BNODE_ALREADY_DEPLOYED;
83✔
191

192
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
83!
193
    taosMemoryFree(pReq);
×
194
    TAOS_RETURN(code);
×
195
  }
196

197
  TAOS_RETURN(code);
83✔
198
}
199

200
static int32_t mndSetCreateBnodeUndoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
83✔
201
  int32_t        code = 0;
83✔
202
  SDDropBnodeReq dropReq = {0};
83✔
203
  dropReq.dnodeId = pDnode->id;
83✔
204

205
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
83✔
206
  void   *pReq = taosMemoryMalloc(contLen);
83!
207
  if (pReq == NULL) {
83!
208
    code = terrno;
×
209
    TAOS_RETURN(code);
×
210
  }
211
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
83✔
212
  if (code < 0) {
83!
213
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
214
  }
215

216
  STransAction action = {0};
83✔
217
  action.epSet = mndGetDnodeEpset(pDnode);
83✔
218
  action.pCont = pReq;
83✔
219
  action.contLen = contLen;
83✔
220
  action.msgType = TDMT_DND_DROP_BNODE;
83✔
221
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
83✔
222

223
  if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
83!
224
    taosMemoryFree(pReq);
×
225
    TAOS_RETURN(code);
×
226
  }
227

228
  TAOS_RETURN(code);
83✔
229
}
230

231
static int32_t mndCreateBnode(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateBnodeReq *pCreate) {
83✔
232
  int32_t code = -1;
83✔
233

234
  SBnodeObj bnodeObj = {0};
83✔
235
  bnodeObj.id = pDnode->id;
83✔
236
  bnodeObj.proto = pCreate->bnodeProto;
83✔
237
  bnodeObj.createdTime = taosGetTimestampMs();
83✔
238
  bnodeObj.updateTime = bnodeObj.createdTime;
83✔
239

240
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_NOTHING, pReq, "create-bnode");
83✔
241
  if (pTrans == NULL) {
83!
242
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
243
    if (terrno != 0) code = terrno;
×
244
    goto _OVER;
×
245
  }
246
  mndTransSetSerial(pTrans);
83✔
247

248
  mInfo("trans:%d, to create bnode:%d %d", pTrans->id, pCreate->dnodeId, pCreate->bnodeProto);
83!
249

250
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoLogs(pTrans, &bnodeObj), NULL, _OVER);
83!
251
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoLogs(pTrans, &bnodeObj), NULL, _OVER);
83!
252
  TAOS_CHECK_GOTO(mndSetCreateBnodeCommitLogs(pTrans, &bnodeObj), NULL, _OVER);
83!
253
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
83!
254
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
83!
255
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
83!
256

257
  code = 0;
83✔
258

259
_OVER:
83✔
260
  mndTransDrop(pTrans);
83✔
261
  TAOS_RETURN(code);
83✔
262
}
263

264
static int32_t mndProcessCreateBnodeReq(SRpcMsg *pReq) {
92✔
265
  SMnode          *pMnode = pReq->info.node;
92✔
266
  int32_t          code = -1;
92✔
267
  SBnodeObj       *pObj = NULL;
92✔
268
  SDnodeObj       *pDnode = NULL;
92✔
269
  SMCreateBnodeReq createReq = {0};
92✔
270

271
  #ifdef LINUX
272

273
  TAOS_CHECK_GOTO(tDeserializeSMCreateBnodeReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
92!
274

275
  mInfo("bnode:%d, start to create", createReq.dnodeId);
92!
276
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CREATE_BNODE), NULL, _OVER);
92!
277

278
  pObj = mndAcquireBnode(pMnode, createReq.dnodeId);
92✔
279
  if (pObj != NULL) {
92!
UNCOV
280
    code = terrno = TSDB_CODE_MND_BNODE_ALREADY_EXIST;
×
281
    goto _OVER;
×
282
  } else if (terrno != TSDB_CODE_MND_BNODE_NOT_EXIST) {
92!
UNCOV
283
    code = terrno;
×
UNCOV
284
    goto _OVER;
×
285
  }
286

287
  pDnode = mndAcquireDnode(pMnode, createReq.dnodeId);
92✔
288
  if (pDnode == NULL) {
92✔
289
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
9✔
290
    goto _OVER;
9✔
291
  }
292

293
  code = mndCreateBnode(pMnode, pReq, pDnode, &createReq);
83✔
294
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
83!
295

UNCOV
296
_OVER:
×
297
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
92!
298
    mError("bnode:%d, failed to create since %s", createReq.dnodeId, tstrerror(code));
9!
299
    TAOS_RETURN(code);
9✔
300
  }
301

302
  //  mndReleaseBnode(pMnode, pObj);
303
  mndReleaseDnode(pMnode, pDnode);
83✔
304
  tFreeSMCreateBnodeReq(&createReq);
83✔
305

306
  #else
307

308
  code = TSDB_CODE_OPS_NOT_SUPPORT;
309

310
  #endif
311

312
  TAOS_RETURN(code);
83✔
313
}
314

315
static int32_t mndSetDropBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
85✔
316
  int32_t code = 0, lino = 0;
85✔
317

318
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
85✔
319
  if (pRedoRaw == NULL) {
85!
320
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
321
    if (terrno != 0) code = terrno;
×
UNCOV
322
    TAOS_RETURN(code);
×
323
  }
324
  TAOS_CHECK_GOTO(mndTransAppendGroupRedolog(pTrans, pRedoRaw, -1), &lino, _OVER);
85!
325
  TAOS_CHECK_GOTO(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING), &lino, _OVER);
85!
326

327
_OVER:
85✔
328
  if (code != 0) {
85!
UNCOV
329
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
×
330
  }
331

332
  TAOS_RETURN(code);
85✔
333
}
334

335
static int32_t mndSetDropBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
85✔
336
  int32_t  code = 0;
85✔
337
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
85✔
338
  if (pCommitRaw == NULL) {
85!
UNCOV
339
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
340
    if (terrno != 0) code = terrno;
×
UNCOV
341
    TAOS_RETURN(code);
×
342
  }
343
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
85!
344
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
85!
345
  TAOS_RETURN(code);
85✔
346
}
347

348
static int32_t mndSetDropBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
85✔
349
  int32_t        code = 0;
85✔
350
  SDDropBnodeReq dropReq = {0};
85✔
351
  dropReq.dnodeId = pDnode->id;
85✔
352

353
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
85✔
354
  void   *pReq = taosMemoryMalloc(contLen);
85!
355
  if (pReq == NULL) {
85!
UNCOV
356
    code = terrno;
×
UNCOV
357
    TAOS_RETURN(code);
×
358
  }
359
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
85✔
360
  if (code < 0) {
85!
UNCOV
361
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
362
  }
363

364
  STransAction action = {0};
85✔
365
  action.epSet = mndGetDnodeEpset(pDnode);
85✔
366
  action.pCont = pReq;
85✔
367
  action.contLen = contLen;
85✔
368
  action.msgType = TDMT_DND_DROP_BNODE;
85✔
369
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
85✔
370

371
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
85✔
372
    taosMemoryFree(pReq);
3!
373
    TAOS_RETURN(code);
3✔
374
  }
375

376
  TAOS_RETURN(code);
82✔
377
}
378

379
int32_t mndSetDropBnodeInfoToTrans(SMnode *pMnode, STrans *pTrans, SBnodeObj *pObj, bool force) {
85✔
380
  int32_t code = -1, lino = 0;
85✔
381

382
  if (pObj == NULL) return 0;
85!
383
  TAOS_CHECK_GOTO(mndSetDropBnodeRedoLogs(pTrans, pObj), &lino, _OVER);
85!
384
  TAOS_CHECK_GOTO(mndSetDropBnodeCommitLogs(pTrans, pObj), &lino, _OVER);
85!
385
  if (!force) {
85!
386
    TAOS_CHECK_GOTO(mndSetDropBnodeRedoActions(pTrans, pObj->pDnode, pObj), &lino, _OVER);
85✔
387
  }
388

389
_OVER:
82✔
390
  if (code != 0) {
85✔
391
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
3!
392
  }
393

394
  return code;
85✔
395
}
396

397
static int32_t mndDropBnode(SMnode *pMnode, SRpcMsg *pReq, SBnodeObj *pObj) {
82✔
398
  int32_t code = -1;
82✔
399

400
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_NOTHING, pReq, "drop-bnode");
82✔
401
  if (pTrans == NULL) {
82!
UNCOV
402
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
403
    if (terrno != 0) code = terrno;
×
UNCOV
404
    goto _OVER;
×
405
  }
406
  mndTransSetSerial(pTrans);
82✔
407

408
  mInfo("trans:%d, used to drop bnode:%d", pTrans->id, pObj->id);
82!
409
  TAOS_CHECK_GOTO(mndSetDropBnodeInfoToTrans(pMnode, pTrans, pObj, false), NULL, _OVER);
82!
410
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
82!
411

412
  code = 0;
82✔
413

414
_OVER:
82✔
415
  mndTransDrop(pTrans);
82✔
416
  TAOS_RETURN(code);
82✔
417
}
418

419
static int32_t mndProcessDropBnodeReq(SRpcMsg *pReq) {
109✔
420
  SMnode        *pMnode = pReq->info.node;
109✔
421
  int32_t        code = -1;
109✔
422
  SBnodeObj     *pObj = NULL;
109✔
423
  SDnodeObj     *pDnode = NULL;
109✔
424
  SMDropBnodeReq dropReq = {0};
109✔
425

426
  TAOS_CHECK_GOTO(tDeserializeSMDropBnodeReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
109!
427

428
  mInfo("bnode:%d, start to drop", dropReq.dnodeId);
109!
429
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_DROP_BNODE), NULL, _OVER);
109!
430

431
  if (dropReq.dnodeId <= 0) {
109✔
432
    code = TSDB_CODE_INVALID_MSG;
6✔
433
    goto _OVER;
6✔
434
  }
435

436
  pDnode = mndAcquireDnode(pMnode, dropReq.dnodeId);
103✔
437
  if (pDnode == NULL) {
103✔
438
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
8✔
439
    goto _OVER;
8✔
440
  }
441

442
  if (!mndIsDnodeOnline(pDnode, taosGetTimestampMs())) {
95✔
443
    code = TSDB_CODE_DNODE_OFFLINE;
3✔
444
    goto _OVER;
3✔
445
  }
446

447
  pObj = mndAcquireBnode(pMnode, dropReq.dnodeId);
92✔
448
  if (pObj == NULL) {
92✔
449
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
10✔
450
    if (terrno != 0) code = terrno;
10!
451
    goto _OVER;
10✔
452
  }
453

454
  // check deletable
455
  code = mndDropBnode(pMnode, pReq, pObj);
82✔
456
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
82!
457

UNCOV
458
_OVER:
×
459
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
109!
460
    mError("bnode:%d, failed to drop since %s", dropReq.dnodeId, tstrerror(code));
27!
461
  }
462

463
  mndReleaseBnode(pMnode, pObj);
109✔
464
  mndReleaseDnode(pMnode, pDnode);
109✔
465
  tFreeSMDropBnodeReq(&dropReq);
109✔
466
  TAOS_RETURN(code);
109✔
467
}
468

469
static const char *mndBnodeProtoStr(int32_t proto) {
536✔
470
  switch (proto) {
536!
471
    case TSDB_BNODE_OPT_PROTO_MQTT:
536✔
472
      return TSDB_BNODE_OPT_PROTO_STR_MQTT;
536✔
UNCOV
473
    default:
×
UNCOV
474
      break;
×
475
  }
UNCOV
476
  return "unknown";
×
477
}
478

479
static int32_t mndRetrieveBnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
283✔
480
  SMnode    *pMnode = pReq->info.node;
283✔
481
  SSdb      *pSdb = pMnode->pSdb;
283✔
482
  int32_t    numOfRows = 0;
283✔
483
  int32_t    cols = 0;
283✔
484
  SBnodeObj *pObj = NULL;
283✔
485
  char       buf[TSDB_EP_LEN + VARSTR_HEADER_SIZE];
486

487
  while (numOfRows < rows) {
551!
488
    pShow->pIter = sdbFetch(pSdb, SDB_BNODE, pShow->pIter, (void **)&pObj);
551✔
489
    if (pShow->pIter == NULL) break;
551✔
490

491
    cols = 0;
268✔
492
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
268✔
493
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->id, false), pSdb, pObj);
268!
494

495
    char mqtt_ep[TSDB_EP_LEN] = {0};
268✔
496
    char ep[TSDB_EP_LEN + VARSTR_HEADER_SIZE] = {0};
268✔
497

498
    TAOS_UNUSED(tsnprintf(mqtt_ep, TSDB_EP_LEN - 1, "%s:%hu", pObj->pDnode->fqdn, tsMqttPort));
268✔
499
    STR_WITH_MAXSIZE_TO_VARSTR(ep, mqtt_ep, pShow->pMeta->pSchemas[cols].bytes);
268✔
500

501
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
268✔
502
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)ep, false), pSdb, pObj);
268!
503

504
    STR_TO_VARSTR(buf, mndBnodeProtoStr(pObj->proto));
268✔
505
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
268✔
506
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)buf, false), pSdb, pObj);
268!
507

508
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
268✔
509
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->createdTime, false), pSdb,
268!
510
                                   pObj);
511

512
    numOfRows++;
268✔
513
    sdbRelease(pSdb, pObj);
268✔
514
  }
515

516
  pShow->numOfRows += numOfRows;
283✔
517

518
  return numOfRows;
283✔
519
}
520

521
static void mndCancelGetNextBnode(SMnode *pMnode, void *pIter) {
×
UNCOV
522
  SSdb *pSdb = pMnode->pSdb;
×
UNCOV
523
  sdbCancelFetchByType(pSdb, pIter, SDB_BNODE);
×
UNCOV
524
}
×
525

UNCOV
526
SEpSet mndAcquireEpFromBnode(SMnode *pMnode, const SBnodeObj *pBnode) {
×
UNCOV
527
  SEpSet epSet = {.numOfEps = 1, .inUse = 0};
×
UNCOV
528
  memcpy(epSet.eps[0].fqdn, pBnode->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
529
  epSet.eps[0].port = pBnode->pDnode->port;
×
UNCOV
530
  return epSet;
×
531
}
532

533
SBnodeObj *mndAcquireBnode(SMnode *pMnode, int32_t dnodeId) {
214✔
534
  SBnodeObj *pObj = sdbAcquire(pMnode->pSdb, SDB_BNODE, &dnodeId);
214✔
535
  if (pObj == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
214!
536
    terrno = TSDB_CODE_MND_BNODE_NOT_EXIST;
129✔
537
  }
538
  return pObj;
214✔
539
}
540

541
void mndReleaseBnode(SMnode *pMnode, SBnodeObj *pObj) {
140✔
542
  SSdb *pSdb = pMnode->pSdb;
140✔
543
  sdbRelease(pSdb, pObj);
140✔
544
}
140✔
545

546
int32_t mndInitBnode(SMnode *pMnode) {
1,916✔
547
  SSdbTable table = {
1,916✔
548
      .sdbType = SDB_BNODE,
549
      .keyType = SDB_KEY_INT32,
550
      .encodeFp = (SdbEncodeFp)mndBnodeActionEncode,
551
      .decodeFp = (SdbDecodeFp)mndBnodeActionDecode,
552
      .insertFp = (SdbInsertFp)mndBnodeActionInsert,
553
      .updateFp = (SdbUpdateFp)mndBnodeActionUpdate,
554
      .deleteFp = (SdbDeleteFp)mndBnodeActionDelete,
555
  };
556

557
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_BNODE, mndProcessCreateBnodeReq);
1,916✔
558
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_BNODE, mndProcessDropBnodeReq);
1,916✔
559
  mndSetMsgHandle(pMnode, TDMT_DND_CREATE_BNODE_RSP, mndTransProcessRsp);
1,916✔
560
  mndSetMsgHandle(pMnode, TDMT_DND_DROP_BNODE_RSP, mndTransProcessRsp);
1,916✔
561

562
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndRetrieveBnodes);
1,916✔
563
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndCancelGetNextBnode);
1,916✔
564

565
  return sdbSetTable(pMnode->pSdb, table);
1,916✔
566
}
567

568
void mndCleanupBnode(SMnode *pMnode) {}
1,915✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc