wirenboard / wb-mqtt-serial / 689

Committed 26 Aug 2025 01:28PM UTC coverage: 73.031% (-0.08%) from 73.114%

Build # 689

Build Type

push

github

Committed by

web-flow

Commit Message

Add protocol parameter to device/Probe RPC (#988)

  * Add protocol to Modbus TCP port information in ports/Load RPC
  * Add protocol parameter to device/Probe RPC
  * Set TCP_NODELAY for TCP ports
  * Handle TCP port closing by remote

Run Details

6605 of 9406 branches covered (70.22%)

28 of 59 new or added lines in 11 files covered. (47.46%)

68 existing lines in 3 files now uncovered.

12554 of 17190 relevant lines covered (73.03%)

372.2 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.22

/src/rpc/rpc_config.cpp

#include "rpc_config.h"
#include <algorithm>

void TRPCConfig::AddSerialPort(const TSerialPortSettings& settings)
{
    Json::Value item;
    item["path"] = settings.Device;
    item["baud_rate"] = settings.BaudRate;
    item["data_bits"] = settings.DataBits;
    item["parity"] = std::string(1, settings.Parity);
    item["stop_bits"] = settings.StopBits;
    PortConfigs.append(std::move(item));
}

void TRPCConfig::AddTCPPort(const TTcpPortSettings& settings)
{
    Json::Value item;
    item["address"] = settings.Address;
    item["port"] = settings.Port;
    PortConfigs.append(std::move(item));
}

void TRPCConfig::AddModbusTCPPort(const TTcpPortSettings& settings)
{
    Json::Value item;
    item["address"] = settings.Address;
    item["port"] = settings.Port;
    item["mode"] = "modbus-tcp";
    PortConfigs.append(std::move(item));
}

Json::Value TRPCConfig::GetPortConfigs() const
{
    return PortConfigs;
}

1	#include "rpc_config.h"
2	#include <algorithm>
3
4	void TRPCConfig::AddSerialPort(const TSerialPortSettings& settings)	17✔
5	{
6	Json::Value item;	34✔
7	item["path"] = settings.Device;	17✔
8	item["baud_rate"] = settings.BaudRate;	17✔
9	item["data_bits"] = settings.DataBits;	17✔
10	item["parity"] = std::string(1, settings.Parity);	17✔
11	item["stop_bits"] = settings.StopBits;	17✔
12	PortConfigs.append(std::move(item));	17✔
13	}	17✔
14
15	void TRPCConfig::AddTCPPort(const TTcpPortSettings& settings)	4✔
16	{
17	Json::Value item;	8✔
18	item["address"] = settings.Address;	4✔
19	item["port"] = settings.Port;	4✔
20	PortConfigs.append(std::move(item));	4✔
21	}	4✔
22
NEW 23	void TRPCConfig::AddModbusTCPPort(const TTcpPortSettings& settings)	×
24	{
NEW 25	Json::Value item;	×
NEW 26	item["address"] = settings.Address;	×
NEW 27	item["port"] = settings.Port;	×
NEW 28	item["mode"] = "modbus-tcp";	×
NEW 29	PortConfigs.append(std::move(item));	×
30	}
31
UNCOV 32	Json::Value TRPCConfig::GetPortConfigs() const	×
33	{
34	return PortConfigs;	×
35	}

wirenboard / wb-mqtt-serial / 689

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous