17229631411

Committed 26 Aug 2025 06:13AM UTC coverage: 51.84% (-2.1%) from 53.937%

Build # 17229631411

Build Type

push

github

Committed by

web-flow

Commit Message

fix: remove another bottleneck that causes boot time spike (#596)

* fix: remove another bottleneck that causes boot time spike

* chore: add integration test

Run Details

28 of 33 new or added lines in 1 file covered. (84.85%)

4922 existing lines in 74 files now uncovered.

18444 of 35579 relevant lines covered (51.84%)

5545.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

7.69

/ext/node/ops/process.rs

// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

use deno_core::op2;
use deno_core::OpState;
use deno_permissions::PermissionsContainer;

#[cfg(unix)]
fn kill(pid: i32, sig: i32) -> i32 {
  // SAFETY: FFI call to libc
  if unsafe { libc::kill(pid, sig) } < 0 {
    std::io::Error::last_os_error().raw_os_error().unwrap()
  } else {
    0
  }
}

#[cfg(not(unix))]
fn kill(pid: i32, _sig: i32) -> i32 {
  use winapi::shared::minwindef::DWORD;
  use winapi::shared::minwindef::FALSE;
  use winapi::shared::minwindef::TRUE;
  use winapi::um::errhandlingapi::GetLastError;
  use winapi::um::processthreadsapi::GetCurrentProcess;
  use winapi::um::processthreadsapi::OpenProcess;
  use winapi::um::processthreadsapi::TerminateProcess;
  use winapi::um::winnt::PROCESS_TERMINATE;

  // SAFETY: FFI call to winapi
  unsafe {
    let p_hnd = if pid == 0 {
      GetCurrentProcess()
    } else {
      OpenProcess(PROCESS_TERMINATE, FALSE, pid as DWORD)
    };

    if p_hnd.is_null() {
      return GetLastError() as i32;
    }

    if TerminateProcess(p_hnd, 1) == TRUE {
      return 0;
    }

    GetLastError() as i32
  }
}

#[op2(fast, stack_trace)]
pub fn op_node_process_kill(
  state: &mut OpState,
  #[smi] pid: i32,
  #[smi] sig: i32,
) -> Result<i32, deno_core::error::AnyError> {
  state
    .borrow_mut::<PermissionsContainer>()
    .check_run_all("process.kill")?;
  Ok(kill(pid, sig))
}

#[op2(fast)]
pub fn op_process_abort(state: &mut OpState) {
  if state
    .borrow_mut::<PermissionsContainer>()
    .check_run_all("process.abort")
    .is_ok()
  {
    std::process::abort();
  }
}

1	// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
2
3	use deno_core::op2;
4	use deno_core::OpState;
5	use deno_permissions::PermissionsContainer;
6
7	#[cfg(unix)]
UNCOV 8	fn kill(pid: i32, sig: i32) -> i32 {	×
UNCOV 9	// SAFETY: FFI call to libc	×
UNCOV 10	if unsafe { libc::kill(pid, sig) } < 0 {	×
UNCOV 11	std::io::Error::last_os_error().raw_os_error().unwrap()	×
12	} else {
UNCOV 13	0	×
14	}
UNCOV 15	}	×
16
17	#[cfg(not(unix))]
18	fn kill(pid: i32, _sig: i32) -> i32 {
19	use winapi::shared::minwindef::DWORD;
20	use winapi::shared::minwindef::FALSE;
21	use winapi::shared::minwindef::TRUE;
22	use winapi::um::errhandlingapi::GetLastError;
23	use winapi::um::processthreadsapi::GetCurrentProcess;
24	use winapi::um::processthreadsapi::OpenProcess;
25	use winapi::um::processthreadsapi::TerminateProcess;
26	use winapi::um::winnt::PROCESS_TERMINATE;
27
28	// SAFETY: FFI call to winapi
29	unsafe {
30	let p_hnd = if pid == 0 {
31	GetCurrentProcess()
32	} else {
33	OpenProcess(PROCESS_TERMINATE, FALSE, pid as DWORD)
34	};
35
36	if p_hnd.is_null() {
37	return GetLastError() as i32;
38	}
39
40	if TerminateProcess(p_hnd, 1) == TRUE {
41	return 0;
42	}
43
44	GetLastError() as i32
45	}
46	}
47
48	#[op2(fast, stack_trace)]	1,159✔
49	pub fn op_node_process_kill(	×
50	state: &mut OpState,	×
51	#[smi] pid: i32,	×
UNCOV 52	#[smi] sig: i32,	×
53	) -> Result<i32, deno_core::error::AnyError> {	×
54	state	×
UNCOV 55	.borrow_mut::<PermissionsContainer>()	×
UNCOV 56	.check_run_all("process.kill")?;	×
UNCOV 57	Ok(kill(pid, sig))	×
UNCOV 58	}	×
59
60	#[op2(fast)]	1,159✔
UNCOV 61	pub fn op_process_abort(state: &mut OpState) {	×
UNCOV 62	if state	×
UNCOV 63	.borrow_mut::<PermissionsContainer>()	×
UNCOV 64	.check_run_all("process.abort")	×
UNCOV 65	.is_ok()	×
66	{
UNCOV 67	std::process::abort();	×
UNCOV 68	}	×
UNCOV 69	}	×

supabase / edge-runtime / 17229631411

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous