#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.31

/src/main/java/de/gwdg/metadataqa/marc/utils/keygenerator/MarcDataFieldKeyGenerator.java

package de.gwdg.metadataqa.marc.utils.keygenerator;

import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.structure.SubfieldDefinition;

public class MarcDataFieldKeyGenerator extends DataFieldKeyGenerator {

  public MarcDataFieldKeyGenerator(DataFieldDefinition definition) {
    super(definition);
  }

  public MarcDataFieldKeyGenerator(DataFieldDefinition definition,
                                   String tag,
                                   SchemaType schemaType) {
    super(definition, tag, schemaType);
  }

  @Override
  public String forInd1() {
    return String.format("%sind1", tag);
  }

  @Override
  public String forInd2() {
    return String.format("%sind2", tag);
  }

  @Override
  public String getKeyForSubfield(String code, String codeForIndex) {
    // Make sure that the field tag does not contain any invalid characters
    String safeTag = nonValidSubfieldCode.matcher(tag).find() ? escape(tag) : tag;

    // Also make sure that the subfield code does not contain any invalid characters
    if (nonValidSubfieldCode.matcher(code).matches()) {
      code = String.format("x%x", (int) code.charAt(0));
    }

    return String.format("%s%s", safeTag, code);
  }

  @Override
  public String forFullField() {
    String safeTag = nonValidSubfieldCode.matcher(tag).find() ? escape(tag) : tag;
    return safeTag + "_full";
  }

  @Override
  protected String addVersionSpecifier(SubfieldDefinition versionSpecificDefinition, String key) {
    return key;
  }
}

1	package de.gwdg.metadataqa.marc.utils.keygenerator;
2
3	import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
4	import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
5	import de.gwdg.metadataqa.marc.definition.structure.SubfieldDefinition;
6
7	public class MarcDataFieldKeyGenerator extends DataFieldKeyGenerator {
8
9	public MarcDataFieldKeyGenerator(DataFieldDefinition definition) {
10	super(definition);	1✔
11	}	1✔
12
13	public MarcDataFieldKeyGenerator(DataFieldDefinition definition,
14	String tag,
15	SchemaType schemaType) {
16	super(definition, tag, schemaType);	1✔
17	}	1✔
18
19	@Override
20	public String forInd1() {
21	return String.format("%sind1", tag);	1✔
22	}
23
24	@Override
25	public String forInd2() {
26	return String.format("%sind2", tag);	1✔
27	}
28
29	@Override
30	public String getKeyForSubfield(String code, String codeForIndex) {
31	// Make sure that the field tag does not contain any invalid characters
32	String safeTag = nonValidSubfieldCode.matcher(tag).find() ? escape(tag) : tag;	1✔
33
34	// Also make sure that the subfield code does not contain any invalid characters
35	if (nonValidSubfieldCode.matcher(code).matches()) {	1✔
NEW 36	code = String.format("x%x", (int) code.charAt(0));	×
37	}
38
39	return String.format("%s%s", safeTag, code);	1✔
40	}
41
42	@Override
43	public String forFullField() {
44	String safeTag = nonValidSubfieldCode.matcher(tag).find() ? escape(tag) : tag;	1✔
45	return safeTag + "_full";	1✔
46	}
47
48	@Override
49	protected String addVersionSpecifier(SubfieldDefinition versionSpecificDefinition, String key) {
50	return key;	1✔
51	}
52	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous