#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.12

/src/main/java/de/gwdg/metadataqa/marc/utils/keygenerator/HumanDataFieldKeyGenerator.java

package de.gwdg.metadataqa.marc.utils.keygenerator;

import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.structure.SubfieldDefinition;

public class HumanDataFieldKeyGenerator extends DataFieldKeyGenerator {

  public HumanDataFieldKeyGenerator(DataFieldDefinition definition) {
    super(definition);
  }

  public HumanDataFieldKeyGenerator(DataFieldDefinition definition,
                                    String tag,
                                    SchemaType schemaType) {
    super(definition, tag, schemaType);
  }

  @Override
  public String forInd1() {
    return String.format(
      "%s_%s",
      indexTag, definition.getInd1().getIndexTag());
  }

  @Override
  public String forInd2() {
    return String.format(
      "%s_%s",
      indexTag, definition.getInd2().getIndexTag());
  }

  @Override
  protected String addVersionSpecifier(SubfieldDefinition versionSpecificDefinition, String key) {
    if (versionSpecificDefinition != null && versionSpecificDefinition.getMarcVersion() != null) {
      key += "_" + versionSpecificDefinition.getMarcVersion().getCode();
    }
    return key;
  }

  @Override
  public String getKeyForSubfield(String code, String codeForIndex) {
    if (schemaType != null && schemaType.equals(SchemaType.PICA)) {
      return String.format("%s%s", indexTag, codeForIndex);
    }
    if (!codeForIndex.isEmpty()) {
      return String.format("%s_%s", indexTag, codeForIndex);
    }
    return String.format("%s", indexTag);
  }

  @Override
  public String forFullField() {
    return indexTag + "_full";
  }
}

1	package de.gwdg.metadataqa.marc.utils.keygenerator;
2
3	import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
4	import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
5	import de.gwdg.metadataqa.marc.definition.structure.SubfieldDefinition;
6
7	public class HumanDataFieldKeyGenerator extends DataFieldKeyGenerator {
8
9	public HumanDataFieldKeyGenerator(DataFieldDefinition definition) {
10	super(definition);	1✔
11	}	1✔
12
13	public HumanDataFieldKeyGenerator(DataFieldDefinition definition,
14	String tag,
15	SchemaType schemaType) {
16	super(definition, tag, schemaType);	1✔
17	}	1✔
18
19	@Override
20	public String forInd1() {
21	return String.format(	1✔
22	"%s_%s",
23	indexTag, definition.getInd1().getIndexTag());	1✔
24	}
25
26	@Override
27	public String forInd2() {
28	return String.format(	1✔
29	"%s_%s",
30	indexTag, definition.getInd2().getIndexTag());	1✔
31	}
32
33	@Override
34	protected String addVersionSpecifier(SubfieldDefinition versionSpecificDefinition, String key) {
35	if (versionSpecificDefinition != null && versionSpecificDefinition.getMarcVersion() != null) {	1✔
NEW 36	key += "_" + versionSpecificDefinition.getMarcVersion().getCode();	×
37	}
38	return key;	1✔
39	}
40
41	@Override
42	public String getKeyForSubfield(String code, String codeForIndex) {
43	if (schemaType != null && schemaType.equals(SchemaType.PICA)) {	1✔
44	return String.format("%s%s", indexTag, codeForIndex);	1✔
45	}
46	if (!codeForIndex.isEmpty()) {	1✔
47	return String.format("%s_%s", indexTag, codeForIndex);	1✔
48	}
49	return String.format("%s", indexTag);	1✔
50	}
51
52	@Override
53	public String forFullField() {
54	return indexTag + "_full";	1✔
55	}
56	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous