#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/src/main/java/de/gwdg/metadataqa/marc/utils/keygenerator/DataFieldKeyGeneratorFactory.java

package de.gwdg.metadataqa.marc.utils.keygenerator;

import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
import de.gwdg.metadataqa.marc.model.SolrFieldType;

public class DataFieldKeyGeneratorFactory {

  private DataFieldKeyGeneratorFactory() {
    // Prevent instantiation
  }

  public static DataFieldKeyGenerator create(SolrFieldType fieldType, DataFieldDefinition definition, String tag, SchemaType schemaType) {
    if (fieldType == SolrFieldType.MIXED) {
      return new MixedDataFieldKeyGenerator(definition, tag, schemaType);
    }
    if (fieldType == SolrFieldType.HUMAN) {
      return new HumanDataFieldKeyGenerator(definition, tag, schemaType);
    }

    // In any other case, return a MarcDataFieldKeyGenerator
    return new MarcDataFieldKeyGenerator(definition, tag, schemaType);
  }

  public static DataFieldKeyGenerator create(SolrFieldType fieldType, DataFieldDefinition definition) {
    if (fieldType == SolrFieldType.MIXED) {
      return new MixedDataFieldKeyGenerator(definition);
    }
    if (fieldType == SolrFieldType.HUMAN) {
      return new HumanDataFieldKeyGenerator(definition);
    }

    // In any other case, return a MarcDataFieldKeyGenerator
    return new MarcDataFieldKeyGenerator(definition);
  }
}

1	package de.gwdg.metadataqa.marc.utils.keygenerator;
2
3	import de.gwdg.metadataqa.marc.definition.bibliographic.SchemaType;
4	import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
5	import de.gwdg.metadataqa.marc.model.SolrFieldType;
6
7	public class DataFieldKeyGeneratorFactory {
8
9	private DataFieldKeyGeneratorFactory() {
10	// Prevent instantiation
11	}
12
13	public static DataFieldKeyGenerator create(SolrFieldType fieldType, DataFieldDefinition definition, String tag, SchemaType schemaType) {
14	if (fieldType == SolrFieldType.MIXED) {	1✔
15	return new MixedDataFieldKeyGenerator(definition, tag, schemaType);	1✔
16	}
17	if (fieldType == SolrFieldType.HUMAN) {	1✔
18	return new HumanDataFieldKeyGenerator(definition, tag, schemaType);	1✔
19	}
20
21	// In any other case, return a MarcDataFieldKeyGenerator
22	return new MarcDataFieldKeyGenerator(definition, tag, schemaType);	1✔
23	}
24
25	public static DataFieldKeyGenerator create(SolrFieldType fieldType, DataFieldDefinition definition) {
26	if (fieldType == SolrFieldType.MIXED) {	1✔
27	return new MixedDataFieldKeyGenerator(definition);	1✔
28	}
NEW 29	if (fieldType == SolrFieldType.HUMAN) {	×
NEW 30	return new HumanDataFieldKeyGenerator(definition);	×
31	}
32
33	// In any other case, return a MarcDataFieldKeyGenerator
NEW 34	return new MarcDataFieldKeyGenerator(definition);	×
35	}
36	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous