#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.46

/src/main/java/de/gwdg/metadataqa/marc/dao/MarcControlField.java

package de.gwdg.metadataqa.marc.dao;

import de.gwdg.metadataqa.marc.Extractable;
import de.gwdg.metadataqa.marc.Validatable;
import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.MarcVersion;
import de.gwdg.metadataqa.marc.model.SolrFieldType;
import de.gwdg.metadataqa.marc.model.validation.ValidationError;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;

public class MarcControlField implements Validatable, Extractable, Serializable {

  private static final long serialVersionUID = -2860608188307996601L;
  protected BibliographicRecord marcRecord;
  protected DataFieldDefinition definition;
  protected String content;
  protected List<ValidationError> initializationErrors = new ArrayList<>();
  protected List<ValidationError> validationErrors;

  public MarcControlField() {
  }

  public MarcControlField(DataFieldDefinition definition, String content) {
    this.definition = definition;
    this.content = content;
  }

  public DataFieldDefinition getDefinition() {
    return definition;
  }

  public String getContent() {
    return content;
  }

  public String getSolrKey(SolrFieldType type, String tag, String mqTag) {
    String key;
    switch (type) {
      case HUMAN: key = mqTag; break;
      case MIXED: key = String.format("%s_%s", tag, mqTag); break;
      case MARC:
      default:  key = tag; break;
    }
    return key;
  }

  @Override
  public Map<String, List<String>> getKeyValuePairs() {
    return getKeyValuePairs(SolrFieldType.MARC);
  }

  @Override
  public Map<String, List<String>> getKeyValuePairs(SolrFieldType type) {
    return getKeyValuePairs(type, MarcVersion.MARC21);
  }

  @Override
  public Map<String, List<String>> getKeyValuePairs(SolrFieldType type, MarcVersion marcVersion) {
    Map<String, List<String>> map = new LinkedHashMap<>();

    map.put(
      getSolrKey(type, definition.getTag(), definition.getMqTag()),
      Arrays.asList(content));
    return map;
  }

  @Override
  public boolean validate(MarcVersion marcVersion) {
    return true;
  }

  @Override
  public List<ValidationError> getValidationErrors() {
    return validationErrors;
  }

  public void setMarcRecord(BibliographicRecord marcRecord) {
    this.marcRecord = marcRecord;
  }

  public List<ValidationError> getInitializationErrors() {
    return initializationErrors;
  }
}

1	package de.gwdg.metadataqa.marc.dao;
2
3	import de.gwdg.metadataqa.marc.Extractable;
4	import de.gwdg.metadataqa.marc.Validatable;
5	import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
6	import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
7	import de.gwdg.metadataqa.marc.definition.MarcVersion;
8	import de.gwdg.metadataqa.marc.model.SolrFieldType;
9	import de.gwdg.metadataqa.marc.model.validation.ValidationError;
10
11	import java.io.Serializable;
12	import java.util.ArrayList;
13	import java.util.Arrays;
14	import java.util.LinkedHashMap;
15	import java.util.List;
16	import java.util.Map;
17
18	public class MarcControlField implements Validatable, Extractable, Serializable {
19
20	private static final long serialVersionUID = -2860608188307996601L;
21	protected BibliographicRecord marcRecord;
22	protected DataFieldDefinition definition;
23	protected String content;
24	protected List<ValidationError> initializationErrors = new ArrayList<>();	1✔
25	protected List<ValidationError> validationErrors;
26
UNCOV 27	public MarcControlField() {	×
28	}	×
29
30	public MarcControlField(DataFieldDefinition definition, String content) {	1✔
31	this.definition = definition;	1✔
32	this.content = content;	1✔
33	}	1✔
34
35	public DataFieldDefinition getDefinition() {
36	return definition;	1✔
37	}
38
39	public String getContent() {
40	return content;	1✔
41	}
42
43	public String getSolrKey(SolrFieldType type, String tag, String mqTag) {
44	String key;
45	switch (type) {	1✔
46	case HUMAN: key = mqTag; break;	1✔
47	case MIXED: key = String.format("%s_%s", tag, mqTag); break;	1✔
48	case MARC:
49	default: key = tag; break;	1✔
50	}
51	return key;	1✔
52	}
53
54	@Override
55	public Map<String, List<String>> getKeyValuePairs() {
56	return getKeyValuePairs(SolrFieldType.MARC);	1✔
57	}
58
59	@Override
60	public Map<String, List<String>> getKeyValuePairs(SolrFieldType type) {
61	return getKeyValuePairs(type, MarcVersion.MARC21);	1✔
62	}
63
64	@Override
65	public Map<String, List<String>> getKeyValuePairs(SolrFieldType type, MarcVersion marcVersion) {
66	Map<String, List<String>> map = new LinkedHashMap<>();	1✔
67
68	map.put(	1✔
69	getSolrKey(type, definition.getTag(), definition.getMqTag()),	1✔
70	Arrays.asList(content));	1✔
71	return map;	1✔
72	}
73
74	@Override
75	public boolean validate(MarcVersion marcVersion) {
UNCOV 76	return true;	×
77	}
78
79	@Override
80	public List<ValidationError> getValidationErrors() {
81	return validationErrors;	1✔
82	}
83
84	public void setMarcRecord(BibliographicRecord marcRecord) {
85	this.marcRecord = marcRecord;	1✔
86	}	1✔
87
88	public List<ValidationError> getInitializationErrors() {
89	return initializationErrors;	1✔
90	}
91	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous