#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/src/main/java/de/gwdg/metadataqa/marc/dao/DefaultMarcPositionalControlField.java

package de.gwdg.metadataqa.marc.dao;

import de.gwdg.metadataqa.marc.definition.ControlValue;
import de.gwdg.metadataqa.marc.definition.structure.ControlFieldDefinition;
import de.gwdg.metadataqa.marc.definition.structure.ControlfieldPositionDefinition;
import de.gwdg.metadataqa.marc.definition.structure.DefaultControlFieldDefinition;

import java.util.logging.Level;
import java.util.logging.Logger;

public class DefaultMarcPositionalControlField extends MarcPositionalControlField {
  private static final Logger logger = Logger.getLogger(DefaultMarcPositionalControlField.class.getCanonicalName());

  public DefaultMarcPositionalControlField(DefaultControlFieldDefinition definition, String content) {
    super(definition, content);
    processContent();
  }

  public DefaultMarcPositionalControlField(ControlFieldDefinition definition, String content, MarcLeader.Type recordType) {
    super(definition, content, recordType);
  }

  @Override
  protected void processContent() {
    for (ControlfieldPositionDefinition position : ((DefaultControlFieldDefinition) definition).getPositions()) {
      int end = Math.min(content.length(), position.getPositionEnd());
      try {
        String value = content.substring(position.getPositionStart(), end);
        ControlValue controlValue = new ControlValue(position, value);
        valuesList.add(controlValue);
      } catch (StringIndexOutOfBoundsException e) {
        logger.log(
          Level.SEVERE,
          "Problem with processing {5} (\"{0}\"). The content length is only {1} while reading position @{2}-{3} (for {4})",
          new Object[]{
            content, content.length(), position.getPositionStart(), position.getPositionEnd(), position.getLabel(), definition.getTag()
          });
      }
    }
  }

  @Override
  public ControlfieldPositionDefinition getSubfieldByPosition(Integer charStart) {
    return null;
  }
}

1	package de.gwdg.metadataqa.marc.dao;
2
3	import de.gwdg.metadataqa.marc.definition.ControlValue;
4	import de.gwdg.metadataqa.marc.definition.structure.ControlFieldDefinition;
5	import de.gwdg.metadataqa.marc.definition.structure.ControlfieldPositionDefinition;
6	import de.gwdg.metadataqa.marc.definition.structure.DefaultControlFieldDefinition;
7
8	import java.util.logging.Level;
9	import java.util.logging.Logger;
10
11	public class DefaultMarcPositionalControlField extends MarcPositionalControlField {
12	private static final Logger logger = Logger.getLogger(DefaultMarcPositionalControlField.class.getCanonicalName());	1✔
13
14	public DefaultMarcPositionalControlField(DefaultControlFieldDefinition definition, String content) {
15	super(definition, content);	1✔
16	processContent();	1✔
17	}	1✔
18
19	public DefaultMarcPositionalControlField(ControlFieldDefinition definition, String content, MarcLeader.Type recordType) {
NEW 20	super(definition, content, recordType);	×
NEW 21	}	×
22
23	@Override
24	protected void processContent() {
25	for (ControlfieldPositionDefinition position : ((DefaultControlFieldDefinition) definition).getPositions()) {	1✔
26	int end = Math.min(content.length(), position.getPositionEnd());	1✔
27	try {
28	String value = content.substring(position.getPositionStart(), end);	1✔
29	ControlValue controlValue = new ControlValue(position, value);	1✔
30	valuesList.add(controlValue);	1✔
NEW 31	} catch (StringIndexOutOfBoundsException e) {	×
NEW 32	logger.log(	×
33	Level.SEVERE,
34	"Problem with processing {5} (\"{0}\"). The content length is only {1} while reading position @{2}-{3} (for {4})",
35	new Object[]{
NEW 36	content, content.length(), position.getPositionStart(), position.getPositionEnd(), position.getLabel(), definition.getTag()	×
37	});
38	}	1✔
39	}	1✔
40	}	1✔
41
42	@Override
43	public ControlfieldPositionDefinition getSubfieldByPosition(Integer charStart) {
NEW 44	return null;	×
45	}
46	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous