#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.97

/src/main/java/de/gwdg/metadataqa/marc/cli/parameters/TranslationParameters.java

package de.gwdg.metadataqa.marc.cli.parameters;

import org.apache.commons.cli.ParseException;

import java.util.Arrays;
import java.util.List;
import java.util.logging.Logger;

public class TranslationParameters extends Shacl4bibParameters {

  private static final Logger logger = Logger.getLogger(TranslationParameters.class.getCanonicalName());

  // default values
  protected static final String DEFAULT_TRANSLATION_OUTPUT_FILE = "translations.csv";
  private String translationConfigurationFile;
  // private String translationOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;
  private List<String> debugFailedRules;
  private String translationPlaceNameDictionaryDir;
  private String translationExport;

  // protected String shaclOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;

  protected void setOptions() {
    if (!isOptionSet) {
      super.setOptions();
      // options.addOption("O", "translationOutputFile", true, "output file");
      options.addOption("D", "translationDebugFailedRules", true, "log values that are not matched with the specified rule ID");
      options.addOption("E", "translationPlaceNameDictionaryDir", true, "A directory where place-synonyms-normalized.csv and coords.csv are located (see https://github.com/pkiraly/place-names)");
      options.addOption("F", "translationExport", true, "The exported translations file");
      options.addOption("G", "translationConfigurationFile", true, "specify the configuration file");
    }
  }

  public TranslationParameters() {
    super();
  }

  public TranslationParameters(String[] arguments) throws ParseException {
    super(arguments);
    if (!cmd.hasOption("shaclOutputFile")) {
      shaclOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;
    }

    /*
    if (cmd.hasOption("translationOutputFile"))
      translationOutputFile = cmd.getOptionValue("translationOutputFile");

     */

    if (cmd.hasOption("translationDebugFailedRules"))
      debugFailedRules = Arrays.asList(cmd.getOptionValue("translationDebugFailedRules").split(","));

    if (cmd.hasOption("translationPlaceNameDictionaryDir"))
      translationPlaceNameDictionaryDir = cmd.getOptionValue("translationPlaceNameDictionaryDir");

    if (cmd.hasOption("translationExport"))
      translationExport = cmd.getOptionValue("translationExport");

    if (cmd.hasOption("translationConfigurationFile"))
      translationConfigurationFile = cmd.getOptionValue("translationConfigurationFile");
  }

  public List<String> getDebugFailedRules() {
    return debugFailedRules;
  }

  /*
  public String getTranslationOutputFile() {
    return translationOutputFile;
  }
   */

  @Override
  public String getShaclOutputFile() {
    return shaclOutputFile;
  }

  public String getTranslationPlaceNameDictionaryDir() {
    return translationPlaceNameDictionaryDir;
  }

  public String getTranslationExport() {
    return translationExport;
  }

  public String getTranslationConfigurationFile() {
    return translationConfigurationFile;
  }

  @Override
  public String formatParameters() {
    String text = super.formatParameters();
    // text += String.format("translationOutputFile: %s%n", getTranslationOutputFile());
    text += String.format("translationDebugFailedRules: %s%n", getDebugFailedRules());
    text += String.format("translationPlaceNameDictionaryDir: %s%n", getTranslationPlaceNameDictionaryDir());
    text += String.format("translationExport: %s%n", getTranslationExport());
    text += String.format("translationConfigurationFile: %s%n", getTranslationConfigurationFile());
    return text;
  }
}

1	package de.gwdg.metadataqa.marc.cli.parameters;
2
3	import org.apache.commons.cli.ParseException;
4
5	import java.util.Arrays;
6	import java.util.List;
7	import java.util.logging.Logger;
8
9	public class TranslationParameters extends Shacl4bibParameters {
10
11	private static final Logger logger = Logger.getLogger(TranslationParameters.class.getCanonicalName());	1✔
12
13	// default values
14	protected static final String DEFAULT_TRANSLATION_OUTPUT_FILE = "translations.csv";
15	private String translationConfigurationFile;
16	// private String translationOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;
17	private List<String> debugFailedRules;
18	private String translationPlaceNameDictionaryDir;
19	private String translationExport;
20
21	// protected String shaclOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;
22
23	protected void setOptions() {
24	if (!isOptionSet) {	1✔
25	super.setOptions();	1✔
26	// options.addOption("O", "translationOutputFile", true, "output file");
27	options.addOption("D", "translationDebugFailedRules", true, "log values that are not matched with the specified rule ID");	1✔
28	options.addOption("E", "translationPlaceNameDictionaryDir", true, "A directory where place-synonyms-normalized.csv and coords.csv are located (see https://github.com/pkiraly/place-names)");	1✔
29	options.addOption("F", "translationExport", true, "The exported translations file");	1✔
30	options.addOption("G", "translationConfigurationFile", true, "specify the configuration file");	1✔
31	}
32	}	1✔
33
34	public TranslationParameters() {
35	super();	1✔
36	}	1✔
37
38	public TranslationParameters(String[] arguments) throws ParseException {
39	super(arguments);	1✔
40	if (!cmd.hasOption("shaclOutputFile")) {	1✔
NEW 41	shaclOutputFile = DEFAULT_TRANSLATION_OUTPUT_FILE;	×
42	}
43
44	/*
45	if (cmd.hasOption("translationOutputFile"))
46	translationOutputFile = cmd.getOptionValue("translationOutputFile");
47
48	*/
49
50	if (cmd.hasOption("translationDebugFailedRules"))	1✔
51	debugFailedRules = Arrays.asList(cmd.getOptionValue("translationDebugFailedRules").split(","));	1✔
52
53	if (cmd.hasOption("translationPlaceNameDictionaryDir"))	1✔
54	translationPlaceNameDictionaryDir = cmd.getOptionValue("translationPlaceNameDictionaryDir");	1✔
55
56	if (cmd.hasOption("translationExport"))	1✔
57	translationExport = cmd.getOptionValue("translationExport");	1✔
58
59	if (cmd.hasOption("translationConfigurationFile"))	1✔
60	translationConfigurationFile = cmd.getOptionValue("translationConfigurationFile");	1✔
61	}	1✔
62
63	public List<String> getDebugFailedRules() {
64	return debugFailedRules;	1✔
65	}
66
67	/*
68	public String getTranslationOutputFile() {
69	return translationOutputFile;
70	}
71	*/
72
73	@Override
74	public String getShaclOutputFile() {
75	return shaclOutputFile;	1✔
76	}
77
78	public String getTranslationPlaceNameDictionaryDir() {
79	return translationPlaceNameDictionaryDir;	1✔
80	}
81
82	public String getTranslationExport() {
83	return translationExport;	1✔
84	}
85
86	public String getTranslationConfigurationFile() {
87	return translationConfigurationFile;	1✔
88	}
89
90	@Override
91	public String formatParameters() {
92	String text = super.formatParameters();	1✔
93	// text += String.format("translationOutputFile: %s%n", getTranslationOutputFile());
94	text += String.format("translationDebugFailedRules: %s%n", getDebugFailedRules());	1✔
95	text += String.format("translationPlaceNameDictionaryDir: %s%n", getTranslationPlaceNameDictionaryDir());	1✔
96	text += String.format("translationExport: %s%n", getTranslationExport());	1✔
97	text += String.format("translationConfigurationFile: %s%n", getTranslationConfigurationFile());	1✔
98	return text;	1✔
99	}
100	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous