#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.77

/src/main/java/de/gwdg/metadataqa/marc/analysis/serial/SerialFields.java

package de.gwdg.metadataqa.marc.analysis.serial;

public enum SerialFields {
  ID("id", "id"),
  DATE_1_UNKNOWN("Date 1 is unknown", "date1-unknown"),
  COUNTRY_UNKNOWN("Country of publication is unknown", "country-unknown"),
  LANGUAGE("Publication language is unknown", "language"),
  AUTH("Authentication code is empty", "auth"),
  ENCODING_LEVEL_FULL("Encoding level is full", "enc-full"),
  ENCODING_LEVEL_MINIMAL("Encoding level is M, L, K or 7", "enc-mlk7"),
  HAS_006("006 is present", "006"),
  HAS_PUBLISHER_260("Publisher 260 (AACR2) is present", "260"),
  HAS_PUBLISHER_264("Publisher 264 (RDA) is present", "264"),
  HAS_PUBLICATION_FREQUENCY_310("Publication frequency is present", "310"),
  HAS_CONTENT_TYPE_336("Content Type (336) is present", "336"),
  HAS_DATES_OF_PUBLICATION_362("Dates of Publication (362) is present", "362"),
  HAS_SOURCE_OF_DESCRIPTION_588("Source of Description Note (588) is present", "588"),
  HAS_NO_SUBJECT("No subject is present", "no-subject"),
  HAS_SUBJECT("Subject is present", "has-subject"),
  PCC("Authentication Code is pcc", "pcc"),
  DATE_1_STARTS_WITH_0("First date (008/07) startes with 0", "date1-0"),
  INACTIVE_TITLE("Title is inactive - no date2", "date2-present"), // TODO check the machine field. Not sure what it is
  ABBREVIATED("Encoding level is abbreviated", "abbreviated"),
  TOTAL("total", "total");

  private final String label;

  // FIXME The name "machine" isn't very descriptive. It's not clear what it means.
  private final String machine;

  // FIXME This field is not set anywhere. It's always false.
  private final boolean isClassification = false;

  SerialFields(String label, String machine) {
    this.label = label;
    this.machine = machine;
  }

  public String getLabel() {
    return label;
  }

  public String getMachine() {
    return machine;
  }

  public boolean isClassification() {
    return isClassification;
  }

  @Override
  public String toString() {
    return "SerialFields{" +
      "label='" + label + '\'' +
      ", machine='" + machine + '\'' +
      ", isClassification=" + isClassification +
      '}';
  }
}

1	package de.gwdg.metadataqa.marc.analysis.serial;
2
3	public enum SerialFields {	1✔
4	ID("id", "id"),	1✔
5	DATE_1_UNKNOWN("Date 1 is unknown", "date1-unknown"),	1✔
6	COUNTRY_UNKNOWN("Country of publication is unknown", "country-unknown"),	1✔
7	LANGUAGE("Publication language is unknown", "language"),	1✔
8	AUTH("Authentication code is empty", "auth"),	1✔
9	ENCODING_LEVEL_FULL("Encoding level is full", "enc-full"),	1✔
10	ENCODING_LEVEL_MINIMAL("Encoding level is M, L, K or 7", "enc-mlk7"),	1✔
11	HAS_006("006 is present", "006"),	1✔
12	HAS_PUBLISHER_260("Publisher 260 (AACR2) is present", "260"),	1✔
13	HAS_PUBLISHER_264("Publisher 264 (RDA) is present", "264"),	1✔
14	HAS_PUBLICATION_FREQUENCY_310("Publication frequency is present", "310"),	1✔
15	HAS_CONTENT_TYPE_336("Content Type (336) is present", "336"),	1✔
16	HAS_DATES_OF_PUBLICATION_362("Dates of Publication (362) is present", "362"),	1✔
17	HAS_SOURCE_OF_DESCRIPTION_588("Source of Description Note (588) is present", "588"),	1✔
18	HAS_NO_SUBJECT("No subject is present", "no-subject"),	1✔
19	HAS_SUBJECT("Subject is present", "has-subject"),	1✔
20	PCC("Authentication Code is pcc", "pcc"),	1✔
21	DATE_1_STARTS_WITH_0("First date (008/07) startes with 0", "date1-0"),	1✔
22	INACTIVE_TITLE("Title is inactive - no date2", "date2-present"), // TODO check the machine field. Not sure what it is	1✔
23	ABBREVIATED("Encoding level is abbreviated", "abbreviated"),	1✔
24	TOTAL("total", "total");	1✔
25
26	private final String label;
27
28	// FIXME The name "machine" isn't very descriptive. It's not clear what it means.
29	private final String machine;
30
31	// FIXME This field is not set anywhere. It's always false.
32	private final boolean isClassification = false;	1✔
33
34	SerialFields(String label, String machine) {	1✔
35	this.label = label;	1✔
36	this.machine = machine;	1✔
37	}	1✔
38
39	public String getLabel() {
40	return label;	1✔
41	}
42
43	public String getMachine() {
44	return machine;	1✔
45	}
46
47	public boolean isClassification() {
48	return isClassification;	1✔
49	}
50
51	@Override
52	public String toString() {
UNCOV 53	return "SerialFields{" +	×
54	"label='" + label + '\'' +
55	", machine='" + machine + '\'' +
56	", isClassification=" + isClassification +
57	'}';
58	}
59	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous