#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/src/main/java/de/gwdg/metadataqa/marc/analysis/functional/UnimarcFunctionalAnalyzer.java

package de.gwdg.metadataqa.marc.analysis.functional;

import de.gwdg.metadataqa.marc.MarcSubfield;
import de.gwdg.metadataqa.marc.dao.DataField;
import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
import de.gwdg.metadataqa.marc.dao.record.UnimarcRecord;
import de.gwdg.metadataqa.marc.definition.FRBRFunction;
import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
import de.gwdg.metadataqa.marc.utils.FunctionValue;

import java.util.HashMap;
import java.util.Map;
import java.util.logging.Logger;

/**
 * Analyzes a UNIMARC record and counts the FRBR functions. In other words, it counts how many FRBR user tasks are
 * supported by the provided record.
 */
public class UnimarcFunctionalAnalyzer extends FunctionalAnalyzer {

  private static final Logger logger = Logger.getLogger(UnimarcFunctionalAnalyzer.class.getCanonicalName());

  public UnimarcFunctionalAnalyzer(FrbrFunctionLister frbrFunctionLister) {
    super(frbrFunctionLister);
  }

  @Override
  protected void analyzeRecord(BibliographicRecord bibliographicRecord) {

    if (!(bibliographicRecord instanceof UnimarcRecord)) {
      logger.severe("The provided record is not a UNIMARC record. The analysis will not be performed.");
      return;
    }

    UnimarcRecord unimarcRecord = (UnimarcRecord) bibliographicRecord;

    Map<DataFieldDefinition, Boolean> cache = new HashMap<>();

    // Count functions for the data fields
    countDataFields(recordCounter, unimarcRecord.getDatafields(), cache);

  }

  @Override
  protected void countDataField(DataFieldDefinition definition,
                                DataField dataField,
                                Map<FRBRFunction, FunctionValue> recordCounter) {

    for (MarcSubfield subfield : dataField.getSubfields()) {
      String key = dataField.getTag() + "$" + subfield.getCode();
      if (frbrFunctionLister.getFunctionByPath().containsKey(key)) {
        countFunctions(frbrFunctionLister.getFunctionByPath().get(key), recordCounter);
      }
    }
  }
}

1	package de.gwdg.metadataqa.marc.analysis.functional;
2
3	import de.gwdg.metadataqa.marc.MarcSubfield;
4	import de.gwdg.metadataqa.marc.dao.DataField;
5	import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
6	import de.gwdg.metadataqa.marc.dao.record.UnimarcRecord;
7	import de.gwdg.metadataqa.marc.definition.FRBRFunction;
8	import de.gwdg.metadataqa.marc.definition.structure.DataFieldDefinition;
9	import de.gwdg.metadataqa.marc.utils.FunctionValue;
10
11	import java.util.HashMap;
12	import java.util.Map;
13	import java.util.logging.Logger;
14
15	/**
16	* Analyzes a UNIMARC record and counts the FRBR functions. In other words, it counts how many FRBR user tasks are
17	* supported by the provided record.
18	*/
19	public class UnimarcFunctionalAnalyzer extends FunctionalAnalyzer {
20
21	private static final Logger logger = Logger.getLogger(UnimarcFunctionalAnalyzer.class.getCanonicalName());	1✔
22
23	public UnimarcFunctionalAnalyzer(FrbrFunctionLister frbrFunctionLister) {
24	super(frbrFunctionLister);	1✔
25	}	1✔
26
27	@Override
28	protected void analyzeRecord(BibliographicRecord bibliographicRecord) {
29
30	if (!(bibliographicRecord instanceof UnimarcRecord)) {	1✔
NEW 31	logger.severe("The provided record is not a UNIMARC record. The analysis will not be performed.");	×
NEW 32	return;	×
33	}
34
35	UnimarcRecord unimarcRecord = (UnimarcRecord) bibliographicRecord;	1✔
36
37	Map<DataFieldDefinition, Boolean> cache = new HashMap<>();	1✔
38
39	// Count functions for the data fields
40	countDataFields(recordCounter, unimarcRecord.getDatafields(), cache);	1✔
41
42	}	1✔
43
44	@Override
45	protected void countDataField(DataFieldDefinition definition,
46	DataField dataField,
47	Map<FRBRFunction, FunctionValue> recordCounter) {
48
49	for (MarcSubfield subfield : dataField.getSubfields()) {	1✔
50	String key = dataField.getTag() + "$" + subfield.getCode();	1✔
51	if (frbrFunctionLister.getFunctionByPath().containsKey(key)) {	1✔
52	countFunctions(frbrFunctionLister.getFunctionByPath().get(key), recordCounter);	1✔
53	}
54	}	1✔
55	}	1✔
56	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous