#1527

Committed 22 Aug 2025 02:21PM UTC coverage: 90.345%. Remained the same

Build # #1527

Build Type

push

Committed by

Commit Message

Improve timeline handling

Run Details

5191 of 6416 new or added lines in 219 files covered. (80.91%)

886 existing lines in 78 files now uncovered.

36717 of 40641 relevant lines covered (90.34%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/de/gwdg/metadataqa/marc/analysis/DataElementCounter.java

package de.gwdg.metadataqa.marc.analysis;

import de.gwdg.metadataqa.marc.MarcSubfield;
import de.gwdg.metadataqa.marc.dao.DataField;
import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
import org.apache.commons.io.FileUtils;

import java.io.File;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.logging.Logger;

public class DataElementCounter {

  public enum Basis{EXISTENCE, OCCURENCE}

  private static final Logger logger = Logger.getLogger(DataElementCounter.class.getCanonicalName());

  List<DataElement> elements = new ArrayList<>();
  Map<String, List<DataElement>> tags = new LinkedHashMap<>();
  private final String header;
  private final Basis basis;

  public DataElementCounter(String dir, String fileName, Basis basis) {
    this.basis = basis;
    File file = new File(dir, fileName);
    String firstLine = "";
    try {
      List<String> lines = FileUtils.readLines(file, StandardCharsets.UTF_8);
      firstLine = lines.get(0);
      String[] topFields = firstLine.split(",");
      for (String field : topFields) {
        String[] parts = field.split("\\$");
        DataElement element = new DataElement(parts[0], parts[1]);
        elements.add(element);
        tags.computeIfAbsent(element.field, s -> new ArrayList<>());
        tags.get(element.field).add(element);
      }
    } catch (IOException e) {
      logger.severe(e.getLocalizedMessage());
    }
    this.header = firstLine;
  }

  public List<Integer> count(BibliographicRecord marcRecord) {
    List<Integer> counts = new ArrayList<>();
    for (Map.Entry<String, List<DataElement>> entry : tags.entrySet()) {
      List<DataField> instances = marcRecord.getDatafieldsByTag(entry.getKey());
      if (instances == null || instances.isEmpty()) {
        for (int i=0; i<entry.getValue().size(); i++) {
          counts.add(0);
        }
      } else {
        Map<String, Integer> result = new LinkedHashMap<>();
        for (DataField instance : instances) {
          for (DataElement element : entry.getValue()) {
            result.computeIfAbsent(element.subfield, s -> 0);
            List<MarcSubfield> subfields = instance.getSubfield(element.subfield);
            if (subfields != null && !subfields.isEmpty()) {
              result.put(element.subfield, result.get(element.subfield) + subfields.size());
            }
          }
        }
        for (DataElement element : entry.getValue()) {
          int score = result.get(element.subfield);
          if (basis.equals(Basis.EXISTENCE) && score >= 1)
            score = 1;
          counts.add(score);
        }
      }
    }
    return counts;
  }

  public String getHeader() {
    return header;
  }

  class DataElement {
    String field;
    String subfield;
    String key;

    public DataElement(String field, String subfield) {
      this.field = field;
      this.subfield = subfield;
      this.key = field + "$" + subfield;
    }
  }
}

1	package de.gwdg.metadataqa.marc.analysis;
2
3	import de.gwdg.metadataqa.marc.MarcSubfield;
4	import de.gwdg.metadataqa.marc.dao.DataField;
5	import de.gwdg.metadataqa.marc.dao.record.BibliographicRecord;
6	import org.apache.commons.io.FileUtils;
7
8	import java.io.File;
9	import java.io.IOException;
10	import java.nio.charset.StandardCharsets;
11	import java.util.ArrayList;
12	import java.util.LinkedHashMap;
13	import java.util.List;
14	import java.util.Map;
15	import java.util.logging.Logger;
16
17	public class DataElementCounter {
18
19	public enum Basis{EXISTENCE, OCCURENCE}	×
20
21	private static final Logger logger = Logger.getLogger(DataElementCounter.class.getCanonicalName());	×
22
23	List<DataElement> elements = new ArrayList<>();	×
24	Map<String, List<DataElement>> tags = new LinkedHashMap<>();	×
25	private final String header;
26	private final Basis basis;
27
28	public DataElementCounter(String dir, String fileName, Basis basis) {	×
29	this.basis = basis;	×
30	File file = new File(dir, fileName);	×
31	String firstLine = "";	×
32	try {
33	List<String> lines = FileUtils.readLines(file, StandardCharsets.UTF_8);	×
34	firstLine = lines.get(0);	×
35	String[] topFields = firstLine.split(",");	×
36	for (String field : topFields) {	×
37	String[] parts = field.split("\\$");	×
38	DataElement element = new DataElement(parts[0], parts[1]);	×
39	elements.add(element);	×
40	tags.computeIfAbsent(element.field, s -> new ArrayList<>());	×
41	tags.get(element.field).add(element);	×
42	}
43	} catch (IOException e) {	×
44	logger.severe(e.getLocalizedMessage());	×
45	}	×
46	this.header = firstLine;	×
47	}	×
48
49	public List<Integer> count(BibliographicRecord marcRecord) {
50	List<Integer> counts = new ArrayList<>();	×
51	for (Map.Entry<String, List<DataElement>> entry : tags.entrySet()) {	×
NEW 52	List<DataField> instances = marcRecord.getDatafieldsByTag(entry.getKey());	×
53	if (instances == null \|\| instances.isEmpty()) {	×
54	for (int i=0; i<entry.getValue().size(); i++) {	×
55	counts.add(0);	×
56	}
57	} else {
58	Map<String, Integer> result = new LinkedHashMap<>();	×
59	for (DataField instance : instances) {	×
60	for (DataElement element : entry.getValue()) {	×
61	result.computeIfAbsent(element.subfield, s -> 0);	×
62	List<MarcSubfield> subfields = instance.getSubfield(element.subfield);	×
63	if (subfields != null && !subfields.isEmpty()) {	×
64	result.put(element.subfield, result.get(element.subfield) + subfields.size());	×
65	}
66	}	×
67	}	×
68	for (DataElement element : entry.getValue()) {	×
69	int score = result.get(element.subfield);	×
70	if (basis.equals(Basis.EXISTENCE) && score >= 1)	×
71	score = 1;	×
72	counts.add(score);	×
73	}	×
74	}
75	}	×
76	return counts;	×
77	}
78
79	public String getHeader() {
80	return header;	×
81	}
82
83	class DataElement {
84	String field;
85	String subfield;
86	String key;
87
88	public DataElement(String field, String subfield) {	×
89	this.field = field;	×
90	this.subfield = subfield;	×
91	this.key = field + "$" + subfield;	×
92	}	×
93	}
94	}

pkiraly / metadata-qa-marc / #1527

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous