2593

Committed 19 Aug 2025 12:18AM UTC coverage: 22.883%. Remained the same

Build # 2593

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1136 from hazendaz/moretests

Set logger in stub override fixer to final

Run Details

93 of 760 branches covered (12.24%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

334 of 1106 relevant lines covered (30.2%)

0.3 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/stubfixer/java/com/github/spotbugs/StubOverrideFixer.java

/*
 * Copyright 2005-2025 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.github.spotbugs;

import com.github.javaparser.ParseProblemException;
import com.github.javaparser.StaticJavaParser;
import com.github.javaparser.ast.CompilationUnit;
import com.github.javaparser.ast.body.MethodDeclaration;

import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Set;
import java.util.stream.Stream;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
 * The Class StubOverrideFixer.
 */
public class StubOverrideFixer {

    /** The logger. */
    private static final Logger logger = LoggerFactory.getLogger(StubOverrideFixer.class);

    /** The Constant GROOVY_METHODS. */
    private static final Set<String> GROOVY_METHODS = Set.of("getMetaClass", "setMetaClass", "invokeMethod",
            "getProperty", "setProperty");

    /**
     * The main method.
     *
     * @param args the arguments
     * @throws IOException Signals that an I/O exception has occurred.
     */
    public static void main(String[] args) throws IOException {
        Path stubsDir = Path.of(args[0]);
        try (Stream<Path> stream = Files.walk(stubsDir)) {
            stream.filter(p -> p.toString().endsWith(".java")).forEach(StubOverrideFixer::processStub);
        }
    }

    /**
     * Process stub.
     *
     * @param filePath the file path
     */
    private static void processStub(Path filePath) {
        try {
            CompilationUnit cu = StaticJavaParser.parse(filePath);

            cu.findAll(MethodDeclaration.class).forEach(method -> {
                if (shouldHaveOverride(method)) {
                    method.addAnnotation("java.lang.Override");
                }
            });

            Files.write(filePath, cu.toString().getBytes(StandardCharsets.UTF_8));
        } catch (IOException | ParseProblemException e) {
            logger.error("Error processing: {} - {}", filePath, e.getMessage());
        }
    }

    /**
     * Should have override.
     *
     * @param method the method
     * @return true, if successful
     */
    private static boolean shouldHaveOverride(MethodDeclaration method) {
        return GROOVY_METHODS.contains(method.getNameAsString());
    }

}

1	/*
2	* Copyright 2005-2025 the original author or authors.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* https://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.github.spotbugs;
17
18	import com.github.javaparser.ParseProblemException;
19	import com.github.javaparser.StaticJavaParser;
20	import com.github.javaparser.ast.CompilationUnit;
21	import com.github.javaparser.ast.body.MethodDeclaration;
22
23	import java.io.IOException;
24	import java.nio.charset.StandardCharsets;
25	import java.nio.file.Files;
26	import java.nio.file.Path;
27	import java.util.Set;
28	import java.util.stream.Stream;
29
30	import org.slf4j.Logger;
31	import org.slf4j.LoggerFactory;
32
33	/**
34	* The Class StubOverrideFixer.
35	*/
36	public class StubOverrideFixer {	×
37
38	/** The logger. */
NEW 39	private static final Logger logger = LoggerFactory.getLogger(StubOverrideFixer.class);	×
40
41	/** The Constant GROOVY_METHODS. */
42	private static final Set<String> GROOVY_METHODS = Set.of("getMetaClass", "setMetaClass", "invokeMethod",	×
43	"getProperty", "setProperty");
44
45	/**
46	* The main method.
47	*
48	* @param args the arguments
49	* @throws IOException Signals that an I/O exception has occurred.
50	*/
51	public static void main(String[] args) throws IOException {
52	Path stubsDir = Path.of(args[0]);	×
53	try (Stream<Path> stream = Files.walk(stubsDir)) {	×
54	stream.filter(p -> p.toString().endsWith(".java")).forEach(StubOverrideFixer::processStub);	×
55	}
56	}	×
57
58	/**
59	* Process stub.
60	*
61	* @param filePath the file path
62	*/
63	private static void processStub(Path filePath) {
64	try {
65	CompilationUnit cu = StaticJavaParser.parse(filePath);	×
66
67	cu.findAll(MethodDeclaration.class).forEach(method -> {	×
68	if (shouldHaveOverride(method)) {	×
69	method.addAnnotation("java.lang.Override");	×
70	}
71	});	×
72
73	Files.write(filePath, cu.toString().getBytes(StandardCharsets.UTF_8));	×
74	} catch (IOException \| ParseProblemException e) {	×
75	logger.error("Error processing: {} - {}", filePath, e.getMessage());	×
76	}	×
77	}	×
78
79	/**
80	* Should have override.
81	*
82	* @param method the method
83	* @return true, if successful
84	*/
85	private static boolean shouldHaveOverride(MethodDeclaration method) {
86	return GROOVY_METHODS.contains(method.getNameAsString());	×
87	}
88
89	}

spotbugs / spotbugs-maven-plugin / 2593

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous