17019138792

Committed 17 Aug 2025 09:01AM UTC coverage: 97.399% (-0.2%) from 97.629%

Build # 17019138792

Build Type

Pull #264

github

Committed by

web-flow

Commit Message

Merge f09dd629a into c107cc5e2

Pull Request Pull Request #264: Allow parts to have empty fields

Run Details

78 of 92 new or added lines in 10 files covered. (84.78%)

12 existing lines in 5 files now uncovered.

4381 of 4498 relevant lines covered (97.4%)

1618.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.98

/questiontype.php

<?php
// This file is part of Moodle - https://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle.  If not, see <https://www.gnu.org/licenses/>.

/**
 * Question type class for the Formulas question type.
 *
 * @copyright 2010-2011 Hon Wai, Lau; 2023 Philipp Imhof
 * @author Hon Wai, Lau <lau65536@gmail.com>
 * @author Philipp Imhof
 * @license https://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 * @package qtype_formulas
 */

use qtype_formulas\answer_unit_conversion;
use qtype_formulas\unit_conversion_rules;
use qtype_formulas\local\evaluator;
use qtype_formulas\local\random_parser;
use qtype_formulas\local\answer_parser;
use qtype_formulas\local\parser;
use qtype_formulas\local\token;

defined('MOODLE_INTERNAL') || die();

require_once($CFG->libdir . '/questionlib.php');
require_once($CFG->dirroot . '/question/engine/lib.php');
require_once($CFG->dirroot . '/question/type/formulas/answer_unit.php');
require_once($CFG->dirroot . '/question/type/formulas/conversion_rules.php');
require_once($CFG->dirroot . '/question/type/formulas/question.php');

/**
 * Question type class for the Formulas question type.
 *
 * @copyright 2010-2011 Hon Wai, Lau; 2023 Philipp Imhof
 * @license https://www.gnu.org/copyleft/gpl.html GNU Public License version 3
 */
class qtype_formulas extends question_type {

    /** @var int */
    const ANSWER_TYPE_NUMBER = 0;

    /** @var int */
    const ANSWER_TYPE_NUMERIC = 10;

    /** @var int */
    const ANSWER_TYPE_NUMERICAL_FORMULA = 100;

    /** @var int */
    const ANSWER_TYPE_ALGEBRAIC = 1000;

    /** @var int maximum allowed size for lists (arrays) */
    const MAX_LIST_SIZE = 1000;

    /**
     * The following array contains some of the column names of the table qtype_formulas_answers,
     * the table that holds the parts (not just answers) of a question. These columns undergo similar
     * validation, so they are grouped in this array. Some columns are not listed here, namely
     * the texts (part's text, part's feedback) and their formatting option, because they are
     * validated separately:
     * - placeholder: the part's placeholder to be used in the main question text, e. g. #1
     * - answermark: grade awarded for this part, if answer is fully correct
     * - numbox: number of answers for this part, not including a possible unit field
     * - vars1: the part's local variables
     * - answer: the model answer(s) for this part
     * - vars2: the part's grading variables
     * - correctness: the part's grading criterion
     * - unitpenalty: deduction to be made for wrong units
     * - postunit: the unit in which the model answer has been entered
     * - ruleid: ruleset used for unit conversion
     * - otherrule: additional rules for unit conversion
     */
    const PART_BASIC_FIELDS = ['placeholder', 'answermark', 'answertype', 'numbox', 'vars1', 'answer', 'answernotunique', 'vars2',
        'emptyallowed', 'correctness', 'unitpenalty', 'postunit', 'ruleid', 'otherrule'];

    /**
     * This function returns the "simple" additional fields defined in the qtype_formulas_options
     * table. It is called by Moodle's core in order to have those fields automatically saved
     * backed up and restored. The basic fields like id and questionid do not need to included.
     * Also, we do not include the more "complex" feedback fields (correct, partially correct, incorrect),
     * as they need special treatment, because they can contain references to uploaded files.
     *
     * @return string[]
     */
    public function extra_question_fields() {
        return ['qtype_formulas_options', 'varsrandom', 'varsglobal', 'shownumcorrect', 'answernumbering'];
    }

    /**
     * Fetch the ID for every part of a given question.
     *
     * @param int $questionid
     * @return int[]
     */
    protected function fetch_part_ids_for_question(int $questionid): array {
        global $DB;

        // Fetch the parts from the DB. The result will be an associative array with
        // the parts' IDs as keys.
        $parts = $DB->get_records('qtype_formulas_answers', ['questionid' => $questionid]);

        return array_keys($parts);
    }

    /**
     * Move all the files belonging to this question (and its parts) from one context to another.
     *
     * @param int $questionid the question being moved.
     * @param int $oldcontextid the context it is moving from.
     * @param int $newcontextid the context it is moving to.
     */
    public function move_files($questionid, $oldcontextid, $newcontextid): void {
        // Fetch the part IDs for every part of this question.
        $partids = $this->fetch_part_ids_for_question($questionid);

        // Move files for all areas and all parts.
        $fs = get_file_storage();
        $areas = ['answersubqtext', 'answerfeedback', 'partcorrectfb', 'partpartiallycorrectfb', 'partincorrectfb'];
        foreach ($areas as $area) {
            $fs->move_area_files_to_new_context($oldcontextid, $newcontextid, 'qtype_formulas', $area, $questionid);
            foreach ($partids as $partid) {
                $fs->move_area_files_to_new_context($oldcontextid, $newcontextid, 'qtype_formulas', $area, $partid);
            }
        }

        $this->move_files_in_combined_feedback($questionid, $oldcontextid, $newcontextid);
        $this->move_files_in_hints($questionid, $oldcontextid, $newcontextid);

        // The parent method will move files from the question text and the general feedback.
        parent::move_files($questionid, $oldcontextid, $newcontextid);
    }

    /**
     * Delete all the files belonging to this question (and its parts).
     *
     * @param int $questionid the question being deleted.
     * @param int $contextid the context the question is in.
     */
    protected function delete_files($questionid, $contextid): void {
        // Fetch the part IDs for every part of this question.
        $partids = $this->fetch_part_ids_for_question($questionid);

        // Delete files for all areas and all parts.
        $fs = get_file_storage();
        $areas = ['answersubqtext', 'answerfeedback', 'partcorrectfb', 'partpartiallycorrectfb', 'partincorrectfb'];
        foreach ($areas as $area) {
            $fs->delete_area_files($contextid, 'qtype_formulas', $area, $questionid);
            foreach ($partids as $partid) {
                $fs->delete_area_files($contextid, 'qtype_formulas', $area, $partid);
            }
        }

        $this->delete_files_in_combined_feedback($questionid, $contextid);
        $this->delete_files_in_hints($questionid, $contextid);

        // The parent method will delete files from the question text and the general feedback.
        parent::delete_files($questionid, $contextid);
    }

    /**
     * Loads the question type specific options for the question.
     * $question already contains the question's general data from the question table when
     * this function is called.
     *
     * This function loads any question type specific options for the
     * question from the database into the question object. This information
     * is placed in the $question->options field. A question type is
     * free, however, to decide on a internal structure of the options field.
     * @param object $question The question object for the question. This object
     *                         should be updated to include the question type
     *                         specific information (it is passed by reference).
     * @return bool            Indicates success or failure.
     */
    public function get_question_options($question): bool {
        global $DB;

        // Fetch options from the table qtype_formulas_options. The DB engine will automatically
        // return a standard class where the attribute names match the column names.
        $question->options = $DB->get_record('qtype_formulas_options', ['questionid' => $question->id]);

        // In case of a DB error (e. g. missing record), get_record() returns false. In that case, we
        // create default options.
        if ($question->options === false) {
            debugging(get_string('error_db_missing_options', 'qtype_formulas', $question->id), DEBUG_DEVELOPER);
            $question->options = (object)[
                'questionid' => $question->id,
                'varsrandom' => '',
                'varsglobal' => '',
                'correctfeedback' => get_string('correctfeedbackdefault', 'question'),
                'correctfeedbackformat' => FORMAT_HTML,
                'partiallycorrectfeedback' => get_string('partiallycorrectfeedbackdefault', 'question'),
                'partiallycorrectfeedbackformat' => FORMAT_HTML,
                'incorrectfeedback' => get_string('incorrectfeedbackdefault', 'question'),
                'incorrectfeedbackformat' => FORMAT_HTML,
                'shownumcorrect' => 0,
                'answernumbering' => 'none',
            ];
        }

        parent::get_question_options($question);

        // Fetch parts' data and remove existing array indices (starting from first part's id) in order
        // to have the array indices start from 0.
        $question->options->answers = $DB->get_records('qtype_formulas_answers', ['questionid' => $question->id], 'partindex ASC');
        $question->options->answers = array_values($question->options->answers);

        // Correctly set the number of parts for this question.
        $question->options->numparts = count($question->options->answers);

        return true;
    }

    /**
     * Helper function to save files that are embedded in e. g. part's text or
     * feedback, avoids to set 'qtype_formulas' for every invocation.
     *
     * @param array $array the data from the form (or from import). This will
     *      normally have come from the formslib editor element, so it will be an
     *      array with keys 'text', 'format' and 'itemid'. However, when we are
     *      importing, it will be an array with keys 'text', 'format' and 'files'
     * @param object $context the context the question is in.
     * @param string $filearea indentifies the file area questiontext,
     *      generalfeedback, answerfeedback, etc.
     * @param int $itemid part or question ID
     *
     * @return string the text for this field, after files have been processed.
     */
    protected function save_file_helper(array $array, object $context, string $filearea, int $itemid): string {
        return $this->import_or_save_files($array, $context, 'qtype_formulas', $filearea, $itemid);
    }

    /**
     * Saves question-type specific options
     *
     * This is called by {@see save_question()} to save the question-type specific data
     * @param object $formdata  This holds the information from the editing form,
     *      it is not a standard question object.
     * @return object $result->error or $result->notice
     * @throws Exception
     */
    public function save_question_options($formdata) {
        global $DB;

        // Fetch existing parts from the DB.
        $existingparts = $DB->get_records('qtype_formulas_answers', ['questionid' => $formdata->id], 'partindex ASC');

        // Validate the data from the edit form.
        $filtered = $this->validate($formdata);
        if (!empty($filtered->errors)) {
            return (object)['error' => implode("\n", $filtered->errors)];
        }

        // Order the parts according to how they appear in the question.
        $filtered->answers = $this->reorder_parts($formdata->questiontext, $filtered->answers);

        // Get the question's context. We will need that for handling any files that might have
        // been uploaded via the text editors.
        $context = $formdata->context;

        foreach ($filtered->answers as $i => $part) {
            $part->questionid = $formdata->id;
            $part->partindex = $i;

            // Try to take the first existing part.
            $parttoupdate = array_shift($existingparts);

            // If there is currently no part, we create an empty one, store it in the DB
            // and retrieve its ID.
            if (empty($parttoupdate)) {
                $config = get_config('qtype_formulas');
                $parttoupdate = (object)[
                    'questionid' => $formdata->id,
                    'answermark' => $config->defaultanswermark,
                    'numbox' => 1,
                    'answer' => '',
                    'answernotunique' => 1,
                    'emptyallowed' => 1,
                    'correctness' => '',
                    'ruleid' => 1,
                    'subqtext' => '',
                    'subqtextformat' => FORMAT_HTML,
                    'feedback' => '',
                    'feedbackformat' => FORMAT_HTML,
                    'partcorrectfb' => '',
                    'partcorrectfbformat' => FORMAT_HTML,
                    'partpartiallycorrectfb' => '',
                    'partpartiallycorrectfbformat' => FORMAT_HTML,
                    'partincorrectfb' => '',
                    'partincorrectfbformat' => FORMAT_HTML,
                ];

                try {
                    $parttoupdate->id = $DB->insert_record('qtype_formulas_answers', $parttoupdate);
                } catch (Exception $e) {
                    // TODO: change to non-capturing catch when dropping support for PHP 7.4.
                    return (object)['error' => get_string('error_db_write', 'qtype_formulas', 'qtype_formulas_answers')];
                }
            }

            // Finally, set the ID for the newpart.
            $part->id = $parttoupdate->id;

            // Now that we have the ID, we can deal with the text fields that might contain files,
            // i. e. the part's text and the feedbacks (general, correct, partially correct, incorrect).
            // We must split up the form's text editor data (text and format in one array) into separate
            // text and format properties. Moodle does its magic when saving the files, so we first do
            // that and keep the modified text.
            // Note that we store the files with the part ID for all text fields that belong to a part.
            $tmp = $part->subqtext;
            $part->subqtext = $this->save_file_helper($tmp, $context, 'answersubqtext', $part->id);
            $part->subqtextformat = $tmp['format'];

            $tmp = $part->feedback;
            $part->feedback = $this->save_file_helper($tmp, $context, 'answerfeedback', $part->id);
            $part->feedbackformat = $tmp['format'];

            $tmp = $part->partcorrectfb;
            $part->partcorrectfb = $this->save_file_helper($tmp, $context, 'partcorrectfb', $part->id);
            $part->partcorrectfbformat = $tmp['format'];

            $tmp = $part->partpartiallycorrectfb;
            $part->partpartiallycorrectfb = $this->save_file_helper($tmp, $context, 'partpartiallycorrectfb', $part->id);
            $part->partpartiallycorrectfbformat = $tmp['format'];

            $tmp = $part->partincorrectfb;
            $part->partincorrectfb = $this->save_file_helper($tmp, $context, 'partincorrectfb', $part->id);
            $part->partincorrectfbformat = $tmp['format'];

            try {
                $DB->update_record('qtype_formulas_answers', $part);
            } catch (Exception $e) {
                // TODO: change to non-capturing catch when dropping support for PHP 7.4.
                return (object)['error' => get_string('error_db_write', 'qtype_formulas', 'qtype_formulas_answers')];
            }
        }

        $options = $DB->get_record('qtype_formulas_options', ['questionid' => $formdata->id]);

        // If there are no options yet (i. e. we are saving a new question) or if the fetch was not
        // successful, create new options with default values.
        if (empty($options) || $options === false) {
            $options = (object)[
                'questionid' => $formdata->id,
                'correctfeedback' => '',
                'partiallycorrectfeedback' => '',
                'incorrectfeedback' => '',
                'answernumbering' => 'none',
            ];

            try {
                $options->id = $DB->insert_record('qtype_formulas_options', $options);
            } catch (Exception $e) {
                return (object)['error' => get_string('error_db_write', 'qtype_formulas', 'qtype_formulas_options')];
            }
        }

        // Do all the magic for the question's combined feedback fields (correct, partially correct, incorrect).
        $options = $this->save_combined_feedback_helper($options, $formdata, $context, true);

        // Get the extra fields we have for our question type. Drop the first entry, because
        // it contains the table name.
        $extraquestionfields = $this->extra_question_fields();
        array_shift($extraquestionfields);

        // Assign the values from the form.
        foreach ($extraquestionfields as $extrafield) {
            if (isset($formdata->$extrafield)) {
                $options->$extrafield = $formdata->$extrafield;
            }
        }

        // Finally, update the existing (or just recently created) record with the values from the form.
        try {
            $DB->update_record('qtype_formulas_options', $options);
        } catch (Exception $e) {
            return (object)['error' => get_string('error_db_write', 'qtype_formulas', 'qtype_formulas_options')];
        }

        // Save the hints, if they exist.
        $this->save_hints($formdata, true);

        // If there are no existing parts left to be updated, we may leave.
        if (!$existingparts) {
            return;
        }

        // Still here? Then we must remove remaining parts and their files (if there are), because the
        // user seems to have deleted them in the form. This is only important for Moodle 3.11 and lower,
        // because from Moodle 4.0 on, the parts and their files will remain in the DB, linked to the
        // old question version.
        $fs = get_file_storage();
        foreach ($existingparts as $leftover) {
            $areas = ['answersubqtext', 'answerfeedback', 'partcorrectfb', 'partpartiallycorrectfb', 'partincorrectfb'];
            foreach ($areas as $area) {
                $fs->delete_area_files($context->id, 'qtype_formulas', $area, $leftover->id);
            }
            try {
                $DB->delete_records('qtype_formulas_answers', ['id' => $leftover->id]);
            } catch (Exception $e) {
                return (object)['error' => get_string('error_db_delete', 'qtype_formulas', 'qtype_formulas_answers')];
            }
        }
    }

    /**
     * Save a question. Overriding the parent method, because we have to calculate the
     * defaultmark and we need to propagate the global settings for unitpenalty and ruleid
     * to every part.
     *
     * @param object $question
     * @param object $formdata
     * @return object
     */
    public function save_question($question, $formdata) {
        // Question's default mark is the total of all non empty parts's marks.
        $formdata->defaultmark = 0;
        foreach (array_keys($formdata->answermark) as $key) {
            $formdata->defaultmark += $formdata->answermark[$key];
        }

        // Add the global unitpenalty and ruleid to each part. Using the answertype field as
        // the counter reference, because it is always set.
        $count = count($formdata->answertype);
        $formdata->unitpenalty = array_fill(0, $count, $formdata->globalunitpenalty);
        $formdata->ruleid = array_fill(0, $count, $formdata->globalruleid);

        // Preparation work is done, let the parent method do the rest.
        return parent::save_question($question, $formdata);
    }

    /**
     * Create a question_hint. Overriding the parent method, because our
     * question type can have multiple parts.
     *
     * @param object $hint the DB row from the question hints table.
     * @return question_hint
     */
    protected function make_hint($hint) {
        return question_hint_with_parts::load_from_record($hint);
    }

    /**
     * Delete the question from the database, together with its options and parts.
     *
     * @param int $questionid
     * @param int $contextid
     * @return void
     */
    public function delete_question($questionid, $contextid) {
        global $DB;

        // First, we call the parent method. It will delete the question itself (from question)
        // and its options (from qtype_formulas_options).
        // Note: This will also trigger the delete_files() method which, in turn, needs the question's
        // parts to be available, so we MUST NOT remove the parts before this.
        parent::delete_question($questionid, $contextid);

        // Finally, remove the related parts from the qtype_formulas_answers table.
        $DB->delete_records('qtype_formulas_answers', ['questionid' => $questionid]);
    }

    /**
     * Split the main question text into fragments that will later enclose the various parts'
     * text. As an example, 'foo {#1} bar' will become 'foo ' and ' bar'. The function will
     * return one more fragment than the number of parts. The last fragment can be empty, e. g.
     * if we have a part with no placeholder. Such parts are placed at the very end, so there will
     * no fragment of the question's main text after them.
     *
     * @param string $questiontext main question tex
     * @param qtype_formulas_part[] $parts
     * @return string[] fragments (one more than the number of parts
     */
    public function split_questiontext(string $questiontext, array $parts): array {
        // Make sure the parts are ordered according to the position of their placeholders
        // in the main question text.
        $parts = $this->reorder_parts($questiontext, $parts);

        $fragments = [];
        foreach ($parts as $part) {
            // Since the parts are ordered, we know that parts with placeholders come first.
            // When we see the first part without a placeholder, we can add the remaining question
            // text to the fragments. We then set the question text to the empty string, in order
            // to add empty fragments for each subsequent part.
            if (empty($part->placeholder)) {
                $fragments[] = $questiontext;
                $questiontext = '';
                continue;
            }
            $pos = strpos($questiontext, "{{$part->placeholder}}");
            $fragments[] = substr($questiontext, 0, $pos);
            $questiontext = substr($questiontext, $pos + strlen($part->placeholder) + 2);
        }

        // Add the remainder of the question text after the last part; this might be an empty string.
        $fragments[] = $questiontext;

        return $fragments;
    }

    /**
     * Initialise instante of the qtype_formulas_question class and its parts which, in turn,
     * are instances of the qtype_formulas_part class.
     *
     * @param question_definition $question instance of a Formulas question (qtype_formulas_question)
     * @param object $questiondata question data as stored in the DB
     */
    protected function initialise_question_instance(question_definition $question, $questiondata) {
        // All the classical fields (e. g. category, context or id) are filled by the parent method.
        parent::initialise_question_instance($question, $questiondata);

        // First, copy some data for the main question.
        /** @var qtype_formulas_question $question */
        $question->varsrandom = $questiondata->options->varsrandom;
        $question->varsglobal = $questiondata->options->varsglobal;
        $question->answernumbering = $questiondata->options->answernumbering;
        $question->numparts = $questiondata->options->numparts;

        // The attribute $questiondata->options->answers stores all information for the parts. Despite
        // its name, it does not only contain the model answers, but also e.g. local or grading vars.
        foreach ($questiondata->options->answers as $partdata) {
            $questionpart = new qtype_formulas_part();

            // Copy the data fields fetched from the DB to the question part object.
            foreach ($partdata as $key => $value) {
                $questionpart->{$key} = $value;
            }

            // And finally store the populated part in the main question instance.
            $question->parts[$partdata->partindex] = $questionpart;
        }

        // Split the main question text into fragments that will later surround the parts' texts.
        $question->textfragments = $this->split_questiontext($question->questiontext, $question->parts);

        // The combined feedback will be initialised by the parent class, because we do not override
        // this method.
        $this->initialise_combined_feedback($question, $questiondata, true);
    }

    /**
     * Return all possible types of response. They are used e. g. in reports.
     *
     * @param object $questiondata question definition data
     * @return array possible responses for every part
     */
    public function get_possible_responses($questiondata) {
        $responses = [];

        /** @var qtype_formulas_question $question */
        $question = $this->make_question($questiondata);

        foreach ($question->parts as $part) {
            if ($part->postunit === '') {
                $responses[$part->partindex] = [
                    'wrong' => new question_possible_response(get_string('response_wrong', 'qtype_formulas'), 0),
                    'right' => new question_possible_response(get_string('response_right', 'qtype_formulas'), 1),
                    null => question_possible_response::no_response(),
                ];
            } else {
                $responses[$part->partindex] = [
                    'wrong' => new question_possible_response(get_string('response_wrong', 'qtype_formulas'), 0),
                    'right' => new question_possible_response(get_string('response_right', 'qtype_formulas'), 1),
                    'wrongvalue' => new question_possible_response(get_string('response_wrong_value', 'qtype_formulas'), 0),
                    'wrongunit' => new question_possible_response(
                        get_string('response_wrong_unit', 'qtype_formulas'), 1 - $part->unitpenalty
                    ),
                    null => question_possible_response::no_response(),
                ];
            }
        }

        return $responses;
    }

    /**
     * Imports the question from Moodle XML format. Overriding the parent function is necessary,
     * because a Formulas question contains subparts.
     *
     * @param array $xml structure containing the XML data
     * @param object $question question object to fill
     * @param qformat_xml $format format class exporting the question
     * @param object $extra extra information (not required for importing this question in this format)
     * @return object question object
     */
    public function import_from_xml($xml, $question, qformat_xml $format, $extra = null) {
        // Return if data type is not our own one.
        if (!isset($xml['@']['type']) || $xml['@']['type'] != $this->name()) {
            return false;
        }

        // Import the common question headers and set the corresponding field.
        $question = $format->import_headers($xml);
        $question->qtype = $this->name();
        $format->import_combined_feedback($question, $xml, true);
        $format->import_hints($question, $xml, true);

        $question->varsrandom = $format->getpath($xml, ['#', 'varsrandom', 0, '#', 'text', 0, '#'], '', true);
        $question->varsglobal = $format->getpath($xml, ['#', 'varsglobal', 0, '#', 'text', 0, '#'], '', true);
        $question->answernumbering = $format->getpath($xml, ['#', 'answernumbering', 0, '#', 'text', 0, '#'], 'none', true);

        // Loop over each answer block found in the XML.
        foreach ($xml['#']['answers'] as $i => $part) {
            $partindex = $format->getpath($part, ['#', 'partindex', 0 , '#' , 'text' , 0 , '#'], false);
            if ($partindex !== false) {
                $question->partindex[$i] = $partindex;
            }
            foreach (self::PART_BASIC_FIELDS as $field) {
                // Older questions do not have the 'answernotunique' field, so we do not want to issue an
                // error message. For maximum backwards compatibility, we set the default value to 1. With
                // this, nothing changes for old questions. Also, questions exported prior to version 6.2
                // won't have the 'emptyallowed' field. We will set it to 0 (false) for backwards compatiblity.
                if ($field === 'answernotunique') {
                    $ifnotexists = '';
                    $default = '1';
                } else if ($field === 'emptyallowed') {
                    $ifnotexists = '';
                    $default = '0';
                } else {
                    $ifnotexists = get_string('error_import_missing_field', 'qtype_formulas', $field);
                    $default = '0';
                }
                $question->{$field}[$i] = $format->getpath(
                    $part,
                    ['#', $field, 0 , '#' , 'text' , 0 , '#'],
                    $default,
                    false,
                    $ifnotexists
                );
            }

            $subqxml = $format->getpath($part, ['#', 'subqtext', 0], []);
            $question->subqtext[$i] = $format->import_text_with_files($subqxml,
                        [], '', $format->get_format($question->questiontextformat));

            $feedbackxml = $format->getpath($part, ['#', 'feedback', 0], []);
            $question->feedback[$i] = $format->import_text_with_files($feedbackxml,
                        [], '', $format->get_format($question->questiontextformat));

            $feedbackxml = $format->getpath($part, ['#', 'correctfeedback', 0], []);
            $question->partcorrectfb[$i] = $format->import_text_with_files($feedbackxml,
                        [], '', $format->get_format($question->questiontextformat));
            $feedbackxml = $format->getpath($part, ['#', 'partiallycorrectfeedback', 0], []);
            $question->partpartiallycorrectfb[$i] = $format->import_text_with_files($feedbackxml,
                        [], '', $format->get_format($question->questiontextformat));
            $feedbackxml = $format->getpath($part, ['#', 'incorrectfeedback', 0], []);
            $question->partincorrectfb[$i] = $format->import_text_with_files($feedbackxml,
                        [], '', $format->get_format($question->questiontextformat));
        }

        // Make the defaultmark consistent if not specified.
        $question->defaultmark = array_sum($question->answermark);

        return $question;
    }

    /**
     * Exports the question to Moodle XML format.
     *
     * @param object $question question to be exported into XML format
     * @param qformat_xml $format format class exporting the question
     * @param object $extra extra information (not required for exporting this question in this format)
     * @return string containing the question data in XML format
     */
    public function export_to_xml($question, qformat_xml $format, $extra = null) {
        $output = '';
        $contextid = $question->contextid;
        $output .= $format->write_combined_feedback($question->options, $question->id, $question->contextid);

        // Get the extra fields we have for our question type. Drop the first entry, because
        // it contains the table name.
        $extraquestionfields = $this->extra_question_fields();
        array_shift($extraquestionfields);
        foreach ($extraquestionfields as $extrafield) {
            $output .= "<$extrafield>" . $format->writetext($question->options->$extrafield) . "</$extrafield>\n";
        }

        $fs = get_file_storage();
        foreach ($question->options->answers as $part) {
            $output .= "<answers>\n";
            $output .= " <partindex>\n  " . $format->writetext($part->partindex) . " </partindex>\n";

            foreach (self::PART_BASIC_FIELDS as $tag) {
                $output .= " <$tag>\n  " . $format->writetext($part->$tag) . " </$tag>\n";
            }

            $subqfiles = $fs->get_area_files($contextid, 'qtype_formulas', 'answersubqtext', $part->id);
            $subqtextformat = $format->get_format($part->subqtextformat);
            $output .= " <subqtext format=\"$subqtextformat\">\n";
            $output .= $format->writetext($part->subqtext);
            $output .= $format->write_files($subqfiles);
            $output .= " </subqtext>\n";

            $fbfiles = $fs->get_area_files($contextid, 'qtype_formulas', 'answerfeedback', $part->id);
            $feedbackformat = $format->get_format($part->feedbackformat);
            $output .= " <feedback format=\"$feedbackformat\">\n";
            $output .= $format->writetext($part->feedback);
            $output .= $format->write_files($fbfiles);
            $output .= " </feedback>\n";

            $fbfiles = $fs->get_area_files($contextid, 'qtype_formulas', 'partcorrectfb', $part->id);
            $feedbackformat = $format->get_format($part->partcorrectfbformat);
            $output .= " <correctfeedback format=\"$feedbackformat\">\n";
            $output .= $format->writetext($part->partcorrectfb);
            $output .= $format->write_files($fbfiles);
            $output .= " </correctfeedback>\n";

            $fbfiles = $fs->get_area_files($contextid, 'qtype_formulas', 'partpartiallycorrectfb', $part->id);
            $feedbackformat = $format->get_format($part->partpartiallycorrectfbformat);
            $output .= " <partiallycorrectfeedback format=\"$feedbackformat\">\n";
            $output .= $format->writetext($part->partpartiallycorrectfb);
            $output .= $format->write_files($fbfiles);
            $output .= " </partiallycorrectfeedback>\n";

            $fbfiles = $fs->get_area_files($contextid, 'qtype_formulas', 'partincorrectfb', $part->id);
            $feedbackformat = $format->get_format($part->partincorrectfbformat);
            $output .= " <incorrectfeedback format=\"$feedbackformat\">\n";
            $output .= $format->writetext($part->partincorrectfb);
            $output .= $format->write_files($fbfiles);
            $output .= " </incorrectfeedback>\n";

            $output .= "</answers>\n";
        }

        return $output;
    }

    /**
     * Check if part placeholders are correctly formatted and unique and if each
     * placeholder appears exactly once in the main question text.
     *
     * @param string $questiontext main question text
     * @param object[] $parts data relative to each part, coming from the edit form
     * @return array $errors possible error messages for each part's placeholder field
     */
    public function check_placeholders(string $questiontext, array $parts): array {
        // Store possible error messages for every part.
        $errors = [];

        // List of placeholders in order to spot duplicates.
        $knownplaceholders = [];

        foreach ($parts as $i => $part) {
            // No error if part's placeholder is empty.
            if (empty($part->placeholder)) {
                continue;
            }

            $errormsgs = [];

            // Maximal length for placeholders is limited to 40.
            if (strlen($part->placeholder) > 40) {
                $errormsgs[] = get_string('error_placeholder_too_long', 'qtype_formulas');
            }
            // Placeholders must start with # and contain only alphanumeric characters or underscores.
            if (!preg_match('/^#\w+$/', $part->placeholder) ) {
                $errormsgs[] = get_string('error_placeholder_format', 'qtype_formulas');
            }
            // Placeholders must be unique.
            if (in_array($part->placeholder, $knownplaceholders)) {
                $errormsgs[] = get_string('error_placeholder_sub_duplicate', 'qtype_formulas');
            }
            // Add this placeholder to the list of known values.
            $knownplaceholders[] = $part->placeholder;

            // Each placeholder must appear exactly once in the main question text.
            $count = substr_count($questiontext, "{{$part->placeholder}}");
            if ($count < 1) {
                $errormsgs[] = get_string('error_placeholder_missing', 'qtype_formulas');
            }
            if ($count > 1) {
                $errormsgs[] = get_string('error_placeholder_main_duplicate', 'qtype_formulas');
            }

            // Concatenate all error messages and store them, so they can be shown in the edit form.
            // The corresponding field's name is 'placeholder[...]', so we use that as the array key.
            if (!empty($errormsgs)) {
                $errors["placeholder[$i]"] = implode(' ', $errormsgs);
            }
        }

        // Return the errors. The array will be empty, if everything was fine.
        return $errors;
    }

    /**
     * For each part, check that all required fields have been filled and that they are valid.
     * Return the filtered data for all parts.
     *
     * @param object $data data from the edit form (or an import)
     * @return object stdClass with properties 'errors' (for errors) and 'parts' (array of stdClass, data for each part)
     */
    public function check_and_filter_parts(object $data): object {
        // This function is also called when importing a question.
        // The answers of imported questions already have their unitpenalty and ruleid set.
        $isfromimport = property_exists($data, 'unitpenalty') && property_exists($data, 'ruleid');

        $partdata = [];
        $errors = [];
        $hasoneanswer = false;

        foreach (array_keys($data->answermark) as $i) {
            // The answermark must not be empty or 0.
            $nomark = empty(trim($data->answermark[$i]));

            // For answers, zero is not nothing... Note that PHP < 8.0 does not consider '1 ' as numeric,
            // so we trim first. PHP 8.0+ makes no difference between leading or trailing whitespace.
            $noanswer = empty(trim($data->answer[$i])) && !is_numeric(trim($data->answer[$i]));
            if ($noanswer === false) {
                $hasoneanswer = true;
            }

            // For maximum backwards compatibility, we consider a part as being "empty", if
            // has no question text (subqtext), no general feedback (combined feedback was
            // probably not taken into account at first, because it was added later) and no
            // local vars.
            // Note that data from the editors is stored in an array with the keys text, format and itemid.
            // Also note that local vars are entered in a textarea (and not an editor) and are PARAM_RAW_TRIMMED.
            $noparttext = strlen(trim($data->subqtext[$i]['text'])) === 0;
            $nogeneralfb = strlen(trim($data->subqtext[$i]['text'])) === 0;
            $nolocalvars = strlen(trim($data->vars1[$i])) === 0;
            $emptypart = $noparttext && $nogeneralfb && $nolocalvars;

            // Having no answermark is only allowed if the part is "empty" AND if there is no answer.
            if ($nomark && !($emptypart && $noanswer)) {
                $errors["answermark[$i]"] = get_string('error_mark', 'qtype_formulas');
            }
            // On the other hand, having no answer is allowed for "empty" parts even if they
            // do have an answermark. We do this, because the answermark field is set by default when
            // the user clicks the "Blanks for 2 more parts" button. But if they do that by accident
            // and don't want those parts, they should not have to worry about them.
            if ($noanswer && !$emptypart) {
                $errors["answer[$i]"] = get_string('error_answer_missing', 'qtype_formulas');
            }

            // No need to validate the remainder of this part if there is no answer or no mark.
            if ($noanswer || $nomark) {
                continue;
            }

            // The mark must be strictly positive.
            if (floatval($data->answermark[$i]) <= 0) {
                $errors["answermark[$i]"] = get_string('error_mark', 'qtype_formulas');
            }

            // The grading criterion must not be empty. Also, if there is no grading criterion, it does
            // not make sense to continue the validation.
            if (empty(trim($data->correctness[$i])) && !is_numeric(trim($data->correctness[$i]))) {
                $errors["correctness[$i]"] = get_string('error_criterion_empty', 'qtype_formulas');
                continue;
            }

            // Create a stdClass for each part, start by setting the questionid property which is
            // common for all parts.
            $partdata[$i] = (object)['questionid' => $data->id];
            // Set the basic fields, e.g. mark, placeholder or definition of local variables.
            foreach (self::PART_BASIC_FIELDS as $field) {
                // In the edit form, the part's 'unitpenalty' and 'ruleid' are set via the global options
                // 'globalunitpenalty' and 'globalruleid'. When importing a question, they do not need
                // special treatment, because they are already stored with the part. Also, all other fields
                // are submitted by part and do not need special treatment either.
                if (in_array($field, ['ruleid', 'unitpenalty']) && !$isfromimport) {
                    $partdata[$i]->$field = trim($data->{'global' . $field});
                } else {
                    $partdata[$i]->$field = trim($data->{$field}[$i]);
                }
            }

            // The various texts are stored as arrays with the keys 'text', 'format' and (if coming from
            // the edit form) 'itemid'. We can just copy that over.
            $partdata[$i]->subqtext = $data->subqtext[$i];
            $partdata[$i]->feedback = $data->feedback[$i];
            $partdata[$i]->partcorrectfb = $data->partcorrectfb[$i];
            $partdata[$i]->partpartiallycorrectfb = $data->partpartiallycorrectfb[$i];
            $partdata[$i]->partincorrectfb = $data->partincorrectfb[$i];
        }

        // If no part has survived the validation, we need to output an error message. There are three
        // reasons why a part's validation can fail:
        // (a) there is no answermark
        // (b) there is no answer
        // (c) there is no grading criterion
        // If all parts are left empty, they will fail for case (a) and will not have an error message
        // attached to the answer field (answer can be empty if part is empty). In that case, we need
        // to output an error to the first answer field (and this one only) saying that at least one
        // answer is needed. We do not, however, add that error if the first part failed for case (b) and
        // thus already has an error message there.
        if (count($partdata) === 0 && $hasoneanswer === false) {
            if (empty($errors['answer[0]'])) {
                $errors['answer[0]'] = get_string('error_no_answer', 'qtype_formulas');
            }
            // If the answermark was left empty or filled with rubbish, the parameter filtering
            // will have changed the value to 0, which is not a valid value. If, in addition,
            // the part was otherwise empty, that will not have triggered an error message so far,
            // because it might have been on purpose (to delete the unused part). But now that
            // there seems to be no part left, we should add an error message to the field.
            if (empty($data->answermark[$i])) {
                $errors['answermark[0]'] = get_string('error_mark', 'qtype_formulas');
            }
        }

        return (object)['errors' => $errors, 'parts' => $partdata];
    }

    /**
     * Check the data from the edit form (or an XML import): parts, answer box placeholders,
     * part placeholders and definitions of variables and expressions. At the same time, calculate
     * the number of expected answers for every part.
     *
     * @param object $data
     * @return object
     */
    public function validate(object $data): object {
        // Collect all error messages in an associative array of the form 'fieldname' => 'error'.
        $errors = [];

        // The fields 'globalunitpenalty' and 'globalruleid' must be validated separately,
        // because they are defined at the question level, even though they affect the parts.
        // If we are importing a question, those fields will not be present, because the values
        // are already stored with the parts.
        // Note: we validate this first, because the fields will be referenced during validation
        // of the parts.
        $isfromimport = property_exists($data, 'unitpenalty') && property_exists($data, 'ruleid');
        if (!$isfromimport) {
            $errors += $this->validate_global_unit_fields($data);
        }

        // Check the parts. We get a stdClass with the properties 'errors' (a possibly empty array)
        // and 'parts' (an array of stdClass objects, one per part).
        $partcheckresult = $this->check_and_filter_parts($data);
        $errors += $partcheckresult->errors;

        // If the basic check failed, we abort and output the error message, because the errors
        // might cause other errors downstream.
        if (!empty($errors)) {
            return (object)['errors' => $errors, 'answers' => null];
        }

        // From now on, we continue with the checked and filtered parts.
        $parts = $partcheckresult->parts;

        // Make sure that answer box placeholders (if used) are unique for each part.
        foreach ($parts as $i => $part) {
            try {
                qtype_formulas_part::scan_for_answer_boxes($part->subqtext['text'], true);
            } catch (Exception $e) {
                $errors["subqtext[$i]"] = $e->getMessage();
            }
        }

        // Separately validate the part placeholders. If we are importing, the question text
        // will be a string. If the data comes from the edit from, it is in the editor's
        // array structure (text, format, itemid).
        $errors += $this->check_placeholders(
            is_array($data->questiontext) ? $data->questiontext['text'] : $data->questiontext,
            $parts
        );

        // Finally, check definition of variables (local, grading), various expressions
        // depending on those variables (model answers, correctness criterion) and unit
        // stuff. This check also allows us to calculate the number of answers for each part,
        // a value that we store as 'numbox'.
        $evaluationresult = $this->check_variables_and_expressions($data, $parts, $isfromimport);
        $errors += $evaluationresult->errors;
        $parts = $evaluationresult->parts;

        return (object)['errors' => $errors, 'answers' => $parts];
    }

    /**
     * This function is called during the validation process to validate the special fields
     * 'globalunitpenalty' and 'globalruleid'. Both fields are used as a single option to set
     * the unit penalty and the unit conversion rules for all parts of a question.
     *
     * @param object $data form data to be validated
     * @return array array containing error messages or empty array if no error
     */
    private function validate_global_unit_fields(object $data): array {
        $errors = [];

        if ($data->globalunitpenalty < 0 || $data->globalunitpenalty > 1) {
            $errors['globalunitpenalty'] = get_string('error_unitpenalty', 'qtype_formulas');;
        }

        // If the globalruleid field is missing, that means the request or the form has
        // been modified by the user. In that case, we set the id to the invalid value -1
        // to simplify the code for the upcoming steps.
        if (!isset($data->globalruleid)) {
            $data->globalruleid = -1;
        }

        // Finally, check the global setting for the basic conversion rules. We only check this
        // once, because it is the same for all parts.
        $conversionrules = new unit_conversion_rules();
        $entry = $conversionrules->entry($data->globalruleid);
        if ($entry === null || $entry[1] === null) {
            $errors['globalruleid'] = get_string('error_ruleid', 'qtype_formulas');
        } else {
            $unitcheck = new answer_unit_conversion();
            $unitcheck->assign_default_rules($data->globalruleid, $entry[1]);
            try {
                $unitcheck->reparse_all_rules();
            } catch (Exception $e) {
                // This can only happen if the user has modified (and screwed up) conversion_rules.php.
                // TODO: When refactoring the unit stuff, user-defined rules must be written via the
                // settings page and validated there, the user should not be forced to modify the PHP files,
                // also because they will be overwritten on every update.
                $errors['globalruleid'] = $e->getMessage();
            }
        }

        return $errors;
    }

    /**
     * Check definition of variables (local vars, grading vars), various expressions
     * like model answers or correctness criterion and unit stuff. At the same time,
     * calculate the number of answers boxes (to be stored in part->numbox) once the
     * model answers are evaluated. Possible errors are returned in the 'errors' property
     * of the return object. The updated part data (now containing the numbox value)
     * is in the 'parts' property, as an array of objects (one object per part).
     *
     * @param object $data
     * @param object[] $parts
     * @param bool $fromimport whether the check is performed during an import process
     * @return object stdClass with 'errors' and 'parts'
     */
    public function check_variables_and_expressions(object $data, array $parts, bool $fromimport = false): object {
        // Collect all errors.
        $errors = [];

        // Check random variables. If there is an error, we do not continue, because
        // other variables or answers might depend on these definitions.
        try {
            $randomparser = new random_parser($data->varsrandom);
            $evaluator = new evaluator();
            $evaluator->evaluate($randomparser->get_statements());
            $evaluator->instantiate_random_variables();
        } catch (Exception $e) {
            $errors['varsrandom'] = $e->getMessage();
            return (object)['errors' => $errors, 'parts' => $parts];
        }

        // Check global variables. If there is an error, we do not continue, because
        // other variables or answers might depend on these definitions.
        try {
            $globalparser = new parser($data->varsglobal, $randomparser->export_known_variables());
            $evaluator->evaluate($globalparser->get_statements());
        } catch (Exception $e) {
            $errors['varsglobal'] = $e->getMessage();
            return (object)['errors' => $errors, 'parts' => $parts];
        }

        // Check local variables, model answers and grading criterion for each part.
        foreach ($parts as $i => $part) {
            $partevaluator = clone $evaluator;
            $knownvars = $partevaluator->export_variable_list();

            // Validate the local variables for this part. In case of an error, skip the
            // rest of the part, because there might be dependencies.
            $partparser = null;
            if (!empty($part->vars1)) {
                try {
                    $partparser = new parser($part->vars1, $knownvars);
                    $partevaluator->evaluate($partparser->get_statements());
                } catch (Exception $e) {
                    $errors["vars1[$i]"] = $e->getMessage();
                    continue;
                }
            }

            // If there were no local variables, the partparser has not been initialized yet.
            // Otherwise, we export its known variables.
            if ($partparser !== null) {
                $knownvars = $partparser->export_known_variables();
            }

            // Check whether the part uses the algebraic answer type.
            $isalgebraic = $part->answertype == self::ANSWER_TYPE_ALGEBRAIC;

            // Try evaluating the model answers. If this fails, don't validate the rest of
            // this part, because there are dependencies.
            try {
                // If (and only if) the answer is algebraic, the answer parser should
                // interpret ^ as **. The last argument tells the answer parser that we are
                // checking model answers, i. e. the prefix operator is allowed.
                $answerparser = new answer_parser($part->answer, $knownvars, $isalgebraic, true);
                // If the user enters a comment sign in the model answer, it is not technically empty,
                // but it will be parsed as an empty expression. We catch this here and make use of
                // the catch block to pass an error message.
                if (empty($answerparser->get_statements())) {
                    throw new Exception(get_string('error_model_answer_no_content', 'qtype_formulas'));
                }
                $modelanswers = $partevaluator->evaluate($answerparser->get_statements())[0];
            } catch (Exception $e) {
                // If the answer type is algebraic, the model answer field must contain one string (with quotes)
                // or an array of strings. Thus, evaluation of the field's content as done above cannot fail,
                // unless that syntax constraint has not been respected by the user.
                if ($isalgebraic) {
                    $errors["answer[$i]"] = get_string('error_string_for_algebraic_formula', 'qtype_formulas');
                } else {
                    $errors["answer[$i]"] = $e->getMessage();
                }
                continue;
            }

            // Check the model answer. If it is a LIST, make an array out of the individual tokens. If it is
            // a single token, wrap it into a single-element array.
            // Note: If we have e.g. the (global or local) variable 'a=[1,2,3]' and the answer is 'a',
            // this will be considered as three answers 1, 2 and 3. We must maintain that interpretation
            // for backwards compatibility.
            if ($modelanswers->type === token::LIST) {
                $modelanswers = $modelanswers->value;
            } else {
                $modelanswers = [$modelanswers];
            }

            // As $modelanswers is now an array, we can iterate over all answers. If the answer type is
            // "algebraic formula", they must all be strings. Otherwise, they must all be numbers or
            // at least numeric strings.
            foreach ($modelanswers as $answer) {
                if ($isalgebraic && ($answer->type !== token::STRING && $answer->type !== token::EMPTY)) {
                    $errors["answer[$i]"] = get_string('error_string_for_algebraic_formula', 'qtype_formulas');
                    continue;
                }
                if (!$isalgebraic && !($answer->type === token::EMPTY || $answer->type === token::NUMBER || is_numeric($answer->value))) {
                    $errors["answer[$i]"] = get_string('error_number_for_numeric_answertypes', 'qtype_formulas');
                    continue;
                }
            }
            // Finally, we convert the array of tokens into an array of literals.
            // FIXME: remove this
            // $modelanswers = token::unpack($modelanswers);

            // Now that we know the model answers, we can set the $numbox property for the part,
            // i. e. the number of answer boxes that are to be shown.
            $part->numbox = count($modelanswers);

            // If the answer type is algebraic, we must now try to do algebraic evaluation of each answer
            // to check for bad formulas.
            if ($isalgebraic) {
                foreach ($modelanswers as $k => $answertoken) {
                    // If it is the $EMPTY token, we have nothing to do.
                    if ($answertoken->type === token::EMPTY) {
                        continue;
                    }
                    // Evaluating the string should give us a numeric value.
                    try {
                        $result = $partevaluator->calculate_algebraic_expression($answertoken->value);
                    } catch (Exception $e) {
                        $a = (object)[
                            // Answers are zero-indexed, but users normally count from 1.
                            'answerno' => $k + 1,
                            // The error message may contain line and column numbers, but they don't make
                            // sense in this context, so we'd rather remove them.
                            'message' => preg_replace('/([^:]+:)([^:]+:)/', '', $e->getMessage()),
                        ];
                        $errors["answer[$i]"] = get_string('error_in_answer', 'qtype_formulas', $a);
                        break;
                    }
                }
            }

            // If there was an error, we do not continue the validation, because the answers are going to
            // be used for the next steps.
            if (!empty($errors["answer[$i]"])) {
                continue;
            }

            // In order to prepare the grading variables, we need to have the special vars like
            // _a and _r or _0, _1, ... or _err and _relerr. We will create a dummy part and use it
            // as our worker. Note that the result will automatically flow back into $partevaluator,
            // because the assignment is by reference only.
            $dummypart = new qtype_formulas_part();
            $dummypart->answertype = $part->answertype;
            $dummypart->answer = $part->answer;
            $dummypart->evaluator = $partevaluator;
            try {
                // As we are using the model answers, we must set the third parameter to TRUE, because
                // there might be a PREFIX operator. This is important for answer type algebraic formula.
                $dummypart->add_special_variables($dummypart->get_evaluated_answers(), 1, true);
            } catch (Throwable $e) {
                // If the last step failed (e. g. because the model answer to an algebraic formula question
                // contained a PREFIX operator), we attach the message to the answer field and stop
                // further validation steps.
                $errors["answer[$i]"] = $e->getMessage();
                continue;
            }

            // Validate grading variables.
            if (!empty($part->vars2)) {
                try {
                    $partparser = new parser($part->vars2, $knownvars);
                    $partevaluator->evaluate($partparser->get_statements());
                } catch (Exception $e) {
                    $errors["vars2[$i]"] = $e->getMessage();
                    continue;
                }

                // Update the list of known variables.
                $knownvars = $partparser->export_known_variables();
            }

            // Check grading criterion.
            $grade = 0;
            try {
                $partparser = new parser($part->correctness, $knownvars);
                $result = $partevaluator->evaluate($partparser->get_statements());
                $num = count($result);
                if ($num > 1) {
                    $errors["correctness[$i]"] = get_string('error_grading_single_expression', 'qtype_formulas', $num);
                }
                $grade = $result[0]->value;
            } catch (Exception $e) {
                $message = $e->getMessage();
                // If we are working with the answer type "algebraic formula" and there was an error
                // during evaluation of the grading criterion *and* the error message contains '_relerr',
                // we change the message, because it is save to assume that the teacher tried to use
                // relative error which is not supported with that answer type.
                if ($isalgebraic && strpos($message, '_relerr') !== false) {
                    $message = get_string('error_algebraic_relerr', 'qtype_formulas');
                }
                $errors["correctness[$i]"] = $message;
                continue;
            }

            // We used the model answers, so the grading criterion should always evaluate to 1 (or more).
            // This check is omitted when importing questions, because it did not exist in legacy versions,
            // so teachers might have questions with "wrong" model answers and their import will fail.
            $lenientimport = get_config('qtype_formulas', 'lenientimport');
            $checkthis = !$lenientimport || !$fromimport;
            if ($checkthis && $grade < 0.999) {
                $errors["correctness[$i]"] = get_string('error_grading_not_one', 'qtype_formulas', $grade);
            }

            // Instantiate toolkit class for units.
            $unitcheck = new answer_unit_conversion();

            // If a unit has been provided, check whether it can be parsed.
            if (!empty($part->postunit)) {
                try {
                    $unitcheck->parse_targets($part->postunit);
                } catch (Exception $e) {
                    $errors["postunit[$i]"] = get_string('error_unit', 'qtype_formulas');
                }
            }

            // If provided by the user, check the additional conversion rules. We do validate those
            // rules even if the unit has not been set, because we would not want to have invalid stuff
            // in the database.
            if (!empty($part->otherrule)) {
                try {
                    $unitcheck->assign_additional_rules($part->otherrule);
                    $unitcheck->reparse_all_rules();
                } catch (Exception $e) {
                    $errors["otherrule[$i]"] = get_string('error_rule', 'qtype_formulas');
                }
            }
        }

        return (object)['errors' => $errors, 'parts' => $parts];
    }

    /**
     * Reorder the parts according to the order of placeholders in main question text.
     * Note: the check_placeholder() function should be called before.
     *
     * @param string $questiontext main question text, containing the placeholders
     * @param object[] $parts part data
     * @return object[] sorted parts
     */
    public function reorder_parts(string $questiontext, array $parts): array {
        // Scan question text for part placeholders; $matches[1] will contain a list of
        // the matches in the order of appearance.
        $matches = [];
        preg_match_all('/\{(#\w+)\}/', $questiontext, $matches);

        $ordered = [];

        // First, add the parts with a placeholder, ordered by their appearance.
        foreach ($parts as $part) {
            $newindex = array_search($part->placeholder, $matches[1]);
            if ($newindex !== false) {
                $ordered[$newindex] = $part;
            }
        }

        // Now, append all remaining parts that do not have a placeholder.
        foreach ($parts as $part) {
            if (empty($part->placeholder)) {
                $ordered[] = $part;
            }
        }

        // Sort the parts by their index and assign result.
        ksort($ordered);

        return $ordered;
    }

    /**
     * Similar to Moodle's format_float() function, this function will output a float number
     * with the locale's decimal separator. It checks the admin setting (allowdecimalcomma)
     * before doing so; if the decimal comma is not activated, the point will be used in
     * all cases. We are not using the library function, because it can lead to unnecessary
     * trailing zeroes. When using the function for LaTeX output, it will wrap the comma in
     * curly braces for correct spacing.
     *
     * @param float|string $float a number or numeric string to be formatted
     * @param bool $forlatex whether the output is for LaTeX code
     * @return string
     */
    public static function format_float($float, bool $forlatex = false): string {
        // If use of decimal comma (or other local decimal separator) is not allowed, we
        // return the number as-is.
        if (!get_config('qtype_formulas', 'allowdecimalcomma')) {
            return strval($float);
        }

        // Get the correct decimal separator according to the user's locale. If necessary,
        // put braces around it.
        $decsep = get_string('decsep', 'langconfig');
        if ($forlatex && $decsep === ',') {
            $decsep = '{' . $decsep . '}';
        }

        return str_replace('.', $decsep, strval($float));
    }
}

FormulasQuestion / moodle-qtype_formulas / 17019138792

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous