• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

randombit / botan / 17010254744

16 Aug 2025 11:53AM UTC coverage: 90.654% (+0.006%) from 90.648%
17010254744

push

github

web-flow
Merge pull request #5060 from randombit/jack/tidy-aarch64-code

Fix various clang-tidy warnings in aarch64 specific code

100084 of 110402 relevant lines covered (90.65%)

12127747.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.64
/src/lib/utils/socket/socket_udp.cpp
1
/*
2
* (C) 2015,2016,2017 Jack Lloyd
3
* (C) 2016 Daniel Neus
4
* (C) 2019 Nuno Goncalves <nunojpg@gmail.com>
5
*
6
* Botan is released under the Simplified BSD License (see license.txt)
7
*/
8

9
#include <botan/internal/socket_udp.h>
10

11
#include <botan/exceptn.h>
12
#include <botan/mem_ops.h>
13
#include <botan/internal/fmt.h>
14
#include <botan/internal/target_info.h>
15
#include <botan/internal/uri.h>
16
#include <chrono>
17

18
#if defined(BOTAN_HAS_BOOST_ASIO)
19
   /*
20
   * We don't need serial port support anyway, and asking for it
21
   * causes macro conflicts with Darwin's termios.h when this
22
   * file is included in the amalgamation. GH #350
23
   */
24
   #define BOOST_ASIO_DISABLE_SERIAL_PORT
25
   #include <boost/asio.hpp>
26
   #include <boost/asio/system_timer.hpp>
27
#elif defined(BOTAN_TARGET_OS_HAS_SOCKETS)
28
   #include <errno.h>
29
   #include <fcntl.h>
30
   #include <netdb.h>
31
   #include <netinet/in.h>
32
   #include <string.h>
33
   #include <sys/socket.h>
34
   #include <sys/time.h>
35
   #include <unistd.h>
36

37
#elif defined(BOTAN_TARGET_OS_HAS_WINSOCK2)
38
   #include <ws2tcpip.h>
39
#endif
40

41
namespace Botan {
42

43
namespace {
44

45
#if defined(BOTAN_HAS_BOOST_ASIO)
46
class Asio_SocketUDP final : public OS::SocketUDP {
×
47
   public:
48
      Asio_SocketUDP(std::string_view hostname, std::string_view service, std::chrono::microseconds timeout) :
6✔
49
            m_timeout(timeout), m_timer(m_io), m_udp(m_io) {
12✔
50
         m_timer.expires_after(m_timeout);
6✔
51
         check_timeout();
6✔
52

53
         boost::asio::ip::udp::resolver resolver(m_io);
6✔
54
         boost::asio::ip::udp::resolver::results_type dns_iter =
6✔
55
            resolver.resolve(std::string{hostname}, std::string{service});
18✔
56

57
         boost::system::error_code ec = boost::asio::error::would_block;
6✔
58

59
         auto connect_cb = [&ec](const boost::system::error_code& e,
12✔
60
                                 const boost::asio::ip::udp::resolver::results_type::iterator&) { ec = e; };
6✔
61

62
         boost::asio::async_connect(m_udp, dns_iter.begin(), dns_iter.end(), connect_cb);
12✔
63

64
         while(ec == boost::asio::error::would_block) {
12✔
65
            m_io.run_one();
6✔
66
         }
67

68
         if(ec) {
6✔
69
            throw boost::system::system_error(ec);
×
70
         }
71
         if(!m_udp.is_open()) {
6✔
72
            throw System_Error(fmt("Connection to host {} failed", hostname));
×
73
         }
74
      }
6✔
75

76
      void write(const uint8_t buf[], size_t len) override {
6✔
77
         m_timer.expires_after(m_timeout);
6✔
78

79
         boost::system::error_code ec = boost::asio::error::would_block;
6✔
80

81
         m_udp.async_send(boost::asio::buffer(buf, len), [&ec](boost::system::error_code e, size_t) { ec = e; });
12✔
82

83
         while(ec == boost::asio::error::would_block) {
18✔
84
            m_io.run_one();
12✔
85
         }
86

87
         if(ec) {
6✔
88
            throw boost::system::system_error(ec);
×
89
         }
90
      }
6✔
91

92
      size_t read(uint8_t buf[], size_t len) override {
6✔
93
         m_timer.expires_after(m_timeout);
6✔
94

95
         boost::system::error_code ec = boost::asio::error::would_block;
6✔
96
         size_t got = 0;
6✔
97

98
         m_udp.async_receive(boost::asio::buffer(buf, len), [&](boost::system::error_code cb_ec, size_t cb_got) {
6✔
99
            ec = cb_ec;
6✔
100
            got = cb_got;
6✔
101
         });
102

103
         while(ec == boost::asio::error::would_block) {
20✔
104
            m_io.run_one();
14✔
105
         }
106

107
         if(ec) {
6✔
108
            if(ec == boost::asio::error::eof) {
×
109
               return 0;
110
            }
111
            throw boost::system::system_error(ec);  // Some other error.
×
112
         }
113

114
         return got;
6✔
115
      }
116

117
   private:
118
      void check_timeout() {
18✔
119
         if(m_udp.is_open() && m_timer.expiry() < std::chrono::system_clock::now()) {
18✔
120
            boost::system::error_code err;
×
121

122
            // NOLINTNEXTLINE(bugprone-unused-return-value,cert-err33-c)
123
            m_udp.close(err);
×
124
         }
125

126
         // NOLINTNEXTLINE(*-avoid-bind) FIXME - unclear why we can't use a lambda here
127
         m_timer.async_wait(std::bind(&Asio_SocketUDP::check_timeout, this));
18✔
128
      }
18✔
129

130
      const std::chrono::microseconds m_timeout;
131
      boost::asio::io_context m_io;
132
      boost::asio::system_timer m_timer;
133
      boost::asio::ip::udp::socket m_udp;
134
};
135
#elif defined(BOTAN_TARGET_OS_HAS_SOCKETS) || defined(BOTAN_TARGET_OS_HAS_WINSOCK2)
136
class BSD_SocketUDP final : public OS::SocketUDP {
137
   public:
138
      BSD_SocketUDP(std::string_view hostname, std::string_view service, std::chrono::microseconds timeout) :
139
            m_timeout(timeout), m_socket(invalid_socket()) {
140
         socket_init();
141

142
         addrinfo* res = nullptr;
143
         addrinfo hints{};
144
         hints.ai_family = AF_UNSPEC;
145
         hints.ai_socktype = SOCK_DGRAM;
146

147
         const std::string hostname_str(hostname);
148
         const std::string service_str(service);
149

150
         int rc = ::getaddrinfo(hostname_str.c_str(), service_str.c_str(), &hints, &res);
151

152
         if(rc != 0) {
153
            throw System_Error(fmt("Name resolution failed for {}", hostname), rc);
154
         }
155

156
         for(addrinfo* rp = res; (m_socket == invalid_socket()) && (rp != nullptr); rp = rp->ai_next) {
157
            if(rp->ai_family != AF_INET && rp->ai_family != AF_INET6) {
158
               continue;
159
            }
160

161
            m_socket = ::socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
162

163
            if(m_socket == invalid_socket()) [[unlikely]] {
164
               // unsupported socket type?
165
               continue;
166
            }
167

168
            set_nonblocking(m_socket);
169
            memcpy(&sa, res->ai_addr, res->ai_addrlen);
170
            salen = static_cast<socklen_t>(res->ai_addrlen);  // NOLINT(*-redundant-casting)
171
         }
172

173
         ::freeaddrinfo(res);
174

175
         if(m_socket == invalid_socket()) {
176
            throw System_Error(fmt("Connecting to {} for service {} failed with errno {}", hostname, service, errno),
177
                               errno);
178
         }
179
      }
180

181
      ~BSD_SocketUDP() override {
182
         close_socket(m_socket);
183
         m_socket = invalid_socket();
184
         socket_fini();
185
      }
186

187
      BSD_SocketUDP(const BSD_SocketUDP& other) = delete;
188
      BSD_SocketUDP(BSD_SocketUDP&& other) = delete;
189
      BSD_SocketUDP& operator=(const BSD_SocketUDP& other) = delete;
190
      BSD_SocketUDP& operator=(BSD_SocketUDP&& other) = delete;
191

192
      void write(const uint8_t buf[], size_t len) override {
193
         fd_set write_set;
194
         FD_ZERO(&write_set);
195
         FD_SET(m_socket, &write_set);
196

197
         size_t sent_so_far = 0;
198
         while(sent_so_far != len) {
199
            struct timeval timeout = make_timeout_tv();
200
            int active = ::select(static_cast<int>(m_socket + 1), nullptr, &write_set, nullptr, &timeout);
201

202
            if(active == 0) {
203
               throw System_Error("Timeout during socket write");
204
            }
205

206
            const size_t left = len - sent_so_far;
207
            socket_op_ret_type sent = ::sendto(m_socket,
208
                                               cast_uint8_ptr_to_char(buf + sent_so_far),
209
                                               static_cast<sendrecv_len_type>(left),
210
                                               0,
211
                                               reinterpret_cast<sockaddr*>(&sa),
212
                                               salen);
213
            if(sent < 0) {
214
               throw System_Error("Socket write failed", errno);
215
            } else {
216
               sent_so_far += static_cast<size_t>(sent);
217
            }
218
         }
219
      }
220

221
      size_t read(uint8_t buf[], size_t len) override {
222
         fd_set read_set;
223
         FD_ZERO(&read_set);
224
         FD_SET(m_socket, &read_set);
225

226
         struct timeval timeout = make_timeout_tv();
227
         int active = ::select(static_cast<int>(m_socket + 1), &read_set, nullptr, nullptr, &timeout);
228

229
         if(active == 0) {
230
            throw System_Error("Timeout during socket read");
231
         }
232

233
         socket_op_ret_type got =
234
            ::recvfrom(m_socket, cast_uint8_ptr_to_char(buf), static_cast<sendrecv_len_type>(len), 0, nullptr, nullptr);
235

236
         if(got < 0) {
237
            throw System_Error("Socket read failed", errno);
238
         }
239

240
         return static_cast<size_t>(got);
241
      }
242

243
   private:
244
   #if defined(BOTAN_TARGET_OS_HAS_WINSOCK2)
245
      typedef SOCKET socket_type;
246
      typedef int socket_op_ret_type;
247
      typedef int sendrecv_len_type;
248

249
      static socket_type invalid_socket() { return INVALID_SOCKET; }
250

251
      static void close_socket(socket_type s) { ::closesocket(s); }
252

253
      static std::string get_last_socket_error() { return std::to_string(::WSAGetLastError()); }
254

255
      static bool nonblocking_connect_in_progress() { return (::WSAGetLastError() == WSAEWOULDBLOCK); }
256

257
      static void set_nonblocking(socket_type s) {
258
         u_long nonblocking = 1;
259
         ::ioctlsocket(s, FIONBIO, &nonblocking);
260
      }
261

262
      static void socket_init() {
263
         WSAData wsa_data;
264
         WORD wsa_version = MAKEWORD(2, 2);
265

266
         if(::WSAStartup(wsa_version, &wsa_data) != 0) {
267
            throw System_Error("WSAStartup() failed", WSAGetLastError());
268
         }
269

270
         if(LOBYTE(wsa_data.wVersion) != 2 || HIBYTE(wsa_data.wVersion) != 2) {
271
            ::WSACleanup();
272
            throw System_Error("Could not find a usable version of Winsock.dll");
273
         }
274
      }
275

276
      static void socket_fini() { ::WSACleanup(); }
277
   #else
278
      typedef int socket_type;
279
      typedef ssize_t socket_op_ret_type;
280
      typedef size_t sendrecv_len_type;
281

282
      static socket_type invalid_socket() { return -1; }
283

284
      static void close_socket(socket_type s) { ::close(s); }
285

286
      static std::string get_last_socket_error() { return ::strerror(errno); }
287

288
      static bool nonblocking_connect_in_progress() { return (errno == EINPROGRESS); }
289

290
      static void set_nonblocking(socket_type s) {
291
         // NOLINTNEXTLINE(*-vararg)
292
         if(::fcntl(s, F_SETFL, O_NONBLOCK) < 0) {
293
            throw System_Error("Setting socket to non-blocking state failed", errno);
294
         }
295
      }
296

297
      static void socket_init() {}
298

299
      static void socket_fini() {}
300
   #endif
301
      sockaddr_storage sa = {};
302
      socklen_t salen;
303

304
      struct timeval make_timeout_tv() const {
305
         struct timeval tv {};
306

307
         tv.tv_sec = static_cast<decltype(timeval::tv_sec)>(m_timeout.count() / 1000000);
308
         tv.tv_usec = static_cast<decltype(timeval::tv_usec)>(m_timeout.count() % 1000000);
309
         return tv;
310
      }
311

312
      const std::chrono::microseconds m_timeout;
313
      socket_type m_socket;
314
};
315
#endif
316
}  // namespace
317

318
std::unique_ptr<OS::SocketUDP> OS::open_socket_udp(std::string_view hostname,
6✔
319
                                                   std::string_view service,
320
                                                   std::chrono::microseconds timeout) {
321
#if defined(BOTAN_HAS_BOOST_ASIO)
322
   return std::make_unique<Asio_SocketUDP>(hostname, service, timeout);
6✔
323
#elif defined(BOTAN_TARGET_OS_HAS_SOCKETS) || defined(BOTAN_TARGET_OS_HAS_WINSOCK2)
324
   return std::make_unique<BSD_SocketUDP>(hostname, service, timeout);
325
#else
326
   BOTAN_UNUSED(hostname);
327
   BOTAN_UNUSED(service);
328
   BOTAN_UNUSED(timeout);
329
   return std::unique_ptr<OS::SocketUDP>();
330
#endif
331
}
332

333
std::unique_ptr<OS::SocketUDP> OS::open_socket_udp(std::string_view uri_string, std::chrono::microseconds timeout) {
6✔
334
   const auto uri = URI::from_any(uri_string);
6✔
335
   if(uri.port() == 0) {
6✔
336
      throw Invalid_Argument("UDP port not specified");
×
337
   }
338
   return open_socket_udp(uri.host(), std::to_string(uri.port()), timeout);
12✔
339
}
6✔
340

341
}  // namespace Botan
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc