16935267080

Committed 13 Aug 2025 11:00AM UTC coverage: 24.312% (-63.3%) from 87.658%

Build # 16935267080

Build Type

Pull #4226

github

Committed by

web-flow

Commit Message

Merge 81b48c7fb into baa6ea202

Pull Request Pull Request #4226: Support converting TimestampTZ to and from duckdb

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

20666 existing lines in 469 files now uncovered.

8726 of 35892 relevant lines covered (24.31%)

147.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.71

/vortex-expr/src/forms/extract_conjuncts.rs

// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use crate::{BinaryVTable, ExprRef};

/// Converting an expression to a conjunctive normal form can lead to a large number of expression
/// nodes.
/// For now, we will just extract the conjuncts from the expression, and return a vector of conjuncts.
/// We could look at try cnf with a size cap and otherwise return the original conjuncts.
pub fn conjuncts(expr: &ExprRef) -> Vec<ExprRef> {
    let mut conjuncts = vec![];
    conjuncts_impl(expr, &mut conjuncts);
    if conjuncts.is_empty() {
        conjuncts.push(expr.clone());
    }
    conjuncts
}

fn conjuncts_impl(expr: &ExprRef, conjuncts: &mut Vec<ExprRef>) {
    if let Some(expr) = expr.as_opt::<BinaryVTable>()
        && expr.op() == crate::Operator::And
    {
        conjuncts_impl(expr.lhs(), conjuncts);
        conjuncts_impl(expr.rhs(), conjuncts);
    } else {
        conjuncts.push(expr.clone())
    }
}

1	// SPDX-License-Identifier: Apache-2.0
2	// SPDX-FileCopyrightText: Copyright the Vortex contributors
3
4	use crate::{BinaryVTable, ExprRef};
5
6	/// Converting an expression to a conjunctive normal form can lead to a large number of expression
7	/// nodes.
8	/// For now, we will just extract the conjuncts from the expression, and return a vector of conjuncts.
9	/// We could look at try cnf with a size cap and otherwise return the original conjuncts.
10	pub fn conjuncts(expr: &ExprRef) -> Vec<ExprRef> {	28✔
11	let mut conjuncts = vec![];	28✔
12	conjuncts_impl(expr, &mut conjuncts);	28✔
13	if conjuncts.is_empty() {	28✔
14	conjuncts.push(expr.clone());	×
15	}	28✔
16	conjuncts	28✔
17	}	28✔
18
19	fn conjuncts_impl(expr: &ExprRef, conjuncts: &mut Vec<ExprRef>) {	28✔
20	if let Some(expr) = expr.as_opt::<BinaryVTable>()	28✔
UNCOV 21	&& expr.op() == crate::Operator::And	×
UNCOV 22	{	×
UNCOV 23	conjuncts_impl(expr.lhs(), conjuncts);	×
UNCOV 24	conjuncts_impl(expr.rhs(), conjuncts);	×
UNCOV 25	} else {	×
26	conjuncts.push(expr.clone())	28✔
27	}
28	}	28✔

vortex-data / vortex / 16935267080

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous