#4658

Committed 09 Aug 2025 02:19PM UTC coverage: 59.866% (-1.3%) from 61.2%

Build # #4658

Build Type

push

travis-ci

Committed by GitHub

Commit Message

fix(stream)[TD-37079]: force close the last window in fill_history (#32436)

Run Details

137251 of 291849 branches covered (47.03%)

Branch coverage included in aggregate %.

207628 of 284239 relevant lines covered (73.05%)

4861547.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.85

/source/dnode/vnode/src/tsdb/tsdbOpen.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "meta.h"
#include "tsdb.h"
#include "tsdbFS2.h"

extern int32_t tsdbOpenCompMonitor(STsdb *tsdb);
extern void    tsdbCloseCompMonitor(STsdb *tsdb);
extern int32_t tsdbOpenSsMigrateMonitor(STsdb *tsdb);
extern void    tsdbCloseSsMigrateMonitor(STsdb *tsdb);

void tsdbSetKeepCfg(STsdb *pTsdb, STsdbCfg *pCfg) {
  STsdbKeepCfg *pKeepCfg = &pTsdb->keepCfg;
  pKeepCfg->precision = pCfg->precision;
  pKeepCfg->days = pCfg->days;
  pKeepCfg->keep0 = pCfg->keep0;
  pKeepCfg->keep1 = pCfg->keep1;
  pKeepCfg->keep2 = pCfg->keep2;
  pKeepCfg->keepTimeOffset = pCfg->keepTimeOffset;
}

int64_t tsdbGetEarliestTs(STsdb *pTsdb) {
  STsdbKeepCfg *pCfg = &pTsdb->keepCfg;

  int64_t now = taosGetTimestamp(pCfg->precision);
  int64_t ts = now - (tsTickPerMin[pCfg->precision] * pCfg->keep2) + 1;  // needs to add one tick
  return ts;
}

int32_t tsdbOpen(SVnode *pVnode, STsdb **ppTsdb, const char *dir, STsdbKeepCfg *pKeepCfg, int8_t rollback, bool force) {
  STsdb  *pTsdb = NULL;
  int     slen = 0;
  int32_t code;
  int32_t lino;

  *ppTsdb = NULL;
  slen = strlen(pVnode->path) + strlen(dir) + 2;

  // create handle
  pTsdb = (STsdb *)taosMemoryCalloc(1, sizeof(*pTsdb) + slen);
  if (pTsdb == NULL) {
    TAOS_CHECK_RETURN(terrno);
  }

  pTsdb->path = (char *)&pTsdb[1];
  (void)snprintf(pTsdb->path, TD_PATH_MAX, "%s%s%s", pVnode->path, TD_DIRSEP, dir);
  (void)snprintf(pTsdb->name, sizeof(pTsdb->name), "%s", dir);
  // taosRealPath(pTsdb->path, NULL, slen);
  pTsdb->pVnode = pVnode;
  (void)taosThreadMutexInit(&pTsdb->mutex, NULL);
  if (!pKeepCfg) {
    tsdbSetKeepCfg(pTsdb, &pVnode->config.tsdbCfg);
  } else {
    memcpy(&pTsdb->keepCfg, pKeepCfg, sizeof(STsdbKeepCfg));
  }

  // create dir
  if (!pVnode->mounted) {
    if (pVnode->pTfs) {
      code = tfsMkdir(pVnode->pTfs, pTsdb->path);
      TSDB_CHECK_CODE(code, lino, _exit);
    } else {
      code = taosMkDir(pTsdb->path);
      TSDB_CHECK_CODE(code, lino, _exit);
    }
  }

  // open tsdb
  code = tsdbOpenFS(pTsdb, &pTsdb->pFS, rollback);
  TSDB_CHECK_CODE(code, lino, _exit);

  if (pTsdb->pFS->fsstate == TSDB_FS_STATE_INCOMPLETE && force == false) {
    TAOS_CHECK_GOTO(terrno = TSDB_CODE_NEED_RETRY, &lino, _exit);
  }

  code = tsdbOpenCache(pTsdb);
  TSDB_CHECK_CODE(code, lino, _exit);

#ifdef TD_ENTERPRISE
  TAOS_CHECK_GOTO(tsdbOpenCompMonitor(pTsdb), &lino, _exit);
#endif

  TAOS_CHECK_GOTO(tsdbOpenSsMigrateMonitor(pTsdb), &lino, _exit);

_exit:
  if (code) {
    tsdbError("vgId:%d %s failed at %s:%d since %s, path:%s", TD_VID(pVnode), __func__, __FILE__, lino, tstrerror(code),
              pTsdb->path);
    tsdbCloseFS(&pTsdb->pFS);
    (void)taosThreadMutexDestroy(&pTsdb->mutex);
    taosMemoryFree(pTsdb);
  } else {
    tsdbDebug("vgId:%d, tsdb is opened at %s, days:%d, keep:%d,%d,%d, keepTimeoffset:%d", TD_VID(pVnode), pTsdb->path,
              pTsdb->keepCfg.days, pTsdb->keepCfg.keep0, pTsdb->keepCfg.keep1, pTsdb->keepCfg.keep2,
              pTsdb->keepCfg.keepTimeOffset);
    *ppTsdb = pTsdb;
  }
  return code;
}

void tsdbClose(STsdb **pTsdb) {
  if (*pTsdb) {
    STsdb *pdb = *pTsdb;
    tsdbDebug("vgId:%d, tsdb is close at %s, days:%d, keep:%d,%d,%d, keepTimeOffset:%d", TD_VID(pdb->pVnode), pdb->path,
              pdb->keepCfg.days, pdb->keepCfg.keep0, pdb->keepCfg.keep1, pdb->keepCfg.keep2,
              pdb->keepCfg.keepTimeOffset);
    (void)taosThreadMutexLock(&(*pTsdb)->mutex);
    tsdbMemTableDestroy((*pTsdb)->mem, true);
    (*pTsdb)->mem = NULL;
    (void)taosThreadMutexUnlock(&(*pTsdb)->mutex);

    tsdbCloseFS(&(*pTsdb)->pFS);
    tsdbCloseCache(*pTsdb);
#ifdef TD_ENTERPRISE
    tsdbCloseCompMonitor(*pTsdb);
#endif
    tsdbCloseSsMigrateMonitor(*pTsdb);
    (void)taosThreadMutexDestroy(&(*pTsdb)->mutex);
    taosMemoryFreeClear(*pTsdb);
  }
  return;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "meta.h"
17	#include "tsdb.h"
18	#include "tsdbFS2.h"
19
20	extern int32_t tsdbOpenCompMonitor(STsdb *tsdb);
21	extern void tsdbCloseCompMonitor(STsdb *tsdb);
22	extern int32_t tsdbOpenSsMigrateMonitor(STsdb *tsdb);
23	extern void tsdbCloseSsMigrateMonitor(STsdb *tsdb);
24
25	void tsdbSetKeepCfg(STsdb pTsdb, STsdbCfg pCfg) {	13,490✔
26	STsdbKeepCfg *pKeepCfg = &pTsdb->keepCfg;	13,490✔
27	pKeepCfg->precision = pCfg->precision;	13,490✔
28	pKeepCfg->days = pCfg->days;	13,490✔
29	pKeepCfg->keep0 = pCfg->keep0;	13,490✔
30	pKeepCfg->keep1 = pCfg->keep1;	13,490✔
31	pKeepCfg->keep2 = pCfg->keep2;	13,490✔
32	pKeepCfg->keepTimeOffset = pCfg->keepTimeOffset;	13,490✔
33	}	13,490✔
34
35	int64_t tsdbGetEarliestTs(STsdb *pTsdb) {	1,397,967✔
36	STsdbKeepCfg *pCfg = &pTsdb->keepCfg;	1,397,967✔
37
38	int64_t now = taosGetTimestamp(pCfg->precision);	1,397,967✔
39	int64_t ts = now - (tsTickPerMin[pCfg->precision] * pCfg->keep2) + 1; // needs to add one tick	1,398,228✔
40	return ts;	1,398,228✔
41	}
42
43	int32_t tsdbOpen(SVnode pVnode, STsdb ppTsdb, const char dir, STsdbKeepCfg *pKeepCfg, int8_t rollback, bool force) {	13,417✔
44	STsdb *pTsdb = NULL;	13,417✔
45	int slen = 0;	13,417✔
46	int32_t code;
47	int32_t lino;
48
49	*ppTsdb = NULL;	13,417✔
50	slen = strlen(pVnode->path) + strlen(dir) + 2;	13,417✔
51
52	// create handle
53	pTsdb = (STsdb )taosMemoryCalloc(1, sizeof(pTsdb) + slen);	13,417!
54	if (pTsdb == NULL) {	13,433!
55	TAOS_CHECK_RETURN(terrno);	×
56	}
57
58	pTsdb->path = (char *)&pTsdb[1];	13,433✔
59	(void)snprintf(pTsdb->path, TD_PATH_MAX, "%s%s%s", pVnode->path, TD_DIRSEP, dir);	13,433✔
60	(void)snprintf(pTsdb->name, sizeof(pTsdb->name), "%s", dir);	13,433✔
61	// taosRealPath(pTsdb->path, NULL, slen);
62	pTsdb->pVnode = pVnode;	13,433✔
63	(void)taosThreadMutexInit(&pTsdb->mutex, NULL);	13,433✔
64	if (!pKeepCfg) {	13,432!
65	tsdbSetKeepCfg(pTsdb, &pVnode->config.tsdbCfg);	13,432✔
66	} else {
67	memcpy(&pTsdb->keepCfg, pKeepCfg, sizeof(STsdbKeepCfg));	×
68	}
69
70	// create dir
71	if (!pVnode->mounted) {	13,433✔
72	if (pVnode->pTfs) {	13,416!
73	code = tfsMkdir(pVnode->pTfs, pTsdb->path);	13,416✔
74	TSDB_CHECK_CODE(code, lino, _exit);	13,414!
75	} else {
76	code = taosMkDir(pTsdb->path);	×
77	TSDB_CHECK_CODE(code, lino, _exit);	×
78	}
79	}
80
81	// open tsdb
82	code = tsdbOpenFS(pTsdb, &pTsdb->pFS, rollback);	13,431✔
83	TSDB_CHECK_CODE(code, lino, _exit);	13,434!
84
85	if (pTsdb->pFS->fsstate == TSDB_FS_STATE_INCOMPLETE && force == false) {	13,434!
86	TAOS_CHECK_GOTO(terrno = TSDB_CODE_NEED_RETRY, &lino, _exit);	×
87	}
88
89	code = tsdbOpenCache(pTsdb);	13,434✔
90	TSDB_CHECK_CODE(code, lino, _exit);	13,426!
91
92	#ifdef TD_ENTERPRISE
93	TAOS_CHECK_GOTO(tsdbOpenCompMonitor(pTsdb), &lino, _exit);	13,426!
94	#endif
95
96	TAOS_CHECK_GOTO(tsdbOpenSsMigrateMonitor(pTsdb), &lino, _exit);	13,431!
97
98	_exit:	13,431✔
99	if (code) {	13,431!
100	tsdbError("vgId:%d %s failed at %s:%d since %s, path:%s", TD_VID(pVnode), __func__, __FILE__, lino, tstrerror(code),	×
101	pTsdb->path);
102	tsdbCloseFS(&pTsdb->pFS);	×
103	(void)taosThreadMutexDestroy(&pTsdb->mutex);	×
104	taosMemoryFree(pTsdb);	×
105	} else {
106	tsdbDebug("vgId:%d, tsdb is opened at %s, days:%d, keep:%d,%d,%d, keepTimeoffset:%d", TD_VID(pVnode), pTsdb->path,	13,431✔
107	pTsdb->keepCfg.days, pTsdb->keepCfg.keep0, pTsdb->keepCfg.keep1, pTsdb->keepCfg.keep2,
108	pTsdb->keepCfg.keepTimeOffset);
109	*ppTsdb = pTsdb;	13,430✔
110	}
111	return code;	13,430✔
112	}
113
114	void tsdbClose(STsdb **pTsdb) {	13,434✔
115	if (*pTsdb) {	13,434!
116	STsdb pdb = pTsdb;	13,434✔
117	tsdbDebug("vgId:%d, tsdb is close at %s, days:%d, keep:%d,%d,%d, keepTimeOffset:%d", TD_VID(pdb->pVnode), pdb->path,	13,434✔
118	pdb->keepCfg.days, pdb->keepCfg.keep0, pdb->keepCfg.keep1, pdb->keepCfg.keep2,
119	pdb->keepCfg.keepTimeOffset);
120	(void)taosThreadMutexLock(&(*pTsdb)->mutex);	13,434✔
121	tsdbMemTableDestroy((*pTsdb)->mem, true);	13,434✔
122	(*pTsdb)->mem = NULL;	13,434✔
123	(void)taosThreadMutexUnlock(&(*pTsdb)->mutex);	13,434✔
124
125	tsdbCloseFS(&(*pTsdb)->pFS);	13,434✔
126	tsdbCloseCache(*pTsdb);	13,433✔
127	#ifdef TD_ENTERPRISE
128	tsdbCloseCompMonitor(*pTsdb);	13,423✔
129	#endif
130	tsdbCloseSsMigrateMonitor(*pTsdb);	13,424✔
131	(void)taosThreadMutexDestroy(&(*pTsdb)->mutex);	13,432✔
132	taosMemoryFreeClear(*pTsdb);	13,430!
133	}
134	return;	13,430✔
135	}

taosdata / TDengine / #4658

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous