16728097825

Committed 04 Aug 2025 04:00PM UTC coverage: 48.355% (-35.1%) from 83.429%

Build # 16728097825

Build Type

Pull #4108

github

Committed by

web-flow

Commit Message

Merge 1b2d27fd8 into 649ba9576

Pull Request Pull Request #4108: perf[vortex-array]: use all_valid instead of `invalid_count() == 0`

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

11596 existing lines in 378 files now uncovered.

18635 of 38538 relevant lines covered (48.35%)

151786.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/vortex-array/src/arrays/bool/compute/sum.rs

// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use std::ops::BitAnd;

use vortex_error::VortexResult;
use vortex_mask::AllOr;
use vortex_scalar::Scalar;

use crate::arrays::{BoolArray, BoolVTable};
use crate::compute::{SumKernel, SumKernelAdapter};
use crate::register_kernel;

impl SumKernel for BoolVTable {
    fn sum(&self, array: &BoolArray) -> VortexResult<Scalar> {
        let true_count: Option<u64> = match array.validity_mask()?.boolean_buffer() {
            AllOr::All => {
                // All-valid
                Some(array.boolean_buffer().count_set_bits() as u64)
            }
            AllOr::None => {
                // All-invalid
                unreachable!("All-invalid boolean array should have been handled by entry-point")
            }
            AllOr::Some(validity_mask) => Some(
                array
                    .boolean_buffer()
                    .bitand(validity_mask)
                    .count_set_bits() as u64,
            ),
        };
        Ok(Scalar::from(true_count))
    }
}

register_kernel!(SumKernelAdapter(BoolVTable).lift());

1	// SPDX-License-Identifier: Apache-2.0
2	// SPDX-FileCopyrightText: Copyright the Vortex contributors
3
4	use std::ops::BitAnd;
5
6	use vortex_error::VortexResult;
7	use vortex_mask::AllOr;
8	use vortex_scalar::Scalar;
9
10	use crate::arrays::{BoolArray, BoolVTable};
11	use crate::compute::{SumKernel, SumKernelAdapter};
12	use crate::register_kernel;
13
14	impl SumKernel for BoolVTable {
UNCOV 15	fn sum(&self, array: &BoolArray) -> VortexResult<Scalar> {	×
UNCOV 16	let true_count: Option<u64> = match array.validity_mask()?.boolean_buffer() {	×
17	AllOr::All => {
18	// All-valid
UNCOV 19	Some(array.boolean_buffer().count_set_bits() as u64)	×
20	}
21	AllOr::None => {
22	// All-invalid
23	unreachable!("All-invalid boolean array should have been handled by entry-point")	×
24	}
25	AllOr::Some(validity_mask) => Some(	×
26	array	×
27	.boolean_buffer()	×
28	.bitand(validity_mask)	×
29	.count_set_bits() as u64,	×
30	),	×
31	};
UNCOV 32	Ok(Scalar::from(true_count))	×
UNCOV 33	}	×
34	}
35
36	register_kernel!(SumKernelAdapter(BoolVTable).lift());

vortex-data / vortex / 16728097825

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous