kubeovn/kube-ovn | Build 16719503087 | pkg/controller/vpc.go | Coveralls

31

func (c *Controller) enqueueAddVpc(obj any) {

×

32

        vpc := obj.(*kubeovnv1.Vpc)

×

33

        key := cache.MetaObjectToName(vpc).String()

×

34

        if _, ok := vpc.Labels[util.VpcExternalLabel]; !ok {

×

35

                klog.V(3).Infof("enqueue add vpc %s", key)

×

36

                c.addOrUpdateVpcQueue.Add(key)

×

37

×

40

func vpcBFDPortChanged(oldObj, newObj *kubeovnv1.BFDPort) bool {

×

41

        if oldObj == nil && newObj == nil {

×

42

                return false

×

43

×

44

        if oldObj == nil || newObj == nil {

×

45

                return true

×

46

×

47

        return oldObj.Enabled != newObj.Enabled || oldObj.IP != newObj.IP || !reflect.DeepEqual(oldObj.NodeSelector, newObj.NodeSelector)

×

50

func (c *Controller) enqueueUpdateVpc(oldObj, newObj any) {

×

51

        oldVpc := oldObj.(*kubeovnv1.Vpc)

×

52

        newVpc := newObj.(*kubeovnv1.Vpc)

×

53

×

NEW

54

        if newVpc.Labels != nil && newVpc.Labels[util.VpcExternalLabel] == "true" {

×

55

                return

×

56

×

58

        if !newVpc.DeletionTimestamp.IsZero() ||

×

59

                !slices.Equal(oldVpc.Spec.Namespaces, newVpc.Spec.Namespaces) ||

×

60

                !reflect.DeepEqual(oldVpc.Spec.StaticRoutes, newVpc.Spec.StaticRoutes) ||

×

61

                !reflect.DeepEqual(oldVpc.Spec.PolicyRoutes, newVpc.Spec.PolicyRoutes) ||

×

62

                !reflect.DeepEqual(oldVpc.Spec.VpcPeerings, newVpc.Spec.VpcPeerings) ||

×

63

                !maps.Equal(oldVpc.Annotations, newVpc.Annotations) ||

×

64

                !slices.Equal(oldVpc.Spec.ExtraExternalSubnets, newVpc.Spec.ExtraExternalSubnets) ||

×

65

                oldVpc.Spec.EnableExternal != newVpc.Spec.EnableExternal ||

×

66

                oldVpc.Spec.EnableBfd != newVpc.Spec.EnableBfd ||

×

67

                vpcBFDPortChanged(oldVpc.Spec.BFDPort, newVpc.Spec.BFDPort) ||

×

68

                oldVpc.Labels[util.VpcExternalLabel] != newVpc.Labels[util.VpcExternalLabel] ||

×

69

                !slices.Equal(oldVpc.Status.Subnets, newVpc.Status.Subnets) {

×

70

                // TODO:// label VpcExternalLabel replace with spec enable external

×

71

×

72

                // recode last policies

×

73

                c.vpcLastPoliciesMap.Store(newVpc.Name, convertPolicies(oldVpc.Spec.PolicyRoutes))

×

74

×

UNCOV

75

                key := cache.MetaObjectToName(newVpc).String()

×

UNCOV

76

                klog.Infof("enqueue update vpc %s", key)

×

77

                c.addOrUpdateVpcQueue.Add(key)

×

78

×

81

func (c *Controller) enqueueDelVpc(obj any) {

×

82

        vpc := obj.(*kubeovnv1.Vpc)

×

UNCOV

83

        if _, ok := vpc.Labels[util.VpcExternalLabel]; !vpc.Status.Default || !ok {

×

UNCOV

84

                klog.V(3).Infof("enqueue delete vpc %s", vpc.Name)

×

85

                c.delVpcQueue.Add(vpc)

×

86

×

89

func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {

×

90

        c.vpcKeyMutex.LockKey(vpc.Name)

×

91

        defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()

×

92

        klog.Infof("handle delete vpc %s", vpc.Name)

×

93

×

94

        // should delete vpc subnets first

×

95

        var err error

×

UNCOV

96

        for _, subnet := range vpc.Status.Subnets {

×

97

                if _, err = c.subnetsLister.Get(subnet); err != nil {

×

98

                        if k8serrors.IsNotFound(err) {

×

99

                                continue

×

101

                        err = fmt.Errorf("failed to get subnet %s for vpc %s: %w", subnet, vpc.Name, err)

×

102

                } else {

×

UNCOV

103

                        err = fmt.Errorf("failed to delete vpc %s, please delete subnet %s first", vpc.Name, subnet)

×

UNCOV

104

×

UNCOV

105

                klog.Error(err)

×

106

                return err

×

110

        c.vpcLastPoliciesMap.Delete(vpc.Name)

×

111

×

UNCOV

112

        if err := c.deleteVpcLb(vpc); err != nil {

×

113

                klog.Error(err)

×

114

                return err

×

115

×

UNCOV

117

        if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {

×

118

                klog.Errorf("failed to delete external connection for vpc %s, error %v", vpc.Name, err)

×

119

                return err

×

120

×

122

        for _, subnet := range vpc.Status.ExtraExternalSubnets {

×

123

                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)

×

UNCOV

124

                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {

×

UNCOV

125

                        klog.Error(err)

×

126

                        return err

×

127

×

UNCOV

130

        if err := c.deleteVpcRouter(vpc.Status.Router); err != nil {

×

131

                klog.Error(err)

×

UNCOV

132

                return err

×

UNCOV

133

×

135

        return nil

×

138

func (c *Controller) handleUpdateVpcStatus(key string) error {

×

139

        c.vpcKeyMutex.LockKey(key)

×

140

        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()

×

141

        klog.Infof("handle status update for vpc %s", key)

×

142

×

143

        cachedVpc, err := c.vpcsLister.Get(key)

×

144

        if err != nil {

×

145

                if k8serrors.IsNotFound(err) {

×

UNCOV

146

                        return nil

×

147

×

148

                klog.Error(err)

×

149

                return err

×

151

        vpc := cachedVpc.DeepCopy()

×

152

×

153

        subnets, defaultSubnet, err := c.getVpcSubnets(vpc)

×

UNCOV

154

        if err != nil {

×

155

                klog.Error(err)

×

156

                return err

×

157

×

159

        change := vpc.Status.DefaultLogicalSwitch != defaultSubnet

×

160

×

161

        vpc.Status.DefaultLogicalSwitch = defaultSubnet

×

162

        vpc.Status.Subnets = subnets

×

163

×

164

        if !vpc.Spec.BFDPort.IsEnabled() && !vpc.Status.BFDPort.IsEmpty() {

×

165

                vpc.Status.BFDPort.Clear()

×

166

×

167

        bytes, err := vpc.Status.Bytes()

×

UNCOV

168

        if err != nil {

×

169

                klog.Error(err)

×

170

                return err

×

171

×

173

        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")

×

UNCOV

174

        if err != nil {

×

175

                klog.Error(err)

×

176

                return err

×

177

×

UNCOV

179

        if len(vpc.Status.Subnets) == 0 {

×

180

                klog.Infof("vpc %s has no subnets, add to queue", vpc.Name)

×

181

                c.addOrUpdateVpcQueue.AddAfter(vpc.Name, 5*time.Second)

×

182

×

UNCOV

184

        if change {

×

UNCOV

185

                for _, ns := range vpc.Spec.Namespaces {

×

186

                        c.addNamespaceQueue.Add(ns)

×

187

×

190

        natGws, err := c.vpcNatGatewayLister.List(labels.Everything())

×

191

        if err != nil {

×

192

                klog.Error(err)

×

193

                return err

×

194

×

UNCOV

195

        for _, gw := range natGws {

×

196

                if key == gw.Spec.Vpc {

×

UNCOV

197

                        c.updateVpcSubnetQueue.Add(gw.Name)

×

UNCOV

198

×

UNCOV

200

        return nil

×

212

func (c *Controller) GenVpcLoadBalancer(vpcKey string) *VpcLoadBalancer {

×

213

        if vpcKey == c.config.ClusterRouter || vpcKey == "" {

×

214

                return &VpcLoadBalancer{

×

215

                        TCPLoadBalancer:      c.config.ClusterTCPLoadBalancer,

×

216

                        TCPSessLoadBalancer:  c.config.ClusterTCPSessionLoadBalancer,

×

217

                        UDPLoadBalancer:      c.config.ClusterUDPLoadBalancer,

×

218

                        UDPSessLoadBalancer:  c.config.ClusterUDPSessionLoadBalancer,

×

219

                        SctpLoadBalancer:     c.config.ClusterSctpLoadBalancer,

×

220

                        SctpSessLoadBalancer: c.config.ClusterSctpSessionLoadBalancer,

×

221

×

222

×

223

        return &VpcLoadBalancer{

×

224

                TCPLoadBalancer:      fmt.Sprintf("vpc-%s-tcp-load", vpcKey),

×

225

                TCPSessLoadBalancer:  fmt.Sprintf("vpc-%s-tcp-sess-load", vpcKey),

×

226

                UDPLoadBalancer:      fmt.Sprintf("vpc-%s-udp-load", vpcKey),

×

UNCOV

227

                UDPSessLoadBalancer:  fmt.Sprintf("vpc-%s-udp-sess-load", vpcKey),

×

UNCOV

228

                SctpLoadBalancer:     fmt.Sprintf("vpc-%s-sctp-load", vpcKey),

×

229

                SctpSessLoadBalancer: fmt.Sprintf("vpc-%s-sctp-sess-load", vpcKey),

×

230

×

233

func (c *Controller) addLoadBalancer(vpc string) (*VpcLoadBalancer, error) {

×

234

        vpcLbConfig := c.GenVpcLoadBalancer(vpc)

×

235

        if err := c.initLB(vpcLbConfig.TCPLoadBalancer, string(v1.ProtocolTCP), false); err != nil {

×

236

                return nil, err

×

237

×

238

        if err := c.initLB(vpcLbConfig.TCPSessLoadBalancer, string(v1.ProtocolTCP), true); err != nil {

×

239

                return nil, err

×

240

×

241

        if err := c.initLB(vpcLbConfig.UDPLoadBalancer, string(v1.ProtocolUDP), false); err != nil {

×

242

                return nil, err

×

243

×

244

        if err := c.initLB(vpcLbConfig.UDPSessLoadBalancer, string(v1.ProtocolUDP), true); err != nil {

×

245

                return nil, err

×

246

×

247

        if err := c.initLB(vpcLbConfig.SctpLoadBalancer, string(v1.ProtocolSCTP), false); err != nil {

×

248

                return nil, err

×

UNCOV

249

×

250

        if err := c.initLB(vpcLbConfig.SctpSessLoadBalancer, string(v1.ProtocolSCTP), true); err != nil {

×

UNCOV

251

                return nil, err

×

UNCOV

252

×

254

        return vpcLbConfig, nil

×

257

func (c *Controller) handleAddOrUpdateVpc(key string) error {

×

258

        c.vpcKeyMutex.LockKey(key)

×

259

        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()

×

260

        klog.Infof("handle add/update vpc %s", key)

×

261

×

262

        cachedVpc, err := c.vpcsLister.Get(key)

×

263

        if err != nil {

×

264

                if k8serrors.IsNotFound(err) {

×

UNCOV

265

                        return nil

×

UNCOV

266

×

267

                klog.Error(err)

×

268

                return err

×

271

        vpc, err := c.formatVpc(cachedVpc.DeepCopy())

×

UNCOV

272

        if err != nil {

×

273

                klog.Errorf("failed to format vpc %s: %v", key, err)

×

274

                return err

×

275

×

277

        learnFromARPRequest := vpc.Spec.EnableExternal

×

278

        if !learnFromARPRequest {

×

279

                for _, subnetName := range vpc.Status.Subnets {

×

UNCOV

280

                        subnet, err := c.subnetsLister.Get(subnetName)

×

281

                        if err != nil {

×

282

                                if k8serrors.IsNotFound(err) {

×

UNCOV

283

                                        continue

×

285

                                klog.Errorf("failed to get subnet %s for vpc %s: %v", subnetName, key, err)

×

286

                                return err

×

UNCOV

288

                        if subnet.Spec.Vlan != "" && subnet.Spec.U2OInterconnection {

×

UNCOV

289

                                learnFromARPRequest = true

×

UNCOV

290

                                break

×

UNCOV

295

        if err = c.createVpcRouter(key, learnFromARPRequest); err != nil {

×

296

                klog.Errorf("failed to create vpc router for vpc %s: %v", key, err)

×

297

                return err

×

298

×

300

        var newPeers []string

×

301

        for _, peering := range vpc.Spec.VpcPeerings {

×

UNCOV

302

                if err = util.CheckCidrs(peering.LocalConnectIP); err != nil {

×

303

                        klog.Errorf("invalid cidr %s", peering.LocalConnectIP)

×

304

                        return err

×

305

×

307

                newPeers = append(newPeers, peering.RemoteVpc)

×

UNCOV

308

                if err := c.OVNNbClient.CreatePeerRouterPort(vpc.Name, peering.RemoteVpc, peering.LocalConnectIP); err != nil {

×

309

                        klog.Errorf("create peer router port for vpc %s, %v", vpc.Name, err)

×

310

                        return err

×

311

×

313

        for _, oldPeer := range vpc.Status.VpcPeerings {

×

314

                if !slices.Contains(newPeers, oldPeer) {

×

UNCOV

315

                        if err = c.OVNNbClient.DeleteLogicalRouterPort(fmt.Sprintf("%s-%s", vpc.Name, oldPeer)); err != nil {

×

UNCOV

316

                                klog.Errorf("delete peer router port for vpc %s, %v", vpc.Name, err)

×

UNCOV

317

                                return err

×

UNCOV

318

×

323

        var (

×

324

                staticExistedRoutes []*ovnnb.LogicalRouterStaticRoute

×

325

                staticTargetRoutes  []*kubeovnv1.StaticRoute

×

326

                staticRouteMapping  map[string][]*kubeovnv1.StaticRoute

×

327

×

328

×

329

        staticExistedRoutes, err = c.OVNNbClient.ListLogicalRouterStaticRoutes(vpc.Name, nil, nil, "", nil)

×

UNCOV

330

        if err != nil {

×

331

                klog.Errorf("failed to get vpc %s static route list, %v", vpc.Name, err)

×

332

                return err

×

333

×

335

        var externalSubnet *kubeovnv1.Subnet

×

336

        externalSubnetExist := false

×

337

        externalSubnetGW := ""

×

338

        if c.config.EnableEipSnat {

×

339

                externalSubnet, err = c.subnetsLister.Get(c.config.ExternalGatewaySwitch)

×

340

                if err != nil {

×

341

                        klog.Warningf("enable-eip-snat need external subnet %s to be exist: %v", c.config.ExternalGatewaySwitch, err)

×

342

                } else {

×

343

                        if !externalSubnet.Spec.LogicalGateway {

×

344

                                // logical gw external subnet can not access external

×

345

                                externalSubnetExist = true

×

UNCOV

346

                                externalSubnetGW = externalSubnet.Spec.Gateway

×

UNCOV

347

                        } else {

×

UNCOV

348

                                klog.Infof("default external subnet %s using logical gw", c.config.ExternalGatewaySwitch)

×

349

×

353

        staticRouteMapping = c.getRouteTablesByVpc(vpc)

×

354

        staticTargetRoutes = vpc.Spec.StaticRoutes

×

UNCOV

355

        if vpc.Name == c.config.ClusterRouter {

×

356

                if _, ok := staticRouteMapping[util.MainRouteTable]; !ok {

×

357

                        staticRouteMapping[util.MainRouteTable] = nil

×

358

×

360

                joinSubnet, err := c.subnetsLister.Get(c.config.NodeSwitch)

×

361

                if err != nil {

×

362

                        if !k8serrors.IsNotFound(err) {

×

363

                                klog.Errorf("failed to get node switch subnet %s: %v", c.config.NodeSwitch, err)

×

UNCOV

364

                                return err

×

365

×

366

                        c.addOrUpdateVpcQueue.Add(vpc.Name)

×

367

                        return nil

×

369

                gatewayV4, gatewayV6 := util.SplitStringIP(joinSubnet.Spec.Gateway)

×

370

                if gatewayV4 != "" {

×

371

                        for table := range staticRouteMapping {

×

372

                                staticTargetRoutes = append(

×

373

                                        staticTargetRoutes,

×

374

                                        &kubeovnv1.StaticRoute{

×

375

                                                Policy:     kubeovnv1.PolicyDst,

×

376

                                                CIDR:       "0.0.0.0/0",

×

377

                                                NextHopIP:  gatewayV4,

×

UNCOV

378

                                                RouteTable: table,

×

379

},

×

380

×

381

×

383

                if gatewayV6 != "" {

×

384

                        for table := range staticRouteMapping {

×

385

                                staticTargetRoutes = append(

×

386

                                        staticTargetRoutes,

×

387

                                        &kubeovnv1.StaticRoute{

×

388

                                                Policy:     kubeovnv1.PolicyDst,

×

389

                                                CIDR:       "::/0",

×

390

                                                NextHopIP:  gatewayV6,

×

UNCOV

391

                                                RouteTable: table,

×

392

},

×

393

×

394

×

396

                if c.config.EnableEipSnat {

×

397

                        cm, err := c.configMapsLister.ConfigMaps(c.config.ExternalGatewayConfigNS).Get(util.ExternalGatewayConfig)

×

398

                        if err == nil {

×

399

                                nextHop := cm.Data["external-gw-addr"]

×

400

                                if nextHop == "" {

×

401

                                        if !externalSubnetExist {

×

402

                                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)

×

403

                                                klog.Error(err)

×

404

                                                return err

×

405

×

406

                                        nextHop = externalSubnet.Spec.Gateway

×

407

                                        if nextHop == "" {

×

UNCOV

408

                                                err := fmt.Errorf("subnet %s has no gateway configuration", externalSubnet.Name)

×

409

                                                klog.Error(err)

×

410

                                                return err

×

411

×

413

                                if strings.Contains(nextHop, "/") {

×

414

                                        nextHop = strings.Split(nextHop, "/")[0]

×

415

×

417

                                lr, err := c.OVNNbClient.GetLogicalRouter(vpc.Name, false)

×

UNCOV

418

                                if err != nil {

×

419

                                        klog.Errorf("failed to get logical router %s: %v", vpc.Name, err)

×

420

                                        return err

×

421

×

423

                                for _, nat := range lr.Nat {

×

424

                                        info, err := c.OVNNbClient.GetNATByUUID(nat)

×

425

                                        if err != nil {

×

426

                                                klog.Errorf("failed to get nat ip info for vpc %s, %v", vpc.Name, err)

×

427

                                                return err

×

428

×

429

                                        if info.LogicalIP != "" {

×

430

                                                for table := range staticRouteMapping {

×

431

                                                        staticTargetRoutes = append(

×

432

                                                                staticTargetRoutes,

×

433

                                                                &kubeovnv1.StaticRoute{

×

434

                                                                        Policy:     kubeovnv1.PolicySrc,

×

435

                                                                        CIDR:       info.LogicalIP,

×

436

                                                                        NextHopIP:  nextHop,

×

UNCOV

437

                                                                        RouteTable: table,

×

UNCOV

438

},

×

UNCOV

439

×

UNCOV

440

×

447

        routeNeedDel, routeNeedAdd, err := diffStaticRoute(staticExistedRoutes, staticTargetRoutes)

×

UNCOV

448

        if err != nil {

×

449

                klog.Errorf("failed to diff vpc %s static route, %v", vpc.Name, err)

×

450

                return err

×

451

×

453

        for _, item := range routeNeedDel {

×

454

                klog.Infof("vpc %s del static route: %+v", vpc.Name, item)

×

455

                policy := convertPolicy(item.Policy)

×

UNCOV

456

                if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(vpc.Name, &item.RouteTable, &policy, item.CIDR, item.NextHopIP); err != nil {

×

UNCOV

457

                        klog.Errorf("del vpc %s static route failed, %v", vpc.Name, err)

×

458

                        return err

×

459

×

462

        for _, item := range routeNeedAdd {

×

463

                if item.BfdID != "" {

×

464

                        klog.Infof("vpc %s add static ecmp route: %+v", vpc.Name, item)

×

465

                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(

×

466

                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, &item.BfdID, nil, item.NextHopIP,

×

467

                        ); err != nil {

×

468

                                klog.Errorf("failed to add bfd static route to vpc %s , %v", vpc.Name, err)

×

469

                                return err

×

470

×

471

                } else {

×

472

                        klog.Infof("vpc %s add static route: %+v", vpc.Name, item)

×

473

                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(

×

474

                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, nil, nil, item.NextHopIP,

×

UNCOV

475

                        ); err != nil {

×

UNCOV

476

                                klog.Errorf("failed to add normal static route to vpc %s , %v", vpc.Name, err)

×

UNCOV

477

                                return err

×

UNCOV

478

×

483

        var (

×

484

                policyRouteExisted, policyRouteNeedDel, policyRouteNeedAdd []*kubeovnv1.PolicyRoute

×

485

                policyRouteLogical                                         []*ovnnb.LogicalRouterPolicy

×

486

                externalIDs                                                = map[string]string{"vendor": util.CniTypeName}

×

487

×

488

×

489

        if vpc.Name == c.config.ClusterRouter {

×

490

                lastPolicies, _ := c.vpcLastPoliciesMap.Load(vpc.Name)

×

491

                policyRouteExisted = reversePolicies(lastPolicies)

×

492

                // diff list

×

493

                policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithExisted(policyRouteExisted, vpc.Spec.PolicyRoutes)

×

494

        } else {

×

495

                if vpc.Spec.PolicyRoutes == nil {

×

496

                        // do not clean default vpc policy routes

×

497

                        if err = c.OVNNbClient.ClearLogicalRouterPolicy(vpc.Name); err != nil {

×

498

                                klog.Errorf("clean all vpc %s policy route failed, %v", vpc.Name, err)

×

499

                                return err

×

500

×

501

                } else {

×

502

                        policyRouteLogical, err = c.OVNNbClient.ListLogicalRouterPolicies(vpc.Name, -1, nil, true)

×

UNCOV

503

                        if err != nil {

×

504

                                klog.Errorf("failed to get vpc %s policy route list, %v", vpc.Name, err)

×

UNCOV

505

                                return err

×

UNCOV

506

×

508

                        policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithLogical(policyRouteLogical, vpc.Spec.PolicyRoutes)

×

512

        for _, item := range policyRouteNeedDel {

×

513

                klog.Infof("delete policy route for router: %s, priority: %d, match %s", vpc.Name, item.Priority, item.Match)

×

UNCOV

514

                if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpc.Name, item.Priority, item.Match); err != nil {

×

UNCOV

515

                        klog.Errorf("del vpc %s policy route failed, %v", vpc.Name, err)

×

516

                        return err

×

517

×

520

        for _, item := range policyRouteNeedAdd {

×

521

                klog.Infof("add policy route for router: %s, match %s, action %s, nexthop %s, externalID %v", c.config.ClusterRouter, item.Match, string(item.Action), item.NextHopIP, externalIDs)

×

UNCOV

522

                if err = c.OVNNbClient.AddLogicalRouterPolicy(vpc.Name, item.Priority, item.Match, string(item.Action), []string{item.NextHopIP}, nil, externalIDs); err != nil {

×

UNCOV

523

                        klog.Errorf("add policy route to vpc %s failed, %v", vpc.Name, err)

×

524

                        return err

×

525

×

528

        vpcSubnets, defaultSubnet, err := c.getVpcSubnets(vpc)

×

UNCOV

529

        if err != nil {

×

530

                klog.Error(err)

×

531

                return err

×

532

×

534

        vpc.Status.Subnets = vpcSubnets

×

535

        vpc.Status.DefaultLogicalSwitch = defaultSubnet

×

536

        vpc.Status.Router = key

×

537

        vpc.Status.Standby = true

×

538

        vpc.Status.VpcPeerings = newPeers

×

539

        if c.config.EnableLb {

×

540

                vpcLb, err := c.addLoadBalancer(key)

×

541

                if err != nil {

×

542

                        klog.Error(err)

×

543

                        return err

×

544

×

545

                vpc.Status.TCPLoadBalancer = vpcLb.TCPLoadBalancer

×

546

                vpc.Status.TCPSessionLoadBalancer = vpcLb.TCPSessLoadBalancer

×

UNCOV

547

                vpc.Status.UDPLoadBalancer = vpcLb.UDPLoadBalancer

×

548

                vpc.Status.UDPSessionLoadBalancer = vpcLb.UDPSessLoadBalancer

×

549

                vpc.Status.SctpLoadBalancer = vpcLb.SctpLoadBalancer

×

550

                vpc.Status.SctpSessionLoadBalancer = vpcLb.SctpSessLoadBalancer

×

552

        bytes, err := vpc.Status.Bytes()

×

553

        if err != nil {

×

554

                klog.Error(err)

×

555

                return err

×

556

×

557

        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")

×

UNCOV

558

        if err != nil {

×

559

                klog.Error(err)

×

560

                return err

×

561

×

563

        if len(vpc.Annotations) != 0 && strings.ToLower(vpc.Annotations[util.VpcLbAnnotation]) == "on" {

×

564

                if err = c.createVpcLb(vpc); err != nil {

×

565

                        klog.Error(err)

×

566

                        return err

×

567

×

UNCOV

568

        } else if err = c.deleteVpcLb(vpc); err != nil {

×

569

                klog.Error(err)

×

570

                return err

×

571

×

573

        subnets, err := c.subnetsLister.List(labels.Everything())

×

574

        if err != nil {

×

575

                klog.Error(err)

×

576

                return err

×

577

×

578

        custVpcEnableExternalEcmp := false

×

579

        for _, subnet := range subnets {

×

580

                if subnet.Spec.Vpc == key {

×

UNCOV

581

                        c.addOrUpdateSubnetQueue.Add(subnet.Name)

×

UNCOV

582

                        if vpc.Name != util.DefaultVpc && vpc.Spec.EnableBfd && subnet.Spec.EnableEcmp {

×

UNCOV

583

                                custVpcEnableExternalEcmp = true

×

584

×

588

        if vpc.Spec.EnableExternal || vpc.Status.EnableExternal {

×

UNCOV

589

                if err = c.handleUpdateVpcExternal(cachedVpc, custVpcEnableExternalEcmp, externalSubnetExist, externalSubnetGW); err != nil {

×

UNCOV

590

                        klog.Errorf("failed to handle update external subnet for vpc %s, %v", key, err)

×

591

                        return err

×

592

×

595

        bfdPortName, bfdPortNodes, err := c.reconcileVpcBfdLRP(vpc)

×

596

        if err != nil {

×

597

                klog.Error(err)

×

598

                return err

×

599

×

600

        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {

×

601

                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{}

×

602

        } else {

×

603

                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{

×

604

                        Name:  bfdPortName,

×

605

                        IP:    vpc.Spec.BFDPort.IP,

×

606

                        Nodes: bfdPortNodes,

×

607

×

608

×

609

        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().

×

UNCOV

610

                UpdateStatus(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {

×

611

                klog.Error(err)

×

UNCOV

612

                return err

×

UNCOV

613

×

615

        return nil

×

618

func (c *Controller) handleUpdateVpcExternal(vpc *kubeovnv1.Vpc, custVpcEnableExternalEcmp, defaultExternalSubnetExist bool, externalSubnetGW string) error {

×

UNCOV

619

        if c.config.EnableEipSnat && vpc.Name == util.DefaultVpc {

×

620

                klog.Infof("external_gw handle ovn default external gw %s", vpc.Name)

×

621

                return nil

×

622

×

UNCOV

624

        if !vpc.Spec.EnableExternal && !vpc.Status.EnableExternal {

×

UNCOV

625

                // no need to handle external connection

×

626

                return nil

×

627

×

630

        if vpc.Spec.EnableExternal && !defaultExternalSubnetExist && vpc.Spec.ExtraExternalSubnets == nil {

×

631

                // at least have a external subnet

×

UNCOV

632

                err := fmt.Errorf("failed to get external subnet for enable external vpc %s", vpc.Name)

×

633

                klog.Error(err)

×

634

                return err

×

635

×

637

        if !vpc.Spec.EnableExternal && vpc.Status.EnableExternal {

×

638

                // just del all external subnets connection

×

639

                klog.Infof("disconnect default external subnet %s to vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)

×

640

                if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {

×

641

                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)

×

642

                        return err

×

643

×

644

                for _, subnet := range vpc.Status.ExtraExternalSubnets {

×

645

                        klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)

×

UNCOV

646

                        if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {

×

UNCOV

647

                                klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)

×

UNCOV

648

                                return err

×

649

×

653

        if vpc.Spec.EnableExternal {

×

654

                if !vpc.Status.EnableExternal {

×

655

                        // just add external connection

×

656

                        if vpc.Spec.ExtraExternalSubnets == nil && defaultExternalSubnetExist {

×

657

                                // only connect default external subnet

×

658

                                klog.Infof("connect default external subnet %s with vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)

×

UNCOV

659

                                if err := c.handleAddVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {

×

UNCOV

660

                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)

×

UNCOV

661

                                        return err

×

662

×

666

                        for _, subnet := range vpc.Spec.ExtraExternalSubnets {

×

667

                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)

×

UNCOV

668

                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {

×

UNCOV

669

                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)

×

UNCOV

670

                                        return err

×

UNCOV

671

×

676

                for _, subnet := range vpc.Spec.ExtraExternalSubnets {

×

677

                        if !slices.Contains(vpc.Status.ExtraExternalSubnets, subnet) {

×

678

                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)

×

UNCOV

679

                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {

×

UNCOV

680

                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)

×

UNCOV

681

                                        return err

×

UNCOV

682

×

687

                for _, subnet := range vpc.Status.ExtraExternalSubnets {

×

688

                        if !slices.Contains(vpc.Spec.ExtraExternalSubnets, subnet) {

×

689

                                klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)

×

UNCOV

690

                                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {

×

UNCOV

691

                                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)

×

UNCOV

692

                                        return err

×

UNCOV

693

×

699

        if vpc.Spec.EnableBfd && vpc.Name != util.DefaultVpc && defaultExternalSubnetExist {

×

700

                // create bfd between lrp and physical switch gw

×

701

                // bfd status down means current lrp binding chassis node external nic lost external network connectivity

×

702

                // should switch lrp to another node

×

703

                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)

×

704

                v4ExtGw, _ := util.SplitStringIP(externalSubnetGW)

×

705

                // TODO: dualstack

×

UNCOV

706

                if _, err := c.OVNNbClient.CreateBFD(lrpEipName, v4ExtGw, c.config.BfdMinRx, c.config.BfdMinTx, c.config.BfdDetectMult, nil); err != nil {

×

707

                        klog.Error(err)

×

708

                        return err

×

709

×

711

                if custVpcEnableExternalEcmp {

×

712

                        klog.Infof("remove normal static ecmp route for vpc %s", vpc.Name)

×

713

                        // auto remove normal type static route, if using ecmp based bfd

×

UNCOV

714

                        if err := c.reconcileCustomVpcDelNormalStaticRoute(vpc.Name); err != nil {

×

UNCOV

715

                                klog.Errorf("failed to reconcile del vpc %q normal static route", vpc.Name)

×

UNCOV

716

                                return err

×

717

×

721

        if !vpc.Spec.EnableBfd && vpc.Status.EnableBfd {

×

722

                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)

×

723

                if err := c.OVNNbClient.DeleteBFDByDstIP(lrpEipName, ""); err != nil {

×

724

                        klog.Error(err)

×

725

                        return err

×

726

×

UNCOV

727

                if err := c.handleDeleteVpcStaticRoute(vpc.Name); err != nil {

×

UNCOV

728

                        klog.Errorf("failed to delete bfd route for vpc %s, error %v", vpc.Name, err)

×

729

                        return err

×

730

×

733

        if err := c.updateVpcExternalStatus(vpc.Name, vpc.Spec.EnableExternal); err != nil {

×

UNCOV

734

                klog.Errorf("failed to update vpc external subnets status, %v", err)

×

UNCOV

735

                return err

×

736

×

737

        return nil

×

740

func (c *Controller) reconcileVpcBfdLRP(vpc *kubeovnv1.Vpc) (string, []string, error) {

×

741

        portName := "bfd@" + vpc.Name

×

742

        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {

×

743

                if err := c.OVNNbClient.DeleteLogicalRouterPort(portName); err != nil {

×

744

                        err = fmt.Errorf("failed to delete BFD LRP %s: %w", portName, err)

×

745

                        klog.Error(err)

×

746

                        return portName, nil, err

×

747

×

748

                if err := c.OVNNbClient.DeleteHAChassisGroup(portName); err != nil {

×

749

                        err = fmt.Errorf("failed to delete HA chassis group %s: %w", portName, err)

×

UNCOV

750

                        klog.Error(err)

×

UNCOV

751

                        return portName, nil, err

×

752

×

753

                return portName, nil, nil

×

756

        var err error

×

757

        chassisCount := 3

×

758

        selector := labels.Everything()

×

759

        if vpc.Spec.BFDPort.NodeSelector != nil {

×

760

                chassisCount = math.MaxInt

×

761

                if selector, err = metav1.LabelSelectorAsSelector(vpc.Spec.BFDPort.NodeSelector); err != nil {

×

UNCOV

762

                        err = fmt.Errorf("failed to parse node selector %q: %w", vpc.Spec.BFDPort.NodeSelector.String(), err)

×

UNCOV

763

                        klog.Error(err)

×

764

                        return portName, nil, err

×

765

×

768

        nodes, err := c.nodesLister.List(selector)

×

769

        if err != nil {

×

770

                err = fmt.Errorf("failed to list nodes with selector %q: %w", vpc.Spec.BFDPort.NodeSelector, err)

×

771

                klog.Error(err)

×

772

                return portName, nil, err

×

773

×

774

        if len(nodes) == 0 {

×

UNCOV

775

                err = fmt.Errorf("no nodes found by selector %q", selector.String())

×

776

                klog.Error(err)

×

777

                return portName, nil, err

×

778

×

780

        nodeNames := make([]string, 0, len(nodes))

×

781

        chassisCount = min(chassisCount, len(nodes))

×

782

        chassisNames := make([]string, 0, chassisCount)

×

783

        for _, nodes := range nodes[:chassisCount] {

×

784

                chassis, err := c.OVNSbClient.GetChassisByHost(nodes.Name)

×

785

                if err != nil {

×

786

                        err = fmt.Errorf("failed to get chassis of node %s: %w", nodes.Name, err)

×

787

                        klog.Error(err)

×

UNCOV

788

                        return portName, nil, err

×

UNCOV

789

×

790

                chassisNames = append(chassisNames, chassis.Name)

×

791

                nodeNames = append(nodeNames, nodes.Name)

×

794

        networks := strings.Split(vpc.Spec.BFDPort.IP, ",")

×

795

        if err = c.OVNNbClient.CreateLogicalRouterPort(vpc.Name, portName, "", networks); err != nil {

×

796

                klog.Error(err)

×

797

                return portName, nil, err

×

798

×

799

        if err = c.OVNNbClient.UpdateLogicalRouterPortNetworks(portName, networks); err != nil {

×

800

                klog.Error(err)

×

801

                return portName, nil, err

×

802

×

803

        if err = c.OVNNbClient.UpdateLogicalRouterPortOptions(portName, map[string]string{"bfd-only": "true"}); err != nil {

×

804

                klog.Error(err)

×

805

                return portName, nil, err

×

806

×

807

        if err = c.OVNNbClient.CreateHAChassisGroup(portName, chassisNames, map[string]string{"lrp": portName}); err != nil {

×

808

                klog.Error(err)

×

809

                return portName, nil, err

×

810

×

UNCOV

811

        if err = c.OVNNbClient.SetLogicalRouterPortHAChassisGroup(portName, portName); err != nil {

×

812

                klog.Error(err)

×

UNCOV

813

                return portName, nil, err

×

UNCOV

814

×

816

        return portName, nodeNames, nil

×

819

func (c *Controller) addPolicyRouteToVpc(vpcName string, policy *kubeovnv1.PolicyRoute, externalIDs map[string]string) error {

×

820

        var (

×

821

                nextHops []string

×

822

                err      error

×

823

×

UNCOV

824

×

825

        if policy.NextHopIP != "" {

×

826

                nextHops = strings.Split(policy.NextHopIP, ",")

×

827

×

829

        if err = c.OVNNbClient.AddLogicalRouterPolicy(vpcName, policy.Priority, policy.Match, string(policy.Action), nextHops, nil, externalIDs); err != nil {

×

UNCOV

830

                klog.Errorf("add policy route to vpc %s failed, %v", vpcName, err)

×

UNCOV

831

                return err

×

832

×

833

        return nil

×

836

func buildExternalIDsMapKey(match, action string, priority int) string {

×

837

        return fmt.Sprintf("%s-%s-%d", match, action, priority)

×

838

×

840

func (c *Controller) batchAddPolicyRouteToVpc(name string, policies []*kubeovnv1.PolicyRoute, externalIDs map[string]map[string]string) error {

×

841

        if len(policies) == 0 {

×

842

                return nil

×

843

×

844

        start := time.Now()

×

845

        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))

×

846

        for _, policy := range policies {

×

847

                var nextHops []string

×

848

                if policy.NextHopIP != "" {

×

849

                        nextHops = strings.Split(policy.NextHopIP, ",")

×

850

×

851

                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{

×

852

                        Priority:    policy.Priority,

×

853

                        Nexthops:    nextHops,

×

UNCOV

854

                        Action:      string(policy.Action),

×

UNCOV

855

                        Match:       policy.Match,

×

856

                        ExternalIDs: externalIDs[buildExternalIDsMapKey(policy.Match, string(policy.Action), policy.Priority)],

×

857

})

×

860

        if err := c.OVNNbClient.BatchAddLogicalRouterPolicy(name, routerPolicies...); err != nil {

×

861

                klog.Errorf("batch add policy route to vpc %s failed, %v", name, err)

×

UNCOV

862

                return err

×

UNCOV

863

×

864

        klog.Infof("take to %v batch add policy route to vpc %s policies %d", time.Since(start), name, len(policies))

×

865

        return nil

×

868

func (c *Controller) deletePolicyRouteFromVpc(vpcName string, priority int, match string) error {

×

869

        var (

×

870

                vpc, cachedVpc *kubeovnv1.Vpc

×

871

                err            error

×

872

×

873

×

UNCOV

874

        if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpcName, priority, match); err != nil {

×

875

                klog.Error(err)

×

876

                return err

×

877

×

879

        cachedVpc, err = c.vpcsLister.Get(vpcName)

×

880

        if err != nil {

×

881

                if k8serrors.IsNotFound(err) {

×

UNCOV

882

                        return nil

×

883

×

884

                klog.Error(err)

×

885

                return err

×

887

        vpc = cachedVpc.DeepCopy()

×

888

        // make sure custom policies not be deleted

×

889

        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})

×

890

        if err != nil {

×

UNCOV

891

                klog.Error(err)

×

UNCOV

892

                return err

×

893

×

894

        return nil

×

897

func (c *Controller) batchDeletePolicyRouteFromVpc(name string, policies []*kubeovnv1.PolicyRoute) error {

×

898

        var (

×

899

                vpc, cachedVpc *kubeovnv1.Vpc

×

900

                err            error

×

901

×

902

×

903

        start := time.Now()

×

904

        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))

×

905

        for _, policy := range policies {

×

906

                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{

×

UNCOV

907

                        Priority: policy.Priority,

×

908

                        Match:    policy.Match,

×

909

})

×

910

×

912

        if err = c.OVNNbClient.BatchDeleteLogicalRouterPolicy(name, routerPolicies); err != nil {

×

913

                return err

×

914

×

915

        klog.V(3).Infof("take to %v batch delete policy route from vpc %s policies %d", time.Since(start), name, len(policies))

×

916

×

917

        cachedVpc, err = c.vpcsLister.Get(name)

×

918

        if err != nil {

×

919

                if k8serrors.IsNotFound(err) {

×

UNCOV

920

                        return nil

×

921

×

922

                klog.Error(err)

×

923

                return err

×

925

        vpc = cachedVpc.DeepCopy()

×

926

        // make sure custom policies not be deleted

×

927

        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})

×

928

        if err != nil {

×

UNCOV

929

                klog.Error(err)

×

UNCOV

930

                return err

×

931

×

932

        return nil

×

935

func (c *Controller) addStaticRouteToVpc(name string, route *kubeovnv1.StaticRoute) error {

×

936

        if route.BfdID != "" {

×

937

                klog.Infof("vpc %s add static ecmp route: %+v", name, route)

×

938

                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(

×

939

                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, &route.BfdID, nil, route.NextHopIP,

×

940

                ); err != nil {

×

941

                        klog.Errorf("failed to add bfd static route to vpc %s , %v", name, err)

×

942

                        return err

×

943

×

944

        } else {

×

945

                klog.Infof("vpc %s add static route: %+v", name, route)

×

946

                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(

×

947

                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, nil, nil, route.NextHopIP,

×

UNCOV

948

                ); err != nil {

×

949

                        klog.Errorf("failed to add normal static route to vpc %s , %v", name, err)

×

UNCOV

950

                        return err

×

UNCOV

951

×

953

        return nil

×

956

func (c *Controller) deleteStaticRouteFromVpc(name, table, cidr, nextHop string, policy kubeovnv1.RoutePolicy) error {

×

957

        var (

×

958

                policyStr string

×

959

                err       error

×

960

×

961

×

962

        policyStr = convertPolicy(policy)

×

UNCOV

963

        if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(name, &table, &policyStr, cidr, nextHop); err != nil {

×

964

                klog.Errorf("del vpc %s static route failed, %v", name, err)

×

UNCOV

965

                return err

×

UNCOV

966

×

968

        return nil

×

971

func (c *Controller) batchDeleteStaticRouteFromVpc(name string, staticRoutes []*kubeovnv1.StaticRoute) error {

×

972

        var (

×

973

                vpc, cachedVpc *kubeovnv1.Vpc

×

974

                err            error

×

975

×

976

        start := time.Now()

×

977

        routeCount := len(staticRoutes)

×

978

        delRoutes := make([]*ovnnb.LogicalRouterStaticRoute, 0, routeCount)

×

979

        for _, sr := range staticRoutes {

×

980

                policyStr := convertPolicy(sr.Policy)

×

981

                newRoute := &ovnnb.LogicalRouterStaticRoute{

×

982

                        RouteTable: sr.RouteTable,

×

983

                        Nexthop:    sr.NextHopIP,

×

984

                        Policy:     &policyStr,

×

985

                        IPPrefix:   sr.CIDR,

×

986

×

987

                delRoutes = append(delRoutes, newRoute)

×

988

×

989

        if err = c.OVNNbClient.BatchDeleteLogicalRouterStaticRoute(name, delRoutes); err != nil {

×

990

                klog.Errorf("batch del vpc %s static route %d failed, %v", name, routeCount, err)

×

991

                return err

×

992

×

993

        klog.V(3).Infof("take to %v batch delete static route from vpc %s static routes %d", time.Since(start), name, len(delRoutes))

×

994

×

995

        cachedVpc, err = c.vpcsLister.Get(name)

×

996

        if err != nil {

×

997

                if k8serrors.IsNotFound(err) {

×

UNCOV

998

                        return nil

×

999

×

1000

                klog.Error(err)

×

1001

                return err

×

1003

        vpc = cachedVpc.DeepCopy()

×

1004

        // make sure custom policies not be deleted

×

1005

        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})

×

1006

        if err != nil {

×

UNCOV

1007

                klog.Error(err)

×

UNCOV

1008

                return err

×

1009

×

1010

        return nil

×

1013

func diffPolicyRouteWithExisted(exists, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {

×

1014

        var (

×

1015

                dels, adds []*kubeovnv1.PolicyRoute

×

1016

                existsMap  map[string]*kubeovnv1.PolicyRoute

×

1017

                key        string

×

1018

                ok         bool

×

1019

×

1020

×

UNCOV

1021

        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))

×

1022

        for _, item := range exists {

×

1023

                existsMap[getPolicyRouteItemKey(item)] = item

×

1024

×

1026

        for _, item := range target {

×

1027

                key = getPolicyRouteItemKey(item)

×

1028

×

1029

                if _, ok = existsMap[key]; ok {

×

UNCOV

1030

                        delete(existsMap, key)

×

UNCOV

1031

                } else {

×

1032

                        adds = append(adds, item)

×

1033

×

UNCOV

1036

        for _, item := range existsMap {

×

UNCOV

1037

                dels = append(dels, item)

×

1038

×

1039

        return dels, adds

×

1042

func diffPolicyRouteWithLogical(exists []*ovnnb.LogicalRouterPolicy, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {

×

1043

        var (

×

1044

                dels, adds []*kubeovnv1.PolicyRoute

×

1045

                existsMap  map[string]*kubeovnv1.PolicyRoute

×

1046

                key        string

×

1047

                ok         bool

×

1048

×

1049

        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))

×

1050

×

1051

        for _, item := range exists {

×

1052

                policy := &kubeovnv1.PolicyRoute{

×

1053

                        Priority: item.Priority,

×

1054

                        Match:    item.Match,

×

UNCOV

1055

                        Action:   kubeovnv1.PolicyRouteAction(item.Action),

×

1056

×

1057

                existsMap[getPolicyRouteItemKey(policy)] = policy

×

1058

×

1060

        for _, item := range target {

×

1061

                key = getPolicyRouteItemKey(item)

×

1062

×

1063

                if _, ok = existsMap[key]; ok {

×

UNCOV

1064

                        delete(existsMap, key)

×

UNCOV

1065

                } else {

×

1066

                        adds = append(adds, item)

×

1067

×

UNCOV

1070

        for _, item := range existsMap {

×

UNCOV

1071

                dels = append(dels, item)

×

1072

×

1073

        return dels, adds

×

1076

func getPolicyRouteItemKey(item *kubeovnv1.PolicyRoute) (key string) {

×

1077

        return fmt.Sprintf("%d:%s:%s:%s", item.Priority, item.Match, item.Action, item.NextHopIP)

×

1078

×

1080

func diffStaticRoute(exist []*ovnnb.LogicalRouterStaticRoute, target []*kubeovnv1.StaticRoute) (routeNeedDel, routeNeedAdd []*kubeovnv1.StaticRoute, err error) {

×

1081

        existRouteMap := make(map[string]*kubeovnv1.StaticRoute, len(exist))

×

1082

        for _, item := range exist {

×

1083

                policy := kubeovnv1.PolicyDst

×

1084

                if item.Policy != nil && *item.Policy == ovnnb.LogicalRouterStaticRoutePolicySrcIP {

×

1085

                        policy = kubeovnv1.PolicySrc

×

1086

×

1087

                route := &kubeovnv1.StaticRoute{

×

1088

                        Policy:     policy,

×

1089

                        CIDR:       item.IPPrefix,

×

1090

                        NextHopIP:  item.Nexthop,

×

1091

                        RouteTable: item.RouteTable,

×

1092

                        ECMPMode:   util.StaticRouteBfdEcmp,

×

1093

×

UNCOV

1094

                if item.BFD != nil {

×

UNCOV

1095

                        route.BfdID = *item.BFD

×

1096

×

1097

                existRouteMap[getStaticRouteItemKey(route)] = route

×

1100

        for _, item := range target {

×

1101

                key := getStaticRouteItemKey(item)

×

1102

                if _, ok := existRouteMap[key]; ok {

×

UNCOV

1103

                        delete(existRouteMap, key)

×

1104

                } else {

×

1105

                        routeNeedAdd = append(routeNeedAdd, item)

×

1106

×

UNCOV

1108

        for _, item := range existRouteMap {

×

UNCOV

1109

                routeNeedDel = append(routeNeedDel, item)

×

1110

×

1111

        return

×

1114

func getStaticRouteItemKey(item *kubeovnv1.StaticRoute) string {

×

1115

        var key string

×

1116

        if item.Policy == kubeovnv1.PolicyDst {

×

1117

                key = fmt.Sprintf("%s:dst:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)

×

UNCOV

1118

        } else {

×

UNCOV

1119

                key = fmt.Sprintf("%s:src:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)

×

1120

×

1121

        return key

×

1124

func (c *Controller) formatVpc(vpc *kubeovnv1.Vpc) (*kubeovnv1.Vpc, error) {

×

1125

        var changed bool

×

1126

        for _, item := range vpc.Spec.StaticRoutes {

×

1127

                // check policy

×

1128

                if item.Policy == "" {

×

1129

                        item.Policy = kubeovnv1.PolicyDst

×

1130

                        changed = true

×

UNCOV

1131

×

1132

                if item.Policy != kubeovnv1.PolicyDst && item.Policy != kubeovnv1.PolicySrc {

×

1133

                        return nil, fmt.Errorf("unknown policy type: %q", item.Policy)

×

1134

×

1136

                if strings.Contains(item.CIDR, "/") {

×

1137

                        if _, _, err := net.ParseCIDR(item.CIDR); err != nil {

×

1138

                                return nil, fmt.Errorf("invalid cidr %q: %w", item.CIDR, err)

×

UNCOV

1139

×

1140

                } else if ip := net.ParseIP(item.CIDR); ip == nil {

×

1141

                        return nil, fmt.Errorf("invalid ip %q", item.CIDR)

×

1142

×

UNCOV

1144

                if ip := net.ParseIP(item.NextHopIP); ip == nil {

×

1145

                        return nil, fmt.Errorf("invalid next hop ip %q", item.NextHopIP)

×

1146

×

1149

        for _, route := range vpc.Spec.PolicyRoutes {

×

1150

                if route.Action != kubeovnv1.PolicyRouteActionReroute {

×

1151

                        if route.NextHopIP != "" {

×

1152

                                route.NextHopIP = ""

×

1153

                                changed = true

×

1154

×

1155

                } else {

×

1156

                        // ecmp policy route may reroute to multiple next hop ips

×

1157

                        for ipStr := range strings.SplitSeq(route.NextHopIP, ",") {

×

1158

                                if ip := net.ParseIP(ipStr); ip == nil {

×

UNCOV

1159

                                        err := fmt.Errorf("invalid next hop ips: %s", route.NextHopIP)

×

UNCOV

1160

                                        klog.Error(err)

×

UNCOV

1161

                                        return nil, err

×

UNCOV

1162

×

UNCOV

1167

        if vpc.DeletionTimestamp.IsZero() && !slices.Contains(vpc.GetFinalizers(), util.KubeOVNControllerFinalizer) {

×

1168

                controllerutil.AddFinalizer(vpc, util.KubeOVNControllerFinalizer)

×

1169

                changed = true

×

1170

×

UNCOV

1172

        if !vpc.DeletionTimestamp.IsZero() && len(vpc.Status.Subnets) == 0 {

×

1173

                controllerutil.RemoveFinalizer(vpc, util.KubeOVNControllerFinalizer)

×

1174

                changed = true

×

1175

×

1177

        if changed {

×

1178

                newVpc, err := c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})

×

1179

                if err != nil {

×

UNCOV

1180

                        klog.Errorf("failed to update vpc %s: %v", vpc.Name, err)

×

UNCOV

1181

                        return nil, err

×

1182

×

UNCOV

1183

                return newVpc, nil

×

1186

        return vpc, nil

×

UNCOV

1189

func convertPolicies(list []*kubeovnv1.PolicyRoute) string {

×

1190

        if list == nil {

×

1191

                return ""

×

1192

×

1194

        var (

×

1195

                res []byte

×

1196

                err error

×

1197

×

1198

×

1199

        if res, err = json.Marshal(list); err != nil {

×

UNCOV

1200

                klog.Errorf("failed to serialize policy routes %v , reason : %v", list, err)

×

UNCOV

1201

                return ""

×

1202

×

1203

        return string(res)

×

UNCOV

1206

func reversePolicies(origin string) []*kubeovnv1.PolicyRoute {

×

1207

        if origin == "" {

×

1208

                return nil

×

1209

×

1211

        var (

×

1212

                list []*kubeovnv1.PolicyRoute

×

1213

                err  error

×

1214

×

1215

×

1216

        if err = json.Unmarshal([]byte(origin), &list); err != nil {

×

UNCOV

1217

                klog.Errorf("failed to deserialize policy routes %v , reason : %v", list, err)

×

UNCOV

1218

                return nil

×

1219

×

1220

        return list

×

1223

func convertPolicy(origin kubeovnv1.RoutePolicy) string {

×

UNCOV

1224

        if origin == kubeovnv1.PolicyDst {

×

UNCOV

1225

                return ovnnb.LogicalRouterStaticRoutePolicyDstIP

×

1226

×

1227

        return ovnnb.LogicalRouterStaticRoutePolicySrcIP

×

1230

func reversePolicy(origin ovnnb.LogicalRouterStaticRoutePolicy) kubeovnv1.RoutePolicy {

×

UNCOV

1231

        if origin == ovnnb.LogicalRouterStaticRoutePolicyDstIP {

×

UNCOV

1232

                return kubeovnv1.PolicyDst

×

1233

×

1234

        return kubeovnv1.PolicySrc

×

1237

func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaultSubnet string, err error) {

×

1238

        subnets = []string{}

×

1239

        allSubnets, err := c.subnetsLister.List(labels.Everything())

×

UNCOV

1240

        if err != nil {

×

1241

                klog.Error(err)

×

1242

                return nil, "", err

×

1243

×

UNCOV

1245

        for _, subnet := range allSubnets {

×

1246

                if subnet.Spec.Vpc != vpc.Name || !subnet.DeletionTimestamp.IsZero() || !isOvnSubnet(subnet) {

×

1247

                        continue

×

UNCOV

1250

                subnets = append(subnets, subnet.Name)

×

1251

                if subnet.Spec.Default {

×

1252

                        defaultSubnet = subnet.Name

×

1253

×

1255

                if vpc.Name != util.DefaultVpc && vpc.Spec.DefaultSubnet != "" && vpc.Spec.DefaultSubnet == subnet.Name {

×

1256

                        defaultSubnet = vpc.Spec.DefaultSubnet

×

UNCOV

1257

×

UNCOV

1259

        sort.Strings(subnets)

×

1260

        return

×

1264

func (c *Controller) createVpcRouter(lr string, learnFromARPRequest bool) error {

×

UNCOV

1265

        if err := c.OVNNbClient.CreateLogicalRouter(lr); err != nil {

×

1266

                klog.Errorf("create logical router %s failed: %v", lr, err)

×

1267

                return err

×

1268

×

1270

        vpcRouter, err := c.OVNNbClient.GetLogicalRouter(lr, false)

×

UNCOV

1271

        if err != nil {

×

1272

                klog.Errorf("get logical router %s failed: %v", lr, err)

×

1273

                return err

×

1274

×

1276

        lrOptions := map[string]string{

×

1277

                "mac_binding_age_threshold": "300",

×

1278

                "dynamic_neigh_routers":     "true",

×

1279

×

1280

        if !learnFromARPRequest {

×

1281

                lrOptions["always_learn_from_arp_request"] = "false"

×

1282

×

1283

        if !maps.Equal(vpcRouter.Options, lrOptions) {

×

1284

                vpcRouter.Options = lrOptions

×

UNCOV

1285

                if err = c.OVNNbClient.UpdateLogicalRouter(vpcRouter, &vpcRouter.Options); err != nil {

×

UNCOV

1286

                        klog.Errorf("failed to update options of logical router %s: %v", lr, err)

×

1287

                        return err

×

UNCOV

1288

×

1291

        return nil

×

1295

func (c *Controller) deleteVpcRouter(lr string) error {

×

1296

        return c.OVNNbClient.DeleteLogicalRouter(lr)

×

1297

×

1299

func (c *Controller) handleAddVpcExternalSubnet(key, subnet string) error {

×

1300

        cachedSubnet, err := c.subnetsLister.Get(subnet)

×

1301

        if err != nil {

×

1302

                klog.Error(err)

×

1303

                return err

×

1304

×

1305

        lrpEipName := fmt.Sprintf("%s-%s", key, subnet)

×

1306

        cachedEip, err := c.ovnEipsLister.Get(lrpEipName)

×

1307

        var needCreateEip bool

×

1308

        if err != nil {

×

1309

                if !k8serrors.IsNotFound(err) {

×

UNCOV

1310

                        klog.Error(err)

×

1311

                        return err

×

1312

×

1313

                needCreateEip = true

×

1315

        var v4ip, v6ip, mac string

×

1316

        klog.V(3).Infof("create vpc lrp eip %s", lrpEipName)

×

1317

        if needCreateEip {

×

1318

                if v4ip, v6ip, mac, err = c.acquireIPAddress(subnet, lrpEipName, lrpEipName); err != nil {

×

1319

                        klog.Errorf("failed to acquire ip address for lrp eip %s, %v", lrpEipName, err)

×

1320

                        return err

×

1321

×

1322

                if err := c.createOrUpdateOvnEipCR(lrpEipName, subnet, v4ip, v6ip, mac, util.OvnEipTypeLRP); err != nil {

×

1323

                        klog.Errorf("failed to create ovn eip for lrp %s: %v", lrpEipName, err)

×

1324

                        return err

×

1325

×

1326

        } else {

×

1327

                v4ip = cachedEip.Spec.V4Ip

×

1328

                mac = cachedEip.Spec.MacAddress

×

1329

×

1330

        if v4ip == "" || mac == "" {

×

UNCOV

1331

                err := fmt.Errorf("lrp '%s' ip or mac should not be empty", lrpEipName)

×

1332

                klog.Error(err)

×

1333

                return err

×

1334

×

1336

        chassises := []string{}

×

1337

        sel, _ := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{util.ExGatewayLabel: "true"}})

×

1338

        gwNodes, err := c.nodesLister.List(sel)

×

1339

        if err != nil {

×

1340

                klog.Errorf("failed to list external gw nodes, %v", err)

×

1341

                return err

×

1342

×

1343

        for _, gwNode := range gwNodes {

×

1344

                annoChassisName := gwNode.Annotations[util.ChassisAnnotation]

×

1345

                if annoChassisName == "" {

×

1346

                        err := fmt.Errorf("node %s has no chassis annotation, kube-ovn-cni not ready", gwNode.Name)

×

1347

                        klog.Error(err)

×

1348

                        return err

×

1349

×

1350

                klog.Infof("get node %s chassis: %s", gwNode.Name, annoChassisName)

×

1351

                chassis, err := c.OVNSbClient.GetChassis(annoChassisName, false)

×

1352

                if err != nil {

×

UNCOV

1353

                        klog.Errorf("failed to get node %s chassis: %s, %v", gwNode.Name, annoChassisName, err)

×

UNCOV

1354

                        return err

×

1355

×

1356

                chassises = append(chassises, chassis.Name)

×

1359

        if len(chassises) == 0 {

×

UNCOV

1360

                err := errors.New("no external gw nodes")

×

1361

                klog.Error(err)

×

1362

                return err

×

1363

×

1365

        v4ipCidr, err := util.GetIPAddrWithMask(v4ip, cachedSubnet.Spec.CIDRBlock)

×

1366

        if err != nil {

×

1367

                klog.Error(err)

×

1368

                return err

×

1369

×

1370

        lspName := fmt.Sprintf("%s-%s", subnet, key)

×

1371

        lrpName := fmt.Sprintf("%s-%s", key, subnet)

×

1372

×

1373

        if err := c.OVNNbClient.CreateLogicalPatchPort(subnet, key, lspName, lrpName, v4ipCidr, mac, chassises...); err != nil {

×

UNCOV

1374

                klog.Errorf("failed to connect router '%s' to external: %v", key, err)

×

UNCOV

1375

                return err

×

1376

×

1377

        return nil

×

1380

func (c *Controller) handleDeleteVpcStaticRoute(key string) error {

×

1381

        vpc, err := c.vpcsLister.Get(key)

×

1382

        if err != nil {

×

1383

                if k8serrors.IsNotFound(err) {

×

UNCOV

1384

                        return nil

×

1385

×

1386

                klog.Errorf("failed to get vpc %s, %v", key, err)

×

1387

                return err

×

1389

        needUpdate := false

×

1390

        newStaticRoutes := make([]*kubeovnv1.StaticRoute, 0, len(vpc.Spec.StaticRoutes))

×

1391

        for _, route := range vpc.Spec.StaticRoutes {

×

UNCOV

1392

                if route.ECMPMode != util.StaticRouteBfdEcmp {

×

UNCOV

1393

                        newStaticRoutes = append(newStaticRoutes, route)

×

1394

                        needUpdate = true

×

1395

×

1398

        vpc.Spec.StaticRoutes = newStaticRoutes

×

1399

        if needUpdate {

×

UNCOV

1400

                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {

×

1401

                        klog.Errorf("failed to update vpc spec static route %s, %v", vpc.Name, err)

×

1402

                        return err

×

1403

×

1405

        if err = c.patchVpcBfdStatus(vpc.Name); err != nil {

×

UNCOV

1406

                klog.Errorf("failed to patch vpc %s, %v", vpc.Name, err)

×

UNCOV

1407

                return err

×

1408

×

1409

        return nil

×

1412

func (c *Controller) handleDelVpcExternalSubnet(key, subnet string) error {

×

1413

        lspName := fmt.Sprintf("%s-%s", subnet, key)

×

1414

        lrpName := fmt.Sprintf("%s-%s", key, subnet)

×

1415

        klog.Infof("delete vpc lrp %s", lrpName)

×

1416

        if err := c.OVNNbClient.RemoveLogicalPatchPort(lspName, lrpName); err != nil {

×

1417

                klog.Errorf("failed to disconnect router '%s' to external, %v", key, err)

×

1418

                return err

×

1419

×

1420

        if err := c.config.KubeOvnClient.KubeovnV1().OvnEips().Delete(context.Background(), lrpName, metav1.DeleteOptions{}); err != nil {

×

UNCOV

1421

                if !k8serrors.IsNotFound(err) {

×

1422

                        klog.Errorf("failed to delete ovn eip %s, %v", lrpName, err)

×

1423

                        return err

×

1424

×

1426

        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpName, ""); err != nil {

×

UNCOV

1427

                klog.Error(err)

×

UNCOV

1428

                return err

×

1429

×

1430

        return nil

×

1433

func (c *Controller) patchVpcBfdStatus(key string) error {

×

1434

        cachedVpc, err := c.vpcsLister.Get(key)

×

1435

        if err != nil {

×

1436

                if k8serrors.IsNotFound(err) {

×

UNCOV

1437

                        return nil

×

UNCOV

1438

×

1439

                klog.Errorf("failed to get vpc %s, %v", key, err)

×

1440

                return err

×

1443

        if cachedVpc.Status.EnableBfd != cachedVpc.Spec.EnableBfd {

×

1444

                status := cachedVpc.Status.DeepCopy()

×

1445

                status.EnableExternal = cachedVpc.Spec.EnableExternal

×

1446

                status.EnableBfd = cachedVpc.Spec.EnableBfd

×

1447

                bytes, err := status.Bytes()

×

1448

                if err != nil {

×

1449

                        klog.Errorf("failed to marshal vpc status: %v", err)

×

1450

                        return err

×

1451

×

1452

                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),

×

UNCOV

1453

                        cachedVpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {

×

1454

                        klog.Error(err)

×

UNCOV

1455

                        return err

×

UNCOV

1456

×

1458

        return nil

×

1461

func (c *Controller) getRouteTablesByVpc(vpc *kubeovnv1.Vpc) map[string][]*kubeovnv1.StaticRoute {

×

1462

        rtbs := make(map[string][]*kubeovnv1.StaticRoute)

×

UNCOV

1463

        for _, route := range vpc.Spec.StaticRoutes {

×

UNCOV

1464

                rtbs[route.RouteTable] = append(rtbs[route.RouteTable], route)

×

1465

×

1466

        return rtbs

×

1469

func (c *Controller) updateVpcExternalStatus(key string, enableExternal bool) error {

×

1470

        cachedVpc, err := c.vpcsLister.Get(key)

×

1471

        if err != nil {

×

1472

                klog.Errorf("failed to get vpc %s, %v", key, err)

×

1473

                return err

×

1474

×

1475

        vpc := cachedVpc.DeepCopy()

×

1476

        vpc.Status.EnableExternal = vpc.Spec.EnableExternal

×

1477

        vpc.Status.EnableBfd = vpc.Spec.EnableBfd

×

1478

×

1479

        if enableExternal {

×

1480

                sort.Strings(vpc.Spec.ExtraExternalSubnets)

×

UNCOV

1481

                vpc.Status.ExtraExternalSubnets = vpc.Spec.ExtraExternalSubnets

×

1482

        } else {

×

1483

                vpc.Status.ExtraExternalSubnets = nil

×

1484

×

1486

        bytes, err := vpc.Status.Bytes()

×

1487

        if err != nil {

×

1488

                klog.Errorf("failed to get vpc bytes, %v", err)

×

1489

                return err

×

1490

×

1491

        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),

×

UNCOV

1492

                vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {

×

1493

                klog.Errorf("failed to patch vpc %s, %v", key, err)

×

UNCOV

1494

                return err

×

UNCOV

1495

×

UNCOV

1497

        return nil

×

kubeovn / kube-ovn / 16719503087

Source File
Press 'n' to go to next uncovered line, 'b' for previous

kubeovn / kube-ovn / 16719503087

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous