510183623a1afcec86a81c40dc2c479a483e7ff7

Committed 03 Aug 2025 05:27PM UTC coverage: 84.181% (-0.01%) from 84.192%

Build # 510183623a1afcec86a81c40dc2c479a483e7ff7

Build Type

Pull #85

github

Committed by

camatcode

Commit Message

refactor: Reader behaviour

Pull Request Pull Request #85: refactor: Reader behaviour

Run Details

59 of 62 new or added lines in 6 files covered. (95.16%)

13 existing lines in 6 files now uncovered.

1208 of 1435 relevant lines covered (84.18%)

491.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.31

/lib/basenji/reader/cbz_reader.ex

defmodule Basenji.Reader.CBZReader do
  @moduledoc false
  @behaviour Basenji.Reader

  use Basenji.TelemetryHelpers

  alias Basenji.Reader

  @impl Reader
  def format, do: :cbz

  @impl Reader
  def file_extensions, do: ["cbz"]

  @impl Reader
  def magic_numbers, do: [%{offset: 0, magic: [0x50, 0x4B, 0x03, 0x04]}]

  @impl Reader
  def get_entries(cbz_file_path, _opts \\ []) do
    with {:ok, output} <- Reader.exec("zipinfo", ["-1", cbz_file_path]) do
      file_names = output |> String.split("\n")

      file_entries =
        file_names
        |> Enum.map(&%{file_name: &1})
        |> Reader.sort_and_reject()

      {:ok, %{entries: file_entries}}
    end
  end

  def read(cbz_file_path, _opts \\ []) do
    meter_duration [:basenji, :process], "read_cbz" do
      with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do
        file_entries =
          file_entries
          |> Enum.map(fn entry ->
            entry
            |> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)
          end)

        {:ok, %{entries: file_entries}}
      end
    end
  end

  @impl Reader
  def get_entry_stream!(cbz_file_path, entry),
    do: Reader.create_resource("unzip", ["-p", cbz_file_path, entry[:file_name]])

  @impl Reader
  def close(_), do: :ok
end

1	defmodule Basenji.Reader.CBZReader do
2	@moduledoc false
3	@behaviour Basenji.Reader
4
5	use Basenji.TelemetryHelpers
6
7	alias Basenji.Reader
8
9	@impl Reader
10	def format, do: :cbz	30✔
11
12	@impl Reader
13	def file_extensions, do: ["cbz"]	4,079✔
14
15	@impl Reader
16	def magic_numbers, do: [%{offset: 0, magic: [0x50, 0x4B, 0x03, 0x04]}]	895✔
17
18	@impl Reader
19	def get_entries(cbz_file_path, _opts \\ []) do
20	with {:ok, output} <- Reader.exec("zipinfo", ["-1", cbz_file_path]) do	899✔
21	file_names = output \|> String.split("\n")	898✔
22
23	file_entries =	898✔
24	file_names
25	\|> Enum.map(&%{file_name: &1})	4,307✔
26	\|> Reader.sort_and_reject()
27
28	{:ok, %{entries: file_entries}}
29	end
30	end
31
32	def read(cbz_file_path, _opts \\ []) do
33	meter_duration [:basenji, :process], "read_cbz" do	867✔
NEW 34	with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do	×
35	file_entries =	867✔
36	file_entries
37	\|> Enum.map(fn entry ->
38	entry
39	\|> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)	3,468✔
40	end)
41
42	{:ok, %{entries: file_entries}}
43	end
44	end
45	end
46
47	@impl Reader
48	def get_entry_stream!(cbz_file_path, entry),
49	do: Reader.create_resource("unzip", ["-p", cbz_file_path, entry[:file_name]])	246✔
50
51	@impl Reader
52	def close(_), do: :ok	30✔
53	end

camatcode / basenji / 510183623a1afcec86a81c40dc2c479a483e7ff7

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous