510183623a1afcec86a81c40dc2c479a483e7ff7

Committed 03 Aug 2025 05:27PM UTC coverage: 84.181% (-0.01%) from 84.192%

Build # 510183623a1afcec86a81c40dc2c479a483e7ff7

Build Type

Pull #85

github

Committed by

camatcode

Commit Message

refactor: Reader behaviour

Pull Request Pull Request #85: refactor: Reader behaviour

Run Details

59 of 62 new or added lines in 6 files covered. (95.16%)

13 existing lines in 6 files now uncovered.

1208 of 1435 relevant lines covered (84.18%)

491.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.33

/lib/basenji/reader/cbt_reader.ex

defmodule Basenji.Reader.CBTReader do
  @moduledoc false
  @behaviour Basenji.Reader

  use Basenji.TelemetryHelpers

  alias Basenji.Reader

  @impl Reader
  def format, do: :cbt

  @impl Reader
  def file_extensions, do: ["cbt"]

  @impl Reader
  def magic_numbers, do: [%{offset: 257, magic: ~c"ustar"}]

  @impl Reader
  def get_entries(cbz_file_path, _opts \\ []) do
    with {:ok, file_names} <- :erl_tar.table(cbz_file_path, [:compressed]) do
      file_entries =
        file_names
        |> Enum.map(&%{file_name: "#{&1}"})
        |> Reader.sort_and_reject()

      {:ok, %{entries: file_entries}}
    end
  end

  def read(cbz_file_path, _opts \\ []) do
    meter_duration [:basenji, :process], "read_cbt" do
      with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do
        file_entries =
          file_entries
          |> Enum.map(fn entry ->
            entry
            |> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)
          end)

        {:ok, %{entries: file_entries}}
      end
    end
  end

  @impl Reader
  def get_entry_stream!(cbz_file_path, entry) do
    escaped_filename = entry[:file_name]

    file_name = ~c"#{escaped_filename}"

    Reader.create_resource(fn ->
      with {:ok, [{^file_name, data}]} <-
             :erl_tar.extract(cbz_file_path, [
               {:files, [file_name]},
               :compressed,
               :memory
             ]) do
        [data |> :binary.bin_to_list()]
      end
    end)
  end

  @impl Reader
  def close(_), do: :ok
end

1	defmodule Basenji.Reader.CBTReader do
2	@moduledoc false
3	@behaviour Basenji.Reader
4
5	use Basenji.TelemetryHelpers
6
7	alias Basenji.Reader
8
9	@impl Reader
10	def format, do: :cbt	6✔
11
12	@impl Reader
13	def file_extensions, do: ["cbt"]	1,601✔
14
15	@impl Reader
16	def magic_numbers, do: [%{offset: 257, magic: ~c"ustar"}]	819✔
17
18	@impl Reader
19	def get_entries(cbz_file_path, _opts \\ []) do
20	with {:ok, file_names} <- :erl_tar.table(cbz_file_path, [:compressed]) do	823✔
21	file_entries =	823✔
22	file_names
23	\|> Enum.map(&%{file_name: "#{&1}"})	3,292✔
24	\|> Reader.sort_and_reject()
25
26	{:ok, %{entries: file_entries}}
27	end
28	end
29
30	def read(cbz_file_path, _opts \\ []) do
31	meter_duration [:basenji, :process], "read_cbt" do	815✔
NEW 32	with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do	×
33	file_entries =	815✔
34	file_entries
35	\|> Enum.map(fn entry ->
36	entry
37	\|> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)	3,260✔
38	end)
39
40	{:ok, %{entries: file_entries}}
41	end
42	end
43	end
44
45	@impl Reader
46	def get_entry_stream!(cbz_file_path, entry) do
47	escaped_filename = entry[:file_name]	96✔
48
49	file_name = ~c"#{escaped_filename}"	96✔
50
51	Reader.create_resource(fn ->	96✔
52	with {:ok, [{^file_name, data}]} <-	96✔
53	:erl_tar.extract(cbz_file_path, [
54	{:files, [file_name]},
55	:compressed,
56	:memory
57	]) do
58	[data \|> :binary.bin_to_list()]
59	end
60	end)
61	end
62
63	@impl Reader
64	def close(_), do: :ok	6✔
65	end

camatcode / basenji / 510183623a1afcec86a81c40dc2c479a483e7ff7

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous