4e6ab01ab8578dff199cf92f5b41a9c641c12b53

Committed 03 Aug 2025 05:03PM UTC coverage: 84.192%. Remained the same

Build # 4e6ab01ab8578dff199cf92f5b41a9c641c12b53

Build Type

Pull #85

github

Committed by

camatcode

Commit Message

refactor: Reader behaviour

Pull Request Pull Request #85: refactor: Reader behaviour

Run Details

46 of 46 new or added lines in 6 files covered. (100.0%)

16 existing lines in 8 files now uncovered.

1209 of 1436 relevant lines covered (84.19%)

487.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.33

/lib/basenji/reader/cbz_reader.ex

defmodule Basenji.Reader.CBZReader do
  @moduledoc false
  @behaviour Basenji.Reader

  use Basenji.TelemetryHelpers

  alias Basenji.Reader

  @impl Reader
  def format, do: :cbz

  @impl Reader
  def file_extensions, do: ["cbz"]

  @impl Reader
  def magic_numbers, do: [%{offset: 0, magic: [0x50, 0x4B, 0x03, 0x04]}]

  @impl Reader
  def get_entries(cbz_file_path, _opts \\ []) do
    with {:ok, output} <- Reader.exec("zipinfo", ["-1", cbz_file_path]) do
      file_names = output |> String.split("\n")

      file_entries =
        file_names
        |> Enum.map(&%{file_name: &1})
        |> Reader.sort_file_names()
        |> Reader.reject_macos_preview()
        |> Reader.reject_directories()
        |> Reader.reject_non_image()

      {:ok, %{entries: file_entries}}
    end
  end

  @impl Reader
  def read(cbz_file_path, _opts \\ []) do
    meter_duration [:basenji, :process], "read_cbz" do
      with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do
        file_entries =
          file_entries
          |> Enum.map(fn entry ->
            entry
            |> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)
          end)

        {:ok, %{entries: file_entries}}
      end
    end
  end

  @impl Reader
  def close(_), do: :ok

  defp get_entry_stream!(cbz_file_path, entry) do
    Reader.create_resource(fn ->
      escaped_filename = entry[:file_name]

      with {:ok, output} <- Reader.exec("unzip", ["-p", cbz_file_path, escaped_filename]) do
        [output |> :binary.bin_to_list()]
      end
    end)
  end
end

1	defmodule Basenji.Reader.CBZReader do
2	@moduledoc false
3	@behaviour Basenji.Reader
4
5	use Basenji.TelemetryHelpers
6
7	alias Basenji.Reader
8
9	@impl Reader
10	def format, do: :cbz	29✔
11
12	@impl Reader
13	def file_extensions, do: ["cbz"]	4,059✔
14
15	@impl Reader
16	def magic_numbers, do: [%{offset: 0, magic: [0x50, 0x4B, 0x03, 0x04]}]	895✔
17
18	@impl Reader
19	def get_entries(cbz_file_path, _opts \\ []) do
20	with {:ok, output} <- Reader.exec("zipinfo", ["-1", cbz_file_path]) do	899✔
21	file_names = output \|> String.split("\n")	898✔
22
23	file_entries =	898✔
24	file_names
25	\|> Enum.map(&%{file_name: &1})	4,305✔
26	\|> Reader.sort_file_names()
27	\|> Reader.reject_macos_preview()
28	\|> Reader.reject_directories()
29	\|> Reader.reject_non_image()
30
31	{:ok, %{entries: file_entries}}
32	end
33	end
34
35	@impl Reader
36	def read(cbz_file_path, _opts \\ []) do
37	meter_duration [:basenji, :process], "read_cbz" do	897✔
UNCOV 38	with {:ok, %{entries: file_entries}} <- get_entries(cbz_file_path) do	×
39	file_entries =	897✔
40	file_entries
41	\|> Enum.map(fn entry ->
42	entry
43	\|> Map.put(:stream_fun, fn -> get_entry_stream!(cbz_file_path, entry) end)	3,588✔
44	end)
45
46	{:ok, %{entries: file_entries}}
47	end
48	end
49	end
50
51	@impl Reader
52	def close(_), do: :ok	29✔
53
54	defp get_entry_stream!(cbz_file_path, entry) do
55	Reader.create_resource(fn ->	258✔
56	escaped_filename = entry[:file_name]	258✔
57
58	with {:ok, output} <- Reader.exec("unzip", ["-p", cbz_file_path, escaped_filename]) do	258✔
59	[output \|> :binary.bin_to_list()]
60	end
61	end)
62	end
63	end

camatcode / basenji / 4e6ab01ab8578dff199cf92f5b41a9c641c12b53

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous