16665088909

Committed 01 Aug 2025 02:55AM UTC coverage: 46.166% (-0.1%) from 46.31%

Build # 16665088909

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #2630 from mavlink/pr-segfault-fixes

Stack-use-after-free and thread-safety fixes, CI additions, clang-format-19

Run Details

241 of 320 new or added lines in 32 files covered. (75.31%)

39 existing lines in 10 files now uncovered.

16101 of 34876 relevant lines covered (46.17%)

361.1 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/mavsdk/plugins/mission/mission_impl.cpp

#include "mission_impl.h"
#include "system.h"
#include "unused.h"
#include "callback_list.tpp"
#include <algorithm>
#include <cmath>

namespace mavsdk {

template class CallbackList<Mission::MissionProgress>;

using MissionItem = Mission::MissionItem;
using CameraAction = Mission::MissionItem::CameraAction;
using VehicleAction = Mission::MissionItem::VehicleAction;

MissionImpl::MissionImpl(System& system) : PluginImplBase(system)
{
    _system_impl->register_plugin(this);
}

MissionImpl::MissionImpl(std::shared_ptr<System> system) : PluginImplBase(std::move(system))
{
    _system_impl->register_plugin(this);
}

MissionImpl::~MissionImpl()
{
    _system_impl->unregister_plugin(this);
}

void MissionImpl::init()
{
    _system_impl->register_mavlink_message_handler(
        MAVLINK_MSG_ID_MISSION_CURRENT,
        [this](const mavlink_message_t& message) { process_mission_current(message); },
        this);

    _system_impl->register_mavlink_message_handler(
        MAVLINK_MSG_ID_MISSION_ITEM_REACHED,
        [this](const mavlink_message_t& message) { process_mission_item_reached(message); },
        this);
}

void MissionImpl::enable() {}

void MissionImpl::disable()
{
    reset_mission_progress();
}

void MissionImpl::deinit()
{
    _system_impl->unregister_timeout_handler(_timeout_cookie);
    _system_impl->unregister_all_mavlink_message_handlers(this);
}

void MissionImpl::reset_mission_progress()
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    _mission_data.last_current_mavlink_mission_item = -1;
    _mission_data.last_reached_mavlink_mission_item = -1;
    _mission_data.last_current_reported_mission_item = -1;
    _mission_data.last_total_reported_mission_item = -1;
}

void MissionImpl::process_mission_current(const mavlink_message_t& message)
{
    mavlink_mission_current_t mission_current;
    mavlink_msg_mission_current_decode(&message, &mission_current);

    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    _mission_data.last_current_mavlink_mission_item = mission_current.seq;
    _mission_data.mission_state = mission_current.mission_state;
    report_progress_locked();
}

void MissionImpl::process_mission_item_reached(const mavlink_message_t& message)
{
    mavlink_mission_item_reached_t mission_item_reached;
    mavlink_msg_mission_item_reached_decode(&message, &mission_item_reached);

    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    _mission_data.last_reached_mavlink_mission_item = mission_item_reached.seq;
    report_progress_locked();
}

Mission::Result MissionImpl::upload_mission(const Mission::MissionPlan& mission_plan)
{
    auto prom = std::promise<Mission::Result>();
    auto fut = prom.get_future();

    upload_mission_async(mission_plan, [&prom](Mission::Result result) { prom.set_value(result); });
    return fut.get();
}

void MissionImpl::upload_mission_async(
    const Mission::MissionPlan& mission_plan, const Mission::ResultCallback& callback)
{
    if (_mission_data.last_upload.lock()) {
        _system_impl->call_user_callback([callback]() {
            if (callback) {
                callback(Mission::Result::Busy);
            }
        });
        return;
    }

    reset_mission_progress();

    const auto int_items = convert_to_int_items(mission_plan.mission_items);

    _mission_data.last_upload = _system_impl->mission_transfer_client().upload_items_async(
        MAV_MISSION_TYPE_MISSION,
        _system_impl->get_system_id(),
        int_items,
        [this, callback](MavlinkMissionTransferClient::Result result) {
            auto converted_result = convert_result(result);
            _system_impl->call_user_callback([callback, converted_result]() {
                if (callback) {
                    callback(converted_result);
                }
            });
        });
}

void MissionImpl::upload_mission_with_progress_async(
    const Mission::MissionPlan& mission_plan,
    const Mission::UploadMissionWithProgressCallback callback)
{
    if (_mission_data.last_upload.lock()) {
        _system_impl->call_user_callback([callback]() {
            if (callback) {
                callback(Mission::Result::Busy, Mission::ProgressData{});
            }
        });
        return;
    }

    reset_mission_progress();

    const auto int_items = convert_to_int_items(mission_plan.mission_items);

    _mission_data.last_upload = _system_impl->mission_transfer_client().upload_items_async(
        MAV_MISSION_TYPE_MISSION,
        _system_impl->get_system_id(),
        int_items,
        [this, callback](MavlinkMissionTransferClient::Result result) {
            auto converted_result = convert_result(result);
            _system_impl->call_user_callback([callback, converted_result]() {
                if (callback) {
                    callback(converted_result, Mission::ProgressData{});
                }
            });
        },
        [this, callback](float progress) {
            _system_impl->call_user_callback([callback, progress]() {
                if (callback) {
                    callback(Mission::Result::Next, Mission::ProgressData{progress});
                }
            });
        });
}

Mission::Result MissionImpl::cancel_mission_upload() const
{
    auto ptr = _mission_data.last_upload.lock();
    if (ptr) {
        ptr->cancel();
    } else {
        LogWarn() << "No mission upload to cancel... ignoring";
    }

    return Mission::Result::Success;
}

std::pair<Mission::Result, Mission::MissionPlan> MissionImpl::download_mission()
{
    auto prom = std::promise<std::pair<Mission::Result, Mission::MissionPlan>>();
    auto fut = prom.get_future();

    download_mission_async(
        [&prom](Mission::Result result, const Mission::MissionPlan& mission_plan) {
            prom.set_value(std::make_pair<>(result, mission_plan));
        });
    return fut.get();
}

void MissionImpl::download_mission_async(const Mission::DownloadMissionCallback& callback)
{
    if (_mission_data.last_download.lock()) {
        _system_impl->call_user_callback([callback]() {
            if (callback) {
                Mission::MissionPlan mission_plan{};
                callback(Mission::Result::Busy, mission_plan);
            }
        });
        return;
    }

    _mission_data.last_download = _system_impl->mission_transfer_client().download_items_async(
        MAV_MISSION_TYPE_MISSION,
        _system_impl->get_system_id(),
        [this, callback](
            MavlinkMissionTransferClient::Result result,
            std::vector<MavlinkMissionTransferClient::ItemInt> items) {
            auto result_and_items = convert_to_result_and_mission_items(result, items);
            _system_impl->call_user_callback([callback, result_and_items]() {
                callback(result_and_items.first, result_and_items.second);
            });
        });
}

void MissionImpl::download_mission_with_progress_async(
    const Mission::DownloadMissionWithProgressCallback callback)
{
    if (_mission_data.last_download.lock()) {
        _system_impl->call_user_callback([callback]() {
            if (callback) {
                Mission::ProgressDataOrMission progress_data_or_mission{};
                progress_data_or_mission.has_mission = false;
                progress_data_or_mission.has_progress = false;
                callback(Mission::Result::Busy, progress_data_or_mission);
            }
        });
        return;
    }

    _mission_data.last_download = _system_impl->mission_transfer_client().download_items_async(
        MAV_MISSION_TYPE_MISSION,
        _system_impl->get_system_id(),
        [this, callback](
            MavlinkMissionTransferClient::Result result,
            const std::vector<MavlinkMissionTransferClient::ItemInt>& items) {
            auto result_and_items = convert_to_result_and_mission_items(result, items);
            _system_impl->call_user_callback([callback, result_and_items]() {
                if (result_and_items.first == Mission::Result::Success) {
                    Mission::ProgressDataOrMission progress_data_or_mission{};
                    progress_data_or_mission.has_mission = true;
                    progress_data_or_mission.mission_plan = result_and_items.second;
                    callback(Mission::Result::Next, progress_data_or_mission);
                }

                callback(result_and_items.first, Mission::ProgressDataOrMission{});
            });
        },
        [this, callback](float progress) {
            _system_impl->call_user_callback([callback, progress]() {
                Mission::ProgressDataOrMission progress_data_or_mission{};
                progress_data_or_mission.has_progress = true;
                progress_data_or_mission.progress = progress;
                callback(Mission::Result::Next, progress_data_or_mission);
            });
        });
}

Mission::Result MissionImpl::cancel_mission_download() const
{
    auto ptr = _mission_data.last_download.lock();
    if (ptr) {
        ptr->cancel();
    } else {
        LogWarn() << "No mission download to cancel... ignoring";
    }

    return Mission::Result::Success;
}

Mission::Result MissionImpl::set_return_to_launch_after_mission(bool enable_rtl)
{
    _enable_return_to_launch_after_mission = enable_rtl;
    return Mission::Result::Success;
}

std::pair<Mission::Result, bool> MissionImpl::get_return_to_launch_after_mission()
{
    return std::make_pair<>(Mission::Result::Success, _enable_return_to_launch_after_mission);
}

bool MissionImpl::has_valid_position(const MissionItem& item)
{
    return std::isfinite(item.latitude_deg) && std::isfinite(item.longitude_deg) &&
           std::isfinite(item.relative_altitude_m);
}

float MissionImpl::hold_time(const MissionItem& item)
{
    float hold_time_s;
    if (item.is_fly_through) {
        hold_time_s = 0.0f;
    } else {
        hold_time_s = 0.5f;
    }

    return hold_time_s;
}

float MissionImpl::acceptance_radius(const MissionItem& item)
{
    float acceptance_radius_m;
    if (std::isfinite(item.acceptance_radius_m)) {
        acceptance_radius_m = item.acceptance_radius_m;
    } else if (item.is_fly_through) {
        // _acceptance_radius_m is 0, determine the radius using fly_through
        acceptance_radius_m = 3.0f;
    } else {
        // _acceptance_radius_m is 0, determine the radius using fly_through
        acceptance_radius_m = 1.0f;
    }

    return acceptance_radius_m;
}

std::vector<MavlinkMissionTransferClient::ItemInt>
MissionImpl::convert_to_int_items(const std::vector<MissionItem>& mission_items)
{
    std::vector<MavlinkMissionTransferClient::ItemInt> int_items;

    bool last_position_valid = false; // This flag is to protect us from using an invalid x/y.

    unsigned item_i = 0;
    _mission_data.mavlink_mission_item_to_mission_item_indices.clear();
    _mission_data.gimbal_v2_in_control = false;

    for (const auto& item : mission_items) {
        if (item.vehicle_action == VehicleAction::Takeoff) {
            // There is a vehicle action that we need to send.

            // Current is the 0th waypoint
            uint8_t current = ((int_items.size() == 0) ? 1 : 0);

            uint8_t autocontinue = 1;

            const int32_t x = int32_t(std::round(item.latitude_deg * 1e7));
            const int32_t y = int32_t(std::round(item.longitude_deg * 1e7));
            float z = item.relative_altitude_m;
            MAV_FRAME frame = MAV_FRAME_GLOBAL_RELATIVE_ALT_INT;

            MavlinkMissionTransferClient::ItemInt next_item{
                static_cast<uint16_t>(int_items.size()),
                (uint8_t)frame,
                MAV_CMD_NAV_TAKEOFF,
                current,
                autocontinue,
                NAN,
                NAN,
                NAN,
                NAN,
                x,
                y,
                z,
                MAV_MISSION_TYPE_MISSION};

            _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
            int_items.push_back(next_item);
        } else {
            if (has_valid_position(item)) {
                // Current is the 0th waypoint
                const uint8_t current = ((int_items.size() == 0) ? 1 : 0);

                const int32_t x = int32_t(std::round(item.latitude_deg * 1e7));
                const int32_t y = int32_t(std::round(item.longitude_deg * 1e7));
                const float z = item.relative_altitude_m;

                MavlinkMissionTransferClient::ItemInt next_item{
                    static_cast<uint16_t>(int_items.size()),
                    static_cast<uint8_t>(MAV_FRAME_GLOBAL_RELATIVE_ALT_INT),
                    static_cast<uint8_t>(MAV_CMD_NAV_WAYPOINT),
                    current,
                    1, // autocontinue
                    hold_time(item),
                    acceptance_radius(item),
                    0.0f,
                    item.yaw_deg,
                    x,
                    y,
                    z,
                    MAV_MISSION_TYPE_MISSION};

                last_position_valid = true; // because we checked has_valid_position

                _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
                int_items.push_back(next_item);
            }
        }

        if (std::isfinite(item.speed_m_s)) {
            // The speed has changed, we need to add a speed command.

            // Current is the 0th waypoint
            uint8_t current = ((int_items.size() == 0) ? 1 : 0);

            uint8_t autocontinue = 1;

            MavlinkMissionTransferClient::ItemInt next_item{
                static_cast<uint16_t>(int_items.size()),
                MAV_FRAME_MISSION,
                MAV_CMD_DO_CHANGE_SPEED,
                current,
                autocontinue,
                1.0f, // ground speed
                item.speed_m_s,
                -1.0f, // no throttle change
                0.0f, // absolute
                0,
                0,
                NAN,
                MAV_MISSION_TYPE_MISSION};

            _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
            int_items.push_back(next_item);
        }

        if (std::isfinite(item.gimbal_yaw_deg) || std::isfinite(item.gimbal_pitch_deg)) {
            if (!_mission_data.gimbal_v2_in_control) {
                acquire_gimbal_control_v2(int_items, item_i);
                _mission_data.gimbal_v2_in_control = true;
            }
            add_gimbal_items_v2(int_items, item_i, item.gimbal_pitch_deg, item.gimbal_yaw_deg);
        }

        // A loiter time of NAN is ignored but also a loiter time of 0 doesn't
        // make any sense and should be discarded.
        if (std::isfinite(item.loiter_time_s) && item.loiter_time_s > 0.0f) {
            if (!last_position_valid) {
                // In the case where we get a delay without a previous position, we will have to
                // ignore it.
                LogErr() << "Can't set camera action delay without previous position set.";

            } else {
                // Current is the 0th waypoint
                uint8_t current = ((int_items.size() == 0) ? 1 : 0);

                uint8_t autocontinue = 1;

                MavlinkMissionTransferClient::ItemInt next_item{
                    static_cast<uint16_t>(int_items.size()),
                    MAV_FRAME_MISSION,
                    MAV_CMD_NAV_DELAY,
                    current,
                    autocontinue,
                    item.loiter_time_s, // loiter time in seconds
                    -1, // no specified hour
                    -1, // no specified minute
                    -1, // no specified second
                    0,
                    0,
                    0,
                    MAV_MISSION_TYPE_MISSION};

                _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
                int_items.push_back(next_item);
            }

            if (item.is_fly_through) {
                LogWarn() << "Conflicting options set: fly_through=true and loiter_time>0.";
            }
        }

        if (item.camera_action != CameraAction::None) {
            // Current is the 0th waypoint
            uint8_t current = ((int_items.size() == 0) ? 1 : 0);
            uint8_t autocontinue = 1;

            uint16_t command = 0;
            float param1 = NAN;
            float param2 = NAN;
            float param3 = NAN;
            float param4 = NAN;
            switch (item.camera_action) {
                case CameraAction::TakePhoto:
                    command = MAV_CMD_IMAGE_START_CAPTURE;
                    param1 = 0.0f; // all camera IDs
                    param2 = 0.0f; // no duration, take only one picture
                    param3 = 1.0f; // only take one picture
                    param4 = 0.0f; // no capture sequence
                    break;
                case CameraAction::StartPhotoInterval:
                    command = MAV_CMD_IMAGE_START_CAPTURE;
                    param1 = 0.0f; // all camera IDs
                    param2 = item.camera_photo_interval_s;
                    param3 = 0.0f; // unlimited photos
                    param4 = 0.0f; // no capture sequence
                    break;
                case CameraAction::StopPhotoInterval:
                    command = MAV_CMD_IMAGE_STOP_CAPTURE;
                    param1 = 0.0f; // all camera IDs
                    break;
                case CameraAction::StartVideo:
                    command = MAV_CMD_VIDEO_START_CAPTURE;
                    param1 = 0.0f; // all camera IDs
                    param2 = 0.0f; // no status frequency messages to send
                    break;
                case CameraAction::StopVideo:
                    command = MAV_CMD_VIDEO_STOP_CAPTURE;
                    param1 = 0.0f; // all camera IDs
                    break;
                case CameraAction::StartPhotoDistance:
                    command = MAV_CMD_DO_SET_CAM_TRIGG_DIST;
                    if (std::isfinite(item.camera_photo_distance_m)) {
                        LogErr() << "No photo distance specified";
                    }
                    param1 = item.camera_photo_distance_m; // enable with distance
                    param2 = 0.0f; // ignore
                    param3 = 1.0f; // trigger
                    break;
                case CameraAction::StopPhotoDistance:
                    command = MAV_CMD_DO_SET_CAM_TRIGG_DIST;
                    param1 = 0.0f; // stop
                    param2 = 0.0f; // ignore
                    param3 = 0.0f; // no trigger
                    break;
                default:
                    LogErr() << "Camera action not supported";
                    break;
            }

            MavlinkMissionTransferClient::ItemInt next_item{
                static_cast<uint16_t>(int_items.size()),
                MAV_FRAME_MISSION,
                command,
                current,
                autocontinue,
                param1,
                param2,
                param3,
                param4,
                0,
                0,
                NAN,
                MAV_MISSION_TYPE_MISSION};

            _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
            int_items.push_back(next_item);
        }

        if (item.vehicle_action != VehicleAction::None &&
            item.vehicle_action != VehicleAction::Takeoff) {
            // There is a vehicle action that we need to send.

            // Current is the 0th waypoint
            uint8_t current = ((int_items.size() == 0) ? 1 : 0);

            uint8_t autocontinue = 1;

            uint16_t command = 0;
            float param1 = NAN;
            float param2 = NAN;
            float param3 = NAN;
            switch (item.vehicle_action) {
                case VehicleAction::Land:
                    command = MAV_CMD_NAV_LAND; // Land at current position with same heading
                    break;
                case VehicleAction::TransitionToFw:
                    command = MAV_CMD_DO_VTOL_TRANSITION; // Do transition
                    param1 = MAV_VTOL_STATE_FW; // Target state is Fixed-Wing
                    param2 = 0; // Normal transition
                    break;
                case VehicleAction::TransitionToMc:
                    command = MAV_CMD_DO_VTOL_TRANSITION;
                    param1 = MAV_VTOL_STATE_MC; // Target state is Multi-Copter
                    param2 = 0; // Normal transition
                    break;
                default:
                    LogErr() << "Error: vehicle action not supported";
                    break;
            }

            const int32_t x = int32_t(std::round(item.latitude_deg * 1e7));
            const int32_t y = int32_t(std::round(item.longitude_deg * 1e7));
            float z = item.relative_altitude_m;
            MAV_FRAME frame = MAV_FRAME_GLOBAL_RELATIVE_ALT_INT;

            if (command == MAV_CMD_NAV_LAND) {
                z = 0;
            }

            if (command == MAV_CMD_DO_VTOL_TRANSITION) {
                frame = MAV_FRAME_MISSION;
            }

            MavlinkMissionTransferClient::ItemInt next_item{
                static_cast<uint16_t>(int_items.size()),
                (uint8_t)frame,
                command,
                current,
                autocontinue,
                param1,
                param2,
                param3,
                NAN,
                x,
                y,
                z,
                MAV_MISSION_TYPE_MISSION};

            _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
            int_items.push_back(next_item);
        }

        ++item_i;
    }

    // We need to decrement the item_i again because it was increased in the loop above
    // but the last items below still belong to the last mission item.
    --item_i;

    if (_mission_data.gimbal_v2_in_control) {
        release_gimbal_control_v2(int_items, item_i);
        _mission_data.gimbal_v2_in_control = false;
    }

    if (_enable_return_to_launch_after_mission) {
        MavlinkMissionTransferClient::ItemInt next_item{
            static_cast<uint16_t>(int_items.size()),
            MAV_FRAME_MISSION,
            MAV_CMD_NAV_RETURN_TO_LAUNCH,
            0, // current
            1, // autocontinue
            NAN, // loiter time in seconds
            NAN, // empty
            NAN, // radius around waypoint in meters ?
            NAN, // loiter at center of waypoint
            0,
            0,
            0,
            MAV_MISSION_TYPE_MISSION};

        _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
        int_items.push_back(next_item);
    }
    return int_items;
}

std::pair<Mission::Result, Mission::MissionPlan> MissionImpl::convert_to_result_and_mission_items(
    MavlinkMissionTransferClient::Result result,
    const std::vector<MavlinkMissionTransferClient::ItemInt>& int_items)
{
    std::pair<Mission::Result, Mission::MissionPlan> result_pair;

    result_pair.first = convert_result(result);
    if (result_pair.first != Mission::Result::Success) {
        return result_pair;
    }

    _mission_data.mavlink_mission_item_to_mission_item_indices.clear();

    Mission::DownloadMissionCallback callback;
    {
        _enable_return_to_launch_after_mission = false;

        MissionItem new_mission_item{};
        bool have_set_position = false;

        for (const auto& int_item : int_items) {
            LogDebug() << "Assembling Message: " << int(int_item.seq);

            if (int_item.command == MAV_CMD_NAV_WAYPOINT ||
                int_item.command == MAV_CMD_NAV_TAKEOFF) {
                if (int_item.frame != MAV_FRAME_GLOBAL_RELATIVE_ALT_INT) {
                    LogErr() << "Waypoint frame not supported unsupported";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                }

                if (have_set_position) {
                    // When a new position comes in, create next mission item.
                    result_pair.second.mission_items.push_back(new_mission_item);
                    new_mission_item = {};
                    have_set_position = false;
                }

                new_mission_item.latitude_deg = double(int_item.x) * 1e-7;
                new_mission_item.longitude_deg = double(int_item.y) * 1e-7;
                new_mission_item.relative_altitude_m = int_item.z;
                new_mission_item.yaw_deg = int_item.param4;

                if (int_item.command == MAV_CMD_NAV_TAKEOFF) {
                    new_mission_item.acceptance_radius_m = 1;
                    new_mission_item.is_fly_through = false;
                    new_mission_item.vehicle_action = VehicleAction::Takeoff;
                } else {
                    new_mission_item.acceptance_radius_m = int_item.param2;
                    new_mission_item.is_fly_through = !(int_item.param1 > 0);
                }

                have_set_position = true;

            } else if (int_item.command == MAV_CMD_DO_GIMBAL_MANAGER_PITCHYAW) {
                if (int_item.x !=
                    (GIMBAL_MANAGER_FLAGS_ROLL_LOCK | GIMBAL_MANAGER_FLAGS_PITCH_LOCK)) {
                    LogErr() << "Gimbal do pitchyaw flags unsupported";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                }

                new_mission_item.gimbal_pitch_deg = int_item.param1;
                new_mission_item.gimbal_yaw_deg = int_item.param2;

            } else if (int_item.command == MAV_CMD_DO_GIMBAL_MANAGER_CONFIGURE) {
                // We need to ignore it in order to not throw an "Unsupported" error
                continue;

            } else if (int_item.command == MAV_CMD_IMAGE_START_CAPTURE) {
                if (int_item.param2 > 0 && int(int_item.param3) == 0) {
                    new_mission_item.camera_action = CameraAction::StartPhotoInterval;
                    new_mission_item.camera_photo_interval_s = double(int_item.param2);
                } else if (int(int_item.param2) == 0 && int(int_item.param3) == 1) {
                    new_mission_item.camera_action = CameraAction::TakePhoto;
                } else {
                    LogErr() << "Mission item START_CAPTURE params unsupported.";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                }

            } else if (int_item.command == MAV_CMD_IMAGE_STOP_CAPTURE) {
                new_mission_item.camera_action = CameraAction::StopPhotoInterval;

            } else if (int_item.command == MAV_CMD_VIDEO_START_CAPTURE) {
                new_mission_item.camera_action = CameraAction::StartVideo;

            } else if (int_item.command == MAV_CMD_VIDEO_STOP_CAPTURE) {
                new_mission_item.camera_action = CameraAction::StopVideo;

            } else if (int_item.command == MAV_CMD_DO_SET_CAM_TRIGG_DIST) {
                if (!std::isfinite(int_item.param1)) {
                    LogErr() << "Trigger distance in SET_CAM_TRIGG_DIST not finite.";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                } else if (static_cast<int>(int_item.param1) > 0.0f) {
                    new_mission_item.camera_action = CameraAction::StartPhotoDistance;
                    new_mission_item.camera_photo_distance_m = int_item.param1;
                } else {
                    new_mission_item.camera_action = CameraAction::StopPhotoDistance;
                }

            } else if (int_item.command == MAV_CMD_NAV_TAKEOFF) {
                new_mission_item.vehicle_action = VehicleAction::Takeoff;
            } else if (int_item.command == MAV_CMD_NAV_LAND) {
                new_mission_item.vehicle_action = VehicleAction::Land;
            } else if (int_item.command == MAV_CMD_DO_VTOL_TRANSITION) {
                if (int_item.param1 == MAV_VTOL_STATE_FW) {
                    new_mission_item.vehicle_action = VehicleAction::TransitionToFw;
                } else {
                    new_mission_item.vehicle_action = VehicleAction::TransitionToMc;
                }

            } else if (int_item.command == MAV_CMD_DO_CHANGE_SPEED) {
                if (int(int_item.param1) == 1 && int_item.param3 < 0 && int(int_item.param4) == 0) {
                    new_mission_item.speed_m_s = int_item.param2;
                } else {
                    LogErr() << "Mission item DO_CHANGE_SPEED params unsupported";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                }

            } else if (int_item.command == MAV_CMD_NAV_LOITER_TIME) {
                // MAVSDK doesn't use LOITER_TIME anymore, but it is possible
                // a mission still uses it
                new_mission_item.loiter_time_s = int_item.param1;

            } else if (int_item.command == MAV_CMD_NAV_DELAY) {
                if (int_item.param1 != -1) {
                    // use delay in seconds directly
                    new_mission_item.loiter_time_s = int_item.param1;
                } else {
                    // TODO: we should support this by converting
                    // time of day data to delay in seconds
                    // leaving it out for now because a portable implementation
                    // is not trivial
                    LogErr() << "Mission item NAV_DELAY params unsupported";
                    result_pair.first = Mission::Result::Unsupported;
                    break;
                }

            } else if (int_item.command == MAV_CMD_NAV_RETURN_TO_LAUNCH) {
                _enable_return_to_launch_after_mission = true;

            } else {
                LogErr() << "UNSUPPORTED mission item command (" << int_item.command << ")";
                result_pair.first = Mission::Result::Unsupported;
                break;
            }

            _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(
                result_pair.second.mission_items.size());
        }

        // Don't forget to add last mission item.
        result_pair.second.mission_items.push_back(new_mission_item);
    }
    return result_pair;
}

Mission::Result MissionImpl::start_mission()
{
    auto prom = std::promise<Mission::Result>();
    auto fut = prom.get_future();

    start_mission_async([&prom](Mission::Result result) { prom.set_value(result); });
    return fut.get();
}

void MissionImpl::start_mission_async(const Mission::ResultCallback& callback)
{
    _system_impl->set_flight_mode_async(
        FlightMode::Mission, [this, callback](MavlinkCommandSender::Result result, float) {
            report_flight_mode_change(callback, result);
        });
}

Mission::Result MissionImpl::pause_mission()
{
    auto prom = std::promise<Mission::Result>();
    auto fut = prom.get_future();

    pause_mission_async([&prom](Mission::Result result) { prom.set_value(result); });
    return fut.get();
}

void MissionImpl::pause_mission_async(const Mission::ResultCallback& callback)
{
    _system_impl->set_flight_mode_async(
        FlightMode::Hold, [this, callback](MavlinkCommandSender::Result result, float) {
            report_flight_mode_change(callback, result);
        });
}

void MissionImpl::report_flight_mode_change(
    Mission::ResultCallback callback, MavlinkCommandSender::Result result)
{
    if (!callback) {
        return;
    }

    _system_impl->call_user_callback(
        [callback, result]() { callback(command_result_to_mission_result(result)); });
}

Mission::Result MissionImpl::command_result_to_mission_result(MavlinkCommandSender::Result result)
{
    switch (result) {
        case MavlinkCommandSender::Result::Success:
            return Mission::Result::Success;
        case MavlinkCommandSender::Result::NoSystem:
            return Mission::Result::NoSystem;
        case MavlinkCommandSender::Result::ConnectionError:
            return Mission::Result::Error;
        case MavlinkCommandSender::Result::Busy:
            return Mission::Result::Busy;
        case MavlinkCommandSender::Result::TemporarilyRejected:
            // FALLTHROUGH
        case MavlinkCommandSender::Result::Denied:
            return Mission::Result::Denied;
        case MavlinkCommandSender::Result::Timeout:
            return Mission::Result::Timeout;
        case MavlinkCommandSender::Result::InProgress:
            return Mission::Result::Busy;
        case MavlinkCommandSender::Result::UnknownError:
            return Mission::Result::Unknown;
        default:
            return Mission::Result::Unknown;
    }
}

Mission::Result MissionImpl::clear_mission()
{
    auto prom = std::promise<Mission::Result>();
    auto fut = prom.get_future();

    clear_mission_async([&prom](Mission::Result result) { prom.set_value(result); });
    return fut.get();
}

void MissionImpl::clear_mission_async(const Mission::ResultCallback& callback)
{
    reset_mission_progress();

    _system_impl->mission_transfer_client().clear_items_async(
        MAV_MISSION_TYPE_MISSION,
        _system_impl->get_system_id(),
        [this, callback](MavlinkMissionTransferClient::Result result) {
            auto converted_result = convert_result(result);
            _system_impl->call_user_callback([callback, converted_result]() {
                if (callback) {
                    callback(converted_result);
                }
            });
        });
}

Mission::Result MissionImpl::set_current_mission_item(int current)
{
    auto prom = std::promise<Mission::Result>();
    auto fut = prom.get_future();

    set_current_mission_item_async(
        current, [&prom](Mission::Result result) { prom.set_value(result); });
    return fut.get();
}

void MissionImpl::set_current_mission_item_async(
    int current, const Mission::ResultCallback& callback)
{
    int mavlink_index = -1;
    {
        std::lock_guard<std::mutex> lock(_mission_data.mutex);
        // We need to find the first mavlink item which maps to the current mission item.
        int i = 0;
        for (auto index : _mission_data.mavlink_mission_item_to_mission_item_indices) {
            if (index == current) {
                mavlink_index = i;
                break;
            }
            ++i;
        }
    }

    // If we don't have _mission_data cached from an upload or download,
    // we have to complain. The exception is current set to 0 because it
    // means to reset to the beginning.

    if (mavlink_index == -1 && current != 0) {
        _system_impl->call_user_callback([callback]() {
            if (callback) {
                // FIXME: come up with better error code.
                callback(Mission::Result::InvalidArgument);
                return;
            }
        });
    }

    _system_impl->mission_transfer_client().set_current_item_async(
        mavlink_index,
        _system_impl->get_system_id(),
        [this, callback](MavlinkMissionTransferClient::Result result) {
            auto converted_result = convert_result(result);
            _system_impl->call_user_callback([callback, converted_result]() {
                if (callback) {
                    callback(converted_result);
                }
            });
        });
}

void MissionImpl::report_progress_locked()
{
    if (_mission_data.mission_progress_callbacks.empty()) {
        return;
    }

    int current = current_mission_item_locked();
    int total = total_mission_items_locked();

    // Do not report -1 as a current mission item
    if (current == -1) {
        return;
    }

    bool should_report = false;
    if (_mission_data.last_current_reported_mission_item != current) {
        _mission_data.last_current_reported_mission_item = current;
        should_report = true;
    }
    if (_mission_data.last_total_reported_mission_item != total) {
        _mission_data.last_total_reported_mission_item = total;
        should_report = true;
    }

    if (should_report) {
        _mission_data.mission_progress_callbacks.queue(
            {current, total}, [this](const auto& func) { _system_impl->call_user_callback(func); });
        LogDebug() << "current: " << current << ", total: " << total;
    }
}

std::pair<Mission::Result, bool> MissionImpl::is_mission_finished() const
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);

    return is_mission_finished_locked();
}

std::pair<Mission::Result, bool> MissionImpl::is_mission_finished_locked() const
{
    if (_mission_data.last_current_mavlink_mission_item < 0) {
        return std::make_pair<Mission::Result, bool>(Mission::Result::Success, false);
    }

    if (_mission_data.last_reached_mavlink_mission_item < 0) {
        return std::make_pair<Mission::Result, bool>(Mission::Result::Success, false);
    }

    if (_mission_data.mavlink_mission_item_to_mission_item_indices.size() == 0) {
        return std::make_pair<Mission::Result, bool>(Mission::Result::Success, false);
    }

    // If mission_state is Unknown, fall back to the previous behavior
    if (_mission_data.mission_state == MISSION_STATE_UNKNOWN) {
        // It is not straightforward to look at "current" because it jumps to 0
        // once the last item has been done. Therefore we have to lo decide using
        // "reached" here.
        // With PX4, it seems that we didn't use to receive a reached when RTL is initiated
        // after a mission, and we needed to account for that all the way to PX4 v1.16.
        const unsigned rtl_correction = _enable_return_to_launch_after_mission ? 2 : 1;

        // By accepting the current to be larger than the total, we are accepting the case
        // where we no longer require the rtl_correction, as this is now getting fixed in PX4.
        return std::make_pair<Mission::Result, bool>(
            Mission::Result::Success,
            unsigned(_mission_data.last_reached_mavlink_mission_item + rtl_correction) >=
                _mission_data.mavlink_mission_item_to_mission_item_indices.size());
    }

    // If mission_state is Completed, the mission is finished
    if (_mission_data.mission_state == MISSION_STATE_COMPLETE) {
        return std::make_pair<Mission::Result, bool>(Mission::Result::Success, true);
    }

    // If mission_state is NotCompleted, the mission is not finished
    return std::make_pair<Mission::Result, bool>(Mission::Result::Success, false);
}

int MissionImpl::current_mission_item() const
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    return current_mission_item_locked();
}

int MissionImpl::current_mission_item_locked() const
{
    // If the mission is finished, let's return the total as the current
    // to signal this.
    if (is_mission_finished_locked().second) {
        return total_mission_items_locked();
    }

    // We want to return the current mission item and not the underlying
    // mavlink mission item.
    if (_mission_data.last_current_mavlink_mission_item >=
            static_cast<int>(_mission_data.mavlink_mission_item_to_mission_item_indices.size()) ||
        _mission_data.last_current_mavlink_mission_item < 0) {
        return -1;
    }

    return _mission_data.mavlink_mission_item_to_mission_item_indices[static_cast<unsigned>(
        _mission_data.last_current_mavlink_mission_item)];
}

int MissionImpl::total_mission_items() const
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    return total_mission_items_locked();
}

int MissionImpl::total_mission_items_locked() const
{
    if (_mission_data.mavlink_mission_item_to_mission_item_indices.size() == 0) {
        return 0;
    }
    return _mission_data.mavlink_mission_item_to_mission_item_indices.back() + 1;
}

Mission::MissionProgress MissionImpl::mission_progress()
{
    Mission::MissionProgress mission_progress;
    mission_progress.current = current_mission_item();
    mission_progress.total = total_mission_items();

    return mission_progress;
}

Mission::MissionProgressHandle
MissionImpl::subscribe_mission_progress(const Mission::MissionProgressCallback& callback)
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    return _mission_data.mission_progress_callbacks.subscribe(callback);
}

void MissionImpl::unsubscribe_mission_progress(Mission::MissionProgressHandle handle)
{
    std::lock_guard<std::mutex> lock(_mission_data.mutex);
    _mission_data.mission_progress_callbacks.unsubscribe(handle);
}

Mission::Result MissionImpl::convert_result(MavlinkMissionTransferClient::Result result)
{
    switch (result) {
        case MavlinkMissionTransferClient::Result::Success:
            return Mission::Result::Success;
        case MavlinkMissionTransferClient::Result::ConnectionError:
            return Mission::Result::Error;
        case MavlinkMissionTransferClient::Result::Denied:
            return Mission::Result::Denied;
        case MavlinkMissionTransferClient::Result::TooManyMissionItems:
            return Mission::Result::TooManyMissionItems;
        case MavlinkMissionTransferClient::Result::Timeout:
            return Mission::Result::Timeout;
        case MavlinkMissionTransferClient::Result::Unsupported:
            return Mission::Result::Unsupported;
        case MavlinkMissionTransferClient::Result::UnsupportedFrame:
            return Mission::Result::Unsupported;
        case MavlinkMissionTransferClient::Result::NoMissionAvailable:
            return Mission::Result::NoMissionAvailable;
        case MavlinkMissionTransferClient::Result::Cancelled:
            return Mission::Result::TransferCancelled;
        case MavlinkMissionTransferClient::Result::MissionTypeNotConsistent:
            return Mission::Result::Error; // should not happen
        case MavlinkMissionTransferClient::Result::InvalidSequence:
            return Mission::Result::Error; // should not happen
        case MavlinkMissionTransferClient::Result::CurrentInvalid:
            return Mission::Result::Error; // should not happen
        case MavlinkMissionTransferClient::Result::ProtocolError:
            return Mission::Result::ProtocolError;
        case MavlinkMissionTransferClient::Result::InvalidParam:
            return Mission::Result::InvalidArgument;
        case MavlinkMissionTransferClient::Result::IntMessagesNotSupported:
            return Mission::Result::IntMessagesNotSupported;
        default:
            return Mission::Result::Unknown;
    }
}

void MissionImpl::add_gimbal_items_v2(
    std::vector<MavlinkMissionTransferClient::ItemInt>& int_items,
    unsigned item_i,
    float pitch_deg,
    float yaw_deg)
{
    uint8_t current = ((int_items.size() == 0) ? 1 : 0);

    uint8_t autocontinue = 1;

    // We don't set YAW_LOCK because we probably just want to face forward.
    uint32_t flags = GIMBAL_MANAGER_FLAGS_ROLL_LOCK | GIMBAL_MANAGER_FLAGS_PITCH_LOCK;

    // Pitch should be between -180 and 180 degrees
    pitch_deg = fmod(pitch_deg, 360.f);
    pitch_deg = pitch_deg > 180.f ? pitch_deg - 360.f : pitch_deg;

    // Yaw should be between -180 and 180 degrees
    yaw_deg = fmod(yaw_deg, 360.f);
    yaw_deg = yaw_deg > 180.f ? yaw_deg - 360.f : yaw_deg;

    MavlinkMissionTransferClient::ItemInt next_item{
        static_cast<uint16_t>(int_items.size()),
        MAV_FRAME_MISSION,
        MAV_CMD_DO_GIMBAL_MANAGER_PITCHYAW,
        current,
        autocontinue,
        pitch_deg, // pitch
        yaw_deg, // yaw
        NAN, // pitch rate
        NAN, // yaw rate
        static_cast<int32_t>(flags),
        0, // reserved
        0, // all devices
        MAV_MISSION_TYPE_MISSION};

    _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
    int_items.push_back(next_item);
}

void MissionImpl::acquire_gimbal_control_v2(
    std::vector<MavlinkMissionTransferClient::ItemInt>& int_items, unsigned item_i)
{
    uint8_t current = ((int_items.size() == 0) ? 1 : 0);

    uint8_t autocontinue = 1;

    MavlinkMissionTransferClient::ItemInt next_item{
        static_cast<uint16_t>(int_items.size()),
        MAV_FRAME_MISSION,
        MAV_CMD_DO_GIMBAL_MANAGER_CONFIGURE,
        current,
        autocontinue,
        -2.0f, // primary control sysid: set itself (autopilot) when running mission
        -2.0f, // primary control compid: itself (autopilot) when running mission
        -1.0f, // secondary control sysid: unchanged
        -1.0f, // secondary control compid: unchanged
        0, // reserved
        0, // reserved
        0, // all devices
        MAV_MISSION_TYPE_MISSION};

    _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
    int_items.push_back(next_item);
}

void MissionImpl::release_gimbal_control_v2(
    std::vector<MavlinkMissionTransferClient::ItemInt>& int_items, unsigned item_i)
{
    uint8_t current = ((int_items.size() == 0) ? 1 : 0);

    uint8_t autocontinue = 1;

    MavlinkMissionTransferClient::ItemInt next_item{
        static_cast<uint16_t>(int_items.size()),
        MAV_FRAME_MISSION,
        MAV_CMD_DO_GIMBAL_MANAGER_CONFIGURE,
        current,
        autocontinue,
        -3.0f, // primary control sysid: remove itself (autopilot) if in control
        -3.0f, // primary control compid: remove itself (autopilot) if in control
        -1.0f, // secondary control sysid: unchanged
        -1.0f, // secondary control compid: unchanged
        0, // reserved
        0, // reserved
        0, // all devices
        MAV_MISSION_TYPE_MISSION};

    _mission_data.mavlink_mission_item_to_mission_item_indices.push_back(item_i);
    int_items.push_back(next_item);
}

} // namespace mavsdk

mavlink / MAVSDK / 16665088909

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous