unicode-org / icu4x / 16613990805

Build # 16613990805

Build Type

push

github

Committed by web-flow

Commit Message

Add four `map_with_cart` methods to `yoke::Yoke` (#6781)

Closes #6777

.

# Added

Adds four public methods to `yoke::Yoke`,
`{try_}map_with_cart{_cloned}`, which are analogous to the `map_project`
family, but additionally provide a reference to the cart.



# Tests



I added a bunch of safety docs and doctests to the bottom of `yoke.rs`
for `map_with_cart` (and a few for `map_with_cart_cloned`), under the
reasoning that the `try_` variants differ only in the output type of the
callback, and the difference is incapable of introducing a new
lifetime.



The tests passed under a run of `MIRIFLAGS="-Zmiri-strict-provenance
-Zmiri-retag-fields -Zmiri-recursive-validation" cargo +nightly miri
test --package yoke --all-features`. I'm pleasantly surprised everything
went smoothly... aside from me sleepwalking into #2095 by defaulting to
`Box` for the tests. After replacing `Box` with `Rc`, they passed. (I
guess that shows the tests successfully checked for something.) Some of
the older doctests (for `map_project` and `attach_to_cart`) still use
`Box`, but I guess they don't do enough to trigger UB.

Run Details

59770 of 82146 relevant lines covered (72.76%)

456149.74 hits per line

Source File

Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available