• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4609

28 Jul 2025 03:45AM UTC coverage: 60.413% (-0.7%) from 61.072%
#4609

push

travis-ci

web-flow
merge: from 3.3.6 to main branch #32314 

Merge/3.3.6tomain

138583 of 291345 branches covered (47.57%)

Branch coverage included in aggregate %.

79 of 97 new or added lines in 12 files covered. (81.44%)

9880 existing lines in 148 files now uncovered.

208900 of 283831 relevant lines covered (73.6%)

18073489.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.33
/source/dnode/mnode/impl/src/mndStb.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "audit.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndex.h"
21
#include "mndIndexComm.h"
22
#include "mndInfoSchema.h"
23
#include "mndMnode.h"
24
#include "mndPerfSchema.h"
25
#include "mndPrivilege.h"
26
#include "mndShow.h"
27
#include "mndSma.h"
28
#include "mndStb.h"
29
#include "mndTopic.h"
30
#include "mndTrans.h"
31
#include "mndUser.h"
32
#include "mndVgroup.h"
33
#include "mndStream.h"
34
#include "tname.h"
35

36
#define STB_VER_NUMBER   3
37
#define STB_RESERVE_SIZE 56
38

39
static int32_t  mndStbActionInsert(SSdb *pSdb, SStbObj *pStb);
40
static int32_t  mndStbActionDelete(SSdb *pSdb, SStbObj *pStb);
41
static int32_t  mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew);
42
static int32_t  mndProcessTtlTimer(SRpcMsg *pReq);
43
static int32_t  mndProcessTrimDbTimer(SRpcMsg *pReq);
44
static int32_t  mndProcessCreateStbReq(SRpcMsg *pReq);
45
static int32_t  mndProcessAlterStbReq(SRpcMsg *pReq);
46
static int32_t  mndProcessDropStbReq(SRpcMsg *pReq);
47
static int32_t  mndProcessDropTtltbRsp(SRpcMsg *pReq);
48
static int32_t  mndProcessTrimDbRsp(SRpcMsg *pReq);
49
static int32_t  mndProcessTableMetaReq(SRpcMsg *pReq);
50
static int32_t  mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
51
static int32_t  mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
52
static void     mndCancelGetNextStb(SMnode *pMnode, void *pIter);
53
static int32_t  mndProcessTableCfgReq(SRpcMsg *pReq);
54
static int32_t  mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
55
                               void *alterOriData, int32_t alterOriDataLen);
56
static int32_t  mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
57
                                              void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter);
58

59
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq);
60
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq);
61

62
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq);
63
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq);
64
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pReq);
65

66
int32_t mndInitStb(SMnode *pMnode) {
2,673✔
67
  SSdbTable table = {
2,673✔
68
      .sdbType = SDB_STB,
69
      .keyType = SDB_KEY_BINARY,
70
      .encodeFp = (SdbEncodeFp)mndStbActionEncode,
71
      .decodeFp = (SdbDecodeFp)mndStbActionDecode,
72
      .insertFp = (SdbInsertFp)mndStbActionInsert,
73
      .updateFp = (SdbUpdateFp)mndStbActionUpdate,
74
      .deleteFp = (SdbDeleteFp)mndStbActionDelete,
75
  };
76

77
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_STB, mndProcessCreateStbReq);
2,673✔
78
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_STB, mndProcessAlterStbReq);
2,673✔
79
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_STB, mndProcessDropStbReq);
2,673✔
80
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_STB_RSP, mndTransProcessRsp);
2,673✔
81
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TTL_TABLE_RSP, mndProcessDropTtltbRsp);
2,673✔
82
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_RSP, mndProcessTrimDbRsp);
2,673✔
83
  mndSetMsgHandle(pMnode, TDMT_VND_ALTER_STB_RSP, mndTransProcessRsp);
2,673✔
84
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_STB_RSP, mndTransProcessRsp);
2,673✔
85
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_META, mndProcessTableMetaReq);
2,673✔
86
  mndSetMsgHandle(pMnode, TDMT_MND_TTL_TIMER, mndProcessTtlTimer);
2,673✔
87
  mndSetMsgHandle(pMnode, TDMT_MND_TRIM_DB_TIMER, mndProcessTrimDbTimer);
2,673✔
88
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_CFG, mndProcessTableCfgReq);
2,673✔
89
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP, mndProcessDropStbReqFromMNode);
2,673✔
90
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP_RSP, mndTransProcessRsp);
2,673✔
91
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_TB_WITH_TSMA, mndProcessDropTbWithTsma);
2,673✔
92
  mndSetMsgHandle(pMnode, TDMT_VND_FETCH_TTL_EXPIRED_TBS_RSP, mndProcessFetchTtlExpiredTbs);
2,673✔
93
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TABLE_RSP, mndTransProcessRsp);
2,673✔
94
  //  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveStbReq);
95

96
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIndexReq);
97
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIndexReq);
98
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
99
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
100

101
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_STB, mndRetrieveStb);
2,673✔
102
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_STB, mndCancelGetNextStb);
2,673✔
103

104
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COL, mndRetrieveStbCol);
2,673✔
105
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_COL, mndCancelGetNextStb);
2,673✔
106

107
  return sdbSetTable(pMnode->pSdb, table);
2,673✔
108
}
109

110
void mndCleanupStb(SMnode *pMnode) {}
2,673✔
111

112
SSdbRaw *mndStbActionEncode(SStbObj *pStb) {
55,592✔
113
  int32_t code = 0;
55,592✔
114
  int32_t lino = 0;
55,592✔
115
  bool    hasTypeMod = false;
55,592✔
116
  terrno = TSDB_CODE_OUT_OF_MEMORY;
55,592✔
117

118
  int32_t size = sizeof(SStbObj) + (pStb->numOfColumns + pStb->numOfTags) * sizeof(SSchema) + pStb->commentLen +
111,184✔
119
                 pStb->ast1Len + pStb->ast2Len + pStb->numOfColumns * sizeof(SColCmpr) + STB_RESERVE_SIZE +
111,184✔
120
                 taosArrayGetSize(pStb->pFuncs) * TSDB_FUNC_NAME_LEN + sizeof(int32_t) * pStb->numOfColumns;
55,592✔
121
  SSdbRaw *pRaw = sdbAllocRaw(SDB_STB, STB_VER_NUMBER, size);
55,592✔
122
  if (pRaw == NULL) goto _OVER;
55,592!
123

124
  int32_t dataPos = 0;
55,592✔
125
  SDB_SET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
55,592!
126
  SDB_SET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
55,592!
127
  SDB_SET_INT64(pRaw, dataPos, pStb->createdTime, _OVER)
55,592!
128
  SDB_SET_INT64(pRaw, dataPos, pStb->updateTime, _OVER)
55,592!
129
  SDB_SET_INT64(pRaw, dataPos, pStb->uid, _OVER)
55,592!
130
  SDB_SET_INT64(pRaw, dataPos, pStb->dbUid, _OVER)
55,592!
131
  SDB_SET_INT32(pRaw, dataPos, pStb->tagVer, _OVER)
55,592!
132
  SDB_SET_INT32(pRaw, dataPos, pStb->colVer, _OVER)
55,592!
133
  SDB_SET_INT32(pRaw, dataPos, pStb->smaVer, _OVER)
55,592!
134
  SDB_SET_INT32(pRaw, dataPos, pStb->nextColId, _OVER)
55,592!
135
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[0], _OVER)
55,592!
136
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[1], _OVER)
55,592!
137
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[0], _OVER)
55,592!
138
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[1], _OVER)
55,592!
139
  SDB_SET_INT32(pRaw, dataPos, pStb->ttl, _OVER)
55,592!
140
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfColumns, _OVER)
55,592!
141
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfTags, _OVER)
55,592!
142
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfFuncs, _OVER)
55,592!
143
  SDB_SET_INT32(pRaw, dataPos, pStb->commentLen, _OVER)
55,592!
144
  SDB_SET_INT32(pRaw, dataPos, pStb->ast1Len, _OVER)
55,592!
145
  SDB_SET_INT32(pRaw, dataPos, pStb->ast2Len, _OVER)
55,592!
146

147
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
3,517,357✔
148
    SSchema *pSchema = &pStb->pColumns[i];
3,461,765✔
149
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
3,461,765!
150
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
3,461,765!
151
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
3,461,765!
152
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
3,461,765!
153
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
3,461,765!
154
    hasTypeMod = hasTypeMod || HAS_TYPE_MOD(pSchema);
3,461,765✔
155
  }
156

157
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
516,833✔
158
    SSchema *pSchema = &pStb->pTags[i];
461,241✔
159
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
461,241!
160
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
461,241!
161
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
461,241!
162
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
461,241!
163
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
461,241!
164
  }
165

166
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
55,595✔
167
    char *func = taosArrayGet(pStb->pFuncs, i);
3✔
168
    SDB_SET_BINARY(pRaw, dataPos, func, TSDB_FUNC_NAME_LEN, _OVER)
3!
169
  }
170

171
  if (pStb->commentLen > 0) {
55,592✔
172
    SDB_SET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
334!
173
  }
174

175
  if (pStb->ast1Len > 0) {
55,592✔
176
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
3!
177
  }
178

179
  if (pStb->ast2Len > 0) {
55,592✔
180
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
3!
181
  }
182

183
  if (pStb->pCmpr != NULL) {
55,592!
184
    for (int i = 0; i < pStb->numOfColumns; i++) {
3,517,357✔
185
      SColCmpr *p = &pStb->pCmpr[i];
3,461,765✔
186
      SDB_SET_INT16(pRaw, dataPos, p->id, _OVER)
3,461,765!
187
      SDB_SET_INT32(pRaw, dataPos, p->alg, _OVER)
3,461,765!
188
    }
189
  }
190
  SDB_SET_INT64(pRaw, dataPos, pStb->keep, _OVER)
55,592!
191

192
  if (hasTypeMod) {
55,592✔
193
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
2,655,599✔
194
      SDB_SET_INT32(pRaw, dataPos, pStb->pExtSchemas[i].typeMod, _OVER);
2,644,467!
195
    }
196
  }
197

198
  SDB_SET_INT8(pRaw, dataPos, pStb->virtualStb, _OVER)
55,592!
199
  SDB_SET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
55,592!
200
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
55,592!
201

202
  terrno = 0;
55,592✔
203

204
_OVER:
55,592✔
205
  if (terrno != 0) {
55,592!
206
    mError("stb:%s, failed to encode to raw:%p since %s", pStb->name, pRaw, terrstr());
×
207
    sdbFreeRaw(pRaw);
×
208
    return NULL;
×
209
  }
210

211
  mTrace("stb:%s, encode to raw:%p, row:%p", pStb->name, pRaw, pStb);
55,592✔
212
  return pRaw;
55,592✔
213
}
214

215
SSdbRow *mndStbActionDecode(SSdbRaw *pRaw) {
47,593✔
216
  int32_t code = 0;
47,593✔
217
  int32_t lino = 0;
47,593✔
218
  terrno = TSDB_CODE_OUT_OF_MEMORY;
47,593✔
219
  SSdbRow *pRow = NULL;
47,593✔
220
  SStbObj *pStb = NULL;
47,593✔
221
  bool     hasExtSchemas = false;
47,593✔
222

223
  int8_t sver = 0;
47,593✔
224
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
47,593!
225

226
  if (sver > STB_VER_NUMBER) {
47,593!
227
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
228
    goto _OVER;
×
229
  }
230

231
  pRow = sdbAllocRow(sizeof(SStbObj));
47,593✔
232
  if (pRow == NULL) goto _OVER;
47,593!
233

234
  pStb = sdbGetRowObj(pRow);
47,593✔
235
  if (pStb == NULL) goto _OVER;
47,593!
236

237
  int32_t dataPos = 0;
47,593✔
238
  SDB_GET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
47,593!
239
  SDB_GET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
47,593!
240
  SDB_GET_INT64(pRaw, dataPos, &pStb->createdTime, _OVER)
47,593!
241
  SDB_GET_INT64(pRaw, dataPos, &pStb->updateTime, _OVER)
47,593!
242
  SDB_GET_INT64(pRaw, dataPos, &pStb->uid, _OVER)
47,593!
243
  SDB_GET_INT64(pRaw, dataPos, &pStb->dbUid, _OVER)
47,593!
244
  SDB_GET_INT32(pRaw, dataPos, &pStb->tagVer, _OVER)
47,593!
245
  SDB_GET_INT32(pRaw, dataPos, &pStb->colVer, _OVER)
47,593!
246
  SDB_GET_INT32(pRaw, dataPos, &pStb->smaVer, _OVER)
47,593!
247
  SDB_GET_INT32(pRaw, dataPos, &pStb->nextColId, _OVER)
47,593!
248
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[0], _OVER)
47,593!
249
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[1], _OVER)
47,593!
250
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[0], _OVER)
47,593!
251
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[1], _OVER)
47,593!
252
  SDB_GET_INT32(pRaw, dataPos, &pStb->ttl, _OVER)
47,593!
253
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfColumns, _OVER)
47,593!
254
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfTags, _OVER)
47,593!
255
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfFuncs, _OVER)
47,593!
256
  SDB_GET_INT32(pRaw, dataPos, &pStb->commentLen, _OVER)
47,593!
257
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast1Len, _OVER)
47,593!
258
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast2Len, _OVER)
47,593!
259

260
  pStb->pColumns = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchema));
47,593!
261
  pStb->pTags = taosMemoryCalloc(pStb->numOfTags, sizeof(SSchema));
47,593!
262
  pStb->pFuncs = taosArrayInit(pStb->numOfFuncs, TSDB_FUNC_NAME_LEN);
47,593✔
263
  if (pStb->pColumns == NULL || pStb->pTags == NULL || pStb->pFuncs == NULL) {
47,593!
264
    goto _OVER;
×
265
  }
266

267
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
7,491,681✔
268
    SSchema *pSchema = &pStb->pColumns[i];
7,444,088✔
269
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
7,444,088!
270
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
7,444,088!
271
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
7,444,088!
272
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
7,444,088!
273
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
7,444,088!
274
    hasExtSchemas = hasExtSchemas || HAS_TYPE_MOD(pSchema);
7,444,088✔
275
  }
276

277
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
739,952✔
278
    SSchema *pSchema = &pStb->pTags[i];
692,359✔
279
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
692,359!
280
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
692,359!
281
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
692,359!
282
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
692,359!
283
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
692,359!
284
  }
285

286
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
47,595✔
287
    char funcName[TSDB_FUNC_NAME_LEN] = {0};
2✔
288
    SDB_GET_BINARY(pRaw, dataPos, funcName, TSDB_FUNC_NAME_LEN, _OVER)
2!
289
    if (taosArrayPush(pStb->pFuncs, funcName) == NULL) goto _OVER;
4!
290
  }
291

292
  if (pStb->commentLen > 0) {
47,593✔
293
    pStb->comment = taosMemoryCalloc(pStb->commentLen + 1, 1);
299!
294
    if (pStb->comment == NULL) goto _OVER;
299!
295
    SDB_GET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
299!
296
  }
297

298
  if (pStb->ast1Len > 0) {
47,593✔
299
    pStb->pAst1 = taosMemoryCalloc(pStb->ast1Len, 1);
2!
300
    if (pStb->pAst1 == NULL) goto _OVER;
2!
301
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
2!
302
  }
303

304
  if (pStb->ast2Len > 0) {
47,593✔
305
    pStb->pAst2 = taosMemoryCalloc(pStb->ast2Len, 1);
2!
306
    if (pStb->pAst2 == NULL) goto _OVER;
2!
307
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
2!
308
  }
309

310
  pStb->pCmpr = taosMemoryCalloc(pStb->numOfColumns, sizeof(SColCmpr));
47,593!
311
  if (sver < STB_VER_NUMBER - 1) {
47,593!
312
    // compatible with old data, setup default compress value
313
    // impl later
314
    for (int i = 0; i < pStb->numOfColumns; i++) {
×
315
      SSchema  *pSchema = &pStb->pColumns[i];
×
316
      SColCmpr *pCmpr = &pStb->pCmpr[i];
×
317
      pCmpr->id = pSchema->colId;
×
318
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
×
319
    }
320
  } else {
321
    for (int i = 0; i < pStb->numOfColumns; i++) {
7,491,681✔
322
      SColCmpr *pCmpr = &pStb->pCmpr[i];
7,444,088✔
323
      SDB_GET_INT16(pRaw, dataPos, &pCmpr->id, _OVER)
7,444,088!
324
      SDB_GET_INT32(pRaw, dataPos, (int32_t *)&pCmpr->alg, _OVER)  // compatiable
7,444,088!
325
    }
326
  }
327
  SDB_GET_INT64(pRaw, dataPos, &pStb->keep, _OVER)
47,593!
328

329
  // type mod
330
  if (hasExtSchemas) {
47,593✔
331
    pStb->pExtSchemas = taosMemoryCalloc(pStb->numOfColumns, sizeof(SExtSchema));
19,285!
332
    if (!pStb->pExtSchemas) goto _OVER;
19,285!
333
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
6,924,801✔
334
      SSchema *pSchema = &pStb->pColumns[i];
6,905,516✔
335
      SDB_GET_INT32(pRaw, dataPos, &pStb->pExtSchemas[i].typeMod, _OVER)
6,905,516!
336
    }
337
  }
338

339
  if (sver < STB_VER_NUMBER) {
47,593!
340
    pStb->virtualStb = 0;
×
341
  } else {
342
    SDB_GET_INT8(pRaw, dataPos, &pStb->virtualStb, _OVER)
47,593!
343
  }
344

345
  SDB_GET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
47,593!
346

347
  terrno = 0;
47,593✔
348

349
_OVER:
47,593✔
350
  if (terrno != 0) {
47,593!
351
    mError("stb:%s, failed to decode from raw:%p since %s", pStb == NULL ? "null" : pStb->name, pRaw, terrstr());
×
352
    if (pStb != NULL) {
×
353
      taosMemoryFreeClear(pStb->pColumns);
×
354
      taosMemoryFreeClear(pStb->pTags);
×
355
      taosMemoryFreeClear(pStb->comment);
×
356
      taosMemoryFree(pStb->pCmpr);
×
357
      taosMemoryFreeClear(pStb->pExtSchemas);
×
358
    }
359
    taosMemoryFreeClear(pRow);
×
360
    return NULL;
×
361
  }
362

363
  mTrace("stb:%s, decode from raw:%p, row:%p", pStb->name, pRaw, pStb);
47,593✔
364
  return pRow;
47,593✔
365
}
366

367
void mndFreeStb(SStbObj *pStb) {
56,714✔
368
  taosArrayDestroy(pStb->pFuncs);
56,714✔
369
  taosMemoryFreeClear(pStb->pColumns);
56,714!
370
  taosMemoryFreeClear(pStb->pTags);
56,714!
371
  taosMemoryFreeClear(pStb->comment);
56,714!
372
  taosMemoryFreeClear(pStb->pAst1);
56,714!
373
  taosMemoryFreeClear(pStb->pAst2);
56,714!
374
  taosMemoryFreeClear(pStb->pCmpr);
56,714!
375
  taosMemoryFreeClear(pStb->pExtSchemas);
56,714!
376
}
56,714✔
377

378
static int32_t mndStbActionInsert(SSdb *pSdb, SStbObj *pStb) {
13,647✔
379
  mTrace("stb:%s, perform insert action, row:%p", pStb->name, pStb);
13,647✔
380
  return 0;
13,647✔
381
}
382

383
static int32_t mndStbActionDelete(SSdb *pSdb, SStbObj *pStb) {
56,590✔
384
  mTrace("stb:%s, perform delete action, row:%p", pStb->name, pStb);
56,590✔
385
  mndFreeStb(pStb);
56,590✔
386
  return 0;
56,590✔
387
}
388

389
static int32_t mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew) {
29,763✔
390
  terrno = 0;
29,763✔
391
  mTrace("stb:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
29,763✔
392

393
  taosWLockLatch(&pOld->lock);
29,763✔
394
  int32_t numOfColumns = pOld->numOfColumns;
29,763✔
395
  if (pOld->numOfColumns < pNew->numOfColumns) {
29,763✔
396
    void *pColumns = taosMemoryMalloc(pNew->numOfColumns * sizeof(SSchema));
6,176!
397
    if (pColumns == NULL) {
6,176!
398
      goto END;
×
399
    }
400
    taosMemoryFree(pOld->pColumns);
6,176!
401
    pOld->pColumns = pColumns;
6,176✔
402
  }
403

404
  if (pOld->numOfTags < pNew->numOfTags) {
29,763✔
405
    void *pTags = taosMemoryMalloc(pNew->numOfTags * sizeof(SSchema));
1,297!
406
    if (pTags == NULL) {
1,297!
407
      goto END;
×
408
    }
409
    taosMemoryFree(pOld->pTags);
1,297!
410
    pOld->pTags = pTags;
1,297✔
411
  }
412

413
  if (pOld->commentLen < pNew->commentLen && pNew->commentLen > 0) {
29,763✔
414
    void *comment = taosMemoryMalloc(pNew->commentLen + 1);
25!
415
    if (comment == NULL) {
25!
416
      goto END;
×
417
    }
418
    taosMemoryFree(pOld->comment);
25!
419
    pOld->comment = comment;
25✔
420
  }
421
  pOld->commentLen = pNew->commentLen;
29,763✔
422

423
  if (pOld->ast1Len < pNew->ast1Len) {
29,763!
424
    void *pAst1 = taosMemoryMalloc(pNew->ast1Len + 1);
×
425
    if (pAst1 == NULL) {
×
426
      goto END;
×
427
    }
428
    taosMemoryFree(pOld->pAst1);
×
429
    pOld->pAst1 = pAst1;
×
430
  }
431

432
  if (pOld->ast2Len < pNew->ast2Len) {
29,763!
433
    void *pAst2 = taosMemoryMalloc(pNew->ast2Len + 1);
×
434
    if (pAst2 == NULL) {
×
435
      goto END;
×
436
    }
437
    taosMemoryFree(pOld->pAst2);
×
438
    pOld->pAst2 = pAst2;
×
439
  }
440

441
  pOld->updateTime = pNew->updateTime;
29,763✔
442
  pOld->tagVer = pNew->tagVer;
29,763✔
443
  pOld->colVer = pNew->colVer;
29,763✔
444
  pOld->smaVer = pNew->smaVer;
29,763✔
445
  pOld->nextColId = pNew->nextColId;
29,763✔
446
  pOld->ttl = pNew->ttl;
29,763✔
447
  pOld->keep = pNew->keep;
29,763✔
448
  
449
  if (pNew->numOfColumns > 0) {
29,763!
450
    pOld->numOfColumns = pNew->numOfColumns;
29,763✔
451
    memcpy(pOld->pColumns, pNew->pColumns, pOld->numOfColumns * sizeof(SSchema));
29,763✔
452
  }
453
  if (pNew->numOfTags > 0) {
29,763!
454
    pOld->numOfTags = pNew->numOfTags;
29,763✔
455
    memcpy(pOld->pTags, pNew->pTags, pOld->numOfTags * sizeof(SSchema));
29,763✔
456
  }
457
  if (pNew->commentLen > 0) {
29,763✔
458
    memcpy(pOld->comment, pNew->comment, pNew->commentLen + 1);
250✔
459
    pOld->commentLen = pNew->commentLen;
250✔
460
  }
461
  if (pNew->ast1Len != 0) {
29,763!
462
    memcpy(pOld->pAst1, pNew->pAst1, pNew->ast1Len);
×
463
    pOld->ast1Len = pNew->ast1Len;
×
464
  }
465
  if (pNew->ast2Len != 0) {
29,763!
466
    memcpy(pOld->pAst2, pNew->pAst2, pNew->ast2Len);
×
467
    pOld->ast2Len = pNew->ast2Len;
×
468
  }
469
  if (numOfColumns < pNew->numOfColumns) {
29,763✔
470
    taosMemoryFree(pOld->pCmpr);
6,176!
471
    pOld->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
6,176!
472
    if (pOld->pCmpr == NULL){
6,176!
473
      goto END;
×
474
    }
475
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
6,176✔
476
  } else {
477
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
23,587✔
478
  }
479

480
  if (pNew->pExtSchemas) {
29,763✔
481
    taosMemoryFreeClear(pOld->pExtSchemas);
19,192!
482
    pOld->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
19,192!
483
    if (pOld->pExtSchemas == NULL){
19,192!
484
      goto END;
×
485
    }
486
    memcpy(pOld->pExtSchemas, pNew->pExtSchemas, pNew->numOfColumns * sizeof(SExtSchema));
19,192✔
487
  }
488

489
END:
10,571✔
490
  taosWUnLockLatch(&pOld->lock);
29,763✔
491
  return terrno;
29,763✔
492
}
493

494
SStbObj *mndAcquireStb(SMnode *pMnode, char *stbName) {
2,039,104✔
495
  SSdb    *pSdb = pMnode->pSdb;
2,039,104✔
496
  SStbObj *pStb = sdbAcquire(pSdb, SDB_STB, stbName);
2,039,104✔
497
  if (pStb == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
2,039,221!
498
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
13,564✔
499
  }
500
  return pStb;
2,039,221✔
501
}
502

503
void mndReleaseStb(SMnode *pMnode, SStbObj *pStb) {
2,035,710✔
504
  SSdb *pSdb = pMnode->pSdb;
2,035,710✔
505
  sdbRelease(pSdb, pStb);
2,035,710✔
506
}
2,035,722✔
507

508
SDbObj *mndAcquireDbByStb(SMnode *pMnode, const char *stbName) {
22,045✔
509
  SName name = {0};
22,045✔
510
  if ((terrno = tNameFromString(&name, stbName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) return NULL;
22,045!
511

512
  char db[TSDB_TABLE_FNAME_LEN] = {0};
22,045✔
513
  if ((terrno = tNameGetFullDbName(&name, db)) != 0) return NULL;
22,045!
514

515
  return mndAcquireDb(pMnode, db);
22,045✔
516
}
517

518
static FORCE_INLINE int32_t schemaExColIdCompare(const void *colId, const void *pSchema) {
519
  if (*(col_id_t *)colId < ((SSchema *)pSchema)->colId) {
520
    return -1;
521
  } else if (*(col_id_t *)colId > ((SSchema *)pSchema)->colId) {
522
    return 1;
523
  }
524
  return 0;
525
}
526

527
void *mndBuildVCreateStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen, void *alterOriData,
36,446✔
528
                            int32_t alterOriDataLen) {
529
  SEncoder       encoder = {0};
36,446✔
530
  int32_t        contLen;
531
  SName          name = {0};
36,446✔
532
  SVCreateStbReq req = {0};
36,446✔
533

534
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
36,446!
535
    goto _err;
×
536
  }
537
  char dbFName[TSDB_DB_FNAME_LEN] = {0};
36,446✔
538
  if ((terrno = tNameGetFullDbName(&name, dbFName)) != 0) {
36,446!
539
    goto _err;
×
540
  };
541

542
  req.name = (char *)tNameGetTableName(&name);
36,446✔
543
  req.suid = pStb->uid;
36,446✔
544
  req.rollup = pStb->ast1Len > 0 ? 1 : 0;
36,446✔
545
  req.alterOriData = alterOriData;
36,446✔
546
  req.alterOriDataLen = alterOriDataLen;
36,446✔
547
  req.source = pStb->source;
36,446✔
548
  req.virtualStb = pStb->virtualStb;
36,446✔
549
  // todo
550
  req.schemaRow.nCols = pStb->numOfColumns;
36,446✔
551
  req.schemaRow.version = pStb->colVer;
36,446✔
552
  req.schemaRow.pSchema = pStb->pColumns;
36,446✔
553
  req.schemaTag.nCols = pStb->numOfTags;
36,446✔
554
  req.schemaTag.version = pStb->tagVer;
36,446✔
555
  req.schemaTag.pSchema = pStb->pTags;
36,446✔
556

557
  req.colCmpred = 1;
36,446✔
558
  SColCmprWrapper *pCmpr = &req.colCmpr;
36,446✔
559
  req.keep = pStb->keep;
36,446✔
560
  pCmpr->version = pStb->colVer;
36,446✔
561
  pCmpr->nCols = pStb->numOfColumns;
36,446✔
562

563
  req.colCmpr.pColCmpr = taosMemoryCalloc(pCmpr->nCols, sizeof(SColCmpr));
36,446!
564
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
3,228,255✔
565
    SColCmpr *p = &pCmpr->pColCmpr[i];
3,191,809✔
566
    p->alg = pStb->pCmpr[i].alg;
3,191,809✔
567
    p->id = pStb->pCmpr[i].id;
3,191,809✔
568
  }
569

570
/*
571
  if (req.rollup) {
572
    req.rsmaParam.maxdelay[0] = pStb->maxdelay[0];
573
    req.rsmaParam.maxdelay[1] = pStb->maxdelay[1];
574
    req.rsmaParam.watermark[0] = pStb->watermark[0];
575
    req.rsmaParam.watermark[1] = pStb->watermark[1];
576
    if (pStb->ast1Len > 0) {
577
      if (mndConvertRsmaTask(&req.rsmaParam.qmsg[0], &req.rsmaParam.qmsgLen[0], pStb->pAst1, pStb->uid,
578
                             STREAM_TRIGGER_WINDOW_CLOSE, req.rsmaParam.watermark[0],
579
                             req.rsmaParam.deleteMark[0]) < 0) {
580
        goto _err;
581
      }
582
    }
583
    if (pStb->ast2Len > 0) {
584
      if (mndConvertRsmaTask(&req.rsmaParam.qmsg[1], &req.rsmaParam.qmsgLen[1], pStb->pAst2, pStb->uid,
585
                             STREAM_TRIGGER_WINDOW_CLOSE, req.rsmaParam.watermark[1],
586
                             req.rsmaParam.deleteMark[1]) < 0) {
587
        goto _err;
588
      }
589
    }
590
  }
591
*/  
592
  req.pExtSchemas = pStb->pExtSchemas; // only reference to it.
36,446✔
593
  // get length
594
  int32_t ret = 0;
36,446✔
595
  tEncodeSize(tEncodeSVCreateStbReq, &req, contLen, ret);
36,446!
596
  if (ret < 0) {
36,446!
597
    goto _err;
×
598
  }
599

600
  contLen += sizeof(SMsgHead);
36,446✔
601

602
  SMsgHead *pHead = taosMemoryCalloc(1, contLen);
36,446!
603
  if (pHead == NULL) {
36,446!
604
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
605
    goto _err;
×
606
  }
607

608
  pHead->contLen = htonl(contLen);
36,446✔
609
  pHead->vgId = htonl(pVgroup->vgId);
36,446✔
610

611
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
36,446✔
612
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
36,446✔
613
  if (tEncodeSVCreateStbReq(&encoder, &req) < 0) {
36,446!
614
    taosMemoryFreeClear(pHead);
×
615
    tEncoderClear(&encoder);
×
616
    goto _err;
×
617
  }
618
  tEncoderClear(&encoder);
36,446✔
619

620
  *pContLen = contLen;
36,446✔
621
  taosMemoryFreeClear(req.rsmaParam.qmsg[0]);
36,446!
622
  taosMemoryFreeClear(req.rsmaParam.qmsg[1]);
36,446!
623
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
36,446!
624
  return pHead;
36,446✔
625
_err:
×
626
  taosMemoryFreeClear(req.rsmaParam.qmsg[0]);
×
627
  taosMemoryFreeClear(req.rsmaParam.qmsg[1]);
×
628
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
×
629
  return NULL;
×
630
}
631

632
static void *mndBuildVDropStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen) {
24,448✔
633
  SName        name = {0};
24,448✔
634
  SVDropStbReq req = {0};
24,448✔
635
  int32_t      contLen = 0;
24,448✔
636
  int32_t      ret = 0;
24,448✔
637
  SMsgHead    *pHead = NULL;
24,448✔
638
  SEncoder     encoder = {0};
24,448✔
639

640
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
24,448!
641
    return NULL;
×
642
  }
643

644
  req.name = (char *)tNameGetTableName(&name);
24,448✔
645
  req.suid = pStb->uid;
24,448✔
646

647
  tEncodeSize(tEncodeSVDropStbReq, &req, contLen, ret);
24,448!
648
  if (ret < 0) return NULL;
24,448!
649

650
  contLen += sizeof(SMsgHead);
24,448✔
651
  pHead = taosMemoryMalloc(contLen);
24,448!
652
  if (pHead == NULL) {
24,448!
653
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
654
    return NULL;
×
655
  }
656

657
  pHead->contLen = htonl(contLen);
24,448✔
658
  pHead->vgId = htonl(pVgroup->vgId);
24,448✔
659

660
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
24,448✔
661

662
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
24,448✔
663
  int32_t code = tEncodeSVDropStbReq(&encoder, &req);
24,448✔
664
  tEncoderClear(&encoder);
24,448✔
665
  if (code != 0) {
24,448!
666
    terrno = code;
×
667
    return NULL;
×
668
  }
669

670
  *pContLen = contLen;
24,448✔
671
  return pHead;
24,448✔
672
}
673

674
int32_t mndCheckCreateStbReq(SMCreateStbReq *pCreate) {
9,283✔
675
  int32_t code = 0;
9,283✔
676
  if (pCreate->igExists < 0 || pCreate->igExists > 1) {
9,283!
677
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
678
    TAOS_RETURN(code);
×
679
  }
680

681
  if (pCreate->virtualStb != 0 && pCreate->virtualStb != 1) {
9,283!
682
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
683
    TAOS_RETURN(code);
×
684
  }
685

686
  if (pCreate->numOfColumns < TSDB_MIN_COLUMNS || pCreate->numOfTags + pCreate->numOfColumns > TSDB_MAX_COLUMNS) {
9,283!
687
    code = TSDB_CODE_PAR_INVALID_COLUMNS_NUM;
×
688
    TAOS_RETURN(code);
×
689
  }
690

691
  if (pCreate->numOfTags <= 0 || pCreate->numOfTags > TSDB_MAX_TAGS) {
9,283!
692
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
693
    TAOS_RETURN(code);
×
694
  }
695

696
  SField *pField = taosArrayGet(pCreate->pColumns, 0);
9,283✔
697
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
9,283!
698
    code = TSDB_CODE_PAR_INVALID_FIRST_COLUMN;
×
699
    TAOS_RETURN(code);
×
700
  }
701

702
  for (int32_t i = 0; i < pCreate->numOfColumns; ++i) {
244,256✔
703
    SFieldWithOptions *pField1 = taosArrayGet(pCreate->pColumns, i);
234,973✔
704
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
234,973!
705
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
706
      TAOS_RETURN(code);
×
707
    }
708
    if (pField1->bytes <= 0) {
234,973!
709
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
710
      TAOS_RETURN(code);
×
711
    }
712
    if (pField1->name[0] == 0) {
234,973!
713
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
714
      TAOS_RETURN(code);
×
715
    }
716
  }
717

718
  for (int32_t i = 0; i < pCreate->numOfTags; ++i) {
59,627✔
719
    SField *pField1 = taosArrayGet(pCreate->pTags, i);
50,344✔
720
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
50,344!
721
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
722
      TAOS_RETURN(code);
×
723
    }
724
    if (pField1->bytes <= 0) {
50,344!
725
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
726
      TAOS_RETURN(code);
×
727
    }
728
    if (pField1->name[0] == 0) {
50,344!
729
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
730
      TAOS_RETURN(code);
×
731
    }
732
  }
733

734
  TAOS_RETURN(code);
9,283✔
735
}
736

737
static int32_t mndSetCreateStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
×
738
  int32_t  code = 0;
×
739
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
×
740
  if (pRedoRaw == NULL) {
×
741
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
742
    if (terrno != 0) code = terrno;
×
743
    TAOS_RETURN(code);
×
744
  }
745
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
×
746
    sdbFreeRaw(pRedoRaw);
×
747
    TAOS_RETURN(code);
×
748
  }
749
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
×
750

751
  TAOS_RETURN(code);
×
752
}
753

754
int32_t mndSetCreateStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,003✔
755
  int32_t  code = 0;
9,003✔
756
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
9,003✔
757
  if (pCommitRaw == NULL) {
9,003!
758
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
759
    if (terrno != 0) code = terrno;
×
760
    TAOS_RETURN(code);
×
761
  }
762
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
9,003!
763
    sdbFreeRaw(pCommitRaw);
×
764
    TAOS_RETURN(code);
×
765
  }
766
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
9,003!
767

768
  TAOS_RETURN(code);
9,003✔
769
}
770

771
static int32_t mndSetCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
8,991✔
772
  int32_t code = 0;
8,991✔
773
  SSdb   *pSdb = pMnode->pSdb;
8,991✔
774
  SVgObj *pVgroup = NULL;
8,991✔
775
  void   *pIter = NULL;
8,991✔
776
  int32_t contLen;
777

778
  while (1) {
72,541✔
779
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
81,532✔
780
    if (pIter == NULL) break;
81,532✔
781
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
72,541✔
782
      sdbRelease(pSdb, pVgroup);
51,438✔
783
      continue;
51,438✔
784
    }
785

786
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
21,103✔
787
    if (pReq == NULL) {
21,103!
788
      sdbCancelFetch(pSdb, pIter);
×
789
      sdbRelease(pSdb, pVgroup);
×
790
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
791
      if (terrno != 0) code = terrno;
×
792
      TAOS_RETURN(code);
×
793
    }
794

795
    STransAction action = {0};
21,103✔
796
    action.mTraceId = pTrans->mTraceId;
21,103✔
797
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
21,103✔
798
    action.pCont = pReq;
21,103✔
799
    action.contLen = contLen;
21,103✔
800
    action.msgType = TDMT_VND_CREATE_STB;
21,103✔
801
    action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
21,103✔
802
    action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
21,103✔
803
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
21,103!
804
      taosMemoryFree(pReq);
×
805
      sdbCancelFetch(pSdb, pIter);
×
806
      sdbRelease(pSdb, pVgroup);
×
807
      TAOS_RETURN(code);
×
808
    }
809
    sdbRelease(pSdb, pVgroup);
21,103✔
810
  }
811

812
  TAOS_RETURN(code);
8,991✔
813
}
814

815
int32_t mndSetForceDropCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup, SStbObj *pStb) {
2✔
816
  int32_t code = 0;
2✔
817
  SSdb   *pSdb = pMnode->pSdb;
2✔
818
  int32_t contLen;
819

820
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
2✔
821
  if (pReq == NULL) {
2!
822
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
823
    if (terrno != 0) code = terrno;
×
824
    TAOS_RETURN(code);
×
825
  }
826

827
  STransAction action = {0};
2✔
828
  action.mTraceId = pTrans->mTraceId;
2✔
829
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
2✔
830
  action.pCont = pReq;
2✔
831
  action.contLen = contLen;
2✔
832
  action.msgType = TDMT_VND_CREATE_STB;
2✔
833
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
2✔
834
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
2✔
835
  action.groupId = pVgroup->vgId;
2✔
836
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
2!
837
    taosMemoryFree(pReq);
×
838
    TAOS_RETURN(code);
×
839
  }
840

841
  TAOS_RETURN(code);
2✔
842
}
843

844
static int32_t mndSetCreateStbUndoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
8,991✔
845
  int32_t code = 0;
8,991✔
846
  SSdb   *pSdb = pMnode->pSdb;
8,991✔
847
  SVgObj *pVgroup = NULL;
8,991✔
848
  void   *pIter = NULL;
8,991✔
849

850
  while (1) {
72,541✔
851
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
81,532✔
852
    if (pIter == NULL) break;
81,532✔
853
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
72,541✔
854
      sdbRelease(pSdb, pVgroup);
51,438✔
855
      continue;
51,438✔
856
    }
857

858
    int32_t contLen = 0;
21,103✔
859
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
21,103✔
860
    if (pReq == NULL) {
21,103!
861
      sdbCancelFetch(pSdb, pIter);
×
862
      sdbRelease(pSdb, pVgroup);
×
863
      code = TSDB_CODE_OUT_OF_MEMORY;
×
864
      TAOS_RETURN(code);
×
865
    }
866

867
    STransAction action = {0};
21,103✔
868
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
21,103✔
869
    action.pCont = pReq;
21,103✔
870
    action.contLen = contLen;
21,103✔
871
    action.msgType = TDMT_VND_DROP_STB;
21,103✔
872
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
21,103✔
873
    if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
21,103!
874
      taosMemoryFree(pReq);
×
875
      sdbCancelFetch(pSdb, pIter);
×
876
      sdbRelease(pSdb, pVgroup);
×
877
      TAOS_RETURN(code);
×
878
    }
879
    sdbRelease(pSdb, pVgroup);
21,103✔
880
  }
881

882
  TAOS_RETURN(code);
8,991✔
883
}
884

885
static SSchema *mndFindStbColumns(const SStbObj *pStb, const char *colName) {
×
886
  for (int32_t col = 0; col < pStb->numOfColumns; ++col) {
×
887
    SSchema *pSchema = &pStb->pColumns[col];
×
888
    if (taosStrncasecmp(pSchema->name, colName, TSDB_COL_NAME_LEN) == 0) {
×
889
      return pSchema;
×
890
    }
891
  }
892
  return NULL;
×
893
}
894

895
int32_t mndBuildStbFromReq(SMnode *pMnode, SStbObj *pDst, SMCreateStbReq *pCreate, SDbObj *pDb) {
9,109✔
896
  int32_t code = 0;
9,109✔
897
  bool    hasTypeMods = false;
9,109✔
898
  memcpy(pDst->name, pCreate->name, TSDB_TABLE_FNAME_LEN);
9,109✔
899
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
9,109✔
900
  pDst->createdTime = taosGetTimestampMs();
9,109✔
901
  pDst->updateTime = pDst->createdTime;
9,109✔
902
  pDst->uid = (pCreate->source == TD_REQ_FROM_TAOX_OLD || pCreate->source == TD_REQ_FROM_TAOX || pCreate->source == TD_REQ_FROM_SML)
9,109!
903
                  ? pCreate->suid
904
                  : mndGenerateUid(pCreate->name, TSDB_TABLE_FNAME_LEN);
18,218!
905
  pDst->dbUid = pDb->uid;
9,109✔
906
  pDst->tagVer = 1;
9,109✔
907
  pDst->colVer = 1;
9,109✔
908
  pDst->smaVer = 1;
9,109✔
909
  pDst->nextColId = 1;
9,109✔
910
  pDst->maxdelay[0] = pCreate->delay1;
9,109✔
911
  pDst->maxdelay[1] = pCreate->delay2;
9,109✔
912
  pDst->watermark[0] = pCreate->watermark1;
9,109✔
913
  pDst->watermark[1] = pCreate->watermark2;
9,109✔
914
  pDst->ttl = pCreate->ttl;
9,109✔
915
  pDst->numOfColumns = pCreate->numOfColumns;
9,109✔
916
  pDst->numOfTags = pCreate->numOfTags;
9,109✔
917
  pDst->numOfFuncs = pCreate->numOfFuncs;
9,109✔
918
  pDst->commentLen = pCreate->commentLen;
9,109✔
919
  pDst->pFuncs = pCreate->pFuncs;
9,109✔
920
  pDst->source = pCreate->source;
9,109✔
921
  pDst->keep = pCreate->keep;
9,109✔
922
  pDst->virtualStb = pCreate->virtualStb;
9,109✔
923
  pCreate->pFuncs = NULL;
9,109✔
924

925
  if (pDst->commentLen > 0) {
9,109✔
926
    pDst->comment = taosMemoryCalloc(pDst->commentLen + 1, 1);
34!
927
    if (pDst->comment == NULL) {
34!
928
      code = terrno;
×
929
      TAOS_RETURN(code);
×
930
    }
931
    memcpy(pDst->comment, pCreate->pComment, pDst->commentLen + 1);
34✔
932
  }
933

934
  pDst->ast1Len = pCreate->ast1Len;
9,109✔
935
  if (pDst->ast1Len > 0) {
9,109✔
936
    pDst->pAst1 = taosMemoryCalloc(pDst->ast1Len, 1);
1!
937
    if (pDst->pAst1 == NULL) {
1!
938
      code = terrno;
×
939
      TAOS_RETURN(code);
×
940
    }
941
    memcpy(pDst->pAst1, pCreate->pAst1, pDst->ast1Len);
1✔
942
  }
943

944
  pDst->ast2Len = pCreate->ast2Len;
9,109✔
945
  if (pDst->ast2Len > 0) {
9,109✔
946
    pDst->pAst2 = taosMemoryCalloc(pDst->ast2Len, 1);
1!
947
    if (pDst->pAst2 == NULL) {
1!
948
      code = terrno;
×
949
      TAOS_RETURN(code);
×
950
    }
951
    memcpy(pDst->pAst2, pCreate->pAst2, pDst->ast2Len);
1✔
952
  }
953

954
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
9,109!
955
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
9,109!
956
  if (pDst->pColumns == NULL || pDst->pTags == NULL) {
9,109!
957
    code = terrno;
×
958
    TAOS_RETURN(code);
×
959
  }
960

961
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
9,109!
962
    code = TSDB_CODE_OUT_OF_RANGE;
×
963
    TAOS_RETURN(code);
×
964
  }
965

966
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
242,796✔
967
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
233,687✔
968
    SSchema           *pSchema = &pDst->pColumns[i];
233,687✔
969
    pSchema->type = pField->type;
233,687✔
970
    pSchema->bytes = pField->bytes;
233,687✔
971
    pSchema->flags = pField->flags;
233,687✔
972
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
233,687✔
973
    pSchema->colId = pDst->nextColId;
233,687✔
974
    pDst->nextColId++;
233,687✔
975
    hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
233,687✔
976
  }
977

978
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
58,065✔
979
    SField  *pField = taosArrayGet(pCreate->pTags, i);
48,956✔
980
    SSchema *pSchema = &pDst->pTags[i];
48,956✔
981
    pSchema->type = pField->type;
48,956✔
982
    pSchema->bytes = pField->bytes;
48,956✔
983
    if (i == 0) {
48,956✔
984
      SSCHMEA_SET_IDX_ON(pSchema);
9,109✔
985
    }
986
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
48,956✔
987
    pSchema->colId = pDst->nextColId;
48,956✔
988
    pDst->nextColId++;
48,956✔
989
  }
990
  // set col compress
991
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
9,109!
992
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
242,796✔
993
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
233,687✔
994
    SSchema           *pSchema = &pDst->pColumns[i];
233,687✔
995

996
    SColCmpr *pColCmpr = &pDst->pCmpr[i];
233,687✔
997
    pColCmpr->id = pSchema->colId;
233,687✔
998
    pColCmpr->alg = pField->compress;
233,687✔
999
  }
1000

1001
  if (hasTypeMods) {
9,109✔
1002
    pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
43!
1003
    if (!pDst->pExtSchemas) {
43!
1004
      code = terrno;
×
1005
      TAOS_RETURN(code);
×
1006
    }
1007
    for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
801✔
1008
      SFieldWithOptions * pField = taosArrayGet(pCreate->pColumns, i);
758✔
1009
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
758✔
1010
    }
1011
  }
1012
  TAOS_RETURN(code);
9,109✔
1013
}
1014
int32_t mndGenIdxNameForFirstTag(char *fullname, char *dbname, char *stbname, char *tagname) {
9,009✔
1015
  SName name = {0};
9,009✔
1016
  if ((terrno = tNameFromString(&name, stbname, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
9,009!
1017
    return -1;
×
1018
  }
1019
  return snprintf(fullname, TSDB_INDEX_FNAME_LEN, "%s.%s_%s", dbname, tagname, tNameGetTableName(&name));
9,009✔
1020
}
1021

1022
static int32_t mndCreateStb(SMnode *pMnode, SRpcMsg *pReq, SMCreateStbReq *pCreate, SDbObj *pDb) {
8,997✔
1023
  SStbObj stbObj = {0};
8,997✔
1024
  int32_t code = -1;
8,997✔
1025

1026
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
8,997✔
1027

1028
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb");
8,997✔
1029
  if (pTrans == NULL) {
8,997!
1030
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
1031
    if (terrno != 0) code = terrno;
×
1032
    goto _OVER;
×
1033
  }
1034

1035
  mInfo("trans:%d, used to create stb:%s", pTrans->id, pCreate->name);
8,997!
1036
  TAOS_CHECK_GOTO(mndBuildStbFromReq(pMnode, &stbObj, pCreate, pDb), NULL, _OVER);
8,997!
1037

1038
  SSchema *pSchema = &(stbObj.pTags[0]);
8,997✔
1039
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
8,997!
1040
    goto _OVER;
×
1041
  }
1042
  SSIdx idx = {0};
8,997✔
1043
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
8,997!
1044
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
1045
    mndReleaseIdx(pMnode, idx.pIdx);
×
1046
    goto _OVER;
×
1047
  }
1048

1049
  SIdxObj idxObj = {0};
8,997✔
1050
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
8,997✔
1051
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
8,997✔
1052
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
8,997✔
1053
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
8,997✔
1054
  idxObj.createdTime = taosGetTimestampMs();
8,997✔
1055
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
8,997✔
1056
  idxObj.stbUid = stbObj.uid;
8,997✔
1057
  idxObj.dbUid = stbObj.dbUid;
8,997✔
1058

1059
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
8,997!
1060

1061
  TAOS_CHECK_GOTO(mndAddStbToTrans(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
8,997✔
1062
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
8,879!
1063
  code = 0;
8,879✔
1064

1065
_OVER:
8,997✔
1066
  mndTransDrop(pTrans);
8,997✔
1067
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
8,997!
1068
  TAOS_RETURN(code);
8,997✔
1069
}
1070

1071
int32_t mndAddStbToTrans(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,109✔
1072
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
9,109✔
1073
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
9,109✔
1074
  TAOS_CHECK_RETURN(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, pStb));
8,991!
1075
  TAOS_CHECK_RETURN(mndSetCreateStbRedoActions(pMnode, pTrans, pDb, pStb));
8,991!
1076
  TAOS_CHECK_RETURN(mndSetCreateStbUndoActions(pMnode, pTrans, pDb, pStb));
8,991!
1077
  return 0;
8,991✔
1078
}
1079

1080
static int32_t mndProcessTtlTimer(SRpcMsg *pReq) {
6,771✔
1081
  SMnode           *pMnode = pReq->info.node;
6,771✔
1082
  SSdb             *pSdb = pMnode->pSdb;
6,771✔
1083
  SVgObj           *pVgroup = NULL;
6,771✔
1084
  void             *pIter = NULL;
6,771✔
1085
  SVDropTtlTableReq ttlReq = {
6,771✔
1086
      .timestampSec = taosGetTimestampSec(), .ttlDropMaxCount = tsTtlBatchDropNum, .nUids = 0, .pTbUids = NULL};
6,771✔
1087
  int32_t reqLen = tSerializeSVDropTtlTableReq(NULL, 0, &ttlReq);
6,771✔
1088
  int32_t contLen = reqLen + sizeof(SMsgHead);
6,771✔
1089

1090
  mDebug("start to process ttl timer");
6,771✔
1091

1092
  while (1) {
58,559✔
1093
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
65,330✔
1094
    if (pIter == NULL) break;
65,330✔
1095

1096
    if (pVgroup->mountVgId) {
58,559✔
1097
      sdbRelease(pSdb, pVgroup);
8✔
1098
      continue;
8✔
1099
    }
1100

1101
    int32_t   code = 0;
58,551✔
1102
    SMsgHead *pHead = rpcMallocCont(contLen);
58,551✔
1103
    if (pHead == NULL) {
58,551!
1104
      sdbRelease(pSdb, pVgroup);
×
1105
      continue;
×
1106
    }
1107
    pHead->contLen = htonl(contLen);
58,551✔
1108
    pHead->vgId = htonl(pVgroup->vgId);
58,551✔
1109
    if ((code = tSerializeSVDropTtlTableReq((char *)pHead + sizeof(SMsgHead), reqLen, &ttlReq)) < 0) {
58,551!
1110
      mError("vgId:%d, failed to serialize drop ttl table request since %s", pVgroup->vgId, tstrerror(code));
×
1111
      sdbRelease(pSdb, pVgroup);
×
1112
      continue;
×
1113
    }
1114

1115
    SRpcMsg rpcMsg = {
58,551✔
1116
        .msgType = TDMT_VND_FETCH_TTL_EXPIRED_TBS, .pCont = pHead, .contLen = contLen, .info = pReq->info};
1117
    SEpSet epSet = mndGetVgroupEpset(pMnode, pVgroup);
58,551✔
1118
    code = tmsgSendReq(&epSet, &rpcMsg);
58,551✔
1119
    if (code != 0) {
58,551✔
1120
      mError("vgId:%d, failed to send drop ttl table request to vnode since 0x%x", pVgroup->vgId, code);
120!
1121
    } else {
1122
      mDebug("vgId:%d, send drop ttl table request to vnode, time:%" PRId32, pVgroup->vgId, ttlReq.timestampSec);
58,431✔
1123
    }
1124
    sdbRelease(pSdb, pVgroup);
58,551✔
1125
  }
1126

1127
  return 0;
6,771✔
1128
}
1129

1130
static int32_t mndProcessTrimDbTimer(SRpcMsg *pReq) {
3✔
1131
  SMnode     *pMnode = pReq->info.node;
3✔
1132
  SSdb       *pSdb = pMnode->pSdb;
3✔
1133
  SVgObj     *pVgroup = NULL;
3✔
1134
  void       *pIter = NULL;
3✔
1135
  SVTrimDbReq trimReq = {.timestamp = taosGetTimestampSec()};
3✔
1136
  int32_t     reqLen = tSerializeSVTrimDbReq(NULL, 0, &trimReq);
3✔
1137
  int32_t     contLen = reqLen + sizeof(SMsgHead);
3✔
1138

1139
  while (1) {
87✔
1140
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
90✔
1141
    if (pIter == NULL) break;
90✔
1142
    if (pVgroup->mountVgId) {
87!
1143
      sdbRelease(pSdb, pVgroup);
×
1144
      continue;
×
1145
    }
1146

1147
    int32_t code = 0;
87✔
1148

1149
    SMsgHead *pHead = rpcMallocCont(contLen);
87✔
1150
    if (pHead == NULL) {
87!
1151
      sdbCancelFetch(pSdb, pVgroup);
×
1152
      sdbRelease(pSdb, pVgroup);
×
1153
      continue;
×
1154
    }
1155
    pHead->contLen = htonl(contLen);
87✔
1156
    pHead->vgId = htonl(pVgroup->vgId);
87✔
1157
    if ((code = tSerializeSVTrimDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &trimReq)) < 0) {
87!
1158
      mError("vgId:%d, failed to serialize trim db request since %s", pVgroup->vgId, tstrerror(code));
×
1159
    }
1160

1161
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_TRIM, .pCont = pHead, .contLen = contLen};
87✔
1162
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
87✔
1163
    code = tmsgSendReq(&epSet, &rpcMsg);
87✔
1164
    if (code != 0) {
87!
1165
      mError("vgId:%d, timer failed to send vnode-trim request to vnode since 0x%x", pVgroup->vgId, code);
×
1166
    } else {
1167
      mInfo("vgId:%d, timer send vnode-trim request to vnode, time:%d", pVgroup->vgId, trimReq.timestamp);
87!
1168
    }
1169
    sdbRelease(pSdb, pVgroup);
87✔
1170
  }
1171

1172
  return 0;
3✔
1173
}
1174

1175
static int32_t mndFindSuperTableTagIndex(const SStbObj *pStb, const char *tagName) {
8,049✔
1176
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
116,515✔
1177
    if (strcmp(pStb->pTags[tag].name, tagName) == 0) {
110,948✔
1178
      return tag;
2,482✔
1179
    }
1180
  }
1181

1182
  return -1;
5,567✔
1183
}
1184

1185
static int32_t mndFindSuperTableColumnIndex(const SStbObj *pStb, const char *colName) {
10,034✔
1186
  for (int32_t col = 0; col < pStb->numOfColumns; col++) {
1,179,422✔
1187
    if (strcmp(pStb->pColumns[col].name, colName) == 0) {
1,173,719✔
1188
      return col;
4,331✔
1189
    }
1190
  }
1191

1192
  return -1;
5,703✔
1193
}
1194

1195
static bool mndValidateSchema(SSchema *pSchemas, int32_t nSchema, SArray *pFields, int32_t maxLen) {
5,557✔
1196
  int32_t rowLen = 0;
5,557✔
1197
  for (int32_t i = 0; i < nSchema; ++i) {
650,431✔
1198
    rowLen += (pSchemas + i)->bytes;
644,874✔
1199
  }
1200

1201
  int32_t nField = taosArrayGetSize(pFields);
5,557✔
1202
  for (int32_t i = 0; i < nField; ++i) {
11,114✔
1203
    rowLen += ((SField *)TARRAY_GET_ELEM(pFields, i))->bytes;
5,557✔
1204
  }
1205

1206
  return rowLen <= maxLen;
5,557✔
1207
}
1208

1209
static int32_t mndBuildStbFromAlter(SStbObj *pStb, SStbObj *pDst, SMCreateStbReq *createReq) {
96✔
1210
  int32_t code = 0;
96✔
1211
  taosRLockLatch(&pStb->lock);
96✔
1212
  memcpy(pDst, pStb, sizeof(SStbObj));
96✔
1213
  taosRUnLockLatch(&pStb->lock);
96✔
1214

1215
  pDst->source = createReq->source;
96✔
1216
  pDst->updateTime = taosGetTimestampMs();
96✔
1217
  pDst->numOfColumns = createReq->numOfColumns;
96✔
1218
  pDst->numOfTags = createReq->numOfTags;
96✔
1219
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
96!
1220
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
96!
1221
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SColCmpr));
96!
1222
  pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
96!
1223

1224
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL || pDst->pExtSchemas == NULL) {
96!
1225
    code = terrno;
×
1226
    TAOS_RETURN(code);
×
1227
  }
1228

1229
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
96!
1230
    code = TSDB_CODE_OUT_OF_RANGE;
×
1231
    TAOS_RETURN(code);
×
1232
  }
1233

1234
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
707✔
1235
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
611✔
1236
    SSchema           *pSchema = &pDst->pColumns[i];
611✔
1237
    pSchema->type = pField->type;
611✔
1238
    pSchema->bytes = pField->bytes;
611✔
1239
    pSchema->flags = pField->flags;
611✔
1240
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
611✔
1241
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pField->name);
611✔
1242
    if (cIndex >= 0) {
611✔
1243
      pSchema->colId = pStb->pColumns[cIndex].colId;
540✔
1244
    } else {
1245
      pSchema->colId = pDst->nextColId++;
71✔
1246
    }
1247
  }
1248

1249
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
776✔
1250
    SField  *pField = taosArrayGet(createReq->pTags, i);
680✔
1251
    SSchema *pSchema = &pDst->pTags[i];
680✔
1252
    pSchema->type = pField->type;
680✔
1253
    pSchema->bytes = pField->bytes;
680✔
1254
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
680✔
1255
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pField->name);
680✔
1256
    if (cIndex >= 0) {
680✔
1257
      pSchema->colId = pStb->pTags[cIndex].colId;
626✔
1258
    } else {
1259
      pSchema->colId = pDst->nextColId++;
54✔
1260
    }
1261
  }
1262
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
707✔
1263
    SColCmpr          *p = pDst->pCmpr + i;
611✔
1264
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
611✔
1265
    SSchema           *pSchema = &pDst->pColumns[i];
611✔
1266
    p->id = pSchema->colId;
611✔
1267
    if (pField->compress == 0) {
611!
1268
      p->alg = createDefaultColCmprByType(pSchema->type);
×
1269
    } else {
1270
      p->alg = pField->compress;
611✔
1271
    }
1272
    if (pField->flags & COL_HAS_TYPE_MOD) {
611!
1273
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
×
1274
    }
1275
  }
1276
  pDst->tagVer = createReq->tagVer;
96✔
1277
  pDst->colVer = createReq->colVer;
96✔
1278
  return TSDB_CODE_SUCCESS;
96✔
1279
}
1280

1281
static int32_t mndProcessCreateStbReq(SRpcMsg *pReq) {
9,171✔
1282
  SMnode        *pMnode = pReq->info.node;
9,171✔
1283
  int32_t        code = -1;
9,171✔
1284
  SStbObj       *pStb = NULL;
9,171✔
1285
  SDbObj        *pDb = NULL;
9,171✔
1286
  SMCreateStbReq createReq = {0};
9,171✔
1287
  bool           isAlter = false;
9,171✔
1288
  SHashObj      *pHash = NULL;
9,171✔
1289

1290
  if (tDeserializeSMCreateStbReq(pReq->pCont, pReq->contLen, &createReq) != 0) {
9,171!
1291
    code = TSDB_CODE_INVALID_MSG;
×
1292
    goto _OVER;
×
1293
  }
1294

1295
  mInfo("stb:%s, start to create", createReq.name);
9,171!
1296
  if (mndCheckCreateStbReq(&createReq) != 0) {
9,171!
1297
    code = TSDB_CODE_INVALID_MSG;
×
1298
    goto _OVER;
×
1299
  }
1300

1301
  pStb = mndAcquireStb(pMnode, createReq.name);
9,171✔
1302
  if (pStb != NULL) {
9,171✔
1303
    if (createReq.igExists) {
173✔
1304
      if (createReq.source == TD_REQ_FROM_APP) {
171✔
1305
        mInfo("stb:%s, already exist, ignore exist is set", createReq.name);
27!
1306
        code = 0;
27✔
1307
        goto _OVER;
27✔
1308
      } else if (pStb->uid != createReq.suid) {
144!
1309
        mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
1310
        code = 0;
×
1311
        goto _OVER;
×
1312
      } else if (createReq.tagVer > 0 || createReq.colVer > 0) {
240!
1313
        int32_t tagDelta = createReq.tagVer - pStb->tagVer;
144✔
1314
        int32_t colDelta = createReq.colVer - pStb->colVer;
144✔
1315
        mInfo("stb:%s, already exist while create, input tagVer:%d colVer:%d, exist tagVer:%d colVer:%d",
144!
1316
              createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1317
        if (tagDelta <= 0 && colDelta <= 0) {
144✔
1318
          mInfo("stb:%s, schema version is not incremented and nothing needs to be done", createReq.name);
48!
1319
          code = 0;
48✔
1320
          goto _OVER;
48✔
1321
        } else if ((tagDelta == 1 && colDelta == 0) || (tagDelta == 0 && colDelta == 1) ||
96!
1322
                   (pStb->colVer == 1 && createReq.colVer > 1) || (pStb->tagVer == 1 && createReq.tagVer > 1)) {
×
1323
          isAlter = true;
96✔
1324
          mInfo("stb:%s, schema version is only increased by 1 number, do alter operation", createReq.name);
96!
1325
        } else {
1326
          mError("stb:%s, schema version increase more than 1 number, error is returned", createReq.name);
×
1327
          code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
1328
          goto _OVER;
×
1329
        }
1330
      } else {
1331
        mError("stb:%s, already exist while create, input tagVer:%d colVer:%d is invalid, origin tagVer:%d colVer:%d",
×
1332
               createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1333
        code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
1334
        goto _OVER;
×
1335
      }
1336
    } else {
1337
      code = TSDB_CODE_MND_STB_ALREADY_EXIST;
2✔
1338
      goto _OVER;
2✔
1339
    }
1340
  } else if (terrno != TSDB_CODE_MND_STB_NOT_EXIST) {
8,998!
1341
    goto _OVER;
×
1342
  } else if ((createReq.source == TD_REQ_FROM_TAOX_OLD || createReq.source == TD_REQ_FROM_TAOX || createReq.source == TD_REQ_FROM_SML) &&
8,998!
1343
             (createReq.tagVer != 1 || createReq.colVer != 1)) {
1!
1344
    mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
1345
    code = 0;
×
1346
    goto _OVER;
×
1347
  }
1348

1349
  pHash = taosHashInit(createReq.numOfColumns + createReq.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY),
9,094✔
1350
                       false, HASH_NO_LOCK);
1351
  if (pHash == NULL) {
9,094!
1352
    code = TSDB_CODE_OUT_OF_MEMORY;
×
1353
    goto _OVER;
×
1354
  }
1355

1356
  for (int32_t i = 0; i < createReq.numOfColumns; ++i) {
242,926✔
1357
    SFieldWithOptions *pField = taosArrayGet(createReq.pColumns, i);
233,832✔
1358
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
233,832!
UNCOV
1359
      if (code == TSDB_CODE_DUP_KEY) {
×
UNCOV
1360
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1361
      }
UNCOV
1362
      goto _OVER;
×
1363
    }
1364
  }
1365

1366
  for (int32_t i = 0; i < createReq.numOfTags; ++i) {
58,545✔
1367
    SField *pField = taosArrayGet(createReq.pTags, i);
49,452✔
1368
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
49,452✔
1369
      if (code == TSDB_CODE_DUP_KEY) {
1!
1370
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
1✔
1371
      }
1372
      goto _OVER;
1✔
1373
    }
1374
  }
1375

1376
  pDb = mndAcquireDbByStb(pMnode, createReq.name);
9,093✔
1377
  if (pDb == NULL) {
9,093!
1378
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
1379
    goto _OVER;
×
1380
  }
1381

1382
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
9,093!
1383
    goto _OVER;
×
1384
  }
1385
  if (pDb->cfg.isMount) {
9,093!
1386
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
1387
    goto _OVER;
×
1388
  }
1389

1390
  int32_t numOfStbs = -1;
9,093✔
1391
  if ((code = mndGetNumOfStbs(pMnode, pDb->name, &numOfStbs)) != 0) {
9,093!
1392
    goto _OVER;
×
1393
  }
1394

1395
  if (pDb->cfg.numOfStables == 1 && numOfStbs != 0) {
9,093!
1396
    code = TSDB_CODE_MND_SINGLE_STB_MODE_DB;
×
1397
    goto _OVER;
×
1398
  }
1399

1400
  if ((code = grantCheck(TSDB_GRANT_STABLE)) < 0) {
9,093!
1401
    goto _OVER;
×
1402
  }
1403

1404
  if (isAlter) {
9,093✔
1405
    bool    needRsp = false;
96✔
1406
    SStbObj pDst = {0};
96✔
1407
    if ((code = mndBuildStbFromAlter(pStb, &pDst, &createReq)) != 0) {
96!
1408
      taosMemoryFreeClear(pDst.pTags);
×
1409
      taosMemoryFreeClear(pDst.pColumns);
×
1410
      taosMemoryFreeClear(pDst.pCmpr);
×
1411
      taosMemoryFreeClear(pDst.pExtSchemas);
×
1412
      goto _OVER;
×
1413
    }
1414

1415
    code = mndAlterStbImp(pMnode, pReq, pDb, &pDst, needRsp, NULL, 0);
96✔
1416
    taosMemoryFreeClear(pDst.pTags);
96!
1417
    taosMemoryFreeClear(pDst.pColumns);
96!
1418
    taosMemoryFreeClear(pDst.pCmpr);
96!
1419
    taosMemoryFreeClear(pDst.pExtSchemas);
96!
1420
  } else {
1421
    code = mndCreateStb(pMnode, pReq, &createReq, pDb);
8,997✔
1422
  }
1423
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
9,093✔
1424

1425
  SName name = {0};
9,093✔
1426
  TAOS_CHECK_RETURN(tNameFromString(&name, createReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
9,093!
1427

1428
  if (createReq.sql == NULL && createReq.sqlLen == 0) {
10,803!
1429
    char detail[1000] = {0};
1,710✔
1430

1431
    (void)tsnprintf(detail, sizeof(detail), "dbname:%s, stable name:%s", name.dbname, name.tname);
1,710✔
1432

1433
    auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, detail, strlen(detail));
1,710✔
1434
  } else {
1435
    auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, createReq.sql, createReq.sqlLen);
7,383✔
1436
  }
1437
_OVER:
9,171✔
1438
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
9,171✔
1439
    mError("stb:%s, failed to create since %s", createReq.name, tstrerror(code));
121!
1440
  }
1441

1442
  mndReleaseStb(pMnode, pStb);
9,171✔
1443
  mndReleaseDb(pMnode, pDb);
9,171✔
1444
  tFreeSMCreateStbReq(&createReq);
9,171✔
1445

1446
  if (pHash != NULL) {
9,171✔
1447
    taosHashCleanup(pHash);
9,094✔
1448
  }
1449

1450
  TAOS_RETURN(code);
9,171✔
1451
}
1452

1453
static int32_t mndCheckAlterStbReq(SMAlterStbReq *pAlter) {
10,661✔
1454
  int32_t code = 0;
10,661✔
1455
  if (pAlter->commentLen >= 0) return 0;
10,661✔
1456
  if (pAlter->ttl != 0) return 0;
20!
1457
  if (pAlter->keep != -1) return 0;
20!
1458

1459
  if (pAlter->numOfFields < 1 || pAlter->numOfFields != (int32_t)taosArrayGetSize(pAlter->pFields)) {
×
1460
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1461
    TAOS_RETURN(code);
×
1462
  }
1463

1464
  for (int32_t i = 0; i < pAlter->numOfFields; ++i) {
×
1465
    SField *pField = taosArrayGet(pAlter->pFields, i);
×
1466
    if (pField->name[0] == 0) {
×
1467
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1468
      TAOS_RETURN(code);
×
1469
    }
1470
  }
1471

1472
  TAOS_RETURN(code);
×
1473
}
1474

1475
int32_t mndAllocStbSchemas(const SStbObj *pOld, SStbObj *pNew) {
11,616✔
1476
  pNew->pTags = taosMemoryCalloc(pNew->numOfTags, sizeof(SSchema));
11,616!
1477
  pNew->pColumns = taosMemoryCalloc(pNew->numOfColumns, sizeof(SSchema));
11,616!
1478
  pNew->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
11,616!
1479
  if (pNew->pTags == NULL || pNew->pColumns == NULL || pNew->pCmpr == NULL) {
11,616!
1480
    TAOS_RETURN(terrno);
×
1481
  }
1482

1483
  memcpy(pNew->pColumns, pOld->pColumns, sizeof(SSchema) * pOld->numOfColumns);
11,616✔
1484
  memcpy(pNew->pTags, pOld->pTags, sizeof(SSchema) * pOld->numOfTags);
11,616✔
1485
  memcpy(pNew->pCmpr, pOld->pCmpr, sizeof(SColCmpr) * pOld->numOfColumns);
11,616✔
1486
  if (pOld->pExtSchemas) {
11,616✔
1487
    pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
7,879!
1488
    if (pNew->pExtSchemas == NULL) {
7,879!
1489
      TAOS_RETURN(terrno);
×
1490
    }
1491
    memcpy(pNew->pExtSchemas, pOld->pExtSchemas, sizeof(SExtSchema) * pOld->numOfColumns);
7,879✔
1492
  }
1493

1494
  TAOS_RETURN(0);
11,616✔
1495
}
1496

1497
static int32_t mndUpdateTableOptions(const SStbObj *pOld, SStbObj *pNew, char *pComment, int32_t commentLen,
56✔
1498
                                     int32_t ttl, int64_t keep) {
1499
  int32_t code = 0;
56✔
1500
  if (commentLen > 0) {
56✔
1501
    pNew->commentLen = commentLen;
25✔
1502
    pNew->comment = taosMemoryCalloc(1, commentLen + 1);
25!
1503
    if (pNew->comment == NULL) {
25!
1504
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
1505
      return -1;
×
1506
    }
1507
    memcpy(pNew->comment, pComment, commentLen + 1);
25✔
1508
  } else if (commentLen == 0) {
31✔
1509
    pNew->commentLen = 0;
11✔
1510
  } else {
1511
  }
1512

1513
  if (ttl >= 0) {
56!
1514
    pNew->ttl = ttl;
56✔
1515
  }
1516

1517
  if (keep > 0) {
56✔
1518
    pNew->keep = keep;
20✔
1519
  }
1520

1521
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
56!
1522
    TAOS_RETURN(code);
×
1523
  }
1524
  TAOS_RETURN(code);
56✔
1525
}
1526

1527
static int32_t mndAddSuperTableTag(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ntags) {
879✔
1528
  int32_t code = 0;
879✔
1529
  if (pOld->numOfTags + ntags > TSDB_MAX_TAGS) {
879!
1530
    code = TSDB_CODE_MND_TOO_MANY_TAGS;
×
1531
    TAOS_RETURN(code);
×
1532
  }
1533

1534
  if (pOld->numOfColumns + ntags + pOld->numOfTags > TSDB_MAX_COLUMNS) {
879!
1535
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
1536
    TAOS_RETURN(code);
×
1537
  }
1538

1539
  if (!mndValidateSchema(pOld->pTags, pOld->numOfTags, pFields, TSDB_MAX_TAGS_LEN)) {
879✔
1540
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
40✔
1541
    TAOS_RETURN(code);
40✔
1542
  }
1543

1544
  pNew->numOfTags = pNew->numOfTags + ntags;
839✔
1545
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
839!
1546
    TAOS_RETURN(code);
×
1547
  }
1548

1549
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ntags) {
839!
1550
    code = TSDB_CODE_OUT_OF_RANGE;
×
1551
    TAOS_RETURN(code);
×
1552
  }
1553

1554
  for (int32_t i = 0; i < ntags; i++) {
1,553✔
1555
    SField *pField = taosArrayGet(pFields, i);
839✔
1556
    if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
839✔
1557
      code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
11✔
1558
      TAOS_RETURN(code);
11✔
1559
    }
1560

1561
    if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
828✔
1562
      code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
114✔
1563
      TAOS_RETURN(code);
114✔
1564
    }
1565

1566
    SSchema *pSchema = &pNew->pTags[pOld->numOfTags + i];
714✔
1567
    pSchema->bytes = pField->bytes;
714✔
1568
    pSchema->type = pField->type;
714✔
1569
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
714✔
1570
    pSchema->colId = pNew->nextColId;
714✔
1571
    pNew->nextColId++;
714✔
1572

1573
    mInfo("stb:%s, start to add tag %s", pNew->name, pSchema->name);
714!
1574
  }
1575

1576
  pNew->tagVer++;
714✔
1577
  TAOS_RETURN(code);
714✔
1578
}
1579

1580
static int32_t mndCheckAlterColForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
4,705✔
1581
  int32_t code = 0;
4,705✔
1582
  SSdb   *pSdb = pMnode->pSdb;
4,705✔
1583
  void   *pIter = NULL;
4,705✔
1584
  while (1) {
917✔
1585
    SMqTopicObj *pTopic = NULL;
5,622✔
1586
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
5,622✔
1587
    if (pIter == NULL) break;
5,622✔
1588

1589
    mInfo("topic:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, subType:%d sql:%s",
995!
1590
          pTopic->name, stbFullName, suid, colId, pTopic->subType, pTopic->sql);
1591
    if (pTopic->ast == NULL) {
995✔
1592
      sdbRelease(pSdb, pTopic);
63✔
1593
      continue;
63✔
1594
    }
1595

1596
    SNode *pAst = NULL;
932✔
1597
    if (nodesStringToNode(pTopic->ast, &pAst) != 0) {
932!
1598
      code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TOPIC;
×
1599
      mError("topic:%s, create ast error", pTopic->name);
×
1600
      sdbRelease(pSdb, pTopic);
×
1601
      sdbCancelFetch(pSdb, pIter);
×
1602
      TAOS_RETURN(code);
78✔
1603
    }
1604

1605
    SNodeList *pNodeList = NULL;
932✔
1606
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
932!
1607
        0) {
1608
      sdbRelease(pSdb, pTopic);
×
1609
      sdbCancelFetch(pSdb, pIter);
×
1610
      TAOS_RETURN(code);
×
1611
    }
1612
    SNode *pNode = NULL;
932✔
1613
    FOREACH(pNode, pNodeList) {
1,573!
1614
      SColumnNode *pCol = (SColumnNode *)pNode;
1,516✔
1615
      mInfo("topic:%s, check colId:%d tableId:%" PRId64 " ctbStbUid:%" PRId64, pTopic->name, pCol->colId, pCol->tableId,
1,516!
1616
            pTopic->ctbStbUid);
1617

1618
      if (pCol->tableId != suid && pTopic->ctbStbUid != suid) {
1,516✔
1619
        mInfo("topic:%s, check colId:%d passed", pTopic->name, pCol->colId);
797!
1620
        goto NEXT;
797✔
1621
      }
1622
      if (pCol->colId > 0 && pCol->colId == colId) {
719!
1623
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TOPIC;
78✔
1624
        mError("topic:%s, check colId:%d conflicted", pTopic->name, pCol->colId);
78!
1625
        nodesDestroyNode(pAst);
78✔
1626
        nodesDestroyList(pNodeList);
78✔
1627
        sdbCancelFetch(pSdb, pIter);
78✔
1628
        sdbRelease(pSdb, pTopic);
78✔
1629
        TAOS_RETURN(code);
78✔
1630
      }
1631
      mInfo("topic:%s, check colId:%d passed", pTopic->name, pCol->colId);
641!
1632
    }
1633

1634
  NEXT:
57✔
1635
    sdbRelease(pSdb, pTopic);
854✔
1636
    nodesDestroyNode(pAst);
854✔
1637
    nodesDestroyList(pNodeList);
854✔
1638
  }
1639
  TAOS_RETURN(code);
4,627✔
1640
}
1641

1642
static int32_t mndCheckAlterColForStream(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
4,627✔
1643
  return 0;
4,627✔
1644
  
1645
  /* STREAMTODO
1646
  int32_t code = 0;
1647
  SSdb   *pSdb = pMnode->pSdb;
1648
  void   *pIter = NULL;
1649
  while (1) {
1650
    SStreamObj *pStream = NULL;
1651
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
1652
    if (pIter == NULL) break;
1653

1654
    SNode *pAst = NULL;
1655
    if (nodesStringToNode(pStream->ast, &pAst) != 0) {
1656
      code = TSDB_CODE_MND_INVALID_STREAM_OPTION;
1657
      mError("stream:%s, create ast error", pStream->name);
1658
      sdbRelease(pSdb, pStream);
1659
      sdbCancelFetch(pSdb, pIter);
1660
      TAOS_RETURN(code);
1661
    }
1662

1663
    SNodeList *pNodeList = NULL;
1664
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
1665
        0) {
1666
      sdbRelease(pSdb, pStream);
1667
      sdbCancelFetch(pSdb, pIter);
1668
      TAOS_RETURN(code);
1669
    }
1670

1671
    SNode *pNode = NULL;
1672
    FOREACH(pNode, pNodeList) {
1673
      SColumnNode *pCol = (SColumnNode *)pNode;
1674

1675
      if (pCol->tableId != suid) {
1676
        mInfo("stream:%s, check colId:%d passed", pStream->name, pCol->colId);
1677
        goto NEXT;
1678
      }
1679
      if (pCol->colId > 0 && pCol->colId == colId) {
1680
        code = TSDB_CODE_MND_STREAM_MUST_BE_DELETED;
1681
        mError("stream:%s, check colId:%d conflicted", pStream->name, pCol->colId);
1682
        nodesDestroyNode(pAst);
1683
        nodesDestroyList(pNodeList);
1684
        sdbRelease(pSdb, pStream);
1685
        sdbCancelFetch(pSdb, pIter);
1686
        TAOS_RETURN(code);
1687
      }
1688
      mInfo("stream:%s, check colId:%d passed", pStream->name, pCol->colId);
1689
    }
1690

1691
  NEXT:
1692
    sdbRelease(pSdb, pStream);
1693
  }
1694
  TAOS_RETURN(code);
1695
*/  
1696
}
1697

1698
static int32_t mndCheckAlterColForTSma(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
4,627✔
1699
  int32_t code = 0;
4,627✔
1700
  SSdb   *pSdb = pMnode->pSdb;
4,627✔
1701
  void   *pIter = NULL;
4,627✔
1702
  while (1) {
×
1703
    SSmaObj *pSma = NULL;
4,627✔
1704
    pIter = sdbFetch(pSdb, SDB_SMA, pIter, (void **)&pSma);
4,627✔
1705
    if (pIter == NULL) break;
4,627!
1706

1707
    mInfo("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, sql:%s", pSma->name, stbFullName,
×
1708
          suid, colId, pSma->sql);
1709

1710
    SNode *pAst = NULL;
×
1711
    if (nodesStringToNode(pSma->ast, &pAst) != 0) {
×
1712
      code = TSDB_CODE_SDB_INVALID_DATA_CONTENT;
×
1713
      mError("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d failed since parse AST err",
×
1714
             pSma->name, stbFullName, suid, colId);
1715
      sdbCancelFetch(pSdb, pIter);
×
1716
      TAOS_RETURN(code);
×
1717
    }
1718

1719
    SNodeList *pNodeList = NULL;
×
1720
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
×
1721
        0) {
1722
      sdbCancelFetch(pSdb, pIter);
×
1723
      TAOS_RETURN(code);
×
1724
    }
1725
    SNode *pNode = NULL;
×
1726
    FOREACH(pNode, pNodeList) {
×
1727
      SColumnNode *pCol = (SColumnNode *)pNode;
×
1728
      mInfo("tsma:%s, check colId:%d tableId:%" PRId64, pSma->name, pCol->colId, pCol->tableId);
×
1729

1730
      if ((pCol->tableId != suid) && (pSma->stbUid != suid)) {
×
1731
        mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
1732
        goto NEXT;
×
1733
      }
1734
      if ((pCol->colId) > 0 && (pCol->colId == colId)) {
×
1735
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
×
1736
        mError("tsma:%s, check colId:%d conflicted", pSma->name, pCol->colId);
×
1737
        nodesDestroyNode(pAst);
×
1738
        nodesDestroyList(pNodeList);
×
1739
        sdbRelease(pSdb, pSma);
×
1740
        sdbCancelFetch(pSdb, pIter);
×
1741
        TAOS_RETURN(code);
×
1742
      }
1743
      mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
1744
    }
1745

1746
  NEXT:
×
1747
    sdbRelease(pSdb, pSma);
×
1748
    nodesDestroyNode(pAst);
×
1749
    nodesDestroyList(pNodeList);
×
1750
  }
1751
  TAOS_RETURN(code);
4,627✔
1752
}
1753

1754
int32_t mndCheckColAndTagModifiable(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId) {
4,705✔
1755
  TAOS_CHECK_RETURN(mndCheckAlterColForTopic(pMnode, stbFullName, suid, colId));
4,705✔
1756
  TAOS_CHECK_RETURN(mndCheckAlterColForStream(pMnode, stbFullName, suid, colId));
4,627!
1757
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, stbFullName, suid, colId));
4,627!
1758
  TAOS_RETURN(0);
4,627✔
1759
}
1760

1761
static int32_t mndDropSuperTableTag(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *tagName) {
516✔
1762
  int32_t code = 0;
516✔
1763
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagName);
516✔
1764
  if (tag < 0) {
516✔
1765
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
7✔
1766
    TAOS_RETURN(code);
7✔
1767
  }
1768

1769
  col_id_t colId = pOld->pTags[tag].colId;
509✔
1770
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
509✔
1771

1772
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
491!
1773

1774
  memmove(pNew->pTags + tag, pNew->pTags + tag + 1, sizeof(SSchema) * (pNew->numOfTags - tag - 1));
491✔
1775
  pNew->numOfTags--;
491✔
1776

1777
  pNew->tagVer++;
491✔
1778

1779
  // if (mndDropIndexByTag(pMnode, pOld, tagName) != 0) {
1780
  //   return -1;
1781
  // }
1782
  mInfo("stb:%s, start to drop tag %s", pNew->name, tagName);
491!
1783
  TAOS_RETURN(code);
491✔
1784
}
1785

1786
static int32_t mndAlterStbTagName(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pFields) {
692✔
1787
  int32_t code = 0;
692✔
1788
  if ((int32_t)taosArrayGetSize(pFields) != 2) {
692!
1789
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1790
    TAOS_RETURN(code);
×
1791
  }
1792

1793
  SField *pField0 = taosArrayGet(pFields, 0);
692✔
1794
  SField *pField1 = taosArrayGet(pFields, 1);
692✔
1795

1796
  const char *oldTagName = pField0->name;
692✔
1797
  const char *newTagName = pField1->name;
692✔
1798

1799
  int32_t tag = mndFindSuperTableTagIndex(pOld, oldTagName);
692✔
1800
  if (tag < 0) {
692✔
1801
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
16✔
1802
    TAOS_RETURN(code);
16✔
1803
  }
1804

1805
  col_id_t colId = pOld->pTags[tag].colId;
676✔
1806
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
676✔
1807

1808
  if (mndFindSuperTableTagIndex(pOld, newTagName) >= 0) {
659✔
1809
    code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
20✔
1810
    TAOS_RETURN(code);
20✔
1811
  }
1812

1813
  if (mndFindSuperTableColumnIndex(pOld, newTagName) >= 0) {
639✔
1814
    code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
1✔
1815
    TAOS_RETURN(code);
1✔
1816
  }
1817

1818
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
638!
1819

1820
  SSchema *pSchema = (SSchema *)(pNew->pTags + tag);
638✔
1821
  memcpy(pSchema->name, newTagName, TSDB_COL_NAME_LEN);
638✔
1822

1823
  pNew->tagVer++;
638✔
1824
  mInfo("stb:%s, start to modify tag %s to %s", pNew->name, oldTagName, newTagName);
638!
1825
  TAOS_RETURN(code);
638✔
1826
}
1827

1828
static int32_t mndAlterStbTagBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
525✔
1829
  int32_t code = 0;
525✔
1830
  int32_t tag = mndFindSuperTableTagIndex(pOld, pField->name);
525✔
1831
  if (tag < 0) {
525✔
1832
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
1✔
1833
    TAOS_RETURN(code);
1✔
1834
  }
1835

1836
  col_id_t colId = pOld->pTags[tag].colId;
524✔
1837
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
524✔
1838

1839
  uint32_t nLen = 0;
515✔
1840
  for (int32_t i = 0; i < pOld->numOfTags; ++i) {
19,536✔
1841
    nLen += (pOld->pTags[i].colId == colId) ? pField->bytes : pOld->pTags[i].bytes;
19,021✔
1842
  }
1843

1844
  if (nLen > TSDB_MAX_TAGS_LEN) {
515✔
1845
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
290✔
1846
    TAOS_RETURN(code);
290✔
1847
  }
1848

1849
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
225!
1850

1851
  SSchema *pTag = pNew->pTags + tag;
225✔
1852

1853
  if (!(pTag->type == TSDB_DATA_TYPE_BINARY || pTag->type == TSDB_DATA_TYPE_VARBINARY ||
225!
1854
        pTag->type == TSDB_DATA_TYPE_NCHAR || pTag->type == TSDB_DATA_TYPE_GEOMETRY)) {
195!
1855
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
1✔
1856
    TAOS_RETURN(code);
1✔
1857
  }
1858

1859
  if (pField->bytes <= pTag->bytes) {
224✔
1860
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
73✔
1861
    TAOS_RETURN(code);
73✔
1862
  }
1863

1864
  pTag->bytes = pField->bytes;
151✔
1865
  pNew->tagVer++;
151✔
1866

1867
  mInfo("stb:%s, start to modify tag len %s to %d", pNew->name, pField->name, pField->bytes);
151!
1868
  TAOS_RETURN(code);
151✔
1869
}
1870

1871
static int32_t mndUpdateSuperTableColumnCompress(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pField,
193✔
1872
                                                 int32_t nCols) {
1873
  // if (pColCmpr == NULL || colName == NULL) return -1;
1874

1875
  if (taosArrayGetSize(pField) != nCols) return TSDB_CODE_FAILED;
193!
1876
  TAOS_FIELD *p = taosArrayGet(pField, 0);
193✔
1877

1878
  int32_t code = 0;
193✔
1879
  int32_t idx = mndFindSuperTableColumnIndex(pOld, p->name);
193✔
1880
  if (idx == -1) {
193!
1881
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
1882
    TAOS_RETURN(code);
×
1883
  }
1884
  SSchema *pTarget = &pOld->pColumns[idx];
193✔
1885
  col_id_t colId = pTarget->colId;
193✔
1886

1887
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
193!
1888
  code = validColCmprByType(pTarget->type, p->bytes);
193✔
1889
  if (code != TSDB_CODE_SUCCESS) {
193✔
1890
    TAOS_RETURN(code);
5✔
1891
  }
1892

1893
  int8_t updated = 0;
188✔
1894
  for (int i = 0; i < pNew->numOfColumns; i++) {
1,549!
1895
    SColCmpr *pCmpr = &pNew->pCmpr[i];
1,549✔
1896
    if (pCmpr->id == colId) {
1,549✔
1897
      uint32_t dst = 0;
188✔
1898
      updated = tUpdateCompress(pCmpr->alg, p->bytes, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
188✔
1899
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
1900
      if (updated > 0) pCmpr->alg = dst;
188✔
1901
      break;
188✔
1902
    }
1903
  }
1904

1905
  if (updated == 0) {
188✔
1906
    code = TSDB_CODE_MND_COLUMN_COMPRESS_ALREADY_EXIST;
21✔
1907
    TAOS_RETURN(code);
21✔
1908
  } else if (updated == -1) {
167!
1909
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
1910
    TAOS_RETURN(code);
×
1911
  }
1912

1913
  pNew->colVer++;
167✔
1914

1915
  TAOS_RETURN(code);
167✔
1916
}
1917
static int32_t mndAddSuperTableColumn(const SStbObj *pOld, SStbObj *pNew, const SMAlterStbReq* pReq, int32_t ncols,
4,678✔
1918
                                      int8_t withCompress) {
1919
  int32_t code = 0;
4,678✔
1920
  if (pOld->numOfColumns + ncols + pOld->numOfTags > TSDB_MAX_COLUMNS) {
4,678!
1921
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
1922
    TAOS_RETURN(code);
×
1923
  }
1924

1925
  if ((code = grantCheck(TSDB_GRANT_TIMESERIES)) != 0) {
4,678!
1926
    TAOS_RETURN(code);
×
1927
  }
1928

1929
  if (!mndValidateSchema(pOld->pColumns, pOld->numOfColumns, pReq->pFields, TSDB_MAX_BYTES_PER_ROW)) {
4,678✔
1930
    code = TSDB_CODE_PAR_INVALID_ROW_LENGTH;
20✔
1931
    TAOS_RETURN(code);
20✔
1932
  }
1933

1934
  pNew->numOfColumns = pNew->numOfColumns + ncols;
4,658✔
1935

1936
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
4,658!
1937

1938
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ncols) {
4,658!
1939
    code = TSDB_CODE_OUT_OF_RANGE;
×
1940
    TAOS_RETURN(code);
×
1941
  }
1942

1943
  for (int32_t i = 0; i < ncols; i++) {
8,794✔
1944
    if (withCompress) {
4,658✔
1945
      SFieldWithOptions *pField = taosArrayGet(pReq->pFields, i);
426✔
1946
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
426!
1947
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
1948
        TAOS_RETURN(code);
×
1949
      }
1950

1951
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
426!
1952
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
×
1953
        TAOS_RETURN(code);
×
1954
      }
1955

1956
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
426✔
1957
      pSchema->bytes = pField->bytes;
426✔
1958
      pSchema->type = pField->type;
426✔
1959
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
426✔
1960
      pSchema->colId = pNew->nextColId;
426✔
1961
      pNew->nextColId++;
426✔
1962

1963
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
426✔
1964
      pCmpr->id = pSchema->colId;
426✔
1965
      pCmpr->alg = pField->compress;
426✔
1966
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
426!
1967
    } else {
1968
      SField *pField = taosArrayGet(pReq->pFields, i);
4,232✔
1969
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
4,232✔
1970
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
509✔
1971
        TAOS_RETURN(code);
509✔
1972
      }
1973

1974
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
3,723✔
1975
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
13✔
1976
        TAOS_RETURN(code);
13✔
1977
      }
1978

1979
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
3,710✔
1980
      pSchema->bytes = pField->bytes;
3,710✔
1981
      pSchema->type = pField->type;
3,710✔
1982
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
3,710✔
1983
      pSchema->colId = pNew->nextColId;
3,710✔
1984
      pNew->nextColId++;
3,710✔
1985

1986
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
3,710✔
1987
      pCmpr->id = pSchema->colId;
3,710✔
1988
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
3,710✔
1989
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
3,710!
1990
    }
1991
  }
1992
  // 1. old schema already has extschemas
1993
  // 2. new schema has extschemas
1994
  if (pReq->pTypeMods || pOld->pExtSchemas) {
4,136!
1995
    if (!pNew->pExtSchemas) {
4,134✔
1996
      // all ext schemas reset to zero
1997
      pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
94!
1998
      if (!pNew->pExtSchemas) TAOS_RETURN(terrno);
94!
1999
    }
2000
    if (pOld->pExtSchemas) {
4,134✔
2001
      memcpy(pNew->pExtSchemas, pOld->pExtSchemas, pOld->numOfColumns * sizeof(SExtSchema));
4,040✔
2002
    }
2003
    if (taosArrayGetSize(pReq->pTypeMods) > 0) {
4,134!
2004
      // copy added column ext schema
2005
      for (int32_t i = 0; i < ncols; ++i) {
8,268✔
2006
        pNew->pColumns[pOld->numOfColumns + i].flags |= COL_HAS_TYPE_MOD;
4,134✔
2007
        pNew->pExtSchemas[pOld->numOfColumns + i].typeMod = *(STypeMod *)taosArrayGet(pReq->pTypeMods, i);
4,134✔
2008
      }
2009
    }
2010
  }
2011

2012
  pNew->colVer++;
4,136✔
2013
  TAOS_RETURN(code);
4,136✔
2014
}
2015

2016
static int32_t mndDropSuperTableColumn(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *colName) {
2,296✔
2017
  int32_t code = 0;
2,296✔
2018
  int32_t col = mndFindSuperTableColumnIndex(pOld, colName);
2,296✔
2019
  if (col < 0) {
2,296✔
2020
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
13✔
2021
    TAOS_RETURN(code);
13✔
2022
  }
2023

2024
  if (col == 0) {
2,283✔
2025
    code = TSDB_CODE_MND_INVALID_STB_ALTER_OPTION;
9✔
2026
    TAOS_RETURN(code);
9✔
2027
  }
2028

2029
  if (pOld->numOfColumns == 2) {
2,274✔
2030
    code = TSDB_CODE_PAR_INVALID_DROP_COL;
1✔
2031
    TAOS_RETURN(code);
1✔
2032
  }
2033

2034
  col_id_t colId = pOld->pColumns[col].colId;
2,273✔
2035
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
2,273✔
2036

2037
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
2,251!
2038

2039
  int32_t sz = pNew->numOfColumns - col - 1;
2,251✔
2040
  memmove(pNew->pColumns + col, pNew->pColumns + col + 1, sizeof(SSchema) * sz);
2,251✔
2041
  memmove(pNew->pCmpr + col, pNew->pCmpr + col + 1, sizeof(SColCmpr) * sz);
2,251✔
2042
  if (pOld->pExtSchemas) {
2,251✔
2043
    memmove(pNew->pExtSchemas + col, pNew->pExtSchemas + col + 1, sizeof(SExtSchema) * sz);
2,076✔
2044
  }
2045
  pNew->numOfColumns--;
2,251✔
2046

2047
  pNew->colVer++;
2,251✔
2048
  mInfo("stb:%s, start to drop col %s", pNew->name, colName);
2,251!
2049
  TAOS_RETURN(code);
2,251✔
2050
}
2051

2052
static int32_t mndAlterStbColumnBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
798✔
2053
  int32_t code = 0;
798✔
2054
  int32_t col = mndFindSuperTableColumnIndex(pOld, pField->name);
798✔
2055
  if (col < 0) {
798✔
2056
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
4✔
2057
    TAOS_RETURN(code);
4✔
2058
  }
2059

2060
  col_id_t colId = pOld->pColumns[col].colId;
794✔
2061

2062
  uint32_t nLen = 0;
794✔
2063
  for (int32_t i = 0; i < pOld->numOfColumns; ++i) {
30,971✔
2064
    nLen += (pOld->pColumns[i].colId == colId) ? pField->bytes : pOld->pColumns[i].bytes;
30,177✔
2065
  }
2066

2067
  if (nLen > TSDB_MAX_BYTES_PER_ROW) {
794✔
2068
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
71✔
2069
    TAOS_RETURN(code);
71✔
2070
  }
2071

2072
  TAOS_CHECK_RETURN(mndCheckColAndTagModifiable(pMnode, pOld->name, pOld->uid, colId));
723✔
2073

2074
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
711!
2075

2076
  SSchema *pCol = pNew->pColumns + col;
711✔
2077
  if (!(pCol->type == TSDB_DATA_TYPE_BINARY || pCol->type == TSDB_DATA_TYPE_VARBINARY ||
711✔
2078
        pCol->type == TSDB_DATA_TYPE_NCHAR || pCol->type == TSDB_DATA_TYPE_GEOMETRY)) {
673!
2079
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
1✔
2080
    TAOS_RETURN(code);
1✔
2081
  }
2082

2083
  if (pField->bytes <= pCol->bytes) {
710✔
2084
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
328✔
2085
    TAOS_RETURN(code);
328✔
2086
  }
2087

2088
  pCol->bytes = pField->bytes;
382✔
2089
  pNew->colVer++;
382✔
2090

2091
  mInfo("stb:%s, start to modify col len %s to %d", pNew->name, pField->name, pField->bytes);
382!
2092
  TAOS_RETURN(code);
382✔
2093
}
2094

2095
static int32_t mndSetAlterStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,082✔
2096
  int32_t  code = 0;
9,082✔
2097
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
9,082✔
2098
  if (pRedoRaw == NULL) {
9,082!
2099
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2100
    if (terrno != 0) code = terrno;
×
2101
    TAOS_RETURN(code);
×
2102
  }
2103
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
9,082!
2104
    sdbFreeRaw(pRedoRaw);
×
2105
    TAOS_RETURN(code);
×
2106
  }
2107
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
9,082!
2108

2109
  TAOS_RETURN(code);
9,082✔
2110
}
2111

2112
static int32_t mndSetAlterStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
9,082✔
2113
  int32_t  code = 0;
9,082✔
2114
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
9,082✔
2115
  if (pCommitRaw == NULL) {
9,082!
2116
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2117
    if (terrno != 0) code = terrno;
×
2118
    TAOS_RETURN(code);
×
2119
  }
2120
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
9,082!
2121
    sdbFreeRaw(pCommitRaw);
×
2122
    TAOS_RETURN(code);
×
2123
  }
2124
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
9,082!
2125

2126
  TAOS_RETURN(code);
9,082✔
2127
}
2128

2129
static int32_t mndSetAlterStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, void *alterOriData,
9,082✔
2130
                                         int32_t alterOriDataLen) {
2131
  int32_t code = 0;
9,082✔
2132
  SSdb   *pSdb = pMnode->pSdb;
9,082✔
2133
  SVgObj *pVgroup = NULL;
9,082✔
2134
  void   *pIter = NULL;
9,082✔
2135
  int32_t contLen;
2136

2137
  while (1) {
23,462✔
2138
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
32,544✔
2139
    if (pIter == NULL) break;
32,544✔
2140
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
23,462✔
2141
      sdbRelease(pSdb, pVgroup);
9,083✔
2142
      continue;
9,083✔
2143
    }
2144

2145
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
14,379✔
2146
    if (pReq == NULL) {
14,379!
2147
      sdbCancelFetch(pSdb, pIter);
×
2148
      sdbRelease(pSdb, pVgroup);
×
2149
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2150
      if (terrno != 0) code = terrno;
×
2151
      TAOS_RETURN(code);
×
2152
    }
2153
    STransAction action = {0};
14,379✔
2154
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
14,379✔
2155
    action.pCont = pReq;
14,379✔
2156
    action.contLen = contLen;
14,379✔
2157
    action.msgType = TDMT_VND_ALTER_STB;
14,379✔
2158
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
14,379!
2159
      taosMemoryFree(pReq);
×
2160
      sdbCancelFetch(pSdb, pIter);
×
2161
      sdbRelease(pSdb, pVgroup);
×
2162
      TAOS_RETURN(code);
×
2163
    }
2164
    sdbRelease(pSdb, pVgroup);
14,379✔
2165
  }
2166

2167
  TAOS_RETURN(code);
9,082✔
2168
}
2169

2170
static int32_t mndSetAlterStbRedoActions2(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
×
2171
                                          void *alterOriData, int32_t alterOriDataLen) {
2172
  int32_t code = 0;
×
2173
  SSdb   *pSdb = pMnode->pSdb;
×
2174
  SVgObj *pVgroup = NULL;
×
2175
  void   *pIter = NULL;
×
2176
  int32_t contLen;
2177

2178
  while (1) {
×
2179
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
2180
    if (pIter == NULL) break;
×
2181
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
×
2182
      sdbRelease(pSdb, pVgroup);
×
2183
      continue;
×
2184
    }
2185

2186
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
×
2187
    if (pReq == NULL) {
×
2188
      sdbCancelFetch(pSdb, pIter);
×
2189
      sdbRelease(pSdb, pVgroup);
×
2190
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2191
      if (terrno != 0) code = terrno;
×
2192
      TAOS_RETURN(code);
×
2193
    }
2194
    STransAction action = {0};
×
2195
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
2196
    action.pCont = pReq;
×
2197
    action.contLen = contLen;
×
2198
    action.msgType = TDMT_VND_CREATE_INDEX;
×
2199
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
2200
      taosMemoryFree(pReq);
×
2201
      sdbCancelFetch(pSdb, pIter);
×
2202
      sdbRelease(pSdb, pVgroup);
×
2203
      TAOS_RETURN(code);
×
2204
    }
2205
    sdbRelease(pSdb, pVgroup);
×
2206
  }
2207

2208
  TAOS_RETURN(code);
×
2209
}
2210

2211
static int32_t mndBuildStbSchemaImp(SMnode *pMnode, SDbObj *pDb, SStbObj *pStb, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
1,978,950✔
2212
  int32_t code = 0;
1,978,950✔
2213
  taosRLockLatch(&pStb->lock);
1,978,950✔
2214

2215
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
1,979,123✔
2216
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
1,979,123!
2217
  if (pRsp->pSchemas == NULL) {
1,978,927!
2218
    taosRUnLockLatch(&pStb->lock);
×
2219
    code = terrno;
×
2220
    TAOS_RETURN(code);
×
2221
  }
2222
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
1,978,927!
2223
  if (pRsp->pSchemaExt == NULL) {
1,978,933!
2224
    taosRUnLockLatch(&pStb->lock);
×
2225
    code = terrno;
×
2226
    TAOS_RETURN(code);
×
2227
  }
2228
  pRsp->numOfColRefs = 0;
1,978,933✔
2229
  pRsp->pColRefs = NULL;
1,978,933✔
2230
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
1,978,933✔
2231
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
1,978,933✔
2232
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
1,978,933✔
2233
  pRsp->dbId = pDb->uid;
1,978,933✔
2234
  pRsp->numOfTags = pStb->numOfTags;
1,978,933✔
2235
  pRsp->numOfColumns = pStb->numOfColumns;
1,978,933✔
2236
  pRsp->precision = pDb->cfg.precision;
1,978,933✔
2237
  pRsp->tableType = TSDB_SUPER_TABLE;
1,978,933✔
2238
  pRsp->sversion = pStb->colVer;
1,978,933✔
2239
  pRsp->tversion = pStb->tagVer;
1,978,933✔
2240
  pRsp->suid = pStb->uid;
1,978,933✔
2241
  pRsp->tuid = pStb->uid;
1,978,933✔
2242
  pRsp->virtualStb = pStb->virtualStb;
1,978,933✔
2243

2244
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
52,018,529✔
2245
    SSchema *pSchema = &pRsp->pSchemas[i];
50,039,596✔
2246
    SSchema *pSrcSchema = &pStb->pColumns[i];
50,039,596✔
2247
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
50,039,596✔
2248
    pSchema->type = pSrcSchema->type;
50,039,596✔
2249
    pSchema->flags = pSrcSchema->flags;
50,039,596✔
2250
    pSchema->colId = pSrcSchema->colId;
50,039,596✔
2251
    pSchema->bytes = pSrcSchema->bytes;
50,039,596✔
2252
  }
2253
  
2254
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
30,816,683✔
2255
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
28,837,750✔
2256
    SSchema *pSrcSchema = &pStb->pTags[i];
28,837,750✔
2257
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
28,837,750✔
2258
    pSchema->type = pSrcSchema->type;
28,837,750✔
2259
    pSchema->flags = pSrcSchema->flags;
28,837,750✔
2260
    pSchema->colId = pSrcSchema->colId;
28,837,750✔
2261
    pSchema->bytes = pSrcSchema->bytes;
28,837,750✔
2262
  }
2263

2264
  if (refByStm) {
1,978,933✔
2265
    mndStreamUpdateTagsRefFlag(pMnode, pStb->uid, &pRsp->pSchemas[pStb->numOfColumns], pStb->numOfTags);
1,960,410✔
2266
  }
2267

2268
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
52,031,150✔
2269
    SColCmpr   *pCmpr = &pStb->pCmpr[i];
50,052,025✔
2270
    SSchemaExt *pSchEx = &pRsp->pSchemaExt[i];
50,052,025✔
2271
    pSchEx->colId = pCmpr->id;
50,052,025✔
2272
    pSchEx->compress = pCmpr->alg;
50,052,025✔
2273
    if (pStb->pExtSchemas) {
50,052,025✔
2274
      pSchEx->typeMod = pStb->pExtSchemas[i].typeMod;
1,368,904✔
2275
    }
2276
  }
2277

2278
  taosRUnLockLatch(&pStb->lock);
1,979,125✔
2279
  TAOS_RETURN(code);
1,979,115✔
2280
}
2281

2282
static int32_t mndBuildStbCfgImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableCfgRsp *pRsp) {
135✔
2283
  int32_t code = 0;
135✔
2284
  taosRLockLatch(&pStb->lock);
135✔
2285

2286
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
135✔
2287
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
135!
2288
  if (pRsp->pSchemas == NULL) {
135!
2289
    taosRUnLockLatch(&pStb->lock);
×
2290
    code = terrno;
×
2291
    TAOS_RETURN(code);
×
2292
  }
2293

2294
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
135✔
2295
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
135✔
2296
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
135✔
2297
  pRsp->numOfTags = pStb->numOfTags;
135✔
2298
  pRsp->numOfColumns = pStb->numOfColumns;
135✔
2299
  pRsp->tableType = TSDB_SUPER_TABLE;
135✔
2300
  pRsp->delay1 = pStb->maxdelay[0];
135✔
2301
  pRsp->delay2 = pStb->maxdelay[1];
135✔
2302
  pRsp->watermark1 = pStb->watermark[0];
135✔
2303
  pRsp->watermark2 = pStb->watermark[1];
135✔
2304
  pRsp->ttl = pStb->ttl;
135✔
2305
  pRsp->keep = pStb->keep;
135✔
2306
  pRsp->commentLen = pStb->commentLen;
135✔
2307
  if (pStb->commentLen > 0) {
135!
2308
    pRsp->pComment = taosStrdup(pStb->comment);
×
2309
  }
2310

2311
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
995✔
2312
    SSchema *pSchema = &pRsp->pSchemas[i];
860✔
2313
    SSchema *pSrcSchema = &pStb->pColumns[i];
860✔
2314
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
860✔
2315
    pSchema->type = pSrcSchema->type;
860✔
2316
    pSchema->flags = pSrcSchema->flags;
860✔
2317
    pSchema->colId = pSrcSchema->colId;
860✔
2318
    pSchema->bytes = pSrcSchema->bytes;
860✔
2319
  }
2320

2321
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
588✔
2322
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
453✔
2323
    SSchema *pSrcSchema = &pStb->pTags[i];
453✔
2324
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
453✔
2325
    pSchema->type = pSrcSchema->type;
453✔
2326
    pSchema->flags = pSrcSchema->flags;
453✔
2327
    pSchema->colId = pSrcSchema->colId;
453✔
2328
    pSchema->bytes = pSrcSchema->bytes;
453✔
2329
  }
2330

2331
  if (pStb->numOfFuncs > 0) {
135!
2332
    pRsp->pFuncs = taosArrayDup(pStb->pFuncs, NULL);
×
2333
  }
2334

2335
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
135!
2336
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
995✔
2337
    SColCmpr *pCmpr = &pStb->pCmpr[i];
860✔
2338

2339
    SSchemaExt *pSchExt = &pRsp->pSchemaExt[i];
860✔
2340
    pSchExt->colId = pCmpr->id;
860✔
2341
    pSchExt->compress = pCmpr->alg;
860✔
2342
    if (pStb->pExtSchemas) {
860!
2343
      pSchExt->typeMod = pStb->pExtSchemas[i].typeMod;
×
2344
    }
2345
  }
2346
  pRsp->virtualStb = pStb->virtualStb;
135✔
2347
  pRsp->pColRefs = NULL;
135✔
2348

2349
  taosRUnLockLatch(&pStb->lock);
135✔
2350
  TAOS_RETURN(code);
135✔
2351
}
2352

2353
static int32_t mndValidateStbVersion(SMnode *pMnode, SSTableVersion *pStbVer, bool *schema, bool *sma) {
41,364✔
2354
  int32_t code = 0;
41,364✔
2355
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
41,364✔
2356
  snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVer->dbFName, pStbVer->stbName);
41,364✔
2357

2358
  SDbObj *pDb = mndAcquireDb(pMnode, pStbVer->dbFName);
41,364✔
2359
  if (pDb == NULL) {
41,363✔
2360
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
36✔
2361
    TAOS_RETURN(code);
36✔
2362
  }
2363

2364
  if (pDb->uid != pStbVer->dbId) {
41,327✔
2365
    mndReleaseDb(pMnode, pDb);
15✔
2366
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
15✔
2367
    TAOS_RETURN(code);
15✔
2368
  }
2369

2370
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
41,312✔
2371
  if (pStb == NULL) {
41,313✔
2372
    mndReleaseDb(pMnode, pDb);
48✔
2373
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
48✔
2374
    TAOS_RETURN(code);
48✔
2375
  }
2376

2377
  taosRLockLatch(&pStb->lock);
41,265✔
2378

2379
  if (pStbVer->sversion != pStb->colVer || pStbVer->tversion != pStb->tagVer) {
41,265✔
2380
    *schema = true;
321✔
2381
  } else {
2382
    *schema = false;
40,944✔
2383
  }
2384

2385
  if (pStbVer->smaVer && pStbVer->smaVer != pStb->smaVer) {
41,265!
2386
    *sma = true;
×
2387
  } else {
2388
    *sma = false;
41,265✔
2389
  }
2390

2391
  taosRUnLockLatch(&pStb->lock);
41,265✔
2392

2393
  mndReleaseDb(pMnode, pDb);
41,265✔
2394
  mndReleaseStb(pMnode, pStb);
41,265✔
2395
  return TSDB_CODE_SUCCESS;
41,265✔
2396
}
2397

2398
static int32_t mndBuildStbSchema(SMnode *pMnode, const char *dbFName, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
1,964,309✔
2399
  int32_t code = 0;
1,964,309✔
2400
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
1,964,309✔
2401
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
1,964,309✔
2402

2403
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
1,964,309✔
2404
  if (pDb == NULL) {
1,964,182!
2405
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
2406
    TAOS_RETURN(code);
×
2407
  }
2408

2409
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
1,964,182✔
2410
  if (pStb == NULL) {
1,964,162✔
2411
    mndReleaseDb(pMnode, pDb);
3,517✔
2412
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
3,517✔
2413
    TAOS_RETURN(code);
3,517✔
2414
  }
2415

2416
  code = mndBuildStbSchemaImp(pMnode, pDb, pStb, tbName, pRsp, refByStm);
1,960,645✔
2417
  mndReleaseDb(pMnode, pDb);
1,960,713✔
2418
  mndReleaseStb(pMnode, pStb);
1,960,789✔
2419
  TAOS_RETURN(code);
1,960,799✔
2420
}
2421

2422
static int32_t mndBuildStbCfg(SMnode *pMnode, const char *dbFName, const char *tbName, STableCfgRsp *pRsp) {
135✔
2423
  int32_t code = 0;
135✔
2424
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
135✔
2425
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
135✔
2426

2427
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
135✔
2428
  if (pDb == NULL) {
135!
2429
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
2430
    TAOS_RETURN(code);
×
2431
  }
2432

2433
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
135✔
2434
  if (pStb == NULL) {
135!
2435
    mndReleaseDb(pMnode, pDb);
×
2436
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
2437
    TAOS_RETURN(code);
×
2438
  }
2439

2440
  code = mndBuildStbCfgImp(pDb, pStb, tbName, pRsp);
135✔
2441

2442
  mndReleaseDb(pMnode, pDb);
135✔
2443
  mndReleaseStb(pMnode, pStb);
135✔
2444
  TAOS_RETURN(code);
135✔
2445
}
2446

2447
static int32_t mndBuildSMAlterStbRsp(SDbObj *pDb, SStbObj *pObj, void **pCont, int32_t *pLen) {
8,930✔
2448
  int32_t       code = 0;
8,930✔
2449
  SEncoder      ec = {0};
8,930✔
2450
  uint32_t      contLen = 0;
8,930✔
2451
  SMAlterStbRsp alterRsp = {0};
8,930✔
2452
  SName         name = {0};
8,930✔
2453
  TAOS_CHECK_RETURN(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
8,930!
2454

2455
  alterRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
8,930!
2456
  if (NULL == alterRsp.pMeta) {
8,930!
2457
    code = terrno;
×
2458
    TAOS_RETURN(code);
×
2459
  }
2460

2461
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, alterRsp.pMeta, false);
8,930✔
2462
  if (code) {
8,930!
2463
    tFreeSMAlterStbRsp(&alterRsp);
×
2464
    return code;
×
2465
  }
2466

2467
  tEncodeSize(tEncodeSMAlterStbRsp, &alterRsp, contLen, code);
8,930!
2468
  if (code) {
8,930!
2469
    tFreeSMAlterStbRsp(&alterRsp);
×
2470
    return code;
×
2471
  }
2472

2473
  void *cont = taosMemoryMalloc(contLen);
8,930!
2474
  if (NULL == cont) {
8,930!
2475
    code = terrno;
×
2476
    tFreeSMAlterStbRsp(&alterRsp);
×
2477
    TAOS_RETURN(code);
×
2478
  }
2479
  tEncoderInit(&ec, cont, contLen);
8,930✔
2480
  code = tEncodeSMAlterStbRsp(&ec, &alterRsp);
8,930✔
2481
  tEncoderClear(&ec);
8,930✔
2482

2483
  tFreeSMAlterStbRsp(&alterRsp);
8,930✔
2484

2485
  if (code < 0) TAOS_RETURN(code);
8,930!
2486

2487
  *pCont = cont;
8,930✔
2488
  *pLen = contLen;
8,930✔
2489

2490
  TAOS_RETURN(code);
8,930✔
2491
}
2492

2493
int32_t mndBuildSMCreateStbRsp(SMnode *pMnode, char *dbFName, char *stbFName, void **pCont, int32_t *pLen) {
9,457✔
2494
  int32_t code = -1;
9,457✔
2495
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
9,457✔
2496
  if (NULL == pDb) {
9,457!
2497
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2498
    if (terrno != 0) code = terrno;
×
2499
    TAOS_RETURN(code);
×
2500
  }
2501

2502
  SStbObj *pObj = mndAcquireStb(pMnode, stbFName);
9,457✔
2503
  if (NULL == pObj) {
9,457✔
2504
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
4✔
2505
    if (terrno != 0) code = terrno;
4!
2506
    goto _OVER;
4✔
2507
  }
2508

2509
  SEncoder       ec = {0};
9,453✔
2510
  uint32_t       contLen = 0;
9,453✔
2511
  SMCreateStbRsp stbRsp = {0};
9,453✔
2512
  SName          name = {0};
9,453✔
2513
  TAOS_CHECK_GOTO(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE), NULL, _OVER);
9,453!
2514

2515
  stbRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
9,453!
2516
  if (NULL == stbRsp.pMeta) {
9,453!
2517
    code = terrno;
×
2518
    goto _OVER;
×
2519
  }
2520

2521
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, stbRsp.pMeta, false);
9,453✔
2522
  if (code) {
9,453!
2523
    tFreeSMCreateStbRsp(&stbRsp);
×
2524
    goto _OVER;
×
2525
  }
2526

2527
  tEncodeSize(tEncodeSMCreateStbRsp, &stbRsp, contLen, code);
9,453!
2528
  if (code) {
9,453!
2529
    tFreeSMCreateStbRsp(&stbRsp);
×
2530
    goto _OVER;
×
2531
  }
2532

2533
  void *cont = taosMemoryMalloc(contLen);
9,453!
2534
  if (NULL == cont) {
9,453!
2535
    code = terrno;
×
2536
    tFreeSMCreateStbRsp(&stbRsp);
×
2537
    goto _OVER;
×
2538
  }
2539
  tEncoderInit(&ec, cont, contLen);
9,453✔
2540
  TAOS_CHECK_GOTO(tEncodeSMCreateStbRsp(&ec, &stbRsp), NULL, _OVER);
9,453!
2541
  tEncoderClear(&ec);
9,453✔
2542

2543
  tFreeSMCreateStbRsp(&stbRsp);
9,453✔
2544

2545
  *pCont = cont;
9,453✔
2546
  *pLen = contLen;
9,453✔
2547

2548
  code = 0;
9,453✔
2549

2550
_OVER:
9,457✔
2551
  if (pObj) {
9,457✔
2552
    mndReleaseStb(pMnode, pObj);
9,453✔
2553
  }
2554

2555
  if (pDb) {
9,457!
2556
    mndReleaseDb(pMnode, pDb);
9,457✔
2557
  }
2558

2559
  TAOS_RETURN(code);
9,457✔
2560
}
2561

2562
static int32_t mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
7,953✔
2563
                              void *alterOriData, int32_t alterOriDataLen) {
2564
  int32_t code = -1;
7,953✔
2565
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
7,953✔
2566
  if (pTrans == NULL) {
7,953!
2567
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2568
    if (terrno != 0) code = terrno;
×
2569
    goto _OVER;
×
2570
  }
2571

2572
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
7,953!
2573
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
7,953✔
2574
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
7,953!
2575

2576
  if (needRsp) {
7,953✔
2577
    void   *pCont = NULL;
7,801✔
2578
    int32_t contLen = 0;
7,801✔
2579
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
7,801!
2580
    mndTransSetRpcRsp(pTrans, pCont, contLen);
7,801✔
2581
  }
2582

2583
  TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
7,953!
2584
  TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
7,953!
2585
  TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
7,953!
2586
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
7,953!
2587

2588
  code = 0;
7,953✔
2589

2590
_OVER:
7,953✔
2591
  mndTransDrop(pTrans);
7,953✔
2592
  TAOS_RETURN(code);
7,953✔
2593
}
2594

2595
static int32_t mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
1,129✔
2596
                                             void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter) {
2597
  int32_t code = -1;
1,129✔
2598
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
1,129✔
2599
  if (pTrans == NULL) {
1,129!
2600
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2601
    if (terrno != 0) code = terrno;
×
2602
    goto _OVER;
×
2603
  }
2604

2605
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
1,129!
2606
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,129✔
2607

2608
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
1,129!
2609

2610
  if (needRsp) {
1,129!
2611
    void   *pCont = NULL;
1,129✔
2612
    int32_t contLen = 0;
1,129✔
2613
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
1,129!
2614
    mndTransSetRpcRsp(pTrans, pCont, contLen);
1,129✔
2615
  }
2616

2617
  if (pAlter->alterType == TSDB_ALTER_TABLE_DROP_TAG) {
1,129✔
2618
    SIdxObj idxObj = {0};
491✔
2619
    SField *pField0 = taosArrayGet(pAlter->pFields, 0);
491✔
2620
    bool    exist = false;
491✔
2621
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
491✔
2622
      exist = true;
20✔
2623
    }
2624
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
491!
2625
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
491!
2626

2627
    if (exist == true) {
491✔
2628
      TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
20!
2629
      TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
20!
2630
    }
2631

2632
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
491!
2633
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
491!
2634

2635
  } else if (pAlter->alterType == TSDB_ALTER_TABLE_UPDATE_TAG_NAME) {
638!
2636
    SIdxObj     idxObj = {0};
638✔
2637
    SField     *pField0 = taosArrayGet(pAlter->pFields, 0);
638✔
2638
    SField     *pField1 = taosArrayGet(pAlter->pFields, 1);
638✔
2639
    const char *oTagName = pField0->name;
638✔
2640
    const char *nTagName = pField1->name;
638✔
2641
    bool        exist = false;
638✔
2642

2643
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
638✔
2644
      exist = true;
53✔
2645
    }
2646

2647
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
638!
2648
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
638!
2649

2650
    if (exist == true) {
638✔
2651
      memcpy(idxObj.colName, nTagName, strlen(nTagName));
53✔
2652
      idxObj.colName[strlen(nTagName)] = 0;
53✔
2653
      TAOS_CHECK_GOTO(mndSetAlterIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
53!
2654
      TAOS_CHECK_GOTO(mndSetAlterIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
53!
2655
    }
2656

2657
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
638!
2658
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
638!
2659
  }
2660
  code = 0;
1,129✔
2661

2662
_OVER:
1,129✔
2663
  mndTransDrop(pTrans);
1,129✔
2664
  TAOS_RETURN(code);
1,129✔
2665
}
2666

2667
static int32_t mndAlterStb(SMnode *pMnode, SRpcMsg *pReq, const SMAlterStbReq *pAlter, SDbObj *pDb, SStbObj *pOld) {
10,633✔
2668
  bool    needRsp = true;
10,633✔
2669
  int32_t code = -1;
10,633✔
2670
  SField *pField0 = NULL;
10,633✔
2671

2672
  SStbObj stbObj = {0};
10,633✔
2673
  taosRLockLatch(&pOld->lock);
10,633✔
2674
  memcpy(&stbObj, pOld, sizeof(SStbObj));
10,633✔
2675
  taosRUnLockLatch(&pOld->lock);
10,633✔
2676
  stbObj.pColumns = NULL;
10,633✔
2677
  stbObj.pTags = NULL;
10,633✔
2678
  stbObj.pFuncs = NULL;
10,633✔
2679
  stbObj.pCmpr = NULL;
10,633✔
2680
  stbObj.pExtSchemas = NULL;
10,633✔
2681
  stbObj.updateTime = taosGetTimestampMs();
10,633✔
2682
  stbObj.lock = 0;
10,633✔
2683
  stbObj.virtualStb = pOld->virtualStb;
10,633✔
2684
  bool updateTagIndex = false;
10,633✔
2685
  switch (pAlter->alterType) {
10,633!
2686
    case TSDB_ALTER_TABLE_ADD_TAG:
879✔
2687
      code = mndAddSuperTableTag(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
879✔
2688
      break;
879✔
2689
    case TSDB_ALTER_TABLE_DROP_TAG:
516✔
2690
      pField0 = taosArrayGet(pAlter->pFields, 0);
516✔
2691
      code = mndDropSuperTableTag(pMnode, pOld, &stbObj, pField0->name);
516✔
2692
      updateTagIndex = true;
516✔
2693
      break;
516✔
2694
    case TSDB_ALTER_TABLE_UPDATE_TAG_NAME:
692✔
2695
      code = mndAlterStbTagName(pMnode, pOld, &stbObj, pAlter->pFields);
692✔
2696
      updateTagIndex = true;
692✔
2697
      break;
692✔
2698
    case TSDB_ALTER_TABLE_UPDATE_TAG_BYTES:
525✔
2699
      pField0 = taosArrayGet(pAlter->pFields, 0);
525✔
2700
      code = mndAlterStbTagBytes(pMnode, pOld, &stbObj, pField0);
525✔
2701
      break;
525✔
2702
    case TSDB_ALTER_TABLE_ADD_COLUMN:
4,252✔
2703
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 0);
4,252✔
2704
      break;
4,252✔
2705
    case TSDB_ALTER_TABLE_DROP_COLUMN:
2,296✔
2706
      pField0 = taosArrayGet(pAlter->pFields, 0);
2,296✔
2707
      code = mndDropSuperTableColumn(pMnode, pOld, &stbObj, pField0->name);
2,296✔
2708
      break;
2,296✔
2709
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
798✔
2710
      pField0 = taosArrayGet(pAlter->pFields, 0);
798✔
2711
      code = mndAlterStbColumnBytes(pMnode, pOld, &stbObj, pField0);
798✔
2712
      break;
798✔
2713
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
56✔
2714
      needRsp = false;
56✔
2715
      code = mndUpdateTableOptions(pOld, &stbObj, pAlter->comment, pAlter->commentLen, pAlter->ttl, pAlter->keep);
56✔
2716
      break;
56✔
2717
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_COMPRESS:
193✔
2718
      code = mndUpdateSuperTableColumnCompress(pMnode, pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
193✔
2719
      break;
193✔
2720
    case TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COMPRESS_OPTION:
426✔
2721
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 1);
426✔
2722
      break;
426✔
2723
    default:
×
2724
      needRsp = false;
×
2725
      terrno = TSDB_CODE_OPS_NOT_SUPPORT;
×
2726
      break;
×
2727
  }
2728

2729
  if (code != 0) goto _OVER;
10,633✔
2730
  if (updateTagIndex == false) {
8,986✔
2731
    code = mndAlterStbImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen);
7,857✔
2732
  } else {
2733
    code = mndAlterStbAndUpdateTagIdxImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen, pAlter);
1,129✔
2734
  }
2735

2736
_OVER:
10,633✔
2737
  taosMemoryFreeClear(stbObj.pTags);
10,633!
2738
  taosMemoryFreeClear(stbObj.pColumns);
10,633!
2739
  taosMemoryFreeClear(stbObj.pCmpr);
10,633!
2740
  if (pAlter->commentLen > 0) {
10,633✔
2741
    taosMemoryFreeClear(stbObj.comment);
25!
2742
  }
2743
  taosMemoryFreeClear(stbObj.pExtSchemas);
10,633!
2744
  TAOS_RETURN(code);
10,633✔
2745
}
2746

2747
static int32_t mndProcessAlterStbReq(SRpcMsg *pReq) {
10,661✔
2748
  SMnode       *pMnode = pReq->info.node;
10,661✔
2749
  int32_t       code = -1;
10,661✔
2750
  SDbObj       *pDb = NULL;
10,661✔
2751
  SStbObj      *pStb = NULL;
10,661✔
2752
  SMAlterStbReq alterReq = {0};
10,661✔
2753

2754
  if (tDeserializeSMAlterStbReq(pReq->pCont, pReq->contLen, &alterReq) != 0) {
10,661!
2755
    code = TSDB_CODE_INVALID_MSG;
×
2756
    goto _OVER;
×
2757
  }
2758

2759
  mInfo("stb:%s, start to alter", alterReq.name);
10,661!
2760
  if (mndCheckAlterStbReq(&alterReq) != 0) goto _OVER;
10,661!
2761

2762
  pDb = mndAcquireDbByStb(pMnode, alterReq.name);
10,661✔
2763
  if (pDb == NULL) {
10,661✔
2764
    code = TSDB_CODE_MND_DB_NOT_EXIST;
2✔
2765
    goto _OVER;
2✔
2766
  }
2767
  if (pDb->cfg.isMount) {
10,659✔
2768
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
2✔
2769
    goto _OVER;
2✔
2770
  }
2771

2772
  pStb = mndAcquireStb(pMnode, alterReq.name);
10,657✔
2773
  if (pStb == NULL) {
10,657✔
2774
    code = TSDB_CODE_MND_STB_NOT_EXIST;
24✔
2775
    goto _OVER;
24✔
2776
  }
2777

2778
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
10,633!
2779
    goto _OVER;
×
2780
  }
2781

2782
  code = mndAlterStb(pMnode, pReq, &alterReq, pDb, pStb);
10,633✔
2783
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
10,633✔
2784

2785
  SName   name = {0};
10,633✔
2786
  int32_t ret = 0;
10,633✔
2787
  if ((ret = tNameFromString(&name, alterReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
10,633!
2788
    mError("stb:%s, failed to tNameFromString since %s", alterReq.name, tstrerror(ret));
×
2789

2790
  auditRecord(pReq, pMnode->clusterId, "alterStb", name.dbname, name.tname, alterReq.sql, alterReq.sqlLen);
10,633✔
2791

2792
_OVER:
10,661✔
2793
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
10,661!
2794
    mError("stb:%s, failed to alter since %s", alterReq.name, tstrerror(code));
1,675!
2795
  }
2796

2797
  mndReleaseStb(pMnode, pStb);
10,661✔
2798
  mndReleaseDb(pMnode, pDb);
10,661✔
2799
  tFreeSMAltertbReq(&alterReq);
10,661✔
2800

2801
  TAOS_RETURN(code);
10,661✔
2802
}
2803

2804
static int32_t mndSetDropStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
1,676✔
2805
  int32_t  code = 0;
1,676✔
2806
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
1,676✔
2807
  if (pRedoRaw == NULL) {
1,676!
2808
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2809
    if (terrno != 0) code = terrno;
×
2810
    TAOS_RETURN(code);
×
2811
  }
2812
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
1,676!
2813
    sdbFreeRaw(pRedoRaw);
×
2814
    TAOS_RETURN(code);
×
2815
  }
2816
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
1,676!
2817

2818
  TAOS_RETURN(code);
1,676✔
2819
}
2820

2821
static int32_t mndSetDropStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
1,676✔
2822
  int32_t  code = 0;
1,676✔
2823
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
1,676✔
2824
  if (pCommitRaw == NULL) {
1,676!
2825
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2826
    if (terrno != 0) code = terrno;
×
2827
    TAOS_RETURN(code);
×
2828
  }
2829
  if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
1,676!
2830
    sdbFreeRaw(pCommitRaw);
×
2831
    TAOS_RETURN(code);
×
2832
  }
2833
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
1,676!
2834

2835
  TAOS_RETURN(code);
1,676✔
2836
}
2837

2838
static int32_t mndSetDropStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
1,676✔
2839
  int32_t code = 0;
1,676✔
2840
  SSdb   *pSdb = pMnode->pSdb;
1,676✔
2841
  SVgObj *pVgroup = NULL;
1,676✔
2842
  void   *pIter = NULL;
1,676✔
2843

2844
  while (1) {
5,177✔
2845
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
6,853✔
2846
    if (pIter == NULL) break;
6,853✔
2847
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
5,177✔
2848
      sdbRelease(pSdb, pVgroup);
1,832✔
2849
      continue;
1,832✔
2850
    }
2851

2852
    int32_t contLen = 0;
3,345✔
2853
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
3,345✔
2854
    if (pReq == NULL) {
3,345!
2855
      sdbCancelFetch(pSdb, pIter);
×
2856
      sdbRelease(pSdb, pVgroup);
×
2857
      code = TSDB_CODE_OUT_OF_MEMORY;
×
2858
      TAOS_RETURN(code);
×
2859
    }
2860

2861
    STransAction action = {0};
3,345✔
2862
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
3,345✔
2863
    action.pCont = pReq;
3,345✔
2864
    action.contLen = contLen;
3,345✔
2865
    action.msgType = TDMT_VND_DROP_STB;
3,345✔
2866
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
3,345✔
2867
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
3,345!
2868
      taosMemoryFree(pReq);
×
2869
      sdbCancelFetch(pSdb, pIter);
×
2870
      sdbRelease(pSdb, pVgroup);
×
2871
      TAOS_RETURN(code);
×
2872
    }
2873
    sdbRelease(pSdb, pVgroup);
3,345✔
2874
  }
2875

2876
  TAOS_RETURN(code);
1,676✔
2877
}
2878

2879
static int32_t mndDropStb(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb) {
1,676✔
2880
  int32_t code = -1;
1,676✔
2881
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "drop-stb");
1,676✔
2882
  if (pTrans == NULL) {
1,676!
2883
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2884
    if (terrno != 0) code = terrno;
×
2885
    goto _OVER;
×
2886
  }
2887

2888
  mInfo("trans:%d, used to drop stb:%s", pTrans->id, pStb->name);
1,676!
2889
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
1,676✔
2890
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
1,676!
2891

2892
  TAOS_CHECK_GOTO(mndSetDropStbPrepareLogs(pMnode, pTrans, pStb), NULL, _OVER);
1,676!
2893
  TAOS_CHECK_GOTO(mndSetDropStbCommitLogs(pMnode, pTrans, pStb), NULL, _OVER);
1,676!
2894
  TAOS_CHECK_GOTO(mndSetDropStbRedoActions(pMnode, pTrans, pDb, pStb), NULL, _OVER);
1,676!
2895
  TAOS_CHECK_GOTO(mndDropIdxsByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
1,676!
2896
  TAOS_CHECK_GOTO(mndUserRemoveStb(pMnode, pTrans, pStb->name), NULL, _OVER);
1,676!
2897
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
1,676!
2898
  code = 0;
1,676✔
2899

2900
_OVER:
1,676✔
2901
  mndTransDrop(pTrans);
1,676✔
2902
  TAOS_RETURN(code);
1,676✔
2903
}
2904

2905
static int32_t mndCheckDropStbForTopic(SMnode *pMnode, const char *stbFullName, int64_t suid) {
1,678✔
2906
  int32_t code = 0;
1,678✔
2907
  SSdb   *pSdb = pMnode->pSdb;
1,678✔
2908
  void   *pIter = NULL;
1,678✔
2909
  while (1) {
3✔
2910
    SMqTopicObj *pTopic = NULL;
1,681✔
2911
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
1,681✔
2912
    if (pIter == NULL) break;
1,681✔
2913

2914
    if (pTopic->subType == TOPIC_SUB_TYPE__TABLE) {
3!
2915
      if (pTopic->stbUid == suid) {
×
2916
        sdbRelease(pSdb, pTopic);
×
2917
        sdbCancelFetch(pSdb, pIter);
×
2918
        TAOS_RETURN(-1);
×
2919
      }
2920
    }
2921

2922
    if (pTopic->ast == NULL) {
3!
2923
      sdbRelease(pSdb, pTopic);
3✔
2924
      continue;
3✔
2925
    }
2926

2927
    SNode *pAst = NULL;
×
2928
    if (nodesStringToNode(pTopic->ast, &pAst) != 0) {
×
2929
      code = TSDB_CODE_MND_INVALID_TOPIC_OPTION;
×
2930
      mError("topic:%s, create ast error", pTopic->name);
×
2931
      sdbRelease(pSdb, pTopic);
×
2932
      sdbCancelFetch(pSdb, pIter);
×
2933
      TAOS_RETURN(code);
×
2934
    }
2935

2936
    SNodeList *pNodeList = NULL;
×
2937
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
×
2938
        0) {
2939
      sdbRelease(pSdb, pTopic);
×
2940
      sdbCancelFetch(pSdb, pIter);
×
2941
      TAOS_RETURN(code);
×
2942
    }
2943
    SNode *pNode = NULL;
×
2944
    FOREACH(pNode, pNodeList) {
×
2945
      SColumnNode *pCol = (SColumnNode *)pNode;
×
2946

2947
      if (pCol->tableId == suid) {
×
2948
        sdbRelease(pSdb, pTopic);
×
2949
        nodesDestroyNode(pAst);
×
2950
        nodesDestroyList(pNodeList);
×
2951
        sdbCancelFetch(pSdb, pIter);
×
2952
        TAOS_RETURN(-1);
×
2953
      } else {
2954
        goto NEXT;
×
2955
      }
2956
    }
2957
  NEXT:
×
2958
    sdbRelease(pSdb, pTopic);
×
2959
    nodesDestroyNode(pAst);
×
2960
    nodesDestroyList(pNodeList);
×
2961
  }
2962
  TAOS_RETURN(code);
1,678✔
2963
}
2964

2965
static int32_t mndCheckDropStbForStream(SMnode *pMnode, const char *stbFullName, int64_t suid) {
×
2966
  int32_t code = 0;
×
2967
  SSdb   *pSdb = pMnode->pSdb;
×
2968
  void   *pIter = NULL;
×
2969
  while (1) {
×
2970
    SStreamObj *pStream = NULL;
×
2971
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
×
2972
    if (pIter == NULL) break;
×
2973

2974
    if (pStream->pCreate->outStbUid == suid) {
×
2975
      sdbCancelFetch(pSdb, pIter);
×
2976
      sdbRelease(pSdb, pStream);
×
2977
      TAOS_RETURN(-1);
×
2978
    }
2979

2980
    sdbRelease(pSdb, pStream);
×
2981
  }
2982
  TAOS_RETURN(code);
×
2983
}
2984

2985
static int32_t mndProcessDropTtltbRsp(SRpcMsg *pRsp) { return 0; }
×
2986
static int32_t mndProcessTrimDbRsp(SRpcMsg *pRsp) { return 0; }
120✔
2987

2988
static int32_t mndProcessDropStbReq(SRpcMsg *pReq) {
2,537✔
2989
  SMnode      *pMnode = pReq->info.node;
2,537✔
2990
  int32_t      code = -1;
2,537✔
2991
  SDbObj      *pDb = NULL;
2,537✔
2992
  SStbObj     *pStb = NULL;
2,537✔
2993
  SMDropStbReq dropReq = {0};
2,537✔
2994

2995
  TAOS_CHECK_GOTO(tDeserializeSMDropStbReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
2,537!
2996

2997
  mInfo("stb:%s, start to drop", dropReq.name);
2,537!
2998

2999
  pStb = mndAcquireStb(pMnode, dropReq.name);
2,537✔
3000
  if (pStb == NULL) {
2,537✔
3001
    if (dropReq.igNotExists) {
859✔
3002
      mInfo("stb:%s, not exist, ignore not exist is set", dropReq.name);
856!
3003
      code = 0;
856✔
3004
      goto _OVER;
856✔
3005
    } else {
3006
      code = TSDB_CODE_MND_STB_NOT_EXIST;
3✔
3007
      goto _OVER;
3✔
3008
    }
3009
  }
3010

3011
  if ((dropReq.source == TD_REQ_FROM_TAOX_OLD || dropReq.source == TD_REQ_FROM_TAOX) && pStb->uid != dropReq.suid) {
1,678!
3012
    code = 0;
×
3013
    goto _OVER;
×
3014
  }
3015

3016
  pDb = mndAcquireDbByStb(pMnode, dropReq.name);
1,678✔
3017
  if (pDb == NULL) {
1,678!
3018
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
3019
    goto _OVER;
×
3020
  }
3021

3022
  if ((code = mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb)) != 0) {
1,678!
3023
    goto _OVER;
×
3024
  }
3025

3026
  if (mndCheckDropStbForTopic(pMnode, dropReq.name, pStb->uid) < 0) {
1,678!
3027
    code = TSDB_CODE_MND_TOPIC_MUST_BE_DELETED;
×
3028
    goto _OVER;
×
3029
  }
3030

3031
/*
3032
  if (mndCheckDropStbForStream(pMnode, dropReq.name, pStb->uid) < 0) {
3033
    code = TSDB_CODE_MND_STREAM_MUST_BE_DELETED;
3034
    goto _OVER;
3035
  }
3036
*/
3037

3038
  if (pDb->cfg.isMount) {
1,678✔
3039
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
2✔
3040
    goto _OVER;
2✔
3041
  }
3042

3043
  code = mndDropStb(pMnode, pReq, pDb, pStb);
1,676✔
3044
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
1,676!
3045

3046
  SName   name = {0};
1,676✔
3047
  int32_t ret = 0;
1,676✔
3048
  if ((ret = tNameFromString(&name, dropReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
1,676!
3049
    mError("stb:%s, failed to tNameFromString since %s", dropReq.name, tstrerror(ret));
×
3050

3051
  auditRecord(pReq, pMnode->clusterId, "dropStb", name.dbname, name.tname, dropReq.sql, dropReq.sqlLen);
1,676✔
3052

3053
_OVER:
2,537✔
3054
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
2,537✔
3055
    mError("stb:%s, failed to drop since %s", dropReq.name, tstrerror(code));
5!
3056
  }
3057

3058
  mndReleaseDb(pMnode, pDb);
2,537✔
3059
  mndReleaseStb(pMnode, pStb);
2,537✔
3060
  tFreeSMDropStbReq(&dropReq);
2,537✔
3061
  TAOS_RETURN(code);
2,537✔
3062
}
3063

3064
static int32_t mndProcessTableMetaReq(SRpcMsg *pReq) {
2,236,967✔
3065
  SMnode       *pMnode = pReq->info.node;
2,236,967✔
3066
  int32_t       code = -1;
2,236,967✔
3067
  STableInfoReq infoReq = {0};
2,236,967✔
3068
  STableMetaRsp metaRsp = {0};
2,236,967✔
3069
  SUserObj     *pUser = NULL;
2,236,967✔
3070

3071
  code = mndAcquireUser(pMnode, pReq->info.conn.user, &pUser);
2,236,967✔
3072
  if (pUser == NULL) return 0;
2,237,355!
3073
  bool sysinfo = pUser->sysInfo;
2,237,355✔
3074

3075
  TAOS_CHECK_GOTO(tDeserializeSTableInfoReq(pReq->pCont, pReq->contLen, &infoReq), NULL, _OVER);
2,237,355!
3076

3077
  if (0 == strcmp(infoReq.dbFName, TSDB_INFORMATION_SCHEMA_DB)) {
2,237,483✔
3078
    mInfo("information_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
218,965!
3079
    TAOS_CHECK_GOTO(mndBuildInsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, sysinfo, &metaRsp), NULL, _OVER);
218,965✔
3080
  } else if (0 == strcmp(infoReq.dbFName, TSDB_PERFORMANCE_SCHEMA_DB)) {
2,018,518✔
3081
    mInfo("performance_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
54,646!
3082
    TAOS_CHECK_GOTO(mndBuildPerfsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
54,646✔
3083
  } else {
3084
    mInfo("stb:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
1,963,872✔
3085
    TAOS_CHECK_GOTO(mndBuildStbSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp, true), NULL, _OVER);
1,964,389✔
3086
  }
3087

3088
  int32_t rspLen = tSerializeSTableMetaRsp(NULL, 0, &metaRsp);
2,233,147✔
3089
  if (rspLen < 0) {
2,232,854!
3090
    code = TSDB_CODE_INVALID_MSG;
×
3091
    goto _OVER;
×
3092
  }
3093

3094
  void *pRsp = rpcMallocCont(rspLen);
2,232,854✔
3095
  if (pRsp == NULL) {
2,232,528!
3096
    code = terrno;
×
3097
    goto _OVER;
×
3098
  }
3099

3100
  if ((rspLen = tSerializeSTableMetaRsp(pRsp, rspLen, &metaRsp)) < 0) {
2,232,528!
3101
    code = rspLen;
×
3102
    goto _OVER;
×
3103
  }
3104
  pReq->info.rsp = pRsp;
2,232,733✔
3105
  pReq->info.rspLen = rspLen;
2,232,733✔
3106
  code = 0;
2,232,733✔
3107

3108
  mTrace("%s.%s, meta is retrieved", infoReq.dbFName, infoReq.tbName);
2,232,733✔
3109

3110
_OVER:
2,232,717✔
3111
  if (code != 0) {
2,237,188✔
3112
    mError("stb:%s.%s, failed to retrieve meta since %s", infoReq.dbFName, infoReq.tbName, tstrerror(code));
4,455!
3113
  }
3114

3115
  mndReleaseUser(pMnode, pUser);
2,237,188✔
3116
  tFreeSTableMetaRsp(&metaRsp);
2,237,583✔
3117
  // TODO change to TAOS_RETURN
3118
  return code;
2,237,536✔
3119
}
3120

3121
static int32_t mndProcessTableCfgReq(SRpcMsg *pReq) {
165✔
3122
  SMnode      *pMnode = pReq->info.node;
165✔
3123
  int32_t      code = -1;
165✔
3124
  STableCfgReq cfgReq = {0};
165✔
3125
  STableCfgRsp cfgRsp = {0};
165✔
3126

3127
  TAOS_CHECK_GOTO(tDeserializeSTableCfgReq(pReq->pCont, pReq->contLen, &cfgReq), NULL, _OVER);
165!
3128

3129
  char dbName[TSDB_DB_NAME_LEN] = {0};
165✔
3130
  TAOS_CHECK_GOTO(mndExtractShortDbNameFromDbFullName(cfgReq.dbFName, dbName), NULL, _OVER);
165!
3131
  if (0 == strcmp(dbName, TSDB_INFORMATION_SCHEMA_DB)) {
165✔
3132
    mInfo("information_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
20!
3133
    TAOS_CHECK_GOTO(mndBuildInsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
20!
3134
  } else if (0 == strcmp(dbName, TSDB_PERFORMANCE_SCHEMA_DB)) {
145✔
3135
    mInfo("performance_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
10!
3136
    TAOS_CHECK_GOTO(mndBuildPerfsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
10!
3137
  } else {
3138
    mInfo("stb:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
135!
3139
    TAOS_CHECK_GOTO(mndBuildStbCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
135!
3140
  }
3141

3142
  int32_t rspLen = tSerializeSTableCfgRsp(NULL, 0, &cfgRsp);
165✔
3143
  if (rspLen < 0) {
165!
3144
    code = TSDB_CODE_INVALID_MSG;
×
3145
    goto _OVER;
×
3146
  }
3147

3148
  void *pRsp = rpcMallocCont(rspLen);
165✔
3149
  if (pRsp == NULL) {
165!
3150
    code = terrno;
×
3151
    goto _OVER;
×
3152
  }
3153

3154
  if ((rspLen = tSerializeSTableCfgRsp(pRsp, rspLen, &cfgRsp)) < 0) {
165!
3155
    code = rspLen;
×
3156
    goto _OVER;
×
3157
  }
3158
  pReq->info.rsp = pRsp;
165✔
3159
  pReq->info.rspLen = rspLen;
165✔
3160
  code = 0;
165✔
3161

3162
  mTrace("%s.%s, cfg is retrieved", cfgReq.dbFName, cfgReq.tbName);
165!
3163

3164
_OVER:
165✔
3165
  if (code != 0) {
165!
3166
    mError("stb:%s.%s, failed to retrieve cfg since %s", cfgReq.dbFName, cfgReq.tbName, tstrerror(code));
×
3167
  }
3168

3169
  tFreeSTableCfgRsp(&cfgRsp);
165✔
3170
  TAOS_RETURN(code);
165✔
3171
}
3172

3173
int32_t mndValidateStbInfo(SMnode *pMnode, SSTableVersion *pStbVersions, int32_t numOfStbs, void **ppRsp,
33,280✔
3174
                           int32_t *pRspLen) {
3175
  int32_t   code = 0;
33,280✔
3176
  SSTbHbRsp hbRsp = {0};
33,280✔
3177
  hbRsp.pMetaRsp = taosArrayInit(numOfStbs, sizeof(STableMetaRsp));
33,280✔
3178
  if (hbRsp.pMetaRsp == NULL) {
33,280!
3179
    code = terrno;
×
3180
    TAOS_RETURN(code);
×
3181
  }
3182

3183
  hbRsp.pIndexRsp = taosArrayInit(numOfStbs, sizeof(STableIndexRsp));
33,280✔
3184
  if (NULL == hbRsp.pIndexRsp) {
33,280!
3185
    taosArrayDestroy(hbRsp.pMetaRsp);
×
3186
    code = terrno;
×
3187
    TAOS_RETURN(code);
×
3188
  }
3189

3190
  for (int32_t i = 0; i < numOfStbs; ++i) {
74,644✔
3191
    SSTableVersion *pStbVersion = &pStbVersions[i];
41,364✔
3192
    pStbVersion->suid = be64toh(pStbVersion->suid);
41,364✔
3193
    pStbVersion->sversion = ntohl(pStbVersion->sversion);
41,364✔
3194
    pStbVersion->tversion = ntohl(pStbVersion->tversion);
41,364✔
3195
    pStbVersion->smaVer = ntohl(pStbVersion->smaVer);
41,364✔
3196

3197
    bool    schema = false;
41,364✔
3198
    bool    sma = false;
41,364✔
3199
    int32_t code = mndValidateStbVersion(pMnode, pStbVersion, &schema, &sma);
41,364✔
3200
    if (TSDB_CODE_SUCCESS != code) {
41,364✔
3201
      STableMetaRsp metaRsp = {0};
99✔
3202
      metaRsp.numOfColumns = -1;
99✔
3203
      metaRsp.suid = pStbVersion->suid;
99✔
3204
      tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
99✔
3205
      tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
99✔
3206
      tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
99✔
3207
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
198!
3208
        code = terrno;
×
3209
        return code;
×
3210
      }
3211
      continue;
99✔
3212
    }
3213

3214
    if (schema) {
41,265✔
3215
      STableMetaRsp metaRsp = {0};
321✔
3216
      mInfo("stb:%s.%s, start to retrieve meta", pStbVersion->dbFName, pStbVersion->stbName);
321!
3217
      if (mndBuildStbSchema(pMnode, pStbVersion->dbFName, pStbVersion->stbName, &metaRsp, false) != 0) {
321!
3218
        metaRsp.numOfColumns = -1;
×
3219
        metaRsp.suid = pStbVersion->suid;
×
3220
        tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
×
3221
        tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
×
3222
        tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
×
3223
        if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
×
3224
          code = terrno;
×
3225
          return code;
×
3226
        }
3227
        continue;
×
3228
      }
3229

3230
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
642!
3231
        code = terrno;
×
3232
        return code;
×
3233
      }
3234
    }
3235

3236
    if (sma) {
41,265!
3237
      bool           exist = false;
×
3238
      char           tbFName[TSDB_TABLE_FNAME_LEN];
3239
      STableIndexRsp indexRsp = {0};
×
3240
      indexRsp.pIndex = taosArrayInit(10, sizeof(STableIndexInfo));
×
3241
      if (NULL == indexRsp.pIndex) {
×
3242
        code = terrno;
×
3243
        TAOS_RETURN(code);
×
3244
      }
3245

3246
      (void)tsnprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVersion->dbFName, pStbVersion->stbName);
×
3247
      tstrncpy(indexRsp.dbFName, pStbVersion->dbFName, sizeof(indexRsp.dbFName));
×
3248
      tstrncpy(indexRsp.tbName, pStbVersion->stbName, sizeof(indexRsp.tbName));
×
3249

3250
      if (taosArrayPush(hbRsp.pIndexRsp, &indexRsp) == NULL) {
×
3251
        code = terrno;
×
3252
        return code;
×
3253
      }
3254
    }
3255
  }
3256

3257
  int32_t rspLen = tSerializeSSTbHbRsp(NULL, 0, &hbRsp);
33,280✔
3258
  if (rspLen < 0) {
33,280!
3259
    tFreeSSTbHbRsp(&hbRsp);
×
3260
    code = TSDB_CODE_INVALID_MSG;
×
3261
    TAOS_RETURN(code);
×
3262
  }
3263

3264
  void *pRsp = taosMemoryMalloc(rspLen);
33,280!
3265
  if (pRsp == NULL) {
33,280!
3266
    tFreeSSTbHbRsp(&hbRsp);
×
3267
    code = terrno;
×
3268
    TAOS_RETURN(code);
×
3269
  }
3270

3271
  rspLen = tSerializeSSTbHbRsp(pRsp, rspLen, &hbRsp);
33,280✔
3272
  tFreeSSTbHbRsp(&hbRsp);
33,280✔
3273
  if (rspLen < 0) return rspLen;
33,280!
3274
  *ppRsp = pRsp;
33,280✔
3275
  *pRspLen = rspLen;
33,280✔
3276
  TAOS_RETURN(code);
33,280✔
3277
}
3278

3279
int32_t mndGetNumOfStbs(SMnode *pMnode, char *dbName, int32_t *pNumOfStbs) {
9,205✔
3280
  int32_t code = 0;
9,205✔
3281
  SSdb   *pSdb = pMnode->pSdb;
9,205✔
3282
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
9,205✔
3283
  if (pDb == NULL) {
9,205!
3284
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
3285
    TAOS_RETURN(code);
×
3286
  }
3287

3288
  int32_t numOfStbs = 0;
9,205✔
3289
  void   *pIter = NULL;
9,205✔
3290
  while (1) {
274,200✔
3291
    SStbObj *pStb = NULL;
283,405✔
3292
    pIter = sdbFetch(pSdb, SDB_STB, pIter, (void **)&pStb);
283,405✔
3293
    if (pIter == NULL) break;
283,405✔
3294

3295
    if (pStb->dbUid == pDb->uid) {
274,200✔
3296
      numOfStbs++;
138,938✔
3297
    }
3298

3299
    sdbRelease(pSdb, pStb);
274,200✔
3300
  }
3301

3302
  *pNumOfStbs = numOfStbs;
9,205✔
3303
  mndReleaseDb(pMnode, pDb);
9,205✔
3304
  TAOS_RETURN(code);
9,205✔
3305
}
3306

3307
int32_t mndExtractDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
3308
  SName name = {0};
×
3309
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3310

3311
  TAOS_CHECK_RETURN(tNameGetFullDbName(&name, dst));
×
3312

3313
  return 0;
×
3314
}
3315

3316
int32_t mndExtractShortDbNameFromStbFullName(const char *stbFullName, char *dst) {
110✔
3317
  SName name = {0};
110✔
3318
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
110!
3319

3320
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
110!
3321

3322
  return 0;
110✔
3323
}
3324

3325
int32_t mndExtractShortDbNameFromDbFullName(const char *stbFullName, char *dst) {
165✔
3326
  SName name = {0};
165✔
3327
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB));
165!
3328

3329
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
165!
3330

3331
  return 0;
165✔
3332
}
3333

3334
void mndExtractTbNameFromStbFullName(const char *stbFullName, char *dst, int32_t dstSize) {
1,653,461✔
3335
  int32_t pos = -1;
1,653,461✔
3336
  int32_t num = 0;
1,653,461✔
3337
  for (pos = 0; stbFullName[pos] != 0; ++pos) {
29,464,617✔
3338
    if (stbFullName[pos] == TS_PATH_DELIMITER[0]) num++;
29,464,532✔
3339
    if (num == 2) break;
29,464,532✔
3340
  }
3341

3342
  if (num == 2) {
1,653,461✔
3343
    tstrncpy(dst, stbFullName + pos + 1, dstSize);
1,653,365✔
3344
  }
3345
}
1,653,461✔
3346

3347
static int32_t mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
19,164✔
3348
  SMnode  *pMnode = pReq->info.node;
19,164✔
3349
  SSdb    *pSdb = pMnode->pSdb;
19,164✔
3350
  int32_t  numOfRows = 0;
19,164✔
3351
  SStbObj *pStb = NULL;
19,164✔
3352
  int32_t  cols = 0;
19,164✔
3353
  int32_t  lino = 0;
19,164✔
3354
  int32_t  code = 0;
19,164✔
3355

3356
  SDbObj *pDb = NULL;
19,164✔
3357
  if (strlen(pShow->db) > 0) {
19,164✔
3358
    pDb = mndAcquireDb(pMnode, pShow->db);
1,232✔
3359
    if (pDb == NULL) return terrno;
1,232✔
3360
  }
3361

3362
  while (numOfRows < rows) {
956,134✔
3363
    pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
947,773✔
3364
    if (pShow->pIter == NULL) break;
947,425✔
3365

3366
    if (pDb != NULL && pStb->dbUid != pDb->uid) {
936,614✔
3367
      sdbRelease(pSdb, pStb);
2,680✔
3368
      continue;
2,680✔
3369
    }
3370

3371
    if (isTsmaResSTb(pStb->name)) {
933,934!
3372
      sdbRelease(pSdb, pStb);
×
3373
      continue;
×
3374
    }
3375

3376
    cols = 0;
933,841✔
3377

3378
    SName name = {0};
933,841✔
3379

3380
    char stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
933,841✔
3381
    mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
933,841✔
3382
    varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
934,039✔
3383
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
934,039✔
3384
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _ERROR);
931,258!
3385

3386
    char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
927,403✔
3387
    RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _ERROR);
927,403!
3388
    RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _ERROR);
933,282!
3389
    varDataSetLen(db, strlen(varDataVal(db)));
933,419✔
3390
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
933,419✔
3391
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _ERROR);
930,164!
3392

3393
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
925,120✔
3394
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->createdTime, false), pStb, &lino,
922,474!
3395
                        _ERROR);
3396

3397
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
921,452✔
3398
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfColumns, false), pStb, &lino,
919,549!
3399
                        _ERROR);
3400

3401
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
920,050✔
3402
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfTags, false), pStb, &lino, _ERROR);
918,226!
3403

3404
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
918,568✔
3405
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->updateTime, false), pStb, &lino,
917,082!
3406
                        _ERROR);  // number of tables
3407

3408
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
918,803✔
3409
    if (pStb->commentLen > 0) {
917,036✔
3410
      char comment[TSDB_TB_COMMENT_LEN + VARSTR_HEADER_SIZE] = {0};
71✔
3411
      STR_TO_VARSTR(comment, pStb->comment);
71✔
3412
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
71!
3413
    } else if (pStb->commentLen == 0) {
916,965✔
3414
      char comment[VARSTR_HEADER_SIZE + VARSTR_HEADER_SIZE] = {0};
293✔
3415
      STR_TO_VARSTR(comment, "");
293✔
3416
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
293!
3417
    } else {
3418
      colDataSetNULL(pColInfo, numOfRows);
916,672!
3419
    }
3420

3421
    char watermark[64 + VARSTR_HEADER_SIZE] = {0};
917,061✔
3422
    (void)tsnprintf(varDataVal(watermark), sizeof(watermark) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
917,061✔
3423
              pStb->watermark[0], pStb->watermark[1]);
917,061✔
3424
    varDataSetLen(watermark, strlen(varDataVal(watermark)));
933,340✔
3425

3426
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
933,340✔
3427
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)watermark, false), pStb, &lino, _ERROR);
927,597!
3428

3429
    char maxDelay[64 + VARSTR_HEADER_SIZE] = {0};
923,252✔
3430
    (void)tsnprintf(varDataVal(maxDelay), sizeof(maxDelay) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
923,252✔
3431
              pStb->maxdelay[0], pStb->maxdelay[1]);
923,252✔
3432
    varDataSetLen(maxDelay, strlen(varDataVal(maxDelay)));
933,770✔
3433

3434
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
933,770✔
3435
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)maxDelay, false), pStb, &lino, _ERROR);
928,174!
3436

3437
    char    rollup[160 + VARSTR_HEADER_SIZE] = {0};
922,835✔
3438
    int32_t rollupNum = (int32_t)taosArrayGetSize(pStb->pFuncs);
922,835✔
3439
    char   *sep = ", ";
927,895✔
3440
    int32_t sepLen = strlen(sep);
927,895✔
3441
    int32_t rollupLen = sizeof(rollup) - VARSTR_HEADER_SIZE - 2;
927,895✔
3442
    for (int32_t i = 0; i < rollupNum; ++i) {
927,896✔
3443
      char *funcName = taosArrayGet(pStb->pFuncs, i);
1✔
3444
      if (i) {
1!
3445
        (void)strncat(varDataVal(rollup), sep, rollupLen);
×
3446
        rollupLen -= sepLen;
×
3447
      }
3448
      (void)strncat(varDataVal(rollup), funcName, rollupLen);
1✔
3449
      rollupLen -= strlen(funcName);
1✔
3450
    }
3451
    varDataSetLen(rollup, strlen(varDataVal(rollup)));
927,895✔
3452

3453
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
927,895✔
3454
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)rollup, false), pStb, &lino, _ERROR);
927,198!
3455

3456
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
921,560✔
3457
    if (pColInfo) {
917,787!
3458
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->uid), false), pStb, &lino, _ERROR);
917,973!
3459
    }
3460

3461
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
916,534✔
3462
    if (pColInfo) {
914,466!
3463
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->virtualStb), false), pStb, &lino, _ERROR);
914,515!
3464
    }
3465

3466
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
915,709✔
3467
    if (pColInfo) {
913,554!
3468
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->keep), false), pStb, &lino, _ERROR);
913,782!
3469
    }
3470

3471
    numOfRows++;
915,274✔
3472
    sdbRelease(pSdb, pStb);
915,274✔
3473
  }
3474

3475
  if (pDb != NULL) {
19,172✔
3476
    mndReleaseDb(pMnode, pDb);
1,228✔
3477
  }
3478

3479
  goto _OVER;
19,166✔
3480

3481
_ERROR:
×
3482
  mError("show:0x%" PRIx64 ", failed to retrieve data at %s:%d since %s", pShow->id, __FUNCTION__, lino,
×
3483
         tstrerror(code));
3484

3485
_OVER:
×
3486
  pShow->numOfRows += numOfRows;
19,165✔
3487
  return numOfRows;
19,165✔
3488
}
3489

3490
static int32_t buildDbColsInfoBlock(const SSDataBlock *p, const SSysTableMeta *pSysDbTableMeta, size_t size,
28,078✔
3491
                                    const char *dbName, const char *tbName) {
3492
  char    tName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
28,078✔
3493
  char    dName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
28,078✔
3494
  char    typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
28,078✔
3495
  int32_t numOfRows = p->info.rows;
28,078✔
3496
  int32_t lino = 0;
28,078✔
3497
  int32_t code = 0;
28,078✔
3498

3499
  STR_TO_VARSTR(dName, dbName);
28,078✔
3500
  STR_TO_VARSTR(typeName, "SYSTEM_TABLE");
28,078✔
3501

3502
  for (int32_t i = 0; i < size; ++i) {
657,280!
3503
    const SSysTableMeta *pm = &pSysDbTableMeta[i];
659,525✔
3504
    //    if (pm->sysInfo) {
3505
    //      continue;
3506
    //    }
3507
    if (tbName[0] && strncmp(tbName, pm->name, TSDB_TABLE_NAME_LEN) != 0) {
659,525!
3508
      continue;
×
3509
    }
3510

3511
    STR_TO_VARSTR(tName, pm->name);
659,525✔
3512

3513
    for (int32_t j = 0; j < pm->colNum; j++) {
6,185,476✔
3514
      // table name
3515
      SColumnInfoData *pColInfoData = taosArrayGet(p->pDataBlock, 0);
5,556,274✔
3516
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, tName, false), &lino, _OVER);
5,545,333!
3517

3518
      // database name
3519
      pColInfoData = taosArrayGet(p->pDataBlock, 1);
5,536,964✔
3520
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, dName, false), &lino, _OVER);
5,528,456!
3521

3522
      pColInfoData = taosArrayGet(p->pDataBlock, 2);
5,532,972✔
3523
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, typeName, false), &lino, _OVER);
5,525,500!
3524

3525
      // col name
3526
      char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
5,534,228✔
3527
      STR_TO_VARSTR(colName, pm->schema[j].name);
5,534,228✔
3528
      pColInfoData = taosArrayGet(p->pDataBlock, 3);
5,534,228✔
3529
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, colName, false), &lino, _OVER);
5,556,641!
3530

3531
      // col type
3532
      int8_t colType = pm->schema[j].type;
5,540,627✔
3533
      pColInfoData = taosArrayGet(p->pDataBlock, 4);
5,540,627✔
3534
      char colTypeStr[VARSTR_HEADER_SIZE + 32];
3535
      int  colTypeLen =
5,586,331✔
3536
          tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
5,533,330✔
3537
      if (colType == TSDB_DATA_TYPE_VARCHAR) {
5,586,331✔
3538
        colTypeLen +=
2,975,685✔
3539
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
2,975,516✔
3540
                      (int32_t)(pm->schema[j].bytes - VARSTR_HEADER_SIZE));
2,975,516✔
3541
      } else if (colType == TSDB_DATA_TYPE_NCHAR) {
2,610,815!
3542
        colTypeLen +=
×
3543
            tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
×
3544
                      (int32_t)((pm->schema[j].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
×
3545
      }
3546
      varDataSetLen(colTypeStr, colTypeLen);
5,586,500✔
3547
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (char *)colTypeStr, false), &lino, _OVER);
5,586,500!
3548

3549
      pColInfoData = taosArrayGet(p->pDataBlock, 5);
5,547,763✔
3550
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (const char *)&pm->schema[j].bytes, false), &lino, _OVER);
5,539,635!
3551
      for (int32_t k = 6; k <= 9; ++k) {
27,479,813✔
3552
        pColInfoData = taosArrayGet(p->pDataBlock, k);
21,953,862✔
3553
        colDataSetNULL(pColInfoData, numOfRows);
21,950,176✔
3554
      }
3555

3556
      numOfRows += 1;
5,525,951✔
3557
    }
3558
  }
3559
  return numOfRows;
×
3560
_OVER:
×
3561
  mError("failed at %s:%d since %s", __FUNCTION__, lino, tstrerror(code));
×
3562
  return numOfRows;
×
3563
}
3564
#define BUILD_COL_FOR_INFO_DB 1
3565
#define BUILD_COL_FOR_PERF_DB 1 << 1
3566
#define BUILD_COL_FOR_USER_DB 1 << 2
3567
#define BUILD_COL_FOR_ALL_DB  (BUILD_COL_FOR_INFO_DB | BUILD_COL_FOR_PERF_DB | BUILD_COL_FOR_USER_DB)
3568

3569
static int32_t buildSysDbColsInfo(SSDataBlock *p, int8_t buildWhichDBs, char *tb) {
14,093✔
3570
  size_t               size = 0;
14,093✔
3571
  const SSysTableMeta *pSysDbTableMeta = NULL;
14,093✔
3572

3573
  if (buildWhichDBs & BUILD_COL_FOR_INFO_DB) {
14,093✔
3574
    getInfosDbMeta(&pSysDbTableMeta, &size);
14,039✔
3575
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_INFORMATION_SCHEMA_DB, tb);
14,039✔
3576
  }
3577

3578
  if (buildWhichDBs & BUILD_COL_FOR_PERF_DB) {
14,094✔
3579
    getPerfDbMeta(&pSysDbTableMeta, &size);
14,040✔
3580
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_PERFORMANCE_SCHEMA_DB, tb);
14,040✔
3581
  }
3582

3583
  return p->info.rows;
14,092✔
3584
}
3585

3586
static int8_t determineBuildColForWhichDBs(const char *db) {
14,117✔
3587
  int8_t buildWhichDBs;
3588
  if (!db[0])
14,117✔
3589
    buildWhichDBs = BUILD_COL_FOR_ALL_DB;
14,038✔
3590
  else {
3591
    char *p = strchr(db, '.');
79✔
3592
    if (p && strcmp(p + 1, TSDB_INFORMATION_SCHEMA_DB) == 0) {
79!
3593
      buildWhichDBs = BUILD_COL_FOR_INFO_DB;
1✔
3594
    } else if (p && strcmp(p + 1, TSDB_PERFORMANCE_SCHEMA_DB) == 0) {
78!
3595
      buildWhichDBs = BUILD_COL_FOR_PERF_DB;
1✔
3596
    } else {
3597
      buildWhichDBs = BUILD_COL_FOR_USER_DB;
77✔
3598
    }
3599
  }
3600
  return buildWhichDBs;
14,117✔
3601
}
3602

3603
static int32_t mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
14,117✔
3604
  uint8_t  buildWhichDBs;
3605
  SMnode  *pMnode = pReq->info.node;
14,117✔
3606
  SSdb    *pSdb = pMnode->pSdb;
14,117✔
3607
  SStbObj *pStb = NULL;
14,117✔
3608
  int32_t  numOfRows = 0;
14,117✔
3609
  int32_t  lino = 0;
14,117✔
3610
  int32_t  code = 0;
14,117✔
3611

3612
  buildWhichDBs = determineBuildColForWhichDBs(pShow->db);
14,117✔
3613

3614
  if (!pShow->sysDbRsp) {
14,117✔
3615
    numOfRows = buildSysDbColsInfo(pBlock, buildWhichDBs, pShow->filterTb);
14,093✔
3616
    mDebug("mndRetrieveStbCol get system table cols, rows:%d, db:%s", numOfRows, pShow->db);
14,092✔
3617
    pShow->sysDbRsp = true;
14,093✔
3618
  }
3619

3620
  if (buildWhichDBs & BUILD_COL_FOR_USER_DB) {
14,117✔
3621
    SDbObj *pDb = NULL;
14,115✔
3622
    if (strlen(pShow->db) > 0) {
14,115✔
3623
      pDb = mndAcquireDb(pMnode, pShow->db);
77✔
3624
      if (pDb == NULL && TSDB_CODE_MND_DB_NOT_EXIST != terrno && pBlock->info.rows == 0) return terrno;
77!
3625
    }
3626

3627
    char typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
14,116✔
3628
    STR_TO_VARSTR(typeName, "SUPER_TABLE");
14,116✔
3629
    bool fetch = pShow->restore ? false : true;
14,116✔
3630
    pShow->restore = false;
14,116✔
3631
    while (numOfRows < rows) {
733,153✔
3632
      if (fetch) {
733,151✔
3633
        pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
733,127✔
3634
        if (pShow->pIter == NULL) break;
733,140✔
3635
      } else {
3636
        fetch = true;
24✔
3637
        void *pKey = taosHashGetKey(pShow->pIter, NULL);
24✔
3638
        pStb = sdbAcquire(pSdb, SDB_STB, pKey);
24✔
3639
        if (!pStb) continue;
36!
3640
      }
3641

3642
      if (pDb != NULL && pStb->dbUid != pDb->uid) {
719,048✔
3643
        sdbRelease(pSdb, pStb);
12✔
3644
        continue;
12✔
3645
      }
3646

3647
      SName name = {0};
719,036✔
3648
      char  stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
719,036✔
3649
      mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
719,036✔
3650
      if (pShow->filterTb[0] && strncmp(pShow->filterTb, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN) != 0) {
719,026!
3651
        sdbRelease(pSdb, pStb);
×
3652
        continue;
×
3653
      }
3654

3655
      if ((numOfRows + pStb->numOfColumns) > rows) {
719,026✔
3656
        pShow->restore = true;
24✔
3657
        if (numOfRows == 0) {
24!
3658
          mError("mndRetrieveStbCol failed to get stable cols since buf:%d less than result:%d, stable name:%s, db:%s",
×
3659
                 rows, pStb->numOfColumns, pStb->name, pStb->db);
3660
        }
3661
        sdbRelease(pSdb, pStb);
24✔
3662
        break;
24✔
3663
      }
3664

3665
      varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
719,002✔
3666

3667
      mDebug("mndRetrieveStbCol get stable cols, stable name:%s, db:%s", pStb->name, pStb->db);
719,002✔
3668

3669
      char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
719,002✔
3670
      RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _OVER);
719,002!
3671
      RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _OVER);
718,981!
3672
      varDataSetLen(db, strlen(varDataVal(db)));
719,005✔
3673

3674
      for (int i = 0; i < pStb->numOfColumns; i++) {
17,158,960✔
3675
        int32_t          cols = 0;
17,058,460✔
3676
        SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
17,058,460✔
3677
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _OVER);
16,887,266!
3678

3679
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
16,909,680✔
3680
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _OVER);
16,695,948!
3681

3682
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
17,065,308✔
3683
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, typeName, false), pStb, &lino, _OVER);
16,828,941!
3684

3685
        // col name
3686
        char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
16,808,064✔
3687
        STR_TO_VARSTR(colName, pStb->pColumns[i].name);
16,808,064✔
3688
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
16,808,064✔
3689
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, colName, false), pStb, &lino, _OVER);
16,934,192!
3690

3691
        // col type
3692
        int8_t colType = pStb->pColumns[i].type;
16,840,245✔
3693
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
16,840,245✔
3694
        char colTypeStr[VARSTR_HEADER_SIZE + 32];
3695
        int  colTypeLen =
17,418,010✔
3696
            tsnprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
16,678,771✔
3697
        if (colType == TSDB_DATA_TYPE_VARCHAR) {
17,418,010✔
3698
          colTypeLen +=
1,384,287✔
3699
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
1,384,222✔
3700
                        "(%d)", (int32_t)(pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE));
1,384,222✔
3701
        } else if (colType == TSDB_DATA_TYPE_NCHAR) {
16,033,788✔
3702
          colTypeLen +=
1,391,493✔
3703
              tsnprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
1,391,399✔
3704
                        "(%d)", (int32_t)((pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
1,391,399✔
3705
        } else if (IS_DECIMAL_TYPE(colType)) {
14,642,389!
3706
          STypeMod typeMod = pStb->pExtSchemas[i].typeMod;
×
3707
          uint8_t prec = 0, scale = 0;
×
3708
          decimalFromTypeMod(typeMod, &prec, &scale);
×
3709
          colTypeLen += sprintf(varDataVal(colTypeStr) + colTypeLen, "(%d,%d)", prec, scale);
×
3710
        }
3711
        varDataSetLen(colTypeStr, colTypeLen);
17,420,462✔
3712
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (char *)colTypeStr, false), pStb, &lino, _OVER);
17,420,462!
3713

3714
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
16,949,644✔
3715
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].bytes, false), pStb,
16,738,357!
3716
                            &lino, _OVER);
3717
        while (cols < pShow->numOfColumns) {
80,986,402✔
3718
          pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
64,546,447✔
3719
          colDataSetNULL(pColInfo, numOfRows);
64,288,670✔
3720
        }
3721
        numOfRows++;
16,439,955✔
3722
      }
3723

3724
      sdbRelease(pSdb, pStb);
100,500✔
3725
    }
3726

3727
    if (pDb != NULL) {
14,118✔
3728
      mndReleaseDb(pMnode, pDb);
77✔
3729
    }
3730
  }
3731

3732
  mDebug("mndRetrieveStbCol success, rows:%d, pShow->numOfRows:%d", numOfRows, pShow->numOfRows);
14,118✔
3733
  goto _OVER;
14,118✔
3734

3735
_ERROR:
3736
  mError("failed to mndRetrieveStbCol, rows:%d, pShow->numOfRows:%d, at %s:%d since %s", numOfRows, pShow->numOfRows,
3737
         __FUNCTION__, lino, tstrerror(code));
3738

3739
_OVER:
14,118✔
3740
  pShow->numOfRows += numOfRows;
14,118✔
3741
  return numOfRows;
14,118✔
3742
}
3743

3744
static void mndCancelGetNextStb(SMnode *pMnode, void *pIter) {
1✔
3745
  SSdb *pSdb = pMnode->pSdb;
1✔
3746
  sdbCancelFetchByType(pSdb, pIter, SDB_STB);
1✔
3747
}
1✔
3748

3749
const char *mndGetStbStr(const char *src) {
×
3750
  char *posDb = strstr(src, TS_PATH_DELIMITER);
×
3751
  if (posDb != NULL) ++posDb;
×
3752
  if (posDb == NULL) return src;
×
3753

3754
  char *posStb = strstr(posDb, TS_PATH_DELIMITER);
×
3755
  if (posStb != NULL) ++posStb;
×
3756
  if (posStb == NULL) return posDb;
×
3757
  return posStb;
×
3758
}
3759

3760
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
3761
  // impl
3762
  return TSDB_CODE_SUCCESS;
×
3763
}
3764

3765
/*int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp, void *sql,
3766
                        int32_t len) {
3767
  // impl later
3768
  int32_t code = 0;
3769
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
3770
  if (pTrans == NULL) goto _OVER;
3771

3772
  mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
3773
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
3774
  if (mndTransCheckConflict(pMnode, pTrans) != 0) goto _OVER;
3775

3776
  if (mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
3777
  if (mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
3778
  if (mndSetAlterStbRedoActions2(pMnode, pTrans, pDb, pStb, sql, len) != 0) goto _OVER;
3779
  if (mndTransPrepare(pMnode, pTrans) != 0) goto _OVER;
3780

3781
  return code;
3782

3783
_OVER:
3784
  mndTransDrop(pTrans);
3785
  return code;
3786
}
3787
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *tagIdxReq, SDbObj *pDb, SStbObj *pOld) {
3788
  bool    needRsp = true;
3789
  int32_t code = -1;
3790
  SField *pField0 = NULL;
3791

3792
  SStbObj  stbObj = {0};
3793
  SStbObj *pNew = &stbObj;
3794

3795
  taosRLockLatch(&pOld->lock);
3796
  memcpy(&stbObj, pOld, sizeof(SStbObj));
3797
  taosRUnLockLatch(&pOld->lock);
3798

3799
  stbObj.pColumns = NULL;
3800
  stbObj.pTags = NULL;
3801
  stbObj.updateTime = taosGetTimestampMs();
3802
  stbObj.lock = 0;
3803

3804
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagIdxReq->colName);
3805
  if (tag < 0) {
3806
    terrno = TSDB_CODE_MND_TAG_NOT_EXIST;
3807
    return -1;
3808
  }
3809
  if (mndAllocStbSchemas(pOld, pNew) != 0) {
3810
    return -1;
3811
  }
3812

3813
  SSchema *pTag = pNew->pTags + tag;
3814
  if (IS_IDX_ON(pTag)) {
3815
    terrno = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
3816
    return -1;
3817
  } else {
3818
    pTag->flags |= COL_IDX_ON;
3819
  }
3820
  pNew->tagVer++;
3821

3822
  code = mndAddIndexImpl(pMnode, pReq, pDb, pNew, needRsp, pReq->pCont, pReq->contLen);
3823

3824
  return code;
3825
}
3826
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq) {
3827
  SMnode            *pMnode = pReq->info.node;
3828
  int32_t            code = -1;
3829
  SDbObj            *pDb = NULL;
3830
  SStbObj           *pStb = NULL;
3831
  SCreateTagIndexReq tagIdxReq = {0};
3832

3833
  if (tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &tagIdxReq) != 0) {
3834
    terrno = TSDB_CODE_INVALID_MSG;
3835
    goto _OVER;
3836
  }
3837

3838
  mInfo("stb:%s, start to alter", tagIdxReq.stbName);
3839

3840
  if (mndCheckIndexReq(&tagIdxReq) != TSDB_CODE_SUCCESS) {
3841
    goto _OVER;
3842
  }
3843

3844
  pDb = mndAcquireDbByStb(pMnode, tagIdxReq.dbFName);
3845
  if (pDb == NULL) {
3846
    terrno = TSDB_CODE_MND_DB_NOT_EXIST;
3847
    goto _OVER;
3848
  }
3849

3850
  pStb = mndAcquireStb(pMnode, tagIdxReq.stbName);
3851
  if (pStb == NULL) {
3852
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
3853
    goto _OVER;
3854
  }
3855
  if (mndCheckDbPrivilege(pMnode, pReq->info.conn.user, MND_OPER_WRITE_DB, pDb) != 0) {
3856
    goto _OVER;
3857
  }
3858

3859
  code = mndAddIndex(pMnode, pReq, &tagIdxReq, pDb, pStb);
3860
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
3861
    return terrno;
3862
  } else {
3863
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
3864
  }
3865
_OVER:
3866
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3867
    mError("stb:%s, failed to create index since %s", tagIdxReq.stbName, terrstr());
3868
  }
3869
  mndReleaseStb(pMnode, pStb);
3870
  mndReleaseDb(pMnode, pDb);
3871
  return code;
3872
}
3873
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq) {
3874
  SMnode          *pMnode = pReq->info.node;
3875
  int32_t          code = -1;
3876
  SDbObj          *pDb = NULL;
3877
  SStbObj         *pStb = NULL;
3878
  SDropTagIndexReq dropReq = {0};
3879
  if (tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
3880
    terrno = TSDB_CODE_INVALID_MSG;
3881
    goto _OVER;
3882
  }
3883
  //
3884
  return TSDB_CODE_SUCCESS;
3885
_OVER:
3886
  return code;
3887
}*/
3888

3889
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq) {
×
3890
  int32_t code = mndProcessDropStbReq(pReq);
×
3891
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
×
3892
    pReq->info.rsp = rpcMallocCont(1);
×
3893
    pReq->info.rspLen = 1;
×
3894
    pReq->info.noResp = false;
×
3895
    pReq->code = code;
×
3896
  }
3897
  return code;
×
3898
}
3899

3900
typedef struct SVDropTbVgReqs {
3901
  SArray     *pBatchReqs;
3902
  SVgroupInfo info;
3903
} SVDropTbVgReqs;
3904

3905
typedef struct SMDropTbDbInfo {
3906
  SArray *dbVgInfos;
3907
  int32_t hashPrefix;
3908
  int32_t hashSuffix;
3909
  int32_t hashMethod;
3910
} SMDropTbDbInfo;
3911

3912
typedef struct SMDropTbTsmaInfo {
3913
  char           tsmaResTbDbFName[TSDB_DB_FNAME_LEN];
3914
  char           tsmaResTbNamePrefix[TSDB_TABLE_FNAME_LEN];
3915
  int32_t        suid;
3916
  SMDropTbDbInfo dbInfo;  // reference to DbInfo in pDbMap
3917
} SMDropTbTsmaInfo;
3918

3919
typedef struct SMDropTbTsmaInfos {
3920
  SArray *pTsmaInfos;  // SMDropTbTsmaInfo
3921
} SMDropTbTsmaInfos;
3922

3923
typedef struct SMndDropTbsWithTsmaCtx {
3924
  SHashObj *pVgMap;  // <vgId, SVDropTbVgReqs>
3925
} SMndDropTbsWithTsmaCtx;
3926

3927
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId);
3928

3929
static void destroySVDropTbBatchReqs(void *p);
3930
static void mndDestroyDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx *p) {
16✔
3931
  if (!p) return;
16!
3932

3933
  if (p->pVgMap) {
16!
3934
    void *pIter = taosHashIterate(p->pVgMap, NULL);
16✔
3935
    while (pIter) {
32✔
3936
      SVDropTbVgReqs *pReqs = pIter;
16✔
3937
      taosArrayDestroyEx(pReqs->pBatchReqs, destroySVDropTbBatchReqs);
16✔
3938
      pIter = taosHashIterate(p->pVgMap, pIter);
16✔
3939
    }
3940
    taosHashCleanup(p->pVgMap);
16✔
3941
  }
3942
  taosMemoryFree(p);
16!
3943
}
3944

3945
static int32_t mndInitDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx **ppCtx) {
16✔
3946
  int32_t                 code = 0;
16✔
3947
  SMndDropTbsWithTsmaCtx *pCtx = taosMemoryCalloc(1, sizeof(SMndDropTbsWithTsmaCtx));
16!
3948
  if (!pCtx) return terrno;
16!
3949

3950
  pCtx->pVgMap = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_INT), false, HASH_NO_LOCK);
16✔
3951
  if (!pCtx->pVgMap) {
16!
3952
    code = terrno;
×
3953
    goto _end;
×
3954
  }
3955

3956
  *ppCtx = pCtx;
16✔
3957
_end:
16✔
3958
  if (code) mndDestroyDropTbsWithTsmaCtx(pCtx);
16!
3959
  return code;
16✔
3960
}
3961

3962
static void *mndBuildVDropTbsReq(SMnode *pMnode, const SVgroupInfo *pVgInfo, const SVDropTbBatchReq *pReq,
41✔
3963
                                 int32_t *len) {
3964
  int32_t   contLen = 0;
41✔
3965
  int32_t   ret = 0;
41✔
3966
  SMsgHead *pHead = NULL;
41✔
3967
  SEncoder  encoder = {0};
41✔
3968

3969
  tEncodeSize(tEncodeSVDropTbBatchReq, pReq, contLen, ret);
41!
3970
  if (ret < 0) return NULL;
41!
3971

3972
  contLen += sizeof(SMsgHead);
41✔
3973
  pHead = taosMemoryMalloc(contLen);
41!
3974
  if (pHead == NULL) {
41!
3975
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
3976
    return NULL;
×
3977
  }
3978

3979
  pHead->contLen = htonl(contLen);
41✔
3980
  pHead->vgId = htonl(pVgInfo->vgId);
41✔
3981

3982
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
41✔
3983

3984
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
41✔
3985
  int32_t code = tEncodeSVDropTbBatchReq(&encoder, pReq);
41✔
3986
  tEncoderClear(&encoder);
41✔
3987
  if (code != 0) return NULL;
41!
3988

3989
  *len = contLen;
41✔
3990
  return pHead;
41✔
3991
}
3992

3993
static int32_t mndSetDropTbsRedoActions(SMnode *pMnode, STrans *pTrans, const SVDropTbVgReqs *pVgReqs, void *pCont,
41✔
3994
                                        int32_t contLen, tmsg_t msgType) {
3995
  STransAction action = {0};
41✔
3996
  action.epSet = pVgReqs->info.epSet;
41✔
3997
  action.pCont = pCont;
41✔
3998
  action.contLen = contLen;
41✔
3999
  action.msgType = msgType;
41✔
4000
  action.acceptableCode = TSDB_CODE_TDB_TABLE_NOT_EXIST;
41✔
4001
  return mndTransAppendRedoAction(pTrans, &action);
41✔
4002
}
4003

4004
static int32_t mndBuildDropTbRedoActions(SMnode *pMnode, STrans *pTrans, SHashObj *pVgMap, tmsg_t msgType) {
11✔
4005
  int32_t code = 0;
11✔
4006
  void   *pIter = taosHashIterate(pVgMap, NULL);
11✔
4007
  while (pIter) {
22✔
4008
    const SVDropTbVgReqs *pVgReqs = pIter;
11✔
4009
    int32_t               len = 0;
11✔
4010
    for (int32_t i = 0; i < taosArrayGetSize(pVgReqs->pBatchReqs) && code == TSDB_CODE_SUCCESS; ++i) {
52!
4011
      SVDropTbBatchReq *pBatchReq = taosArrayGet(pVgReqs->pBatchReqs, i);
41✔
4012
      void             *p = mndBuildVDropTbsReq(pMnode, &pVgReqs->info, pBatchReq, &len);
41✔
4013
      if (!p) {
41!
4014
        code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
4015
        if (terrno != 0) code = terrno;
×
4016
        break;
×
4017
      }
4018
      if ((code = mndSetDropTbsRedoActions(pMnode, pTrans, pVgReqs, p, len, msgType)) != 0) {
41!
4019
        break;
×
4020
      }
4021
    }
4022
    if (TSDB_CODE_SUCCESS != code) {
11!
4023
      taosHashCancelIterate(pVgMap, pIter);
×
4024
      break;
×
4025
    }
4026
    pIter = taosHashIterate(pVgMap, pIter);
11✔
4027
  }
4028
  return code;
11✔
4029
}
4030

4031
static int32_t mndCreateDropTbsTxnPrepare(SRpcMsg *pRsp, SMndDropTbsWithTsmaCtx *pCtx) {
16✔
4032
  int32_t code = 0;
16✔
4033
  SMnode *pMnode = pRsp->info.node;
16✔
4034
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pRsp, "drop-tbs");
16✔
4035
  mndTransSetChangeless(pTrans);
16✔
4036
  mndTransSetSerial(pTrans);
16✔
4037
  if (pTrans == NULL) {
16!
4038
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
4039
    if (terrno != 0) code = terrno;
×
4040
    goto _OVER;
×
4041
  }
4042

4043
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
16✔
4044

4045
  if ((code = mndBuildDropTbRedoActions(pMnode, pTrans, pCtx->pVgMap, TDMT_VND_DROP_TABLE)) != 0) goto _OVER;
11!
4046
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) goto _OVER;
11!
4047

4048
_OVER:
11✔
4049
  mndTransDrop(pTrans);
16✔
4050
  TAOS_RETURN(code);
16✔
4051
}
4052

4053
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq) {
×
4054
  int32_t      code = -1;
×
4055
  SMnode      *pMnode = pReq->info.node;
×
4056
  SDbObj      *pDb = NULL;
×
4057
  SStbObj     *pStb = NULL;
×
4058
  SMDropTbsReq dropReq = {0};
×
4059
  bool         locked = false;
×
4060
  if (tDeserializeSMDropTbsReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
×
4061
    code = TSDB_CODE_INVALID_MSG;
×
4062
    goto _OVER;
×
4063
  }
4064

4065
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
×
4066
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
×
4067
  if (code) goto _OVER;
×
4068
  for (int32_t i = 0; i < dropReq.pVgReqs->size; ++i) {
×
4069
    SMDropTbReqsOnSingleVg *pReq = taosArrayGet(dropReq.pVgReqs, i);
×
4070
    code = mndDropTbForSingleVg(pMnode, pCtx, pReq->pTbs, pReq->vgInfo.vgId);
×
4071
    if (code) goto _OVER;
×
4072
  }
4073
  code = mndCreateDropTbsTxnPrepare(pReq, pCtx);
×
4074
  if (code == 0) {
×
4075
    code = TSDB_CODE_ACTION_IN_PROGRESS;
×
4076
  }
4077
_OVER:
×
4078
  tFreeSMDropTbsReq(&dropReq);
×
4079
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
×
4080
  TAOS_RETURN(code);
×
4081
}
4082

4083
static int32_t createDropTbBatchReq(const SVDropTbReq *pReq, SVDropTbBatchReq *pBatchReq) {
62✔
4084
  pBatchReq->nReqs = 1;
62✔
4085
  pBatchReq->pArray = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbReq));
62✔
4086
  if (!pBatchReq->pArray) return terrno;
62!
4087
  if (taosArrayPush(pBatchReq->pArray, pReq) == NULL) {
124!
4088
    taosArrayDestroy(pBatchReq->pArray);
×
4089
    pBatchReq->pArray = NULL;
×
4090
    return terrno;
×
4091
  }
4092
  return TSDB_CODE_SUCCESS;
62✔
4093
}
4094

4095
static void destroySVDropTbBatchReqs(void *p) {
62✔
4096
  SVDropTbBatchReq *pReq = p;
62✔
4097
  taosArrayDestroy(pReq->pArray);
62✔
4098
  pReq->pArray = NULL;
62✔
4099
}
62✔
4100

4101
static int32_t mndDropTbAdd(SMnode *pMnode, SHashObj *pVgHashMap, const SVgroupInfo *pVgInfo, char *name, tb_uid_t suid,
62✔
4102
                            bool ignoreNotExists) {
4103
  SVDropTbReq req = {.name = name, .suid = suid, .igNotExists = ignoreNotExists, .uid = 0};
62✔
4104

4105
  SVDropTbVgReqs *pVgReqs = taosHashGet(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId));
62✔
4106
  SVDropTbVgReqs  vgReqs = {0};
62✔
4107
  if (pVgReqs == NULL) {
62✔
4108
    vgReqs.info = *pVgInfo;
16✔
4109
    vgReqs.pBatchReqs = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbBatchReq));
16✔
4110
    if (!vgReqs.pBatchReqs) return terrno;
16!
4111
    SVDropTbBatchReq batchReq = {0};
16✔
4112
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
16✔
4113
    if (TSDB_CODE_SUCCESS != code) return code;
16!
4114
    if (taosArrayPush(vgReqs.pBatchReqs, &batchReq) == NULL) {
32!
4115
      taosArrayDestroy(batchReq.pArray);
×
4116
      return terrno;
×
4117
    }
4118
    if (taosHashPut(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId), &vgReqs, sizeof(vgReqs)) != 0) {
16!
4119
      taosArrayDestroyEx(vgReqs.pBatchReqs, destroySVDropTbBatchReqs);
×
4120
      return terrno;
×
4121
    }
4122
  } else {
4123
    SVDropTbBatchReq batchReq = {0};
46✔
4124
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
46✔
4125
    if (TSDB_CODE_SUCCESS != code) return code;
46!
4126
    if (taosArrayPush(pVgReqs->pBatchReqs, &batchReq) == NULL) {
92!
4127
      taosArrayDestroy(batchReq.pArray);
×
4128
      return terrno;
×
4129
    }
4130
  }
4131
  return 0;
62✔
4132
}
4133

4134
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId) {
16✔
4135
  int32_t code = 0;
16✔
4136

4137
  SVgObj *pVgObj = mndAcquireVgroup(pMnode, vgId);
16✔
4138
  if (!pVgObj) {
16!
4139
    code = 0;
×
4140
    goto _end;
×
4141
  }
4142
  SVgroupInfo vgInfo = {.hashBegin = pVgObj->hashBegin,
16✔
4143
                        .hashEnd = pVgObj->hashEnd,
16✔
4144
                        .numOfTable = pVgObj->numOfTables,
16✔
4145
                        .vgId = pVgObj->vgId};
16✔
4146
  vgInfo.epSet = mndGetVgroupEpset(pMnode, pVgObj);
16✔
4147
  mndReleaseVgroup(pMnode, pVgObj);
16✔
4148

4149
  for (int32_t i = 0; i < pTbs->size; ++i) {
78✔
4150
    SVDropTbReq *pTb = taosArrayGet(pTbs, i);
62✔
4151
    TAOS_CHECK_GOTO(mndDropTbAdd(pMnode, pCtx->pVgMap, &vgInfo, pTb->name, pTb->suid, pTb->igNotExists), NULL, _end);
62!
4152
  }
4153
_end:
16✔
4154
  return code;
16✔
4155
}
4156

4157
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pRsp) {
58,413✔
4158
  int32_t                 code = -1;
58,413✔
4159
  SDecoder                decoder = {0};
58,413✔
4160
  SMnode                 *pMnode = pRsp->info.node;
58,413✔
4161
  SVFetchTtlExpiredTbsRsp rsp = {0};
58,413✔
4162
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
58,413✔
4163
  if (pRsp->code != TSDB_CODE_SUCCESS) {
58,413✔
4164
    code = pRsp->code;
169✔
4165
    goto _end;
169✔
4166
  }
4167
  if (pRsp->contLen == 0) {
58,244✔
4168
    code = 0;
58,228✔
4169
    goto _end;
58,228✔
4170
  }
4171

4172
  tDecoderInit(&decoder, pRsp->pCont, pRsp->contLen);
16✔
4173
  code = tDecodeVFetchTtlExpiredTbsRsp(&decoder, &rsp);
16✔
4174
  if (code) goto _end;
16!
4175

4176
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
16✔
4177
  if (code) goto _end;
16!
4178

4179
  code = mndDropTbForSingleVg(pMnode, pCtx, rsp.pExpiredTbs, rsp.vgId);
16✔
4180
  if (code) goto _end;
16!
4181
  code = mndCreateDropTbsTxnPrepare(pRsp, pCtx);
16✔
4182
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
16✔
4183
_end:
5✔
4184
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
58,413✔
4185
  tDecoderClear(&decoder);
58,413✔
4186
  tFreeFetchTtlExpiredTbsRsp(&rsp);
58,413✔
4187
  TAOS_RETURN(code);
58,413✔
4188
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc