16597714186

Committed 29 Jul 2025 01:36PM UTC coverage: 72.977%. Remained the same

Build # 16597714186

Build Type

push

github

Committed by

torand

Commit Message

fix: add parentheses around negated predicate

Run Details

234 of 378 branches covered (61.9%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

1308 of 1735 relevant lines covered (75.39%)

3.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0

/src/main/java/io/github/torand/fastersql/predicate/compound/Or.java

/*
 * Copyright (c) 2024-2025 Tore Eide Andersen
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package io.github.torand.fastersql.predicate.compound;

import io.github.torand.fastersql.alias.ColumnAlias;
import io.github.torand.fastersql.model.Column;
import io.github.torand.fastersql.predicate.Predicate;
import io.github.torand.fastersql.sql.Context;
import io.github.torand.fastersql.sql.Sql;

import java.util.List;
import java.util.stream.Stream;

import static io.github.torand.javacommons.collection.CollectionHelper.asList;
import static io.github.torand.javacommons.contract.Requires.requireNonEmpty;
import static java.util.stream.Collectors.joining;

/**
 * Implements the compound predicate using the boolean operator OR on its operands.
 */
public class Or implements Predicate {
    private final List<Predicate> operands;

    Or(Predicate... operands) {
        this.operands = asList(requireNonEmpty(operands, "No operands specified"));
    }

    // Sql

    @Override
    public String sql(Context context) {
        return operands.stream().map(e -> e.sql(context)).collect(joining(" or "));
    }

    @Override
    public Stream<Object> params(Context context) {
        return operands.stream().flatMap(o -> o.params(context));
    }

    @Override
    public Stream<Column> columnRefs() {
        return operands.stream().flatMap(Sql::columnRefs);
    }

    @Override
    public Stream<ColumnAlias> aliasRefs() {
        return operands.stream().flatMap(Sql::aliasRefs);
    }

    // Predicate

    @Override
    public String negatedSql(Context context) {
        return "not (" + sql(context) + ")";
    }
}

1	/*
2	* Copyright (c) 2024-2025 Tore Eide Andersen
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package io.github.torand.fastersql.predicate.compound;
17
18	import io.github.torand.fastersql.alias.ColumnAlias;
19	import io.github.torand.fastersql.model.Column;
20	import io.github.torand.fastersql.predicate.Predicate;
21	import io.github.torand.fastersql.sql.Context;
22	import io.github.torand.fastersql.sql.Sql;
23
24	import java.util.List;
25	import java.util.stream.Stream;
26
27	import static io.github.torand.javacommons.collection.CollectionHelper.asList;
28	import static io.github.torand.javacommons.contract.Requires.requireNonEmpty;
29	import static java.util.stream.Collectors.joining;
30
31	/**
32	* Implements the compound predicate using the boolean operator OR on its operands.
33	*/
34	public class Or implements Predicate {
35	private final List<Predicate> operands;
36
37	Or(Predicate... operands) {	2✔
38	this.operands = asList(requireNonEmpty(operands, "No operands specified"));	9✔
39	}	1✔
40
41	// Sql
42
43	@Override
44	public String sql(Context context) {
45	return operands.stream().map(e -> e.sql(context)).collect(joining(" or "));	15✔
46	}
47
48	@Override
49	public Stream<Object> params(Context context) {
50	return operands.stream().flatMap(o -> o.params(context));	11✔
51	}
52
53	@Override
54	public Stream<Column> columnRefs() {
55	return operands.stream().flatMap(Sql::columnRefs);	6✔
56	}
57
58	@Override
59	public Stream<ColumnAlias> aliasRefs() {
60	return operands.stream().flatMap(Sql::aliasRefs);	×
61	}
62
63	// Predicate
64
65	@Override
66	public String negatedSql(Context context) {
NEW 67	return "not (" + sql(context) + ")";	×
68	}
69	}

torand / FasterSQL / 16597714186

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous