1c8cfbce0d0b9400324380e1ba82321290fe534d

Committed 27 Jul 2025 02:43PM UTC coverage: 81.516% (-0.2%) from 81.695%

Build # 1c8cfbce0d0b9400324380e1ba82321290fe534d

Build Type

Pull #72

github

Committed by

camatcode

Commit Message

perf: introduce reader telemetry

Pull Request Pull Request #72: perf: introduce telemetry

Run Details

53 of 65 new or added lines in 12 files covered. (81.54%)

18 existing lines in 2 files now uncovered.

1151 of 1412 relevant lines covered (81.52%)

490.18 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.33

/lib/basenji/reader/cbr_reader.ex

defmodule Basenji.Reader.CBRReader do
  @moduledoc false
  use Basenji.TelemetryHelpers

  import Basenji.Reader

  def format, do: :cbr
  def file_extensions, do: ["cbr"]
  def close(_any), do: :ok

  def get_magic_numbers, do: [%{offset: 0, magic: [0x52, 0x61, 0x72, 0x21, 0x1A, 0x07]}]

  def get_entries(cbr_file_path, _opts \\ []) do
    with {:ok, output} <- exec("unrar", ["lb", cbr_file_path]) do
      file_names = String.split(output, "\n")

      file_entries =
        file_names
        |> Enum.map(&%{file_name: &1})
        |> sort_file_names()
        |> reject_macos_preview()
        |> reject_directories()
        |> reject_non_image()

      {:ok, %{entries: file_entries}}
    end
  end

  def get_entry_stream!(cbr_file_path, entry) do
    create_resource(fn ->
      escaped_filename = entry[:file_name]

      with {:ok, output} <- exec("unrar", ["p", cbr_file_path, escaped_filename]) do
        [output |> :binary.bin_to_list()]
      end
    end)
  end

  def read(cbr_file_path, _opts \\ []) do
    telemetry_wrap [:basenji, :process], %{action: "read_cbr"} do
      with {:ok, %{entries: file_entries}} <- get_entries(cbr_file_path) do
        file_entries =
          file_entries
          |> Enum.map(fn entry ->
            entry
            |> Map.put(:stream_fun, fn -> get_entry_stream!(cbr_file_path, entry) end)
          end)

        {:ok, %{entries: file_entries}}
      end
    end
  end
end

1	defmodule Basenji.Reader.CBRReader do
2	@moduledoc false
3	use Basenji.TelemetryHelpers
4
5	import Basenji.Reader
6
7	def format, do: :cbr	6✔
8	def file_extensions, do: ["cbr"]	3,172✔
9	def close(_any), do: :ok	6✔
10
11	def get_magic_numbers, do: [%{offset: 0, magic: [0x52, 0x61, 0x72, 0x21, 0x1A, 0x07]}]	778✔
12
13	def get_entries(cbr_file_path, _opts \\ []) do
14	with {:ok, output} <- exec("unrar", ["lb", cbr_file_path]) do	780✔
15	file_names = String.split(output, "\n")	780✔
16
17	file_entries =	780✔
18	file_names
19	\|> Enum.map(&%{file_name: &1})	3,120✔
20	\|> sort_file_names()
21	\|> reject_macos_preview()
22	\|> reject_directories()
23	\|> reject_non_image()
24
25	{:ok, %{entries: file_entries}}
26	end
27	end
28
29	def get_entry_stream!(cbr_file_path, entry) do
30	create_resource(fn ->	75✔
31	escaped_filename = entry[:file_name]	75✔
32
33	with {:ok, output} <- exec("unrar", ["p", cbr_file_path, escaped_filename]) do	75✔
34	[output \|> :binary.bin_to_list()]
35	end
36	end)
37	end
38
39	def read(cbr_file_path, _opts \\ []) do
40	telemetry_wrap [:basenji, :process], %{action: "read_cbr"} do	779✔
NEW 41	with {:ok, %{entries: file_entries}} <- get_entries(cbr_file_path) do	×
42	file_entries =	779✔
43	file_entries
44	\|> Enum.map(fn entry ->
45	entry
46	\|> Map.put(:stream_fun, fn -> get_entry_stream!(cbr_file_path, entry) end)	3,116✔
47	end)
48
49	{:ok, %{entries: file_entries}}
50	end
51	end
52	end
53	end

camatcode / basenji / 1c8cfbce0d0b9400324380e1ba82321290fe534d

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous