facebookincubator / TTPForge / 16429055613

Pull #545

github

Kill Process Improvements (#545)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/545

### Context
Currently the `kill_process` action in TTPForge in cases of failure like `Couldn't find process` and `Couldn't kill process` by default throws an exception which leads to TTP being stopped. While this could be a valid usecase in some situations, allowing user control on whether to throw an error or to print an error and return normally helps make the code versatile.

Following is the decision making in the initial commit of Kill Process Action: [link](https://app.diagrams.net/#G1A4S3RgNffbaMbp40RCpqvmprH1QQvVvi#%7B%22pageId%22%3A%22CNsj_rZLfA5pAP3afiLK%22%7D)
https://pxl.cl/7Lcn3
This flow diagram shows the updated decision making: [link](https://app.diagrams.net/?title=Kill%20Process%20Updated%20Decision%20making.drawio&client=1#G1TePfzl48hKjTKe-K-efOH8F-ASMror7j#%7B%22pageId%22%3A%22CNsj_rZLfA5pAP3afiLK%22%7D)
https://pxl.cl/7Lcmh

### Changes

*   **Code Improvements**: The `kill_process` step has been updated to receive user inputs on actions to take in case of failures like `error_on_find_process_failure` and `error_on_kill_failure`. This facilitates increased control on the code flow by the user to satisfy different needs.
*   **Documentation**: Added an example TTP for reference on the use of the new user inputs for the step `kill_process`.
*   **Testing**: Additional test cases have been added to verify the functionality of the added flags on the `kill_process` step.

### Impact

*   **Improved Usability**: The changes in this diff make it easier for users to control the output of the step on the basis of their needs. (Ignoring or throwing exceptions in cases of failure)

Reviewed By: d0n601

Differential Revision: D78521586

26 of 30 new or added lines in 2 files covered. (86.67%)

2385 of 3594 relevant lines covered (66.36%)

16.43 hits per line